Hi Jiri,
Please follow the process described in the "stable release" paragraph at:
https://core.dpdk.org/contribute/
ie, one patch per affected LTS branch must be prepared, tested and
sent individually, and then we'll apply it. Thanks.
On Thu, 18 Jul 2024 at 10:16, Thomas Monjalon wrote:
>
> A
Adding sta...@dpdk.org and LTS maintainers as Cc.
It must be merged directly in LTS branches.
16/07/2024 10:44, Jiri Slaby:
> 6.10 removed the "support" (it was never supported [1]) of separate
> source and build dirs for out of tree modules.
>
> KNI uses "src=" hack for that purpose.
>
> Inste
6.10 removed the "support" (it was never supported [1]) of separate
source and build dirs for out of tree modules.
KNI uses "src=" hack for that purpose.
Instead, copy sources to the build dir and don't rely upon the
unsupported...
Intended esp. for stable/22.11. It should go wherever kni is sti
11/07/2023 12:09, Ferruh Yigit:
> The get_user_pages_remote() API has been modified in Linux kernel v6.5
> [1], "struct vm_area_struct **vmas" parameter removed from the API.
>
> To fix KNI build with Linux kernel v6.5, version check added around the
> get_user_pages_remote() API.
>
> [1]
> ca5e8
The get_user_pages_remote() API has been modified in Linux kernel v6.5
[1], "struct vm_area_struct **vmas" parameter removed from the API.
To fix KNI build with Linux kernel v6.5, version check added around the
get_user_pages_remote() API.
[1]
ca5e863233e8 ("mm/gup: remove vmas parameter from get
On 3/20/2023 1:01 PM, David Marchand wrote:
> On Mon, Mar 20, 2023 at 1:10 PM David Marchand
> wrote:
>>
>> On Tue, Feb 28, 2023 at 9:45 PM David Marchand
>> wrote:
>>>
>>> On Tue, Feb 28, 2023 at 6:29 PM Ferruh Yigit wrote:
KNI calls `get_user_pages_remote()` API which is using `FOLL_
On Fri, Mar 24, 2023 at 4:04 AM Vamsi Krishna Attunuru
wrote:
> > > So I think the dpdk commit e73831dc6c26 ("kni: support userspace VA")
> > > uselessly introduced call to this flag and we can remove it.
> > > Adding author and reviewers of this change.
> >
> > Alternatively, we could go with pas
> -Original Message-
> From: David Marchand
> Sent: Monday, March 20, 2023 6:31 PM
> To: Ferruh Yigit ; Vamsi Krishna Attunuru
> ; Kiran Kumar Kokkilagadda
> ; Jerin Jacob Kollanukkaran
>
> Cc: dev@dpdk.org; Thomas Monjalon
> Subject: [EXT] Re: [PATCH] kn
On Mon, Mar 20, 2023 at 1:10 PM David Marchand
wrote:
>
> On Tue, Feb 28, 2023 at 9:45 PM David Marchand
> wrote:
> >
> > On Tue, Feb 28, 2023 at 6:29 PM Ferruh Yigit wrote:
> > >
> > > KNI calls `get_user_pages_remote()` API which is using `FOLL_TOUCH`
> > > flag, but `FOLL_TOUCH` is no more in
On Tue, Feb 28, 2023 at 9:45 PM David Marchand
wrote:
>
> On Tue, Feb 28, 2023 at 6:29 PM Ferruh Yigit wrote:
> >
> > KNI calls `get_user_pages_remote()` API which is using `FOLL_TOUCH`
> > flag, but `FOLL_TOUCH` is no more in public headers since v6.3,
> > causing a build error.
>
> Something lo
On Tue, Feb 28, 2023 at 6:29 PM Ferruh Yigit wrote:
>
> KNI calls `get_user_pages_remote()` API which is using `FOLL_TOUCH`
> flag, but `FOLL_TOUCH` is no more in public headers since v6.3,
> causing a build error.
Something looks strange with what kni was doing.
Looking at get_user_pages_remote
KNI calls `get_user_pages_remote()` API which is using `FOLL_TOUCH`
flag, but `FOLL_TOUCH` is no more in public headers since v6.3,
causing a build error.
`FOLL_*` defines in Linux kernel first moved to another header [1],
later some of them moved to memory subsystem internal header [2] for 6.3
Q
On Mon, Jan 9, 2023 at 10:07 AM David Marchand
wrote:
>
> Hi Ferruh,
>
> On Fri, Jan 6, 2023 at 9:13 PM Ferruh Yigit wrote:
> >
> > Linux kernel in the RHEL9.1 seems backported Linux commit [1] that drops
> > netif_rx_ni().
> >
> > This was fixed in DPDK [2] for vanilla Linux kernel.
> >
> > Addi
Hi Ferruh,
On Fri, Jan 6, 2023 at 9:13 PM Ferruh Yigit wrote:
>
> Linux kernel in the RHEL9.1 seems backported Linux commit [1] that drops
> netif_rx_ni().
>
> This was fixed in DPDK [2] for vanilla Linux kernel.
>
> Adding RHEL9.1 check for the netif_rx_ni() usage to fix build error.
>
> [1]
> 2
> From: Ferruh Yigit
> Sent: 2023年1月7日 4:13
> To: Thomas Monjalon
> Cc: David Marchand ; dev@dpdk.org;
> sta...@dpdk.org; Gao, DaxueX
> Subject: [PATCH] kni: fix build on RHEL 9.1
>
> Linux kernel in the RHEL9.1 seems backported Linux commit [1] that drops
> netif_r
Linux kernel in the RHEL9.1 seems backported Linux commit [1] that drops
netif_rx_ni().
This was fixed in DPDK [2] for vanilla Linux kernel.
Adding RHEL9.1 check for the netif_rx_ni() usage to fix build error.
[1]
2655926aea9b ("net: Remove netif_rx_any_context() and netif_rx_ni().")
[2]
Commit
A previous fix had #else instead of #endif.
The error message is:
kernel/linux/kni/kni_net.c: In function ‘kni_net_rx_normal’:
kernel/linux/kni/kni_net.c:448:2: error: #else after #else
Bugzilla ID: 1025
Fixes: c98600d4bed6 ("kni: fix build with Linux 5.18")
Cc: sta...@dpdk.org
Si
Since commit 2655926aea9b (net: Remove netif_rx_any_context() and
netif_rx_ni().) in 5.18, netif_rx_ni() no longer exists as netif_rx()
can be called from any context. So define HAVE_NETIF_RX_NI for older
releases and call the appropriate function in kni_net.
Cc: sta...@dpdk.org
Signed-off-by: Jir
On 9/9/2020 12:59 PM, Min Hu (Connor) wrote:
> Build error seen with Linux kernel 5.9.
>
> Build error:
> kernel/linux/kni/kni_dev.h:104:30:
> error: passing argument 1 of ‘get_user_pages_remote’ from
> incompatible pointer type [-Werror=incompatible-pointer-types]
> ret = get_us
Build error seen with Linux kernel 5.9.
Build error:
kernel/linux/kni/kni_dev.h:104:30:
error: passing argument 1 of ‘get_user_pages_remote’ from
incompatible pointer type [-Werror=incompatible-pointer-types]
ret = get_user_pages_remote(tsk, tsk->mm, iova, 1,
get_user_page
Starting from Linux 5.9 'get_user_pages_remote()' API doesn't get
'struct task_struct' parameter:
commit 64019a2e467a ("mm/gup: remove task_struct pointer for all gup code")
The change reflected to the KNI with version check.
Signed-off-by: Ferruh Yigit
---
kernel/linux/kni/compat.h | 4
On Wed, Feb 12, 2020 at 6:14 PM Ferruh Yigit wrote:
>
> With the following Linux commit a new parameter 'txqueue' has been added
> to 'ndo_tx_timeout' ndo:
> commit 0290bd291cc0 ("netdev: pass the stuck queue to the timeout handler")
>
> The change reflected to the KNI with version check.
>
> Cc:
With the following Linux commit a new parameter 'txqueue' has been added
to 'ndo_tx_timeout' ndo:
commit 0290bd291cc0 ("netdev: pass the stuck queue to the timeout handler")
The change reflected to the KNI with version check.
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
kernel/linux/kni
On Thu, Nov 28, 2019 at 2:43 PM Andrew Rybchenko
wrote:
> On 11/28/19 3:15 PM, Ferruh Yigit wrote:
> > The 'get_user_pages_remote()' API is updated in kernel 4.10.0 [1],
> > but the check added as > 4.9.0,
> > this logic is broken for kernels 4.9.x, because they justify
> >> 4.9.0 check but have t
On 11/28/19 3:15 PM, Ferruh Yigit wrote:
> The 'get_user_pages_remote()' API is updated in kernel 4.10.0 [1],
> but the check added as > 4.9.0,
> this logic is broken for kernels 4.9.x, because they justify
>> 4.9.0 check but have the old API.
> Fixing the check as >= 4.10.0
>
> [1]
> commit 5b56d4
The 'get_user_pages_remote()' API is updated in kernel 4.10.0 [1],
but the check added as > 4.9.0,
this logic is broken for kernels 4.9.x, because they justify
> 4.9.0 check but have the old API.
Fixing the check as >= 4.10.0
[1]
commit 5b56d49fc31d ("mm: add locked parameter to get_user_pages_re
On 04/06/2019 16:00, Ferruh Yigit wrote:
> On 5/29/2019 10:48 PM, Thomas Monjalon wrote:
>> 27/05/2019 06:02, michael@intel.com:
>>> From: Luo Gaoliang
>>>
>>> Build error was seen on RHEL8 when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
>>>
>>> Build error log:
>>> /root/kni/dpdk-19.05/kernel/li
On 5/29/2019 10:48 PM, Thomas Monjalon wrote:
> 27/05/2019 06:02, michael@intel.com:
>> From: Luo Gaoliang
>>
>> Build error was seen on RHEL8 when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
>>
>> Build error log:
>> /root/kni/dpdk-19.05/kernel/linux/kni/ethtool/igb/kcompat.h:3928:25:
>> error: '
27/05/2019 06:02, michael@intel.com:
> From: Luo Gaoliang
>
> Build error was seen on RHEL8 when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
>
> Build error log:
> /root/kni/dpdk-19.05/kernel/linux/kni/ethtool/igb/kcompat.h:3928:25:
> error: 'const struct net_device_ops' has no member named 'ext
From: Luo Gaoliang
Build error was seen on RHEL8 when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
Build error log:
/root/kni/dpdk-19.05/kernel/linux/kni/ethtool/igb/kcompat.h:3928:25:
error: 'const struct net_device_ops' has no member named 'extended'
#define ndo_set_vf_vlan extended.ndo_set_vf_vla
09/04/2019 19:59, Rami Rosen:
> On Mon, Apr 08, 2019 at 03:22:26PM +0100, Ferruh Yigit wrote:
> > Build error seen with Linux kernel 5.1 and
> > when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
> >
> > Build error:
> > .../dpdk/build/build/kernel/linux/kni/igb_main.c:2352:18:
> > error: initializatio
On Mon, Apr 08, 2019 at 03:22:26PM +0100, Ferruh Yigit wrote:
> Build error seen with Linux kernel 5.1 and
> when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
>
> Build error:
> .../dpdk/build/build/kernel/linux/kni/igb_main.c:2352:18:
> error: initialization of ... from incompatible pointer type ...
On Mon, Apr 08, 2019 at 03:22:26PM +0100, Ferruh Yigit wrote:
> Build error seen with Linux kernel 5.1 and
> when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
>
> Build error:
> .../dpdk/build/build/kernel/linux/kni/igb_main.c:2352:18:
> error: initialization of ... from incompatible pointer type ...
Build error seen with Linux kernel 5.1 and
when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
Build error:
.../dpdk/build/build/kernel/linux/kni/igb_main.c:2352:18:
error: initialization of ... from incompatible pointer type ...
[-Werror=incompatible-pointer-types]
.ndo_fdb_add = igb_ndo_fdb_ad
21/12/2018 18:02, Ferruh Yigit:
> On 12/21/2018 4:27 PM, David Zeng wrote:
> > Signed-off-by: David Zeng
>
> Acked-by: Ferruh Yigit
Applied on top of another fix:
http://git.dpdk.org/dpdk/commit/?id=4c820b22
and renamed:
kni: fix build on RHEL8 for arm and Power9
Thanks
On 12/21/2018 4:27 PM, David Zeng wrote:
> Signed-off-by: David Zeng
Acked-by: Ferruh Yigit
Signed-off-by: David Zeng
---
kernel/linux/kni/compat.h | 9 -
kernel/linux/kni/ethtool/igb/kcompat.h | 4 +++-
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
index 5aadebb..3c575c7 100644
--- a/kernel/lin
On 12/21/2018 4:15 PM, David Zeng wrote:
> Signed-off-by: David Zeng
Acked-by: Ferruh Yigit
Thanks, Ferruh!
Signed-off-by: David Zeng
---
kernel/linux/kni/compat.h | 9 -
kernel/linux/kni/ethtool/igb/kcompat.h | 4 +++-
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
index 5aadebb..3c575c7 100644
--- a/kernel/lin
On 12/21/2018 6:03 AM, David Zeng wrote:
> Signed-off-by: David Zeng
> ---
> kernel/linux/kni/compat.h | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
> index 5aadebb..1afa3b8 100644
> --- a/kernel/linux/kni/co
Signed-off-by: David Zeng
---
kernel/linux/kni/compat.h | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
index 5aadebb..1afa3b8 100644
--- a/kernel/linux/kni/compat.h
+++ b/kernel/linux/kni/compat.h
@@ -102,8 +102,14
On 11/27/2018 1:38 PM, Ferruh Yigit wrote:
> On 11/27/2018 11:13 AM, Mohammed Gamal wrote:
>> On Tue, 2018-11-27 at 10:55 +, Ferruh Yigit wrote:
>>> On 11/26/2018 8:45 PM, Mohammed Gamal wrote:
As RHEL8 beta has been released and is based on recent upstream
kernels
which don't us
On 11/27/2018 11:13 AM, Mohammed Gamal wrote:
> On Tue, 2018-11-27 at 10:55 +, Ferruh Yigit wrote:
>> On 11/26/2018 8:45 PM, Mohammed Gamal wrote:
>>> As RHEL8 beta has been released and is based on recent upstream
>>> kernels
>>> which don't use ndo_change_mtu_rh74 function. Fix the build so t
On Tue, 2018-11-27 at 10:55 +, Ferruh Yigit wrote:
> On 11/26/2018 8:45 PM, Mohammed Gamal wrote:
> > As RHEL8 beta has been released and is based on recent upstream
> > kernels
> > which don't use ndo_change_mtu_rh74 function. Fix the build so that
> > it
> > doesn't fail because the function
On 11/26/2018 8:45 PM, Mohammed Gamal wrote:
> As RHEL8 beta has been released and is based on recent upstream kernels
> which don't use ndo_change_mtu_rh74 function. Fix the build so that it
> doesn't fail because the function is missing
>
> Signed-off-by: Mohammed Gamal
> ---
> kernel/linux/kn
As RHEL8 beta has been released and is based on recent upstream kernels
which don't use ndo_change_mtu_rh74 function. Fix the build so that it
doesn't fail because the function is missing
Signed-off-by: Mohammed Gamal
---
kernel/linux/kni/compat.h | 3 ++-
1 file changed, 2 insertions(+), 1 dele
27/10/2018 00:42, Ferruh Yigit:
> On 10/26/2018 10:56 PM, Thomas Monjalon wrote:
> > 26/10/2018 23:40, Thomas Monjalon:
> >> The atomic functions smp_load_acquire() and smp_store_release()
> >> were introduced in Linux 3.14. Older kernels miss the functions:
> >>
> >> kni_fifo.h:19:2: error:
> >>
On 10/26/2018 10:56 PM, Thomas Monjalon wrote:
> 26/10/2018 23:40, Thomas Monjalon:
>> The atomic functions smp_load_acquire() and smp_store_release()
>> were introduced in Linux 3.14. Older kernels miss the functions:
>>
>> kni_fifo.h:19:2: error:
>> implicit declaration of function ‘smp_load
26/10/2018 23:40, Thomas Monjalon:
> The atomic functions smp_load_acquire() and smp_store_release()
> were introduced in Linux 3.14. Older kernels miss the functions:
>
> kni_fifo.h:19:2: error:
> implicit declaration of function ‘smp_load_acquire’
> kni_fifo.h:30:2: error:
> implicit
The atomic functions smp_load_acquire() and smp_store_release()
were introduced in Linux 3.14. Older kernels miss the functions:
kni_fifo.h:19:2: error:
implicit declaration of function ‘smp_load_acquire’
kni_fifo.h:30:2: error:
implicit declaration of function ‘smp_store_release’
The build error observed with Linux kernel 4.19 when KNI ethtool
support enabled (CONFIG_RTE_KNI_KMOD_ETHTOOL=y)
.../build/build/kernel/linux/kni/kni_ethtool.c:193:3:
error: ‘struct ethtool_ops’ has no member named ‘get_settings’;
.get_settings = kni_get_settings,
^~~~
.../build/
Sorry for my mistake,
This patch fixes compilation errors on Centos 7.5 when
CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'.
On RHEL75 ndo_change_mtu has changed to ndo_change_mtu_rh74.
See commit 37d477b6863e5c06e20be434b559d3a03d89f46a
-- Drocula Lambda
Thanks
On Aug 9, 2018 18:25, "Drocula" wro
This patch Fix compilation errors on Centos 7.4 when
CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'.
On Thu, Aug 9, 2018, 17:59 Ferruh Yigit wrote:
> On 8/6/2018 1:06 PM, Drocula wrote:
> > Signed-off-by: Drocula
>
> +1 for fixing build error, hence
> Acked-by: Ferruh Yigit
>
> But it would be bett
On 8/6/2018 1:06 PM, Drocula wrote:
> Signed-off-by: Drocula
+1 for fixing build error, hence
Acked-by: Ferruh Yigit
But it would be better to have more detail on the build error, why and when this
change required in RedHat side, it would be good if this information can make on
time, but not I
Signed-off-by: Drocula
---
kernel/linux/kni/ethtool/igb/kcompat.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/kernel/linux/kni/ethtool/igb/kcompat.h
b/kernel/linux/kni/ethtool/igb/kcompat.h
index 40a8d99..ae1b530 100644
--- a/kernel/linux/kni/ethtool/igb/kcompat.h
+++ b/kernel/linux
On 6/20/2018 5:39 PM, Ferruh Yigit wrote:
> On 6/20/2018 12:35 AM, Stephen Hemminger wrote:
>> On Tue, 19 Jun 2018 13:08:55 +0100
>> Ferruh Yigit wrote:
>>
>>> Error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option is
>>> enabled.
>>>
>>> build error:
>>> In function ‘strncpy’,
>>> inli
org
>> Subject: [dpdk-stable] [PATCH] kni: fix build with gcc 8.1
>>
>> Error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option is
>> enabled.
>>
>> build error:
>> In function ‘strncpy’,
>> inlined from ‘igb_get_drvinfo’ at
>> .../dpdk
On 6/20/2018 12:35 AM, Stephen Hemminger wrote:
> On Tue, 19 Jun 2018 13:08:55 +0100
> Ferruh Yigit wrote:
>
>> Error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option is
>> enabled.
>>
>> build error:
>> In function ‘strncpy’,
>> inlined from ‘igb_get_drvinfo’ at
>> .../dpdk/build/
> -Original Message-
> From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Tuesday, June 19, 2018 1:09 PM
> To: Yigit, Ferruh
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [dpdk-stable] [PATCH] kni: fix build with gcc 8.1
>
On Tue, 19 Jun 2018 13:08:55 +0100
Ferruh Yigit wrote:
> Error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option is
> enabled.
>
> build error:
> In function ‘strncpy’,
> inlined from ‘igb_get_drvinfo’ at
> .../dpdk/build/build/kernel/linux/kni/igb_ethtool.c:814:2:
> .../includ
Error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option is
enabled.
build error:
In function ‘strncpy’,
inlined from ‘igb_get_drvinfo’ at
.../dpdk/build/build/kernel/linux/kni/igb_ethtool.c:814:2:
.../include/linux/string.h:246:9: error: ‘__builtin_strncpy’ output
may be trun
On 5/22/2018 1:18 AM, Dan Gora wrote:
> Fix compilation errors on Centos 7.4 when CONFIG_RTE_KNI_KMOD_ETHTOOL
> is set to 'y'.
>
> Centos 7.4 needs HAVE_NDO_BRIDGE_GETLINK_FILTER_MASK_VLAN_FILL:
>
> igb_main.c: In function ‘igb_ndo_bridge_getlink’:
> igb_main.c:2289:2: error: too few arguments to
Fix compilation errors on Centos 7.4 when CONFIG_RTE_KNI_KMOD_ETHTOOL
is set to 'y'.
Centos 7.4 needs HAVE_NDO_BRIDGE_GETLINK_FILTER_MASK_VLAN_FILL:
igb_main.c: In function ‘igb_ndo_bridge_getlink’:
igb_main.c:2289:2: error: too few arguments to function
‘ndo_dflt_bridge_getlin
> > kni library has a dependency to new PCI library, adding that dependency.
> >
> > build error:
> > CC rte_kni.o
> > In file included from dpdk/lib/librte_kni/rte_kni.c:48:0:
> > dpdk/build/include/rte_kni.h:49:21:
> > fatal error: rte_pci.h: No such file or directory
> > #include
> >
Hi Ferruh,
> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, December 12, 2017 6:40 PM
> To: Yigit, Ferruh
> Cc: dev@dpdk.org; Iremonger, Bernard ;
> sta...@dpdk.org
> Subject: [PATCH] kni: fix build dependency
>
> kni library has a dependency to n
29/11/2017 00:45, Ferruh Yigit:
> build error:
> .../dpdk/build/build/lib/librte_eal/linuxapp/kni/igb_main.c:2809:2:
> error: implicit declaration of function ‘setup_timer’;
> did you mean ‘sk_stop_timer’? [-Werror=implicit-function-declaration]
> setup_timer(&adapter->watchdog_timer, &igb_watc
kni library has a dependency to new PCI library, adding that dependency.
build error:
CC rte_kni.o
In file included from dpdk/lib/librte_kni/rte_kni.c:48:0:
dpdk/build/include/rte_kni.h:49:21:
fatal error: rte_pci.h: No such file or directory
#include
^
Fixes: c7
build error:
.../dpdk/build/build/lib/librte_eal/linuxapp/kni/igb_main.c:2809:2:
error: implicit declaration of function ‘setup_timer’;
did you mean ‘sk_stop_timer’? [-Werror=implicit-function-declaration]
setup_timer(&adapter->watchdog_timer, &igb_watchdog,
^~~
sk_stop_timer
cc1: a
Hi Nirmoy,
On 8/15/2017 10:58 AM, Nirmoy Das wrote:
> compilation error:
> build/lib/librte_eal/linuxapp/kni/kni_net.c:215:5: error: ‘struct net_device’
> has no member named ‘trans_start’
Commit log is too long, can you please break this line.
> dev->trans_start = jiffies;
>
> Signed-off-by
compilation error:
build/lib/librte_eal/linuxapp/kni/kni_net.c:215:5: error: ‘struct net_device’
has no member named ‘trans_start’
dev->trans_start = jiffies;
Signed-off-by: Nirmoy Das
---
lib/librte_eal/linuxapp/kni/compat.h | 32 +++-
1 file changed, 31 insertion
Hello,
>
> compile error:
> .../build/build/lib/librte_eal/linuxapp/kni/kni_net.c:124:6:
> error: implicit declaration of function ‘signal_pending’
> [-Werror=implicit-function-declaration]
> if (signal_pending(current) || ret_val <= 0) {
> ^~
>
> Linux 4.11 moves signal fun
On Mon, Mar 20, 2017 at 11:22:08AM +, Ferruh Yigit wrote:
> compile error:
> .../build/build/lib/librte_eal/linuxapp/kni/kni_net.c:124:6:
> error: implicit declaration of function ‘signal_pending’
> [-Werror=implicit-function-declaration]
> if (signal_pending(current) || ret_val <= 0) {
>
compile error:
.../build/build/lib/librte_eal/linuxapp/kni/kni_net.c:124:6:
error: implicit declaration of function ‘signal_pending’
[-Werror=implicit-function-declaration]
if (signal_pending(current) || ret_val <= 0) {
^~
Linux 4.11 moves signal function declarations to its ow
> > compile error:
> > CC [M] .../lib/librte_eal/linuxapp/kni/igb_main.o
> > .../lib/librte_eal/linuxapp/kni/igb_main.c:2317:21:
> > error: initialization from incompatible pointer type
> > [-Werror=incompatible-pointer-types]
> > .ndo_set_vf_vlan = igb_ndo_set_vf_vlan,
> >
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Monday, October 17, 2016 3:23 AM
> To: dev at dpdk.org
> Cc: Yigit, Ferruh
> Subject: [dpdk-dev] [PATCH] kni: fix build with kernel 4.9
>
> compile error:
>
compile error:
CC [M] .../lib/librte_eal/linuxapp/kni/igb_main.o
.../lib/librte_eal/linuxapp/kni/igb_main.c:2317:21:
error: initialization from incompatible pointer type
[-Werror=incompatible-pointer-types]
.ndo_set_vf_vlan = igb_ndo_set_vf_vlan,
^~
2016-09-16 17:09, Ferruh Yigit:
> Compile error:
> CC [M] .../build/lib/librte_eal/linuxapp/kni/igb_main.o
> .../build/lib/librte_eal/linuxapp/kni/igb_main.c:
> In function ?igb_check_swap_media?:
> .../build/lib/librte_eal/linuxapp/kni/igb_main.c:1556:7:
> error: variable ?link? set but not use
Compile error:
CC [M] .../build/lib/librte_eal/linuxapp/kni/igb_main.o
.../build/lib/librte_eal/linuxapp/kni/igb_main.c:
In function ?igb_check_swap_media?:
.../build/lib/librte_eal/linuxapp/kni/igb_main.c:1556:7:
error: variable ?link? set but not used [-Werror=unused-but-set-variable]
bool l
Linux kernel v4.8 removes macro DEFINE_PCI_DEVICE_TABLE
Linux: 7e9321599011 ("treewide: remove references to the now unnecessary
DEFINE_PCI_DEVICE_TABLE")
Added the macro to compatibility headers of the kni ethtool drivers.
Signed-off-by: Ferruh Yigit
---
lib/librte_eal/linuxapp/kni/ethtool/ig
On Thu, 8 Sep 2016 18:54:56 +0100
Ferruh Yigit wrote:
> Linux kernel v4.8 removes macro DEFINE_PCI_DEVICE_TABLE
>
> Linux: 7e9321599011 ("treewide: remove references to the now unnecessary
> DEFINE_PCI_DEVICE_TABLE")
>
> Added the macro to compatibility headers of the kni ethtool drivers.
>
>
2016-06-21 13:27, Ferruh Yigit:
> On 6/21/2016 12:43 PM, Anupam Kapoor wrote:
> > This commit fixes build errors triggered due misleading indentation.
> >
> > Fixes: 38db3f7f50bde (e1000: update base driver)
> Fixes: b9ee370557f1 ("kni: update kernel driver ethtool baseline")
>
> > Fixes: 3fc5ca2
This commit fixes build errors triggered due misleading indentation.
Fixes: 38db3f7f50bde (e1000: update base driver)
Fixes: 3fc5ca2f63529 (kni: initial import)
Signed-off-by: Anupam Kapoor
---
lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_phy.c | 6 --
lib/librte_eal/linuxapp/kni/etht
On Tue, Jun 21, 2016 at 3:40 PM, Ferruh Yigit
wrote:
> Hi Anupam,
>
> Thank you for the patch.
>
>
> On 6/21/2016 9:37 AM, Anupam Kapoor wrote:
> > This commit fixes build errors triggered due misleading indentation.
> >
> > Fixes: 366113dbfb696 (e1000: suppress misleading indentation warning)
>
This commit fixes build errors triggered due misleading indentation.
Fixes: 366113dbfb696 (e1000: suppress misleading indentation warning)
Signed-off-by: Anupam Kapoor
---
lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_phy.c | 12
lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe
On 6/21/2016 12:43 PM, Anupam Kapoor wrote:
> This commit fixes build errors triggered due misleading indentation.
>
> Fixes: 38db3f7f50bde (e1000: update base driver)
Fixes: b9ee370557f1 ("kni: update kernel driver ethtool baseline")
> Fixes: 3fc5ca2f63529 (kni: initial import)
>
>
> Signed-of
Hi Anupam,
Thank you for the patch.
On 6/21/2016 9:37 AM, Anupam Kapoor wrote:
> This commit fixes build errors triggered due misleading indentation.
>
> Fixes: 366113dbfb696 (e1000: suppress misleading indentation warning)
This looks like wrong commit id that fixed, can you please double check
On Fri, 10 Jul 2015 02:53:51 +0200
Thomas Monjalon wrote:
> 2015-07-09 10:43, Stephen Hemminger:
> > From: Stephen Hemminger
> >
> > The internal API for some functions used by KNI changes in current
> > kernel. KNI really needs to be submitted upstream (by Intel)
> > to keep it maintainable.
>
2015-07-10 07:16, De Lara Guarch, Pablo:
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> > 2015-07-09 10:43, Stephen Hemminger:
> > > From: Stephen Hemminger
> > >
> > > The internal API for some functions used by KNI changes in current
> > > kernel. KNI really needs to
Hi Thomas,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Friday, July 10, 2015 1:54 AM
> To: Stephen Hemminger
> Cc: dev at dpdk.org; Stephen Hemminger
> Subject: Re: [dpdk-dev] [PATCH] kni: fix build with Linux k
2015-07-09 10:43, Stephen Hemminger:
> From: Stephen Hemminger
>
> The internal API for some functions used by KNI changes in current
> kernel. KNI really needs to be submitted upstream (by Intel)
> to keep it maintainable.
>
> Signed-off-by: Stephen Hemminger
There was already a similar patch
From: Stephen Hemminger
The internal API for some functions used by KNI changes in current
kernel. KNI really needs to be submitted upstream (by Intel)
to keep it maintainable.
Signed-off-by: Stephen Hemminger
---
lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c | 12 +++-
lib/librte
> From CentOS 6.6, function skb_set_hash is introduced, this breaks
> the previous assumption. So modify RHEL_RELEASE_VERSION from 7.0
> to 6.6 to fix build for rte_kni.ko.
>
> Related mail from Barak Enat:
> http://dpdk.org/ml/archives/dev/2014-December/010124.html
>
> building error likes:
>
>From CentOS 6.6, function skb_set_hash is introduced, this breaks
the previous assumption. So modify RHEL_RELEASE_VERSION from 7.0
to 6.6 to fix build for rte_kni.ko.
Related mail from Barak Enat:
http://dpdk.org/ml/archives/dev/2014-December/010124.html
building error likes:
CC [M]
/root/dp
2014-12-17 11:26, Jincheng Miao:
> On 12/16/2014 11:21 PM, Thomas Monjalon wrote:
> > 2014-12-11 13:27, Jincheng Miao:
> >> RHEL6.5 kernel is based on 2.6.32. But there are two changing
> >> from 2.6.35:
> >> 1. socket struct is changed
> >> It wrappered previous wait_queue_head_t of socket to
> >>
On 12/16/2014 11:21 PM, Thomas Monjalon wrote:
> 2014-12-11 13:27, Jincheng Miao:
>> RHEL6.5 kernel is based on 2.6.32. But there are two changing
>> from 2.6.35:
>> 1. socket struct is changed
>> It wrappered previous wait_queue_head_t of socket to
>> struct socket_wq. So for the kernel older than
2014-12-11 13:27, Jincheng Miao:
> RHEL6.5 kernel is based on 2.6.32. But there are two changing
> from 2.6.35:
> 1. socket struct is changed
> It wrappered previous wait_queue_head_t of socket to
> struct socket_wq. So for the kernel older than 2.6.35, we should
> directly use socket->wait instead
RHEL6.5 kernel is based on 2.6.32. But there are two changing
from 2.6.35:
1. socket struct is changed
It wrappered previous wait_queue_head_t of socket to
struct socket_wq. So for the kernel older than 2.6.35, we should
directly use socket->wait instead.
2. new function sk_sleep()
This function i
> > Since commit 08b563ffb19 ("mbuf: replace data pointer by an offset"),
> > KNI vhost compilation (CONFIG_RTE_KNI_VHOST=y) was broken.
> >
> > rte_pktmbuf_mtod() is not used in the kernel context but is replaced
> > by a simple addition of the base address and the offset.
> >
> > Signed-off-by:
Hi Thomas,
On 11/07/2014 03:51 PM, Thomas Monjalon wrote:
> Since commit 08b563ffb19 ("mbuf: replace data pointer by an offset"),
> KNI vhost compilation (CONFIG_RTE_KNI_VHOST=y) was broken.
>
> rte_pktmbuf_mtod() is not used in the kernel context but is replaced
> by a simple addition of the bas
1 - 100 of 114 matches
Mail list logo
