LGTM,
Acked-by: Huisong Li
在 2025/4/2 20:42, Dengdui Huang 写道:
When the process address space is insufficient,
mmap will fail, which will cause an infinite loop.
This pathc fix it.
Fixes: c4b89ecb64ea ("eal: introduce memory management wrappers")
Cc: sta...@dpdk.org
Signed-off-by: Dengdui Hu
在 2025/4/16 8:06, Stephen Hemminger 写道:
On Tue, 15 Apr 2025 21:28:07 +0800
"lihuisong (C)" wrote:
Hi Stephen,
The main cause of cpfl driver attach failure is the added alarm in new
event callback to setup port automatically.
It's a question of when to set up the new port.
Hi Stephen,
The main cause of cpfl driver attach failure is the added alarm in new
event callback to setup port automatically.
It's a question of when to set up the new port. Please see the
discussion[1]. I have a stupid method, but I'm not very willing to do that.
For the Bugzilla id1695, I'l
在 2025/4/2 16:47, Jie Hai 写道:
I am moving on to other things and dengdui is going to
take over the role of hns3 maintainer. Update the
MAINTAINERS accordingly.
Signed-off-by: Jie Hai
Thanks for your contributions to hns3.
Acked-by: Huisong Li
---
MAINTAINERS | 2 +-
1 file changed, 1 i
+Stephen
在 2025/4/2 11:29, Jie Hai 写道:
Update maintainer for the hns3 driver.
Signed-off-by: Jie Hai
Thanks for your contributions to hns3.
Acked-by: Huisong Li
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4b01103f
在 2025/2/24 19:12, Konstantin Ananyev 写道:
在 2025/2/20 17:41, Konstantin Ananyev 写道:
Hi
Hi all,
Kindly ping for review.
在 2024/12/19 15:53, Huisong Li 写道:
The queue_list_entry structure data is used in rx_callback of io path
when enable PMD Power Management. However its memory is curren
在 2025/2/20 17:41, Konstantin Ananyev 写道:
Hi
Hi all,
Kindly ping for review.
在 2024/12/19 15:53, Huisong Li 写道:
The queue_list_entry structure data is used in rx_callback of io path
when enable PMD Power Management. However its memory is currently from
normal heap memory. For better perfo
LGTM,
Acked-by: Huisong Li
在 2025/2/21 4:44, Stephen Hemminger 写道:
When configuring offloads, need to check the port id before
indexing into the ports[] array. This can easily be done
by moving the call to oh_dev_conf_get_print_err() to before
the checks for port stopped.
Fixes: c73a9071877a ("
在 2025/2/21 4:56, Stephen Hemminger 写道:
On Tue, 18 Feb 2025 19:31:56 +0800
Huisong Li wrote:
Testpmd doesn't modify the Rx/Tx queue number of all ports after attach a
new device. The root cause is that "port config all rxq " would
check if all ports are stopped and the status of this port is
Hi all,
Kindly ping for review.
在 2024/12/19 15:53, Huisong Li 写道:
The queue_list_entry structure data is used in rx_callback of io path
when enable PMD Power Management. However its memory is currently from
normal heap memory. For better performance, use hugepage memory to
replace it.
Signed
在 2025/1/16 23:18, Thomas Monjalon 写道:
16/01/2025 12:40, Huisong Li:
During probing, before the port becomes generally available, the
rte_eth_dev_socket_id() and rte_eth_dev_owner_*() are available to
application.
Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")
在 2025/1/17 2:31, Stephen Hemminger 写道:
On Thu, 16 Jan 2025 19:40:33 +0800
Huisong Li wrote:
If application verify the validity of the port id or configure this port in
the new event callback, application may happen to the port id is invalid.
In case of similar confusion, this patch have to
在 2025/1/16 17:09, Thomas Monjalon 写道:
16/01/2025 07:14, lihuisong (C):
在 2025/1/15 19:36, Thomas Monjalon 写道:
15/01/2025 04:41, Huisong Li:
The rte_eth_dev_socket_id() and rte_eth_dev_owner_*() can be used after
allocating an ethdev. So this patch relaxes the conditions for using them
在 2025/1/16 17:15, Thomas Monjalon 写道:
16/01/2025 07:16, lihuisong (C):
在 2025/1/15 19:31, Thomas Monjalon 写道:
15/01/2025 04:41, Huisong Li:
If application verify the validity of the port id or configure this port in
the new event callback, application may happen to the port id is invalid
在 2025/1/15 19:31, Thomas Monjalon 写道:
15/01/2025 04:41, Huisong Li:
If application verify the validity of the port id or configure this port in
the new event callback, application may happen to the port id is invalid.
Actually, when application receive a new event from one port, the port is
在 2025/1/15 19:36, Thomas Monjalon 写道:
15/01/2025 04:41, Huisong Li:
The rte_eth_dev_socket_id() and rte_eth_dev_owner_*() can be used after
allocating an ethdev. So this patch relaxes the conditions for using them.
You should be more explicit:
"during probing, before it becomes generally ava
在 2025/1/14 19:13, Thomas Monjalon 写道:
14/01/2025 02:50, lihuisong (C):
在 2025/1/13 21:14, Thomas Monjalon 写道:
13/01/2025 13:47, lihuisong (C):
在 2025/1/13 20:30, Thomas Monjalon 写道:
13/01/2025 13:05, lihuisong (C):
在 2025/1/13 19:23, lihuisong (C) 写道:
在 2025/1/13 18:57, Thomas Monjalon
在 2025/1/13 21:14, Thomas Monjalon 写道:
13/01/2025 13:47, lihuisong (C):
在 2025/1/13 20:30, Thomas Monjalon 写道:
13/01/2025 13:05, lihuisong (C):
在 2025/1/13 19:23, lihuisong (C) 写道:
在 2025/1/13 18:57, Thomas Monjalon 写道:
13/01/2025 10:35, lihuisong (C):
在 2025/1/13 16:16, Thomas Monjalon
在 2025/1/13 20:30, Thomas Monjalon 写道:
13/01/2025 13:05, lihuisong (C):
在 2025/1/13 19:23, lihuisong (C) 写道:
在 2025/1/13 18:57, Thomas Monjalon 写道:
13/01/2025 10:35, lihuisong (C):
在 2025/1/13 16:16, Thomas Monjalon 写道:
13/01/2025 03:55, Huisong Li:
The event callback in application may
Hi Thomas,
在 2025/1/13 19:23, lihuisong (C) 写道:
在 2025/1/13 18:57, Thomas Monjalon 写道:
13/01/2025 10:35, lihuisong (C):
在 2025/1/13 16:16, Thomas Monjalon 写道:
13/01/2025 03:55, Huisong Li:
The event callback in application may use the macro
RTE_ETH_FOREACH_DEV to
iterate over all enabled
在 2025/1/13 18:57, Thomas Monjalon 写道:
13/01/2025 10:35, lihuisong (C):
在 2025/1/13 16:16, Thomas Monjalon 写道:
13/01/2025 03:55, Huisong Li:
The event callback in application may use the macro RTE_ETH_FOREACH_DEV to
iterate over all enabled ports to do something(like, verifying the port id
Hi Thomas,
在 2025/1/13 16:16, Thomas Monjalon 写道:
13/01/2025 03:55, Huisong Li:
The event callback in application may use the macro RTE_ETH_FOREACH_DEV to
iterate over all enabled ports to do something(like, verifying the port id
validity) when receive a probing event. If the ethdev state of a
在 2025/1/11 1:54, Stephen Hemminger 写道:
On Fri, 10 Jan 2025 11:21:26 +0800
"lihuisong (C)" wrote:
Hi Stephen,
Can you take a look at my below reply and reconsider this patch?
/Huisong
在 2024/12/10 9:50, lihuisong (C) 写道:
Hi Ferruh, Stephen and Thomas,
Can you take a look at
Hi Stephen,
Can you take a look at my below reply and reconsider this patch?
/Huisong
在 2024/12/10 9:50, lihuisong (C) 写道:
Hi Ferruh, Stephen and Thomas,
Can you take a look at this patch? After all, it is an issue in ethdev
layer.
This also is the fruit we disscussed with Thomas and
LGTM
Acked-by: Huisong Li
Tested-by: Huisong Li
在 2024/12/14 1:17, Stephen Hemminger 写道:
The test had incorrect assumptions about how active backup
should work. When in active backup mode, the secondary (not primary)
ports should be ignored. The test was always broken since initially
written bu
在 2024/12/14 0:56, Stephen Hemminger 写道:
On Fri, 13 Dec 2024 14:57:23 +0800
"lihuisong (C)" wrote:
Hi Stephen,
This patch looks good to me.
But this test case still runs failure when I run "link_bonding_autotest"
twice. like:
-->
...
EAL: Test assert configure
Hi Stephen,
This patch looks good to me.
But this test case still runs failure when I run "link_bonding_autotest"
twice. like:
-->
...
EAL: Test assert configure_ethdev line 181 failed: rte_eth_dev_configure
for port 7 failed
EAL: Test assert initialize_bonding_device_with_members line 1138
在 2024/12/13 2:07, Stephen Hemminger 写道:
On Fri, 12 Apr 2024 14:27:39 +0200
Kamil Vojanec wrote:
This patch adds a new bonding mode: 'direct'. The purpose of this mode
is to redirect output packets to the same member port on which they were
received. In case the requested port is not among t
Hi Ferruh, Stephen and Thomas,
Can you take a look at this patch? After all, it is an issue in ethdev
layer.
This also is the fruit we disscussed with Thomas and Ferruh before.
Please go back to this thread. If we don't need this patch, please let
me know. I will drop it from my upstreaming li
LGTM, good job.
Acked-by: Huisong Li
在 2024/11/22 15:13, Jie Hai 写道:
The application send packets only when the buffer is full, or the
buffer is empty and the number of packets to be sent extends half
of the buffer.
The change of MAX_PKT_BURST increases TX buffer size, while the
default size o
Series-Acked-by: Huisong Li
在 2024/11/14 19:39, Dengdui Huang 写道:
Whether strerror() needs to be replaced needs further discussion,
but rte_error should not be used by strerror() because rte_errno
may be an RTE-specific error code.
This patchset use rte_strerror() instead of strerror() for rte
在 2024/11/12 20:55, Thomas Monjalon 写道:
12/11/2024 09:35, Huisong Li:
The typo in the guide is hard to understand. Necessary to fix it.
Fixes: dd6fd75bf662 ("power: introduce PM QoS API on CPU wide")
Signed-off-by: Huisong Li
---
--- a/doc/guides/prog_guide/power_man.rst
+++ b/doc/guides/pr
Hi Ferruh, Stephen, Andrew and Thomas,
Can you go back to this thread?
在 2024/10/18 10:48, lihuisong (C) 写道:
Hi Ferruh,
Thanks for your considering again. please see reply inline.
在 2024/10/18 9:04, Ferruh Yigit 写道:
On 10/8/2024 3:32 AM, lihuisong (C) wrote:
Hi Thomas and Ferruh,
We&#x
在 2024/11/11 21:11, Thomas Monjalon 写道:
11/11/2024 13:52, Huisong Li:
-Some services are latency sensitive and very except the low resume time,
+Some services are latency sensitive and request the low resume time,
I suppose it should be "request a low resume time".
Ack, thanks
.
在 2024/11/11 18:18, Thomas Monjalon 写道:
11/11/2024 03:25, Huisong Li:
Some service are delay sensitive and very except the low
resume time, like interrupt packet receiving mode.
I don't understand this sentence.
Are you sure about "very except"?
It is also in the guide.
If something needs a r
Hi Ferruh and Thomas,
Kindly ping for merge.
在 2024/10/29 21:28, Huisong Li 写道:
The deeper the idle state, the lower the power consumption, but the longer
the resume time. Some service are delay sensitive and very except the low
resume time, like interrupt packet receiving mode.
And the "/sys
For this series,
Acked-by: Huisong Li
在 2024/10/30 16:54, Chengwen Feng 写道:
When developing patchset [1], I found the kvargs test is hard to
understand when tried to add some testcase.
So refactor kvargs by:
1. introduce UT suite framework.
2. extract big test_valid_kvargs() to five part.
3. ad
Acked-by: Huisong Li
在 2024/10/30 23:42, Lukas Sismis 写道:
Remove rte_experimental macros from the stable functions
as they have been part of the stable API since 23.11.
Signed-off-by: Lukas Sismis
---
drivers/net/bonding/rte_eth_bond.h| 4
drivers/net/bonding/rte_eth_bond_802
在 2024/10/30 6:12, Ferruh Yigit 写道:
On 10/18/2024 3:48 AM, lihuisong (C) wrote:
Hi Ferruh,
Thanks for your considering again. please see reply inline.
在 2024/10/18 9:04, Ferruh Yigit 写道:
On 10/8/2024 3:32 AM, lihuisong (C) wrote:
Hi Thomas and Ferruh,
We've discussed it on and off
Acked-by: Huisong Li
在 2024/10/11 11:24, Chaoyong He 写道:
From: Long Wu
According to the check rules in the patch check script,
drivers and libraries must use the logging framework.
So standard the log message of bonding driver by using
the logging framework.
Signed-off-by: Long Wu
Reviewed-
Very useful,
Acked-by: Huisong Li
在 2024/10/11 11:24, Chaoyong He 写道:
From: Long Wu
The testpmd application can not modify the value of
dedicated hardware Rx/Tx queue size, and hardcoded
them as (128/512). This will cause the bonding port
start fail if some NIC requires more Rx/Tx descriptors
For series,
Acked-by: Huisong Li
在 2024/10/23 16:28, Dengdui Huang 写道:
The function strerror() is insecure in a multi-thread environment.
It is better to use rte_strerror() instead of strerror().
In this patchset, only the libs and drivers are modified.
chang log:
v3->v4 fix ci error
v2->v3 d
在 2024/10/26 13:22, Tummala, Sivaprasad 写道:
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Huisong,
-Original Message-
From: lihuisong (C)
Sent: Saturday, October 26, 2024 8:37 AM
To: Tummala, Sivaprasad
Cc: dev@dpdk.org; david.h...@intel.com; anatoly.bura
Hi Ferruh,
在 2024/10/18 10:48, lihuisong (C) 写道:
Hi Ferruh,
Thanks for your considering again. please see reply inline.
在 2024/10/18 9:04, Ferruh Yigit 写道:
On 10/8/2024 3:32 AM, lihuisong (C) wrote:
Hi Thomas and Ferruh,
We've discussed it on and off a few times, and we've re
Hi Sivaprasad,
在 2024/10/23 13:11, Sivaprasad Tummala 写道:
This patch renames the existing core power library source files
from rte_power.* to rte_power_cpufreq.* for better clarity
Now it is more clarity for cpufeq and uncore. Thank you for this work.
But I have another question, pmd_mgmt com
Already reviewed before.
Acked-by: Huisong Li
在 2024/10/23 13:11, Sivaprasad Tummala 写道:
This patch refactors the power management library, addressing uncore
power management. The primary changes involve the creation of dedicated
directories for each driver within 'drivers/power/uncore/*'. The
Hi Sivaprasad,
LGTM except for some trivial comments inline,
With belows to change, you can add
Acked-by: Huisong Li
/Huisong
在 2024/10/23 13:11, Sivaprasad Tummala 写道:
This patch introduces a comprehensive refactor to the core power
management library. The primary focus is on improving modula
在 2024/10/25 0:44, Konstantin Ananyev 写道:
The '--cpu-resume-latency' can use to control C-state selection.
Setting the CPU resume latency to 0 can limit the CPU just to enter
C0-state to improve performance, which also may increase the power
consumption of platform.
Signed-off-by: Huisong Li
Acked-by: Huisong Li
在 2024/10/22 12:01, Jie Hai 写道:
If the register values of multiple modules are obtained at a time,
the register values are incorrect because the data field to be filled
pointing to a wrong address. Update the pointer offset of data to
get the correct address.
Fixes: dd4b8b
Acked-by: Huisong Li
在 2024/10/22 12:01, Jie Hai 写道:
The patch fixes variable type in case of data trunction.
Fixes: dd4b8bba785f ("net/hns3: support reporting names of registers")
Cc: sta...@dpdk.org
Signed-off-by: Jie Hai
---
drivers/net/hns3/hns3_regs.c | 4 ++--
1 file changed, 2 inse
Hi Konstantin,
在 2024/10/22 17:10, Konstantin Ananyev 写道:
Add PM QoS configuration to declease the delay after sleep in case of
entering deeper idle state.
I still think it is worth to mention this behavior change somewhere in the docs.
Probably release_notes or sample app guides.
I see some
在 2024/10/22 17:10, Konstantin Ananyev 写道:
Add PM QoS configuration to declease the delay after sleep in case of
entering deeper idle state.
I still think it is worth to mention this behavior change somewhere in the docs.
Probably release_notes or sample app guides.
I already added this inf
在 2024/10/22 17:08, Konstantin Ananyev 写道:
The deeper the idle state, the lower the power consumption, but the longer
the resume time. Some service are delay sensitive and very except the low
resume time, like interrupt packet receiving mode.
And the "/sys/devices/system/cpu/cpuX/power/pm_qo
在 2024/10/22 15:13, Tummala, Sivaprasad 写道:
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Huisong,
Please find my comments inline.
-Original Message-
From: lihuisong (C)
Sent: Tuesday, October 22, 2024 8:33 AM
To: Tummala, Sivaprasad ;
david.h...@intel.com
LGTM except for one typo,
Acked-by: Huisong Li
在 2024/10/21 12:07, Sivaprasad Tummala 写道:
iThis patch refactors the power management library, addressing uncore
iThis --> This
power management. The primary changes involve the creation of dedicated
directories for each driver within 'drivers/po
Hi Stephen,
The modification for this issue has been sent out.
please have a look at v11, thanks.
/Huisong
在 2024/10/15 23:45, Stephen Hemminger 写道:
On Tue, 15 Oct 2024 17:41:39 +0800
"lihuisong (C)" wrote:
Hi Stephen,
Can you take a look at this reply so as to send out the ne
Hi Sivaprasad,
Some comments inline.
在 2024/10/21 12:07, Sivaprasad Tummala 写道:
This patch introduces a comprehensive refactor to the core power
management library. The primary focus is on improving modularity
and organization by relocating specific driver implementations
from the 'lib/power' d
Hi Sivaprasa,
I have a inline question, please take a look.
在 2024/10/8 14:19, Tummala, Sivaprasad 写道:
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Lihuisong,
-Original Message-
From: lihuisong (C)
Sent: Tuesday, August 27, 2024 6:33 PM
To: Tummala, Sivaprasad
Cc
在 2024/10/18 10:42, Chaoyong He 写道:
From: Long Wu
The previous code used a macro as the data size for mbuf
to create the mempool and users cannot modify the size.
Now modify the code to support setting the data size of
mbuf by '--mbuf-size' parameter. If user does not add the
parameter in star
Hi Ferruh,
Thanks for your considering again. please see reply inline.
在 2024/10/18 9:04, Ferruh Yigit 写道:
On 10/8/2024 3:32 AM, lihuisong (C) wrote:
Hi Thomas and Ferruh,
We've discussed it on and off a few times, and we've reached some
consensus.
They've been going thro
在 2024/10/17 19:02, Sivaprasad Tummala 写道:
When user request to use lcores mapped to different physical
cores using --lcores eal option, power application accesses
incorrect cpu sysfs attribute for checking current frequency
The patch fixes the cpu_id based on the lcore and cpu mappings.
Sign
Good job.
With belows to change,
Acked-by: Huisong Li
在 2024/10/17 19:02, Sivaprasad Tummala 写道:
This commit fixes an issue in the power library
related to using lcores mapped to different
physical cores (--lcores option in EAL).
Previously, the power library incorrectly accessed
CPU sysfs at
lgtm, Acked-by: Huisong Li
在 2024/10/17 16:58, Jie Hai 写道:
The mempool cache size of mbuf is set to
RTE_MEMPOOL_CACHE_MAX_SIZE as default. This patch allows
users to configure the cache size by "--mbcache", and limits
the paramater to a maximum of RTE_MEMPOOL_CACHE_MAX_SIZE.
Signed-off-by: Jie
Acked-by: Huisong Li
在 2024/10/17 16:58, Jie Hai 写道:
Now the Rx burst size is fixed to MAX_PKT_BURST (32). This
parameter needs to be modified in some performance optimization
scenarios. So an option '--burst' is added to set the burst size
explicitly. The default value is DEFAULT_PKT_BURST (32
在 2024/10/17 11:20, Stephen Hemminger 写道:
On Thu, 17 Oct 2024 10:11:13 +0800
"lihuisong (C)" wrote:
Hi Stephen,
在 2024/10/15 23:45, Stephen Hemminger 写道:
On Tue, 15 Oct 2024 17:41:39 +0800
"lihuisong (C)" wrote:
Hi Stephen,
Can you take a look at this reply s
在 2024/10/16 8:24, Konstantin Ananyev 写道:
Add PM QoS configuration to declease the delay after sleep in case of
entering deeper idle state.
Signed-off-by: Huisong Li
Acked-by: Morten Brørup
---
examples/l3fwd-power/main.c | 24
1 file changed, 24 insertions(+)
Hi Stephen,
在 2024/10/15 23:45, Stephen Hemminger 写道:
On Tue, 15 Oct 2024 17:41:39 +0800
"lihuisong (C)" wrote:
Hi Stephen,
Can you take a look at this reply so as to send out the next version ASAP?
Thanks.😁
/Huisong
在 2024/10/14 20:19, lihuisong (C) 写道:
The biggest issue is
Hi Stephen,
Can you take a look at this reply so as to send out the next version ASAP?
Thanks.😁
/Huisong
在 2024/10/14 20:19, lihuisong (C) 写道:
Hi Stephen,
在 2024/10/13 9:10, Stephen Hemminger 写道:
On Thu, 12 Sep 2024 10:38:11 +0800
Huisong Li wrote:
+
+PM QoS
+--
+
+The deeper the
在 2024/10/14 23:27, Stephen Hemminger 写道:
On Thu, 12 Sep 2024 10:38:10 +0800
Huisong Li wrote:
The deeper the idle state, the lower the power consumption, but the longer
the resume time. Some service are delay sensitive and very except the low
resume time, like interrupt packet receiving mod
Hi Konstantin Ananyev,
Thanks for your review.
在 2024/10/14 16:29, Konstantin Ananyev 写道:
The deeper the idle state, the lower the power consumption, but the longer
the resume time. Some service are delay sensitive and very except the low
resume time, like interrupt packet receiving mode.
And
Hi Konstantin Ananyev,
在 2024/10/14 16:24, Konstantin Ananyev 写道:
Add PM QoS configuration to declease the delay after sleep in case of
entering deeper idle state.
Signed-off-by: Huisong Li
Acked-by: Morten Brørup
---
examples/l3fwd-power/main.c | 24
1 file chan
Hi Stephen,
在 2024/10/13 9:10, Stephen Hemminger 写道:
On Thu, 12 Sep 2024 10:38:11 +0800
Huisong Li wrote:
+
+PM QoS
+--
+
+The deeper the idle state, the lower the power consumption, but the longer
+the resume time. Some service are delay sensitive and very except the low
+resume time, l
Hi Thomas and Ferruh,
Kindly ping for merge.
/Huisong
在 2024/9/12 11:07, fengchengwen 写道:
Series-reviewed-by: Chengwen Feng
Thanks chengwen.
On 2024/9/12 10:38, Huisong Li wrote:
The deeper the idle state, the lower the power consumption, but the longer
the resume time. Some service are de
Hi Thomas and Ferruh,
We've discussed it on and off a few times, and we've reached some consensus.
They've been going through more than 2 years😅
Can you have a look at this series again?
If we really don't need it, I will drop it from my upstreaming list.
/Huisong
在 2024/9/29 13:52, Huisong Li
Hi Stephen,
Thanks for your review this series again.
在 2024/10/4 0:03, Stephen Hemminger 写道:
On Mon, 19 Apr 2021 21:34:49 +0800
"Min Hu (Connor)" wrote:
From: Chengchang Tang
The expression may cause an overflow.
This patch fix the codeDEX static check warning "INTEGER_OVERFLOW".
Fixes
在 2024/10/2 23:57, David Marchand 写道:
While invoking telemetry commands (which may happen at any time,
out of control of the application), an application thread may
concurrently add/remove ports.
The telemetry callbacks may then access partially
initialised/uninitialised ethdev data.
Reuse the
在 2024/9/26 4:42, Ferruh Yigit 写道:
On 9/24/2024 8:24 AM, lihuisong (C) wrote:
Hi Ferruh,
在 2024/9/23 6:23, Ferruh Yigit 写道:
On 1/30/2024 3:58 AM, Huisong Li wrote:
Currently, the PTP feature is a little messy and has some issue.
1> There is different implementation for PTP. This feat
Hi Ferruh,
在 2024/9/23 6:23, Ferruh Yigit 写道:
On 1/30/2024 3:58 AM, Huisong Li wrote:
Currently, the PTP feature is a little messy and has some issue.
1> There is different implementation for PTP. This feature of some
hardware depends on the Rx HW timestamp offload, and use this
offloa
在 2024/9/18 16:37, Tummala, Sivaprasad 写道:
[AMD Official Use Only - AMD Internal Distribution Only]
-Original Message-
From: lihuisong (C)
Sent: Friday, September 13, 2024 1:05 PM
To: Tummala, Sivaprasad
Cc: dev@dpdk.org; david.h...@intel.com; anatoly.bura...@intel.com;
radu.nico
在 2024/9/12 19:17, Tummala, Sivaprasad 写道:
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Huisong,
Please find my response inline.
-Original Message-
From: lihuisong (C)
Sent: Tuesday, August 27, 2024 1:51 PM
To: Tummala, Sivaprasad
Cc: dev@dpdk.org; david.h
Hi chengwen,
在 2024/9/10 10:26, fengchengwen 写道:
Hi Huisong,
On 2024/8/9 17:50, Huisong Li wrote:
Add PM QoS configuration to declease the delay after sleep in case of
entering deeper idle state.
Signed-off-by: Huisong Li
Acked-by: Morten Brørup
---
examples/l3fwd-power/main.c | 24 ++
Hi Chengwen,
Thanks for your review.
在 2024/9/10 10:00, fengchengwen 写道:
Hi Huisong
Please see comments inline.
Thanks
On 2024/8/9 17:50, Huisong Li wrote:
The deeper the idle state, the lower the power consumption, but the longer
the resume time. Some service are delay sensitive and very e
Hi Sivaprasad,
Suggest to split this patch into two patches for easiler to review:
patch-1: abstract a file for uncore dvfs core level, namely, the
rte_power_uncore_ops.c you did.
patch-2: move and rename, lib/power/power_intel_uncore.c =>
drivers/power/intel_uncore/intel_uncore.c
patch[1/4]
Hi Sivaprasa,
Some comments inline.
/Huisong
在 2024/8/26 21:06, Sivaprasad Tummala 写道:
This patch introduces a comprehensive refactor to the core power
management library. The primary focus is on improving modularity
and organization by relocating specific driver implementations
from the 'lib/
在 2024/8/13 5:56, Stephen Hemminger 写道:
Only in one place does the power library need un-constify a pointer
and this can be done by casting to uintptr_t first. Better, to have
the warning enabled across the rest of the code.
Signed-off-by: Stephen Hemminger
---
Acked-by: Huisong Li
LGTM,
Acked-by: Huisong Li
在 2024/8/2 0:03, Morten Brørup 写道:
Optimized the performance of updating the virtio statistics counters by
reducing the number of branches.
Ordered the packet size comparisons according to the probability with
typical internet traffic mix.
Signed-off-by: Morten Brø
在 2024/8/2 19:27, Morten Brørup 写道:
From: lihuisong (C) [mailto:lihuis...@huawei.com]
Sent: Friday, 2 August 2024 04.23
在 2024/8/2 0:03, Morten Brørup 写道:
void
-virtio_update_packet_stats(struct virtnet_stats *stats, struct
rte_mbuf *mbuf)
+virtio_update_packet_stats(struct
在 2024/8/2 10:42, Stephen Hemminger 写道:
On Fri, 2 Aug 2024 10:23:12 +0800
"lihuisong (C)" wrote:
void
-virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf)
+virtio_update_packet_stats(struct virtnet_stats *const stats,
+ const struc
在 2024/8/2 0:03, Morten Brørup 写道:
Optimized the performance of updating the virtio statistics counters by
reducing the number of branches.
Ordered the packet size comparisons according to the probability with
typical internet traffic mix.
Signed-off-by: Morten Brørup
---
v5:
* Do not inline
For series.
Acked-by: Huisong Li
在 2024/7/18 19:48, Jie Hai 写道:
From: Dengdui Huang
For hns3 NIC, when KEEP_CRC offload is enabled, the CRC data is still be
stripped in rare scenarios.
Some users of hns3 are already using this feature. So driver has to recaculate
packet CRC.
In addition,
Hi Kamil,
在 2024/4/12 20:27, Kamil Vojanec 写道:
This patch adds a new bonding mode: 'direct'. The purpose of this mode
is to redirect output packets to the same member port on which they were
received. In case the requested port is not among the member ports,
round robin TX mode is used as a fall
在 2024/7/9 11:07, Stephen Hemminger 写道:
On Tue, 9 Jul 2024 10:29:27 +0800
Huisong Li wrote:
+ RTE_LCORE_FOREACH(lcore_id) {
+ if (rte_lcore_is_enabled(lcore_id) == 0)
+ continue;
Why do you need this check? RTE_LCORE_FOREACH calls rte_next_lcore wh
Hi
在 2024/7/3 9:32, zhoumin 写道:
Hi Huisong,
I knew that this patchset was based on the *dpdk-next-net* repository
in our previous communication. However, maybe it's better to rebase
this pactchset on the *dpdk* repository. Because the CI system is not
smart enough to recognize the patchset a
在 2024/6/27 23:06, Stephen Hemminger 写道:
On Thu, 27 Jun 2024 14:00:10 +0800
Huisong Li wrote:
+ char buf[BUFSIZ] = {0};
BUFSIZ is 4K and you probably don't need all of that.
I rember the maximum buffer length of sysfs show in Linux is BUFSIZ.
Just from the same size, here is ok to re
在 2024/6/19 23:32, Thomas Monjalon 写道:
19/06/2024 08:31, Huisong Li:
--- /dev/null
+++ b/lib/power/rte_power_qos.h
@@ -0,0 +1,71 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2024 HiSilicon Limited
+ */
+
+#ifndef RTE_POWER_QOS_H
+#define RTE_POWER_QOS_H
+
+#include
+
+#ifdef
在 2024/6/19 22:54, Stephen Hemminger 写道:
On Wed, 19 Jun 2024 14:31:44 +0800
Huisong Li wrote:
+ /*
+* Set the work CPU with strict latency limit to allow the
+* process running on the CPU can only enter the shallowest
+* idle stat
Hi Stephen,
Thanks for your review.
在 2024/6/19 22:56, Stephen Hemminger 写道:
On Wed, 19 Jun 2024 14:31:43 +0800
Huisong Li wrote:
+PM QoS
+--
+
+The deeper the idle state, the lower the power consumption, but the longer
+the resume time. Some service are delay sensitive and very except t
Hi Morten,
Thanks for your review.
在 2024/6/14 16:04, Morten Brørup 写道:
+#define PM_QOS_SYSFILE_RESUME_LATENCY_US \
+ "/sys/devices/system/cpu/cpu%u/power/pm_qos_resume_latency_us"
Is it OK to access this path using the lcore_id as CPU parameter to
open_core_sysfs_file(), or must
在 2024/6/11 14:51, Morten Brørup 写道:
Added information about the memory chunks holding the objects in the
mempool when dumping the status of the mempool to a file.
Signed-off-by: Morten Brørup
Acked-by: Paul Szczepanek
Acked-by: Andrew Rybchenko
Acked-by: Konstantin Ananyev
---
v3:
* Fix o
Hi John and all,
在 2024/5/9 16:46, Mcnamara, John 写道:
Release status meeting minutes 2024-05-09
=
Agenda:
* Release Dates
* Subtrees
* Roadmaps
* LTS
* Defects
* Opens
Participants:
* AMD
* ARM
* Intel
* Marvell
* Nvidia
* Red Hat
Release
1 - 100 of 356 matches
Mail list logo
