Hi Ferruh, Stephen, Andrew and Thomas,
Can you go back to this thread?
在 2024/10/18 10:48, lihuisong (C) 写道:
Hi Ferruh,
Thanks for your considering again. please see reply inline.
在 2024/10/18 9:04, Ferruh Yigit 写道:
On 10/8/2024 3:32 AM, lihuisong (C) wrote:
Hi Thomas and Ferruh,
We've discussed it on and off a few times, and we've reached some
consensus.
They've been going through more than 2 years😅
Can you have a look at this series again?
If we really don't need it, I will drop it from my upstreaming list.
Hi Huisong,
I was not really convinced with the patch series, but did not want to
block it outright, sorry that this caused patch series stay around.
As checked again, still feels like adding unnecessary complexity, and I
am for rejecting this series.
Overall target is to be able to support hotplug with primary/secondary
process, and uses event handlers for this but this requires adding a new
ethdev state to be able iterate over devices etc...
Perhaps better way to support this without relying on event handlers.
Ignoring the modification of tesptmd is ok to me.
But we need to restrict testpmd not to support attach and detach port
in multiple process case.
Otherwise. these issues this series solved will be encountered.
Do we need to announce this point for testpmd?
BTW, I want to say the patch [2/5] which introduced
RTE_ETH_DEV_ALLOCATED should be thought again.
Because it is an real issue in ethdev layer. This is also the fruit
that Thomas, you and I discussed before.
Please look at this patch again.
If we don't merge patch [2/5], user also may encounter this issue as the
commit log of patch [2/5] mentioned.
Please take a look at the commit of patch [2/5] and the modification in
patch [3/5].
