replenishment
succeeds during the polling process, the routine will resume its operation.
Fixes: 1ded26239aa0 ("net/mlx5: refactor vectorized Rx")
Cc: sta...@dpdk.org
Reported-by: Changqi Dingluo
Signed-off-by: Gavin Hu
---
drivers/net/mlx5/mlx5_rxtx_vec.c | 3 +++
1 file changed, 3 insertion
Hi Konstantin,
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Friday, April 24, 2020 9:24 PM
> To: Gavin Hu ; dev@dpdk.org
> Cc: nd ; david.march...@redhat.com;
> tho...@monjalon.net; jer...@marvell.com; Honnappa Nagarahalli
> ; Ruifeng Wang
>
Instead of polling for tail to be updated, use wfe instruction.
Signed-off-by: Gavin Hu
Reviewed-by: Ruifeng Wang
Reviewed-by: Steve Capper
Reviewed-by: Ola Liljedahl
Reviewed-by: Honnappa Nagarahalli
---
lib/librte_ring/rte_ring_c11_mem.h | 4 ++--
lib/librte_ring/rte_ring_generic.h | 3
was measured.
Signed-off-by: Gavin Hu
Reviewed-by: Ruifeng Wang
Reviewed-by: Phil Yang
Reviewed-by: Steve Capper
Reviewed-by: Ola Liljedahl
Reviewed-by: Honnappa Nagarahalli
Tested-by: Pavan Nikhilesh
---
lib/librte_eal/include/generic/rte_spinlock.h | 4 ++--
1 file changed, 2 insertions
The rte_wait_until_equal_xxx APIs abstract the functionality of 'polling
for a memory location to become equal to a given value'[1].
Use the API for the rte spinlock and ring implementations.
[1] http://patches.dpdk.org/cover/62703/
Gavin Hu (2):
spinlock: use wfe to reduce con
Hi Honnappa,
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Friday, April 24, 2020 10:46 PM
> To: Gavin Hu ; dev@dpdk.org
> Cc: nd ; david.march...@redhat.com;
> tho...@monjalon.net; jer...@marvell.com; Ruifeng Wang
> ; Phil Yang ; Joyce Kong
> ; Hon
was measured.
Signed-off-by: Gavin Hu
Reviewed-by: Ruifeng Wang
Reviewed-by: Phil Yang
Reviewed-by: Steve Capper
Reviewed-by: Ola Liljedahl
Reviewed-by: Honnappa Nagarahalli
Tested-by: Pavan Nikhilesh
---
lib/librte_eal/include/generic/rte_spinlock.h | 5 ++---
1 file changed, 2 insertions
The rte_wait_until_equal_xxx APIs abstract the functionality of 'polling
for a memory location to become equal to a given value'[1].
Use the API for the rte spinlock and ring implementations.
[1] http://patches.dpdk.org/cover/62703/
Gavin Hu (2):
spinlock: use wfe to reduce con
Instead of polling for tail to be updated, use wfe instruction.
Signed-off-by: Gavin Hu
Reviewed-by: Ruifeng Wang
Reviewed-by: Steve Capper
Reviewed-by: Ola Liljedahl
Reviewed-by: Honnappa Nagarahalli
---
lib/librte_ring/rte_ring_c11_mem.h | 4 ++--
lib/librte_ring/rte_ring_generic.h | 3
Hi Ferruh,
> -Original Message-
> From: Ferruh Yigit
> Sent: Monday, April 20, 2020 10:51 PM
> To: Gavin Hu ; dev@dpdk.org
> Cc: nd ; david.march...@redhat.com;
> tho...@monjalon.net; jer...@marvell.com; xiaolong...@intel.com;
> Honnappa Nagarahalli ; Ruifeng Wang
35:35: error:
expected ';', ',' or ')' before 'rx_queue' i40e_recv_pkts_vec(void
*restrict rx_queue, struct rte_mbuf **restrict rx_pkts,
Fix this by using '__restrict' type qualifier, which compiles ok with
old and new versions of gcc.
Fixes:
> -Original Message-
> From: Chauskin, Igor
> Sent: Thursday, April 16, 2020 9:38 PM
> To: Gavin Hu ; dev@dpdk.org
> Cc: nd ; david.march...@redhat.com;
> tho...@monjalon.net; m...@semihalf.com; Tzalik, Guy
> ; Schmeilin, Evgeny ;
> m...@semihalf.com; Honnappa Naga
Hi Andrew,
> -Original Message-
> From: Andrew Rybchenko
> Sent: Monday, April 13, 2020 5:52 PM
> To: Gavin Hu ; dev@dpdk.org
> Cc: nd ; david.march...@redhat.com;
> tho...@monjalon.net; rasl...@mellanox.com; d...@linux.vnet.ibm.com;
> bruce.richard...@intel
case is the RFC2544 zero-loss test running testpmd.
[1] http://inbox.dpdk.org/dev/CALBAE1M-ezVWCjqCZDBw+MMDEC4O9
qf0kpn89emdgdajepk...@mail.gmail.com
Fixes: ae0eb310f253 ("net/i40e: implement vector PMD for ARM")
Cc: sta...@dpdk.org
Signed-off-by: Gavin Hu
Acked-by: Jeri
command on Marvell
ThunderX2 and Arm N1SDP and showed positive performance results.
sudo ./build/app/testpmd -l 1,3 -w 0001:01:00.0 -w 0001:01:00.1
--master-lcore 1 -- -i --rxq=4 --txq=4 --nb-cores=1 --nb-ports=2 -a
Gavin Hu (2):
net/i40e: relax barrier in Tx fastpath for NEON vPMD
net/i40e
Signed-off-by: Gavin Hu
Reviewed-by: Steve Capper
---
drivers/net/i40e/i40e_rxtx_vec_neon.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c
b/drivers/net/i40e/i40e_rxtx_vec_neon.c
index 4376d8911..405bd82df 100644
--- a
case is the RFC2544 zero-loss test running testpmd.
[1] http://inbox.dpdk.org/dev/CALBAE1M-ezVWCjqCZDBw+MMDEC4O9
qf0kpn89emdgdajepk...@mail.gmail.com
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Cc: sta...@dpdk.org
Signed-off-by: Gavin Hu
---
drivers/net/i40e/i40e_rxtx_vec_neo
Signed-off-by: Gavin Hu
Reviewed-by: Steve Capper
---
drivers/net/i40e/i40e_rxtx_vec_neon.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c
b/drivers/net/i40e/i40e_rxtx_vec_neon.c
index 4376d8911..405bd82df 100644
--- a
showed positive performance results.
sudo ./build/app/testpmd -l 1,3 -w 0001:01:00.0 -w 0001:01:00.1
--master-lcore 1 -- -i --rxq=4 --txq=4 --nb-cores=1 --nb-ports=2 -a
Gavin Hu (2):
net/i40e: relax barrier in Tx fastpath for NEON vPMD
net/i40e: restrict pointer aliasing for NEON vPMD
Hi Andrew,
> -Original Message-
> From: Andrew Rybchenko
> Sent: Saturday, April 11, 2020 1:21 AM
> To: Gavin Hu ; dev@dpdk.org
> Cc: nd ; david.march...@redhat.com;
> tho...@monjalon.net; rasl...@mellanox.com; d...@linux.vnet.ibm.com;
> bruce.richard...@intel
> -Original Message-
> From: Thomas Monjalon
> Sent: Thursday, April 9, 2020 6:50 PM
> To: Gavin Hu
> Cc: David Marchand ; Kevin Traynor
> ; Bruce Richardson ;
> Morten Brørup ; Ferruh Yigit
> ; dev@dpdk.org; nd ;
> jer...@marvell.com; Honnappa Nagarahall
s to these two memory regions.
Interpreting it to 'non-cacheable' makes no distinction and is
confusing.
re-interprete it to 'non-combining' can make the distinction.
Also explains why aarch64 default setting for this is different.
Signed-off-by: Gavin Hu
---
doc/guides/ni
with one-way barrier to improve performance.
Fixes: 7d6bf6b866b8 ("net/mlx5: add Multi-Packet Rx support")
Cc: sta...@dpdk.org
Suggested-by: Gavin Hu
Signed-off-by: Phil Yang
Reviewed-by: Gavin Hu
---
drivers/net/mlx5/mlx5_rxq.c | 2 +-
drivers/net/mlx5/mlx5_r
-by: Gavin Hu
Reviewed-by: Phil Yang
---
drivers/net/mlx5/mlx5_rxtx.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
index 228e37de5..737d5716d 100644
--- a/drivers/net/mlx5/mlx5_rxtx.h
+++ b/drivers/net/mlx5/mlx5_rxtx.h
and ppc.
Fixes: 6bf10ab69be0 ("net/mlx5: support 32-bit systems")
Cc: sta...@dpdk.org
Signed-off-by: Gavin Hu
Reviewed-by: Phil Yang
---
drivers/net/mlx5/mlx5_rxtx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_
between Arm and Ampere, 8%~13%
performance boost was measured.
As there is no functionality changes, it will not impact x86.
Gavin Hu (6):
eal: introduce new class of barriers for DMA use cases
net/mlx5: dmb for immediate doorbell ring on aarch64
net/mlx5: relax barrier to order UAR writes on aar
ned-off-by: Gavin Hu
Reviewed-by: Phil Yang
---
drivers/net/mlx5/mlx5_rxtx.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
index da5d81350..228e37de5 100644
--- a/drivers/net/mlx5/mlx5_rxtx.h
+++ b/driver
A 'DMB' is enough to evict the merge buffer on aarch64,when the doorbell
register is mapped as 'Normal-NC', the counterpart of WC on x86.
Otherwise, it is mapped as Device memory, no barriers required at all.
Signed-off-by: Gavin Hu
---
drivers/net/mlx5/mlx5_rxtx.h | 2 +
/kernel/git/torvalds/linux.git/
commit/?id=22ec71615d824f4f11d38d0e55a88d8956b7e45f
Signed-off-by: Gavin Hu
Reviewed-by: Steve Capper
---
lib/librte_eal/arm/include/rte_atomic_32.h | 6
lib/librte_eal/arm/include/rte_atomic_64.h | 6
lib/librte_eal/include/gener
Hi David,
> -Original Message-
> From: David Marchand
> Sent: Wednesday, April 8, 2020 11:22 PM
> To: Gavin Hu
> Cc: Kevin Traynor ; Bruce Richardson
> ; Morten Brørup
> ; Ferruh Yigit ;
> dev@dpdk.org; nd ; tho...@monjalon.net;
> jer...@marvell.com; Honna
Hi Kevin,
> -Original Message-
> From: Kevin Traynor
> Sent: Wednesday, April 8, 2020 1:14 AM
> To: Gavin Hu ; Bruce Richardson
> ; Morten Brørup
>
> Cc: Ferruh Yigit ; dev@dpdk.org; nd
> ; david.march...@redhat.com; tho...@monjalon.net;
> jer...@marvel
Honnappa Nagarahalli
> ; Gavin Hu ; nd
> ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/2] virtio: one way barrier for split vring
> used idx
>
> On Thu, 2 Apr 2020 10:57:52 +0800
> Joyce Kong wrote:
>
> > - (
> -Original Message-
> From: Jerin Jacob
> Sent: Thursday, April 2, 2020 4:12 PM
> To: tho...@monjalon.net
> Cc: Joyce Kong ; Gavin Hu ;
> step...@networkplumber.org; david.march...@redhat.com;
> m...@smartsharesystems.com; jer...@marvell.com;
> bruce.richar
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon
> Sent: Wednesday, April 1, 2020 5:45 PM
> To: Joyce Kong ; Gavin Hu
> Cc: step...@networkplumber.org; david.march...@redhat.com;
> m...@smartsharesystems.com; jer...@marvell.com;
> bruce.richard...@intel.com
Hi Marvin,
> -Original Message-
> From: Liu, Yong
> Sent: Wednesday, April 1, 2020 9:01 PM
> To: Gavin Hu ; maxime.coque...@redhat.com; Ye,
> Xiaolong ; Wang, Zhihong
>
> Cc: dev@dpdk.org; nd
> Subject: RE: [dpdk-dev] [PATCH v2 2/2] vhost: cach
Reviewed-by: Gavin Hu
Hi Marvin,
> -Original Message-
> From: dev On Behalf Of Marvin Liu
> Sent: Wednesday, April 1, 2020 10:50 PM
> To: maxime.coque...@redhat.com; xiaolong...@intel.com;
> zhihong.w...@intel.com
> Cc: dev@dpdk.org; Marvin Liu
> Subject: [dpdk-dev] [PATCH v2 2/2] vhost: cache gpa to hpa tran
vi1.ku...@amd.com; rm...@marvell.com;
> shsha...@marvell.com; xuanziya...@huawei.com;
> cloud.wangxiao...@huawei.com; zhouguoy...@huawei.com; Honnappa
> Nagarahalli ; Phil Yang
> ; Gavin Hu ; nd
> ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of PMD
&
Reviewed-by: Gavin Hu
Hi Igor,
> -Original Message-
> From: Chauskin, Igor
> Sent: Monday, March 16, 2020 5:35 PM
> To: Gavin Hu ; dev@dpdk.org
> Cc: nd ; david.march...@redhat.com; tho...@monjalon.net;
> m...@semihalf.com; Tzalik, Guy ; Schmeilin, Evgeny
> ; m...@semihalf.com;
Hi Bruce,
> -Original Message-
> From: Bruce Richardson
> Sent: Wednesday, March 11, 2020 8:08 PM
> To: Morten Brørup
> Cc: Gavin Hu ; Ferruh Yigit ;
> dev@dpdk.org; nd ; david.march...@redhat.com;
> tho...@monjalon.net; ktray...@redhat.com; jer...@marvell.com;
&
There is a memset operation for the whole structure so no need
to memset the sub fields in it.
Fixes: 1173fca25af9 ("ena: add polling-mode driver")
Cc: sta...@dpdk.org
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Gavin Hu
Reviewed-by: Honnappa Nagarahalli
---
drive
As there is necessary barriers before calling the function everywhere,
then using the relaxed write function ENA_REG_WRITE32_RELAXED is ok.
Fixes: 99ecfbf845b3 ("ena: import communication layer")
Cc: sta...@dpdk.org
Signed-off-by: Gavin Hu
Reviewed-by: Honnappa Nagarahalli
---
drive
The statistics logging are in the data path, as rte_atomic APIs enforce
unnecessary barriers on aarch64, this patch uses c11 atomic APIs with
the __ATOMIC_RELAXED memory ordering to give CPU more freedom to optimize
by making use of out-of-order execution.
Signed-off-by: Gavin Hu
Reviewed-by
#n48
[4] http://code.dpdk.org/dpdk/v20.02/source/drivers/net/ena/
ena_ethdev.c#L2021
Fixes: b68309be44c0 ("net/ena/base: update communication layer for the ENAv2")
Cc: sta...@dpdk.org
Signed-off-by: Gavin Hu
Reviewed-by: Honnappa Nagarahalli
---
drivers/net/ena/base/ena_plat_dpdk.h | 2
t/ena: fix unneeded doorbell submission")
Cc: sta...@dpdk.org
[1] http://code.dpdk.org/dpdk/v20.02/source/lib/librte_eal/common/
include/generic/rte_atomic.h#L137
Signed-off-by: Gavin Hu
Reviewed-by: Honnappa Nagarahalli
---
drivers/net/ena/ena_ethdev.c | 6 +++---
1 file changed, 3 insert
To gaurantee the update observed by NIC HW, a cio barrier is sufficient,
a io barrier, which translates to dsb on aarch64, is overkill.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Gavin Hu
Reviewed-by: Honnappa Nagarahalli
---
drivers/net/ena/base/ena_eth_com.c | 2 +-
1 file changed, 1
and the other
patch removing duplicate memset.
Note this set is submitted for RFC as we don't have physical ENA NICs in
the lab and the patch set was not verified nor benchmarked.
Gavin Hu (7):
net/ena: remove duplicate barrier
net/ena: relax the barrier for doorbell ring
net/ena: relax
To gaurantee the update observed by NIC HW, a cio barrier is sufficient,
an io barrier, which translates to dsb on aarch64, is overkill.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Gavin Hu
Reviewed-by: Honnappa Nagarahalli
---
drivers/net/ena/base/ena_eth_com.h | 4 +++-
1 file changed
Hi Bruce,
> -Original Message-
> From: Bruce Richardson
> Sent: Wednesday, March 11, 2020 8:08 PM
> To: Morten Brørup
> Cc: Gavin Hu ; Ferruh Yigit ;
> dev@dpdk.org; nd ; david.march...@redhat.com;
> tho...@monjalon.net; ktray...@redhat.com; jer...@marvell.com;
&
Hi Morten,
> -Original Message-
> From: Morten Brørup
> Sent: Monday, March 9, 2020 9:31 PM
> To: Ferruh Yigit ; Gavin Hu ;
> dev@dpdk.org
> Cc: nd ; david.march...@redhat.com;
> tho...@monjalon.net; ktray...@redhat.com; jer...@marvell.com;
> Honnappa Nagarahalli
Reviewed-by: Gavin Hu
Hi Haifeng,
> -Original Message-
> From: dev On Behalf Of Linhaifeng
> Sent: Monday, March 9, 2020 5:23 PM
> To: dev@dpdk.org; tho...@monjalon.net
> Cc: chenchanghu ; xudingke
> ; Lilijun (Jerry)
> Subject: [dpdk-dev] [PATCH] cycles: add isb before read cntvct_el0
>
> We should use isb
Reviewed-by: Gavin Hu
Hi Ferruh,
> -Original Message-
> From: Ferruh Yigit
> Sent: Monday, March 9, 2020 4:55 PM
> To: Gavin Hu ; dev@dpdk.org
> Cc: nd ; david.march...@redhat.com; tho...@monjalon.net;
> ktray...@redhat.com; jer...@marvell.com; Honnappa Nagarahalli
> ; Ruifeng Wang
>
Hi Jerin,
> -Original Message-
> From: Jerin Jacob
> Sent: Monday, March 9, 2020 3:36 PM
> To: Gavin Hu
> Cc: dpdk-dev ; nd ; David Marchand
> ; tho...@monjalon.net; jer...@marvell.com;
> Ye, Xiaolong ; Honnappa Nagarahalli
> ; Ruifeng Wang
> ; Phil Yang ;
://bugs.dpdk.org/show_bug.cgi?id=396
Bugzilla ID: 396
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
Fixes: 3e6181b07038 ("mbuf: use structure marker from EAL")
Cc: sta...@dpdk.org
Signed-off-by: Gavin Hu
---
v2:
* change 'uint64_t rearm_data' to 'uint_64_t rearm_
Hi Jerin,
> -Original Message-
> From: Jerin Jacob
> Sent: Friday, March 6, 2020 3:45 PM
> To: Gavin Hu
> Cc: dpdk-dev ; nd ; David Marchand
> ; tho...@monjalon.net;
> jer...@marvell.com; Ye, Xiaolong ; Honnappa
> Nagarahalli ; Ruifeng Wang
> ; Phil Yang ;
Hi Kevin,
> -Original Message-
> From: Kevin Traynor
> Sent: Wednesday, March 4, 2020 8:33 PM
> To: Gavin Hu ; dev@dpdk.org
> Cc: nd ; tho...@monjalon.net;
> david.march...@redhat.com; jer...@marvell.com; Honnappa Nagarahalli
> ; Ruifeng Wang
> ; Phil Yang ;
>
Signed-off-by: Gavin Hu
Reviewed-by: Steve Capper
---
drivers/net/i40e/i40e_rxtx_vec_neon.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c
b/drivers/net/i40e/i40e_rxtx_vec_neon.c
index 4376d8911..405bd82df 100644
--- a
: Gavin Hu
Reviewed-by: Steve Capper
---
drivers/net/i40e/i40e_rxtx_vec_common.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h
b/drivers/net/i40e/i40e_rxtx_vec_common.h
index 0e6ffa007..fc0fa45d4 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_common.h
=4 --txq=4 --nb-cores=1 --nb-ports=2 -a
Gavin Hu (3):
net/i40e: relax barrier in the Tx fastpath of vPMD
net/i40e: restrict pointer aliasing for neon vec
net/i40e: auto-vectorization to speed up Tx free
drivers/net/i40e/i40e_rxtx_vec_common.h | 5 +
drivers/net/i40e/i40e_rxtx_vec_neon.c
the RFC2544 zero-loss test running testpmd.
[1] http://inbox.dpdk.org/dev/CALBAE1M-ezVWCjqCZDBw+MMDEC4O9
qf0kpn89emdgdajepk...@mail.gmail.com
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Cc: sta...@dpdk.org
Signed-off-by: Gavin Hu
---
drivers/net/i40e/i40e_rxtx_vec_neon.c | 6
96
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
Fixes: 3e6181b07038 ("mbuf: use structure marker from EAL")
Cc: sta...@dpdk.org
Signed-off-by: Gavin Hu
---
lib/librte_mbuf/rte_mbuf_core.h | 54 +++--
1 file changed, 32 insertions(+), 22 delet
Reviewed-by: Gavin Hu
Reviewed-by: Gavin Hu
Hi Pavan,
> -Original Message-
> From: pbhagavat...@marvell.com
> Sent: Friday, February 14, 2020 2:45 PM
> To: jer...@marvell.com; Pavan Nikhilesh
> Cc: Gavin Hu ; dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] event/octeontx2: remove WFE from dualslot
> dequeue
>
Hi Jerin,
Could you help review this patch? We discussed a lot on this topic and I think
we agreed already to relax the barrier only on the fast path.
Best Regards,
Gavin
> -Original Message-
> From: Gavin Hu
> Sent: Friday, February 14, 2020 3:58 PM
> To: Gavin Hu
&
fix Tx doorbell write memory barrier")
Cc: sta...@dpdk.org
Signed-off-by: Gavin Hu
Reviewed-by: Phil Yang
---
drivers/net/mlx5/mlx5_txq.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
index bc13abfe6..144bab4a6 100644
--
with one-way barrier to improve performance.
Fixes: 7d6bf6b866b8 ("net/mlx5: add Multi-Packet Rx support")
Cc: sta...@dpdk.org
Suggested-by: Gavin Hu
Signed-off-by: Phil Yang
Reviewed-by: Gavin Hu
---
drivers/net/mlx5/mlx5_rxq.c | 2 +-
drivers/net/mlx5/mlx5_r
quot;net/mlx5: support 32-bit systems")
Cc: sta...@dpdk.org
Suggested-by: Phil Yang
Signed-off-by: Gavin Hu
Reviewed-by: Phil Yang
---
drivers/net/mlx5/mlx5_rxq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx
-by: Gavin Hu
Reviewed-by: Phil Yang
---
drivers/net/mlx5/mlx5_rxtx.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
index c672af4c4..d32c4e430 100644
--- a/drivers/net/mlx5/mlx5_rxtx.h
+++ b/drivers/net/mlx5/mlx5_rxtx.h
To ensure the WQE and doorbell record, which reside in the host memory,
are visible to HW before the blue frame, a CIO barrier is sufficient, a
rte_wmb is overkill.
Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86")
Cc: sta...@dpdk.org
Signed-off-by: Gavin Hu
Reviewe
mapped as nGnRE device memory, not cachable nor
write-combine.
2. io accesses to a single device is total ordered.
Fixes: 6bf10ab69be0 ("net/mlx5: support 32-bit systems")
Cc: sta...@dpdk.org
Signed-off-by: Gavin Hu
Reviewed-by: Phil Yang
---
drivers/net/mlx5/mlx5_rxtx.h | 2 +-
1 fi
Using just sufficient barriers really matters to performance.
Insufficient barriers will cause issues while barriers stronger
than required, especially in the fast path is a performance killer.
In the joint preliminary testing between Arm and Ampere, 8%~13%
performance was measured.
Gavin Hu (5
Hi Xiaolong,
Just sent v4 for this, thanks for reminding!
Best Regards,
Gavin
> -Original Message-
> From: Ye Xiaolong
> Sent: Tuesday, February 11, 2020 10:11 AM
> To: Gavin Hu
> Cc: dev@dpdk.org; nd ; david.march...@redhat.com;
> tho...@monjalon.net; ra
.@dpdk.org
Signed-off-by: Gavin Hu
---
V4:
- add the Fixes tag and CC stable
V3:
- optimize the barriers in the fast path only, leave as it is for the
barriers in the slow path and control path
- drop the virtio patches from the list as they are in the control path
- it makes more sense to relax t
To keep ordering of mixed accesses, rte_cio is sufficient.
The rte_io barrier is overkill.[1]
[1] http://inbox.dpdk.org/dev/CALBAE1M-ezVWCjqCZDBw+MMDEC4O9
qf0kpn89emdgdajepk...@mail.gmail.com
Signed-off-by: Gavin Hu
---
V3:
- optimize the barriers in the fast path only, leave as it is for the
> -Original Message-
> From: David Marchand
> Sent: Friday, January 17, 2020 5:38 AM
> To: Honnappa Nagarahalli
> Cc: Gavin Hu ; Jerin Jacob ;
> Ananyev, Konstantin ;
> tho...@monjalon.net; dev@dpdk.org; Mcnamara, John
> ; Kovacevic, Marko
> ; jer...@marve
Hi Mahipal,
Please cc me in your future optimization patches.
Series-reviewed-by: Gavin Hu
> -Original Message-
> From: Mahipal Challa
> Sent: Wednesday, January 8, 2020 3:32 PM
> To: dev@dpdk.org; tho...@monjalon.net; jer...@marvell.com; Gavin Hu
>
> Cc:
Hi Mahipal,
> -Original Message-
> From: Mahipal Challa
> Sent: Monday, January 6, 2020 8:07 PM
> To: dev@dpdk.org
> Cc: jer...@marvell.com; pathr...@marvell.com; sni...@marvell.com;
> venk...@marvell.com; Gavin Hu
> Subject: [dpdk-dev] [PATCH v3 2/6] raw/oct
Hi Mahipal,
> -Original Message-
> From: Mahipal Challa
> Sent: Monday, January 6, 2020 8:07 PM
> To: dev@dpdk.org
> Cc: jer...@marvell.com; pathr...@marvell.com; sni...@marvell.com;
> venk...@marvell.com; Gavin Hu
> Subject: [dpdk-dev] [PATCH v3 4/6] raw/octe
Hi Mahipal, Jerin,
> -Original Message-
> From: Mahipal Challa
> Sent: Monday, January 6, 2020 8:07 PM
> To: dev@dpdk.org
> Cc: jer...@marvell.com; pathr...@marvell.com; sni...@marvell.com;
> venk...@marvell.com; Gavin Hu
> Subject: [dpdk-dev] [PATCH v3 5/6]
Hi Mahipal,
> -Original Message-
> From: Mahipal Challa
> Sent: Monday, January 6, 2020 8:07 PM
> To: dev@dpdk.org
> Cc: jer...@marvell.com; pathr...@marvell.com; sni...@marvell.com;
> venk...@marvell.com; Gavin Hu
> Subject: [dpdk-dev] [PATCH v3 6/6] raw/octeontx
Hi Jerin,
> -Original Message-
> From: Jerin Jacob
> Sent: Friday, January 3, 2020 3:35 PM
> To: Gavin Hu
> Cc: dpdk-dev ; nd ; David Marchand
> ; tho...@monjalon.net;
> rasl...@mellanox.com; maxime.coque...@redhat.com; tiwei@intel.com;
> hemant.agra...@nxp
Hi Jerin,
> -Original Message-
> From: Jerin Jacob
> Sent: Thursday, January 2, 2020 5:52 PM
> To: Gavin Hu
> Cc: dpdk-dev ; nd ; David Marchand
> ; tho...@monjalon.net;
> rasl...@mellanox.com; maxime.coque...@redhat.com; tiwei@intel.com;
> hemant.agra...@nxp
Hi Mahipal,
> -Original Message-
> From: dev On Behalf Of Mahipal Challa
> Sent: Friday, December 27, 2019 8:40 PM
> To: dev@dpdk.org
> Cc: jer...@marvell.com; pathr...@marvell.com; sni...@marvell.com;
> venk...@marvell.com
> Subject: [dpdk-dev] [dpdk-dev PATCH v2 4/6] raw/octeontx2_ep: a
Hi Mahipal,
> -Original Message-
> From: dev On Behalf Of Mahipal Challa
> Sent: Friday, December 27, 2019 8:40 PM
> To: dev@dpdk.org
> Cc: jer...@marvell.com; pathr...@marvell.com; sni...@marvell.com;
> venk...@marvell.com
> Subject: [dpdk-dev] [dpdk-dev PATCH v2 6/6] raw/octeontx2_ep: a
Hi Mahipal,
3 comments inline.
> -Original Message-
> From: dev On Behalf Of Mahipal Challa
> Sent: Friday, December 27, 2019 8:40 PM
> To: dev@dpdk.org
> Cc: jer...@marvell.com; pathr...@marvell.com; sni...@marvell.com;
> venk...@marvell.com
> Subject: [dpdk-dev] [dpdk-dev PATCH v2 2/6]
Hi Mahipal,
Could you make old versions 'Superseded' when you have new ones?
/Gavin
.richard...@intel.com; ravi1.ku...@amd.com;
> rm...@marvell.com; shsha...@marvell.com; xuanziya...@huawei.com;
> cloud.wangxiao...@huawei.com; zhouguoy...@huawei.com; Phil Yang
> ; Gavin Hu ; nd ;
> dev@dpdk.org
> Subject: Re: [PATCH v6 1/6] lib/eal: implement the family of rte bit
Reviewed-by: Gavin Hu
Hi Xiaoyun,
> -Original Message-
> From: Li, Xiaoyun
> Sent: Monday, December 23, 2019 5:36 PM
> To: Gavin Hu ; Wu, Jingjing
> Cc: dev@dpdk.org; Maslekar, Omkar ;
> sta...@dpdk.org; nd ; jer...@marvell.com; Honnappa
> Nagarahalli ; Richardson, Bruce
> ; nd
Hi Jerin,
> -Original Message-
> From: Jerin Jacob
> Sent: Monday, December 23, 2019 5:20 PM
> To: Gavin Hu
> Cc: dpdk-dev ; nd ; David Marchand
> ; tho...@monjalon.net;
> rasl...@mellanox.com; maxime.coque...@redhat.com;
> tiwei@intel.com; hemant.agra...@nxp
2019 2:56 PM
> To: Gavin Hu
> Cc: dpdk-dev ; nd ; David Marchand
> ; tho...@monjalon.net;
> rasl...@mellanox.com; maxime.coque...@redhat.com;
> tiwei@intel.com; hemant.agra...@nxp.com; jer...@marvell.com;
> Pavan Nikhilesh ; Honnappa Nagarahalli
> ; Ruifeng Wang
> ;
Hi Xiaoyun,
> -Original Message-
> From: Li, Xiaoyun
> Sent: Monday, December 23, 2019 3:52 PM
> To: Gavin Hu ; Wu, Jingjing
> Cc: dev@dpdk.org; Maslekar, Omkar ;
> sta...@dpdk.org; nd
> Subject: RE: [dpdk-dev] [PATCH v2] raw/ntb: fix write memory barrier issue
>
Reviewed-by: Gavin Hu
Hi Tiwei,
Thanks for review.
> -Original Message-
> From: Tiwei Bie
> Sent: Friday, December 20, 2019 4:18 PM
> To: Gavin Hu
> Cc: dev@dpdk.org; nd ; david.march...@redhat.com;
> tho...@monjalon.net; rasl...@mellanox.com;
> maxime.coque...@redhat.com; hemant.a
Hi Jerin,
> -Original Message-
> From: Jerin Jacob
> Sent: Friday, December 20, 2019 12:34 PM
> To: Gavin Hu
> Cc: dpdk-dev ; nd ; David Marchand
> ; tho...@monjalon.net;
> rasl...@mellanox.com; maxime.coque...@redhat.com;
> tiwei@intel.com; hem
Series-reviewed-by: Gavin Hu
1 - 100 of 666 matches
Mail list logo
