Hi folks,
I recently updated to Fedora 42 that comes with GCC 15.
When building with -fsanitize=address (libasan.so.8), it seems that
the --no-huge mode (along with --no-shconf) fails at initialization for
some obscure reason.
"couldn't allocate memory due to IOVA exceeding limits of current DMA
Hi Andre,
Thanks for the respin. Could you format the code using ruff/black before
sending a v3?
Andre Muezerie, Apr 15, 2025 at 03:21:
> Script usertools\dpdk-pmdinfo.py was enhanced to also be able to parse
> symbols from sections in PE images.
>
> Signed-off-by: Andre Muezerie
> ---
> userto
gi?id=1664
Signed-off-by: Robin Jarry
---
app/test/test_net_ip6.c | 26 ++
lib/net/rte_ip6.h | 4 ++--
2 files changed, 28 insertions(+), 2 deletions(-)
diff --git a/app/test/test_net_ip6.c b/app/test/test_net_ip6.c
index 9cc10b1f714f..cfc550940306 100644
---
Bruce Richardson, Jan 27, 2025 at 15:39:
> On Mon, Jan 27, 2025 at 12:51:44PM +0100, Robin Jarry wrote:
>> Fix the following warning reported by Coverity:
>>
>> Defect type: SIGMA.insecure_network_bind:
>> > dpdk-stable-24.11.1/usertools/dpdk-telemetry-exporter.py:2
ides address_family
to socket.AF_INET6.
Fixes: d94ebd627a86 ("usertools: add telemetry exporter")
Cc: sta...@dpdk.org
Signed-off-by: Robin Jarry
---
usertools/dpdk-telemetry-exporter.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/usertools/dpdk-telemetry-exporte
Nitin Saxena, Jan 03, 2025 at 15:41:
> Hi,
>
> Please find attached slides explaining feature arc concept and its
> usage in graph library
>
> I can also present these slides to community to facilitate this patch
> series review process
Hi Nitin,
thanks for taking the time to explain your design
5065ef1f6c ("test: emit warning for orphaned tests")
Cc: sta...@dpdk.org
Signed-off-by: Ariel Otilibili
---
Acked-by: Robin Jarry
Ariel Otilibili, Dec 08, 2024 at 03:25:
* invalid escape sequences now generate SyntaxWarning
* therefore changed syntax to raw string noration.
Link: https://docs.python.org/3/library/re.html#module-re
Signed-off-by: Ariel Otilibili
Hi Ariel, thanks for the fix!
Acked-by: Robin Jarry
If
Hi folks,
I had a look at the graph dispatch mode and wondered if it could be
adapted to be used with event loops for "slow path" processing.
The use case I have in mind is having lcores dedicated for control plane
operations which are not latency sensitive. It would be nice to allow
data pl
Stephen Hemminger, Nov 29, 2024 at 17:54:
On Fri, 29 Nov 2024 17:10:14 +0100
Robin Jarry wrote:
@@ -550,11 +555,8 @@ eal_log_init(const char *id)
void
rte_eal_log_cleanup(void)
{
- FILE *log_stream = rte_logs.file;
-
- /* don't close stderr on the application */
-
(syslog or journald) to determine if it should be
closed or not.
Fixes: 985130369be3 ("log: rework syslog handling")
Signed-off-by: Robin Jarry
---
lib/log/log.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/lib/log/log.c b/lib/log/log.c
index eb087d
This patch adds an option to `dpdk-devbind.py` to change the UID/GID of
the device when binding it to VFIO.
Signed-off-by: Anatoly Burakov
---
Reviewed-by: Robin Jarry
: a7d69cef8f20 ("usertools/devbind: print device NUMA node")
Signed-off-by: Anatoly Burakov
Acked-by: Robin Jarry
Anatoly Burakov, Nov 27, 2024 at 16:42:
When adding NUMA node printouts, the "*Active*" marker was accidentally
omitted. Add it back in.
Fixes: a7d69cef8f20 ("usertools/devbind: print device NUMA node")
Signed-off-by: Anatoly Burakov
Acked-by: Robin Jarry
Hi Anatoly,
Anatoly Burakov, Nov 26, 2024 at 16:02:
Currently, when binding a device to VFIO, the UID/GID for the device will
always stay as system default (`root`). Yet, when running DPDK as non-root
user, one has to change the UID/GID of the device to match the user's
UID/GID to use the device
Thomas Monjalon, Nov 26, 2024 at 16:36:
The central question is to know how to get those GPL2 scripts accepted
in DPDK.
These are scripts, not linked to any DPDK related binary. So I think it
is OK in terms of license contamination. We MUST preserve the original
license headers in these impor
Thomas Monjalon, Nov 26, 2024 at 15:03:
I would prefer we host our own fork of checkpatch.pl.
There are too many irrelevant checks that we should drop.
How about get_maintainer.pl? Should we host our copy as well?
Vladimir Medvedkin, Nov 17, 2024 at 16:04:
[Robin]
I had not understood that it was *only* the lookups that were network
order
[Morten]
When I saw the byte order flag the first time, it was not clear to me
either that it only affected lookups - I too thought it covered the
entire API of the
Morten Brørup, Nov 15, 2024 at 14:52:
Robin, you've totally won me over on this endian discussion. :-)
Especially the IPv6 comparison make it clear why IPv4 should also be
network byte order.
API/ABI stability is a pain... we're stuck with host endian IPv4
addresses; e.g. for the RTE_IPV4() m
Morten Brørup, Nov 14, 2024 at 15:35:
RTE_IPV4 is only useful to define addresses in unit tests.
There are plenty of special IP addresses and subnets, where a shortcut
macro makes the address easier readable in the code.
OK, let me reformulate. I didn't mean to say that RTE_IPV4 is useless.
Hi folks,
Morten Brørup, Nov 14, 2024 at 08:43:
Medvedkin, Vladimir:
I think control plane API should work with prefix addresses in CPU
byte order. At least our RTE_IPV4 macro works this way. Also, prefix
is an address + prefix length (not the mask), so it is more natural
if address is in cpu
Medvedkin, Vladimir, Nov 13, 2024 at 11:42:
Hi Robin,
It should not. Here is documentation says regarding this flag:
/** If set, fib lookup is expecting IPv4 address in network byte order */
#define RTE_FIB_F_NETWORK_ORDER 1
As stated above lookups will be performed while expecting addresse
Hernández
Thanks!
Reviewed-by: Robin Jarry
Hi,
Rogelio Domínguez Hernández, Nov 12, 2024 at 14:15:
This patch adds support for 'y' and 'Y' values when reading
vfio-pci unsafe_noiommu_mode flag.
Possible values were taken from linux kernel
(sysfs__read_bool() in tools/lib/api/fs/fs.c)
Signed-off-by: Rogelio Domínguez Hernández
---
use
Hi Vladimir,
I started playing with the new RTE_FIB_F_NETWORK_ORDER flag and I found
that it does not work at all.
rte_fib is based on rte_rib to perform all slow path lookups and
modifications. Unfortunately, rte_rib does not handle network order
addresses. This causes the added routes to b
, Nov 11, 2024 at 08:34:
From: Kiran Kumar K
The node id is determined based on a global variable that is
incremented every time a node is created. Adding changes to
remove the global counter. Make sure that the node list is always
ordered by increasing node ids. When creating a new node, pick
IPv6 headers are always aligned on a 2-bytes grid. Reflect this in the
structure definition.
Signed-off-by: Robin Jarry
---
Notes:
v2: added changelog entry
doc/guides/rel_notes/release_24_11.rst | 6 ++
lib/net/rte_ip6.h | 6 +++---
2 files changed, 9 insertions
IPv6 headers are always aligned on a 2-bytes grid. Reflect this in the
structure definition.
Signed-off-by: Robin Jarry
---
lib/net/rte_ip6.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/net/rte_ip6.h b/lib/net/rte_ip6.h
index 3ae38811b27c..fea7d7b0cd73 100644
Morten Brørup, Nov 05, 2024 at 10:09:
For consistency, could one of you - David or Robin - please also
2-byte align the IPv6 header structure?
I can send a patch but I wonder if this is really necessary after the
RC-1 has passed?
We don't have any gcc warning related to IPv6 unaligned access
s: 6f3dbd306de0 ("build: increase minimum meson version to 0.57")
Signed-off-by: David Marchand
---
Reviewed-by: Robin Jarry
46758
Fixes: ca786def84ca ("net: add IPv6 address structure and utils")
Signed-off-by: Robin Jarry
---
lib/net/rte_ip6.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/net/rte_ip6.h b/lib/net/rte_ip6.h
index 3ae38811b27c..c015c977573d 100644
--- a/lib/ne
6 bytes at byte offset
16 by dereferencing pointer &ip->a[d].
91memset(&ip->a[d], 0, sizeof(*ip) - d);
92}
93 }
Use a simple loop instead of memset.
Coverity issue: 446754
Fixes: ca786def84ca ("net: add IPv6 address structure and utils")
Signed-o
lowed, is used in a pointer index in
>>> "ip->a[d]".
89 ip->a[d] &= mask;
90 d++;
91 memset(&ip->a[d], 0, sizeof(*ip) - d);
92 }
93 }
Cheers.
Robin Jarry (2):
net/ipv6: fix overflowed array index reads
net/ipv6: fix out-of-bounds read
lib/net/rte_ip6.h | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
--
2.47.0
Bruce Richardson, Oct 22, 2024 at 17:25:
No strong objection to this. Just FYI, the reason it is currently done as
it is in the build, is that even if you configure a build without the docs
enabled, you can just build the docs explicitly by doing "ninja -C build
doc". That is so that one can do a
enter the doc subdir. Replace all
occurrences of get_option('enable_docs') in the doc subdir with true.
Fixes: 7f9326423a04 ("dts: add API doc generation")
Signed-off-by: Robin Jarry
---
doc/api/dts/meson.build | 6 +++---
doc/api/meson.build | 16
doc/guid
Hi all,
I am starting this discussion to see what can be done in order to make
the in-built nodes (i.e. https://git.dpdk.org/dpdk/tree/lib/node) easier
to reuse in external applications.
So far here are the limitations I have found when working on grout. Some
of these limitations are trivial
without
-Wno-address-of-packed-member (set in dpdk by default).
In order to have a consistent code base, replace in6_addr with
rte_ipv6_addr in the cmdline library. Update all code accordingly.
Signed-off-by: Robin Jarry
---
app/graph/ethdev.c | 4 +--
app/graph/ip6_route.c
Replace ad-hoc uint8_t[16] array types in the API of rte_rib6 with
rte_ipv6_addr structures. Replace duplicate functions and macros with
common ones from rte_ip6.h. Update all code accordingly.
Signed-off-by: Robin Jarry
---
app/test/test_rib6.c | 55 ++--
doc/guides
Update rte_ipv6_tuple to use rte_ipv6_addr structures instead of
uint8_t[16] arrays.
Signed-off-by: Robin Jarry
---
app/test/test_thash.c | 46 ++
doc/guides/rel_notes/deprecation.rst | 2 --
doc/guides/rel_notes/release_24_11.rst | 2 ++
lib/hash
Update rte_table_action_ipv6_header and rte_table_action_nat_params to
use rte_ipv6_addr structures instead of uint8_t[16] arrays.
For consistency, also update rte_swx_ipsec_sa_encap_params to use
rte_ipv6_addr instead of in6_addr.
Signed-off-by: Robin Jarry
---
doc/guides/rel_notes
Split IPv4 and IPv6 symbols in two separate headers. rte_ip4.h and
rte_ip6.h, respectively.
Update doxygen index accordingly.
Include rte_ip4.h and rte_ip6.h in rte_ip.h for backward compatibility
in applications.
Signed-off-by: Robin Jarry
Acked-by: Stephen Hemminger
---
doc/api/doxy-api
Add more utilities to work with IPv6 addresses. These functions will be
required in order to help building IPv6 routing applications.
Signed-off-by: Robin Jarry
Acked-by: Stephen Hemminger
---
app/test/test_net_ip6.c | 68 +
lib/net/rte_ip6.h | 209
Add a function to check the version in IPv6 headers.
Signed-off-by: Robin Jarry
---
app/test/test_net_ip6.c | 16
lib/net/rte_ip6.h | 16
2 files changed, 32 insertions(+)
diff --git a/app/test/test_net_ip6.c b/app/test/test_net_ip6.c
index 94033421ad0b
Update rte_flow_tunnel, rte_flow_action_set_ipv6,
rte_flow_item_icmp6_nd_na and rte_flow_item_icmp6_nd_ns to use
rte_ipv6_addr structures instead of uint8_t[16] arrays.
Signed-off-by: Robin Jarry
---
app/test-flow-perf/actions_gen.c | 4 ++--
doc/guides/rel_notes/deprecation.rst
Update tcp6_flow_key to use rte_ipv6_addr structures instead of
uint8_t[16] arrays.
Signed-off-by: Robin Jarry
---
doc/guides/rel_notes/deprecation.rst | 2 --
doc/guides/rel_notes/release_24_11.rst | 2 ++
lib/gro/gro_tcp6.c | 8
lib/gro/gro_tcp6.h
For consistency with the rest of the code base, update
rte_security_ipsec_tunnel_param to use rte_ipv6_addr structures instead
of in6_addr.
Signed-off-by: Robin Jarry
---
doc/guides/rel_notes/release_24_11.rst | 2 ++
drivers/common/cnxk/cnxk_security.c| 14 ++
drivers/net/iavf
The rte_ipv6_hdr uses ad-hoc uint8_t[16] arrays to represent addresses.
Replace these arrays with the newly added rte_ipv6_addr structure. Adapt
all code accordingly.
Signed-off-by: Robin Jarry
---
app/test-flow-perf/items_gen.c | 4 +--
app/test-pipeline/pipeline_hash.c| 4
Replace ad-hoc uint8_t[16] arrays with rte_ipv6_addr structures. Replace
duplicated code with utils from rte_ip6.h.
Signed-off-by: Robin Jarry
---
app/graph/ethdev.c | 44 +++---
app/graph/ethdev.h | 9 ++---
app/graph/ip6_route.c
Update rte_ipsec_sadv6_key to use rte_ipv6_addr structures instead of
uint8_t[16] arrays.
Signed-off-by: Robin Jarry
---
app/test-sad/main.c| 24 ++--
app/test/test_ipsec_sad.c | 46
doc/guides/prog_guide/ipsec_lib.rst| 4 +-
doc/guides
Replace ad-hoc uint8_t[16] array types in the API of rte_fib6 with
rte_ipv6_addr structures. Replace duplicate functions and macros with
common ones from rte_ip6.h. Update all code accordingly.
Signed-off-by: Robin Jarry
---
app/test-fib/main.c| 8 +-
app/test/test_fib6.c
rte_ipv6_addr
structure. Add basic unit tests to ensure everything works as expected.
These functions will be used in the next commits to replace private
and/or duplicated functions.
Signed-off-by: Robin Jarry
---
MAINTAINERS| 1 +
app/test/meson.build
The checksum functions are used by both ipv4 and ipv6 functions. In
preparation of moving ipv6 symbols to a new header, move the checksum
related symbols to another dedicated header.
Update doxygen index accordingly.
Signed-off-by: Robin Jarry
Acked-by: Stephen Hemminger
---
doc/api/doxy-api
ted with a space
- update changelog with deprecated symbols and their replacements, if any
Robin Jarry (17):
net: split raw checksum functions in separate header
net: split IPv4 and IPv6 symbols in separate headers
net: add IPv6 address structure and utils
net: use IPv6 structure for pack
without
-Wno-address-of-packed-member (set in dpdk by default).
In order to have a consistent code base, replace in6_addr with
rte_ipv6_addr in the cmdline library. Update all code accordingly.
Signed-off-by: Robin Jarry
---
app/graph/ethdev.c | 4 +--
app/graph/ip6_route.c
Update tcp6_flow_key to use rte_ipv6_addr structures instead of
uint8_t[16] arrays.
Signed-off-by: Robin Jarry
---
doc/guides/rel_notes/deprecation.rst | 2 --
doc/guides/rel_notes/release_24_11.rst | 2 ++
lib/gro/gro_tcp6.c | 8
lib/gro/gro_tcp6.h
For consistency with the rest of the code base, update
rte_security_ipsec_tunnel_param to use rte_ipv6_addr structures instead
of in6_addr.
Signed-off-by: Robin Jarry
---
doc/guides/rel_notes/release_24_11.rst | 2 ++
drivers/common/cnxk/cnxk_security.c| 14 ++
drivers/net/iavf
Update rte_flow_tunnel, rte_flow_action_set_ipv6,
rte_flow_item_icmp6_nd_na and rte_flow_item_icmp6_nd_ns to use
rte_ipv6_addr structures instead of uint8_t[16] arrays.
Signed-off-by: Robin Jarry
---
app/test-flow-perf/actions_gen.c | 4 ++--
doc/guides/rel_notes/deprecation.rst
rte_ipv6_addr
structure. Add basic unit tests to ensure everything works as expected.
These functions will be used in the next commits to replace private
and/or duplicated functions.
Signed-off-by: Robin Jarry
---
MAINTAINERS| 1 +
app/test/meson.build
Replace ad-hoc uint8_t[16] arrays with rte_ipv6_addr structures. Replace
duplicated code with utils from rte_ip6.h.
Signed-off-by: Robin Jarry
---
app/graph/ethdev.c | 44 +++---
app/graph/ethdev.h | 9 ++---
app/graph/ip6_route.c
The rte_ipv6_hdr uses ad-hoc uint8_t[16] arrays to represent addresses.
Replace these arrays with the newly added rte_ipv6_addr structure. Adapt
all code accordingly.
Signed-off-by: Robin Jarry
---
app/test-flow-perf/items_gen.c | 4 +--
app/test-pipeline/pipeline_hash.c| 4
Add more utilities to work with IPv6 addresses. These functions will be
required in order to help building IPv6 routing applications.
Signed-off-by: Robin Jarry
Acked-by: Stephen Hemminger
---
app/test/test_net_ip6.c | 68 +++
lib/net/rte_ip6.h | 143
Add a function to check the version in IPv6 headers.
Signed-off-by: Robin Jarry
---
app/test/test_net_ip6.c | 16
lib/net/rte_ip6.h | 14 ++
2 files changed, 30 insertions(+)
diff --git a/app/test/test_net_ip6.c b/app/test/test_net_ip6.c
index 94033421ad0b
Update rte_ipv6_tuple to use rte_ipv6_addr structures instead of
uint8_t[16] arrays.
Signed-off-by: Robin Jarry
---
app/test/test_thash.c | 46 ++
doc/guides/rel_notes/deprecation.rst | 2 --
doc/guides/rel_notes/release_24_11.rst | 2 ++
lib/hash
Update rte_table_action_ipv6_header and rte_table_action_nat_params to
use rte_ipv6_addr structures instead of uint8_t[16] arrays.
For consistency, also update rte_swx_ipsec_sa_encap_params to use
rte_ipv6_addr instead of in6_addr.
Signed-off-by: Robin Jarry
---
doc/guides/rel_notes
Update rte_ipsec_sadv6_key to use rte_ipv6_addr structures instead of
uint8_t[16] arrays.
Signed-off-by: Robin Jarry
---
app/test-sad/main.c| 24 ++--
app/test/test_ipsec_sad.c | 46
doc/guides/prog_guide/ipsec_lib.rst| 4 +-
doc/guides
Replace ad-hoc uint8_t[16] array types in the API of rte_fib6 with
rte_ipv6_addr structures. Replace duplicate functions and macros with
common ones from rte_ip6.h. Update all code accordingly.
Signed-off-by: Robin Jarry
---
app/test-fib/main.c| 8 +-
app/test/test_fib6.c
Replace ad-hoc uint8_t[16] array types in the API of rte_rib6 with
rte_ipv6_addr structures. Replace duplicate functions and macros with
common ones from rte_ip6.h. Update all code accordingly.
Signed-off-by: Robin Jarry
---
app/test/test_rib6.c | 55 ++--
doc/guides
The checksum functions are used by both ipv4 and ipv6 functions. In
preparation of moving ipv6 symbols to a new header, move the checksum
related symbols to another dedicated header.
Update doxygen index accordingly.
Signed-off-by: Robin Jarry
Acked-by: Stephen Hemminger
---
doc/api/doxy-api
o separate commits
- split security, pipeline and ipsec into separate commits
Robin Jarry (17):
net: split raw checksum functions in separate header
net: split IPv4 and IPv6 symbols in separate headers
net: add IPv6 address structure and utils
net: use IPv6 structure for packet headers
Split IPv4 and IPv6 symbols in two separate headers. rte_ip4.h and
rte_ip6.h, respectively.
Update doxygen index accordingly.
Include rte_ip4.h and rte_ip6.h in rte_ip.h for backward compatibility
in applications.
Signed-off-by: Robin Jarry
Acked-by: Stephen Hemminger
---
doc/api/doxy-api
-editor.org/rfc/rfc6918
Signed-off-by: Robin Jarry
Acked-by: Stephen Hemminger
Acked-by: Ferruh Yigit
---
Notes:
v2: added release note
app/test-pmd/icmpecho.c| 10
doc/guides/rel_notes/release_24_11.rst | 6 +
lib/net/rte_icmp.h | 33
Ferruh Yigit, Oct 18, 2024 at 00:22:
On 10/17/2024 5:02 PM, Stephen Hemminger wrote:
On Thu, 17 Oct 2024 10:33:22 +0200
Robin Jarry wrote:
Add more ICMP message types and codes based on RFC 792. Change the
namespace prefix from RTE_IP_ICMP_ to RTE_ICMP_ to allow differentiation
between types
David Marchand, Oct 17, 2024 at 15:52:
Hello Robin,
[snip]
- Now that many changes hit the main repo, this series needs some
rebasing (conflicts are not too difficult, but having this rebase run
through a bit in the CI would be great).
Will do.
- From a compatibility pov, I am not fond of
Add more ICMP message types and codes based on RFC 792. Change the
namespace prefix from RTE_IP_ICMP_ to RTE_ICMP_ to allow differentiation
between types and codes.
Signed-off-by: Robin Jarry
---
app/test-pmd/icmpecho.c | 10 +-
lib/net/rte_icmp.h | 31
Hi Nitin, all,
Nitin Saxena, Oct 17, 2024 at 09:03:
Hi Robin/David and all,
We realized the feature arc patch series is difficult to understand as
a new concept. Our objectives are following with feature arc changes
1. Allow reusability of standard DPDK nodes (defined in lib/nodes/*)
wit
Hi folks,
David Marchand, Oct 16, 2024 at 11:24:
On Mon, Oct 14, 2024 at 1:12 PM Nitin Saxena wrote:
I had pushed non RFC patch series before -rc1 date (11th oct).
We have an ABI change in this patch series
https://patches.dpdk.org/project/dpdk/patch/20241010133111.2764712-3-nsax...@marvell.c
Bruce Richardson, Sep 20, 2024 at 14:57:
The meson function "get_cross_property" is deprecated in meson 0.58 and
should be replaced by "get_external_property".
Signed-off-by: Bruce Richardson
---
Reviewed-by: Robin Jarry
Bruce Richardson, Sep 20, 2024 at 14:57:
Rather than having to use run_command to shell out and read the VERSION
file for the DPDK version, we can use the support added directly to
meson in version 0.57.
Signed-off-by: Bruce Richardson
---
Reviewed-by: Robin Jarry
Bruce Richardson, Sep 20, 2024 at 14:57:
Since minimum meson version is now 0.57 we can remove all version checks
for versions lower than that.
Signed-off-by: Bruce Richardson
---
Reviewed-by: Robin Jarry
add dependency check for cross build")
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
Reviewed-by: Robin Jarry
get_cross_property
* Ability to use a VERSION file rather than hacking it with scripting
* Ability to set built-in options in cross-build files
* Ability to set pkg_config_libdir in cross-build files
Signed-off-by: Bruce Richardson
Reviewed-by: Robin Jarry
David Marchand, Oct 15, 2024 at 10:02:
On Mon, Oct 14, 2024 at 10:01 PM Stephen Hemminger
If this happens often, and the function takes a long time (like doing i/o)
it might be worth changing this to reader/writer in future.
Yes, this was an option mentionned when we discussed the issue in Mon
, Oct 14, 2024 at 18:10:
From: Pavan Nikhilesh
update the graph memory layout and node anatomy
images to reflect the xstats memory region.
Signed-off-by: Pavan Nikhilesh
---
Reviewed-by: Robin Jarry
, Oct 14, 2024 at 18:10:
From: Pavan Nikhilesh
Add xstat counters for ip4 LPM lookup failures in
ip4_lookup node.
Add reassembly failure xstat counter for ip4 reassembly
node.
Signed-off-by: Pavan Nikhilesh
Acked-by: Kiran Kumar K
---
Reviewed-by: Robin Jarry
ned-off-by: Robin Jarry
Acked-by: Bruce Richardson
---
lib/ethdev/rte_ethdev_telemetry.c | 66 ++-
1 file changed, 47 insertions(+), 19 deletions(-)
diff --git a/lib/ethdev/rte_ethdev_telemetry.c
b/lib/ethdev/rte_ethdev_telemetry.c
index 6b873e7abe68..7599fa2852b6 100644
the list of callbacks and invoke the correct function pointer.
Update release notes.
Signed-off-by: Robin Jarry
Acked-by: Bruce Richardson
---
Notes:
v3: reorder callback arguments
doc/guides/rel_notes/release_24_11.rst | 5 +++
lib/telemetry/rte_telemetry.h | 46
and naive
approach of putting locks in the ethdev layer.
v3: reordered callback arguments.
v2: added new telemetry api to register callbacks with a private arg.
Robin Jarry (2):
telemetry: add api to register command with private argument
ethdev: fix potential race in telemetry endpoints
Hi Pavan,
I am resending my review here. It seems you didn't get it.
, Oct 14, 2024 at 13:58:
From: Pavan Nikhilesh
Introduce the ability for nodes to advertise error counters during
registration and increment them during the node process function in
the graph library.
This enhancement allow
Hi Vladimir,
Vladimir Medvedkin, Oct 10, 2024 at 13:26:
Previously when running rte_fib_lookup IPv4 addresses must have been in
host byte order.
This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on
fib create, which will allow to have IPv4 in network byte order on
lookup.
Si
I forgot to mention.
If you submit a v5, could you squash all commits that deal with
lib/graph into a single patch? Including the public API to increment the
nodes xstats?
And a second patch that implements xstats in the in-built nodes.
Thanks!
Hi Pavan,
, Aug 16, 2024 at 17:09:
From: Pavan Nikhilesh
Add ability for Nodes to advertise error counters
during registration.
Signed-off-by: Pavan Nikhilesh
---
v2 Changes:
- Fix compilation.
v3 Changes:
- Resend as 1/5 didn't make it through.
v4 Changes:
- Address review comments.
- Rebas
Hi Pavan,
, Aug 16, 2024 at 17:09:
From: Pavan Nikhilesh
Add support for retrieving/printing stats for node specific
errors using rte_graph_cluster_stats_get().
Signed-off-by: Pavan Nikhilesh
---
[snip]
diff --git a/lib/graph/rte_graph.h b/lib/graph/rte_graph.h
index b28143d737..12b6461c
, Aug 16, 2024 at 17:09:
From: Pavan Nikhilesh
Add node fastpath error counters advertised during
node registration.
Signed-off-by: Pavan Nikhilesh
Reviewed-by: Robin Jarry
Hi Pavan,
, Aug 16, 2024 at 17:09:
From: Pavan Nikhilesh
Add error counters for ip4 LPM lookup failures in
ip4_lookup node.
Signed-off-by: Pavan Nikhilesh
[snip]
diff --git a/lib/node/node_private.h b/lib/node/node_private.h
index 1de7306792..36b2a733db 100644
--- a/lib/node/node_private
patch
Link: https://git.dpdk.org/tools/dpdk-ci/commit/?id=070b31649e48460b3
Signed-off-by: Robin Jarry
Acked-by: Stephen Hemminger
---
Notes:
v2: fix check for v1[0-9]+
devtools/checkpatches.sh | 13 +
1 file changed, 13 insertions(+)
diff --git a/devtools/checkpatches.sh b
Morten Brørup, Oct 06, 2024 at 10:18:
This has been discussed before, but I want to double check...
If - sometime in the future - we want to add a union to offer a 2-byte
access variant and make the structure to 2-byte aligned (which is the
common case in Ethernet packets), it will break both
Hi Morten,
Morten Brørup, Oct 06, 2024 at 11:02:
Personally, I would prefer following the convention of rte_ether functions to
return boolean (as int)...
static inline int
rte_is__ether_addr(const
struct rte_ether_addr *ea)
Sorry, I haven't followed your recommendation in v3, but I have a
Add a function to check the version in IPv6 headers.
Signed-off-by: Robin Jarry
---
Notes:
v3: only check for the first byte
app/test/test_net_ip6.c | 16
lib/net/rte_ip6.h | 14 ++
2 files changed, 30 insertions(+)
diff --git a/app/test/test_net_ip6.c
Add more utilities to work with IPv6 addresses. These functions will be
required in order to help building IPv6 routing applications.
Signed-off-by: Robin Jarry
Acked-by: Stephen Hemminger
---
Notes:
v3:
- replace string initializers and RTE_IPV6_ADDR() with RTE_IPV6()
app/test
Update rte_flow_tunnel, rte_flow_action_set_ipv6,
rte_flow_item_icmp6_nd_na and rte_flow_item_icmp6_nd_ns to use
rte_ipv6_addr structures instead of uint8_t[16] arrays. Use the IPv6
utils that go along.
Update all code accordingly.
Signed-off-by: Robin Jarry
---
Notes:
v3: replace string
1 - 100 of 457 matches
Mail list logo
