Ferruh Yigit, Oct 18, 2024 at 00:22:
On 10/17/2024 5:02 PM, Stephen Hemminger wrote:
On Thu, 17 Oct 2024 10:33:22 +0200
Robin Jarry <rja...@redhat.com> wrote:

Add more ICMP message types and codes based on RFC 792. Change the
namespace prefix from RTE_IP_ICMP_ to RTE_ICMP_ to allow differentiation
between types and codes.

Signed-off-by: Robin Jarry <rja...@redhat.com>

Should add a release note for this

Acked-by: Stephen Hemminger <step...@networkplumber.org>


+1 to get this in 24.11

Acked-by: Ferruh Yigit <ferruh.yi...@amd.com>


@Thomas, probably it is better to get this for -rc1 and as next-net
already pulled can this directly go to main?

I will probably send a v2 with a release note.


Btw, is following also required? Just because it is documented in RFC:
   15  Information Request
   16  Information Reply

It seems some of the original codes have been deprecated:

https://www.rfc-editor.org/rfc/rfc6918#section-2.2


Ack stands if above added or not.

Reply via email to