On 01/03/2019 10:31, Thomas Monjalon wrote:
[..]
Applied
Remy, you are welcome to continue maintaining some of these libraries
with another email address if you plan to have time to dedicate.
I've considered reclaiming them in a personal capacity but I need to see
how time and/or contractual
After today I will no longer be with Intel, so I am
removing my name from all related maintainer roles.
Signed-off-by: Remy Horton
---
MAINTAINERS | 4
1 file changed, 4 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3b39bc6..f13c241 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
block of metadata may be better on cache
side. Since rte_metrics_update_values is called periodicly in bitrate lib.
Quite possibly, at least for smallish datasets like bitrate.
Signed-off-by: Junjie Wan
Acked-by: Remy Horton
The tests for metrics themselves now all pass, but there is failure with
bitrate statistics (bitrate stats uses metrics underneath). Latency
statistics, which also uses metrics, seems ok though.
RTE>>bitratestats_autotest
+ --- +
+ Test Suit
This patch has checkpatch errors that will need to be fixed:
ERROR:SPACING: space prohibited before that close parenthesis ')'
#179: FILE: lib/librte_metrics/rte_metrics.c:233:
+ if (count < 1 )
ERROR:TRAILING_WHITESPACE: trailing whitespace
#242: FILE: lib/librte_metrics/rte_metrics.c:298
On 25/02/2019 19:21, Rami Rosen wrote:
[snip]
Signed-off-by: Rami Rosen
---
examples/ethtool/lib/rte_ethtool.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Remy Horton
ics.c | 20
lib/librte_metrics/rte_metrics.h | 17 +
lib/librte_metrics/rte_metrics_version.map | 6 ++
4 files changed, 57 insertions(+)
Acked-by: Remy Horton
Did quick test run and seems fine.
On 22/02/2019 14:45, Harman Kalra wrote:
Signed-off-by: Harman Kalra
---
test/test/test_metrics.c | 17 +
1 file changed, 17 insertions(+)
Acked-by: Remy Horton
or metrics library")
Acked-by: Remy Horton
On 09/10/2018 16:11, Stephen Hemminger wrote:
On Tue, 09 Oct 2018 16:31:24 +0200
[..]
This is getting complex enough that doing a real parser maybe necessary.
I thought the same thing back in April with the port representor
patchsets. Quickly run out of things to use as delimiters otherwis
On 09/10/2018 03:18, Thomas Monjalon wrote:
The functions for representor devargs parsing were static
in the file rte_ethdev.c.
In order to reuse them in the file rte_class_eth.c,
they are moved to the files ethdev_private.c/.h.
Signed-off-by: Thomas Monjalon
There is overlap between these
On 26/07/2018 17:50, Reshma Pattan wrote:
Free up the memzone allocated during the
rte_latencystats_init().
Fixes: 5cd3cac9ed ("latency: added new library for latency stats")
CC: sta...@dpdk.org
CC: remy.hor...@intel.com
Signed-off-by: Reshma Pattan
Acked-by: Remy Horton
t with lib/
- fixes of old commits must have Cc: sta...@dpdk.org
20/07/2018 17:31, Ferruh Yigit:
On 7/6/2018 2:21 PM, Remy Horton wrote:
This patchset adds a check to rte_metrics_update_values()
that prevents the updating of metrics when presented with
an invalid metric key. Previously, doing the la
-by: Remy Horton
+ /* Test Case to check failures when memzone init is not done */
+static int
+test_metrics_without_init(void)
+{
+ int err = 0;
+ const uint64_t value[REG_METRIC_COUNT] = {0};
+ const char * const mnames[] = {
+ "mean_bits_in", &quo
On 16/07/2018 13:47, Qi Zhang wrote:
Add missing NULL point check inside ixgbe_pf_host_uninit, or it may cause
segment fault when detaching a device.
Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports")
Cc: sta...@dpdk.org
Signed-off-by: Qi Zhang
Acked-by: Remy Horton
ned-off-by: Remy Horton
---
lib/librte_bitratestats/rte_bitrate.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_bitratestats/rte_bitrate.c
b/lib/librte_bitratestats/rte_bitrate.c
index 964e3c3..c4b28f6 100644
--- a/lib/librte_bitratestats/rte_bitrate.c
+++ b/lib/librte_bi
s for packet forwarding"
Patch Link is http://patches.dpdk.org/patch/42946/
Signed-off-by: Chaitanya Babu Talluri
Reviewed-by: Reshma Pattan
Acked-by: Remy Horton
Patch doesn't apply to latest master, but otherwise seems fine to me.
On 02/07/2018 05:18, Qi Zhang wrote:
Add missing NULL point check in ixgbe_pf_host_uninit, or it may cause
segement fault when detach a device.
Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports")
Cc: sta...@d
This patchset adds a check to rte_metrics_update_values()
that prevents the updating of metrics when presented with
an invalid metric key. Previously, doing the latter could
result in a crash.
Fixes: 349950ddb9c5 ("metrics: add information metrics library")
Signed-off-by: Remy Horton
'noon,
See inline comments.
On 05/07/2018 08:37, Hari kumar Vemula wrote:
Unit Testcases are added for metrics library.
[..]
+/* Test case to validate registering a list of valid metric names */
+static int
+test_metrics_reg_names(void)
+{
+ int err = 0;
+ const char * const mn
-EIO.
Fixes: 349950ddb9c5 ("metrics: add information metrics library")
Signed-off-by: Remy Horton
---
lib/librte_metrics/rte_metrics.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c
ind
This patch adds a sanity check so that names passed into
rte_metrics_reg_names() and the wrapper rte_metrics_reg_name()
cannot be NULL.
Fixes: 349950ddb9c5 ("metrics: add information metrics library")
Signed-off-by: Remy Horton
---
lib/librte_metrics/rte_metrics.c | 3 +++
1 file
If rte_stats_bitrate_reg() is passed NULL, the result is a crash.
Fixed by adding a sanity check that makes sure the passed-in
pointer is not NULL.
Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library")
Signed-off-by: Remy Horton
---
lib/librte_bitratestats/rte_bitrate.c
d-off-by: Qi Zhang
---
drivers/bus/vdev/vdev.c | 30 ++
1 file changed, 30 insertions(+)
Acked-by: Remy Horton
On 26/06/2018 08:08, Qi Zhang wrote:
[..]
Signed-off-by: Qi Zhang
---
lib/librte_eal/common/eal_common_dev.c | 17 +
lib/librte_eal/common/include/rte_bus.h | 16
Acked-by: Remy Horton
On 26/06/2018 08:08, Qi Zhang wrote:
[..]
Signed-off-by: Qi Zhang
---
lib/librte_ethdev/rte_ethdev.c| 24 +---
lib/librte_ethdev/rte_ethdev_driver.h | 13 +
2 files changed, 34 insertions(+), 3 deletions(-)
Acked-by: Remy Horton
On 26/06/2018 08:08, Qi Zhang wrote:
[..]
static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
{
+ struct rte_eth_dev *ethdev;
+ ethdev = rte_eth_dev_allocated(pci_dev->device.name);
+
+ if (!ethdev)
+ return -ENODEV;
+
+ if (rte_eal_p
On 26/06/2018 08:08, Qi Zhang wrote:
[..]
static int eth_ixgbevf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
struct rte_pci_device *pci_dev)
{
+ struct rte_eth_dev *ethdev;
+
+ ethdev = rte_eth_dev_allocated(pci_dev->device.name);
+ if (!ethdev)
+
On 26/06/2018 10:03, Ferruh Yigit wrote:
[..]
Hi Remy,
Is following covering this patch:
https://patches.dpdk.org/patch/41313/
Patch was sent out with wrong subject, so consider it Nack'd.
On 22/06/2018 14:36, Remy Horton wrote:
[..]
Signed-off-by: Remy Horton
---
examples/ipsec-secgw/ipsec-secgw.c | 5 +
1 file changed, 5 insertions(+)
Self-Nack. Another pending patch already fixes this.
On 22/06/2018 16:46, Ferruh Yigit wrote:
[..]
Is following covering this patch:
https://patches.dpdk.org/patch/41313/
Looks like it. Didn't spot it earlier..
..Remy
ests modes that are supported rather than
failing to start up.
Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
Signed-off-by: Remy Horton
---
examples/ipsec-secgw/ipsec-secgw.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/examples/ipsec-secgw/ipsec
ests modes that are supported rather than
failing to start up.
Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
Signed-off-by: Remy Horton
---
examples/ipsec-secgw/ipsec-secgw.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/examples/ipsec-secgw/ipsec
On 14/06/2018 11:55, Ferruh Yigit wrote:
On 6/14/2018 7:39 AM, Remy Horton wrote:
On 13/06/2018 16:39, Ferruh Yigit wrote:
On 6/7/2018 9:15 AM, David Marchand wrote:
Testpmd should not expect the xstats names and values arrays to be
aligned: neither the arrays sizes, nor the order in which
On 13/06/2018 16:39, Ferruh Yigit wrote:
On 6/7/2018 9:15 AM, David Marchand wrote:
Testpmd should not expect the xstats names and values arrays to be
aligned: neither the arrays sizes, nor the order in which the values are.
As far as I can see this assumption is everywhere in API implementa
se of implementation simplification
turning into API assumption :(
..Remy
On 07/06/2018 09:15, David Marchand wrote:
[..]
Signed-off-by: David Marchand
Acked-by: Remy Horton
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch adds the values for the ixgbe PMD.
Signed-off-by: Remy Horton
---
doc/guides/rel_n
On 30/05/2018 07:31, Pablo de Lara wrote:
[..]
Reported-by: Anatoly Burakov
Signed-off-by: Pablo de Lara
Acked-by: Remy Horton
ix is for the port representor
to maintain its own stats offset, so the port representor and VF
maintain independently-resettable counters.
Fixes: e0cb96204b71 ("net/i40e: add support for representor ports")
Signed-off-by: Remy Horton
---
drivers/net/i40e/i40e_ethdev.h | 2
Missing fixline, so v2 coming..
On 18/05/2018 08:59, Remy Horton wrote:
The resetting of stats on a VF involves the setting of an offset
that is subtracted from future calls, rather zeroing of counters.
However doing a stats reset on the port representor was also
adjusting the values forwarded
ix is for the port representor
to maintain its own stats offset, so the port representor and VF
maintain independently-resettable counters
Signed-off-by: Remy Horton
---
drivers/net/i40e/i40e_ethdev.h | 2 +
drivers/net/i40e/i40e_vf_representor.c | 119 +++
On 14/05/2018 12:29, Burakov, Anatoly wrote:
[..]
This failure is not caused by this patchset, and you should get similar
failures on master if you get these while testing my patchset. I am not
able to reproduce this issue, but i'll double-check the bounded reserve
code with a fine-toothed comb
On 11/05/2018 11:48, Mohammad Abdul Awal wrote:
[..]
+static uint16_t
+i40e_vf_representor_tx_burst(__rte_unused void *tx_queue,
+struct rte_mbuf **tx_pkts,
+uint16_t nb_pkts)
+{
+uint16_t idx_pkt;
+
+for (idx_pkt = 0; idx_pkt < nb_pkts; idx_pkt++)
+rte_pktmbuf_free(tx_pk
This patch adds Rx and Tx burst functions to the ixgbe
Port Representors, so that the implementation within
ixgbe PMD can be tested using applications such as
testpmd which require data-path functionality.
Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports")
Signed-of
This patch adds Rx and Tx burst functions to the i40e Port
Representors, so that the implementation within this PMD
can be tested using applications such as testpmd which
require data-path functionality.
Fixes: e0cb96204b71 ("net/i40e: add support for representor ports")
Signed-of
silently consuming packets to No-Op
Remy Horton (2):
net/i40e: fix missing Port Representor data-path
net/ixgbe: fix missing Port Representor data-path
drivers/net/i40e/i40e_vf_representor.c | 22 +++---
drivers/net/ixgbe/ixgbe_vf_representor.c | 22 +++---
2
On 03/05/2018 18:18, Anatoly Burakov wrote:
[..]
Also, fixup unit tests to account for the new behavior.
Tried running the tests but it fails on a boundary check:
RTE>>memzone_autotest
test basic memzone API
[...]
1GB Huge pages available
test alignment for memzone_reserve
check alignments an
)) {
Why the double-negation?
Otherwise, see no issues.
Acked-by: Remy Horton
-off-by: Anatoly Burakov
Acked-by: Remy Horton
fix this issue.
Reworded using proper tense:
In 17.11 port_id was changed from uint8_t to uint16_t, but eventdev
still uses the old fashion. This patch fixes this issue.
Signed-off-by: Lei Yao
Acked-by: Remy Horton
Looks good to me, and passed quick smoke test.
On 03/05/2018 13:38, Anatoly Burakov wrote:
[..]
Signed-off-by: Jianfeng Tan
Signed-off-by: Anatoly Burakov
Acked-by: Remy Horton
On 10/05/2018 03:22, Qi Zhang wrote:
[..]
Fixes: 3be82f5cc5e ("ethdev: support PMD-tuned Tx/Rx parameters")
Signed-off-by: Qi Zhang
Acked-by: Remy Horton
This patch adds Rx and Tx burst functions to the ixgbe
Port Representors, so that the implementation within
ixgbe PMD can be tested using applications such as
testpmd which require data-path functionality.
Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports")
Signed-of
This patch adds Rx and Tx burst functions to the i40e Port
Representors, so that the implementation within this PMD
can be tested using applications such as testpmd which
require data-path functionality.
Fixes: e0cb96204b71 ("net/i40e: add support for representor ports")
Signed-of
On 26/04/2018 13:03, Ananyev, Konstantin wrote:
[..]
I still think that if you'd like to extend rte_kvarrgs to be able to parse something
like: "key=[val1,val2,...,valn]",
you have to make it generic kvargs ability and put it into librte_kvargs, not
try to introduce your own new parser here.
I
On 25/04/2018 11:06, Thomas Monjalon wrote:
25/04/2018 11:40, Remy Horton:
On 24/04/2018 20:53, Thomas Monjalon wrote:
[..]
OK
Please can you add it as a comment in the parsing code?
We will need one or two examples in the commit message too.
Docs are being updated, so it should be in
On 24/04/2018 20:53, Thomas Monjalon wrote:
[..]
But I would like to review the devargs you are standardizing.
Unfortunately, I cannot find a documentation about it.
How users are supposed to use it?
Can you, at least, describe the syntax in the commit log, please?
The patch follows this pseud
On 19/04/2018 14:36, Ferruh Yigit wrote:
[..]
Zijie Pan (5):
ethdev: add access to eeprom
examples/ethtool: add a new command module-eeprom
net/ixgbe: add module EEPROM callbacks for ixgbe
net/e1000: add module EEPROM callbacks for e1000
net/i40e: add module EEPROM callbacks for i40e
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows individual PMDs to specify preferred parameter values.
Signed-off-by: Remy Ho
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows testpmd to make use of per-PMD tuned parameter values.
Signed-off-by: Remy Ho
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows individual PMDs to specify preferred parameter values.
Signed-off-by: Remy Ho
Added fallback values to rte_rte_[rt]x_queue_setup()
* Added fallback values to rte_eth_dev_configure()
* Corrected comment
* Removed deprecation notice
* Split RX and Tx into seperate structures
* Changed parameter names
Remy Horton (4):
ethdev: add support for PMD-tuned Tx/Rx parameters
net/e
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows individual PMDs to specify preferred parameter values.
Signed-off-by: Remy Ho
On 10/04/2018 05:18, Shreyansh Jain wrote:
[..]
I'll add in the snippet above. 18.05 integration deadline has I think
passed, but documentation changes will still get in.
@thomas you won't be integrating these default conf patches in 18.05?
I meant that since the v5 and v6 will only differ
On 09/04/2018 13:55, Shreyansh Jain wrote:
[..]
Documentation for burst mode changes to testpmd would need an update.
I guess, only when the user explicitly sets 'set burst 0' would the
driver defaults be picked up - isn't it?
Yes.
Maybe something like this:
--->8---
--- a/doc/guides/testp
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows individual PMDs to specify preferred parameter values.
Signed-off-by: Remy Ho
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows testpmd to make use of per-PMD tuned parameter values.
Signed-off-by: Remy Ho
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows individual PMDs to specify preferred parameter values.
Signed-off-by: Remy Ho
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows individual PMDs to specify preferred parameter values.
Signed-off-by: Remy Ho
ment
* Removed deprecation notice
* Split RX and Tx into seperate structures
* Changed parameter names
Remy Horton (4):
ethdev: add support for PMD-tuned Tx/Rx parameters
net/e1000: add TxRx tuning parameters
net/i40e: add TxRx tuning parameters
testpmd: make use of per-PMD TxRx paramet
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows testpmd to make use of per-PMD tuned parameter values.
Signed-off-by: Remy Ho
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows individual PMDs to specify preferred parameter values.
Signed-off-by: Remy Ho
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows individual PMDs to specify preferred parameter values.
Signed-off-by: Remy Ho
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows individual PMDs to specify preferred parameter values.
Signed-off-by: Remy Ho
RX and Tx into seperate structures
* Changed parameter names
Remy Horton (4):
ethdev: add support for PMD-tuned Tx/Rx parameters
net/e1000: add TxRx tuning parameters
net/i40e: add TxRx tuning parameters
testpmd: make use of per-PMD TxRx parameters
app/test-pmd/cmdline.c
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows individual PMDs to specify preferred parameter values.
Signed-off-by: Remy Ho
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows individual PMDs to specify preferred parameter values.
Signed-off-by: Remy Ho
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows testpmd to make use of per-PMD tuned parameter values.
Signed-off-by: Remy Ho
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows individual PMDs to specify preferred parameter values.
Signed-off-by: Remy Ho
moved fallback values from rte_eth_dev_info_get()
* Added fallback values to rte_rte_[rt]x_queue_setup()
* Added fallback values to rte_eth_dev_configure()
* Corrected comment
* Removed deprecation notice
* Split RX and Tx into seperate structures
* Changed parameter names
Remy Horton (4):
ethde
On 28/03/2018 08:18, Shreyansh Jain wrote:
[..]
Can the change for burst size too be accommodated in this patch? I
looked through them and they might not be as trivial as the change
above - but if that is incorporated in this, it might serve as
example for other applications.
Testpmd doesn't r
On 31/03/2018 01:01, Thomas Monjalon wrote:
[..]
uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT; /**< Number of RX descriptors. */
uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT; /**< Number of TX descriptors. */
These doxygen comments in the middle of the code are totally useless.
Did wonder why
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows testpmd to make use of per-PMD tuned parameter values.
Signed-off-by: Remy Ho
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows individual PMDs to specify preferred parameter values.
Signed-off-by: Remy Ho
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows individual PMDs to specify preferred parameter values.
Signed-off-by: Remy Ho
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows individual PMDs to specify preferred parameter values.
Signed-off-by: Remy Ho
ased to
* Removed fallback values from rte_eth_dev_info_get()
* Added fallback values to rte_rte_[rt]x_queue_setup()
* Added fallback values to rte_eth_dev_configure()
* Corrected comment
* Removed deprecation notice
* Split RX and Tx into seperate structures
* Changed parameter names
Remy Horto
On 20/03/2018 15:03, Ferruh Yigit wrote:
On 3/16/2018 3:36 PM, Remy Horton wrote:
[..]
struct rte_eth_dev_preferred_size {
uint16_t burst;
uint16_t ring;
uint16_t nb_queues;
};
struct rte_eth_dev_info {
/* ... */
struct rte_eth_dev_preferred_size
On 16/03/2018 13:54, Shreyansh Jain wrote:
On Thu, Mar 15, 2018 at 8:27 PM, Ferruh Yigit wrote:
On 3/15/2018 2:39 PM, Bruce Richardson wrote:
On Thu, Mar 15, 2018 at 01:57:13PM +, Ferruh Yigit wrote:
[..]
Hi Remy, Shreyansh,
What do you think about using a variable name consistent with
changed, 79 insertions(+)
Acked-by: Remy Horton
| 35 +++
lib/librte_ether/rte_ethdev_core.h | 12
5 files changed, 102 insertions(+)
Acked-by: Remy Horton
/rte_ethtool.h| 34 ++
4 files changed, 130 insertions(+)
Acked-by: Remy Horton
On 14/03/2018 15:10, Shreyansh Jain wrote:
[..]
What do you think renaming structure and variable name,
"preferred_dev_config" perhaps?
I missed this naming while reading this patch. In the deprecation
notice, 'preferred_size' was the name we came up with precisely on
this issue of structure h
On 14/03/2018 14:43, Ferruh Yigit wrote:
[..]
lib/librte_ether/rte_ethdev.c | 18 ++
lib/librte_ether/rte_ethdev.h | 15 +++
Can you please remove deprecation notice in this patch.
Done.
+ /* Defaults for drivers that don't implement preferred
+* q
On 14/03/2018 12:28, Shreyansh Jain wrote:
[..]
+ /* Use default specified by driver, if nb_rc_desc is zero */
^^^
Should be '_rx_'
[..]
Other than the above;
Ok - v2 on the way :)
Acked-by
On 12/03/2018 04:17, Zijie Pan wrote:
Add APIs to read information from the DPDK applictions.
It can be used to dump the EEPROM of plugin modules (SFP+, QSFP, etc.).
Quite a few checkpatch warnings regarding long lines, but did a quick
test with ixgbe and on the whole it looks good to me. CC
| 35 +++
lib/librte_ether/rte_ethdev_core.h | 12
5 files changed, 102 insertions(+)
Acked-by: Remy Horton
examples/ethtool/lib/rte_ethtool.h| 34 ++
4 files changed, 127 insertions(+)
Reviewed-by: Remy Horton
cmdline_parse_token_string_t pcmd_eeprom_token_cmd =
TOKEN_STRING_INITIALIZER(struct pcmd_intstr_params, cmd, "e
On 12/03/2018 04:17, Zijie Pan wrote:
[..]
Signed-off-by: Zijie Pan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 76 ++
1 file changed, 76 insertions(+)
Reviewed-by: Remy Horton
+ if (addr_mode & IXGBE_SFF_ADDRESSING_
The optimal values of several transmission & reception related
parameters, such as burst sizes, descriptor ring sizes, and number
of queues, varies between different network interface devices. This
patch allows individual PMDs to specify preferred parameter values.
Signed-off-by: Remy Ho
1 - 100 of 532 matches
Mail list logo
