Re: [PATCH] net/nfb: fix use after free

2024-10-11 Thread Martin Spinler
ointer 'rxq' used after 'rte_free' > > > > It is fixed by moving the assignment before freeing the parent pointer. > > > > Fixes: 80da7efbb4c4 ("eal: annotate allocation functions") > > > > Signed-off-by: Thomas Monjalon > Reviewed-by: David Marchand > > Acked-by: Martin Spinler

Re: [PATCH v6 08/20] net/nfb: use dynamic logtype

2024-01-12 Thread Martin Spinler
Tested-by: Martin Spinler Acked-by: Martin Spinler On Fri, 2023-12-22 at 09:11 -0800, Stephen Hemminger wrote: > All drivers should be using dynamic logtype. > > Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver") > Signed-off-by: Stephen Hemminger > ---

Re: [PATCH 0/3] net/nfb: driver cleanups

2024-01-12 Thread Martin Spinler
Tested-by: Martin Spinler Acked-by: Martin Spinler --- Hi! Thanks for the cleanup. I've tested that patchset and works fine. I'm just not sure, if the "net/nfb: use dynamic logtype" patch merges with the "Remove uses of PMD logtype" series as they slightly diffe

Re: [PATCH 3/3] net/nfb: use dynamic logtype

2023-12-12 Thread Martin Spinler
On Thu, 2023-12-07 at 10:56 -0800, Stephen Hemminger wrote: > All drivers should be using dynamic logtype. > > Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver") > Signed-off-by: Stephen Hemminger Tested-by: Martin Spinler

Re: [RFT] net/nfb: use dynamic logtype

2023-12-07 Thread Martin Spinler
Thanks for patch! There are some issues. On Wed, 2023-12-06 at 09:51 -0800, Stephen Hemminger wrote: > > diff --git a/drivers/net/nfb/nfb_log.h b/drivers/net/nfb/nfb_log.h > new file mode 100644 > index ..fac66a38d4b3 > --- /dev/null > +++ b/drivers/net/nfb/nfb_log.h > @@ -0,0 +1,13 @

Re: [PATCH v2 0/5] net/nfb: add missing libfdt dependency for build

2022-02-15 Thread Martin Spinler
Thank you for the review! On Tue, 2022-02-15 at 13:55 +, Ferruh Yigit wrote: > On 2/15/2022 12:55 PM, spin...@cesnet.cz wrote: > > From: Martin Spinler > > > > This series introduces standard RX timestamp offload flag support > > together with multiple MAC addres

Re: [PATCH 6/6] drivers/nfb: add support for more MAC addresses

2022-02-15 Thread Martin Spinler
On Mon, 2022-02-14 at 17:54 +, Ferruh Yigit wrote: > > > > @@ -530,7 +577,7 @@ nfb_eth_dev_init(struct rte_eth_dev *dev) > > > > eth_addr_init.addr_bytes[1] = eth_addr.addr_bytes[1]; > > > > eth_addr_init.addr_bytes[2] = eth_addr.addr_bytes[2]; > > > >     > > > > - nfb_e

Re: [PATCH 6/6] drivers/nfb: add support for more MAC addresses

2022-02-14 Thread Martin Spinler
On Mon, 2022-02-14 at 13:37 +, Ferruh Yigit wrote: > On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: > > From: Martin Spinler > > > > Extend the eth_dev_ops by add/remove MAC address functions. > > > > Signed-off-by: Martin Spinler > > ---

Re: [PATCH 5/6] drivers/nfb: fix multicast/promiscuous mode switching

2022-02-14 Thread Martin Spinler
On Mon, 2022-02-14 at 13:36 +, Ferruh Yigit wrote: > On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: > > From: Martin Spinler > > > > In the firmware, the promisc mode overrides the multicast mode. > > So when the promisc mode is turned off, driver must check if

Re: [PATCH 1/6] net/nfb: add missing libfdt dependency for build

2022-02-14 Thread Martin Spinler
On Mon, 2022-02-14 at 13:36 +, Ferruh Yigit wrote: > On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: > > From: Martin Spinler > > > > The driver uses some FDT manipulation functions from libfdt. > > Let the build system check for libfdt package. > > >

Re: [PATCH 3/6] drivers/nfb: do not report zero-sized TX burst

2022-02-14 Thread Martin Spinler
On Mon, 2022-02-14 at 13:35 +, Ferruh Yigit wrote: > On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: > > From: Martin Spinler > > > > Zero-sized TX burst floods the log no more. > > > > If you want this patch to be backported, you can update > commit lo

Re: [PATCH 2/6] drivers/nfb: fix array indexes in deinit functions

2022-02-14 Thread Martin Spinler
Hi Ferruh, thanks for all comments in this series. On Mon, 2022-02-14 at 13:34 +, Ferruh Yigit wrote: > On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: > > From: Martin Spinler > > > > The indexes in the for cycle were wrongly used and > > the code accessed outsi

Re: [PATCH v2] net/szedata2: remove driver

2021-11-11 Thread Martin Spinler
On Wed, 2021-11-10 at 16:08 +, Ferruh Yigit wrote: > On 11/10/2021 3:39 PM, Martin Spinler wrote: > > Remove the szedata2 device driver as the platform is no longer > > supported. > > > > Signed-off-by: Martin Spinler > > Thanks Martin for the update. >

Re: [PATCH v2] net/nfb: update links in documentation

2021-11-10 Thread Martin Spinler
On Wed, 2021-11-10 at 16:12 +, Ferruh Yigit wrote: > On 11/10/2021 3:39 PM, Martin Spinler wrote: > > Update the software dependency link because of website shutdown. > > > > Netcope Technologies was recently renamed to Magmio and no longer > > provides packages and

[PATCH v2] net/nfb: update links in documentation

2021-11-10 Thread Martin Spinler
and cooperates on the development of high speed network FPGA cards as well. Signed-off-by: Martin Spinler --- doc/guides/nics/nfb.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/nfb.rst b/doc/guides/nics/nfb.rst index 790fc48311..14560d38e4 100644

[PATCH v2] net/szedata2: remove driver

2021-11-10 Thread Martin Spinler
Remove the szedata2 device driver as the platform is no longer supported. Signed-off-by: Martin Spinler --- MAINTAINERS |6 - doc/guides/nics/features/szedata2.ini | 18 - .../img/szedata2_nfb200g_architecture.svg | 214 -- doc/guides/nics

[PATCH] net/nfb: update links in documentation

2021-11-10 Thread Martin Spinler
and cooperates on the development of high speed network FPGA cards as well. Signed-off-by: Martin Spinler --- doc/guides/nics/nfb.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/nfb.rst b/doc/guides/nics/nfb.rst index 790fc48311..14560d38e4 100644

[PATCH] net/szedata2: remove driver

2021-11-10 Thread Martin Spinler
Removing the szedata2 device driver as the platform is no longer supported. Signed-off-by: Martin Spinler --- MAINTAINERS |6 - doc/guides/nics/features/szedata2.ini | 18 - .../img/szedata2_nfb200g_architecture.svg | 214 -- doc/guides/nics