On Mon, 2022-02-14 at 13:36 +0000, Ferruh Yigit wrote:
> On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote:
> > From: Martin Spinler <spin...@cesnet.cz>
> >
> > The driver uses some FDT manipulation functions from libfdt.
> > Let the build system check for libfdt package.
> >
>
> I don't see 'libfdt.h' included by the driver, where/how libfdt
> is used?
I've prepared this dependency for the future commit (fw_version_get
feature), but i've omit it from this series for now due to internal
discussion about versioning (can take a week or two) and doesn't
realise that this 'libfdt' commit is now needless.
The second fact is, it will not pass even in the current form without
libfdt, because the netcope-common package (precisely the libnetcope
headers included in DPDK driver) doesn't specify the libfdt-devel
dependency. But this is a defect in the netcope-common package and
should be fixed there.
Anyway, I can remove this patch from series, but not sure if it will
not confuse the Patchwork series/version matching as this is the first
patch.
Does it make sense to you to remove this patch from this series
completely?
>
> Also what do you think to document this external dependency
> and its usage in the driver documentation?
>
> > Signed-off-by: Martin Spinler <spin...@cesnet.cz>
> > ---
> > drivers/net/nfb/meson.build | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/net/nfb/meson.build b/drivers/net/nfb/meson.build
> > index bb5f66a09a..c080c06bf9 100644
> > --- a/drivers/net/nfb/meson.build
> > +++ b/drivers/net/nfb/meson.build
> > @@ -9,6 +9,12 @@ if is_windows
> > subdir_done()
> > endif
> >
> > +if has_libfdt == 0
> > + build = false
> > + reason = 'missing dependency, "libfdt"'
> > + subdir_done()
> > +endif
> > +
> > dep = dependency('netcope-common', required: false, method: 'pkg-config')
> > reason = 'missing dependency, "libnfb"'
> > build = dep.found()
>
