rte_distributor_process(d, &bufs[i], 1);
> + }
>
> rte_mempool_put_bulk(p, (void *)bufs, num_workers);
>
> rte_distributor_process(d, NULL, 0);
> + rte_distributor_flush(d);
> rte_eal_mp_wait_lcore();
> quit = 0;
> worker_idx = 0;
Tested-by: Lukasz Wojciechowski
Reviewed-by: Lukasz Wojciechowski
--
Lukasz Wojciechowski
Principal Software Engineer
Samsung R&D Institute Poland
Samsung Electronics
Office +48 22 377 88 25
l.wojciec...@partner.samsung.com
el changed from debug to info
>>
>> Fixes: 6c7216eefd63 ("eal: fix log level of early messages")
>> Fixes: 1c806ae5c3ac ("eal/windows: support command line options parsing")
>> Cc: sta...@dpdk.org
>>
>> Signed-off-by: David Marchand
> Acked-by:
Thank you guys!
W dniu 29.01.2021 o 09:03, David Marchand pisze:
> On Thu, Jan 28, 2021 at 3:10 PM David Marchand
> wrote:
>> On Tue, Jan 19, 2021 at 4:59 AM Lukasz Wojciechowski
>> wrote:
>>> The distributor library implementation uses a cyclic queue to store
>&g
> On Tue, Jan 19, 2021 at 4:59 AM Lukasz Wojciechowski
> wrote:
>> According to the discussion in this thread:
>> https://protect2.fireeye.com/v1/url?k=24ecce33-7b77f77c-24ed457c-0cc47a30
>> d446-e317a6beb8cfa273&q=1&e=f8bb12df-3698-4bce-a7b7-d72e22b91431&
<https://protect2.fireeye.com/v1/url?k=75833b33-2a18027e-7582b07c-0cc47aa8f5ba-f87ac679cb8c13d6&q=1&e=342f3a9f-26e9-459f-b456-e4c0f24f9551&u=https%3A%2F%2Fwww.iol.unh.edu%2F>
>
>
>
> --
> *Lincoln Lavoie*
> Senior Engineer, Broadband Technologies
> 21 Madbury Rd.,
impossible to drop any packets.
It also cleans up duplicated code in the same test.
Bugzilla ID: 612
Fixes: c0de0eb82e40 ("distributor: switch over to new API")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
---
app/test/test_distributor.c | 20 +++--
ed in CI lab,
on which the issue occurred?
Lukasz Wojciechowski (1):
test/distributor: prevent return buffer overload
app/test/test_distributor.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
--
2.17.1
ndled 0 packets
> Worker 60 handled 0 packets
> Worker 61 handled 0 packets
> Worker 62 handled 0 packets
> Sanity test with non-zero hashes done
> === testing big burst (burst) ===
> line 258: Missing packets, expected 783
> Test Failed
> RTE>>
> --- stderr ---
&
Changes in distributor tests look good.
All tests pass
W dniu 26.10.2020 o 06:21, Thomas Monjalon pisze:
> The test used the deprecated mbuf field udata64.
> It is moved to a dynamic field in order to allow removal of udata64.
>
> Signed-off-by: Thomas Monjalon
Acked-by: Lukasz W
-Werror=aggressive-loop-optimizations]
>
> Fixes: d48415e1fee3 ("examples/performance-thread: add l3fwd-thread app")
> Cc: ian.be...@intel.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Honnappa Nagarahalli
> Reviewed-by: Ruifeng Wang
Tested-by: Lukasz Wojc
est/rcu: add API and functional tests")
>>> Cc: sta...@dpdk.org
>>>
>>> Signed-off-by: Honnappa Nagarahalli
>>> Reviewed-by: Ruifeng Wang
Tested-by: Lukasz Wojciechowski
Reviewed-by: Lukasz Wojciechowski
>>> ---
>>>app/tes
if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0)
> goto error;
> rte_hash_free(h[0]);
> @@ -1236,6 +1245,12 @@ test_rcu_qsbr_mw_mv_mqs(void)
> unsigned int i, j;
> unsigned int test_cores;
>
> + if (RTE_MAX_LCORE < 5
ile,
>> /* Perf test only */
>> { "perf", 0, 0, ARG_PERF_MODE},
>> /* Number of iterations to run with perf test */
>> - { "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS}
>> +{ "nb_iter", 1,
to crypto based session create APIs.
>
> Signed-off-by: Akhil Goyal
Reviewed-by: Lukasz Wojciechowski
Tested-by: Lukasz Wojciechowski
> ---
> Changes in v5:
> fixed security test.
>
> Changes in v4:
> rebase on TOT
> addressed comments from Lukasz on v3
>
> Chan
EST_ASSERT_MEMPOOL_USAGE(1);
+ TEST_ASSERT_PRIV_MP_USAGE(1);
TEST_ASSERT_SESSION_COUNT(1);
return TEST_SUCCESS;
Best regards
Lukasz
W dniu 18.10.2020 o 11:30, Lukasz Wojciechowski pisze:
> Hi Akhil,
>
> If you replace mock_session_create_exp.ret wit
e as well: TEST_ASSERT_PRIV_MP_USAGE(1);
> Thanks for the review of the patch.
>
> This is causing the test to fail. And I cannot spend more time in debugging
> this right now.
> Since we are approaching RC1 deadline and the intent of the patch is to add a
> new
> Paramet
N_CALL_RET(rte_security_session_destroy,
> ret, -1, "%d");
> TEST_ASSERT_MOCK_CALLS(mock_session_destroy_exp, 1);
> TEST_ASSERT_MEMPOOL_USAGE(1);
nit: you can add and assertion here as well: TEST_ASSERT_PRIV_MP_USAGE(1);
> TEST_ASSERT_SESSION_COUN
W dniu 16.10.2020 o 17:42, Honnappa Nagarahalli pisze:
>
>
>> W dniu 16.10.2020 o 14:43, Lukasz Wojciechowski pisze:
>>> Hi Honnappa,
>>>
>>> Thank you for your answer.
>>> In the current v7 version I followed your advise and used RELAXED memory
distributor: add unit tests")
>> Cc: bruce.richard...@intel.com
>> Fixes: c0de0eb82e40 ("distributor: switch over to new API")
>> Cc: david.h...@intel.com
>> Cc: sta...@dpdk.org
>>
>> Signed-off-by: Lukasz Wojciechowski
>> Acked-b
ionally this patch cleans up unused variables.
>>
>> Fixes: c0de0eb82e40 ("distributor: switch over to new API")
>> Cc: david.h...@intel.com
>> Cc: sta...@dpdk.org
>>
>> Signed-off-by: Lukasz Wojciechowski
>> Acked-by: David Hunt
>
I reordered patches: "synchronize lcores statistics" and "fix freeing
mbufs" to avoid changing same code.
Many thanks for the review
Lukasz
>
> Thanks,
> Honnappa
>
>> -Original Message-----
>> From: dev On Behalf Of Lukasz Wojciechowski
>&g
matching algorithms.
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
app/test/test_distributor.c | 141
1 file changed, 141 insertions(+)
diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c
index fdb6ea9ce..cfae5a1ac 100644
bufptr64 until
>> handshake on it is cleared by distributor lcore.
>>
>> Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
>> Cc: david.h...@intel.com
>> Cc: sta...@dpdk.org
>>
>> Signed-off-by: Lukasz Wojciechowski
>> Acked
successfully processed packets reaches required by test.
Change is applied to every first call in test case.
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
app/test/test_distributor.c | 32 +++-
1 file changed, 27 insertions(+), 5
flight packets for each worker in bufs[].count.
Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.c | 12 +-
Instead of making delays in test code and waiting
for worker hopefully to reach proper states,
synchronize worker shutdown test cases with spin lock
on atomic variable.
Fixes: c0de0eb82e40 ("distributor: switch over to new API")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-
The patch clears distributors returns buffer
in clear_returns() by setting start and count to 0.
Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_d
("distributor: add unit tests")
Cc: bruce.richard...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
app/test/test_distributor.c | 39 +
1 file changed, 27 insertions(+), 12 deletions(-)
diff --git
nding packets one by one. Each sent packet
causes exactly one worker to quit.
Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
---
app/test/test_distributor.c | 5 +++--
1 file change
.@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.h | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/lib/librte_distributor/rte_distributor.h
b/lib/librte_distributor/rte_distribut
")
Cc: bruce.richard...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Tested-by: David Hunt
---
app/test/test_distributor.c | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c
index
mbufs to mempool
is moved to test procedure run on distributor thread
from worker threads.
Additionally this patch cleans up unused variables.
Fixes: c0de0eb82e40 ("distributor: switch over to new API")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked
")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_distributor/rte_distributor.c
b/lib/librte_distributor/rte_distributor.c
index
parameter.
Distributor tests are also updated passing NULL as oldpkt and
0 as number of returned packets, where packets are not returned.
Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
c: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/distributor_private.h | 3 +
lib/librte_distributor/rte_distributor.c | 175 +++
2 files changed, 146 insertions(+), 32 deletions(-)
diff -
.@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_distributor/rte_distributor.c
b/lib/librte_distributor/rte_distributor.c
index 6e3eae58f..9fea3f
h returned packets
in distributor remains empty.
Fixes: c3eabff124e6 ("distributor: add unit tests")
Cc: bruce.richard...@intel.com
Fixes: c0de0eb82e40 ("distributor: switch over to new API")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked
om
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/librte_distributor/rte_distributor.c
b/lib/librte_distributor/rte_distributor.c
index c6b19a388.
tested by statements from v1
v2:
* assign NULL to freed mbufs in distributor test
* fix handshake check on legacy single distributor
rte_distributor_return_pkt_single()
* add patch 7 passing NULL to legacy API calls if no bufs are returned
* add patch 8 fixing API documentation
Lukasz Wojcie
sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.c| 12
lib/librte_distributor/rte_distributor_single.c | 4
2 files changed, 16 insertions(+)
diff --git a/lib/librte_distributor/rte_distr
W dniu 16.10.2020 o 14:43, Lukasz Wojciechowski pisze:
> Hi Honnappa,
>
> Thank you for your answer.
> In the current v7 version I followed your advise and used RELAXED memory
> model.
> And it works without any issues. I guess after fixing other issues found
> since v4
>
>>>
>>>> Statistics of handled packets are cleared and read on main lcore,
>>>> while they are increased in workers handlers on different lcores.
>>>>
>>>> Without synchronization occasionally showed invalid values.
>>>> This pat
rity_session_creat
>> e,
>>> sess, NULL, "%p");
>>> TEST_ASSERT_MOCK_CALLS(mock_session_create_exp, 0);
>>> @@ -781,7 +809,7 @@ test_session_create_inv_configuration(void)
>>>}
>>>
>>>/**
>>> - * Test execution of rte_security_session_create with NULL mp parameter
>>> + * Test execution of rte_security_session_create with NULL mempools
>>> */
>>>static int
>>>test_session_create_inv_mempool(void)
>>> @@ -790,7 +818,7 @@ test_session_create_inv_mempool(void)
>>> struct rte_security_session *sess;
>>>
>>> sess = rte_security_session_create(&ut_params->ctx, &ut_params-
>>> conf,
>>> - NULL);
>>> + NULL, NULL);
>> It would be best to add a new testcase for verification of passing NULL
>> private mempool.
>> If you pass NULL as the primary mempool as in this testcase, the
>> verification of priv mempool (rte_securitry.c:37) won't ever happen
>> because rte_security_session_create() will return in line 36.
> Added a new test. However that was really unnecessary and was an overkill
> To add a new case for so many negative cases.
>
> Please have a look at v3 and ack it if no further comments.
>
> Regards,
> Akhil
>
--
Lukasz Wojciechowski
Principal Software Engineer
Samsung R&D Institute Poland
Samsung Electronics
Office +48 22 377 88 25
l.wojciec...@partner.samsung.com
_sa *sa,
> }
>
> ips->security.ses = rte_security_session_create(sec_ctx,
> - &sess_conf, skt_ctx->session_pool);
> + &sess_conf, skt_ctx->session_pool,
> +
urity.c
> b/lib/librte_security/rte_security.c
> index 515c29e04..ee4666026 100644
> --- a/lib/librte_security/rte_security.c
> +++ b/lib/librte_security/rte_security.c
> @@ -26,18 +26,21 @@
> struct rte_security_session *
> rte_security_session_create(struct rte_security_ctx *instance,
> struct rte_security_session_conf *conf,
> - struct rte_mempool *mp)
> + struct rte_mempool *mp,
> + struct rte_mempool *priv_mp)
> {
> struct rte_security_session *sess = NULL;
>
> RTE_PTR_CHAIN3_OR_ERR_RET(instance, ops, session_create, NULL, NULL);
> RTE_PTR_OR_ERR_RET(conf, NULL);
> RTE_PTR_OR_ERR_RET(mp, NULL);
> + RTE_PTR_OR_ERR_RET(priv_mp, NULL);
>
> if (rte_mempool_get(mp, (void **)&sess))
> return NULL;
>
> - if (instance->ops->session_create(instance->device, conf, sess, mp)) {
> + if (instance->ops->session_create(instance->device, conf,
> + sess, priv_mp)) {
> rte_mempool_put(mp, (void *)sess);
> return NULL;
> }
> diff --git a/lib/librte_security/rte_security.h
> b/lib/librte_security/rte_security.h
> index 16839e539..1710cdd6a 100644
> --- a/lib/librte_security/rte_security.h
> +++ b/lib/librte_security/rte_security.h
> @@ -386,6 +386,7 @@ struct rte_security_session {
>* @param instancesecurity instance
>* @param confsession configuration parameters
>* @param mp mempool to allocate session objects from
> + * @param priv_mp mempool to allocate session private data objects from
>* @return
>* - On success, pointer to session
>* - On failure, NULL
> @@ -393,7 +394,8 @@ struct rte_security_session {
> struct rte_security_session *
> rte_security_session_create(struct rte_security_ctx *instance,
> struct rte_security_session_conf *conf,
> - struct rte_mempool *mp);
> + struct rte_mempool *mp,
> + struct rte_mempool *priv_mp);
>
> /**
>* Update security session as specified by the session configuration
Best regards
Lukasz
--
Lukasz Wojciechowski
Principal Software Engineer
Samsung R&D Institute Poland
Samsung Electronics
Office +48 22 377 88 25
l.wojciec...@partner.samsung.com
W dniu 10.10.2020 o 10:12, David Marchand pisze:
> Hello Lukasz,
>
> On Sat, Oct 10, 2020 at 1:26 AM Lukasz Wojciechowski
> wrote:
>> W dniu 09.10.2020 o 23:41, Lukasz Wojciechowski pisze:
>> More bad news - same issue just appeared on travis for v6.
>> Good news
successfully processed packets reaches required by test.
Change is applied to every first call in test case.
Signed-off-by: Lukasz Wojciechowski
---
app/test/test_distributor.c | 32 +++-
1 file changed, 27 insertions(+), 5 deletions(-)
diff --git a/app/test
flight packets for each worker in bufs[].count.
Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.c | 12 +-
The patch clears distributors returns buffer
in clear_returns() by setting start and count to 0.
Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_d
.@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_distributor/rte_distributor.c
b/lib/librte_distributor/rte_distributor.c
index 9fd7dcab7..4bd23a
matching algorithms.
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
app/test/test_distributor.c | 141
1 file changed, 141 insertions(+)
diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c
index e8dd75078..4fc10b3cc 100644
Instead of making delays in test code and waiting
for worker hopefully to reach proper states,
synchronize worker shutdown test cases with spin lock
on atomic variable.
Fixes: c0de0eb82e40 ("distributor: switch over to new API")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-
.@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.h | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/lib/librte_distributor/rte_distributor.h
b/lib/librte_distributor/rte_distribut
h returned packets
in distributor remains empty.
Fixes: c3eabff124e6 ("distributor: add unit tests")
Cc: bruce.richard...@intel.com
Fixes: c0de0eb82e40 ("distributor: switch over to new API")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked
: add unit tests")
Cc: bruce.richard...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
app/test/test_distributor.c | 43 +
1 file changed, 29 insertions(+), 14 deletions(-)
diff --git a/app/test/test_distribut
mbufs to mempool
is moved to test procedure run on distributor thread
from worker threads.
Additionally this patch cleans up unused variables.
Fixes: c0de0eb82e40 ("distributor: switch over to new API")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked
")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_distributor/rte_distributor.c
b/lib/librte_distributor/rte_distributor.c
index
")
Cc: bruce.richard...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Tested-by: David Hunt
---
app/test/test_distributor.c | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c
index
c: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/distributor_private.h | 3 +
lib/librte_distributor/rte_distributor.c | 175 +++
2 files changed, 146 insertions(+), 32 deletions(-)
diff -
om
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/librte_distributor/rte_distributor.c
b/lib/librte_distributor/rte_distributor.c
index 89493c331.
parameter.
Distributor tests are also updated passing NULL as oldpkt and
0 as number of returned packets, where packets are not returned.
Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
ndshake check on legacy single distributor
rte_distributor_return_pkt_single()
* add patch 7 passing NULL to legacy API calls if no bufs are returned
* add patch 8 fixing API documentation
Lukasz Wojciechowski (16):
distributor: fix missing handshake synchronization
distributor: fix hands
sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.c| 14 ++
lib/librte_distributor/rte_distributor_single.c | 4
2 files changed, 18 insertions(+)
diff --git a/lib/librte_distributor/rte_distr
W dniu 09.10.2020 o 23:41, Lukasz Wojciechowski pisze:
>
> Hi David,
>
> W dniu 09.10.2020 o 14:53, David Marchand pisze:
>> Hello Lukasz,
>>
>> On Thu, Oct 8, 2020 at 11:17 PM Lukasz Wojciechowski
>> wrote:
>>> I'm here if you have any ques
The patch clears distributors returns buffer
in clear_returns() by setting start and count to 0.
Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_d
flight packets for each worker in bufs[].count.
Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.c | 12 +-
matching algorithms.
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
app/test/test_distributor.c | 141
1 file changed, 141 insertions(+)
diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c
index e8dd75078..4fc10b3cc 100644
.@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.h | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/lib/librte_distributor/rte_distributor.h
b/lib/librte_distributor/rte_distribut
.@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_distributor/rte_distributor.c
b/lib/librte_distributor/rte_distributor.c
index 9fd7dcab7..4bd23a
h returned packets
in distributor remains empty.
Fixes: c3eabff124e6 ("distributor: add unit tests")
Cc: bruce.richard...@intel.com
Fixes: c0de0eb82e40 ("distributor: switch over to new API")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked
mbufs to mempool
is moved to test procedure run on distributor thread
from worker threads.
Additionally this patch cleans up unused variables.
Fixes: c0de0eb82e40 ("distributor: switch over to new API")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked
Instead of making delays in test code and waiting
for worker hopefully to reach proper states,
synchronize worker shutdown test cases with spin lock
on atomic variable.
Fixes: c0de0eb82e40 ("distributor: switch over to new API")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-
")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_distributor/rte_distributor.c
b/lib/librte_distributor/rte_distributor.c
index
: add unit tests")
Cc: bruce.richard...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
app/test/test_distributor.c | 43 +
1 file changed, 29 insertions(+), 14 deletions(-)
diff --git a/app/test/test_distribut
")
Cc: bruce.richard...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Tested-by: David Hunt
---
app/test/test_distributor.c | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c
index
c: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/distributor_private.h | 3 +
lib/librte_distributor/rte_distributor.c | 175 +++
2 files changed, 146 insertions(+), 32 deletions(-)
diff -
parameter.
Distributor tests are also updated passing NULL as oldpkt and
0 as number of returned packets, where packets are not returned.
Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.c| 14 ++
lib/librte_distributor/rte_distributor_single.c | 4
2 files changed, 18 insertions(+)
diff --git a/lib/librte_distributor/rte_distr
om
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/librte_distributor/rte_distributor.c
b/lib/librte_distributor/rte_distributor.c
index 89493c331.
API calls if no bufs are returned
* add patch 8 fixing API documentation
Lukasz Wojciechowski (15):
distributor: fix missing handshake synchronization
distributor: fix handshake deadlock
distributor: do not use oldpkt when not needed
distributor: handle worker shutdown in burst mode
tes
Hi David,
W dniu 09.10.2020 o 14:53, David Marchand pisze:
> Hello Lukasz,
>
> On Thu, Oct 8, 2020 at 11:17 PM Lukasz Wojciechowski
> wrote:
>> I'm here if you have any questions or suggestions
> Unfortunately, I can see a timeout on the distributor autotest in Travi
Hi David,
W dniu 09.10.2020 o 14:50, David Hunt pisze:
> Hi Lukasz,
>
> On 8/10/2020 6:23 AM, Lukasz Wojciechowski wrote:
>> All of the former tests analyzed only statistics
>> of packets processed by all workers.
>> The new test verifies also if packets are processe
W dniu 09.10.2020 o 14:35, David Hunt pisze:
> Hi Lukasz,
>
> On 9/10/2020 1:31 PM, David Hunt wrote:
>>
>> On 8/10/2020 6:23 AM, Lukasz Wojciechowski wrote:
>>> Fix improper indexes while comparing tags.
>>> In the find_match_scalar() function:
>&
W dniu 09.10.2020 o 14:13, David Hunt pisze:
>
> On 8/10/2020 10:07 PM, Lukasz Wojciechowski wrote:
>> W dniu 08.10.2020 o 16:26, David Hunt pisze:
>>> On 8/10/2020 6:23 AM, Lukasz Wojciechowski wrote:
>>>> The burst version of distributor implementation wa
W dniu 08.10.2020 o 09:30, David Marchand pisze:
> On Thu, Oct 8, 2020 at 7:24 AM Lukasz Wojciechowski
> wrote:
>> During review and verification of the patch created by Sarosh Arif:
>> "test_distributor: prevent memory leakages from the pool" I found out
>> t
W dniu 08.10.2020 o 16:26, David Hunt pisze:
>
> On 8/10/2020 6:23 AM, Lukasz Wojciechowski wrote:
>> The burst version of distributor implementation was missing proper
>> handling of worker shutdown. A worker processing packets received
>> from distributor can call rt
asn't able now to catch even
a single failure using the ACQ/REL memory models.
I'll test it maybe tomorrow with RELAXED to see if it will work.
Best regards
Lukasz
W dniu 02.10.2020 o 13:25, Lukasz Wojciechowski pisze:
> Hi Honnappa,
>
> Many thanks for the review!
>
>
The patch clears distributors returns buffer
in clear_returns() by setting start and count to 0.
Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
---
lib/librte_distributor/rte_distrib
matching algorithms.
Signed-off-by: Lukasz Wojciechowski
---
app/test/test_distributor.c | 141
1 file changed, 141 insertions(+)
diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c
index 1e0a079ff..0404e463a 100644
--- a/app/test
.@dpdk.org
Signed-off-by: Lukasz Wojciechowski
---
lib/librte_distributor/rte_distributor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_distributor/rte_distributor.c
b/lib/librte_distributor/rte_distributor.c
index 9fd7dcab7..4bd23a990 100644
flight packets for each worker in bufs[].count.
Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
---
lib/librte_distributor/rte_distributor.c | 12 +---
1 file changed, 5 insert
.@dpdk.org
Signed-off-by: Lukasz Wojciechowski
---
lib/librte_distributor/rte_distributor.h | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/lib/librte_distributor/rte_distributor.h
b/lib/librte_distributor/rte_distributor.h
index 327c0c4ab..a073e6
Instead of making delays in test code and waiting
for worker hopefully to reach proper states,
synchronize worker shutdown test cases with spin lock
on atomic variable.
Fixes: c0de0eb82e40 ("distributor: switch over to new API")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-
mbufs to mempool
is moved to test procedure run on distributor thread
from worker threads.
Additionally this patch cleans up unused variables.
Fixes: c0de0eb82e40 ("distributor: switch over to new API")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked
h returned packets
in distributor remains empty.
Fixes: c3eabff124e6 ("distributor: add unit tests")
Cc: bruce.richard...@intel.com
Fixes: c0de0eb82e40 ("distributor: switch over to new API")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked
: add unit tests")
Cc: bruce.richard...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
app/test/test_distributor.c | 43 +
1 file changed, 29 insertions(+), 14 deletions(-)
diff --git a/app/test/test_distribut
")
Cc: bruce.richard...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Tested-by: David Hunt
---
app/test/test_distributor.c | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c
index
")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
---
lib/librte_distributor/rte_distributor.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_distributor/rte_distributor.c
b/lib/librte_distributor/rte_distributor.c
index 115443fc0..9fd7dcab7 10
parameter.
Distributor tests are also updated passing NULL as oldpkt and
0 as number of returned packets, where packets are not returned.
Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
om
Cc: sta...@dpdk.org
Signed-off-by: Lukasz Wojciechowski
Acked-by: David Hunt
---
lib/librte_distributor/rte_distributor.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/librte_distributor/rte_distributor.c
b/lib/librte_distributor/rte_distributor.c
index 89493c331.
1 - 100 of 307 matches
Mail list logo
