Re: [PATCH v2] test/bitops: check worker lcore availability

2024-10-25 Thread Jack Bond-Preston
Acked-by: Jack Bond-Preston On 25/10/2024 08:39, David Marchand wrote: Coverity is not able to understand that having 2 lcores means that rte_get_next_lcore(-1, 0, 1) can't return RTE_MAX_LCORE. Add a check. Coverity issue: 445382, 445383, 445384, 445387, 445389, 445391 Fixes: 35326b6

Re: [PATCH v2 2/6] crypto/openssl: support EDDSA

2024-09-09 Thread Jack Bond-Preston
res...@foss.arm.com/ for more information. I suppose for an initial implementation this could be ok - it's correct, just slow. Cheers, Jack

Re: [PATCH v3 5/5] eal: extend bitops to handle volatile pointers

2024-08-12 Thread Jack Bond-Preston
On 12/08/2024 13:49, Mattias Rönnblom wrote: Have rte_bit_[test|set|clear|assign|flip]() and rte_bit_atomic_*() handle volatile-marked pointers. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Jack Bond-Preston

Re: [PATCH v3 4/5] eal: add unit tests for atomic bit access functions

2024-08-12 Thread Jack Bond-Preston
On 12/08/2024 13:49, Mattias Rönnblom wrote: Extend bitops tests to cover the rte_bit_atomic_*() family of functions. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston

Re: [PATCH v3 3/5] eal: add atomic bit operations

2024-08-12 Thread Jack Bond-Preston
: Tyler Retzlaff Acked-by: Jack Bond-Preston

Re: [PATCH v3 2/5] eal: add unit tests for bit operations

2024-08-12 Thread Jack Bond-Preston
On 12/08/2024 13:49, Mattias Rönnblom wrote: Extend bitops tests to cover the rte_bit_[test|set|clear|assign|flip]() functions. The tests are converted to use the test suite runner framework. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack

Re: [PATCH v3 1/5] eal: extend bit manipulation functionality

2024-08-12 Thread Jack Bond-Preston
-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston

Re: [PATCH v2 5/5] eal: extend bitops to handle volatile pointers

2024-08-12 Thread Jack Bond-Preston
On 09/08/2024 10:58, Mattias Rönnblom wrote: +#define __RTE_GEN_BIT_ATOMIC_TEST(v, qualifier, size) \ __rte_experimental \ static inline bool \ - __rte_bit_atomic_test

Re: [PATCH v2 3/5] eal: add atomic bit operations

2024-08-12 Thread Jack Bond-Preston
On 09/08/2024 10:58, Mattias Rönnblom wrote: + +#define __RTE_GEN_BIT_ATOMIC_OPS(size) \ + __RTE_GEN_BIT_ATOMIC_TEST(size) \ + __RTE_GEN_BIT_ATOMIC_SET(size) \ + __RTE_GEN_BIT_ATOMIC_CLEAR(size)\ + __RTE_GEN

Re: [PATCH v2 1/5] eal: extend bit manipulation functionality

2024-08-12 Thread Jack Bond-Preston
On 09/08/2024 10:58, Mattias Rönnblom wrote: + +__RTE_GEN_BIT_TEST(, test,, 32) +__RTE_GEN_BIT_SET(, set,, 32) +__RTE_GEN_BIT_CLEAR(, clear,, 32) +__RTE_GEN_BIT_ASSIGN(, assign,, 32) +__RTE_GEN_BIT_FLIP(, flip,, 32) + +__RTE_GEN_BIT_TEST(, test,, 64) +__RTE_GEN_BIT_SET(, set,, 64) +__RTE_GEN_BIT

Re: [PATCH] doc: update Arm IPsec-MB dependency version

2024-08-01 Thread Jack Bond-Preston
On 31/07/2024 22:26, Wathsala Vithanage wrote: Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.07.08 in snow3g and zuc documentation. Signed-off-by: Wathsala Vithanage Reviewed-by: Dhruv Tripathi Acked-by: Jack Bond-Preston --- .mailmap | 1 + doc

Re: [PATCH 2/2] doc: remove use of -n 4 option in documentation

2024-07-19 Thread Jack Bond-Preston
On 18/07/2024 19:43, Stephen Hemminger wrote: Many places in the documentation are using -n 4 to set the number of memory channels. This should not be recommended since it is not always right and the default should be used instead. Signed-off-by: Stephen Hemminger Acked-by: Jack Bond-Preston

[PATCH] doc: clarify mempool striding optimisation on Arm

2024-07-15 Thread Jack Bond-Preston
The mempool memory channel striding optimisation is not necessary on Arm platforms. Update the Programmer's Guide's mempool section to clarify this. Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- doc/guides/prog_guide/mempool_lib.rst | 6 ++ 1 file

Re: [EXTERNAL] [PATCH v4 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

2024-07-03 Thread Jack Bond-Preston
On 03/07/2024 11:49, Jack Bond-Preston wrote: On 02/07/2024 16:39, Akhil Goyal wrote: I am seeing below errors when it is compiled with openssl 3.0 [1/30] Compiling C object 'drivers/a715181@@tmp_rte_crypto_openssl@sta/crypto_openssl_rte_openssl_pmd_ops.c.o'. FAILED: drive

[PATCH v5 5/5] crypto/openssl: only set cipher padding once

2024-07-03 Thread Jack Bond-Preston
28.05 | 135.40 | 5.7% | |4096 |139.45 | 143.76 | 3.1% | Signed-off-by: Jack Bond-Preston Acked-by: Kai Ji Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

[PATCH v5 4/5] crypto/openssl: per-qp auth context clones

2024-07-03 Thread Jack Bond-Preston
| 1122.5% | | 256 | 3.70 | 35.30 | 853.7% | |1024 | 15.22 | 74.27 | 387.8% | |2048 | 30.20 | 91.08 | 201.6% | |4096 | 56.92 | 102.76 |80.5% | Signed-off-by: Jack

[PATCH v5 3/5] crypto/openssl: per-qp cipher context clones

2024-07-03 Thread Jack Bond-Preston
| 64.86 | 520.3% | |1024 | 40.97 | 113.80 | 177.7% | |2048 | 73.25 | 130.21 |77.8% | |4096 |103.89 | 140.62 |35.4% | Signed-off-by: Jack Bond-Preston Acked-by: Kai Ji Reviewed-by: Wathsala

[PATCH v5 2/5] crypto/openssl: only init 3DES-CTR key + impl once

2024-07-03 Thread Jack Bond-Preston
| 1.77 | 2.6% | |2048 | 1.76 | 1.78 | 1.1% | |4096 | 1.79 | 1.80 | 0.6% | Signed-off-by: Jack Bond-Preston Acked-by: Kai Ji Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 21

[PATCH v5 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

2024-07-03 Thread Jack Bond-Preston
2048 |147.69 | 80.91 | -45.2% | |4096 |167.39 | 121.25 | -27.6% | Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API") Cc: sta...@dpdk.org Signed-off-by: Jack Bond-Preston Acked-by: Kai Ji Reviewed-by: Wat

[PATCH v5 0/5] OpenSSL PMD Optimisations

2024-07-03 Thread Jack Bond-Preston
s, so I haven't attached them for now. If you are interested in reviewing them, please reach out and I will find a way to get them to you. Jack Bond-Preston (5): crypto/openssl: fix GCM and CCM thread unsafe ctxs crypto/openssl: only init 3DES-CTR key + impl once crypto/openssl: pe

Re: [EXTERNAL] [PATCH v4 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

2024-07-03 Thread Jack Bond-Preston
On 02/07/2024 16:39, Akhil Goyal wrote: I am seeing below errors when it is compiled with openssl 3.0 [1/30] Compiling C object 'drivers/a715181@@tmp_rte_crypto_openssl@sta/crypto_openssl_rte_openssl_pmd_ops.c.o'. FAILED: drivers/a715181@@tmp_rte_crypto_openssl@sta/crypto_openssl_rte_openssl_

[PATCH 2/2] maintainers: update maintainers

2024-06-28 Thread Jack Bond-Preston
Update maintainers for Bitops, Ticketlock, and ARMv8 Crypto. Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index dfc022c0c6..6cfcf4cafe 100644 --- a

[PATCH 1/2] maintainers: update for ARMv7 and ARMv8

2024-06-28 Thread Jack Bond-Preston
Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 533f707d5f..dfc022c0c6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -279,13 +279,13 @@ F: lib/eal/common

Re: [PATCH] app/test-crypto-perf: add shared session option

2024-06-18 Thread Jack Bond-Preston
Hi Brian, Would be good to add a doc update too. Thanks. Acked-by: Brian Dooley Thanks for the suggestion! I totally missed that. I've uploaded v2 with a doc update. Thanks, Jack

[PATCH v2] app/test-crypto-perf: add shared session option

2024-06-18 Thread Jack Bond-Preston
Add the option to create one session for the PMD, and share it across all of the queue pairs. This may help to discover/debug concurrency issues (both correctness and performance) that can occur when using this configuration. Signed-off-by: Jack Bond-Preston Acked-by: Brian Dooley Reviewed-by

[PATCH v4 5/5] crypto/openssl: only set cipher padding once

2024-06-07 Thread Jack Bond-Preston
28.05 | 135.40 | 5.7% | |4096 |139.45 | 143.76 | 3.1% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/c

[PATCH v4 4/5] crypto/openssl: per-qp auth context clones

2024-06-07 Thread Jack Bond-Preston
| 1122.5% | | 256 | 3.70 | 35.30 | 853.7% | |1024 | 15.22 | 74.27 | 387.8% | |2048 | 30.20 | 91.08 | 201.6% | |4096 | 56.92 | 102.76 |80.5% | Signed-off-by: Jack

[PATCH v4 3/5] crypto/openssl: per-qp cipher context clones

2024-06-07 Thread Jack Bond-Preston
| 64.86 | 520.3% | |1024 | 40.97 | 113.80 | 177.7% | |2048 | 73.25 | 130.21 |77.8% | |4096 |103.89 | 140.62 |35.4% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage

[PATCH v4 2/5] crypto/openssl: only init 3DES-CTR key + impl once

2024-06-07 Thread Jack Bond-Preston
| 1.77 | 2.6% | |2048 | 1.76 | 1.78 | 1.1% | |4096 | 1.79 | 1.80 | 0.6% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 21

[PATCH v4 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

2024-06-07 Thread Jack Bond-Preston
2048 |147.69 | 80.91 | -45.2% | |4096 |167.39 | 121.25 | -27.6% | Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API") Cc: sta...@dpdk.org Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vi

[PATCH v4 0/5] OpenSSL PMD Optimisations

2024-06-07 Thread Jack Bond-Preston
oss different sets of applied patches) - for both Intel and Arm platforms - are available. However, I'm not sure of the ettiquette regarding attachments of such files, so I haven't attached them for now. If you are interested in reviewing them, please reach out and I will find a way to get

[PATCH v3 5/5] crypto/openssl: only set cipher padding once

2024-06-06 Thread Jack Bond-Preston
28.05 | 135.40 | 5.7% | |4096 |139.45 | 143.76 | 3.1% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/c

[PATCH v3 4/5] crypto/openssl: per-qp auth context clones

2024-06-06 Thread Jack Bond-Preston
| 1122.5% | | 256 | 3.70 | 35.30 | 853.7% | |1024 | 15.22 | 74.27 | 387.8% | |2048 | 30.20 | 91.08 | 201.6% | |4096 | 56.92 | 102.76 |80.5% | Signed-off-by: Jack

[PATCH v3 3/5] crypto/openssl: per-qp cipher context clones

2024-06-06 Thread Jack Bond-Preston
| 64.86 | 520.3% | |1024 | 40.97 | 113.80 | 177.7% | |2048 | 73.25 | 130.21 |77.8% | |4096 |103.89 | 140.62 |35.4% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage

[PATCH v3 2/5] crypto/openssl: only init 3DES-CTR key + impl once

2024-06-06 Thread Jack Bond-Preston
| 1.77 | 2.6% | |2048 | 1.76 | 1.78 | 1.1% | |4096 | 1.79 | 1.80 | 0.6% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 21

[PATCH v3 0/5] OpenSSL PMD Optimisations

2024-06-06 Thread Jack Bond-Preston
r, I'm not sure of the ettiquette regarding attachments of such files, so I haven't attached them for now. If you are interested in reviewing them, please reach out and I will find a way to get them to you. Jack Bond-Preston (5): crypto/openssl: fix GCM and CCM thread unsafe ctxs cryp

[PATCH v3 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

2024-06-06 Thread Jack Bond-Preston
2048 |147.69 | 80.91 | -45.2% | |4096 |167.39 | 121.25 | -27.6% | Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API") Cc: sta...@dpdk.org Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vi

[PATCH] app/test-crypto-perf: add shared session option

2024-06-04 Thread Jack Bond-Preston
Add the option to create one session for the PMD, and share it across all of the queue pairs. This may help to discover/debug concurrency issues (both correctness and performance) that can occur when using this configuration. Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage

[PATCH v2 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

2024-06-03 Thread Jack Bond-Preston
| 42.46 | -64.5% | |2048 |147.69 | 80.91 | -45.2% | |4096 |167.39 | 121.25 | -27.6% | Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API") Cc: sta...@dpdk.org Signed-off-by: Jack Bond-

[PATCH v2 2/5] crypto/openssl: only init 3DES-CTR key + impl once

2024-06-03 Thread Jack Bond-Preston
| 1.77 | 2.6% | |2048 | 1.76 | 1.78 | 1.1% | |4096 | 1.79 | 1.80 | 0.6% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 21

[PATCH v2 0/5] OpenSSL PMD Optimisations

2024-06-03 Thread Jack Bond-Preston
additional bar charts showing the throughput comparison across different sets of applied patches) - for both Intel and Arm platforms - are available. However, I'm not sure of the ettiquette regarding attachments of such files, so I haven't attached them for now. If you are interested i

[PATCH v2 3/5] crypto/openssl: per-qp cipher context clones

2024-06-03 Thread Jack Bond-Preston
| 64.86 | 520.3% | |1024 | 40.97 | 113.80 | 177.7% | |2048 | 73.25 | 130.21 |77.8% | |4096 |103.89 | 140.62 |35.4% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage

[PATCH v2 5/5] crypto/openssl: only set cipher padding once

2024-06-03 Thread Jack Bond-Preston
28.05 | 135.40 | 5.7% | |4096 |139.45 | 143.76 | 3.1% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/c

[PATCH v2 4/5] crypto/openssl: per-qp auth context clones

2024-06-03 Thread Jack Bond-Preston
| 1122.5% | | 256 | 3.70 | 35.30 | 853.7% | |1024 | 15.22 | 74.27 | 387.8% | |2048 | 30.20 | 91.08 | 201.6% | |4096 | 56.92 | 102.76 |80.5% | Signed-off-by: Jack

[PATCH v2 2/5] crypto/openssl: only init 3DES-CTR key + impl once

2024-06-03 Thread Jack Bond-Preston
| 1.77 | 2.6% | |2048 | 1.76 | 1.78 | 1.1% | |4096 | 1.79 | 1.80 | 0.6% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 21

[PATCH v2 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

2024-06-03 Thread Jack Bond-Preston
| 42.46 | -64.5% | |2048 |147.69 | 80.91 | -45.2% | |4096 |167.39 | 121.25 | -27.6% | Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API") Cc: sta...@dpdk.org Signed-off-by: Jack Bond-

[PATCH v2 4/5] crypto/openssl: per-qp auth context clones

2024-06-03 Thread Jack Bond-Preston
| 1122.5% | | 256 | 3.70 | 35.30 | 853.7% | |1024 | 15.22 | 74.27 | 387.8% | |2048 | 30.20 | 91.08 | 201.6% | |4096 | 56.92 | 102.76 |80.5% | Signed-off-by: Jack

[PATCH v2 0/5] OpenSSL PMD Optimisations

2024-06-03 Thread Jack Bond-Preston
additional bar charts showing the throughput comparison across different sets of applied patches) - for both Intel and Arm platforms - are available. However, I'm not sure of the ettiquette regarding attachments of such files, so I haven't attached them for now. If you are interested i

[PATCH v2 5/5] crypto/openssl: only set cipher padding once

2024-06-03 Thread Jack Bond-Preston
28.05 | 135.40 | 5.7% | |4096 |139.45 | 143.76 | 3.1% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/c

[PATCH v2 3/5] crypto/openssl: per-qp cipher context clones

2024-06-03 Thread Jack Bond-Preston
| 64.86 | 520.3% | |1024 | 40.97 | 113.80 | 177.7% | |2048 | 73.25 | 130.21 |77.8% | |4096 |103.89 | 140.62 |35.4% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage

Re: [PATCH 4/5] crypto/openssl: per-qp auth context clones

2024-06-03 Thread Jack Bond-Preston
On 03/06/2024 17:01, Jack Bond-Preston wrote: diff --git a/drivers/crypto/openssl/openssl_pmd_private.h b/drivers/crypto/openssl/openssl_pmd_private.h index bad7dcf2f5..c3740ccc62 100644 --- a/drivers/crypto/openssl/openssl_pmd_private.h +++ b/drivers/crypto/openssl/openssl_pmd_private.h

Re: [PATCH 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

2024-06-03 Thread Jack Bond-Preston
On 03/06/2024 17:01, Jack Bond-Preston wrote: + EVP_CIPHER_CTX *ctx = EVP_CIPHER_CTX_new(); + EVP_CIPHER_CTX_copy(ctx, sess->cipher.ctx); + This, and other patches in the set, are throwing a checkpatch error: _coding style issues_ ERROR:SPACING: need consistent spacing aro

[PATCH 5/5] crypto/openssl: only set cipher padding once

2024-06-03 Thread Jack Bond-Preston
28.05 | 135.40 | 5.7% | |4096 |139.45 | 143.76 | 3.1% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/c

[PATCH 4/5] crypto/openssl: per-qp auth context clones

2024-06-03 Thread Jack Bond-Preston
| 1122.5% | | 256 | 3.70 | 35.30 | 853.7% | |1024 | 15.22 | 74.27 | 387.8% | |2048 | 30.20 | 91.08 | 201.6% | |4096 | 56.92 | 102.76 |80.5% | Signed-off-by: Jack

[PATCH 3/5] crypto/openssl: per-qp cipher context clones

2024-06-03 Thread Jack Bond-Preston
| 64.86 | 520.3% | |1024 | 40.97 | 113.80 | 177.7% | |2048 | 73.25 | 130.21 |77.8% | |4096 |103.89 | 140.62 |35.4% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage

[PATCH 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

2024-06-03 Thread Jack Bond-Preston
| 42.46 | -64.5% | |2048 |147.69 | 80.91 | -45.2% | |4096 |167.39 | 121.25 | -27.6% | Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API") Cc: sta...@dpdk.org Signed-off-by: Jack Bond-

[PATCH 2/5] crypto/openssl: only init 3DES-CTR key + impl once

2024-06-03 Thread Jack Bond-Preston
| 1.77 | 2.6% | |2048 | 1.76 | 1.78 | 1.1% | |4096 | 1.79 | 1.80 | 0.6% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 21

[PATCH 0/5] OpenSSL PMD Optimisations

2024-06-03 Thread Jack Bond-Preston
t sets of applied patches) - for both Intel and Arm platforms - are available. However, I'm not sure of the ettiquette regarding attachments of such files, so I haven't attached them for now. If you are interested in reviewing them, please reach out and I will find a way to get them to you

DPDK patch for Amston Lake SGMII <> GPY215

2024-05-26 Thread Jack . Chen
EMETRY: No legacy callbacks, legacy socket not created testpmd: No probed ethernet devices Interactive-mode selected Fail: input rxq (1) can't be greater than max_rx_queues (0) of port 0 EAL: Error - exiting with code: 1 Cause: rxq 1 invalid - must be >= 0 && <= 0 Thanks an

[PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library tag

2024-03-12 Thread Jack Bond-Preston
Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.03.12 in snow3g and zuc documentation. Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- .mailmap | 1 + doc/guides/cryptodevs/snow3g.rst | 2 +- doc/guides/cryptodevs/zuc.rst| 2 +- 3

Re: [PATCH v6 1/5] ci: replace IPsec-mb package install

2024-03-12 Thread Jack Bond-Preston
is is now tagged as SECLIB-IPSEC-2024.03.12. See here: https://gitlab.arm.com/arm-reference-solutions/ipsec-mb/-/tree/SECLIB-IPSEC-2024.03.12 Thanks, Jack

Re: MLX5 PMD access ring library private data

2023-08-20 Thread Jack Min
On 2023/8/21 14:06, Honnappa Nagarahalli wrote: It would be good if you could fix the email on your side to text format. Comments inline. Seems a wrong setting on my email client. Sorry. *From:* Jack Min *Sent:* Friday, August 18, 2023 8:35 PM *To:* Honnappa Nagarahalli ; Stephen

Re: MLX5 PMD access ring library private data

2023-08-19 Thread Jack Min
On 2023/8/19 19:57, Konstantin Ananyev wrote: 18/08/2023 10:38, Jack Min пишет: On 2023/8/18 17:05, Konstantin Ananyev wrote: On 2023/8/17 22:06, Stephen Hemminger wrote: On Thu, 17 Aug 2023 05:06:20 + Honnappa Nagarahalli wrote: Hi Matan, Viacheslav, Tyler pointed out that the

Re: MLX5 PMD access ring library private data

2023-08-18 Thread Jack Min
On 2023/8/18 21:59, Honnappa Nagarahalli wrote: *From:* Jack Min *Sent:* Friday, August 18, 2023 12:57 AM *To:* Honnappa Nagarahalli ; Stephen Hemminger *Cc:* dev@dpdk.org; Matan Azrad ; viachesl...@nvidia.com; Tyler Retzlaff ; Wathsala Wathawana Vithanage ; nd *Subject:* Re: MLX5 PMD

Re: MLX5 PMD access ring library private data

2023-08-18 Thread Jack Min
quick because it happens in our local cache, needn't access global ring. In short, we require a struct supports "FIFO" and "LIFO". -Jack

Re: MLX5 PMD access ring library private data

2023-08-17 Thread Jack Min
On 2023/8/18 12:30, Honnappa Nagarahalli wrote: -Original Message- From: Jack Min Sent: Thursday, August 17, 2023 9:32 PM To: Stephen Hemminger; Honnappa Nagarahalli Cc:dev@dpdk.org; Matan Azrad; viachesl...@nvidia.com; Tyler Retzlaff; Wathsala Wathawana Vithanage; nd Subject: Re

Re: MLX5 PMD access ring library private data

2023-08-17 Thread Jack Min
"LIFO" behavior. This is why we require "revert" enqueued objects. -Jack

Re: [RFC v2 2/2] ethdev: queue-based flow aged report

2022-06-02 Thread Jack Min
On 6/2/22 14:10, Ori Kam wrote: Hi, Hello, -Original Message- From: Andrew Rybchenko Sent: Wednesday, June 1, 2022 9:21 PM Subject: Re: [RFC v2 2/2] ethdev: queue-based flow aged report Again, summary must not be a statement. On 6/1/22 10:39, Xiaoyu Min wrote: When application use

Re: [RFC v2 2/2] ethdev: queue-based flow aged report

2022-06-02 Thread Jack Min
On 6/2/22 02:21, Andrew Rybchenko wrote: Again, summary must not be a statement. I'l re-phrase it. On 6/1/22 10:39, Xiaoyu Min wrote: When application use queue-based flow rule management and operate the same flow rule on the same queue, e.g create/destroy/query, API of querying aged flow rule

Re: [RFC v2 1/2] ethdev: port flags for pre-configuration flow hints

2022-06-02 Thread Jack Min
On 6/2/22 02:20, Andrew Rybchenko wrote: Summary must not be a statement. May be: ethdev: add strict queue to pre-configuration flow hints Ok, I'll change to this. On 6/1/22 10:39, Xiaoyu Min wrote: The data-path focused flow rule management can manage flow rules in more optimized way than tr

Re: [RFC 2/2] ethdev: queue-based flow aged report

2022-05-31 Thread Jack Min
Ok, since the *ret_param* is supposed to be used by driver, then the above approach is not a good idea. So we need a new API, something like rte_flow_get_aged_event_queues(), which will return all flow queues which has the aged flows, right? -Jack

Re: [RFC 1/2] ethdev: port flags for pre-configuration flow hints

2022-05-31 Thread Jack Min
On 5/31/22 00:46, Thomas Monjalon wrote: We were waiting for a v2 of this patch. Hey Thomas, Thank you for the comments. Yes, I'll send v2. More comments below. I'll update the patch in v2 accordingly. 07/04/2022 07:30, Xiaoyu Min: The data-path focused flow rule management can manage f

Re: [RFC 1/2] ethdev: port flags for pre-configuration flow hints

2022-04-07 Thread Jack Min
On 4/7/22 23:04, Stephen Hemminger wrote: On Thu, 7 Apr 2022 13:30:46 +0800 Xiaoyu Min wrote: * @b EXPERIMENTAL: this API may change without prior notice. @@ -4972,6 +4983,11 @@ struct rte_flow_port_attr { * @see RTE_FLOW_ACTION_TYPE_METER */ uint32_t nb_meters; +

Re: [RFC 1/2] ethdev: port flags for pre-configuration flow hints

2022-04-07 Thread Jack Min
On 4/7/22 19:27, Ori Kam wrote: Hi Jack, Hey Ori, -Original Message- From: Jack Min Sent: Thursday, April 7, 2022 8:31 AM Subject: [RFC 1/2] ethdev: port flags for pre-configuration flow hints The data-path focused flow rule management can manage flow rules in more optimized way

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing RSS expansion of IPv6 frag

2021-07-14 Thread Jack Min
after frag - which I think it doesn't. > It will lead that the first frag will get different hash than other frags > since it the only one which contain info of L4 header > This will lead to different RSS spreading and that's not correct. No, it will not expand to any items because the .next field is empty of entry MLX5_EXPANSION_IPV6_FRAG_EXT in mlx5_support_expansion[]. -Jack > > Kindest regards, > Raslan Darawsheh

Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add packet id for IP fragment

2021-04-19 Thread Jack Min
On Mon, 21-04-19, 16:40, Ferruh Yigit wrote: > On 4/19/2021 8:43 AM, Jack Min wrote: > > On Tue, 21-04-13, 16:10, Jeff Guo wrote: > > > Add the new items to support the flow configuration for IP fragment > > > packets. > > > > > > Signed-o

Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add packet id for IP fragment

2021-04-19 Thread Jack Min
lags and fragment offset", > @@ -2969,12 +2980,20 @@ static const struct token token_list[] = { > }, > [ITEM_IPV6_FRAG_EXT_FRAG_DATA] = { > .name = "frag_data", > - .help = "Fragment flags and offset", > + .help = "fragment flags and offset", Will it be better to have a seperate fix patch for this ? -Jack

[dpdk-dev] [PATCH] net/mlx5: support RSS expansion for IPv6 GRE

2021-03-18 Thread Jack Min
Currently RSS expansion only support IPv4 as GRE payload or delivery protocol (RFC2784). IPv6 as GRE payload or delivery protocol (RFC7676) is not supported. This patch add RSS expansion for RFC7676 so PMD can expand flow item correctly. Fixes: f4b901a46aec ("net/mlx5: add flow GRE item") Cc: sta

[dpdk-dev] [PATCH 1/2] doc: more info of rte flow shared action

2021-02-02 Thread Jack Min
Added more information of shared action on how to update, query, and the benefits. Signed-off-by: Xiaoyu Min --- doc/guides/prog_guide/rte_flow.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 0b8c243fe1

[dpdk-dev] [PATCH 0/2] doc update for rte flow shared action

2021-02-02 Thread Jack Min
This series update documents as following: 1. Add more information about shared action in rte_flow.rst. 2. Group all supported shared actions in mlx5.rst Xiaoyu Min (2): doc: more info of rte flow shared action doc: group mlx5 shared actions doc/guides/nics/mlx5.rst | 30 +

[dpdk-dev] [PATCH 2/2] doc: group mlx5 shared actions

2021-02-02 Thread Jack Min
Put all supported shared actions in one new table Signed-off-by: Xiaoyu Min --- doc/guides/nics/mlx5.rst | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index e99fea4342..dbd7ae1bb9 100644 ---

Re: [dpdk-dev] [PATCH 4/5] net/iavf: fix protocol size for virtchnl copy

2020-11-22 Thread Jack Min
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, November 17, 2020 00:23 > To: Xiaoyu Min ; Jingjing Wu ; > Beilei Xing > Cc: dev@dpdk.org; Jack Min ; NBU-Contact-Thomas > Monjalon ; Andrew Rybchenko > ; Ori Kam ; Dekel Peled > > Subject: Re: [

[dpdk-dev] DPDK Compiling Error on New Fedora 32: drivers/net/ntacc/meson.build:31:0: ERROR: Include dir /include does not exist.

2020-09-28 Thread Jack
Hi, Compiling error: drivers/net/ntacc/meson.build:31:0: ERROR: Include dir /include does not exist. To fix: drivers/net/ntacc/meson.build  25| PATH = '/usr' Sincerely, Jack

Re: [dpdk-dev] [PATCH v2 0/5] ethdev: add API to dump device internal flow info

2020-01-19 Thread Jack Min
t; > > > Xueming Li (3): > > > app/testpmd: new flow dump CLI > > > net/mlx5: add socket server for external tools > > > doc: update mlx5 document for flow dump feature > > > > Series applied to dpdk-next-net/master, thanks. > > I think we are missing an update of the testpmd doc. > Yes, you are right. I'll update testpmd doc. -Jack

Re: [dpdk-dev] [PATCH 4/5] net/mlx5: add socket server for external tools

2020-01-17 Thread Jack Min
On Fri, 20-01-17, 16:47, Slava Ovsiienko wrote: > Hi, Jack > > > -Original Message- > > From: Xiaoyu Min > > Sent: Thursday, January 16, 2020 12:14 > > To: jerinjac...@gmail.com; Ori Kam ; Slava Ovsiienko > > ; Matan Azrad ; Raslan > > Daraw

Re: [dpdk-dev] [RFC 2/4] app/testpmd: new flow dump CLI

2020-01-15 Thread Jack Min
On Tue, 20-01-14, 19:30, Jerin Jacob wrote: > On Tue, Jan 14, 2020 at 3:45 PM Jack Min wrote: > > > > On Tue, 20-01-14, 10:01, Jerin Jacob wrote: > > > On Tue, Jan 14, 2020 at 9:15 AM Xiaoyu Min wrote: > > > > > > > > From: Xueming Li > > &

Re: [dpdk-dev] [RFC 2/4] app/testpmd: new flow dump CLI

2020-01-14 Thread Jack Min
e_flow, a dump function probabily means dump rte_flow itself (i.e flow->attr, pattern, actions). This is the reason a private API is choosen and driver-specific symbols added in testpmd as result. -Jack

Re: [dpdk-dev] [PATCH] ethdev: fix last item detection on RSS flow expand

2019-11-11 Thread Jack Min
ot;next proto" field of the last configured item in the pattern list. > Wrongly, the mask of this field was not considered in order to validate > the field. > > Ignore "next proto" fields when their corresponded masks invalidate them. > > Fixes: ec84aa45f17b (&q

Re: [dpdk-dev] [PATCH] ethdev: expand RSS flows based on last item spec

2019-11-05 Thread Jack Min
On Tue, 19-11-05, 11:11, Thomas Monjalon wrote: > Hi Jack, > > If it is a fix, please change your title. > Ok, I will add 'fix' in title. > 05/11/2019 10:16, Xiaoyu Min: > > When rte_flow_expand_rss expands rte_flow item list based on the RSS > > types. &

Re: [dpdk-dev] [PATCH] app/testpmd: support multiple raw encap/decap

2019-09-23 Thread Jack Min
Hey, Anyone has any comments on this patch? -Jack On Mon, 19-09-16, 17:21, Xiaoyu Min wrote: > In some scenarios, the raw_encap/raw_decap actions could be multiple in > one single flow (e,g. hirepin flow): > > ... actions raw_decap / raw_encap / raw_decap / raw_encap / ... >

Re: [dpdk-dev] [RFC] app/testpmd: support multiple raw encap/decap

2019-09-20 Thread Jack Min
Hey, Anyone has any comments? -Jack On Sat, 19-08-31, 16:28, Xiaoyu Min wrote: > In some scenarios, the raw_encap/raw_decap actions could be multiple in > one single flow (e,g. hirepin flow): > > ... actions raw_decap / raw_encap / raw_decap / raw_encap / ... > > This re

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix NVGRE matching

2019-07-22 Thread Jack Min
On Mon, 19-07-22, 18:36, Dekel Peled wrote: > NVGRE has a GRE header with c_rsvd0_ver value 0x2000 and protocol > value 0x6558. > These should be matched when item_nvgre is provided. > > This patch adds validation function of NVGRE item. > It also updates the translate function of NVGRE item, to a

Re: [dpdk-dev] [PATCH] net/mlx5: fix NVGRE matching

2019-07-22 Thread Jack Min
On Mon, 19-07-22, 19:33, Dekel Peled wrote: > Thanks, PSB. > > > -Original Message- > > From: Jack Min > > Sent: Monday, July 22, 2019 12:31 PM > > To: Dekel Peled > > Cc: Yongseok Koh ; Slava Ovsiienko > > ; Shahaf Shuler ; Ori > > Kam

Re: [dpdk-dev] [PATCH] net/mlx5: fix NVGRE matching

2019-07-22 Thread Jack Min
On Thu, 19-07-18, 22:42, Dekel Peled wrote: > NVGRE has a GRE header with c_rsvd0_ver value 0x2000 and protocol > value 0x6558. > These should be matched when item_nvgre is provided. > > This patch adds validation function of NVGRE item, to validate that > the input values, if exist, are as requir

Re: [dpdk-dev] [PATCH] net/mlx5: fix setting of item flags bitmap

2019-07-18 Thread Jack Min
On Thu, 19-07-18, 22:42, Dekel Peled wrote: > In functions flow_dv_translate() and flow_dv_validate(), the flow > items are scanned and each item is marked in item_flags bitmap. > The code handling some of the items was ported from another project, > where items are marked in a slightley different

Re: [dpdk-dev] [PATCH] net/mlx5: fix define of added tunnel layer bit

2019-07-18 Thread Jack Min
On Thu, 19-07-18, 22:41, Dekel Peled wrote: > The new define MLX5_FLOW_LAYER_IPIP is using the same value as > existing define MLX5_FLOW_LAYER_GRE_KEY. > This patch updates the values to be in order. > > Fixes: 1b5624cd9062 ("net/mlx5: support IP-in-IP tunnel") > Signed-off-by: Dekel Peled > ---

Re: [dpdk-dev] [PATCH v3 1/3] app/testpmd: support raw encap/decap actions

2019-07-17 Thread Jack Min
On Wed, 19-07-17, 09:20, Ferruh Yigit wrote: > On 7/17/2019 2:24 AM, Jack Min wrote: > > On Tue, 19-07-16, 18:41, Ferruh Yigit wrote: > >> On 7/10/2019 11:43 AM, Xiaoyu Min wrote: > >>> This patch intend to support > >>> action_raw_encap/decap [1] in a g

Re: [dpdk-dev] [PATCH v3 1/3] app/testpmd: support raw encap/decap actions

2019-07-16 Thread Jack Min
On Tue, 19-07-16, 18:41, Ferruh Yigit wrote: > On 7/10/2019 11:43 AM, Xiaoyu Min wrote: > > This patch intend to support > > action_raw_encap/decap [1] in a generic and convenient way. > > > > Two new commands - set raw_encap, set raw_decap are introduced just > > like the other commands for encap

Re: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP tunnel

2019-07-10 Thread Jack Min
va > > > -Original Message- > > From: dev On Behalf Of Slava Ovsiienko > > Sent: Wednesday, July 10, 2019 17:20 > > To: Jack Min ; Raslan Darawsheh > > ; Shahaf Shuler ; > > Yongseok Koh ; John McNamara > > ; Marko Kovacevic > > > >

Re: [dpdk-dev] [PATCH v8 2/2] net/mlx5: match GRE's key and present bits

2019-07-09 Thread Jack Min
On Tue, 19-07-09, 11:54, Thomas Monjalon wrote: > 09/07/2019 11:02, Xiaoyu Min: > > --- a/doc/guides/rel_notes/release_19_08.rst > > +++ b/doc/guides/rel_notes/release_19_08.rst > > @@ -191,6 +191,11 @@ New Features > >Added telemetry mode to l3fwd-power application to report > >application

  1   2   >