Re: [PATCH 4/5] net/hns3: fix TM thread safety risk

2023-08-07 Thread Dongdong Liu
Hi Stephen On 2023/8/5 23:58, Stephen Hemminger wrote: On Sat, 5 Aug 2023 16:36:26 +0800 Dongdong Liu wrote: From: Chengwen Feng The driver-related TM (traffic management) info is implemented through the linked list. The following threads are involved in the read and write of the TM info

[PATCH 5/5] net/hns3: fix un-align format TM info

2023-08-05 Thread Dongdong Liu
ned-off-by: Dongdong Liu --- drivers/net/hns3/hns3_dump.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/hns3/hns3_dump.c b/drivers/net/hns3/hns3_dump.c index 67b45e6dc3..5c21ff0a33 100644 --- a/drivers/net/hns3/hns3_dump.c +++ b/drivers/net/hns3/h

[PATCH 4/5] net/hns3: fix TM thread safety risk

2023-08-05 Thread Dongdong Liu
: e4cfe6bb9114 ("net/hns3: dump TM configuration info") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_dump.c | 8 +- drivers/net/hns3/hns3_tm.c | 173 ++- 2 files changed, 157 insertions(+), 24

[PATCH 1/5] net/hns3: fix VF default MAC modified when set failed

2023-08-05 Thread Dongdong Liu
From: Dengdui Huang When the VF fail to set the default MAC address, "hw->mac.mac_addr" should not be updated. Fixes: a5475d61fa34 ("net/hns3: support VF") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_eth

[PATCH 3/5] net/hns3: flush multicast MAC address if mc_addr_set is NULL

2023-08-05 Thread Dongdong Liu
Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_common.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c index 043c7673b4..c4d47f43fe 100644 --- a/drivers/net/hns3/hns3_common.c +++ b/drivers/net/hns3/hns3_common.c

[PATCH 0/5] net/hns3: some bugfixes for hns3

2023-08-05 Thread Dongdong Liu
This patchset is to fix some bugs for hns3. Chengwen Feng (2): net/hns3: fix TM thread safety risk net/hns3: fix un-align format TM info Dengdui Huang (3): net/hns3: fix VF default MAC modified when set failed net/hns3: return ENOSPC if not enough MCAST filter resource net/hns3: flush m

[PATCH 2/5] net/hns3: return ENOSPC if not enough MCAST filter resource

2023-08-05 Thread Dongdong Liu
From: Dengdui Huang Return ENOSPC instead of EINVAL when the hardware has not enough multicast filtering resources. Fixes: 7d7f9f80bbfb ("net/hns3: support MAC address related operations") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- driver

Re: [PATCH 0/5] net/hns3: some performance optimizations

2023-07-11 Thread Dongdong Liu
Hi, Ferruh On 2023/7/11 18:48, Ferruh Yigit wrote: On 7/11/2023 11:24 AM, Dongdong Liu wrote: This patchset is to do some performance optimizations for hns3. Huisong Li (5): net/hns3: fix incorrect index to look up table in NEON Rx net/hns3: fix the order of NEON Rx code net/hns3

[PATCH 5/5] net/hns3: optimize SVE Rx performance

2023-07-11 Thread Dongdong Liu
tor. On the rxonly forwarding mode, the performance of a single queue or 64B packet is improved by ~40%. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rxtx_vec_sve.c | 138 ++- 1 file changed, 28 insertions(+), 110 deletions(-) diff --g

[PATCH 2/5] net/hns3: fix the order of NEON Rx code

2023-07-11 Thread Dongdong Liu
From: Huisong Li This patch reorders the order of the NEON Rx for better maintenance and easier understanding. Fixes: a3d4f4d291d7 ("net/hns3: support NEON Rx") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rxtx_vec_n

[PATCH 4/5] net/hns3: optimize the rearm mbuf function for SVE Rx

2023-07-11 Thread Dongdong Liu
From: Huisong Li Use hns3_rxq_rearm_mbuf() to replace the hns3_rxq_rearm_mbuf_sve() to optimize the performance of SVE Rx. On the rxonly forwarding mode, the performance of a single queue for 64B packet is improved by ~15%. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers

[PATCH 3/5] net/hns3: optimize free mbuf code for SVE Tx

2023-07-11 Thread Dongdong Liu
VE Tx performance. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rxtx_vec_sve.c | 42 +--- 1 file changed, 1 insertion(+), 41 deletions(-) diff --git a/drivers/net/hns3/hns3_rxtx_vec_sve.c b/drivers/net/hns3/hns3_rxtx_vec_sve.c index 8bfc3

[PATCH 1/5] net/hns3: fix incorrect index to look up table in NEON Rx

2023-07-11 Thread Dongdong Liu
truth. Fixes: a3d4f4d291d7 ("net/hns3: support NEON Rx") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rxtx_vec_neon.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_rxtx_vec_neon.h

[PATCH 0/5] net/hns3: some performance optimizations

2023-07-11 Thread Dongdong Liu
This patchset is to do some performance optimizations for hns3. Huisong Li (5): net/hns3: fix incorrect index to look up table in NEON Rx net/hns3: fix the order of NEON Rx code net/hns3: optimize free mbuf code for SVE Tx net/hns3: optimize the rearm mbuf function for SVE Rx net/hns3: o

[PATCH] net/hns3: fix non-zero weight for disabled TC

2023-07-07 Thread Dongdong Liu
%. Actually, this operation is also redundant, because these disabled TC will never be used. So this patch sets the weight of all TC based on user's configuration. Fixes: 62e3ccc2b94c ("net/hns3: support flow control") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-b

[PATCH 3/3] doc: fix wrong number of spaces in hns3 guide

2023-06-30 Thread Dongdong Liu
The current description of 'mbx_time_limit_ms' has three spaces at the beginning. Use two spaces to keep the same style with other places and add a blank line after '::'. Fixes: 2fc3e696a7f1 ("net/hns3: add runtime config for mailbox limit time") Cc: sta...@dpdk.or

[PATCH 2/3] doc: fix wrong syntax in hns3 guide

2023-06-30 Thread Dongdong Liu
'::' doesn't provide pre-formatted text without an empty line after it, so fixes it. Fixes: cdf6a5fbc540 ("doc: add runtime option examples to hns3 guide") Cc: sta...@dpdk.org Signed-off-by: Dongdong Liu --- doc/guides/nics/hns3.rst | 3 +++ 1 file changed, 3 insert

[PATCH 0/3] doc: fix some errors in hns3 guide

2023-06-30 Thread Dongdong Liu
This patchset is to fix some errors in hns3 guide doc. Dongdong Liu (3): doc: fix invalid link in hns3 guide doc: fix wrong syntax in hns3 guide doc: fix wrong number of spaces in hns3 guide doc/guides/nics/hns3.rst | 33 +++-- 1 file changed, 19 insertions

[PATCH 1/3] doc: fix invalid link in hns3 guide

2023-06-30 Thread Dongdong Liu
The LSC support of Vf driver depends on a patch link in kernel pf driver. But current the link is invalid, so fixes it. Add a blank line after the link. Fixes: 80006b598730 ("doc: add link status event requirements in hns3 guide") Cc: sta...@dpdk.org Signed-off-by: Dongdong Liu ---

Re: [PATCH v3 2/2] net/hns3: add FDIR VLAN match mode runtime config

2023-06-29 Thread Dongdong Liu
Hi Ferruh On 2023/6/29 23:52, Ferruh Yigit wrote: On 6/29/2023 2:21 PM, Dongdong Liu wrote: diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst index 5373ec5a8f..001ccbdb62 100644 --- a/doc/guides/nics/hns3.rst +++ b/doc/guides/nics/hns3.rst @@ -140,6 +140,32 @@ Runtime

Re: [PATCH v2 2/2] net/hns3: add FDIR VLAN match mode runtime config

2023-06-29 Thread Dongdong Liu
On 2023/6/29 19:08, Ferruh Yigit wrote: On 6/28/2023 3:59 AM, Dongdong Liu wrote: Hi Thomas Many thanks for your review. On 2023/6/28 7:12, Thomas Monjalon wrote: 27/06/2023 09:11, Dongdong Liu: +- ``fdir_vlan_match_mode`` (default `strict`) + + Used to select VLAN match mode. This

[PATCH v3 2/2] net/hns3: add FDIR VLAN match mode runtime config

2023-06-29 Thread Dongdong Liu
l uses 'strict' mode as the default mode. Please select 'nostrict' mode if you request all same ethertype packets with and without VLAN to a specified queue. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- doc/guides/nics/hns3.rst | 26 +++

[PATCH v3 0/2] net/hns3: add FDIR VLAN match mode runtime config

2023-06-29 Thread Dongdong Liu
This patchset contains two patches: The first one is to delete duplicate macro definition for hns3. The second one is to add FDIR VLAN match mode runtime config for hns3 v2->v3: - Use double backquotes for values of the devargs and fix spelling errors. v1->v2: - Fix the hns3.rst doc build warini

[PATCH v3 1/2] net/hns3: delete duplicate macro definition

2023-06-29 Thread Dongdong Liu
From: Huisong Li This patch delete some duplicate macro definitions. Fixes: a4c7152d0581 ("net/hns3: extract common code to its own file") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.h | 7 --- 1 file changed, 7

Re: [PATCH v2 2/2] net/hns3: add FDIR VLAN match mode runtime config

2023-06-27 Thread Dongdong Liu
Hi Thomas Many thanks for your review. On 2023/6/28 7:12, Thomas Monjalon wrote: 27/06/2023 09:11, Dongdong Liu: +- ``fdir_vlan_match_mode`` (default `strict`) + + Used to select VLAN match mode. This runtime config can be `strict` + or `nostrict` and is only valid for PF drives. drives

[PATCH v2 2/2] net/hns3: add FDIR VLAN match mode runtime config

2023-06-27 Thread Dongdong Liu
l uses 'strict' mode as the default mode. Please select 'nostrict' mode if you request all same ethertype packets with and without VLAN to a specified queue. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- doc/guides/nics/hns3.rst | 26 +++

[PATCH v2 1/2] net/hns3: delete duplicate macro definition

2023-06-27 Thread Dongdong Liu
From: Huisong Li This patch delete some duplicate macro definitions. Fixes: a4c7152d0581 ("net/hns3: extract common code to its own file") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.h | 7 --- 1 file changed, 7

[PATCH v2 0/2] net/hns3: add FDIR VLAN match mode runtime config

2023-06-27 Thread Dongdong Liu
This patchset contains two patches: The first one is to delete duplicate macro definition for hns3. The second one is to add FDIR VLAN match mode runtime config for hns3 v1->v2: - Fix the hns3.rst doc build warining. Huisong Li (2): net/hns3: delete duplicate macro definition net/hns3: add FD

[PATCH 0/2] net/hns3: add FDIR VLAN match mode runtime config

2023-06-26 Thread Dongdong Liu
This patchset contains two patches: The first one is to delete duplicate macro definition for hns3. The second one is to add FDIR VLAN match mode runtime config for hns3. Huisong Li (2): net/hns3: delete duplicate macro definition net/hns3: add FDIR VLAN match mode runtime config doc/guides/

[PATCH 1/2] net/hns3: delete duplicate macro definition

2023-06-26 Thread Dongdong Liu
From: Huisong Li This patch delete some duplicate macro definitions. Fixes: a4c7152d0581 ("net/hns3: extract common code to its own file") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.h | 7 --- 1 file changed, 7

[PATCH 2/2] net/hns3: add FDIR VLAN match mode runtime config

2023-06-26 Thread Dongdong Liu
l uses 'strict' mode as the default mode. Please select 'nostrict' mode if you request all same ethertype packets with and without VLAN to a specified queue. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- doc/guides/nics/hns3.rst | 20 +

[PATCH] config/arm: add HiSilicon hip10

2023-06-26 Thread Dongdong Liu
Adding support for HiSilicon hip10 platform. Signed-off-by: Dongdong Liu --- config/arm/arm64_hip10_linux_gcc | 16 config/arm/meson.build | 19 +++ 2 files changed, 35 insertions(+) create mode 100644 config/arm/arm64_hip10_linux_gcc diff --git a

[PATCH] doc: deprecation notice to add RSS hash algorithm field

2023-06-06 Thread Dongdong Liu
Deprecation notice to add "func" field to ``rte_eth_rss_conf`` structure for RSS hash algorithm. Signed-off-by: Dongdong Liu --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides

[PATCH] net/hns3: fix the way to trigger IMP reset

2023-06-06 Thread Dongdong Liu
/hns3: support device reset") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index

Re: [PATCH 4/5] app/proc-info: show RSS types with strings

2023-06-05 Thread Dongdong Liu
Hi Ferruh On 2023/6/3 4:22, Ferruh Yigit wrote: On 3/15/2023 11:00 AM, Dongdong Liu wrote: From: Jie Hai show RSS types details and adjust RSS info display format as following: - RSS info -- hf: ipv4 ipv4-frag ipv4-other ipv6 ipv6-frag ipv6-other

Re: [PATCH 3/5] app/proc-info: fix never show RSS info

2023-06-05 Thread Dongdong Liu
Hi Stephen On 2023/6/3 5:19, Stephen Hemminger wrote: On Wed, 15 Mar 2023 19:00:31 +0800 Dongdong Liu wrote: + rss_key = rte_malloc(NULL, + dev_info.hash_key_size * sizeof(uint8_t), 0); + if (rss_key == NULL) + return

Re: [PATCH 3/5] app/proc-info: fix never show RSS info

2023-06-05 Thread Dongdong Liu
Hi Ferruh On 2023/6/3 4:19, Ferruh Yigit wrote: On 3/15/2023 11:00 AM, Dongdong Liu wrote: From: Jie Hai Command show-port shows rss info only if rss_conf.rss_key is not null but it will never be true. This patch allocates memory for rss_conf.rss_key and makes it possible to show rss info

Re: [PATCH 1/5] ethdev: support setting and querying rss algorithm

2023-06-05 Thread Dongdong Liu
Hi Ferruh On 2023/6/3 4:19, Ferruh Yigit wrote: On 3/16/2023 1:16 PM, Dongdong Liu wrote: Hi Thomas On 2023/3/15 21:43, Thomas Monjalon wrote: 15/03/2023 12:00, Dongdong Liu: From: Jie Hai --- a/doc/guides/rel_notes/release_23_03.rst +++ b/doc/guides/rel_notes/release_23_03.rst -* No ABI

[PATCH v2 11/11] net/hns3: remove log redundant line break

2023-06-02 Thread Dongdong Liu
From: Dengdui Huang This patch remove log redundant line break Fixes: d51867db65c1 ("net/hns3: add initialization") Fixes: c6332c3cf9f0 ("net/hns3: support module EEPROM dump") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/ne

[PATCH v2 10/11] net/hns3: fix inaccurate log

2023-06-02 Thread Dongdong Liu
From: Dengdui Huang This patch fix inaccurate log Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Fixes: a951c1ed3ab5 ("net/hns3: support different numbers of Rx and Tx queues") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Dongdo

[PATCH v2 09/11] net/hns3: make code more clean

2023-06-02 Thread Dongdong Liu
From: Dengdui Huang This patch modify the code that violates the coding standards. Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_regs.c | 3 +-- drivers/net/hns3/hns3_rxtx.c | 10 +++--- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a

[PATCH v2 08/11] net/hns3: fix uninitialized variable

2023-06-02 Thread Dongdong Liu
From: Jie Hai This patch fixes possible use of uninitialized variable "old_tuple_fields". Fixes: e3069658da9f ("net/hns3: reimplement hash flow function") Cc: sta...@dpdk.org Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_flow.c | 5 +++-

[PATCH v2 05/11] net/hns3: fix mbuf leak when start rxq in resetting

2023-06-02 Thread Dongdong Liu
_start/rx_queue_stop/ tx_queue_start/tx_queue_stop ops. Fixes: fa29fe45a7b4 ("net/hns3: support queue start and stop") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rxtx.c | 28 1 file changed, 28 insertion

[PATCH v2 07/11] net/hns3: fix no errcode returned when failed to init queue

2023-06-02 Thread Dongdong Liu
From: Chengwen Feng If hns3_init_queues() return failed, the hns3vf_do_start() should return errcode. This patch fixes it. Fixes: 43d8adf3891c ("net/hns3: fix RSS flow rule restore") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- driver

[PATCH v2 06/11] net/hns3: fix mbuf leak when start rxq after resetting

2023-06-02 Thread Dongdong Liu
rmine whether the Rx ring mbufs were allocated based only on the first sw-ring[0]'s mbuf. Fixes: fa29fe45a7b4 ("net/hns3: support queue start and stop") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rxtx.c | 5

[PATCH v2 04/11] net/hns3: extract a PTP header file

2023-06-02 Thread Dongdong Liu
From: Huisong Li This patch extracts a PTP header file to contain PTP registers and external API in order to make PTP code structure more clear. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- d

[PATCH v2 03/11] net/hns3: add the uninitialization process of PTP

2023-06-02 Thread Dongdong Liu
From: Huisong Li This patch adds the uninitialization process of PTP in case of having an impact on PF driver in kernel. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_eth

[PATCH v2 02/11] net/hns3: fix unenabled RTC time after reset

2023-06-02 Thread Dongdong Liu
From: Huisong Li The enabled status of RTC time will be cleared after global or IMP reset, which cause the local RTC time doesn't work. So this patch fix it. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-b

[PATCH v2 00/11] net/hns3: add some bugfixes for hns3

2023-06-02 Thread Dongdong Liu
This patchset contains some bugfixes for hns3 pmd. v1->v2: - Fix the comments for [PATCH 01/11] suggested by Ferruh. Chengwen Feng (3): net/hns3: fix mbuf leak when start rxq in resetting net/hns3: fix mbuf leak when start rxq after resetting net/hns3: fix no errcode returned when failed to

[PATCH v2 01/11] net/hns3: fix uninitialized RTC time

2023-06-02 Thread Dongdong Liu
From: Huisong Li Driver doesn't initialize RTC time during probe phase, which lead to an inaccurate time. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/

Re: [PATCH 01/11] net/hns3: fix uninitialized RTC time

2023-06-02 Thread Dongdong Liu
Hi Ferruh Many thanks for your review. On 2023/6/2 17:00, Ferruh Yigit wrote: On 5/29/2023 2:09 PM, Dongdong Liu wrote: From: Huisong Li Driver doesn't initialize RTC time during probe phase, which lead to an inaccurate time. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP

Re: [PATCH v2 0/5] net/hns3: add some features and bugfixes

2023-06-01 Thread Dongdong Liu
Hi Ferruh On 2023/6/1 18:30, Ferruh Yigit wrote: On 5/22/2023 5:15 PM, Ferruh Yigit wrote: On 5/22/2023 2:17 PM, Dongdong Liu wrote: This patchset contains some features and bugfixes for hns3. v1->v2: -Fix check-git-log warnings. Chengwen Feng (1): net/hns3: fix receive multiple firmw

[PATCH 02/11] net/hns3: fix unenabled RTC time after reset

2023-05-29 Thread Dongdong Liu
From: Huisong Li The enabled status of RTC time will be cleared after global or IMP reset, which cause the local RTC time doesn't work. So this patch fix it. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-b

[PATCH 10/11] net/hns3: fix inaccurate log

2023-05-29 Thread Dongdong Liu
From: Dengdui Huang This patch fix inaccurate log Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Fixes: a951c1ed3ab5 ("net/hns3: support different numbers of Rx and Tx queues") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Dongdo

[PATCH 00/11] net/hns3: add some bugfixes for hns3

2023-05-29 Thread Dongdong Liu
This patchset contains some bugfixes for hns3 pmd. Chengwen Feng (3): net/hns3: fix mbuf leak when start rxq in resetting net/hns3: fix mbuf leak when start rxq after resetting net/hns3: fix no errcode returned when failed to init queue Dengdui Huang (3): net/hns3: make code more clean

[PATCH 06/11] net/hns3: fix mbuf leak when start rxq after resetting

2023-05-29 Thread Dongdong Liu
rmine whether the Rx ring mbufs were allocated based only on the first sw-ring[0]'s mbuf. Fixes: fa29fe45a7b4 ("net/hns3: support queue start and stop") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rxtx.c | 5

[PATCH 05/11] net/hns3: fix mbuf leak when start rxq in resetting

2023-05-29 Thread Dongdong Liu
_start/rx_queue_stop/ tx_queue_start/tx_queue_stop ops. Fixes: fa29fe45a7b4 ("net/hns3: support queue start and stop") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rxtx.c | 28 1 file changed, 28 insertion

[PATCH 11/11] net/hns3: remove log redundant line break

2023-05-29 Thread Dongdong Liu
From: Dengdui Huang This patch remove log redundant line break Fixes: d51867db65c1 ("net/hns3: add initialization") Fixes: c6332c3cf9f0 ("net/hns3: support module EEPROM dump") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/ne

[PATCH 09/11] net/hns3: make code more clean

2023-05-29 Thread Dongdong Liu
From: Dengdui Huang This patch modify the code that violates the coding standards. Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_regs.c | 3 +-- drivers/net/hns3/hns3_rxtx.c | 10 +++--- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a

[PATCH 08/11] net/hns3: fix uninitialized variable

2023-05-29 Thread Dongdong Liu
From: Jie Hai This patch fixes possible use of uninitialized variable "old_tuple_fields". Fixes: e3069658da9f ("net/hns3: reimplement hash flow function") Cc: sta...@dpdk.org Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_flow.c | 5 +++-

[PATCH 07/11] net/hns3: fix no errcode returned when failed to init queue

2023-05-29 Thread Dongdong Liu
From: Chengwen Feng If hns3_init_queues() return failed, the hns3vf_do_start() should return errcode. This patch fixes it. Fixes: 43d8adf3891c ("net/hns3: fix RSS flow rule restore") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- driver

[PATCH 04/11] net/hns3: extract a PTP header file

2023-05-29 Thread Dongdong Liu
From: Huisong Li This patch extracts a PTP header file to contain PTP registers and external API in order to make PTP code structure more clear. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- d

[PATCH 01/11] net/hns3: fix uninitialized RTC time

2023-05-29 Thread Dongdong Liu
From: Huisong Li Driver doesn't initialize RTC time during probe phase, which lead to an inaccurate time. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ptp.c | 7

[PATCH 03/11] net/hns3: add the uninitialization process of PTP

2023-05-29 Thread Dongdong Liu
From: Huisong Li This patch adds the uninitialization process of PTP in case of having an impact on PF driver in kernel. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_eth

[PATCH v2 5/5] net/hns3: add Tx/Rx descriptor logs

2023-05-22 Thread Dongdong Liu
From: Dengdui Huang Add Tx/Rx descriptor logs, controlled by 'RTE_ETHDEV_DEBUG_RX/TX' compile time flag with 'pmd.net.hns3.rx/tx' log type. Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 6 ++ drivers/net/hns

[PATCH v2 1/5] net/hns3: fix never set MAC flow control

2023-05-22 Thread Dongdong Liu
Fixes: 1f411e31a826 ("net/hns3: support flow control autoneg for copper port") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net/hns3/

[PATCH v2 4/5] net/hns3: fix receive multiple firmware reset interrupts

2023-05-22 Thread Dongdong Liu
ned-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index 5ef66f96c6..664226a6ef 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/d

[PATCH v2 3/5] net/hns3: fix loop code variable type mismatch

2023-05-22 Thread Dongdong Liu
k.org Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- .mailmap | 1 + drivers/net/hns3/hns3_regs.c | 3 ++- drivers/net/hns3/hns3_stats.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index 976e4ef6f8..e9a3d443dc 100644

[PATCH v2 2/5] net/hns3: add flow control autoneg for fiber port

2023-05-22 Thread Dongdong Liu
From: Huisong Li This patch support flow control autoneg for fiber and backplane port. And it depends on the capability of firmware. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_cmd.c| 30 +- drivers/net/hns3/hns3_cmd.h| 20

[PATCH v2 0/5] net/hns3: add some features and bugfixes

2023-05-22 Thread Dongdong Liu
This patchset contains some features and bugfixes for hns3. v1->v2: -Fix check-git-log warnings. Chengwen Feng (1): net/hns3: fix receive multiple firmware reset interrupts Dengdui Huang (2): net/hns3: fix loop code variable type mismatch net/hns3: add Tx/Rx descriptor logs Huisong Li (2)

Re: [PATCH 0/5] ] net/hns3: add some features and bugfixes

2023-05-22 Thread Dongdong Liu
Hi Ferruh Many thanks for your review. On 2023/5/22 19:57, Ferruh Yigit wrote: On 5/18/2023 12:29 PM, Dongdong Liu wrote: This patchset contains some features and bugfixes for hns3. Chengwen Feng (1): net/hns3: fix receive multiple firmware reset interrupts Dengdui Huang (2): net/hns3

[PATCH 5/5] net/hns3: add Tx/Rx descriptor logs

2023-05-18 Thread Dongdong Liu
From: Dengdui Huang Add Tx/Rx descriptor logs, controlled by 'RTE_ETHDEV_DEBUG_RX/TX' compile time flag with 'pmd.net.hns3.rx/tx' log type. Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 6 ++ drivers/net/hns

[PATCH 2/5] net/hns3: add flow control autoneg for fiber and backplane port

2023-05-18 Thread Dongdong Liu
From: Huisong Li This patch support flow control autoneg for fiber and backplane port. And it depends on the capability of firmware. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_cmd.c| 30 +- drivers/net/hns3/hns3_cmd.h| 20

[PATCH 4/5] net/hns3: fix receive multiple firmware reset interrupts

2023-05-18 Thread Dongdong Liu
impact of 5ms, the number of PFs managed by a firmware is limited. Therefore, even if a DPDK process takes over all the PFs which managed by the firmware, the delay is controllable. Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c

[PATCH 3/5] net/hns3: fix loop code variable type mismatch

2023-05-18 Thread Dongdong Liu
From: Dengdui Huang Loop conditions are compared with different variable types, which may cause overflow risks. Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_regs.c | 3 ++- drivers/net/hns3/hns3_stats.c | 2 +- 2 files changed, 3 insertions(+), 2

[PATCH 1/5] net/hns3: fix never set MAC flow control

2023-05-18 Thread Dongdong Liu
Fixes: 1f411e31a826 ("net/hns3: support flow control autoneg for copper port") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net/hns3/

[PATCH 0/5] ] net/hns3: add some features and bugfixes

2023-05-18 Thread Dongdong Liu
This patchset contains some features and bugfixes for hns3. Chengwen Feng (1): net/hns3: fix receive multiple firmware reset interrupts Dengdui Huang (2): net/hns3: fix loop code variable type mismatch net/hns3: add Tx/Rx descriptor logs Huisong Li (2): net/hns3: fix never set MAC flow c

Re: [PATCH 0/2] net/hns3: add some features for hns3 pmd

2023-05-16 Thread Dongdong Liu
Kindly ping. Thanks, Dongdong On 2023/4/21 17:53, Dongdong Liu wrote: This patchset is to add some features for hns3 pmd. Chengwen Feng (1): net/hns3: support dump media type Dongdong Liu (1): net/hns3: simplify for hardware csum offloading drivers/net/hns3/hns3_cmd.c| 3

[PATCH 1/2] net/hns3: simplify for hardware csum offloading

2023-04-21 Thread Dongdong Liu
L4. Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_cmd.c| 3 ++ drivers/net/hns3/hns3_cmd.h| 1 + drivers/net/hns3/hns3_dump.c | 1 + drivers/net/hns3/hns3_ethdev.h | 1 + drivers/net/hns3/hns3_rxtx.c | 52 +- drivers/net/hns3/hns3_rxtx.h

[PATCH 0/2] net/hns3: add some features for hns3 pmd

2023-04-21 Thread Dongdong Liu
This patchset is to add some features for hns3 pmd. Chengwen Feng (1): net/hns3: support dump media type Dongdong Liu (1): net/hns3: simplify for hardware csum offloading drivers/net/hns3/hns3_cmd.c| 3 ++ drivers/net/hns3/hns3_cmd.h| 1 + drivers/net/hns3/hns3_dump.c | 3

[PATCH 2/2] net/hns3: support dump media type

2023-04-21 Thread Dongdong Liu
From: Chengwen Feng The media type information helps locate faults such as AN or rate switching, so add dump media type in eth_dev_priv_dump ops. Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_dump.c | 2 ++ drivers/net/hns3/hns3_ethdev.c | 2 +- drivers

[PATCH 7/7] net/hns3: support getting current FEC capability from firmware

2023-04-07 Thread Dongdong Liu
From: Jie Hai Obtain the supported FEC capability from the firmware to enhance code compatibility. Cc: sta...@dpdk.org Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_cmd.h| 9 - drivers/net/hns3/hns3_ethdev.c | 29

[PATCH 6/7] net/hns3: add LLRS FEC mode support for 200G ports

2023-04-07 Thread Dongdong Liu
From: Jie Hai This patch supports the query and configuration of LLRS FEC mode. Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_cmd.c| 1 + drivers/net/hns3/hns3_cmd.h| 2 ++ drivers/net/hns3/hns3_ethdev.c | 21 - 3 files changed, 15

[PATCH 5/7] app/testpmd: add setting and querying of LLRS FEC mode

2023-04-07 Thread Dongdong Liu
From: Jie Hai This patch supports setting and querying of LLRS FEC mode. Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- app/test-pmd/cmdline.c | 5 - app/test-pmd/config.c | 4 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- 3

[PATCH 4/7] ethdev: introduce low latency RS FEC

2023-04-07 Thread Dongdong Liu
From: Jie Hai This patch introduces LLRS (low latency Reed Solomon FEC). LLRS supports for 25 Gbps, 50 Gbps, 100 Gbps, 200 Gbps and 400 Gbps Ethernet networks. Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- doc/guides/rel_notes/release_23_07.rst | 3 +++ lib/ethdev/rte_ethdev.h

[PATCH 3/7] net/hns3: fix missing FEC capability

2023-04-07 Thread Dongdong Liu
of other rates are not reported. So this patch reports the FEC capabilities by the speed capabilities of the network port. Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC") Cc: sta...@dpdk.org Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethd

[PATCH 2/7] net/hns3: fix fec mode check error

2023-04-07 Thread Dongdong Liu
o extracts the code for verifying mode parameter into a function. Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC") Cc: sta...@dpdk.org Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 50 -- 1 file changed, 24 inserti

[PATCH 1/7] net/hns3: fix fec mode for 200G ports

2023-04-07 Thread Dongdong Liu
From: Jie Hai The hardware does not support NOFEC for 200G ports. So delete this bit. Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC") Cc: sta...@dpdk.org Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 0/7] add setting and querying of LLRS FEC mode

2023-04-07 Thread Dongdong Liu
This patchset include some bugfixes for hns3 fec and add setting and querying of LLRS FEC mode. Jie Hai (7): net/hns3: fix fec mode for 200G ports net/hns3: fix fec mode check error net/hns3: fix missing FEC capability ethdev: introduce low latency RS FEC app/testpmd: add setting and que

Re: [PATCH] net/hns3: fix build warning

2023-04-04 Thread Dongdong Liu
Acked-by: Dongdong Liu Thanks, Dongdong Fixes: 64308555d5bf ("net/hns3: fix link status when port is stopped") Cc: sta...@dpdk.org Signed-off-by: Jerin Jacob --- drivers/net/hns3/hns3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_

Re: [PATCH 09/33] doc: update hns3 guide

2023-03-22 Thread Dongdong Liu
File Options" section to "Compilation Options" - Rename "Runtime Config Options" section to "Runtime Configuration" Signed-off-by: Ferruh Yigit Acked-by: Dongdong Liu Thanks, Dongdong --- doc/guides/nics/hns3.rst | 30 +++--- 1 file c

Re: [PATCH 1/5] ethdev: support setting and querying rss algorithm

2023-03-16 Thread Dongdong Liu
Hi Thomas On 2023/3/15 21:43, Thomas Monjalon wrote: 15/03/2023 12:00, Dongdong Liu: From: Jie Hai --- a/doc/guides/rel_notes/release_23_03.rst +++ b/doc/guides/rel_notes/release_23_03.rst -* No ABI change that would break compatibility with 22.11. - +* ethdev: Added "func"

Re: [PATCH 1/5] ethdev: support setting and querying rss algorithm

2023-03-16 Thread Dongdong Liu
Hi Ivan Many thanks for your review. On 2023/3/15 19:28, Ivan Malov wrote: Hi, On Wed, 15 Mar 2023, Dongdong Liu wrote: From: Jie Hai Currently, rte_eth_rss_conf supports configuring rss hash functions, rss key and it's length, but not rss hash algorithm. The structure ``rte_eth_rss

[PATCH] app/testpmd: display RSS hash key of rte flow rule

2023-03-16 Thread Dongdong Liu
From: Huisong Li There are two ways to set RSS hash key with rte flow rule: 1. 'key_len' isn't zero and 'key' is NULL. 2. 'key_len' isn't zero and 'key' isn't NULL. This patch adds displaying for the hash key of rte flow rule. Signed-of

[PATCH 5/5] app/proc-info: support querying RSS hash algorithm

2023-03-15 Thread Dongdong Liu
From: Jie Hai Display RSS hash algorithm with command show-port as below. - RSS info -- hash algorithm: toeplitz Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- app/proc-info/main.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/app/proc-info

[PATCH 4/5] app/proc-info: show RSS types with strings

2023-03-15 Thread Dongdong Liu
): 6d5a56da255b0ec24167253d43a38fb0d0ca2bcbae7b30b477cb2da38030f20c6a42b73bbeac01fa Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- app/proc-info/main.c | 120 --- 1 file changed, 113 insertions(+), 7 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 878ce37e8b..7b6f8f1228 100644

[PATCH 3/5] app/proc-info: fix never show RSS info

2023-03-15 Thread Dongdong Liu
ff-by: Jie Hai Signed-off-by: Dongdong Liu --- app/proc-info/main.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 53e852a07c..878ce37e8b 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c

[PATCH 2/5] net/hns3: support setting and querying RSS hash function

2023-03-15 Thread Dongdong Liu
From: Huisong Li Support setting and querying RSS hash function by ethdev ops. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rss.c | 47 + 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/drivers/net/hns3

[PATCH 1/5] ethdev: support setting and querying rss algorithm

2023-03-15 Thread Dongdong Liu
set. Do the same for rte_eth_dev_rss_hash_update and rte_eth_dev_configure. To check whether the drivers report the func field, it is set to default value before querying. Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- doc/guides/rel_notes/release_23_03.rst | 4 ++-- lib/ethdev/rte_ethdev.c

[PATCH 0/5] support setting and querying RSS algorithms

2023-03-15 Thread Dongdong Liu
This patchset is to support setting and querying RSS algorithms. Huisong Li (1): net/hns3: support setting and querying RSS hash function Jie Hai (4): ethdev: support setting and querying rss algorithm app/proc-info: fix never show RSS info app/proc-info: show RSS types with strings app

  1   2   3   >