Re: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload

2018-08-03 Thread Dai, Wei
Thanks, Iremonger. I will reply this patch with a v3 patch. > -Original Message- > From: Iremonger, Bernard > Sent: Thursday, August 2, 2018 5:12 PM > To: Dai, Wei ; Wu, Jingjing ; Lu, > Wenzhuo > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: RE: [dpdk-dev

Re: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload

2018-08-01 Thread Dai, Wei
Hi, Bernard Thanks for your feedback and guidance. I have just submitted a v2 patch to include modification on document. Thanks & Best Regrards -Wei > -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, July 24, 2018 10:22 PM > To: Dai, Wei ; Wu, Jingjing

Re: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload

2018-07-19 Thread Dai, Wei
Hi, Yuan How about your test result ? Thanks a lot! > -Original Message- > From: Dai, Wei > Sent: Thursday, July 19, 2018 8:21 PM > To: Wu, Jingjing ; yuan.p...@intle.com > Cc: dev@dpdk.org; sta...@dpdk.org; Dai, Wei > Subject: [PATCH] app/testpmd: fix commands to c

Re: [dpdk-dev] [PATCH v4] net/ixgbe: config VLAN strip on the fly

2018-05-19 Thread Dai, Wei
Hi, Zhang Qi Thanks for your feedback. I've just submitted v5 patch to follow your guidance. > -Original Message- > From: Zhang, Qi Z > Sent: Saturday, May 19, 2018 8:19 AM > To: Dai, Wei ; Lu, Wenzhuo ; > Ananyev, Konstantin ; Wu, Yanglong > ; Yigit, Ferruh >

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port

2018-05-18 Thread Dai, Wei
As 18.05 release is coming soon. I'd like to submit http://dpdk.org/dev/patchwork/patch/40226/ in reply to yanglong's v2 patch for quick review and validation. Thanks for your understanding. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port

2018-05-18 Thread Dai, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, May 18, 2018 8:37 PM > To: Dai, Wei ; Wu, Yanglong > ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port > > Hi Daiwei: > > > -Original Message- &g

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port

2018-05-18 Thread Dai, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, May 18, 2018 3:46 PM > To: Wu, Yanglong ; dev@dpdk.org > Cc: Dai, Wei > Subject: RE: [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port > > > -Original Message- > > From: Wu,

Re: [dpdk-dev] [PATCH] bus/pci: fix error in parsing vfio driver

2018-05-15 Thread Dai, Wei
Give up this patch as there is already a patch in http://dpdk.org/dev/patchwork/patch/40030/ bus/pci: correct the earlier strlcpy conversion > -Original Message- > From: Dai, Wei > Sent: Tuesday, May 15, 2018 10:41 PM > To: Yigit, Ferruh ; Burakov, Anatoly > > Cc: dev@

Re: [dpdk-dev] [PATCH v13] ethdev: new Rx/Tx offloads API

2018-05-14 Thread Dai, Wei
Hi, Thomas Thanks for your quick feedback. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, May 14, 2018 8:54 PM > To: Dai, Wei > Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Qi Z > > Subject: Re: [dpdk-dev] [PATCH v13] ethdev: n

Re: [dpdk-dev] [PATCH v12] ethdev: new Rx/Tx offloads API

2018-05-14 Thread Dai, Wei
mailto:tho...@monjalon.net] > Sent: Monday, May 14, 2018 4:37 PM > To: Dai, Wei > Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Qi Z > > Subject: Re: [dpdk-dev] [PATCH v12] ethdev: new Rx/Tx offloads API > > Wei Dai, > Do you agree with my comments? > Could we have a wording patch to sq

Re: [dpdk-dev] [PATCH v10] ethdev: new Rx/Tx offloads API

2018-05-10 Thread Dai, Wei
Hi, Thomas Thanks for your feedback and guidance. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, May 10, 2018 10:36 AM > To: Dai, Wei > Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Qi Z > > Subject: Re: [dpdk-dev] [PATCH v

Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-09 Thread Dai, Wei
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, May 8, 2018 8:13 PM > To: Dai, Wei ; tho...@monjalon.net; Doherty, Declan > ; linvi...@tuxdriver.com; m...@semihalf.com; > m...@semihalf.com; gtza...@amazon.com; evge...@amazon.com; > ravi1.ku...

Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-09 Thread Dai, Wei
Hi, Andrew See my in-line comments as below. From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Tuesday, May 8, 2018 7:37 PM To: Dai, Wei ; Yigit, Ferruh ; tho...@monjalon.net; Doherty, Declan ; linvi...@tuxdriver.com; m...@semihalf.com; m...@semihalf.com; gtza...@amazon.com

Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-08 Thread Dai, Wei
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Wednesday, May 9, 2018 1:52 AM > To: Dai, Wei ; Yigit, Ferruh ; > tho...@monjalon.net; shah...@mellanox.com; Zhang, Qi Z > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v7 0/2] app/testpmd: add new commands to test new Tx/Rx offloads

2018-05-08 Thread Dai, Wei
ep the style of current command and avoid to introduce more commands. Can you agree it ? Thanks & Best Regards -Wei > -Original Message- > From: Dai, Wei > Sent: Tuesday, April 3, 2018 4:58 PM > To: Lu, Wenzhuo ; Wu, Jingjing > > Cc: dev@dpdk.org; Dai, Wei &g

Re: [dpdk-dev] [PATCH v7] ethdev: check Rx/Tx offloads

2018-05-07 Thread Dai, Wei
etter. I will adopt it in my v8 patch. > -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Sunday, May 6, 2018 3:00 AM > To: Dai, Wei ; Thomas Monjalon > ; Yigit, Ferruh > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v7] ethdev: check

Re: [dpdk-dev] [PATCH v4] ethdev: check Rx/Tx offloads

2018-04-26 Thread Dai, Wei
Thanks to Thomas, Ferruh and Zhang Qi for your feedback. I will rework v5 patch to follow your guidance. > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, April 26, 2018 4:51 PM > To: Thomas Monjalon > Cc: Yigit, Ferruh ; Dai, Wei ; > dev@dpdk.org > S

Re: [dpdk-dev] [PATCH v2] ethdev: check Rx/Tx offloads

2018-04-15 Thread Dai, Wei
Thanks, Thomas and Ferruh I think I can implement v3 for this. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, April 15, 2018 6:37 PM > To: Yigit, Ferruh ; Dai, Wei > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] e

Re: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status on start

2018-04-04 Thread Dai, Wei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Monday, April 2, 2018 10:34 PM > To: Chas Williams <3ch...@gmail.com> > Cc: Zhang, Helin ; dev@dpdk.org; Lu, Wenzhuo > ; Ananyev, Konstantin > ; Charles (Chas) Williams > Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-04-03 Thread Dai, Wei
no matter whether SCATTER is enabled on queue configuration or not. > -Original Message- > From: Ananyev, Konstantin > Sent: Sunday, April 1, 2018 8:09 PM > To: Zhang, Qi Z ; Dai, Wei ; > Wang, Xiao W > Cc: 'dev@dpdk.org' > Subject: RE: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH] net/fm10k: convert to new Rx/Tx offloads API

2018-03-27 Thread Dai, Wei
Thank you, Zhang Qi for your feedback. > -Original Message- > From: Zhang, Qi Z > Sent: Monday, March 19, 2018 11:55 AM > To: Dai, Wei ; Wang, Xiao W > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/fm10k: convert to new Rx/Tx offloads API > > Hi Daiwei: >

Re: [dpdk-dev] [PATCH] ethdev: add enum type for loop on Rx/Tx offloads

2018-03-21 Thread Dai, Wei
Thanks Zhang Qi > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, March 21, 2018 10:24 PM > To: Dai, Wei ; Ananyev, Konstantin > ; tho...@monjalon.net > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] ethdev: add enum type for loo

Re: [dpdk-dev] [PATCH] ethdev: add enum type for loop on Rx/Tx offloads

2018-03-21 Thread Dai, Wei
Hi, Konstantin Thanks for your feedback. > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, March 20, 2018 8:00 PM > To: Dai, Wei ; tho...@monjalon.net > Cc: dev@dpdk.org; Dai, Wei > Subject: RE: [dpdk-dev] [PATCH] ethdev: add enum type for loop o

Re: [dpdk-dev] [PATCH v2 3/4] net/ixgbe: convert to new Rx offloads API

2018-03-21 Thread Dai, Wei
Hi, Konstantin Thanks for your patient guidance! > IXGBE_WRITE_REG(hw, IXGBE_SRRCTL(rxq->reg_idx), srrctl); in > ixgbe_dev_rx_init( ). > > Same case is also in the code line: IXGBE_WRITE_REG(hw, > IXGBE_VFSRRCTL(i), srrctl); in ixgbevf_dev_rx_init( ). > > Yes, HW can enable/disable it on a per que

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: add enum type for loop on Rx/Tx offloads

2018-03-19 Thread Dai, Wei
Hi Zhang Qi Thanks for your feedback. > -Original Message- > From: Zhang, Qi Z > Sent: Monday, March 19, 2018 10:06 PM > To: Dai, Wei ; Lu, Wenzhuo ; > Wu, Jingjing > Cc: dev@dpdk.org; Dai, Wei > Subject: RE: [dpdk-dev] [PATCH v4 1/3] ethdev: add enum type for loo

Re: [dpdk-dev] [PATCH 4/4] net/ixgbe: convert to new Tx offloads API

2018-03-18 Thread Dai, Wei
Hi, Konstantin Thanks for your feedback. > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, March 15, 2018 7:19 AM > To: Dai, Wei ; Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: RE: [PATCH 4/4] net/ixgbe: convert to new Tx offloads API > > > >

Re: [dpdk-dev] [PATCH v2 3/4] net/ixgbe: convert to new Rx offloads API

2018-03-18 Thread Dai, Wei
Hi, Konstantin Thanks for your feedback. > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, March 15, 2018 5:48 AM > To: Dai, Wei ; Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 3/4] net/ixgbe: convert to new Rx offloads API > > Hi W

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add commands to test new Rx offload API

2018-03-17 Thread Dai, Wei
> -Original Message- > From: Wu, Jingjing > Sent: Thursday, March 15, 2018 3:41 AM > To: Dai, Wei ; Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 1/2] app/testpmd: add commands to test new Rx > offload API > > <...> > > > +static i

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add commands to test new Rx offload API

2018-03-17 Thread Dai, Wei
> Sent: Tuesday, March 13, 2018 5:31 PM > To: Andrew Rybchenko ; Dai, Wei > ; Lu, Wenzhuo ; Wu, Jingjing > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add commands to test > new Rx offload API > > > > > -Original Message-

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add commands to test new Rx offload API

2018-03-12 Thread Dai, Wei
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Monday, March 12, 2018 4:43 PM > To: Dai, Wei ; Lu, Wenzhuo ; > Wu, Jingjing > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add commands to test > new R

Re: [dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF

2018-01-21 Thread Dai, Wei
can be initialized successfully and Rx queue can be waked up by incoming packets no matter whether this line exists or not. So I decide to reject it now. > -Original Message- > From: Yang, Qiming > Sent: Wednesday, January 10, 2018 2:29 PM > To: Lu, Wenzhuo ; Dai, Wei > C

Re: [dpdk-dev] [PATCH v3 1/6] net/ixgbevf: unregister irq handler when other interrupts not allowed.

2018-01-14 Thread Dai, Wei
> -Original Message- > From: xiangxia.m@gmail.com [mailto:xiangxia.m@gmail.com] > Sent: Sunday, January 14, 2018 6:04 PM > To: Dai, Wei ; Xing, Beilei > Cc: dev@dpdk.org; Tonghao Zhang > Subject: [PATCH v3 1/6] net/ixgbevf: unregister irq handler when othe

Re: [dpdk-dev] [PATCH 4/5] net/ixgbevf: add check for rte_intr_enable.

2018-01-12 Thread Dai, Wei
Hi, Tonghao Thanks for your patch. It looks that same change can be applied to ixgbe_dev_interrupt_action( ) and ixgbe_dev_interrupt_delayed_handler( ). Anyway, you can test all these changes with example/l3fwd-power. -Wei > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On

Re: [dpdk-dev] [PATCH v2 3/4] net/ixgbevf: save IXGBE_VTEIMS to intr->mask for performance.

2018-01-12 Thread Dai, Wei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of > xiangxia.m@gmail.com > Sent: Friday, January 12, 2018 12:40 AM > To: Xing, Beilei ; dev@dpdk.org > Cc: Tonghao Zhang > Subject: [dpdk-dev] [PATCH v2 3/4] net/ixgbevf: save IXGBE_VTEIMS to > intr->mask for per

Re: [dpdk-dev] [PATCH v2 1/4] net/ixgbevf: unregister irq handler when other interrupts not allowed.

2018-01-12 Thread Dai, Wei
Hi, Tonghao & Beilei The issue reported by Tonghao is caused by shortage of igb_uio. If you want to use Rx queue interrupt in your DPDK application, I suggest use VFIO-PCI to bind NIC port instead of igb_uio. Currently igb_uio only support single event fd. This fd is triggered by both miscellane

Re: [dpdk-dev] [PATCH v4 0/2] app/testpmd: fix invalid rxq and txq nubmer settings

2018-01-11 Thread Dai, Wei
t: Friday, January 12, 2018 1:40 PM > To: Dai, Wei ; Ananyev, Konstantin > ; Yang, Qiming ; > Lu, Wenzhuo ; Wu, Jingjing > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v4 0/2] app/testpmd: fix invalid rxq and txq nubmer > settings > > Hi Wei, > > There is a

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on VF

2018-01-11 Thread Dai, Wei
> -Original Message- > From: Wu, Yanglong > Sent: Friday, January 12, 2018 10:38 AM > To: Dai, Wei ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on VF > > Hi > After confirm with Daiwei and according to the data sheet,

Re: [dpdk-dev] [PATCH 2/2] net/e1000: fix mailbox interrupt handler

2018-01-11 Thread Dai, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, December 28, 2017 4:23 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Dai, Wei ; Wang, Liang-min > ; Zhang, Qi Z ; > sta...@dpdk.org > Subject: [PATCH 2/2] net/e1000: fix mailbox interrupt handler > >

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler

2018-01-11 Thread Dai, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, December 28, 2017 4:22 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Dai, Wei ; Wang, Liang-min > ; Zhang, Qi Z ; > sta...@dpdk.org > Subject: [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler > >

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler

2018-01-11 Thread Dai, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, January 11, 2018 4:08 PM > To: Dai, Wei ; Lu, Wenzhuo > Cc: dev@dpdk.org; Wang, Liang-min ; > sta...@dpdk.org > Subject: RE: [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler > > > > >

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on VF

2018-01-11 Thread Dai, Wei
According to 82599 datasheet, VF working mode is controlled by its host PF. If VF is working in RSS or DCB mode, it can use more than 1 queues. That also means its host PF should enable RSS or DCB. The PF Rx mode can be ETH_MQ_RX_VMDQ_RSS or ETH_MQ_RX_VMDQ_DCB. So I think that DPDK app with PF caus

Re: [dpdk-dev] [PATCH v3 0/2] app/testpmd: fix invalid rxq and txq nubmer setting

2018-01-10 Thread Dai, Wei
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, January 10, 2018 5:59 PM > To: Dai, Wei ; Yang, Qiming ; > Peng, Yuan ; Lu, Wenzhuo ; > Wu, Jingjing > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v3 0/2] app/testpmd: fix invalid rxq

Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: fix invalid txq number setting

2018-01-10 Thread Dai, Wei
> -Original Message- > From: Yang, Qiming > Sent: Wednesday, January 10, 2018 2:38 PM > To: Dai, Wei ; Lu, Wenzhuo ; > Wu, Jingjing ; Peng, Yuan ; > Ananyev, Konstantin > Cc: dev@dpdk.org; sta...@dpdk.org; Dai, Wei > Subject: RE: [dpdk-dev] [PATCH v2 2/2] app/

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix invalid rxq number setting

2018-01-09 Thread Dai, Wei
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, January 10, 2018 9:55 AM > To: Dai, Wei ; Lu, Wenzhuo ; > Wu, Jingjing ; Peng, Yuan > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/2] app/testpmd: fix invalid

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix invalid rxq number setting

2018-01-09 Thread Dai, Wei
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, January 9, 2018 4:06 AM > To: Dai, Wei ; Lu, Wenzhuo ; > Wu, Jingjing ; Peng, Yuan > Cc: dev@dpdk.org; sta...@dpdk.org; Dai, Wei > Subject: RE: [dpdk-dev] [PATCH 1/2] app/testpmd: fix invalid

Re: [dpdk-dev] [PATCH v9] net/i40e: determine number of queues per VF during run time

2018-01-09 Thread Dai, Wei
Thanks to Helin and Ferruh, I will submit v10 patch following your guide. > -Original Message- > From: Zhang, Helin > Sent: Monday, January 8, 2018 2:01 PM > To: Dai, Wei ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org > Subject: RE: [PATCH v9] net/i40e: determine

Re: [dpdk-dev] [PATCH v4 1/2] net/e1000: move RSS to flow API

2018-01-04 Thread Dai, Wei
> -Original Message- > From: Zhao1, Wei > Sent: Thursday, January 4, 2018 3:46 PM > To: dev@dpdk.org > Cc: Dai, Wei ; Zhao1, Wei > Subject: [PATCH v4 1/2] net/e1000: move RSS to flow API > > Rte_flow actually defined to include RSS, but till now, RSS is out of

Re: [dpdk-dev] [PATCH v4 2/2] net/ixgbe: move RSS to flow API

2018-01-04 Thread Dai, Wei
> -Original Message- > From: Zhao1, Wei > Sent: Thursday, January 4, 2018 3:46 PM > To: dev@dpdk.org > Cc: Dai, Wei ; Zhao1, Wei > Subject: [PATCH v4 2/2] net/ixgbe: move RSS to flow API > > Rte_flow actually defined to include RSS, but till now, RSS is out of

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler

2017-12-27 Thread Dai, Wei
: Zhang, Qi Z > Sent: Thursday, December 28, 2017 4:22 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Dai, Wei ; Wang, Liang-min > ; Zhang, Qi Z ; > sta...@dpdk.org > Subject: [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler > > Mailbox interrupt handler only take car

Re: [dpdk-dev] [PATCH] igb: fix Tx queue number

2017-12-19 Thread Dai, Wei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of zhouyangchao > Sent: Wednesday, November 29, 2017 10:50 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] igb: fix Tx queue number > > Internal variable containing the number of TX queues for a

Re: [dpdk-dev] [PATCH v6] net/i40e: determine number of queues per VF during run time

2017-12-07 Thread Dai, Wei
> -Original Message- > From: Ananyev, Konstantin > Sent: Sunday, December 3, 2017 7:20 PM > To: Dai, Wei ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org > Subject: RE: [PATCH v6] net/i40e: determine number of queues per VF during > run time > > Hi Wei

Re: [dpdk-dev] [PATCH v3 2/2] net/ixgbe: move RSS to flow API

2017-12-07 Thread Dai, Wei
Hi, Zhao Wei Please correct build error show in http://dpdk.org/ml/archives/test-report/2017-November/035130.html > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Friday, November 24, 2017 4:05 PM > To: dev@dpdk.org > Cc: Zhao1, Wei > Subject:

Re: [dpdk-dev] [PATCH v3 1/2] net/e1000: move RSS to flow API

2017-12-07 Thread Dai, Wei
Hi, Zhao Wei Please correct build error show in http://dpdk.org/ml/archives/test-report/2017-November/035129.html > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Friday, November 24, 2017 4:05 PM > To: dev@dpdk.org > Cc: Zhao1, Wei > Subject:

Re: [dpdk-dev] [PATCH v3] net/i40e: determine number of queues per VF during run time

2017-11-21 Thread Dai, Wei
Thank you, Konstantin for your quick feedback. Please see my inline comments below. > -Original Message- > From: Ananyev, Konstantin > Sent: Monday, November 20, 2017 7:32 PM > To: Dai, Wei ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Dai, Wei > Subject: RE:

Re: [dpdk-dev] [PATCH] net/ixgbe: fix VF RX hang

2017-11-21 Thread Dai, Wei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Monday, November 20, 2017 11:38 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix VF RX hang > > The datasheet says, if using MSI-X mode, th

Re: [dpdk-dev] [PATCH v3 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power

2017-11-03 Thread Dai, Wei
> -Original Message- > From: Dai, Wei > Sent: Friday, November 3, 2017 4:47 PM > To: Wu, Jingjing ; Xing, Beilei > > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH v3 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power > > These 2 bugs can be observed f

Re: [dpdk-dev] [PATCH 2/2] net/i40e: fix Rx queue interrupt mapping in VF

2017-11-02 Thread Dai, Wei
Hi, Jingjing Thanks for your feedback. > > Subject: [PATCH 2/2] net/i40e: fix Rx queue interrupt mapping in VF > > > > When a VF port is bound to VFIO-PCI, miscellaneous interrupt is mapped > > to MSI-X vector 0 and Rx queues interrupt are mapped to other vectors > > in vfio_enable_msix( ). To s

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix VFIO interrupt mapping in VF

2017-11-02 Thread Dai, Wei
Hi, Jingjing Thanks for your feedback. > > Subject: [PATCH 1/2] net/i40e: fix VFIO interrupt mapping in VF > > > > When a VF port is bound to VFIO-PIC, only miscellaneous interrupt is > > mapped to VFIO vector 0 in i40evf_dev_init( ). > > In ixgbevf_dev_interrupt_handler( ), if previous VFIO inter

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix filter parser error in L2 tunnel

2017-11-02 Thread Dai, Wei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Peng, Yuan > Sent: Friday, November 3, 2017 11:39 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Zhao1, Wei > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix filter parser error in L2 > tunnel > > Tested-by: Peng Yu

Re: [dpdk-dev] [PATCH 0/3] RFC: implement VF reset for i40e, e1000 and ixgbe

2017-10-26 Thread Dai, Wei
hould try multiple times until the PF is UP. Regards -Wei > -Original Message- > From: luca.bocca...@gmail.com [mailto:luca.bocca...@gmail.com] > Sent: Tuesday, October 24, 2017 9:16 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Dai, Wei ; > Horton, Remy > Subject: [PATCH

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VFIO interrupt mapping in VF

2017-10-11 Thread Dai, Wei
Reply for correct mail format. > -Original Message- > From: Dai, Wei > Sent: Wednesday, October 11, 2017 3:07 PM > To: Ma, Jianwei ; Lu, Wenzhuo > ; Ananyev, Konstantin > ; Liang, Cunming > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v2] ne

Re: [dpdk-dev] [PATCH] net/ixgbe: fix Rx queue interrupt mapping in VF

2017-10-11 Thread Dai, Wei
I look through from web browser and not find following mail from Jianwei Ma Hope this can add his test result in the mail list to community. > -Original Message- > From: Ma, Jianwei > Sent: Tuesday, October 10, 2017 4:48 PM > To: Dai, Wei ; Lu, Wenzhuo ; > Ananyev, Konsta

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VFIO interrupt mapping in VF

2017-10-11 Thread Dai, Wei
I look through from web browser and not find following mail from Jianwei Ma Hope this can add his test result in the mail list to community. > -Original Message- > From: Ma, Jianwei > Sent: Tuesday, October 10, 2017 4:47 PM > To: Dai, Wei ; Lu, Wenzhuo ; > Ananyev, Kon

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VFIO interrupt mapping in VF

2017-10-09 Thread Dai, Wei
Hi, Jianwei How about your test result ? Hi Wenzhuo Would you please review this patch ? Thanks a lot ! > -Original Message- > From: Dai, Wei > Sent: Thursday, September 28, 2017 10:29 AM > To: Lu, Wenzhuo ; Ananyev, Konstantin > ; Liang, Cunming > ; Ma, Jianwei

Re: [dpdk-dev] [PATCH] net/ixgbe: fix Rx queue interrupt mapping in VF

2017-10-09 Thread Dai, Wei
Hi, Jianwei How about your test result ? Hi, Wenzhuo Would you please review this patch ? Thanks a lot ! > -Original Message- > From: Dai, Wei > Sent: Wednesday, September 20, 2017 6:18 PM > To: Lu, Wenzhuo ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Dai, Wei

Re: [dpdk-dev] [PATCH v5] net/i40e: fix mirror rule reset when port is stopped

2017-09-23 Thread Dai, Wei
> -Original Message- > From: Ananyev, Konstantin > Sent: Saturday, September 23, 2017 6:37 PM > To: Wu, Jingjing ; Dai, Wei ; > Xing, Beilei > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v5] net/i40e: fix mirror rule reset w

Re: [dpdk-dev] [PATCH v5] net/i40e: fix mirror rule reset when port is stopped

2017-09-20 Thread Dai, Wei
t this patch, the error in second running of testpmd always happen. This patch can address this error. > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, September 20, 2017 5:23 PM > To: Dai, Wei ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Dai, W

Re: [dpdk-dev] [PATCH v2] net/i40e: fix mirror rule reset when port is stopped

2017-09-19 Thread Dai, Wei
Beilei ; Dai, Wei > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] net/i40e: fix mirror rule reset when port > is stopped > > > > > -Original Message- > > From: Xing, Beilei > > Sent: Monday, September 11, 2017 10:46

Re: [dpdk-dev] [PATCH v9 0/5] Support of NIC reset and keep same port id

2017-09-13 Thread Dai, Wei
Hi, Thomas Thanks for your great support ! > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, September 14, 2017 5:02 AM > To: Dai, Wei > Cc: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, > Konstantin ; Wu, Jingjing > ; Xing, Beilei

Re: [dpdk-dev] [PATCH] net/i40e: fix mirror rule reset when port is stopped

2017-09-07 Thread Dai, Wei
> -Original Message- > From: Wu, Jingjing > Sent: Thursday, September 7, 2017 3:51 PM > To: Dai, Wei ; Xing, Beilei > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/i40e: fix mirror rule reset when port is stopped > > > > > -Origina

Re: [dpdk-dev] [PATCH] net/i40e: fix mirror rule reset when port is stopped

2017-09-07 Thread Dai, Wei
Hi, Lijuan How about your test result ? > -Original Message- > From: Dai, Wei > Sent: Wednesday, September 6, 2017 10:52 PM > To: Wu, Jingjing ; Xing, Beilei > > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix mirror rule reset when port

Re: [dpdk-dev] [PATCH] net/i40e: fix mirror rule reset when port is stopped

2017-09-07 Thread Dai, Wei
> -Original Message- > From: Dai, Wei > Sent: Wednesday, September 6, 2017 10:52 PM > To: Wu, Jingjing ; Xing, Beilei > > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix mirror rule reset when port is stopped > > When an i40e PF

Re: [dpdk-dev] [PATCH v4] net/ixgbe: add support of 2.5G and 5G on X550

2017-07-26 Thread Dai, Wei
> -Original Message- > From: Lu, Wenzhuo > Sent: Thursday, July 27, 2017 12:59 AM > To: Dai, Wei ; Ananyev, Konstantin > > Cc: dev@dpdk.org > Subject: RE: [PATCH v4] net/ixgbe: add support of 2.5G and 5G on X550 > > Hi Wei, > > > -----Original Mess

Re: [dpdk-dev] [PATCH v3] net/ixgbe: add support of 2.5G and 5G on X550

2017-07-26 Thread Dai, Wei
> -Original Message- > From: Lu, Wenzhuo > Sent: Wednesday, July 26, 2017 11:02 PM > To: Dai, Wei ; Ananyev, Konstantin > > Cc: dev@dpdk.org > Subject: RE: [PATCH v3] net/ixgbe: add support of 2.5G and 5G on X550 > > Hi Wei, > > > -----Original Mess

Re: [dpdk-dev] [PATCH v2] net/ixgbe: add support of 2.5G and 5G on X550

2017-07-26 Thread Dai, Wei
> -Original Message- > From: Lu, Wenzhuo > Sent: Wednesday, July 26, 2017 10:14 PM > To: Dai, Wei ; Ananyev, Konstantin > > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: add support of 2.5G and 5G on X550 > > Hi Wei, > > > -----Original Mess

Re: [dpdk-dev] [PATCH v2] net/ixgbe: add support of 2.5G and 5G on X550

2017-07-26 Thread Dai, Wei
Hi, Wenzhuo > > speed = 0x0; > > if (*link_speeds == ETH_LINK_SPEED_AUTONEG) { > > - speed = (hw->mac.type != ixgbe_mac_82598EB) ? > > - IXGBE_LINK_SPEED_82599_AUTONEG : > > - IXGBE_LINK_SPEED_82598_AUTONEG; > > + switc

Re: [dpdk-dev] [PATCH v8 1/5] ethdev: add support of NIC reset

2017-07-23 Thread Dai, Wei
Many thanks, Remy. My v9 patch set has followed your guidance. > -Original Message- > From: Horton, Remy > Sent: Thursday, July 20, 2017 9:22 PM > To: Dai, Wei ; dev@dpdk.org > Cc: tho...@monjalon.net; Lu, Wenzhuo ; > Ananyev, Konstantin ; Xing, Beilei > ; Wu, Jingji

Re: [dpdk-dev] [PATCH v7 0/5] Support NIC reset and keep same port id

2017-07-19 Thread Dai, Wei
Remy is a Native English speaker. He will help me review my v8 patch set. Thank you, Remy. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, July 17, 2017 3:26 AM > To: Dai, Wei > Cc: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, > Konstan

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix Rx/Tx queue interrupt for x550 devices

2017-07-19 Thread Dai, Wei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Tuesday, July 18, 2017 10:29 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Lu, Wenzhuo ; Yang, Qiming > > Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix Rx/Tx queue interrupt for x550 > devices

Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-07-18 Thread Dai, Wei
another different type of SFP ? By the way, I'd like you provide more details on how to test your patch? With testpmd ? Or other app ? Thanks -Wei > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, June 29, 2017 9:00 PM > To: Srinivasan J ; Dai, Wei

Re: [dpdk-dev] [PATCH v7 0/5] Support NIC reset and keep same port id

2017-07-17 Thread Dai, Wei
Hi, Thomas Thanks for your expert guidance. I'll rework out v8 patch set to follow your guide and rebase to master brach. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, July 17, 2017 3:26 AM > To: Dai, Wei > Cc: dev@d

Re: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of NIC reset

2017-07-13 Thread Dai, Wei
> > Subject: RE: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of NIC > > reset > > > > > > > + * A DPDK application also can call this function to trigger an > > > + initative > > > + * port reset. > > > > When apart from the above use case? Even if it is above case, we should > have some event to

Re: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of NIC reset

2017-07-11 Thread Dai, Wei
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Tuesday, July 11, 2017 1:17 PM > To: Dai, Wei > Cc: tho...@monjalon.net; Lu, Wenzhuo ; > Ananyev, Konstantin ; Wu, Jingjing > ; Xing, Beilei ; > dev@dpdk.org > Subject: R

Re: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of NIC reset

2017-07-10 Thread Dai, Wei
-Original Message- From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] Sent: Monday, July 10, 2017 7:35 PM To: Dai, Wei Cc: tho...@monjalon.net; Lu, Wenzhuo ; Ananyev, Konstantin ; Wu, Jingjing ; Xing, Beilei ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 1/4] ethdev: add

Re: [dpdk-dev] [PATCH v5 2/4] net/ixgbe: add support of reset

2017-07-10 Thread Dai, Wei
Thanks, Thomas I have just sent out my v6 patch set which includes more details to explain why/what/when. -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Friday, July 7, 2017 4:36 PM To: Dai, Wei ; Yigit, Ferruh Cc: dev@dpdk.org; Lu, Wenzhuo ; Ananyev

Re: [dpdk-dev] [PATCH v5 0/4] Support NIC reset and keep same port id

2017-07-04 Thread Dai, Wei
Hi, Thomas Would you please have a look at this patch set ? If any question, please let me know . Thanks -Wei -Original Message- From: Wu, Jingjing Sent: Friday, June 30, 2017 6:50 PM To: Dai, Wei ; tho...@monjalon.net; Lu, Wenzhuo ; Ananyev, Konstantin ; Zhang, Helin ; Peng, Yuan

Re: [dpdk-dev] [PATCH v4 3/5] net/i40e: add support of reset

2017-06-30 Thread Dai, Wei
> -Original Message- > From: Wu, Jingjing > Sent: Friday, June 30, 2017 4:54 PM > To: Dai, Wei ; tho...@monjalon.net; Lu, Wenzhuo > ; Ananyev, Konstantin > ; Zhang, Helin ; > Peng, Yuan > Cc: dev@dpdk.org > Subject: RE: [PATCH v4 3/5] net

Re: [dpdk-dev] [PATCH v4 5/5] app/testpmd: enhance command to test NIC reset

2017-06-30 Thread Dai, Wei
7 5:10 PM > To: Dai, Wei ; tho...@monjalon.net; Lu, Wenzhuo > ; Ananyev, Konstantin > ; Zhang, Helin ; > Peng, Yuan > Cc: dev@dpdk.org > Subject: RE: [PATCH v4 5/5] app/testpmd: enhance command to test NIC reset > > > > > -----Original Message- > > Fro

Re: [dpdk-dev] [PATCH v2 4/5] app/testpmd: add command to test NIC reset

2017-06-29 Thread Dai, Wei
> -Original Message- > From: Wu, Jingjing > Sent: Wednesday, June 28, 2017 5:11 PM > To: Dai, Wei ; tho...@monjalon.net; Lu, Wenzhuo > ; Ananyev, Konstantin > ; Zhang, Helin > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 4/5] app/testpmd: add c

Re: [dpdk-dev] [PATCH v2 5/5] app/testpmd: add command to test NIC restoration

2017-06-28 Thread Dai, Wei
Thanks for your feedback. V3 patch set will follow your guide. > -Original Message- > From: Wu, Jingjing > Sent: Wednesday, June 28, 2017 5:05 PM > To: Dai, Wei ; tho...@monjalon.net; Lu, Wenzhuo > ; Ananyev, Konstantin > ; Zhang, Helin > Cc: dev@dpdk.org > Su

Re: [dpdk-dev] [PATCH v2 0/5] Support NIC reset and keep same port id

2017-06-28 Thread Dai, Wei
ethod. > -Original Message- > From: Peng, Yuan > Sent: Thursday, June 29, 2017 11:52 AM > To: Dai, Wei ; tho...@monjalon.net; Lu, Wenzhuo > ; Ananyev, Konstantin > ; Zhang, Helin ; Wu, > Jingjing > Cc: dev@dpdk.org; Dai, Wei > Subject: RE: [dpdk-dev] [PATCH v2 0/5] Support

Re: [dpdk-dev] [PATCH 7/7] net/i40e: add support of restoration

2017-06-20 Thread Dai, Wei
> -Original Message- > From: Wu, Jingjing > Sent: Wednesday, June 7, 2017 3:50 PM > To: Dai, Wei ; Lu, Wenzhuo ; > Ananyev, Konstantin ; Zhang, Helin > > Cc: dev@dpdk.org > Subject: RE: [PATCH 7/7] net/i40e: add support of restoration > > > > > -

Re: [dpdk-dev] [PATCH v4 05/19] net/ixgbe: properly reference PCI header

2017-06-14 Thread Dai, Wei
Why to introduce this change ? Even without this patch, all files can be built successfully. Each.*.o.d files in x86_64-native-linuxapp-gcc keeps same in both with and without this patch. So there is no need to add the line at least in the config of x86_64-native-linuxapp-gcc. > -Original

Re: [dpdk-dev] [PATCH v2] ethdev: moved bypass functions to ixgbe pmd

2017-05-31 Thread Dai, Wei
No other NIC has bypass functions except ixgbe, so I agree moving them from ethdev to ixgbe pmd. As these functions are exported to external upper layer application, it is necessary to use is_ixgbe_supported() to avoid be called by other type of NIC. > -Original Message- > From: dev [ma

Re: [dpdk-dev] 2nd try: problem with ixgbe_dev_link_update() for multi-speed fiber [was] Re: [PATCH v4] net/ixgbe: ensure link status is updated

2017-05-23 Thread Dai, Wei
Hi, Roger Sorry for typo error. You should set --log-level=8 Regards -Wei > -Original Message- > From: Dai, Wei > Sent: Tuesday, May 23, 2017 3:24 PM > To: 'Roger B. Melton' ; Laurent Hardy > ; dev@dpdk.org > Cc: Yigit, Ferruh ; Zhang, Helin > ; An

Re: [dpdk-dev] 2nd try: problem with ixgbe_dev_link_update() for multi-speed fiber [was] Re: [PATCH v4] net/ixgbe: ensure link status is updated

2017-05-23 Thread Dai, Wei
ions for us. Thanks & Best Regards -Wei > -Original Message- > From: Roger B. Melton [mailto:rmel...@cisco.com] > Sent: Tuesday, May 23, 2017 2:54 AM > To: Laurent Hardy ; dev@dpdk.org; Dai, Wei > > Cc: Yigit, Ferruh ; Zhang, Helin > ; Ananyev, Konstantin

Re: [dpdk-dev] [PATCH] examples/helloworld: add output of core id and socket id

2017-05-17 Thread Dai, Wei
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, May 17, 2017 10:16 PM > To: Dai, Wei ; Richardson, Bruce > ; Mcnamara, John > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/helloworld: add output of core id and > socket id > >

Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-05-15 Thread Dai, Wei
Hi, Srini There is a bit confusion. Your patch shows that your code is added into the function eth_ixgbevf_pci_remove( ). But it is not. It is added into the fucntion ixgbe_dev_start( ), right ? So would you please rebase it to R 17.05 ? Which type of ixgbe device id did you tested ? There are

Re: [dpdk-dev] bug in net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update beginning in 17.05-rc3?

2017-05-10 Thread Dai, Wei
Yes, it is a bug. The hw->mac.ops.get_media_type of ixgbe VF is NULL. I have just submitted a patch to fix it. http://dpdk.org/dev/patchwork/patch/24188/ > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Roger B Melton > Sent: Wednesday, May 10, 2017 1:53 AM > To:

Re: [dpdk-dev] [PATCH v2 0/3] add a macro to enable support of backtrace

2017-05-04 Thread Dai, Wei
referenced to use DPDK with musl in his mail titled " [dpdk-dev] Compiling DPDK 17.02 using musl instead of glibc " sent on 2017-03-14 Thanks & Best Regards -Wei > -Original Message----- > From: Dai, Wei > Sent: Monday, March 13, 2017 4:59 PM > To: dev@dpdk.org >

  1   2   >