Hi, Thomas Thanks for your expert guidance. I'll rework out v8 patch set to follow your guide and rebase to master brach.
> -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, July 17, 2017 3:26 AM > To: Dai, Wei <wei....@intel.com> > Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo...@intel.com>; Ananyev, > Konstantin <konstantin.anan...@intel.com>; Wu, Jingjing > <jingjing...@intel.com>; Xing, Beilei <beilei.x...@intel.com>; Mcnamara, > John <john.mcnam...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v7 0/5] Support NIC reset and keep same > port id > > 13/07/2017 17:53, Wei Dai: > > chagnes: > > v7: > > add description of NIC reset in doc/poll_mode_drv.rst > > Thanks for bringing more explanations. > The texts have to be reviewed by a native english speaker. > > About the organization of the doc, it is good to explain the VF use case in > the > prog guide as you do. But you should not add it to the doxygen. > The doxygen must be concise enough and explains only the API: > - when it can be called > - what a driver is doing when calling reset > - what is the expected state of the device after reset
