[PATCH 3/3] net/nfp: standard the data endian of NFDk Tx descritor

2025-04-14 Thread Chaoyong He
The data endian of NFDk Tx descriptor should be little, and the related logic also should modify. Fixes: d7f6d9b21ffa ("net/nfp: adjust coding style for NFDk") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfdk/nfp_n

[PATCH 2/3] net/nfp: standard the data endian of NFD3 Tx descritor

2025-04-14 Thread Chaoyong He
The data endian of NFD3 Tx descriptor should be little, and the related logic also should modify. Fixes: 3745dd9dd86f ("net/nfp: adjust coding style for NFD3") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/

[PATCH 0/3] standard the data endian of descriptors

2025-04-14 Thread Chaoyong He
This patch series standard the data endian of Rx/Tx descriptors into little endian to sync with the kernel driver. Chaoyong He (3): net/nfp: standard the data endian of Rx descriptor net/nfp: standard the data endian of NFD3 Tx descritor net/nfp: standard the data endian of NFDk Tx

[PATCH 1/3] net/nfp: standard the data endian of Rx descriptor

2025-04-14 Thread Chaoyong He
The data endian of Rx descriptor should be little endian, and the related logic also should modify. Fixes: 3745dd9dd86f ("net/nfp: adjust coding style for NFD3") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/

RE: [PATCH 1/3] app/testpmd: add/remove multiple VLAN filter IDs at once

2025-04-13 Thread Chaoyong He
> On Fri, 11 Apr 2025 16:10:03 +0800 > Chaoyong He wrote: > > > From: Long Wu > > > > The command of setting VLAN filter IDs can only set one VLAN filter ID > > at once. For example: > > testpmd> rx_vlan add 100 0 > > > > This is very in

[PATCH 2/2] net/nfp: fix control message over flow problem

2025-04-13 Thread Chaoyong He
f-by: Long Wu Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_net_cmsg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_net_cmsg.c b/drivers/net/nfp/nfp_net_cmsg.c index 8f77c5588a..1ebd66bb0f 100644 --- a/drivers/net/nfp/nfp_net_cmsg.c +++ b/drive

[PATCH 1/2] net/nfp: fix flow rule free problem

2025-04-13 Thread Chaoyong He
k.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_net_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_net_flow.c b/drivers/net/nfp/nfp_net_flow.c index 7f3fff2186..0e5003ebe3 100644 --- a/drivers/net/nfp/nfp_net_flow.c +++

[PATCH 0/2] fix two nfp pmd bugs

2025-04-13 Thread Chaoyong He
This patch series fix one coredump problem and one data over flow problem. Long Wu (2): net/nfp: fix flow rule free problem net/nfp: fix control message over flow problem drivers/net/nfp/nfp_net_cmsg.c | 3 ++- drivers/net/nfp/nfp_net_flow.c | 2 +- 2 files changed, 3 insertions(+), 2 deleti

[PATCH 2/3] ethdev: retrieve VLAN filter configuration

2025-04-11 Thread Chaoyong He
From: Long Wu Added an API `rte_eth_dev_get_vlan_filter_conf()` to retrieve the VLAN filter configuration of an Ethernet device. Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- doc/guides/rel_notes/release_25_07.rst | 5 + lib/ethdev/ethdev_trace.h | 8 lib

[PATCH 3/3] app/testpmd: add a command to show VLAN filter IDs

2025-04-11 Thread Chaoyong He
From: Long Wu Introduce a new command to show the VLAN identifiers filtered by a port. Usage example: testpmd> rx_vlan show port 0 VLAN filter IDs: 1,4-5,9,12,14,18,3864-3865,3869,3874,3878,4076-4091,4093,4095, testpmd> Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- app/te

[PATCH 1/3] app/testpmd: add/remove multiple VLAN filter IDs at once

2025-04-11 Thread Chaoyong He
rts the user set any number valid VLAN filter IDs just through one command and it is also backwards compatible. For example: testpmd> rx_vlan add 100,102-103,200 0 The VLAN filter IDs 100, 102, 103, 200 will be added to port 0. Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- app/test-pmd/cmd

[PATCH 0/3] enhance the vlan filter feature

2025-04-11 Thread Chaoyong He
This patch series aims to enhance the vlan filter feature: - Support add/remove multiple vlan IDs just in one comment. - Support show the already configured vlan IDs. Long Wu (3): app/testpmd: add/remove multiple VLAN filter IDs at once ethdev: retrieve VLAN filter configuration app/testpmd:

[PATCH 1/3] net/nfp: support get RSS algorithm capability

2025-04-08 Thread Chaoyong He
Implement the logic of get RSS algorithm capability, also add the logic of print RSS algorithm capability. Signed-off-by: Chaoyong He --- drivers/common/nfp/nfp_common.h | 1 + drivers/common/nfp/nfp_common_ctrl.h | 3 +++ .../net/nfp/flower/nfp_flower_representor.c

[PATCH 2/3] net/nfp: support get RSS algorithm configuration

2025-04-08 Thread Chaoyong He
Implement the logic of get RSS algorithm configuration, also do little refactor to related functions. Signed-off-by: Chaoyong He --- drivers/net/nfp/nfp_net_common.c | 84 ++-- 1 file changed, 57 insertions(+), 27 deletions(-) diff --git a/drivers/net/nfp

[PATCH 3/3] net/nfp: correct RSS algorithm configuration logic

2025-04-07 Thread Chaoyong He
Correct the RSS algorithm configuration logic, also do some refactor to the related logic. Signed-off-by: Chaoyong He --- drivers/net/nfp/nfp_net_common.c | 121 +-- 1 file changed, 81 insertions(+), 40 deletions(-) diff --git a/drivers/net/nfp/nfp_net_common.c b

[PATCH 0/3] Correct RSS algorithm related logic

2025-04-07 Thread Chaoyong He
This patch series try to correct the RSS algorithm related logic. Chaoyong He (3): net/nfp: support get RSS algorithm capability net/nfp: support get RSS algorithm configuration net/nfp: correct RSS algorithm configuration logic drivers/common/nfp/nfp_common.h | 1

[PATCH] net/nfp: fix the hash key length logic problem

2025-04-04 Thread Chaoyong He
API, read from this address will get wrong hash key length and write to this address will overwrite the MAC address unexpected, which will cause very strange problem. Fixes: 934e4c60fbff ("nfp: add RSS") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang

[PATCH] net/nfp: fix one coredump caused by RSS hash key

2025-04-01 Thread Chaoyong He
34e4c60fbff ("nfp: add RSS") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_common.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp

[PATCH] app/testpmd: fix hash key update problem

2025-04-01 Thread Chaoyong He
unctions: ipv4 ipv6 RSS key: 6D5A56DA255B0EC24167253D43A38FB0D0CA2BCBAE7B30B477CB2DA38030F20C6A42B7 3BBEAC01FA testpmd> -- Fixes: 8205e241b2b0 ("app/testpmd: add missing type to RSS hash commands") Cc: nelio.laranje...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang

[PATCH] net/nfp: add PF ID to the firmware load command

2025-03-06 Thread Chaoyong He
the PF ID to the BSP for firmware load command. Fixes: 74fd1a71cec1 ("net/nfp: support loading firmware for card without DDR") Cc: chaoyong...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Zerun Fu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- dri

[PATCH] net/nfp: fix two bugs of error process logic

2025-02-25 Thread Chaoyong He
Fix two bugs of error process logic. Fixes: 19bd7cce5705 ("net/nfp: support different configuration BAR size") Fixes: 636e133ec891 ("net/nfp: update Tx and Rx for multiple PF") Cc: peng.zh...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Peng Zha

[PATCH] net/nfp: fix get represetor wrong port stats

2025-02-24 Thread Chaoyong He
From: Long Wu The 'ipackets'/'opackets' are used to record the number of packets on represetor port received/sent. But the code does not consider concurrent calculation of 'ipackets'/'opackets'. If multiple queues are calculated 'ipackets'/'opackets' simultaneously, it will result in incorrect re

RE: [PATCH 22/32] net/nfp: replace memcpy with assignment

2025-02-09 Thread Chaoyong He
Thanks. Acked-by: Chaoyong He > -Original Message- > From: Stephen Hemminger > Sent: Sunday, February 9, 2025 4:22 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Chaoyong He > > Subject: [PATCH 22/32] net/nfp: replace memcpy with assignment > > Prefe

RE: [RFC 07/10] net/nfp: remove weak symbols

2025-02-07 Thread Chaoyong He
Seems ok for me. Acked-by: Chaoyong He > -Original Message- > From: David Marchand > Sent: Friday, February 7, 2025 4:33 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; bruce.richard...@intel.com; > andre...@linux.microsoft.com; Chaoyong He > Subject: [RFC 07/10]

[PATCH 2/2] net/nfp: support load firmware for card without DDR

2025-01-21 Thread Chaoyong He
The original logic don't support load firmware for cards which has no DDR, add the related logic to make it can load firmware successfully. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfpcore/nfp_nsp.c | 131

[PATCH 0/2] modify logic of load firmware from flash

2025-01-21 Thread Chaoyong He
This patch series aims to support load firmware for card without DDR chip. Chaoyong He (2): net/nfp: fix logic of load firmware from flash net/nfp: support load firmware for card without DDR drivers/net/nfp/nfp_ethdev.c | 30 +++ drivers/net/nfp/nfpcore/nfp_nsp.c | 131

[PATCH 1/2] net/nfp: fix logic of load firmware from flash

2025-01-21 Thread Chaoyong He
ic. Fixes: 08ea495d624b ("net/nfp: support loading firmware from flash") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff

[PATCH] net/nfp: set the correct control flag

2025-01-21 Thread Chaoyong He
ta...@dpdk.org Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index f54483822f..b98eee6b90 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/dri

[PATCH] net/nfp: fix misuse of function return values

2025-01-21 Thread Chaoyong He
ll cause an error because 'true' will be regard as no problem. Fixes: b4ae16eae01c ("net/nfp: support to add and delete flows to firmware") Cc: chaoyong...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Zerun Fu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by:

[PATCH] net/nfp: fix multiple PFs check from NSP

2025-01-21 Thread Chaoyong He
From: Zerun Fu Fix multiple PFs check from NSP problem in the logic of PF initialization. Fixes: 8ad2cc8fec37 ("net/nfp: add flag for multiple PFs support") Cc: peng.zh...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Zerun Fu Reviewed-by: Chaoyong He Reviewed-by: Long Wu R

[PATCH v3] net/bonding: fix dedicated queue setup failed

2024-12-25 Thread Chaoyong He
initialize dedicated hardware Rx/Tx queue. If obtaining the minimum queue size failed, use the default queue size. Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control") Cc: tomaszx.kula...@intel.com Cc: sta...@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong H

RE: [PATCH v2 2/2] net/bonding: add command to set dedicated queue size

2024-12-18 Thread Chaoyong He
> > On Wed, 4 Dec 2024 06:21:00 +0000 > > Chaoyong He wrote: > > > > > > The definition of what a "dedicated queue" is a bit confusing. > > > > If it is only for LACP packets, it should never need to be very big. > > > > O

[PATCH v2] net/nfp: implement the burst mode get operation

2024-12-18 Thread Chaoyong He
Implement the burst mode get operation functions for both Rx and Tx. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- v2: * Replace 'snprintf()' with 'strlcpy()'. --- drivers/net/nfp/nfp_ethdev.c| 2 ++ drivers/net/nfp/nfp_ethdev_vf.c | 2 ++ drivers/net/nfp/

RE: [PATCH] net/nfp: implement the burst mode get operation

2024-12-18 Thread Chaoyong He
> On Wed, 18 Dec 2024 14:30:36 +0800 > Chaoyong He wrote: > > > +int > > +nfp_net_rx_burst_mode_get(struct rte_eth_dev *eth_dev, > > + uint16_t queue_id __rte_unused, > > + struct rte_eth_burst_mode *mode) > > +{ > > + eth_

[PATCH] net/nfp: fix VF link speed problem

2024-12-17 Thread Chaoyong He
are. Fix these problems by modify the related logic, also add needed helper function at the same time. Fixes: eae7dadbe987 ("net/nfp: update link status reporting") Cc: sta...@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- drivers/net/nfp/flower/nf

[PATCH] net/nfp: implement the burst mode get operation

2024-12-17 Thread Chaoyong He
Implement the burst mode get operation functions for both Rx and Tx. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c| 2 ++ drivers/net/nfp/nfp_ethdev_vf.c | 2 ++ drivers/net/nfp/nfp_rxtx.c | 46 + drivers/net/nfp

[PATCH] net/nfp: unify the queue threshold value

2024-12-17 Thread Chaoyong He
Make sure the Rx queue threshold value query by API 'rte_eth_rx_queue_info_get()' and 'rte_eth_dev_info_get()' unify. Same for the Tx queue threshold value. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_rxtx.c | 2 ++ 1 file changed, 2 inserti

RE: [PATCH v2 2/2] net/bonding: add command to set dedicated queue size

2024-12-04 Thread Chaoyong He
> On Wed, 4 Dec 2024 06:21:00 + > Chaoyong He wrote: > > > > The definition of what a "dedicated queue" is a bit confusing. > > > If it is only for LACP packets, it should never need to be very big. > > > Only under a mis-configuration and DoS

RE: [PATCH 2/6] drivers/common: eliminate dependency on non-portable __SIZEOF_LONG__

2024-12-04 Thread Chaoyong He
lt;< (n)) - 1) > > -#define BITS_PER_LONG (__SIZEOF_LONG__ * 8) > -#define BITS_PER_LONG_LONG (__SIZEOF_LONG_LONG__ * 8) > +#define BITS_PER_LONG (sizeof(long) * 8) > +#define BITS_PER_LONG_LONG (sizeof(long long) * 8) This looks good to me, thanks. Acked-by: Chaoyong He > > #define GENMASK(h, l) \ > ((~0UL << (l)) & (~0UL >> (BITS_PER_LONG - (h) - 1))) > -- > 2.47.0.vfs.0.3

RE: [PATCH v2 2/2] net/bonding: add command to set dedicated queue size

2024-12-03 Thread Chaoyong He
> On Fri, 11 Oct 2024 11:24:12 +0800 > Chaoyong He wrote: > > > From: Long Wu > > > > The testpmd application can not modify the value of dedicated hardware > > Rx/Tx queue size, and hardcoded them as (128/512). This will cause the > > bonding port sta

[PATCH v4 3/4] net/nfp: add support for EEPROM functions

2024-11-03 Thread Chaoyong He
ule EEPROM for a specific port. Signed-off-by: James Hershaw Signed-off-by: Chaoyong He --- doc/guides/nics/features/nfp.ini | 2 + .../net/nfp/flower/nfp_flower_representor.c | 76 ++ drivers/net/nfp/nfp_ethdev.c | 5 + drivers/net/nfp/nfp_ne

[PATCH v4 4/4] net/nfp: add LED support

2024-11-03 Thread Chaoyong He
Implement the necessary functions to allow user to visually identify a physical port associated with a netdev by blinking an LED on that port. Signed-off-by: James Hershaw Signed-off-by: Chaoyong He --- doc/guides/nics/features/nfp.ini | 1 + .../net/nfp/flower

[PATCH v4 2/4] net/nfp: extract function to check physical reprsentor

2024-11-03 Thread Chaoyong He
Extract a helper function to check the physical representor port. Signed-off-by: Chaoyong He --- .../net/nfp/flower/nfp_flower_representor.c| 18 -- .../net/nfp/flower/nfp_flower_representor.h| 1 + 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH v4 1/4] net/nfp: fix port index problem

2024-11-03 Thread Chaoyong He
("net/nfp: extract function to allocate VF") Cc: peng.zh...@corigine.com Signed-off-by: Chaoyong He --- drivers/net/nfp/flower/nfp_flower_representor.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/n

[PATCH v4 0/4] NFP PMD enhancement

2024-11-03 Thread Chaoyong He
This patch series fix one problem imported by mistake and add support of two new APIs. --- v4: * Also update the 'nfp.ini' file. v3: * Adapt to the multiple PF firmware. v2: * Add one missing commit. --- Chaoyong He (4): net/nfp: fix port index problem net/nfp: extract functio

[PATCH v3 4/4] net/nfp: add support for port identify

2024-10-31 Thread Chaoyong He
Implement the necessary functions to allow user to visually identify a physical port associated with a netdev by blinking an LED on that port. Signed-off-by: James Hershaw Signed-off-by: Chaoyong He --- .../net/nfp/flower/nfp_flower_representor.c | 30 drivers/net/nfp

[PATCH v3 3/4] net/nfp: add support for EEPROM functions

2024-10-31 Thread Chaoyong He
ule EEPROM for a specific port. Signed-off-by: James Hershaw Signed-off-by: Chaoyong He --- .../net/nfp/flower/nfp_flower_representor.c | 76 ++ drivers/net/nfp/nfp_ethdev.c | 5 + drivers/net/nfp/nfp_net_common.c | 256 ++ drive

[PATCH v3 2/4] net/nfp: extract function to check physical reprsentor

2024-10-31 Thread Chaoyong He
Extract a helper function to check the physical representor port. Signed-off-by: Chaoyong He --- .../net/nfp/flower/nfp_flower_representor.c| 18 -- .../net/nfp/flower/nfp_flower_representor.h| 1 + 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH v3 1/4] net/nfp: fix port index problem

2024-10-31 Thread Chaoyong He
("net/nfp: extract function to allocate VF") Cc: peng.zh...@corigine.com Signed-off-by: Chaoyong He --- drivers/net/nfp/flower/nfp_flower_representor.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/n

[PATCH v3 0/4] NFP PMD enhancement

2024-10-31 Thread Chaoyong He
This patch series fix one problem imported by mistake and add support of two new APIs. --- v3: * Adapt to the multiple PF firmware. v2: * add one missing commit. --- Chaoyong He (4): net/nfp: fix port index problem net/nfp: extract function to check physical reprsentor net/nfp: add support

[PATCH 3/4] net/nfp: add support for EEPROM functions

2024-10-30 Thread Chaoyong He
ule EEPROM for a specific port. Signed-off-by: James Hershaw Signed-off-by: Chaoyong He --- .../net/nfp/flower/nfp_flower_representor.c | 76 ++ drivers/net/nfp/nfp_ethdev.c | 5 + drivers/net/nfp/nfp_net_common.c | 256 ++ drive

[PATCH 4/4] net/nfp: add support for port identify

2024-10-30 Thread Chaoyong He
Implement the necessary functions to allow user to visually identify a physical port associated with a netdev by blinking an LED on that port. Signed-off-by: James Hershaw Signed-off-by: Chaoyong He --- .../net/nfp/flower/nfp_flower_representor.c | 30 drivers/net/nfp

[PATCH 1/4] net/nfp: fix port index problem

2024-10-30 Thread Chaoyong He
("net/nfp: extract function to allocate VF") Cc: peng.zh...@corigine.com Signed-off-by: Chaoyong He --- drivers/net/nfp/flower/nfp_flower_representor.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/n

[PATCH 2/4] net/nfp: extract function to check physical reprsentor

2024-10-30 Thread Chaoyong He
Extract a helper function to check the physical representor port. Signed-off-by: Chaoyong He --- .../net/nfp/flower/nfp_flower_representor.c| 18 -- .../net/nfp/flower/nfp_flower_representor.h| 1 + 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 0/4] NFP PMD enhancement

2024-10-30 Thread Chaoyong He
This patch series fix one problem imported by mistake and add support of two new APIs. --- v2: * add one missing commit. --- Chaoyong He (4): net/nfp: fix port index problem net/nfp: extract function to check physical reprsentor net/nfp: add support for EEPROM functions net/nfp: add

[PATCH 3/3] net/nfp: add support for port identify

2024-10-30 Thread Chaoyong He
Implement the necessary functions to allow user to visually identify a physical port associated with a netdev by blinking an LED on that port. Signed-off-by: James Hershaw Signed-off-by: Chaoyong He --- .../net/nfp/flower/nfp_flower_representor.c | 30 drivers/net/nfp

[PATCH 2/3] net/nfp: add support for EEPROM functions

2024-10-30 Thread Chaoyong He
ule EEPROM for a specific port. Signed-off-by: James Hershaw Signed-off-by: Chaoyong He --- .../net/nfp/flower/nfp_flower_representor.c | 76 ++ drivers/net/nfp/nfp_ethdev.c | 5 + drivers/net/nfp/nfp_net_common.c | 256 ++ drive

[PATCH 1/3] net/nfp: extract function to check physical reprsentor

2024-10-30 Thread Chaoyong He
Extract a helper function to check the physical representor port. Signed-off-by: Chaoyong He --- .../net/nfp/flower/nfp_flower_representor.c| 18 -- .../net/nfp/flower/nfp_flower_representor.h| 1 + 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 0/3] NFP PMD enhancement

2024-10-30 Thread Chaoyong He
This patch series fix one problem imported by mistake and add support of two new APIs. Chaoyong He (3): net/nfp: extract function to check physical reprsentor net/nfp: add support for EEPROM functions net/nfp: add support for port identify .../net/nfp/flower/nfp_flower_representor.c

[PATCH 9/9] net/nfp: update the Tx and Rx function for multiple PF

2024-10-20 Thread Chaoyong He
From: Peng Zhang Update the Tx function and Rx function for multiple PF and simplify the Rx function to enhance the performance. In the RX function, the packets are processed according the firmware type. Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He Reviewed-by: Long Wu --- drivers/net

[PATCH 8/9] net/nfp: add the new operations for multiple PF

2024-10-20 Thread Chaoyong He
From: Peng Zhang When using the multiple PF firmware, add the new operations and update the port start and stop function. Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He Reviewed-by: Long Wu --- drivers/net/nfp/flower/nfp_flower.c | 21 drivers/net/nfp/flower

[PATCH 7/9] net/nfp: ignore useless message for multiple PF

2024-10-20 Thread Chaoyong He
From: Peng Zhang When using the multiple PF firmware, there is no PF representor port, so we also need not care about the corresponding control messages anymore. Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He Reviewed-by: Long Wu --- drivers/net/nfp/flower/nfp_flower_ctrl.c | 10

[PATCH 6/9] net/nfp: initialize the representor port of the multiple PF

2024-10-20 Thread Chaoyong He
From: Peng Zhang When using multiple PF firmware, add the process of initialize the representor port and revise the corresponding logic in the close function. Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He Reviewed-by: Long Wu --- .../net/nfp/flower/nfp_flower_representor.c | 80

[PATCH 5/9] net/nfp: revise the number of PF representor port

2024-10-20 Thread Chaoyong He
From: Peng Zhang When using the multiple PF firmware, there is no need to create the PF representor port anymore. Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He Reviewed-by: Long Wu --- drivers/net/nfp/flower/nfp_flower_representor.c | 12 +--- 1 file changed, 9 insertions(+), 3

[PATCH 4/9] net/nfp: extract the function to allocate the VF

2024-10-20 Thread Chaoyong He
From: Peng Zhang Extract the helper function to allocate the VF representor ports. Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He Reviewed-by: Long Wu --- .../net/nfp/flower/nfp_flower_representor.c | 85 +++ 1 file changed, 49 insertions(+), 36 deletions(-) diff

[PATCH 2/9] net/nfp: extract the function to initialize the PF

2024-10-20 Thread Chaoyong He
From: Peng Zhang Extract the helper function to initialize the basic information of the PF representor port. The logic of check VF is updated because of changing the order of some logics in the initialization function. Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He Reviewed-by: Long Wu

[PATCH 3/9] net/nfp: extract the function to allocate PF

2024-10-20 Thread Chaoyong He
From: Peng Zhang Extract the helper function to allocate the PF representor port. Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He Reviewed-by: Long Wu --- .../net/nfp/flower/nfp_flower_representor.c | 58 --- 1 file changed, 38 insertions(+), 20 deletions(-) diff --git

[PATCH 1/9] net/nfp: extract the function to allocate the PHY

2024-10-20 Thread Chaoyong He
From: Peng Zhang Extract the helper function to allocate the PHY representor port. Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He Reviewed-by: Long Wu --- .../net/nfp/flower/nfp_flower_representor.c | 86 --- 1 file changed, 53 insertions(+), 33 deletions(-) diff

[PATCH 0/9] support multiple PF flower firmware

2024-10-20 Thread Chaoyong He
This patch series add support of the multiple PF flower firmware. Peng Zhang (9): net/nfp: extract the function to allocate the PHY net/nfp: extract the function to initialize the PF net/nfp: extract the function to allocate PF net/nfp: extract the function to allocate the VF net/nfp: re

RE: [PATCH v2] net/bonding: add user callback for bond xmit policy

2024-10-20 Thread Chaoyong He
> From: Vignesh PS > > Add support to bonding PMD to allow user callback function registration for > TX transmit policy. > > Signed-off-by: Vignesh PS > --- > .mailmap| 1 + > drivers/net/bonding/eth_bond_private.h | 6 ++ > drivers/net/bonding/rte_eth_bo

RE: [PATCH v2] examples/l3fwd: support setting the data size of mbuf

2024-10-20 Thread Chaoyong He
> On Fri, 18 Oct 2024 05:50:20 + > Chaoyong He wrote: > > > > On Fri, 18 Oct 2024 03:21:28 +0000 > > > Chaoyong He wrote: > > > > > > > > RTE_PKTMBUF_HEADROOM); } > > > > > > + > > > > > > > > >

RE: [PATCH v2] examples/l3fwd: support setting the data size of mbuf

2024-10-17 Thread Chaoyong He
> On Fri, 18 Oct 2024 03:21:28 + > Chaoyong He wrote: > > > > RTE_PKTMBUF_HEADROOM); } > > > > + > > > > > > Not sure why this is needed? What is the problem with the original code? > > > Are you trying to force packets to be segment

RE: [PATCH v2] examples/l3fwd: support setting the data size of mbuf

2024-10-17 Thread Chaoyong He
> On Fri, 18 Oct 2024 10:42:53 +0800 > Chaoyong He wrote: > > > From: Long Wu > > > > The previous code used a macro as the data size for mbuf to create the > > mempool and users cannot modify the size. > > > > Now modify the code to support sett

[PATCH v2] examples/l3fwd: support setting the data size of mbuf

2024-10-17 Thread Chaoyong He
lt size is still 'RTE_MBUF_DEFAULT_BUF_SIZE'. Examples: dpdk-l3fwd -l 0-3 -- -p 0x03 --mbuf-size=4096 Signed-off-by: Long Wu Reviewed-by: Chaoyong He Acked-by: Morten Brørup --- v2: * Modify some logic following the advices of reviewer. * Add the 'Acked-by' tag.

[PATCH] net/nfp: fix return value check problem

2024-10-17 Thread Chaoyong He
Fix one return value check problem found by the CI. Coverity issue: 445519 Fixes: 08ea495d624b ("net/nfp: support loading firmware from flash") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c | 8 +++- 1 file changed, 7

[PATCH 6/6] net/nfp: correct of misspellings

2024-10-16 Thread Chaoyong He
From: Zerun Fu Correction of misspellings in logs. Signed-off-by: Zerun Fu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 4 ++-- drivers/net/nfp/flower/nfp_flower_representor.c | 6 +++--- 2 files changed, 5

[PATCH 4/6] net/nfp: reformat the abbreviations of logs

2024-10-16 Thread Chaoyong He
From: Zerun Fu Unified do not apply abbreviations in log. Signed-off-by: Zerun Fu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 2 +- drivers/net/nfp/flower/nfp_flower_flow.c | 8 drivers/net/nfp/nfp_ethdev.c

[PATCH 3/6] net/nfp: reformat the header of logs

2024-10-16 Thread Chaoyong He
From: Zerun Fu Capitalize the first letter of each sentence in the log. Signed-off-by: Zerun Fu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common.c | 4 +- drivers/common/nfp/nfp_common_pci.c | 2 +- drivers

[PATCH 2/6] net/nfp: modify the level of speed update log

2024-10-16 Thread Chaoyong He
From: Zerun Fu Here the invoke of `nfp_eth_read_ports()` may fail, but it's acceptable because it will recover soon once the link status changed. So modify the level of the log to avoid confusing users. Signed-off-by: Zerun Fu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by:

[PATCH 0/6] Adjust format and level of log

2024-10-16 Thread Chaoyong He
This patches unify the format of log, also adjust some log level. Zerun Fu (6): net/nfp: modify the level of some logs net/nfp: modify the level of speed update log net/nfp: reformat the header of logs net/nfp: reformat the abbreviations of logs net/nfp: reformat the period of logs net

[PATCH 1/6] net/nfp: modify the level of some logs

2024-10-16 Thread Chaoyong He
ned-off-by: Zerun Fu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_common.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c index f76d5a6895..de7140d

[PATCH] examples/l3fwd: support setting the data size of mbuf

2024-10-16 Thread Chaoyong He
lt size is still 'RTE_MBUF_DEFAULT_BUF_SIZE'. Examples: dpdk-l3fwd -l 0-3 -- -p 0x03 --mbuf-size=4096 Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- examples/l3fwd/main.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/examples/l3fwd/mai

[PATCH] net/nfp: fix RSS failed on VXLAN inner layer

2024-10-16 Thread Chaoyong He
nd add the logic of disable NFP_NET_CFG_CTRL_VXLAN into the 'udp_tunnel_port_del()', thus the whole solution more complete and easier to understand. Fixes: 5126a904fae0 ("net/nfp: use offload flag to control VXLAN configuration") Cc: sta...@dpdk.org Signed-off-by: Lo

[PATCH] net/nfp: modify Rx buffer size setting logic

2024-10-16 Thread Chaoyong He
first initialization, only when the Rx queue buffer size is greater than the current hardware set size will it be modified. Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_net_common.h | 1 + drivers/net/nfp/nfp_rxtx.c | 16 +++- 2 files changed, 16

[PATCH 4/4] net/nfp: clear errors status of aer after soft reset

2024-10-13 Thread Chaoyong He
Zhang Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_ethdev.c | 40 ++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index 8cbbadb4de..b16fbe7db7 100644 --- a/drivers/net/nfp/nfp_eth

[PATCH 3/4] net/nfp: add more logs to debug probe process

2024-10-13 Thread Chaoyong He
From: Huaxing Zhu Add more logs to debug probe process, and modify some log level. Also add an new entry to the mailmap file. Signed-off-by: Huaxing Zhu Reviewed-by: Long Wu Reviewed-by: Peng Zhang Reviewed-by: Chaoyong He --- .mailmap | 1 + drivers/net/nfp

[PATCH 2/4] net/nfp: do not set the IPv6 flag in transport mode

2024-10-13 Thread Chaoyong He
y: Long Wu Reviewed-by: Peng Zhang Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_ipsec.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/net/nfp/nfp_ipsec.c index 647bc2bb6d..89116af1b2 100644 --- a/drivers/net/nfp/nfp_ips

[PATCH 0/4] debug enhancement and bug fix

2024-10-13 Thread Chaoyong He
This patch series includes two bug fix commits and two debug enhancement commits. Huaxing Zhu (2): net/nfp: add more logs to debug probe process net/nfp: clear errors status of aer after soft reset Shihong Wang (1): net/nfp: do not set the IPv6 flag in transport mode Zerun Fu (1): net/nf

[PATCH 1/4] net/nfp: notify flower firmware about PF speed

2024-10-13 Thread Chaoyong He
PF speed. Fixes: e1124c4f8a45 ("net/nfp: add flower representor framework") Cc: chaoyong...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Zerun Fu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower_representor.c | 3 +++ d

RE: [PATCH v2 02/10] net/nfp: fix malloc name problem in secondary process

2024-10-11 Thread Chaoyong He
> On Sat, 12 Oct 2024 10:40:59 +0800 > Chaoyong He wrote: > > > The original logic keeps using the same name parameter when malloc > > memory in secondary process, which may cause error when using multiple > > PF cards. > > > > Fixes: 3b00109d2b65 (&qu

[PATCH v2 10/10] net/nfp: fix memory leak in VF initialization logic

2024-10-11 Thread Chaoyong He
Fix one memory leak problem in the logic of VF initialization. Fixes: d81e2b514dc9 ("net/nfp: move device info into process private data") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang Acked-by: Stephen Hemminger --- drive

[PATCH v2 09/10] net/nfp: modify the comment of some control messages

2024-10-11 Thread Chaoyong He
The comment of some control messages are not right, which conflict with the data structure and may confuse the other developers. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Acked-by: Stephen Hemminger --- drivers/net/nfp/flower/nfp_flower_cmsg.h | 14 +++--- 1 file changed, 7

[PATCH v2 08/10] net/nfp: fix problem caused by FEC set

2024-10-11 Thread Chaoyong He
The return value of 'nfp_eth_set_fec()' is three ways, the original logic considered it as two ways wrongly. Fixes: 37bd1b843a20 ("net/nfp: support setting FEC mode") Cc: zerun...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by:

[PATCH v2 07/10] net/nfp: fix problem caused by commit end function

2024-10-11 Thread Chaoyong He
The return value of 'nfp_eth_config_commit_end()' is three ways, the original logic considered it as two ways wrongly. Fixes: 68aa35373a94 ("net/nfp: support setting pause frame switch mode") Cc: zerun...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-b

[PATCH v2 05/10] net/nfp: fix problem caused by configure function

2024-10-11 Thread Chaoyong He
The return value of 'nfp_eth_set_configured()' is three ways, the original logic considered it as two ways wrongly. Fixes: 61d4008fe6bb ("net/nfp: support setting link up/down") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhan

[PATCH v2 06/10] net/nfp: add check logic for port up/down function

2024-10-11 Thread Chaoyong He
The 'nfp_eth_set_configured()' function is not always success, so need to check the return value of it. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang Acked-by: Stephen Hemminger --- .../net/nfp/flower/nfp_flower_representor.c| 18 +- d

[PATCH v2 04/10] net/nfp: improve the logic readability

2024-10-11 Thread Chaoyong He
Try our best to make the logic in secondary proess the same with the primary process and improve the readability, by add helper functions and rename function. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c | 86

[PATCH v2 03/10] net/nfp: simplify some function parameters

2024-10-11 Thread Chaoyong He
Refactor to the logic of initialize process to simplify some function parameters, both for primary and secodary process. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang Acked-by: Stephen Hemminger --- drivers/net/nfp/nfp_ethdev.c | 153

[PATCH v2 02/10] net/nfp: fix malloc name problem in secondary process

2024-10-11 Thread Chaoyong He
The original logic keeps using the same name parameter when malloc memory in secondary process, which may cause error when using multiple PF cards. Fixes: 3b00109d2b65 ("net/nfp: add PF ID used to format symbols") Cc: peng.zh...@corigine.com Cc: sta...@dpdk.org Signed-off-by: C

[PATCH v2 01/10] net/nfp: use strlcpy for copying string

2024-10-11 Thread Chaoyong He
Replace 'snprintf()' with 'strlcpy()' where applicable. Using 'strlcpy()' is safe practice when copying strings, as it will include a null terminator. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang Acked-by: Stephen Hemminge

  1   2   3   4   5   6   7   8   9   10   >