The return value of 'nfp_eth_set_fec()' is three ways, the original
logic considered it as two ways wrongly.
Fixes: 37bd1b843a20 ("net/nfp: support setting FEC mode")
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Chaoyong He <[email protected]>
Reviewed-by: Long Wu <[email protected]>
Reviewed-by: Peng Zhang <[email protected]>
Acked-by: Stephen Hemminger <[email protected]>
---
drivers/net/nfp/nfp_net_common.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c
index 5c3a9a7ae7..b986ed4622 100644
--- a/drivers/net/nfp/nfp_net_common.c
+++ b/drivers/net/nfp/nfp_net_common.c
@@ -2692,6 +2692,7 @@ int
nfp_net_fec_set(struct rte_eth_dev *dev,
uint32_t fec_capa)
{
+ int ret;
uint8_t idx;
enum nfp_eth_fec fec;
uint32_t supported_fec;
@@ -2724,7 +2725,13 @@ nfp_net_fec_set(struct rte_eth_dev *dev,
return -EIO;
}
- return nfp_eth_set_fec(hw_priv->pf_dev->cpp, eth_port->index, fec);
+ ret = nfp_eth_set_fec(hw_priv->pf_dev->cpp, eth_port->index, fec);
+ if (ret < 0) {
+ PMD_DRV_LOG(ERR, "NFP set FEC mode failed.");
+ return ret;
+ }
+
+ return 0;
}
uint32_t
--
2.39.1
