[PATCH v2 01/10] net/nfp: use strlcpy for copying string

[Chaoyong He]

Replace 'snprintf()' with 'strlcpy()' where applicable.
Using 'strlcpy()' is safe practice when copying strings, as it
will include a null terminator.

Signed-off-by: Chaoyong He <chaoyong...@corigine.com>
Reviewed-by: Long Wu <long...@corigine.com>
Reviewed-by: Peng Zhang <peng.zh...@corigine.com>
Acked-by: Stephen Hemminger <step...@networkplumber.org>
---
 drivers/net/nfp/flower/nfp_flower_representor.c | 4 ++--
 drivers/net/nfp/nfp_net_common.c                | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c 
b/drivers/net/nfp/flower/nfp_flower_representor.c
index 5db7d50618..d1558b905c 100644
--- a/drivers/net/nfp/flower/nfp_flower_representor.c
+++ b/drivers/net/nfp/flower/nfp_flower_representor.c
@@ -576,7 +576,7 @@ nfp_flower_pf_repr_init(struct rte_eth_dev *eth_dev,
        repr->repr_type        = init_repr_data->repr_type;
        repr->app_fw_flower    = init_repr_data->app_fw_flower;
 
-       snprintf(repr->name, sizeof(repr->name), "%s", init_repr_data->name);
+       strlcpy(repr->name, init_repr_data->name, sizeof(repr->name));
 
        eth_dev->dev_ops = &nfp_flower_pf_repr_dev_ops;
        eth_dev->rx_pkt_burst = nfp_net_recv_pkts;
@@ -652,7 +652,7 @@ nfp_flower_repr_init(struct rte_eth_dev *eth_dev,
        repr->repr_type        = init_repr_data->repr_type;
        repr->app_fw_flower    = init_repr_data->app_fw_flower;
 
-       snprintf(repr->name, sizeof(repr->name), "%s", init_repr_data->name);
+       strlcpy(repr->name, init_repr_data->name, sizeof(repr->name));
 
        eth_dev->dev_ops = &nfp_flower_repr_dev_ops;
        eth_dev->rx_pkt_burst = nfp_flower_repr_rx_burst;
diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c
index 4a2c536704..c9a95ed632 100644
--- a/drivers/net/nfp/nfp_net_common.c
+++ b/drivers/net/nfp/nfp_net_common.c
@@ -2306,7 +2306,7 @@ nfp_net_get_mip_name(struct nfp_net_hw_priv *hw_priv,
        if (mip == NULL)
                return;
 
-       snprintf(mip_name, FW_VER_LEN, "%s", nfp_mip_name(mip));
+       strlcpy(mip_name, nfp_mip_name(mip), FW_VER_LEN);
 
        nfp_mip_close(mip);
 }
@@ -2317,13 +2317,13 @@ nfp_net_get_app_name(struct nfp_net_hw_priv *hw_priv,
 {
        switch (hw_priv->pf_dev->app_fw_id) {
        case NFP_APP_FW_CORE_NIC:
-               snprintf(app_name, FW_VER_LEN, "%s", "nic");
+               strlcpy(app_name, "nic", FW_VER_LEN);
                break;
        case NFP_APP_FW_FLOWER_NIC:
-               snprintf(app_name, FW_VER_LEN, "%s", "flower");
+               strlcpy(app_name, "flower", FW_VER_LEN);
                break;
        default:
-               snprintf(app_name, FW_VER_LEN, "%s", "unknown");
+               strlcpy(app_name, "unknown", FW_VER_LEN);
                break;
        }
 }
-- 
2.39.1