RE: [PATCH] net/mlx5: fix VLAN stripping on hairpin queues

2025-05-27 Thread Bing Zhao
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Saturday, April 26, 2025 3:49 AM > To: Slava Ovsiienko ; Bing Zhao > ; Ori Kam ; Suanming Mou > ; Matan Azrad > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix VLAN stripping on hairpi

[PATCH] examples/ntb: fix the heap allocation check

2025-05-21 Thread Bing Zhao
this. Adding the NULL pointer check will help to get rid of such warning. Fixes: 5194299d6ef5 ("examples/ntb: support more functions") Cc: xiaoyun...@intel.com Signed-off-by: Bing Zhao --- examples/ntb/ntb_fwd.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/ex

RE: [PATCH] net/mlx5/hws: fix send queue drain on FW WQE destroy

2025-05-05 Thread Bing Zhao
Hi, > -Original Message- > From: Maayan Kashani > Sent: Sunday, April 27, 2025 7:28 PM > To: dev@dpdk.org > Cc: Maayan Kashani ; Dariusz Sosnowski > ; Raslan Darawsheh ; > sta...@dpdk.org; Alex Vesker ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou

RE: [External] Re: [PATCH 2/2] net/mlx5: improve log file path

2025-03-17 Thread Bing Zhao
Hi Ming & Stephen, > -Original Message- > From: Yang Ming > Sent: Wednesday, March 12, 2025 10:33 AM > To: Stephen Hemminger ; Bing Zhao > > Cc: Dariusz Sosnowski ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Matan Azrad ; dev@dpdk.org > Subject: Re:

RE: [PATCH 2/2] net/mlx5: improve log file path

2025-03-03 Thread Bing Zhao
Hi Ming, > -Original Message- > From: Yang Ming > Sent: Friday, December 13, 2024 5:25 PM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > > Cc: dev@dpdk.org; Yang Ming > Subject: [PATCH 2/2] net/

RE: [PATCH v2 1/3] net/mlx5/hws: support jump FDB Rx

2025-02-26 Thread Bing Zhao
> -Original Message- > From: Suanming Mou > Sent: Wednesday, February 26, 2025 10:01 PM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Matan Azrad > Cc: dev@dpdk.org; Raslan Darawsheh ; Alex Vesker > > Subject: [PATCH v2 1/3] net/ml

RE: [PATCH v3 0/3] net/mlx5: support jump FDB Rx

2025-02-26 Thread Bing Zhao
Thanks a lot, Dariusz. > -Original Message- > From: Dariusz Sosnowski > Sent: Thursday, February 27, 2025 12:04 AM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subje

RE: [PATCH 3/3] net/mlx5: allow FDB RSS

2025-02-26 Thread Bing Zhao
Hi > -Original Message- > From: Suanming Mou > Sent: Wednesday, February 26, 2025 9:43 PM > To: Bing Zhao ; Dariusz Sosnowski > ; Slava Ovsiienko ; Ori Kam > ; Matan Azrad > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: RE: [PATCH 3/3]

RE: [PATCH 3/3] net/mlx5: allow FDB RSS

2025-02-26 Thread Bing Zhao
> -Original Message- > From: Suanming Mou > Sent: Tuesday, February 25, 2025 8:45 AM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Matan Azrad > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 3/3] net/mlx5: allow FDB RSS >

RE: [PATCH 2/3] net/mlx5: add jump FDB Rx flag

2025-02-26 Thread Bing Zhao
Hi > -Original Message- > From: Suanming Mou > Sent: Tuesday, February 25, 2025 8:45 AM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Matan Azrad > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 2/3] net/mlx5: add jump FDB Rx flag

RE: [PATCH 1/3] net/mlx5/hws: support jump FDB Rx

2025-02-26 Thread Bing Zhao
Hi Suanming, PSB > -Original Message- > From: Suanming Mou > Sent: Tuesday, February 25, 2025 8:45 AM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Matan Azrad > Cc: dev@dpdk.org; Raslan Darawsheh ; Alex Vesker > > Subject: [PATCH

[PATCH v3] net/mlx5: add eCPRI support

2025-02-25 Thread Bing Zhao
Support eCPRI item matching over L2 (ETHER / VLAN) in HWS, both for template API and backward compatibility API. Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski --- v2: fix the checkpatch warning of unneeded else v3: fix single line if condition code style warning --- drivers/net/mlx5/hws

[PATCH v2] net/mlx5: add eCPRI support

2025-02-25 Thread Bing Zhao
Support eCPRI item matching over L2 (ETHER / VLAN) in HWS, both for template API and backward compatibility API. Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski --- v2: fix the checkpatch warning of unneeded else --- drivers/net/mlx5/hws/mlx5dr_definer.c | 86

[PATCH] net/mlx5: add eCPRI support

2025-02-25 Thread Bing Zhao
Support eCPRI item matching over L2 (ETHER / VLAN) in HWS, both for template API and backward compatibility API. Signed-off-by: Bing Zhao --- drivers/net/mlx5/hws/mlx5dr_definer.c | 86 +++ drivers/net/mlx5/mlx5_flow.h | 3 + drivers/net/mlx5/mlx5_flow_hw.c

[PATCH] net/mlx5: fix the unneeded stub table allocation

2024-11-26 Thread Bing Zhao
("net/mlx5: abstract flow action and enable reconfigure") Cc: mkash...@nvidia.com Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow.c| 11 +-- drivers/net/mlx5/mlx5_flow.h| 3 +++ drivers/net/mlx5/mlx5_flow_hw.c | 19 +++ 3 files changed, 23 inserti

[PATCH v2] net/mlx5: fix the leak of action data list

2024-11-26 Thread Bing Zhao
d be freed when the actions construction is done. Fixes: ff4064d5b1fe ("net/mlx5: support bulk actions in non-template flow") Cc: mkash...@nvidia.com Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski --- v2: update the commit log --- drivers/net/mlx5

[PATCH] net/mlx5: fix Rx queue control deref

2024-11-25 Thread Bing Zhao
x5: fix Rx queue control management") Cc: sta...@dpdk.org Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_rx.h | 2 +- drivers/net/mlx5/mlx5_rxq.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rx.

[PATCH] net/mlx5: fix the leak of action data list

2024-11-18 Thread Bing Zhao
d when the actions construction is done. Fixes: ff4064d5b1fe ("net/mlx5: support bulk actions in non-template flow") Cc: mkash...@nvidia.com Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow_hw.c | 63 - 1 file changed, 39 insertions(+), 24 deleti

[PATCH] net/mlx5: fix the default RSS flows creation order

2024-11-13 Thread Bing Zhao
k.org Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow.h| 8 drivers/net/mlx5/mlx5_flow_hw.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h index 693e07218d..7028

[PATCH] net/mlx5: fix Rx queue ref count in flushing user flows

2024-11-12 Thread Bing Zhao
ed. Fixes: 3a2f674b6aa8 ("net/mlx5: add queue and RSS HW steering action") Cc: sta...@dpdk.org Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow.c | 3 +++ drivers/net/mlx5/mlx5_rxq.c | 8 +--- 3 files changed

RE: [PATCH v2] doc: update match with compare result item limitation

2024-11-11 Thread Bing Zhao
Thanks. > -Original Message- > From: Suanming Mou > Sent: Wednesday, November 6, 2024 5:34 PM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Matan Azrad > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v2] doc: update match with compar

RE: [PATCH] doc: update match with compare result item limitation

2024-11-11 Thread Bing Zhao
Suanming Mou > Cc: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Matan Azrad ; dev@dpdk.org; > sta...@dpdk.org > Subject: Re: [PATCH] doc: update match with compare result item limitation > > External email: Use caution opening links or attachments > &g

RE: [PATCH] doc: update match with compare result item limitation

2024-11-04 Thread Bing Zhao
The ` repr_matching_en ` flag is enabled (by default) can be added. > -Original Message- > From: Suanming Mou > Sent: Tuesday, November 5, 2024 9:48 AM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Matan Azrad > Cc: dev@dpdk.org; sta...@dpdk.

[PATCH] net/mlx5: fix the Rx queue control management

2024-11-04 Thread Bing Zhao
issue. Fixes: f957ac996435 ("net/mlx5: workaround list management of Rx queue control") Fixes: bcc220cb57d7 ("net/mlx5: fix shared Rx queue list management") CC: sta...@dpdk.org Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko Acked-by: Dariusz Sosnowski --- dri

RE: [PATCH] net/mlx5: support no host PF configuration

2024-09-27 Thread Bing Zhao
- goto exit; > - } > } else { > /* > * The existence of several matching entries (nd > 1) > means > -- Acked-by: Bing Zhao Thanks > 2.18.1

[PATCH] net/mlx5/hws: fix the valid bit of E-Switch owner

2024-07-29 Thread Bing Zhao
The 'eswitch_owner_vhca_id_valid' only depends on the 'merged_eswitch' capability. And it should be set for all vport actions. Fixes: ac8415cfe760 ("net/mlx5/hws: set E-Switch owner VHC ID valid") Cc: ere...@nvidia.com Signed-off-by: Bing Zhao Reviewed-by: Alex Ves

[PATCH v2] net/mlx5: workaround list management of Rx queue control

2024-07-23 Thread Bing Zhao
uot;, the LIST_REMOVE will be called again and cause some UFA issue. If the memory is no longer mapped, there will be a SIGSEGV. Adding a flag in the Rx queue private structure to remove the "rxq_ctrl" from the list only on the port/queue that allocated it. Fixes: bcc220cb57d7 ("net/m

[PATCH] net/mlx5: workaround list management of Rx queue control

2024-07-23 Thread Bing Zhao
uot;, the LIST_REMOVE will be called again and cause some UFA issue. If the memory is no longer mapped, there will be a SIGSEGV. Adding a flag in the Rx queue private structure to remove the "rxq_ctrl" from the list only on the port/queue that allocated it. Fixes: bcc220cb57d7 ("net/m

[PATCH 4/4] net/mlx5: fix log error on non-template rule destroy

2024-07-23 Thread Bing Zhao
, decap, modify header and matcher resource release under flow destroy cause all uses list/hlist with return value 0/1. Fixes: ff4064d5b1fe ("net/mlx5: support bulk actions in non-template flow") Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski Signed-off-by: Bing Zhao --- d

[PATCH 3/4] net/mlx5: fix matcher mask translation

2024-07-23 Thread Bing Zhao
layers. In the meanwhile, unlike in template API, the group information is also needed for the mask translation. Fixes: 27d171b88031 ("net/mlx5: abstract flow action and enable reconfigure") Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_dv.c | 1

[PATCH 2/4] net/mlx5: fix releasing order of compatible matcher

2024-07-23 Thread Bing Zhao
: b2845d51c748 ("net/mlx5: support FDB in non-template flow") Signed-off-by: Maayan Kashani Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/driver

[PATCH 1/4] net/mlx5/hws: fix state detection of queue full in polling

2024-07-23 Thread Bing Zhao
he polling of associative CQ will continue until a new CQE is generated. Fixes: 87026d2e6601 ("net/mlx5/hws: support backward-compatible API") Signed-off-by: Bing Zhao Reviewed-by: Yevgeny Kliteynik Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/hws/mlx5dr_bwc.c | 4 +++-

[PATCH 0/4] non-template fixes set

2024-07-23 Thread Bing Zhao
A set for cumulative fixes of non-template API support. Bing Zhao (4): net/mlx5/hws: fix state detection of queue full in polling net/mlx5: fix releasing order of compatible matcher net/mlx5: fix matcher mask translation net/mlx5: fix log error on non-template rule destroy drivers/net

RE: [PATCH] common/mlx5: remove unneeded field when modify RQ table

2024-07-17 Thread Bing Zhao
Hi Patrick, It seems to be so. The patch is only for mlx5 slow path configuration. There is no reason that such change will impact the BRCM NIC performance. Thanks. BR. Bing > -Original Message- > From: Patrick Robb > Sent: Thursday, July 18, 2024 4:58 AM > To: Bing Zhao

[PATCH] common/mlx5: remove unneeded field when modify RQ table

2024-07-17 Thread Bing Zhao
fy RQT") Cc: ma...@nvidia.com Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index 8e12ac50de..9710dcedd3 100644

[PATCH] net/mlx5: fix the uplink port probing in bond mode

2024-07-17 Thread Bing Zhao
PLINK will always try to be probed with any format. Fixes: 2e569a370395 ("net/mlx5: add VF LAG mode bonding device recognition") Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_os.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --gi

[PATCH] net/mlx5: fix end condition of reading xstats

2024-07-17 Thread Bing Zhao
ome counters are missed. The "xstats_o_idx" should be used instead of the iteration to check if the statistics is an IB device counter. In the meanwhile, adding another field to record the start index of the IB counters to reduce the redundancy iterations. Fixes: a687c3e658c2 ("net/m

RE: [PATCH 8/8] net/mlx5/hws: fix NA64 copy TOS field instead of TTL

2024-07-09 Thread Bing Zhao
ct-Thomas Monjalon (EXTERNAL) > ; Suanming Mou ; Dariusz > Sosnowski ; Bing Zhao ; Ori Kam > ; Matan Azrad > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 8/8] net/mlx5/hws: fix NA64 copy TOS field instead of TTL > > From: Erez Shitrit > > We don't have enough r

[PATCH v2] net/mlx5: add metadata split for compatibility API

2024-07-04 Thread Bing Zhao
IC Rx rule. Regarding the NIC Tx, only the metadata is relevant and it will be copied in NIC Tx from REG_A into some REG_C_x. The current HWS implementation already has already supported in the default copy rule or the default SQ miss rule in the NIC Tx root table. Signed-off-by: Bing Zhao Ack

RE: [PATCH v3] net/mlx5: fix matcher object memory leak

2024-07-03 Thread Bing Zhao
Hi, > -Original Message- > From: Mahmoud Maatuq > Sent: Wednesday, July 3, 2024 4:15 AM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > ; Maayan Kashani > Cc: dev@dpdk.org; Mahmoud Maatuq > Subject: [PATC

[PATCH] net/mlx5: add non-template flow metadata split

2024-06-13 Thread Bing Zhao
IC Rx rule. Regarding the NIC Tx, only the metadata is relevant and it will be copied in NIC Tx from REG_A into some REG_C_x. The current HWS implementation already has already supported in the default copy rule or the default SQ miss rule in the NIC Tx root table. Signed-off-by: Bing Zhao Ack

[PATCH] net/mlx5: fix mlx5 device start failure

2024-06-13 Thread Bing Zhao
From: Rongwei Liu When devargs "allow_duplicate_pattern=0" is specified, PMD won't allow duplicated flows to be inserted and return EEXIST as rte_errno. The queue/RSS split table is shared globally by all representors and PMD didn't prepend port information into it, so all the following ports tr

[PATCH v2] app/testpmd: fix releasing action handle flush memory

2024-03-25 Thread Bing Zhao
. In the meanwhile, since the action handles are already destroyed, it makes no sense to hold the indirect action software resources anymore. Fixes: f7352c176bbf ("app/testpmd: fix use of indirect action after port close") Cc: dmitry.kozl...@gmail.com Cc: sta...@dpdk.org Signed-off-by:

RE: [PATCH] app/testpmd: fix releasing action handle flush memory

2024-03-25 Thread Bing Zhao
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, March 19, 2024 10:21 PM > To: Bing Zhao ; dmitry.kozl...@gmail.com; > dev@dpdk.org > Cc: aman.deep.si...@intel.com; yuying.zh...@intel.com; Matan Azrad > ; sta...@dpdk.org; Dariusz Sosnowski >

[PATCH] app/testpmd: fix releasing action handle flush memory

2024-03-19 Thread Bing Zhao
closed again. Fixes: f7352c176bbf ("app/testpmd: fix use of indirect action after port close") Cc: dmitry.kozl...@gmail.com Cc: sta...@dpdk.org Signed-off-by: Bing Zhao Reviewed-by: Dariusz Sosnowski --- app/test-pmd/config.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletion

[PATCH] net/mlx5: fix the timing of releasing drop action

2024-03-07 Thread Bing Zhao
. This would cause the counter set resources to be exhausted after starting and stopping the ports repeatedly. Fixes: 65b3cd0dc39b ("net/mlx5: create global drop action") Cc: suanmi...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Bing Zhao Acked-by: Suanming Mou --- drivers/net/mlx5/

[PATCH] net/mlx5: fix age position in hairpin split

2024-03-07 Thread Bing Zhao
t;net/mlx5: use aging by counter when counter exists") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Bing Zhao Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.c| 1 + drivers/net/mlx5/mlx5_flow_dv.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH] net/mlx5: prevent ioctl failure log from flood

2024-03-06 Thread Bing Zhao
From: Eli Britstein The following log is printed in WARNING severity: mlx5_net: port 1 ioctl(SIOCETHTOOL, ETHTOOL_GPAUSEPARAM) failed: Operation not supported Reduce the severity to DEBUG to prevent this log from flooding when there are hundreds of ports probed without supporting this flow

[PATCH] net/mlx5: fix the counters map in bonding mode

2024-02-29 Thread Bing Zhao
d69 ("net/mlx5: improve xstats of bonding port") Cc: xuemi...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 249 +++--- drivers/net/mlx5/mlx5.h | 15

[PATCH v4 5/5] net/mlx5: validate the actions combination with NAT64

2024-02-28 Thread Bing Zhao
application should not try to match these TAGs after the rule that contains NAT64 action. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow.h| 1 + drivers/net/mlx5/mlx5_flow_hw.c | 51 + 2 files changed, 52 insertions(+) diff --git a/drivers/net/mlx5

[PATCH v4 4/5] net/mlx5: add NAT64 action support in rule creation

2024-02-28 Thread Bing Zhao
The action will handle the IPv4 and IPv6 headers translation. It will add / remove IPv6 address prefix by default. To use the user specific address, another rule to modify the addresses of the IP header is needed. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow_hw.c | 20

[PATCH v4 3/5] net/mlx5: create NAT64 actions during configuration

2024-02-28 Thread Bing Zhao
The NAT64 DR actions can be shared among the tables. All these actions can be created during configuring the flow queues and saved for the future usage. Even the actions can be shared now, inside per each flow rule, the actual hardware resources are unique. Signed-off-by: Bing Zhao --- doc

[PATCH v4 2/5] net/mlx5: fetch the available registers for NAT64

2024-02-28 Thread Bing Zhao
-off-by: Bing Zhao --- drivers/net/mlx5/mlx5.c | 9 + drivers/net/mlx5/mlx5.h | 2 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index f2ca0ae4c2..cc7cd6adf5 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -1644,6

[PATCH v4 1/5] net/mlx5/hws: support NAT64 action

2024-02-28 Thread Bing Zhao
From: Erez Shitrit Add support of new action mlx5dr_action_create_nat64. The new action allows to modify IP packets from version to version, IPV6 to IPV4 and vice versa. Signed-off-by: Erez Shitrit Signed-off-by: Bing Zhao --- drivers/net/mlx5/hws/mlx5dr.h| 29 ++ drivers/net/mlx5

[PATCH v4 0/5] NAT64 support in mlx5 PMD

2024-02-28 Thread Bing Zhao
v3: 1. code style and typo. Update in v2: 1. separate from the RTE and testpmd common part. 2. reorder the commits. 3. bug fix, code polishing and document update. Bing Zhao (4): net/mlx5: fetch the available registers for NAT64 net/mlx5: create NAT64 actions during configuration

[PATCH] net/mlx5: fix the HWS registers initialization

2024-02-27 Thread Bing Zhao
flow registers in shared context") Cc: getel...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Bing Zhao Acked-by: Suanming Mou --- drivers/net/mlx5/mlx5.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 881c42a97a..

[PATCH] net/mlx5: fix condition of LACP miss flow

2024-02-20 Thread Bing Zhao
allocation and flow rule creation on the representor port. Fixes: 0f0ae73a3287 ("net/mlx5: add parameter for LACP packets control") Fixes: 49dffadf4b0c ("net/mlx5: fix LACP redirection in Rx domain") Cc: sta...@dpdk.org Signed-off-by: Bing Zhao Acked-by: Suanming Mou -

[PATCH] net/mlx5/hws: set the correct VLAN inner_type value

2024-02-20 Thread Bing Zhao
From: Hamdan Igbaria Set the correct VLAN inner_type value, till today the once the VLAN inner_type field was set, an incorrect value was taken instead of the inner_type field. Fixes: c55c2bf35333 ("net/mlx5/hws: add definer layer") Cc: sta...@dpdk.org Signed-off-by: Hamdan Igbaria Reviewed-by

[PATCH v2] net/mlx5/hws: fix VLAN item handling on non relaxed mode

2024-02-20 Thread Bing Zhao
From: Hamdan Igbaria If a VLAN item was passed with null mask, the item handler would return immediately and thus won't set default values for non relax mode. Also change the non relax default set to single-tagged (CVLAN). Fixes: c55c2bf35333 ("net/mlx5/hws: add definer layer") Cc: sta...@dpdk.o

[PATCH] net/mlx5/hws: fix VLAN item handling on non relaxed mode

2024-02-20 Thread Bing Zhao
From: Hamdan Igbaria If a VLAN item was passed with null mask, the item handler would return immediately and thus won't set default values for non relax mode. Also change the non relax default set to single-tagged (CVLAN). Fixes: c55c2bf35333 ("net/mlx5/hws: add definer layer") Cc: sta...@dpdk.o

[PATCH] net/mlx5: prevent querying aged flows on uninit port

2024-02-20 Thread Bing Zhao
valid pointers would cause a crash. With this commit, the flag of the per port aging initialization will be checked. This would help to get rid of the invalid accessing. Fixes: 04a4de756e14 ("net/mlx5: support flow age action with HWS") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Sign

[PATCH v3 4/5] net/mlx5: add NAT64 action support in rule creation

2024-02-20 Thread Bing Zhao
The action will handle the IPv4 and IPv6 headers translation. It will add / remove IPv6 address prefix by default. To use the user specific address, another rule to modify the addresses of the IP header is needed. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow_hw.c | 20

[PATCH v3 5/5] net/mlx5: validate the actions combination with NAT64

2024-02-20 Thread Bing Zhao
application should not try to match these TAGs after the rule that contains NAT64 action. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow.h| 1 + drivers/net/mlx5/mlx5_flow_hw.c | 51 + 2 files changed, 52 insertions(+) diff --git a/drivers/net/mlx5

[PATCH v3 3/5] net/mlx5: create NAT64 actions during configuration

2024-02-20 Thread Bing Zhao
The NAT64 DR actions can be shared among the tables. All these actions can be created during configuring the flow queues and saved for the future usage. Even the actions can be shared now, inside per each flow rule, the actual hardware resources are unique. Signed-off-by: Bing Zhao --- doc

[PATCH v3 2/5] net/mlx5: fetch the available registers for NAT64

2024-02-20 Thread Bing Zhao
-off-by: Bing Zhao --- drivers/net/mlx5/mlx5.c | 9 + drivers/net/mlx5/mlx5.h | 2 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 881c42a97a..9c3b9946e3 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -1644,6

[PATCH v3 1/5] net/mlx5/hws: support NAT64 action

2024-02-20 Thread Bing Zhao
From: Erez Shitrit Add support of new action mlx5dr_action_create_nat64. The new action allows to modify IP packets from version to version, IPV6 to IPV4 and vice versa. Signed-off-by: Erez Shitrit Signed-off-by: Bing Zhao --- drivers/net/mlx5/hws/mlx5dr.h| 29 ++ drivers/net/mlx5

[PATCH v3 0/5] NAT64 support in mlx5 PMD

2024-02-20 Thread Bing Zhao
This patch set contains the mlx5 PMD implementation for NAT64. Update in v3: 1. code style and typo. Update in v2: 1. separate from the RTE and testpmd common part. 2. reorder the commits. 3. bug fix, code polishing and document update. Bing Zhao (4): net/mlx5: fetch the available

[PATCH v2 5/5] net/mlx5: validate the actions combination with NAT64

2024-02-20 Thread Bing Zhao
application should not try to match these TAGs after the rule that contains NAT64 action. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow.h| 1 + drivers/net/mlx5/mlx5_flow_hw.c | 51 + 2 files changed, 52 insertions(+) diff --git a/drivers/net/mlx5

[PATCH v2 4/5] net/mlx5: add NAT64 action support in rule creation

2024-02-20 Thread Bing Zhao
The action will handle the IPv4 and IPv6 headers translation. It will add / remove IPv6 address prefix by default. To use the user specific address, another rule to modify the addresses of the IP header is needed. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow_hw.c | 20

[PATCH v2 3/5] net/mlx5: create NAT64 actions during configuration

2024-02-20 Thread Bing Zhao
The NAT64 DR actions can be shared among the tables. All these actions can be created during configuring the flow queues and saved for the future usage. Even the actions can be shared now, inside per each flow rule, the actual hardware resources are unique. Signed-off-by: Bing Zhao --- doc

[PATCH v2 2/5] net/mlx5: fetch the available registers for NAT64

2024-02-20 Thread Bing Zhao
-off-by: Bing Zhao --- drivers/net/mlx5/mlx5.c | 9 + drivers/net/mlx5/mlx5.h | 2 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 881c42a97a..9c3b9946e3 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -1644,6

[PATCH v2 1/5] net/mlx5/hws: support NAT64 action

2024-02-20 Thread Bing Zhao
From: Erez Shitrit Add support of new action mlx5dr_action_create_nat64. The new action allows to modify IP packets from version to version, IPV6 to IPV4 and vice versa. Signed-off-by: Erez Shitrit Signed-off-by: Bing Zhao --- drivers/net/mlx5/hws/mlx5dr.h| 29 ++ drivers/net/mlx5

[PATCH v2 0/5] NAT64 support in mlx5 PMD

2024-02-20 Thread Bing Zhao
This patch set contains the mlx5 PMD implementation for NAT64. Update in v2: 1. separate from the RTE and testpmd common part. 2. reorder the commits. 3. bug fix, code polishing and document update. Bing Zhao (4): net/mlx5: fetch the available registers for NAT64 net/mlx5: create NAT64

[PATCH v2 2/2] app/testpmd: add support for NAT64 in the command line

2024-01-31 Thread Bing Zhao
\ 0x1 rules_number 8 pattern_template 0 actions_template 1 flow queue 0 create 2 template_table 0x1 pattern_template 0 \ actions_template 0 postpone no pattern eth / end actions count / \ nat64 type 1 / jump group 2 / end ... Signed-off-by: Bing Zhao --- app/test-pmd/cmdline_flow.c

[PATCH v2 1/2] ethdev: introduce NAT64 action

2024-01-31 Thread Bing Zhao
ction. Reference links: - https://datatracker.ietf.org/doc/html/rfc6146 - https://datatracker.ietf.org/doc/html/rfc6052 - https://datatracker.ietf.org/doc/html/rfc6145 Signed-off-by: Bing Zhao --- doc/guides/nics/features/default.ini | 1 + doc/guides/prog_guide/rte_flow.rst | 8

[PATCH v2 0/2] support NAT64 action

2024-01-31 Thread Bing Zhao
This patchset introduce the NAT64 action support for rte_flow. --- v2: split the common part and PMD part. --- Bing Zhao (2): ethdev: introduce NAT64 action app/testpmd: add support for NAT64 in the command line app/test-pmd/cmdline_flow.c | 23 ++ doc

[PATCH 8/8] net/mlx5: validate the actions combination with NAT64

2023-12-27 Thread Bing Zhao
application should not try to match these TAGs after the rule that contains NAT64 action. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow.h| 1 + drivers/net/mlx5/mlx5_flow_hw.c | 4 2 files changed, 5 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5

[PATCH 7/8] net/mlx5: add NAT64 action support in rule creation

2023-12-27 Thread Bing Zhao
The action will handle the IPv4 and IPv6 headers translation. It will add / remove IPv6 address prefix by default. To use the user specific address, another rule to modify the addresses of the IP header is needed. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow_hw.c | 22

[PATCH 5/8] net/mlx5/hws: support NAT64 action

2023-12-27 Thread Bing Zhao
From: Erez Shitrit Add support of new action mlx5dr_action_create_nat64. The new action allows to modify IP packets from version to version, IPV6 to IPV4 and vice versa. Signed-off-by: Erez Shitrit Signed-off-by: Bing Zhao --- drivers/net/mlx5/hws/mlx5dr.h| 29 ++ drivers/net/mlx5

[PATCH 6/8] net/mlx5: create NAT64 actions during configuration

2023-12-27 Thread Bing Zhao
The NAT64 DR actions can be shared among the tables. All these actions can be created during configuring the flow queues and saved for the future usage. Even the actions can be shared now, inside per each flow rule, the actual hardware resources are unique. Signed-off-by: Bing Zhao --- doc

[PATCH 3/8] net/mlx5: fetch the available registers for NAT64

2023-12-27 Thread Bing Zhao
-off-by: Bing Zhao --- drivers/net/mlx5/mlx5.c | 9 + drivers/net/mlx5/mlx5.h | 2 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 3a182de248..6f7b2aaa77 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -1643,6

[PATCH 4/8] common/mlx5: add new modify field defininations

2023-12-27 Thread Bing Zhao
This commit adds TCP data offset, IPv4 total length, IPv4 IHL, IPv6 payload length in modify field operation. Also redefine the out protocol(next header) for both IPv4 and IPv6. Signed-off-by: Bing Zhao --- drivers/common/mlx5/mlx5_prm.h | 5 + 1 file changed, 5 insertions(+) diff --git a

[PATCH 1/8] ethdev: introduce NAT64 action

2023-12-27 Thread Bing Zhao
ction. Reference links: - https://datatracker.ietf.org/doc/html/rfc6146 - https://datatracker.ietf.org/doc/html/rfc6052 - https://datatracker.ietf.org/doc/html/rfc6145 Signed-off-by: Bing Zhao --- doc/guides/nics/features/default.ini | 1 + doc/guides/prog_guide/rte_flow.rst | 8

[PATCH 0/8] support NAT64 action

2023-12-27 Thread Bing Zhao
This patchset introduce the NAT64 action support for rte_flow. Bing Zhao (7): ethdev: introduce NAT64 action app/testpmd: add support for NAT64 in the command line net/mlx5: fetch the available registers for NAT64 common/mlx5: add new modify field defininations net/mlx5: create NAT64

[PATCH 2/8] app/testpmd: add support for NAT64 in the command line

2023-12-27 Thread Bing Zhao
\ 0x1 rules_number 8 pattern_template 0 actions_template 1 flow queue 0 create 2 template_table 0x1 pattern_template 0 \ actions_template 0 postpone no pattern eth / end actions count / \ nat64 type 1 / jump group 2 / end ... Signed-off-by: Bing Zhao --- app/test-pmd/cmdline_flow.c

RE: [RFC PATCH] ethdev: introduce NAT64 action

2023-11-28 Thread Bing Zhao
Hi Ferruh, The full patch set will be sent for the coming 24.03 release. Thank you. > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, October 10, 2023 5:56 PM > To: Ori Kam ; Bing Zhao ; NBU- > Contact-Thomas Monjalon (EXTERNAL) ; > andrew.rybche...@okte

RE: [PATCH] net/mlx5: fix the LACP redirection in Rx domain

2023-11-13 Thread Bing Zhao
Hi Suanming, My answers are inline. > -Original Message- > From: Suanming Mou > Sent: Monday, November 13, 2023 9:14 PM > To: Bing Zhao ; Matan Azrad ; Slava > Ovsiienko ; Raslan Darawsheh > ; Ori Kam > Cc: dev@dpdk.org; Dariusz Sosnowski ; > sta...@dpdk.org &g

[PATCH] net/mlx5: fix the LACP redirection in Rx domain

2023-11-13 Thread Bing Zhao
rules with HWS") Cc: dsosnow...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Bing Zhao --- drivers/net/mlx5/linux/mlx5_os.c | 8 +- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow.h | 1 + drivers/net/mlx5/mlx5_flow_hw.c | 249 +++

[PATCH] net/mlx5: zero encap UDP csum for IPv4 too

2023-11-12 Thread Bing Zhao
From: Eli Britstein A zero UDP csum indicates it should not be validated by the receiver. The HW may not calculate UDP csum after encap. The cited commit made sure the UDP csum is zero for UDP over IPv6, mistakenly not handling UDP over IPv4. Fix it. Fixes: bf1d7d9a033a ("net/mlx5: zero out UDP

[PATCH] net/mlx5: fix shared Rx queue list management

2023-11-12 Thread Bing Zhao
uring port close, it can be removed from the list directly without freeing the resource. Fixes: 09c2555303be ("net/mlx5: support shared Rx queue") Cc: xuemi...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxq.c | 2 +

[PATCH] net/mlx5: fix shared Rx queue list management

2023-11-12 Thread Bing Zhao
uring port close, it can be removed from the list directly without freeing the resource. Fixes: 09c2555303be ("net/mlx5: support shared Rx queue") Cc: xuemi...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxq.c | 2 +

[PATCH] net/mlx5/hws: fix typo in the log

2023-11-12 Thread Bing Zhao
Change "cureent" to "current". Fixes: fa16fead9a68 ("net/mlx5/hws: support rule update after its creation") Cc: ere...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Bing Zhao --- drivers/net/mlx5/hws/mlx5dr_rule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH] net/mlx5: fix the workspace double free in Windows

2023-10-26 Thread Bing Zhao
resources management in Windows will remain the same with some stub function when needed. Fixes: dc7c5e0aa905 ("net/mlx5: fix flow workspace destruction") Cc: getel...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Bing Zhao Acked-by: Matan Azrad --- drivers/net/mlx5/linux/m

[PATCH] net/mlx5: fix the workspace double free in Windows

2023-10-26 Thread Bing Zhao
resources management in Windows will remain the same with some stub function when needed. Fixes: dc7c5e0aa905 ("net/mlx5: fix flow workspace destruction") Cc: getel...@nvidia.com Cc: d...@stable.org Signed-off-by: Bing Zhao Acked-by: Matan Azrad --- drivers/net/mlx5/linux/m

[RFC PATCH] ethdev: introduce NAT64 action

2023-08-11 Thread Bing Zhao
ayers protocol is out of the scope of NAT64 rte_flow action. Reference links: - https://datatracker.ietf.org/doc/html/rfc6146 - https://datatracker.ietf.org/doc/html/rfc6052 - https://datatracker.ietf.org/doc/html/rfc6145 Signed-off-by: Bing Zhao --- lib/ethdev/rte_flow.c | 1 + lib/e

RE: [PATCH] net/mlx5: fix leak in sysfs port name translation

2023-08-01 Thread Bing Zhao
Hi David, Thanks for catching this. BR. Bing > -Original Message- > From: David Marchand > Sent: Tuesday, August 1, 2023 11:19 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Bing Zhao > Subject: [PATC

[PATCH v2] doc: fix the template API requirements

2023-07-19 Thread Bing Zhao
The minimal SW and HW versions are added. Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering") Cc: va...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Bing Zhao --- v2: fix the incorrect headline prefix --- doc/guides/nics/mlx5.rst | 8 1 file changed, 8 insertion

[PATCH] net/mlx5: fix the template API requirements

2023-07-19 Thread Bing Zhao
The minimal SW and HW versions are added. Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering") Cc: va...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Bing Zhao --- doc/guides/nics/mlx5.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/nics/mlx5

[PATCH v2] net/mlx5: fix the drop action memory leak

2023-07-13 Thread Bing Zhao
. Bugzilla ID: 1192 Bugzilla ID: 1255 Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX") Cc: sta...@dpdk.org Reported-by: David Marchand Reported-by: Mário Kuka Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- v2: added the reporter --- drivers/net/mlx5/mlx5_

[PATCH] net/mlx5: fix the drop action memory leak

2023-07-13 Thread Bing Zhao
. Bugzilla ID: 1192 Bugzilla ID: 1255 Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX") Cc: sta...@dpdk.org Reported-by: David Marchand Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_devx.c | 4 1 file changed, 4 insertions(+) di

  1   2   3   4   5   6   7   >