[PATCH v2 14/14] net/zxdh: clean stat values

Implement stat values clean operation by agent channel. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_ethdev_ops.c | 4 + drivers/net/zxdh/zxdh_np.c | 302 + drivers/net/zxdh/zxdh_np.h | 23 ++- 3 files changed, 328 insertions(+), 1 deletion

[PATCH v2 11/14] net/zxdh: get hash table entry result

Implement hash tables get operation by dtb channel. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_np.c | 479 + drivers/net/zxdh/zxdh_np.h | 7 + 2 files changed, 486 insertions(+) diff --git a/drivers/net/zxdh/zxdh_np.c b/drivers/net/zxdh/zxdh_np.c

[PATCH v2 02/14] net/zxdh: support compatibility check

Add compatibility check between (np)network processor software and firmware. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_np.c | 94 ++ drivers/net/zxdh/zxdh_np.h | 12 + 2 files changed, 106 insertions(+) diff --git a/drivers/net/zxdh/zxdh_np.c

[PATCH v2 04/14] net/zxdh: modify dtb queue ops

Modify the implementation of the dtb queue request and release interfaces, and add the implementation of queue initialization. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_np.c | 495 + drivers/net/zxdh/zxdh_np.h | 97 2 files changed, 485 i

[PATCH v2 03/14] net/zxdh: add agent channel

Add agent channel to access (np)network processor registers that are not mapped by PCIE. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_np.c | 386 - drivers/net/zxdh/zxdh_np.h | 78 2 files changed, 463 insertions(+), 1 deletion(-) diff --gi

RE: [EXTERNAL] [PATCH v8] graph: mcore: optimize graph search

> -Original Message- > From: Huichao Cai > Sent: Friday, February 7, 2025 7:10 AM > To: Jerin Jacob ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; yanzhirun_...@163.com > Cc: dev@dpdk.org > Subject: [EXTERNAL] [PATCH v8] graph: mcore: optimize graph search > > In the functi

[PATCH 06/12] net/xsc: check possible null pointer dereference

This issue was reported by PVS studio, described as: https://pvs-studio.com/en/docs/warnings/v522/ Signed-off-by: Rong Qian Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_ethdev.c | 15 +-- drivers/net/xsc/xsc_rx.c | 5 + 2 files changed, 18 insertions(+), 2 deletions(-

[PATCH 12/12] net/xsc: avoid pointer cast to unrelated class

This issue was reported by PVS studio, described as: https://pvs-studio.com/en/docs/warnings/v1027/ Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_np.c | 10 +++-- drivers/net/xsc/xsc_rx.c | 12 ++--- drivers/net/xsc/xsc_vfio.c | 91 +++--- 3 files changed

[PATCH 07/12] net/xsc: avoid potential null pointer before used

This issue reported by PVS studio, described as: https://pvs-studio.com/en/docs/warnings/v595/ Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_np.c | 2 +- drivers/net/xsc/xsc_rx.c | 2 +- drivers/net/xsc/xsc_vfio.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dr

[PATCH 11/12] net/xsc: optimize memcmp returns not 0 check

This issue was reported by PVS studio, described as: https://pvs-studio.com/en/docs/warnings/v526/ Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xsc/xsc_ethdev.c b/drivers/net/xsc/xsc_ethdev.c index 44d

[PATCH 08/12] net/xsc: remove always-true part of if expression

This issue was reported by PVS studio, described as: https://pvs-studio.com/en/docs/warnings/v560/ Signed-off-by: Rong Qian Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_rx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/xsc/xsc_rx.c b/drivers/net/xsc/xsc_rx.c index dfb7

[PATCH 00/12] net/xsc: Resolve issues from PVS and Coverity Scan

This patch series resolves several issues reported by PVS and Coverity Scan, which were earlier forwarded to us by Stephen Hemminger. --- Renyong Wan (12): net/xsc: avoid integer overflow net/xsc: remove useless call net/xsc: address incorrect format warnings net/xsc: remove always-true if

[PATCH 10/12] net/xsc: avoid initialize by same function

This issue was reported by PVS studio, described as: https://pvs-studio.com/en/docs/warnings/v656 Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_rx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/xsc/xsc_rx.c b/drivers/net/xsc/xsc_rx.c index c031e56a94

[PATCH 09/12] net/xsc: avoid assign the same value to a variable

This issue was reported by PVS studio, described as: https://pvs-studio.com/en/docs/warnings/v1048/ Signed-off-by: Rong Qian Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_np.c | 4 drivers/net/xsc/xsc_tx.c | 1 - 2 files changed, 5 deletions(-) diff --git a/drivers/net/xsc/xsc_np.c b

[PATCH 03/12] net/xsc: address incorrect format warnings

These warnings reported by PVS studio, described as: https://pvs-studio.com/en/docs/warnings/v576/ Signed-off-by: Rong Qian Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_dev.c | 2 +- drivers/net/xsc/xsc_rx.c| 4 ++-- drivers/net/xsc/xsc_tx.c| 4 ++-- drivers/net/xsc/

[PATCH 04/12] net/xsc: remove always-true if expressions

This issue was reported by PVS studio, described as: https://pvs-studio.com/en/docs/warnings/v547/ Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_ethdev.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/net/xsc/xsc_ethdev.c b/drivers/net/xsc/xsc_ethd

[PATCH 05/12] net/xsc: avoid variable is assigned but not used

This issue was reported by PVS studio, described as: https://pvs-studio.com/en/docs/warnings/v1001/ Signed-off-by: Rong Qian Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_ethdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/xsc/xsc_ethdev.c b/drivers/net/xsc/xsc_et

[PATCH 01/12] net/xsc: avoid integer overflow

Address the integer overflow issue reported by Coverity Scan. Coverity issue: 456589 Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xsc/xsc_tx.c b/drivers/net/xsc/xsc_tx.c index 406fa95381..1d31e84d69 10064

[PATCH 02/12] net/xsc: remove useless call

Address incorrect expression (USELESS_CALL) reported by Coverity Scan. Coverity issue: 456590 Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_np.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/xsc/xsc_np.c b/drivers/net/xsc/xsc_np.c index d4eb833bf6..f032a0dbc2 100644 --- a/

Re: [PATCH v5 10/10] app: enable app directory to be compiled with MSVC

Acked-by: Chengwen Feng On 2025/2/22 3:52, Andre Muezerie wrote: > Enabled "app" directory to be compiled with MSVC along with all its > contents. > > Removed flag Wno-deprecated-declarations which is not needed anymore. > > Signed-off-by: Andre Muezerie > Acked-by: Bruce Richardson

Re: [PATCH v5 09/10] test: add workaround for __builtin_constant_p in test_memcpy_perf

Acked-by: Chengwen Feng On 2025/2/22 3:52, Andre Muezerie wrote: > There's no MSVC equivalent for compiler extension __builtin_constant_p, > so a workaround is needed. > > Signed-off-by: Andre Muezerie

Re: [PATCH] test/ring: fix return uninitialized variable

Acked-by: Chengwen Feng On 2025/2/19 22:23, Konstantin Ananyev wrote: > This change addresses the CID 455328: Uninitialized variables (UNINIT). > Strictly speaking right now it should never happen, as role_mask is not > zero. But that might change in future, as more test-cases will be > introduc

Re: [PATCH v3 1/2] net: add ptype parse for tunnel packets

On 2025/2/15 0:35, Stephen Hemminger wrote: On Fri, 14 Feb 2025 09:56:37 +0800 Jie Hai wrote: Add packet types parse for vxlan/vxlan-gpe/gtp/geneve packets. Signed-off-by: Jie Hai --- Not sure about this. The original purpose of ptype was to support hardware offload information. Does any

Re: [PATCH v2 1/7] eal: add queue macro extensions from FreeBSD

On Wed, 19 Feb 2025 15:55:17 +0100 Thomas Monjalon wrote: > 14/02/2025 18:20, Stephen Hemminger: > > The Linux version of sys/queue.h is frozen at an older version > > and is missing the _SAFE macro variants. Several drivers started > > introducing the own workarounds for this. Should be handled

Re: [PATCH v2 00/16] net/zxdh: updated net zxdh driver

On Fri, 21 Feb 2025 10:03:28 +0800 Junlong Wang wrote: > V2: > - modify CI some error results(checkpatches warnings、Wrong headline format) > - fix warnings when enable extra warnings. > - modify apply memcpy script for coccinelle and unnecessary init and > unneccessary cast of void when

[v3 3/6] crypto/virtio: add packed ring support

Add packed ring support. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/virtio_cryptodev.c | 125 +++ drivers/crypto/virtio/virtio_cryptodev.h | 13 +- drivers/crypto/virtio/virtio_cvq.c | 103 +- drivers/crypto/virtio/virtio_pci.h | 25 ++ drivers/cryp

[PATCH v2] crypto/openssl: validate incorrect signature in verify op

Return correct error status when incorrect signature is used in RSA verify op. Fixes: d7bd42f6db19 ("crypto/openssl: update RSA routine with 3.0 EVP API") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan --- v2: - added comments. --- drivers/crypto/openssl/rte_openssl_pmd.c | 10 +

RE: [PATCH v5 08/10] test-pmd: declare lcore_count atomic

> From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > Sent: Friday, 21 February 2025 20.53 > > Compiling with MSVC results in the error below: > > app/test/test_ring_perf.c(197): error C7712: address argument to atomic > operation must be a pointer to an atomic integer, > 'volati

Re: [PATCH v1] doc/guides: update monitor PMD mode description

On Fri, Feb 21, 2025 at 04:54:40PM +, Chris MacNamara wrote: > A recent CPU change requires an extra enabling step for > the umonitor instruction on Intel CPUs. > This is now detailed in the l3 fwd power manager doc. > > Signed-off-by: Chris MacNamara > --- > .mailmap

RE: [EXTERNAL] Re: [Patch v3] net/mana: use mana_local_data for tracking usage data for primary process

> Subject: [EXTERNAL] Re: [Patch v3] net/mana: use mana_local_data for tracking > usage data for primary process > > On Thu, 20 Feb 2025 15:32:02 -0800 > lon...@linuxonhyperv.com wrote: > > > From: Long Li > > > > The driver uses mana_shared_data for tracking usage count for primary > > process.

[RFC PATCH v20] mempool: fix mempool cache size

NOTE: THIS VERSION DOES NOT BREAK THE API/ABI. First, a per-lcore mempool cache could hold 50 % more than the cache's size. Since application developers do not expect this behavior, it could lead to application failure. This patch fixes this bug without breaking the API/ABI, by using the mempool c

Re: [Patch v3] net/mana: use mana_local_data for tracking usage data for primary process

On Thu, 20 Feb 2025 15:32:02 -0800 lon...@linuxonhyperv.com wrote: > From: Long Li > > The driver uses mana_shared_data for tracking usage count for primary > process. This is not correct as the mana_shared_data is allocated > by the primary and is meant to track usage of secondary process by th

[v1] app/crypto-perf: add RSA support

From: Akhil Goyal Add RSA support in crypto-perf application. Signed-off-by: Akhil Goyal --- app/test-crypto-perf/cperf_ops.c | 68 app/test-crypto-perf/cperf_options.h | 4 + app/test-crypto-perf/cperf_options_parsing.c | 38 +++- app/test-crypto-perf/cperf_te

[PATCH v5 00/10] enable "app" to be compiled with MSVC

v5: - add "volatile" to declaration of lcore_count in test_ring_perf.c. v4: - add explanation about the expression used in __rte_constant during v3. v3: - use clever expression with _Generic for __rte_constant and use it where __builtin_constant_p was being used. - use %u in csumonly.c and just

[PATCH v5 02/10] test_alarm: avoid warning about different qualifiers

Compiling with MSVC results in the warning below: app/test/test_alarm.c(54): warning C4090: 'function': different '_Atomic' qualifiers The fix is to use a macro to explicitly drop the qualifier. Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/test/test_alarm.c | 12

[PATCH v5 07/10] test-pmd: don't return value from void function

Compiling with MSVC results in the warning below: app/test-pmd/cmdline_flow.c(13964): warning C4098: 'cmd_set_raw_parsed': 'void' function returning a value Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson --- app/test-pmd/cmdline_flow.c | 12 -

[PATCH v5 09/10] test: add workaround for __builtin_constant_p in test_memcpy_perf

There's no MSVC equivalent for compiler extension __builtin_constant_p, so a workaround is needed. Signed-off-by: Andre Muezerie --- app/test/test_memcpy_perf.c | 54 ++--- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/app/test/test_memcpy_perf.c

[PATCH v5 10/10] app: enable app directory to be compiled with MSVC

Enabled "app" directory to be compiled with MSVC along with all its contents. Removed flag Wno-deprecated-declarations which is not needed anymore. Signed-off-by: Andre Muezerie Acked-by: Bruce Richardson --- app/meson.build | 4 app/test-pmd/meson.build | 1 - 2 files changed, 5

[PATCH v5 08/10] test-pmd: declare lcore_count atomic

Compiling with MSVC results in the error below: app/test/test_ring_perf.c(197): error C7712: address argument to atomic operation must be a pointer to an atomic integer, 'volatile unsigned int *' is not valid The fix is to mark lcore_count as atomic. Signed-off-by: Andre Muezerie Signed

[PATCH v5 05/10] test-pmd: avoid undefined behavior

Compiling with MSVC results in warnings like below: app/test-pmd/cmdline.c(9023): warning C5101: use of preprocessor directive in function-like macro argument list is undefined behavior Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline.c | 12

[PATCH v5 06/10] test-pmd: avoid non-constant initializer

Compiling with MSVC results in errors like the one below: app/test-pmd/cmdline_flow.c(8819): error C2099: initializer is not a constant Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline_flow.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-

[PATCH v5 04/10] test-pmd: do explicit 64-bit shift to avoid implicit conversion

Compiling with MSVC results in warnings like the one below: app/test-pmd/util.c(201): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson --- app/test

[PATCH v5 01/10] eal: add workaround for __builtin_constant_p

There's no MSVC equivalent for compiler extension __builtin_constant_p, but the same result can be obtained through a clever expression using _Generic. This patch redefines the macro __rte_constant when msvc is used and uses it as a replacement for __builtin_constant_p. Signed-off-by: Andre Mueze

[PATCH v5 03/10] test-pmd: fix printf format string mismatch

Compiling with MSVC results in warnings like the one below: app/test-pmd/csumonly.c(1085): warning C4477: 'printf' : format string '%d' requires an argument of type 'int', but variadic argument 1 has type 'uint64_t' Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/tes

Re: [PATCH v4 08/10] test-pmd: declare lcore_count atomic

On Fri, Feb 21, 2025 at 08:40:17AM +, Konstantin Ananyev wrote: > > > > Compiling with MSVC results in the error below: > > > > app/test/test_ring_perf.c(197): error C7712: address argument to atomic > > operation must be a pointer to an atomic integer, > > 'volatile unsigned int *'

Re: [PATCH] sched: fix wrr parameter data type

On Fri, 21 Feb 2025 18:17:55 +0530 Megha Ajmera wrote: > wrr tokens getting truncated to uint8_t in wrr_store function() due to > type mismatch. This patch chnages the data type to uint16_t. > > Fixes: e16b06da0908 ("sched: remove WRR from strict priority TC queues") > > Signed-off-by: Megha Aj

[RFC PATCH v19] mempool: fix mempool cache size

NOTE: THIS VERSION DOES NOT BREAK THE API/ABI. First, a per-lcore mempool cache could hold 50 % more than the cache's size. Since application developers do not expect this behavior, it could lead to application failure. This patch fixes this bug without breaking the API/ABI, by using the mempool c

Re: [PATCH v1] doc/guides: update monitor PMD mode description

On Fri, 21 Feb 2025 16:54:40 + Chris MacNamara wrote: > A recent CPU change requires an extra enabling step for > the umonitor instruction on Intel CPUs. > This is now detailed in the l3 fwd power manager doc. > > Signed-off-by: Chris MacNamara > --- > .mailmap

[v3 2/5] vhost: update vhost_user crypto session parameters

As per requirements on vhost_user spec, session id should be located at the end of session parameter. Update VhostUserCryptoSessionParam structure to support newer QEMU. Due to additional parameters added in QEMU, received payload from QEMU would be larger than existing payload, hence breaks parsi

[v3 1/6] crypto/virtio: add asymmetric RSA support

Asymmetric RSA operations (SIGN, VERIFY, ENCRYPT and DECRYPT) are supported in virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: series-34674 ("vhost: add RSA support") v3: - fast path optimizations. --- .../virtio/virtio_crypto_capabilities.h | 19 + drivers/crypto/

[v3 5/6] test/crypto: add asymmetric tests for virtio PMD

Add asymmetric tests for Virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 28 1 file changed, 28 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index 9b5f3c545e..ac47be724f 100644

[v3 6/6] test/crypto: add tests for virtio user PMD

Reuse virtio_crypto tests for testing virtio_crypto_user PMD. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev.c | 7 +++ app/test/test_cryptodev.h | 1 + app/test/test_cryptodev_asym.c | 15 +++ 3 files changed, 23 insertions(+) diff --git a/app

[v3 4/6] crypto/virtio: add vDPA backend

Add vDPA backend to virtio_user crypto. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/meson.build | 7 + drivers/crypto/virtio/virtio_cryptodev.c | 57 +- drivers/crypto/virtio/virtio_cryptodev.h | 3 + drivers/crypto/virtio/virtio_logs.h

[v3 2/6] crypto/virtio: refactor queue operations

Move existing control queue operations into a common place that would be shared with other virtio type of devices. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/meson.build | 1 + drivers/crypto/virtio/virtio_crypto_algs.h | 2 +- drivers/crypto/virtio/virtio_c

[v3 0/6] crypto/virtio: enhancements for RSA and vDPA

This patch series enhances virtio crypto PMD to: * support RSA * support packed virtio ring * support vDPA backend v3: - vDPA backend code majorly sourced from virtio net. Gowrishankar Muthukrishnan (6): crypto/virtio: add asymmetric RSA support crypto/virtio: refactor queue operations

[v3 3/5] examples/vhost_crypto: fix user callbacks

In order to handle new vhost user connection, use new_connection and destroy_connection callbacks. Fixes: f5188211c721 ("examples/vhost_crypto: add sample application") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan --- v3: - decoupled from v2 single patch. --- examples/vhost_cr

[v3 5/5] examples/vhost_crypto: support asymmetric crypto

Support asymmetric crypto operations. Signed-off-by: Gowrishankar Muthukrishnan --- examples/vhost_crypto/main.c | 50 +++- 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c index b1fe4120b9

[v3 4/5] vhost: support asymmetric RSA crypto ops

Support asymmetric RSA crypto operations in vhost-user. Signed-off-by: Gowrishankar Muthukrishnan --- v3: - TLV decode optimization for fast path. - virtio_crypto.h changes moved from virtio PMD patch series into this series as asymmetric support starts essentially from library. --- lib/vh

[v3 1/5] vhost: skip crypto op fetch before vring init

Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR), worker thread should not try to fetch crypto op, which would lead to memory fault. Fixes: 939066d9656 ("vhost/crypto: add public function implementation") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan --- lib

[v3 0/5] vhost: add RSA support

This patch series supports asymmetric RSA in vhost crypto library. It also includes changes to improve vhost crypto library: * support newer QEMU versions. * fix broken vhost_crypto example application. * stabilize crypto fastpath operations. v3: - spin off new patches from one single patch in

RE: Intel FAST_FREE offload question

> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 21 February 2025 18.10 > > On Fri, Feb 21, 2025 at 05:58:21PM +0100, Morten Brørup wrote: > > Intel NIC folks, > > > > Why do the Intel network drivers, when using > > RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE, fall back to norma

Re: Intel FAST_FREE offload question

On Fri, Feb 21, 2025 at 05:58:21PM +0100, Morten Brørup wrote: > Intel NIC folks, > > Why do the Intel network drivers, when using > RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE, fall back to normal freeing when the > mempool cache is empty (cache->len == 0)? It doesn't make sense to me. > > Example: > http

[PATCH] test/crypto: add negative test for RSA verify op

Add negative test for RSA verify operation to check if incorrect signature is validated. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/app/test/test_cryptodev_asym.c b/

Intel FAST_FREE offload question

Intel NIC folks, Why do the Intel network drivers, when using RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE, fall back to normal freeing when the mempool cache is empty (cache->len == 0)? It doesn't make sense to me. Example: https://git.dpdk.org/dpdk/tree/drivers/net/intel/common/tx.h#n146 Med venlig hil

[PATCH v1] doc/guides: update monitor PMD mode description

A recent CPU change requires an extra enabling step for the umonitor instruction on Intel CPUs. This is now detailed in the l3 fwd power manager doc. Signed-off-by: Chris MacNamara --- .mailmap | 1 + doc/guides/sample_app_ug/l3_forward_power_man.rst | 5

Re: [PATCH v4 01/10] eal: add workaround for __builtin_constant_p

On Fri, Feb 21, 2025 at 04:31:28PM +0100, Morten Brørup wrote: > Thank you for this updated MSVC variant of the macro, and its detailed > description. > > Acked-by: Morten Brørup Sure. Thank you for pushing for this better solution.

[PATCH] net/ice: fix incorrect mbuf cleanup function

The mbuf cleanup function is not being called correctly on close of the driver, due to the vector_tx flag not being set correctly on each Tx queue. Normally, this causes no visible problems, because the default is to have the vector flag unset, which means that, if vector Tx path is chosen, we only

RE: [PATCH v4 01/10] eal: add workaround for __builtin_constant_p

Thank you for this updated MSVC variant of the macro, and its detailed description. Acked-by: Morten Brørup

[RFC PATCH v18] mempool: fix mempool cache size

NOTE: THIS VERSION DOES NOT BREAK THE API/ABI. First, a per-lcore mempool cache could hold 50 % more than the cache's size. Since application developers do not expect this behavior, it could lead to application failure. This patch fixes this bug without breaking the API/ABI, by using the mempool c

Re: [PATCH] net/ixgbe: fix min Rx/Tx descriptors

On Fri, Feb 21, 2025 at 08:23:18AM +, Mingjin Ye wrote: > The minimum free packet threshold (tx_free_thresh) and the minimum RS bit > threshold (tx_rs_thresh) both have a default value of 32. Therefore, the > default minimum number of ring descriptors value is 64. > > Fixes: dee5f1fd5fc7 ("ixg

Re: [PATCH] net/ixgbe: fix min Rx/Tx descriptors

On Fri, Feb 21, 2025 at 08:23:18AM +, Mingjin Ye wrote: > The minimum free packet threshold (tx_free_thresh) and the minimum RS bit > threshold (tx_rs_thresh) both have a default value of 32. Therefore, the > default minimum number of ring descriptors value is 64. > > Fixes: dee5f1fd5fc7 ("ixg

RE: [PATCH] sched: fix wrr parameter data type

> -Original Message- > From: Ajmera, Megha > Sent: Friday, February 21, 2025 12:48 PM > To: dev@dpdk.org > Cc: Singh, Jasvinder ; Dumitrescu, Cristian > > Subject: [PATCH] sched: fix wrr parameter data type > > wrr tokens getting truncated to uint8_t in wrr_store function() due to typ

[PATCH] sched: fix wrr parameter data type

wrr tokens getting truncated to uint8_t in wrr_store function() due to type mismatch. This patch chnages the data type to uint16_t. Fixes: e16b06da0908 ("sched: remove WRR from strict priority TC queues") Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(

RE: [PATCH v2] net/mlx5/hws: fix fragmented ptype match

> -Original Message- > From: Alexander Kozyrev > Sent: Thursday, December 19, 2024 17:06 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava Ovsiienko > ; Dariusz Sosnowski ; Bing > Zhao ; Suanming Mou ; Michael > Baum > Subject: [PATCH v2] net/mlx5/hws: fix fragmented p

Re: [PATCH] power: use hugepage memory for queue list entry structure

On 20/02/2025 17:45, Stephen Hemminger wrote: On Thu, 20 Feb 2025 16:39:52 + Konstantin Ananyev wrote: -Original Message- From: Stephen Hemminger Sent: Thursday, February 20, 2025 4:12 PM To: lihuisong (C) Cc: dev@dpdk.org; tho...@monjalon.net; david.h...@intel.com; anatoly.bura

[PATCH] net/ice: fix ACL filter uninit

The pf has enabled the ACL filter, so uninit is no longer limited to the DCF. Fixes: a9d612291c2d ("net/ice: support IPv4 fragments in ACL filters") Signed-off-by: Mingjin Ye --- drivers/net/intel/ice/ice_acl_filter.c | 48 +- 1 file changed, 24 insertions(+), 24 deletio

RE: [PATCH v3 11/14] rawdev: remove unnecessary deref of function pointers

Acked-by: Hemant Agrawal

Re: [PATCH v4 03/10] test-pmd: fix printf format string mismatch

On Thu, Feb 20, 2025 at 01:30:57PM -0800, Andre Muezerie wrote: > Compiling with MSVC results in warnings like the one below: > > app/test-pmd/csumonly.c(1085): warning C4477: 'printf' : format string > '%d' requires an argument of type 'int', > but variadic argument 1 has type 'uint64_t'

[PATCH] net/ixgbe: fix min Rx/Tx descriptors

The minimum free packet threshold (tx_free_thresh) and the minimum RS bit threshold (tx_rs_thresh) both have a default value of 32. Therefore, the default minimum number of ring descriptors value is 64. Fixes: dee5f1fd5fc7 ("ixgbe: get queue info and descriptor limits") Cc: sta...@dpdk.org Signed

RE: [PATCH v2] examples/l3fwd: add option to set Tx burst size

> >> On 2024/12/4 10:06, Jie Hai wrote: > >>> The application send packets only when the buffer is full, or the > >>> buffer is empty and the packets to be sent extends TX_PKT_BURST. > >>> The change of MAX_PKT_BURST make TX buffer size and TX_PKT_BURST > >>> increase, while the default cache siz

RE: [PATCH v4 08/10] test-pmd: declare lcore_count atomic

> Compiling with MSVC results in the error below: > > app/test/test_ring_perf.c(197): error C7712: address argument to atomic > operation must be a pointer to an atomic integer, > 'volatile unsigned int *' is not valid > > The fix is to mark lcore_count as atomic. > > Signed-off-by: A