RE: [PATCH v3 00/10] enable "app" to be compiled with MSVC

Series-acked-by: Morten Brørup

RE: [PATCH v2] testpmd: support meter_mark init_color in indirect list configuration

> -Original Message- > From: Gregory Etelson > Sent: Monday, February 17, 2025 7:21 PM > > Flow actions parameters in indirect actions list are created as > read-only and shared between all flows that reference that indirect > list. > > If a flow rule needs to apply rule specific actio

[PATCH] net/mlx5: fix err message overwrite for actions translation

Function __flow_hw_translate_actions_template contains several encapsulated functions that already have internal error handling process via rte_flow_error_set for each case. Thus the one (rte_flow_error_set) within the goto statement `err` at the end of __flow_hw_translate_actions_template functio

Re: [PATCH v2 01/14] ethdev: remove unnecessary deref on function pointers

On 2/20/25 05:32, Stephen Hemminger wrote: The expression *dev->dev_ops->rx_queue_start and dev->dev_ops->rx_queue_start are equivalent. Remove the unnecessary asterisk and parenthesis. Signed-off-by: Stephen Hemminger Reviewed-by: Andrew Rybchenko one nit below @@ -6995,11 +6966,11 @@ rt

[PATCH 0/2] fix testpmd DCB command

This patchset contains two commit which found when debug DCB module. Chengwen Feng (2): app/testpmd: support display DCB all priority's TC map app/testpmd: fix segment fault when config DCB app/test-pmd/cmdline.c | 6 ++ app/test-pmd/config.c | 4 ++-- 2 files changed, 8 insertions(+),

[PATCH 2/2] app/testpmd: fix segment fault when config DCB

The "port config dcb ..." command will segment fault when input with invalid port id, this patch fixes it. Fixes: 9b53e542e9e1 ("app/testpmd: add priority flow control") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline.c | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH 1/2] app/testpmd: support display DCB all priority's TC map

Currently, the "show port dcb_tc" command displays only the mapping in the number of TCs. This patch fixes it by show all priority's TC mapping. Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test-pmd/config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app

RE: [PATCH v2 1/3] eventdev/eth_rx: add API to burst add queues to Rx adapter

>> >> This patch introduces a new API, rte_event_eth_rx_adapter_queues_add(), >> to allow bulk addition of multiple Rx queues in the eventdev Rx adapter. >> >> The existing rte_event_eth_rx_adapter_queue_add() API supports adding >> multiple queues by specifying rx_queue_id = -1, but it lacks the a

RE: [PATCH v13 00/28] [v13]drivers/net Add Support mucse N10 Pmd Driver

Hi Stephen, For the release thing, that be ok. But for Debian 12 with MUSDK it be failed, do I need to fixed it , The ability when I used it that I had been memset it. But the compile-tool is warning it, hw->phy_port_ids[idx] = ability.port_ids[idx]; Branch: master CommitID:968f7b6d7b6a7e60e6e5

[PATCH v2 07/14] cryptodev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_gets and dev->dev_ops->dev_info_gets are equivalent. Cleanup and remove unnecessary parenthesis as well. Signed-off-by: Stephen Hemminger --- lib/cryptodev/rte_cryptodev.c | 72 +-- 1 file changed, 35 insertions(+), 37 deleti

RE: [PATCH v2 1/3] eventdev/eth_rx: add API to burst add queues to Rx adapter

> -Original Message- > From: Shijith Thotton > Sent: Tuesday, February 18, 2025 2:46 PM > To: Naga Harish K, S V ; jer...@marvell.com > Cc: Shijith Thotton ; dev@dpdk.org; > pbhagavat...@marvell.com; Pathak, Pravin ; > Hemant Agrawal ; Sachin Saxena > ; Mattias R_nnblom > ; Liang Ma ; >

Re: [PATCH v2 10/14] dmadev: remove unnecessary deref of function pointers

Acked-by: Chengwen Feng On 2025/2/20 10:32, Stephen Hemminger wrote: > The expression *dev->dev_ops->dev_info_get and > dev->dev_ops->dev_info_get are equivalent. > > Signed-off-by: Stephen Hemminger

[PATCH v2 05/14] net/ipn3ke: remove unnecessary dereference

Since it is a function pointer, the expression *hw->f_mac_read and hw->f_mac_read are equivalent in C. Remove excession indentation here. Signed-off-by: Stephen Hemminger --- drivers/net/intel/ipn3ke/ipn3ke_ethdev.c | 27 +--- 1 file changed, 5 insertions(+), 22 deletions(-)

[PATCH v2 14/14] security: remove unnecessary dereference

The expressions *instance->ops->set_pkt_metadata and instance->ops->set_pkt_metadata are equivalent in C. Signed-off-by: Stephen Hemminger --- lib/security/rte_security.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/security/rte_security.c b/lib/security/rte_secur

[PATCH v2 12/14] mldev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_get and dev->dev_ops->dev_info_get are equivalent in C. Signed-off-by: Stephen Hemminger --- lib/mldev/rte_mldev.c | 88 +-- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/lib/mldev/rte_mldev.c b/lib/

[PATCH v2 10/14] dmadev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_get and dev->dev_ops->dev_info_get are equivalent. Signed-off-by: Stephen Hemminger --- lib/dmadev/rte_dmadev.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev

[PATCH v2 13/14] regexdev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_get and dev->dev_ops->dev_info_get are equivalent in C. Signed-off-by: Stephen Hemminger --- lib/regexdev/rte_regexdev.c | 72 ++--- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/lib/regexdev/rte_regexdev.c

[PATCH v2 11/14] rawdev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_configure and dev->dev_ops->dev_configure are equivalent. Signed-off-by: Stephen Hemminger --- lib/rawdev/rte_rawdev.c | 99 - 1 file changed, 48 insertions(+), 51 deletions(-) diff --git a/lib/rawdev/rte_rawdev.c b/lib/r

[PATCH v2 09/14] compressdev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_gets and dev->dev_ops->info_get are equivalent. Signed-off-by: Stephen Hemminger --- lib/compressdev/rte_compressdev.c | 56 +++ 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/lib/compressdev/rte_compressdev.c b

[PATCH v2 08/14] crypto/scheduler: remove unnecessary dereference

The expression *dev->dev_ops->sym_session_get_size and dev->dev_ops->sym_session_get_size are equivalent. Signed-off-by: Stephen Hemminger --- .../scheduler/rte_cryptodev_scheduler.c | 8 +++--- drivers/crypto/scheduler/scheduler_pmd_ops.c | 25 +-- 2 files changed, 16 in

[PATCH v2 04/14] net/ixgbe: remove unnecessary dereference

The expression *dev->dev_ops->vlan_strip_queue_set and dev->dev_ops->vlan_strip_queue are equivalent in C. Signed-off-by: Stephen Hemminger --- drivers/net/intel/ixgbe/rte_pmd_ixgbe.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/intel/ixgbe/rte_pmd_ixgbe.c

[PATCH v2 06/14] net/memif: remove unnecessary deref of function pointers

Since queue release functions are local to driver, prefer those over dereferencing the dev_ops table. Signed-off-by: Stephen Hemminger --- drivers/net/memif/rte_eth_memif.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/

[PATCH v2 02/14] eventdev: remover unnecessary deref on function pointers

The expression *dev_dev_ops->foo and dev->dev_ops->foo are equivalent. Cleanup the result by removing unneeded parenthesis and make lines compact. Signed-off-by: Stephen Hemminger --- lib/eventdev/rte_event_crypto_adapter.c | 37 ++ lib/eventdev/rte_event_dma_adapter.c| 16 +-- lib/eve

[PATCH v2 03/14] net/bonding: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_get and dev->dev_ops->dev_info_get are equivalent in C. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_pmd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/dr

[PATCH v2 00/14] Remove unnecessary function pointer deref

A common pattern in DPDK internals is to have an array of function pointers. When using these pointers an unnecessary derefence is done; this is allowed in C because of a historical quirk but unnecessary. This fixes all instances of PVS Studio checker warning: https://pvs-studio.com/en/docs/warni

[PATCH v2 01/14] ethdev: remove unnecessary deref on function pointers

The expression *dev->dev_ops->rx_queue_start and dev->dev_ops->rx_queue_start are equivalent. Remove the unnecessary asterisk and parenthesis. Signed-off-by: Stephen Hemminger --- lib/ethdev/ethdev_driver.c | 16 +- lib/ethdev/ethdev_private.c | 4 +- lib/ethdev/rte_ethdev.c | 492 +++

[PATCH v3 07/10] test-pmd: don't return value from void function

Compiling with MSVC results in the warning below: app/test-pmd/cmdline_flow.c(13964): warning C4098: 'cmd_set_raw_parsed': 'void' function returning a value Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson --- app/test-pmd/cmdline_flow.c | 12 -

[PATCH v3 10/10] app: enable app directory to be compiled with MSVC

Enabled "app" directory to be compiled with MSVC along with all its contents. Removed flag Wno-deprecated-declarations which is not needed anymore. Signed-off-by: Andre Muezerie Acked-by: Bruce Richardson --- app/meson.build | 4 app/test-pmd/meson.build | 1 - 2 files changed, 5

[PATCH v3 06/10] test-pmd: avoid non-constant initializer

Compiling with MSVC results in errors like the one below: app/test-pmd/cmdline_flow.c(8819): error C2099: initializer is not a constant Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline_flow.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-

[PATCH v3 09/10] test: add workaround for __builtin_constant_p in test_memcpy_perf

There's no MSVC equivalent for compiler extension __builtin_constant_p, so a workaround is needed. Signed-off-by: Andre Muezerie --- app/test/test_memcpy_perf.c | 54 ++--- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/app/test/test_memcpy_perf.c

[PATCH v3 08/10] test-pmd: declare lcore_count atomic

Compiling with MSVC results in the error below: app/test/test_ring_perf.c(197): error C7712: address argument to atomic operation must be a pointer to an atomic integer, 'volatile unsigned int *' is not valid The fix is to mark lcore_count as atomic. Signed-off-by: Andre Muezerie Signed

[PATCH v3 05/10] test-pmd: avoid undefined behavior

Compiling with MSVC results in warnings like below: app/test-pmd/cmdline.c(9023): warning C5101: use of preprocessor directive in function-like macro argument list is undefined behavior Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline.c | 12

[PATCH v3 00/10] enable "app" to be compiled with MSVC

v3: - use clever expression with _Generic for __rte_constant and use it where __builtin_constant_p was being used. - use %u in csumonly.c and just cast variables to unsigned int. v2: - use lcore_count as atomic always, not only when RTE_USE_C11_MEM_MODEL is set. - use PRIu64 in csumonly.c inst

[PATCH v3 02/10] test_alarm: avoid warning about different qualifiers

Compiling with MSVC results in the warning below: app/test/test_alarm.c(54): warning C4090: 'function': different '_Atomic' qualifiers The fix is to use a macro to explicitly drop the qualifier. Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/test/test_alarm.c | 12

[PATCH v3 01/10] eal: add workaround for __builtin_constant_p

There's no MSVC equivalent for compiler extension __builtin_constant_p, but the same result can be obtained though a clever expression using _Generic. This patch redefines the macro __rte_constant when msvc is used and uses it as a replacement for __builtin_constant_p. Signed-off-by: Andre Muezer

[PATCH v3 04/10] test-pmd: do explicit 64-bit shift to avoid implicit conversion

Compiling with MSVC results in warnings like the one below: app/test-pmd/util.c(201): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson --- app/test

[PATCH v3 03/10] test-pmd: fix printf format string mismatch

Compiling with MSVC results in warnings like the one below: app/test-pmd/csumonly.c(1085): warning C4477: 'printf' : format string '%d' requires an argument of type 'int', but variadic argument 1 has type 'uint64_t' Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/tes

Re: [PATCH v2 01/10] eal: add workaround for __builtin_constant_p

On Wed, Feb 19, 2025 at 09:10:11AM -0800, Stephen Hemminger wrote: > On Wed, 19 Feb 2025 08:50:02 -0800 > Andre Muezerie wrote: > > > On Tue, Feb 18, 2025 at 06:12:04PM +0100, Morten Brørup wrote: > > > > From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > > > > Sent: Tuesday, 18 Februar

Re: [EXTERNAL] [Patch v2] net/mana: use mana_local_data for tracking usage data for primary process

On Wed, 19 Feb 2025 12:47:11 + Wei Hu wrote: > > > > -/* Shared data between primary/secondary processes */ struct > > mana_shared_data { > > - rte_spinlock_t lock; > > - int init_done; > > - unsigned int primary_cnt; > > - unsigned int secondary_cnt; > > + rte_atomic32_t secondar

Re: [PATCH v2] testpmd: support meter_mark init_color in indirect list configuration

On Mon, 17 Feb 2025 19:21:10 +0200 Gregory Etelson wrote: > Flow actions parameters in indirect actions list are created as > read-only and shared between all flows that reference that indirect > list. > > If a flow rule needs to apply rule specific actions list parameters it > does it with the

Re: [PATCH] config/arm: update NVIDIA BlueField-3 configuration

19/02/2025 17:35, Wathsala Wathawana Vithanage: > > Subject: [PATCH] config/arm: update NVIDIA BlueField-3 configuration > > > > ARM configuration requires explicit `mcpu` specifications in the implementor > > description. > > > > The patch adds `mcpu` and `flags` description for the NVIDIA > > B

Re: [PATCH] config/arm: add Phytium TengYun S5000c

13/02/2025 08:14, luzhipeng: > add support for Phytium tengyunS5000c > > Signed-off-by: luzhipeng Applied, thanks.

Re: Link custom libarchive meson support

11/02/2025 19:46, Ben Magistro: > Will acknowledge this may be more of a meson question and less of a DPDK > issue but things didn't seem to work as expected and had to tweak the > config/meson.build to want to start with the DPDK team. > > Our project is cmake based and we use fetch content to pu

RE: [PATCH] examples/l3fwd: add option to set refetch offset

> Subject: [PATCH] examples/l3fwd: add option to set refetch offset I suppose it should be 'prefetch'. > The prefetch window depending on the HW platform. It is difficult to > measure the prefetch window of a HW platform. Therefore, the prefetch > offset option is added to change the prefetch

Re: [PATCH v2 01/10] eal: add workaround for __builtin_constant_p

On Wed, 19 Feb 2025 08:50:02 -0800 Andre Muezerie wrote: > On Tue, Feb 18, 2025 at 06:12:04PM +0100, Morten Brørup wrote: > > > From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > > > Sent: Tuesday, 18 February 2025 17.32 > > > > > > There's no MSVC equivalent for compiler extension __b

Re: [PATCH v2 05/10] test-pmd: avoid undefined behavior

On Tue, Feb 18, 2025 at 04:41:14PM +, Bruce Richardson wrote: > On Tue, Feb 18, 2025 at 08:32:04AM -0800, Andre Muezerie wrote: > > Compiling with MSVC results in warnings like below: > > > > app/test-pmd/cmdline.c(9023): warning C5101: use of preprocessor > > directive in function-like ma

Re: [PATCH v2 03/10] test-pmd: fix printf format string mismatch

On Tue, Feb 18, 2025 at 05:07:03PM +, Bruce Richardson wrote: > On Tue, Feb 18, 2025 at 09:03:01AM -0800, Andre Muezerie wrote: > > On Tue, Feb 18, 2025 at 04:46:56PM +, Bruce Richardson wrote: > > > On Tue, Feb 18, 2025 at 08:32:02AM -0800, Andre Muezerie wrote: > > > > Compiling with MSVC

RE: [PATCH v2] examples/l3fwd: add option to set Tx burst size

> On 2024/12/4 10:06, Jie Hai wrote: > > The application send packets only when the buffer is full, or the > > buffer is empty and the packets to be sent extends TX_PKT_BURST. > > The change of MAX_PKT_BURST make TX buffer size and TX_PKT_BURST > > increase, while the default cache size is 256.

RE: [PATCH] examples/l3fwd: adjust Tx burst size based on Rx burst

> Previously, the TX burst size was fixed at 256, leading to performance > degradation in certain scenarios. > > This patch introduces logic to set the TX burst size to match the > configured RX burst size (--burst option, default 32, max 512) > for better efficiency. > > Fixes: d5c4897ecfb2 (

Re: [PATCH v7 1/4] bus/pci: fix registration of PCI device

On Wed, 12 Feb 2025 18:38:32 +0200 Shani Peretz wrote: > When registering a new PCI device, the device->name field stored > the user-provided string from devargs (e.g., "08:00.0" or ":08:00.0"). > This approach led to inconsistencies when registering new devices. > > This patch fix this issu

Re: [PATCH v2 01/10] eal: add workaround for __builtin_constant_p

On Tue, Feb 18, 2025 at 06:12:04PM +0100, Morten Brørup wrote: > > From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > > Sent: Tuesday, 18 February 2025 17.32 > > > > There's no MSVC equivalent for compiler extension __builtin_constant_p. > > EAL already had __rte_constant which was used

Re: [PATCH v7 1/4] bus/pci: fix registration of PCI device

On Wed, 12 Feb 2025 18:38:32 +0200 Shani Peretz wrote: > When registering a new PCI device, the device->name field stored > the user-provided string from devargs (e.g., "08:00.0" or ":08:00.0"). > This approach led to inconsistencies when registering new devices. > > This patch fix this issu

Re: [PATCH v7 3/4] app/test: add tests to find devices

On Wed, 12 Feb 2025 18:38:34 +0200 Shani Peretz wrote: > +static struct rte_device * > +create_pci_dev(const char *name) > +{ > + int port_id; > + struct rte_ether_addr rand_ea = {0}; > + rte_eth_random_addr(rand_ea.addr_bytes); Minor nit, no need to initialize address then call rand

RE: [PATCH] config/arm: update NVIDIA BlueField-3 configuration

> Subject: [PATCH] config/arm: update NVIDIA BlueField-3 configuration > > ARM configuration requires explicit `mcpu` specifications in the implementor > description. > > The patch adds `mcpu` and `flags` description for the NVIDIA > BlueField-3 configuration. > > Signed-off-by: Gregory Etelson

Re: [PATCH v13 00/28] [v13]drivers/net Add Support mucse N10 Pmd Driver

On Wed, 19 Feb 2025 15:57:01 +0800 Wenbo Cao wrote: > For This patchset just to support the basic chip init work > and user can just found the eth_dev, but can't control more. > For Now just support 2*10g nic,the chip can support > 2*10g,4*10g,4*1g,8*1g,8*10g. > The Feature rx side can support rx

Re: [PATCH v8] graph: mcore: optimize graph search

07/02/2025 02:39, Huichao Cai: > In the function __rte_graph_mcore_dispatch_sched_node_enqueue, > use a slower loop to search for the graph, modify the search logic > to record the result of the first search, and use this record for > subsequent searches to improve search speed. > > Signed-off-by:

Re: [PATCH] examples/flow_filtering: fix destination IP mask

12/01/2025 08:52, Shani Peretz: > This patch corrects the destination IP address mask to > restore the previous implementation's behavior. > > Also it fixes a misuse of rte_flow_item_tcp struct. > Replace it with the appropriate rte_flow_item_ipv4 struct, > as the code in this context filters ipv4

Re: [PATCH v2 1/7] eal: add queue macro extensions from FreeBSD

14/02/2025 18:20, Stephen Hemminger: > The Linux version of sys/queue.h is frozen at an older version > and is missing the _SAFE macro variants. Several drivers started > introducing the own workarounds for this. Should be handled in EAL. > > Signed-off-by: Stephen Hemminger We may want to unify

Re: [PATCH v2 10/10] app: enable app directory to be compiled with MSVC

On Wed, Feb 19, 2025 at 10:15:21AM +0100, David Marchand wrote: > On Tue, Feb 18, 2025 at 5:33 PM Andre Muezerie > wrote: > > diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build > > index f1c36529b4..8e8863812a 100644 > > --- a/app/test-pmd/meson.build > > +++ b/app/test-pmd/meson.bui

[PATCH] dts: grab linter return value

In dts-check-format we were checking if the linter was updating the tree, but we were not picking up the return value in case an unfixable error would be raised. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- devtools/dts-check-format.sh | 1 + 1 file changed, 1 insertion(+) dif

RE: [PATCH v22 00/27] remove use of VLAs for Windows

> > > > As per guidance technical board meeting 2024/04/17. This series > > > > removes the use of VLAs from code built for Windows for all 3 > > > > toolchains. If there are additional opportunities to convert VLAs > > > > to regular C arrays please provide the details for incorporation > > > > i

[PATCH] test/ring: fix return uninitialized variable

This change addresses the CID 455328: Uninitialized variables (UNINIT). Strictly speaking right now it should never happen, as role_mask is not zero. But that might change in future, as more test-cases will be introduced. Anyway the fix is trivial. Coverity issue: 455328 Fixes: 70581c355d69 ("tes

[RFC v7 3/4] eventdev: add atomic atq to test-eventdev app

Add an atomic atq test to the test-eventdev app. The test works in the same way as atomic queue, the difference being that only one queue capable of all types for both stages. Signed-off-by: Luka Jankovic --- app/test-eventdev/meson.build | 1 + app/test-eventdev/test_atomic_atq.c | 216

[RFC v7 2/4] eventdev: add atomic queue test to test-evnetdev app

Add an atomic queue test to the test-eventdev app, which is based on the order queue test that exclusively uses atomic queues. Signed-off-by: Luka Jankovic --- app/test-eventdev/meson.build | 1 + app/test-eventdev/test_atomic_queue.c | 230 ++ 2 files changed,

[RFC v7 1/4] eventdev: atomic common for test-eventdev app

Introduce changes required for atomic tests to run atomic tests. - Producer port maintenance - Common spinlock implementation Signed-off-by: Luka Jankovic --- app/test-eventdev/evt_common.h | 9 ++ app/test-eventdev/meson.build | 1 + app/test-eventdev/test_atomic_common.c

[RFC v7 0/4] eventdev: atomic tests to test-eventdev app

Add atomic tests to the test-eventdev app which correspond to the order tests but use exclusively atomic queues. The test detects if port maintenance is required, and so they are compatible with event devices such as the distributed software eventdev. To verify atomicity, a spinlock is used for e

RE: [PATCH v5 2/4] lib: fix comparison between devices

Hey, Sorry for my late response, I sent a fix (v7): https://patches.dpdk.org/project/dpdk/patch/20250212163836.178976-2-shper...@nvidia.com/ I added another parameter to the parse function - the size of the memory pointed by addr. so the function signature now is: int XXX_parse(const char *name,

Re: [PATCH v9 2/2] net/af_xdp: Refactor af_xdp_tx_zc

Are you expecting anything from me? From what I understood, the series was acked. Still, patchwork labels it as* Change Requested.* http://patches.dpdk.org/project/dpdk/patch/20250207104552.1663519-3-ariel.otilib...@6wind.com/ Let me know, Ariel I was wanting for discussion to end, there seem

RE: [EXTERNAL] [Patch v2] net/mana: use mana_local_data for tracking usage data for primary process

> -Original Message- > From: lon...@linuxonhyperv.com > Sent: Wednesday, February 19, 2025 4:59 AM > To: Stephen Hemminger ; Wei Hu > > Cc: dev@dpdk.org; sta...@dpdk.org; Long Li > Subject: [EXTERNAL] [Patch v2] net/mana: use mana_local_data for tracking > usage data for primary proce

[PATCH v4 2/3] cryptodev: add SM4 GCM

Added support for symmetric algorithm SM4 GCM in cryptodev. Signed-off-by: Brian Dooley --- doc/guides/cryptodevs/features/default.ini | 2 ++ lib/cryptodev/rte_crypto_sym.h | 4 +++- lib/cryptodev/rte_cryptodev.c | 3 ++- 3 files changed, 7 insertions(+), 2 deletions(-)

[PATCH v4 3/3] app/test: add SM4 GCM tests

Added SM4-GCM tests for the AESNI MB PMD. Signed-off-by: Brian Dooley --- v4: Remove MAX_AAD_LENGTH array length from test vectors --- app/test/test_cryptodev.c | 158 + app/test/test_cryptodev_aead_test_vectors.h | 708 2 files changed, 866 ins

[PATCH v4 1/3] crypto/ipsec_mb: add SM4 GCM support

This patch introduces SM4 GCM algorithm support to the AESNI_MB PMD. SM4 GCM is available in the v2.0 release of Intel IPsec MB. Signed-off-by: Brian Dooley --- v2: Added aad to cpu job params Added ipsec mb version checks v3: Fix naming for patchwork v4: Remove cr

RE: [EXTERNAL] [PATCH v3 4/6] trace: support dumping binary inside a struct

> -Original Message- > From: David Marchand > Sent: Tuesday, February 18, 2025 7:58 PM > To: Sunil Kumar Kori ; Jerin Jacob > Cc: dev@dpdk.org; fengcheng...@huawei.com; Kevin Laatz > ; Bruce Richardson ; > Tyler Retzlaff > Subject: Re: [EXTERNAL] [PATCH v3 4/6] trace: support dumping

[PATCH v7 6/8] drivers: reduce driver dependencies

From: Bruce Richardson Remove any unnecessary dependencies from the driver dependency lists. This will give each driver a near-minimum set of required dependencies. Signed-off-by: Bruce Richardson Reviewed-by: Rosen Xu --- drivers/baseband/fpga_5gnr_fec/meson.build | 2 +- drivers/baseband/fp

[PATCH v7 8/8] devtools: add script to generate DPDK dependency graphs

From: Bruce Richardson Rather than the single monolithic graph that would be output from the deps.dot file in a build directory, we can post-process that to generate simpler graphs for different tasks. This new "draw_dependency_graphs" script takes the "deps.dot" as input and generates an output

[PATCH v7 7/8] app: reduce app dependencies

From: Bruce Richardson Remove any unnecessary dependencies from the app dependency lists. This will give each app a near-minimum set of required dependencies. Signed-off-by: Bruce Richardson --- Notes: v6 -> v7: - Fixed test-crypto-perf dependencies app/dumpcap/meson.build | 2 +-

[PATCH v7 4/8] drivers: remove kvargs from class dependencies

From: Bruce Richardson The kvargs library is used by EAL, and therefore is implicitly a dependency of every DPDK driver. Remove it from the minimum set of dependencies for each driver class as it's unnecessary to call it out there. Signed-off-by: Bruce Richardson --- drivers/event/meson.build

[PATCH v7 5/8] lib: reduce library dependencies

From: Bruce Richardson Rather than having each library depend up on EAL + any extra libs, we can take advantage of recursive dependency support in meson and just assign the dependencies of each directory directly, rather than appending to the array. For libraries which only depend upon EAL, keep

[PATCH v7 3/8] devtools: add script to flag unneeded dependencies

From: Bruce Richardson While not a serious problem, DPDK components often list more dependencies than are actually necessary to build, due to the use of recursive dependencies. In extreme cases, such as with core libraries, this can lead to longer configuration times due to meson having to dedupl

[PATCH v7 0/8] Record and rework component dependencies

As part of the meson build, we can record the dependencies for each component as we process it, logging them to a file. This file can be used as input to a number of other scripts and tools, for example, to graph the dependencies, or to allow higher-level build-config tools to automatically enable

[PATCH v7 2/8] build: output a dependency log in build directory

From: Bruce Richardson As meson processes our DPDK source tree it manages dependencies specified by each individual driver. To enable future analysis of the dependency links between components, log the dependencies of each DPDK component as it gets processed. This could potentially allow other to

[PATCH v7 1/8] build: introduce optional internal dependencies

Allow specifying internal dependencies as either mandatory or optional. Specifying a dependency as optional will mean that the component being built will be skipped if said dependency is not being built. At build time, the build system will resolve any optional dependencies and add them to the list

RE: [EXTERNAL] Re: [PATCH v6 7/8] app: reduce app dependencies

> On Wed, Feb 19, 2025 at 11:18:46AM +0100, Morten Brørup wrote: > > > From: Akhil Goyal [mailto:gak...@marvell.com] > > > Sent: Wednesday, 19 February 2025 09.16 > > > > > > Hi David, > > > > Hello, > > > > > > > > Cc: Akhil. > > > > > > > > On Tue, Feb 18, 2025 at 12:16 PM Anatoly Burakov > > > >

Re: [EXTERNAL] Re: [PATCH v6 7/8] app: reduce app dependencies

On Wed, Feb 19, 2025 at 11:18:46AM +0100, Morten Brørup wrote: > > From: Akhil Goyal [mailto:gak...@marvell.com] > > Sent: Wednesday, 19 February 2025 09.16 > > > > Hi David, > > > Hello, > > > > > > Cc: Akhil. > > > > > > On Tue, Feb 18, 2025 at 12:16 PM Anatoly Burakov > > > wrote: > > > > diff

RE: [EXTERNAL] Re: [PATCH v6 7/8] app: reduce app dependencies

> From: Akhil Goyal [mailto:gak...@marvell.com] > Sent: Wednesday, 19 February 2025 09.16 > > Hi David, > > Hello, > > > > Cc: Akhil. > > > > On Tue, Feb 18, 2025 at 12:16 PM Anatoly Burakov > > wrote: > > > diff --git a/app/test-crypto-perf/meson.build b/app/test-crypto- > > perf/meson.build > >

RE: [PATCH] common/qat: fix incorrect size in the parser

> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday 7 February 2025 09:59 > To: dev@dpdk.org > Cc: gak...@marvell.com; Dooley, Brian ; Kusztal, > ArkadiuszX ; sta...@dpdk.org > Subject: [PATCH] common/qat: fix incorrect size in the parser > > The function `strlen` returns t

Re: [PATCH v2 10/10] app: enable app directory to be compiled with MSVC

On Tue, Feb 18, 2025 at 5:33 PM Andre Muezerie wrote: > diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build > index f1c36529b4..8e8863812a 100644 > --- a/app/test-pmd/meson.build > +++ b/app/test-pmd/meson.build > @@ -3,7 +3,9 @@ > > # override default name to drop the hyphen > name

RE: [EXTERNAL] Re: [PATCH v6 7/8] app: reduce app dependencies

Hi David, > Hello, > > Cc: Akhil. > > On Tue, Feb 18, 2025 at 12:16 PM Anatoly Burakov > wrote: > > diff --git a/app/test-crypto-perf/meson.build b/app/test-crypto- > perf/meson.build > > index fb48d9ec29..f056431bf4 100644 > > --- a/app/test-crypto-perf/meson.build > > +++ b/app/test-crypto-per

Re: [PATCH v3 00/10] Remove weak symbols

On Tue, Feb 18, 2025 at 4:37 PM David Marchand wrote: > > This is an alternative to André series: > https://inbox.dpdk.org/dev/1735009552-31906-1-git-send-email-andre...@linux.microsoft.com/ > > Weak symbols can be easily replaced with some linking updates, and make > it clearer which symbols are

Re: [PATCH] ci: build with MSVC in GHA

On Tue, Feb 18, 2025 at 4:36 PM Andre Muezerie wrote: > > > > Add a build target in Windows 2022 for MSVC. > > > > > > > > Loading MSVC environment and having successive commands in a single > > > > (cmd or pwsh) shell does not seem to correctly report if one of the > > > > commands failed. > > >

[PATCH v13 16/28] net/rnp: add MTU set operation

add mtu update limit for multiple port mode. multiple mode just used the max-mtu of ports to limit receive. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 1 + doc/guides/nics/rnp.rst | 1 + drivers/net/rnp/base/rnp_eth_regs.h | 3 + drivers/net/rnp/rnp.h

Re: [PATCH v6 7/8] app: reduce app dependencies

Hello, Cc: Akhil. On Tue, Feb 18, 2025 at 12:16 PM Anatoly Burakov wrote: > diff --git a/app/test-crypto-perf/meson.build > b/app/test-crypto-perf/meson.build > index fb48d9ec29..f056431bf4 100644 > --- a/app/test-crypto-perf/meson.build > +++ b/app/test-crypto-perf/meson.build > @@ -19,7 +19,7

[PATCH v13 28/28] net/rnp: support Rx/Tx burst mode info

add platform method for get rx/tx burst function select by upload func name. Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp_ethdev.c | 2 ++ drivers/net/rnp/rnp_rxtx.c | 58 drivers/net/rnp/rnp_rxtx.h | 6 3 files changed, 66 insertions(+) diff

[PATCH v13 26/28] net/rnp: add support VLAN filters operations

add support to update vid for vlan filter. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 1 + doc/guides/nics/rnp.rst | 3 +- drivers/net/rnp/base/meson.build| 1 + drivers/net/rnp/base/rnp_bitrev.h | 64 ++ drivers/net/rnp/base/rnp_c

[PATCH v13 27/28] net/rnp: add queue info operation

add support get queue configure info for user debug Signed-off-by: Wenbo Cao --- doc/guides/nics/rnp.rst | 2 ++ drivers/net/rnp/rnp_ethdev.c | 2 ++ drivers/net/rnp/rnp_rxtx.c | 42 drivers/net/rnp/rnp_rxtx.h | 4 4 files changed, 50 inserti

[PATCH v13 24/28] net/rnp: add support Tx TSO offload

Add support tx tso and tunnel tso for tunnel just support vxlan/nvgre. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini | 1 + doc/guides/nics/rnp.rst | 1 + drivers/net/rnp/base/rnp_bdq_if.h | 1 + drivers/net/rnp/rnp.h | 2 +- drivers/net/rnp/rnp_eth

[PATCH v13 25/28] net/rnp: support VLAN offloads

add support rx vlan strip,filter,tx vlan/qinq insert. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 2 + doc/guides/nics/rnp.rst | 4 + drivers/net/rnp/base/rnp_bdq_if.h | 2 +- drivers/net/rnp/base/rnp_eth_regs.h | 5 + drivers/net/rnp/base/rnp_hw.h

[PATCH v13 23/28] net/rnp: add support Rx checksum offload

Add support Rx l3/l4 checum and tunnel inner l3/l4, out l3 chksum. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 4 ++ doc/guides/nics/rnp.rst | 1 + drivers/net/rnp/base/rnp_eth_regs.h | 13 drivers/net/rnp/rnp.h | 7 +++ drivers/net/rnp/rn

[PATCH v13 22/28] net/rnp: add supported packet types

add support parse hw packet types result. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini | 1 + doc/guides/nics/rnp.rst | 2 ++ drivers/net/rnp/base/rnp_bdq_if.h | 4 +++ drivers/net/rnp/rnp_ethdev.c | 31 + drivers/net/rnp/rnp_rxtx.c

[PATCH v13 19/28] net/rnp: add support basic stats operation

add support hw-missed rx/tx packets bytes. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 2 + doc/guides/nics/rnp.rst | 3 + drivers/net/rnp/base/rnp_eth_regs.h | 3 + drivers/net/rnp/rnp.h | 8 ++ drivers/net/rnp/rnp_ethdev.c| 136 +

  1   2   >