On Tue, Feb 18, 2025 at 04:41:14PM +0000, Bruce Richardson wrote: > On Tue, Feb 18, 2025 at 08:32:04AM -0800, Andre Muezerie wrote: > > Compiling with MSVC results in warnings like below: > > > > app/test-pmd/cmdline.c(9023): warning C5101: use of preprocessor > > directive in function-like macro argument list is undefined behavior > > > > Signed-off-by: Andre Muezerie <andre...@linux.microsoft.com> > > Signed-off-by: Chengwen Feng <fengcheng...@huawei.com> > > --- > > app/test-pmd/cmdline.c | 15 +++++++++++++-- > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > > index 2afcf916c0..4f0b0340c8 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -9011,6 +9011,18 @@ static void cmd_dump_parsed(void *parsed_result, > > } > > > > static cmdline_parse_token_string_t cmd_dump_dump = > > +#ifdef RTE_EXEC_ENV_WINDOWS > > + TOKEN_STRING_INITIALIZER(struct cmd_dump_result, dump, > > + "dump_physmem#" > > + "dump_memzone#" > > + "dump_socket_mem#" > > + "dump_struct_sizes#" > > + "dump_ring#" > > + "dump_mempool#" > > + "dump_devargs#" > > + "dump_lcores#" > > + "dump_log_types"); > > +#else > > TOKEN_STRING_INITIALIZER(struct cmd_dump_result, dump, > > "dump_physmem#" > > "dump_memzone#" > > @@ -9020,10 +9032,9 @@ static cmdline_parse_token_string_t cmd_dump_dump = > > "dump_mempool#" > > "dump_devargs#" > > "dump_lcores#" > > -#ifndef RTE_EXEC_ENV_WINDOWS > > "dump_trace#" > > -#endif > > "dump_log_types"); > > +#endif > > > > Rather than defining two separate lists, is a better fix not to provide a > dummy implementation of dump_trace for windows, that returns e.g. > TEST_SKIPPED. > > /Bruce
Good suggestion. I'll update the patch accordingly.
