Re: [PATCH v2 1/4] power: refactor core power management library

2024-09-18 Thread lihuisong (C)
在 2024/9/18 16:37, Tummala, Sivaprasad 写道: [AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: lihuisong (C) Sent: Friday, September 13, 2024 1:05 PM To: Tummala, Sivaprasad Cc: dev@dpdk.org; david.h...@intel.com; anatoly.bura...@intel.com; radu.nico...

[PATCH v5] net/ice: support customized search path for DDP package

2024-09-18 Thread Zhichao Zeng
This patch adds support for customizing firmware search path for DDP package like the kernel behavior, it will read the search path from "/sys/module/firmware_class/parameters/path", and try to load DDP package. Also, updates documentation for loading the DDP package in ice.rst. Signed-off-by: Zh

Re: [PATCH v23 11/15] log: add timestamp option

2024-09-18 Thread fengchengwen
On 2024/9/18 23:05, Stephen Hemminger wrote: > On Wed, 18 Sep 2024 15:37:49 +0800 > fengchengwen wrote: > >> ... >> >>> + >>> +static enum { >>> + LOG_TIMESTAMP_NONE = 0, >>> + LOG_TIMESTAMP_TIME, /* time since start */ >>> + LOG_TIMESTAMP_DELTA,/* time since last message */ >>> +

Re: [PATCH v24 06/15] eal: change rte_exit() output to match rte_log()

2024-09-18 Thread fengchengwen
Acked-by: Chengwen Feng On 2024/9/19 4:52, Stephen Hemminger wrote: > The rte_exit() output format confuses the timestamp and coloring > options. Change it to use be a single line with proper prefix. > > Before: > [ 0.006481] EAL: Error - exiting with code: 1 > Cause: [ 0.006489] Canno

Re: [PATCH v24 03/15] windows: add os shim for localtime_r

2024-09-18 Thread fengchengwen
Acked-by: Chengwen Feng On 2024/9/19 4:52, Stephen Hemminger wrote: > Windows does not have localtime_r but it does have a similar > function that can be used instead. > > Signed-off-by: Stephen Hemminger > Acked-by: Tyler Retzlaff > Acked-by: Morten Brørup > Acked-by: Bruce Richardson > ---

[PATCH 6/6] app/testpmd: add jump to table index action

2024-09-18 Thread Alexander Kozyrev
Add a new command line options to create the RTE_FLOW_ACTION_TYPE_JUMP_TO_TABLE_INDEX action from the testpmd command line. flow queue 0 create 0 template_table 0 pattern_template 0 actions_template 0 postpone no pattern eth / end actions jump_to_table_index table 0x166f9ce00 index 5 / end Si

[PATCH 5/6] ethdev: add jump to table index action

2024-09-18 Thread Alexander Kozyrev
Introduce the RTE_FLOW_ACTION_TYPE_JUMP_TO_TABLE_INDEX action. It redirects packets to a particular index in a flow table. Signed-off-by: Alexander Kozyrev --- doc/guides/rel_notes/release_24_11.rst | 4 lib/ethdev/rte_flow.c | 1 + lib/ethdev/rte_flow.h

[PATCH 4/6] app/testpmd: add insertion by index with pattern option

2024-09-18 Thread Alexander Kozyrev
Allow to specify both the rule index and the pattern in the flow rule creation command line parameters. Both are needed for rte_flow_async_create_by_index_with_pattern(). flow queue 0 create 0 template_table 2 rule_index 5 pattern_template 0 actions_template 0 postpone no pattern eth / end act

[PATCH 2/6] app/testpmd: add index with pattern insertion type

2024-09-18 Thread Alexander Kozyrev
Provide index_with_pattern command line option for the template table insertion type. flow template_table 0 create table_id 2 group 13 priority 0 insertion_type index_with_pattern ingress rules_number 64 pattern_template 2 actions_template 2 Signed-off-by: Alexander Kozyrev --- app/test-pmd

[PATCH 3/6] ethdev: add flow rule insertion by index with pattern

2024-09-18 Thread Alexander Kozyrev
Add a new API to enqueue flow rule creation by index with pattern. The new template table rules insertion type, index-based insertion with pattern, requires a new flow rule creation function with both rule index and pattern provided. Packets will match on the provided pattern at the provided index.

[PATCH 0/6] ethdev: jump to table support

2024-09-18 Thread Alexander Kozyrev
Introduce new Flow API JUMP_TO_TABLE_INDEX action. It allows bypassing a hierarchy of groups and going directly to a specified flow table. That gives a user the flexibility to jump between different priorities in a group and eliminates the need to do a table lookup in the group hierarchy. The JUMP_

[PATCH 1/6] ethdev: add insertion by index with pattern

2024-09-18 Thread Alexander Kozyrev
There are two flow table rules insertion type today: pattern-based insertion when packets match on the pattern and index-based insertion when packets always hit at the index. We need another mode that allows to match on the pattern at the index: insertion by index with pattern. Signed-off-by: Alex

RE: [PATCH v2 1/3] eventdev: introduce event pre-scheduling

2024-09-18 Thread Pathak, Pravin
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Tuesday, September 17, 2024 3:11 AM > To: jer...@marvell.com; sthot...@marvell.com; Sevincer, Abdullah > ; hemant.agra...@nxp.com; > sachin.sax...@oss.nxp.com; Van Haaren, Harry ; > mattias.ronnb...@ericsson.com; lian...@lian

[PATCH v24 11/15] log: add timestamp option

2024-09-18 Thread Stephen Hemminger
When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. There are multiple timestamp formats similar to Linux dmesg. The default is time relative since star

[PATCH v24 15/15] doc: add release note about log library

2024-09-18 Thread Stephen Hemminger
Significant enough to add some documentation. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- doc/guides/rel_notes/release_24_11.rst | 27 ++ 1 file changed, 27 insertions(+) diff --git a/doc/guides/rel_n

[PATCH v24 14/15] log: colorize log output

2024-09-18 Thread Stephen Hemminger
Like dmesg, colorize the log output (unless redirected to file). Timestamp is green, the subsystem is in yellow and the message is red if urgent, boldface if an error, and normal for info and debug messages. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Ack

[PATCH v24 13/15] log: add support for systemd journal

2024-09-18 Thread Stephen Hemminger
If DPDK application is being run as a systemd service, then it can use the journal protocol which allows putting more information in the log such as priority and other information. The use of journal protocol is automatically detected and handled. Rather than having a dependency on libsystemd, ju

[PATCH v24 10/15] log: add hook for printing log messages

2024-09-18 Thread Stephen Hemminger
This is useful for when decorating log output for console or journal. Provide basic version in this patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/log/log.c | 6 +- lib/log/log_private.h | 9 + 2 f

[PATCH v24 12/15] log: add optional support of syslog

2024-09-18 Thread Stephen Hemminger
Log to syslog only if option is specified. And if syslog is used then normally only log to syslog, don't duplicate output. Also enables syslog support on FreeBSD. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- app/test/test_eal_

[PATCH v15 0/1] dts: port over VLAN test suite

2024-09-18 Thread Dean Marx
Port over VLAN capabilities test suite from old DTS. This test suite verifies that VLAN filtering, stripping, and header insertion all function as expected. When a VLAN ID is in the filter list, all packets with that ID should be forwarded and all others should be dropped. While stripping is enable

[PATCH v24 09/15] log: drop syslog support, and make code common

2024-09-18 Thread Stephen Hemminger
This patch makes the log setup code common across all platforms. Drops syslog support for now, will come back in later patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- app/test/test_eal_flags.c | 11 ++- lib/eal/common/eal_common_option

[PATCH v24 08/15] eal: initialize log before everything else

2024-09-18 Thread Stephen Hemminger
In order for all log messages (including CPU mismatch) to come out through the logging library, it must be initialized as early in rte_eal_init() as possible on all platforms. Where it was done before was likely historical based on the support of non-OS isolated CPU's which required a shared memor

[PATCH v24 07/15] log: move handling of syslog facility out of eal

2024-09-18 Thread Stephen Hemminger
The syslog facility property is better handled in lib/log rather than in eal. This also allows for changes to what syslog flag means in later steps. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/common/eal_common_option

[PATCH v24 06/15] eal: change rte_exit() output to match rte_log()

2024-09-18 Thread Stephen Hemminger
The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with co

[PATCH v24 05/15] eal: do not duplicate rte_init_alert() messages

2024-09-18 Thread Stephen Hemminger
The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/freebsd/

[PATCH v24 03/15] windows: add os shim for localtime_r

2024-09-18 Thread Stephen Hemminger
Windows does not have localtime_r but it does have a similar function that can be used instead. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/eal/windows/include/rte_os_shim.h | 10 ++ 1 file changed, 10 insertions

[PATCH v24 04/15] eal: make eal_log_level_parse common

2024-09-18 Thread Stephen Hemminger
The code to parse for log-level option should be same on all OS variants. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/eal/common/eal_common_options.c | 40 +++ lib/eal/common/eal_options.h

[PATCH v24 02/15] windows: make getopt functions have const properties

2024-09-18 Thread Stephen Hemminger
Having different prototypes on different platforms can lead to lots of unnecessary workarounds. Looks like the version of getopt used from windows was based on an older out of date version from FreeBSD. This patch changes getopt, getopt_long, etc to have the same const attributes as Linux and Fre

[PATCH v24 00/15] Logging enhancements for 24.11

2024-09-18 Thread Stephen Hemminger
Improvements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of

[PATCH v24 01/15] maintainers: add for log library

2024-09-18 Thread Stephen Hemminger
"You touch it you own it" Add myself as maintainer for log library. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Bruce Richardson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINE

[PATCH v15] dts: VLAN test suite implementation

2024-09-18 Thread Dean Marx
Test suite for verifying VLAN filtering, stripping, and insertion functionality on Poll Mode Driver. Depends-on: Patch-143966 ("dts: add VLAN methods to testpmd shell") Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestS

[PATCH v15 1/1] dts: VLAN test suite implementation

2024-09-18 Thread Dean Marx
Test suite for verifying VLAN filtering, stripping, and insertion functionality on Poll Mode Driver. Depends-on: Patch-143966 ("dts: add VLAN methods to testpmd shell") Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestS

[PATCH v15 0/1] dts: port over VLAN test suite

2024-09-18 Thread Dean Marx
Port over VLAN capabilities test suite from old DTS. This test suite verifies that VLAN filtering, stripping, and header insertion all function as expected. When a VLAN ID is in the filter list, all packets with that ID should be forwarded and all others should be dropped. While stripping is enable

[PATCH] net/gve: add ptype parsing to DQ format

2024-09-18 Thread Joshua Washington
Currently, the packet type is parsed as part of adding the checksum-related ol_flags for a received packet, but the parsed information is not added to the mbuf. This change adds the parsed ptypes to the mbuf and updates the RX checksum validation to rely on the mbuf instead of re-capturing the pty

[PATCH v3] dts: correct typos in user config docstrings

2024-09-18 Thread Dean Marx
Correct docstring error in conf.yaml showing incorrect example pci address for TG nodes. Fixes: 55442c14297c ("dts: improve documentation") Signed-off-by: Dean Marx Reviewed-by: Nicholas Pratte Reviewed-by: Luca Vizzarro Reviewed-by: Jeremy Spewock Reviewed-by: Juraj Linkeš --- dts/conf.yam

[PATCH v2] dts: add package mode config and updated docs

2024-09-18 Thread Dean Marx
In the current DTS setup description, the user installs poetry with the --no-root option. However, adding 'package-mode = false' to the pyproject.toml sets the same configuration, and running poetry install --no-root will become an error in a future poetry version. Signed-off-by: Dean Marx Review

[PATCH v2] dts: add VLAN methods to testpmd shell

2024-09-18 Thread Dean Marx
added the following methods to testpmd shell class: vlan set filter on/off, rx vlan add/rm, vlan set strip on/off, tx vlan set/reset, set promisc/verbose Fixes: 61d5bc9bf974 ("dts: add port info command to testpmd shell") Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.p

Re: [PATCH 1/1] dts: add binding to different drivers to TG node

2024-09-18 Thread Jeremy Spewock
On Mon, Sep 16, 2024 at 6:04 AM Juraj Linkeš wrote: > > > > On 9. 9. 2024 17:55, Jeremy Spewock wrote: > > On Mon, Sep 9, 2024 at 8:16 AM Juraj Linkeš > > wrote: > >> > >> > >> > >> On 12. 8. 2024 19:22, jspew...@iol.unh.edu wrote: > >>> From: Jeremy Spewock > >>> > >>> The DTS framework in its

[PATCH v3] ethdev: optimize the activation of fast-path tracepoints

2024-09-18 Thread Adel Belkhiri
From: Adel Belkhiri Split the tracepoints rte_ethdev_trace_rx_burst and rte_eth_trace_call_rx_callbacks into two separate ones for empty and non-empty calls to avoid saturating quickly the trace buffer. Signed-off-by: Adel Belkhiri --- .mailmap | 1 + doc/guides/

[PATCH v5 0/1] dts: testpmd verbose parser

2024-09-18 Thread jspewock
From: Jeremy Spewock v5: * fix typo Jeremy Spewock (1): dts: add text parser for testpmd verbose output dts/framework/remote_session/testpmd_shell.py | 525 +- dts/framework/utils.py| 6 + 2 files changed, 529 insertions(+), 2 deletions(-) -- 2.46

[PATCH v5 1/1] dts: add text parser for testpmd verbose output

2024-09-18 Thread jspewock
From: Jeremy Spewock Multiple test suites from the old DTS framework rely on being able to consume and interpret the verbose output of testpmd. The new framework doesn't have an elegant way for handling the verbose output, but test suites are starting to be written that rely on it. This patch cre

Re: [PATCH v3 11/12] dts: add Rx offload capabilities

2024-09-18 Thread Jeremy Spewock
On Wed, Sep 18, 2024 at 10:27 AM Juraj Linkeš wrote: > > > > On 29. 8. 2024 17:40, Jeremy Spewock wrote: > > On Wed, Aug 28, 2024 at 1:44 PM Jeremy Spewock wrote: > >> > >> On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš > >> wrote: > >> > >>> diff --git a/dts/framework/remote_session/testpmd_she

Re: [PATCH v3 11/12] dts: add Rx offload capabilities

2024-09-18 Thread Jeremy Spewock
On Wed, Sep 18, 2024 at 10:18 AM Juraj Linkeš wrote: > > > > On 26. 8. 2024 19:24, Jeremy Spewock wrote: > > On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš > > wrote: > > > >> diff --git a/dts/framework/remote_session/testpmd_shell.py > >> b/dts/framework/remote_session/testpmd_shell.py > >> ind

Re: [PATCH v3 08/12] dts: add NIC capability support

2024-09-18 Thread Jeremy Spewock
On Wed, Sep 18, 2024 at 8:58 AM Juraj Linkeš wrote: > > > > On 27. 8. 2024 18:36, Jeremy Spewock wrote: > > On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš > > wrote: > > > >> diff --git a/dts/framework/testbed_model/capability.py > >> b/dts/framework/testbed_model/capability.py > >> index 8899f0

[PATCH v4 1/1] dts: add text parser for testpmd verbose output

2024-09-18 Thread jspewock
From: Jeremy Spewock Multiple test suites from the old DTS framework rely on being able to consume and interpret the verbose output of testpmd. The new framework doesn't have an elegant way for handling the verbose output, but test suites are starting to be written that rely on it. This patch cre

[PATCH v4 0/1] dts: testpmd verbose parser

2024-09-18 Thread jspewock
From: Jeremy Spewock v4: * adjust name of OLFlags class to be PacketOffloadFlags * change values in PacketOffloadFlags to match the ones in rte_mbuf_core.h * added documentation from rte_mbuf_core.h to flag values * added documentation from rte_mbuf_ptype.h to the RtePTypes class

[PATCH v2] ethdev: optimize the activation of fast-path tracepoints

2024-09-18 Thread Adel Belkhiri
From: Adel Belkhiri Split the tracepoints rte_ethdev_trace_rx_burst and rte_eth_trace_call_rx_callbacks into two separate ones for empty and non-empty calls to avoid saturating quickly the trace buffer. Signed-off-by: Adel Belkhiri --- .mailmap | 1 + doc/guides/

Re: [PATCH] eal/alarm_cancel: Fix thread starvation

2024-09-18 Thread Stephen Hemminger
On Wed, 18 Sep 2024 13:39:06 +0200 Wojciech Panfil wrote: > Issue: > Two threads: > > - A, executing rte_eal_alarm_cancel, > - B, executing eal_alarm_callback. > > Such case can cause starvation of thread B. Please see that there is a > small time window between lock and unlock in thread A, so

Re: [PATCH v23 04/15] eal: make eal_log_level_parse common

2024-09-18 Thread Stephen Hemminger
On Wed, 18 Sep 2024 15:18:04 +0800 fengchengwen wrote: > > +/* Parse the all arguments looking for log related ones */ > > +int > > +eal_log_level_parse(int argc, char * const argv[]) > > +{ > > + struct internal_config *internal_conf = > > eal_get_internal_configuration(); > > + int option_

Re: [DPDK/core Bug 1547] Build fails on FreeBSD 14.0

2024-09-18 Thread Stephen Hemminger
On Wed, 18 Sep 2024 09:31:19 +0100 Bruce Richardson wrote: > On Wed, Sep 18, 2024 at 01:51:18AM +, bugzi...@dpdk.org wrote: > >[1]Stephen Hemminger changed [2]bug 1547 > > > > What Removed Added > >Status UNCONFIRMED RESOLVED > >Resolution --- INVALID >

Re: [PATCH v23 11/15] log: add timestamp option

2024-09-18 Thread Stephen Hemminger
On Wed, 18 Sep 2024 15:37:49 +0800 fengchengwen wrote: > ... > > > + > > +static enum { > > + LOG_TIMESTAMP_NONE = 0, > > + LOG_TIMESTAMP_TIME, /* time since start */ > > + LOG_TIMESTAMP_DELTA,/* time since last message */ > > + LOG_TIMESTAMP_RELTIME, /* relative time since last

Re: [PATCH v3 11/12] dts: add Rx offload capabilities

2024-09-18 Thread Juraj Linkeš
On 29. 8. 2024 17:40, Jeremy Spewock wrote: On Wed, Aug 28, 2024 at 1:44 PM Jeremy Spewock wrote: On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py index 48c31124d1..f83569669e

Re: [PATCH v3 11/12] dts: add Rx offload capabilities

2024-09-18 Thread Juraj Linkeš
On 26. 8. 2024 19:24, Jeremy Spewock wrote: On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py index 48c31124d1..f83569669e 100644 --- a/dts/framework/remote_session/testpmd_shell.p

[PATCH] crypto/scheduler: fix incorrect variable usage

2024-09-18 Thread Yong Liang
The variable `pending_deq_ops` was incorrectly used instead of `pending_enq_ops`. This causes the program to crash when the worker PMD accesses the session Bugzilla ID: 1537 Fixes: 6812b9bf470e ("crypto/scheduler: use unified session") Cc: roy.fan.zh...@intel.com Signed-off-by: Yong Liang <126969

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-18 Thread Jeremy Spewock
On Wed, Sep 18, 2024 at 3:57 AM Juraj Linkeš wrote: > > > > diff --git a/dts/Dockerfile b/dts/Dockerfile > > > @@ -24,9 +27,12 @@ FROM base AS runner > > > +# Adds ~/.local/bin to PATH so that packages installed with pipx are > > callable. `pipx ensurepath` > > +# fixes this issue, but requires t

Re: [PATCH v3 11/12] dts: add Rx offload capabilities

2024-09-18 Thread Juraj Linkeš
On 3. 9. 2024 21:49, Dean Marx wrote: On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: The scatter Rx offload capability is needed for the pmd_buffer_scatter test suite. The command that retrieves the capability is: show port rx_offload capabilities The command also re

RE: [PATCH v2 9/9] net/mlx5: fix flex item header length field translation

2024-09-18 Thread Dariusz Sosnowski
> -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, September 18, 2024 15:46 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Dariusz Sosnowski > ; sta...@dpdk.org > Subject: [PATCH v2 9/9] net/mlx5: fix flex item header length field > translation > >

RE: [PATCH v2 8/9] net/mlx5: fix non full word sample fields in flex item

2024-09-18 Thread Dariusz Sosnowski
> -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, September 18, 2024 15:46 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Dariusz Sosnowski > ; sta...@dpdk.org > Subject: [PATCH v2 8/9] net/mlx5: fix non full word sample fields in flex item > > If t

RE: [PATCH v2 7/9] net/mlx5: fix next protocol validation after flex item

2024-09-18 Thread Dariusz Sosnowski
> -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, September 18, 2024 15:46 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Dariusz Sosnowski > ; sta...@dpdk.org > Subject: [PATCH v2 7/9] net/mlx5: fix next protocol validation after flex item > > On t

RE: [PATCH v2 6/9] app/testpmd: remove flex item init command leftover

2024-09-18 Thread Dariusz Sosnowski
> -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, September 18, 2024 15:46 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Dariusz Sosnowski > > Subject: [PATCH v2 6/9] app/testpmd: remove flex item init command leftover > > There was a leftover of

RE: [PATCH v2 5/9] net/mlx5: fix number of supported flex parsers

2024-09-18 Thread Dariusz Sosnowski
> -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, September 18, 2024 15:46 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Dariusz Sosnowski > ; sta...@dpdk.org > Subject: [PATCH v2 5/9] net/mlx5: fix number of supported flex parsers > > The hardware

RE: [PATCH v2 4/9] net/mlx5: fix flex item tunnel mode handling

2024-09-18 Thread Dariusz Sosnowski
> -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, September 18, 2024 15:46 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Dariusz Sosnowski > ; sta...@dpdk.org > Subject: [PATCH v2 4/9] net/mlx5: fix flex item tunnel mode handling > > The RTE flex i

RE: [PATCH v2 3/9] net/mlx5/hws: fix flex item support as tunnel header

2024-09-18 Thread Dariusz Sosnowski
> -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, September 18, 2024 15:46 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Dariusz Sosnowski > ; sta...@dpdk.org > Subject: [PATCH v2 3/9] net/mlx5/hws: fix flex item support as tunnel header > > The RT

RE: [PATCH v2 2/9] net/mlx5: add flex item query tunnel mode routine

2024-09-18 Thread Dariusz Sosnowski
> -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, September 18, 2024 15:46 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Dariusz Sosnowski > > Subject: [PATCH v2 2/9] net/mlx5: add flex item query tunnel mode routine > > Once parsing the RTE item

RE: [PATCH v2 1/9] net/mlx5: update flex parser arc types support

2024-09-18 Thread Dariusz Sosnowski
> -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, September 18, 2024 15:46 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Dariusz Sosnowski > > Subject: [PATCH v2 1/9] net/mlx5: update flex parser arc types support > > Add support for input IPv4 and f

Minutes of Technical Board meeting 21-August-2024

2024-09-18 Thread Morten Brørup
Members Attending = Aaron Conole Hemant Agrawal Honappa Nagarahalli Kevin Traynor Konstantin Ananyev Maxime Coquelin Morten Brørup (chair) Stephen Hemminger NOTE The technical board meetings are on every second Wednesday at 3 pm UTC. Meetings are public. DPDK community members

RE: [PATCH v2 0/9] net/mlx5: cumulative fix series for flex item

2024-09-18 Thread Dariusz Sosnowski
> -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, September 18, 2024 15:46 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Dariusz Sosnowski > > Subject: [PATCH v2 0/9] net/mlx5: cumulative fix series for flex item > > There is a series of independent

[PATCH v2 9/9] net/mlx5: fix flex item header length field translation

2024-09-18 Thread Viacheslav Ovsiienko
There are hardware imposed limitations on the header length field description for the mask and shift combinations in the FIELD_MODE_OFFSET mode. The patch updates: - parameter check for FIELD_MODE_OFFSET for the header length field - check whether length field crosses dword boundaries in h

[PATCH v2 8/9] net/mlx5: fix non full word sample fields in flex item

2024-09-18 Thread Viacheslav Ovsiienko
If the sample field in flex item did not cover the entire 32-bit word (width was not verified 32 bits) or was not aligned on the byte boundary the match on this sample in flows happened to be ignored or wrongly missed. The field mask "def" was build in wrong endianness, and non-byte aligned shifts

[PATCH v2 7/9] net/mlx5: fix next protocol validation after flex item

2024-09-18 Thread Viacheslav Ovsiienko
On the flow validation some items may check the preceding protocols. In case of flex item the next protocol is opaque (or can be multiple ones) we should set neutral value and allow successful validation, for example, for the combination of flex and following ESP items. Fixes: a23e9b6e3ee9 ("net/m

[PATCH v2 6/9] app/testpmd: remove flex item init command leftover

2024-09-18 Thread Viacheslav Ovsiienko
There was a leftover of "flow flex init" command used for debug purposes and had no useful functionality in the production code. Signed-off-by: Viacheslav Ovsiienko --- app/test-pmd/cmdline_flow.c | 12 1 file changed, 12 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/

[PATCH v2 5/9] net/mlx5: fix number of supported flex parsers

2024-09-18 Thread Viacheslav Ovsiienko
The hardware supports up to 8 flex parser configurations. Some of them can be utilized internally by firmware, depending on the configured profile ("FLEX_PARSER_PROFILE_ENABLE" in NV-setting). The firmware does not report in capabilities how many flex parser configuration is remaining available (th

[PATCH v2 4/9] net/mlx5: fix flex item tunnel mode handling

2024-09-18 Thread Viacheslav Ovsiienko
The RTE flex item can represent tunnel header itself, and split inner and outer items, it should be reflected in the item flags while PMD is processing the item array. Fixes: 8c0ca7527bc8 ("net/mlx5/hws: support flex item matching") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- dr

[PATCH v2 3/9] net/mlx5/hws: fix flex item support as tunnel header

2024-09-18 Thread Viacheslav Ovsiienko
The RTE flex item can represent the tunnel header and split the inner and outer layer items. HWS did not support this flex item specifics. Fixes: 8c0ca7527bc8 ("net/mlx5/hws: support flex item matching") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/hws/mlx5dr_def

[PATCH v2 2/9] net/mlx5: add flex item query tunnel mode routine

2024-09-18 Thread Viacheslav Ovsiienko
Once parsing the RTE item array the PMD needs to know whether the flex item represents the tunnel header. The appropriate tunnel mode query API is added. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.h | 2 ++ drivers/net/mlx5/mlx5_flow_flex.c | 27

[PATCH v2 1/9] net/mlx5: update flex parser arc types support

2024-09-18 Thread Viacheslav Ovsiienko
Add support for input IPv4 and for ESP output flex parser arcs. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_flex.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_flex.c b/drivers/net/mlx5/mlx5_flow_flex.c index 8a0224

[PATCH v2 0/9] net/mlx5: cumulative fix series for flex item

2024-09-18 Thread Viacheslav Ovsiienko
There is a series of independent patches related to the flex item. There is no direct dependency between patches besides the merging dependency inferred by git, the latter is reason the patches are sent in series. For more details, please see the individual patch commit messages. Signed-off-by: Vi

Re: [PATCH v3 08/12] dts: add NIC capability support

2024-09-18 Thread Juraj Linkeš
On 27. 8. 2024 18:36, Jeremy Spewock wrote: On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: diff --git a/dts/framework/testbed_model/capability.py b/dts/framework/testbed_model/capability.py index 8899f07f76..9a79e6ebb3 100644 --- a/dts/framework/testbed_model/capability.py +++ b/dts/

Re: [PATCH v6 1/6] dpdk: do not force C linkage on include file dependencies

2024-09-18 Thread Bruce Richardson
On Wed, Sep 18, 2024 at 02:09:26PM +0200, Mattias Rönnblom wrote: > On 2024-09-18 13:15, David Marchand wrote: > > On Tue, Sep 17, 2024 at 11:30 AM Mattias Rönnblom > > wrote: > > > > > > On 2024-09-16 14:05, David Marchand wrote: > > > > Hello, > > > > > > > > On Tue, Sep 10, 2024 at 10:41 AM

Re: [PATCH v6 1/6] dpdk: do not force C linkage on include file dependencies

2024-09-18 Thread Mattias Rönnblom
On 2024-09-18 13:15, David Marchand wrote: On Tue, Sep 17, 2024 at 11:30 AM Mattias Rönnblom wrote: On 2024-09-16 14:05, David Marchand wrote: Hello, On Tue, Sep 10, 2024 at 10:41 AM Mattias Rönnblom wrote: diff --git a/lib/acl/rte_acl_osdep.h b/lib/acl/rte_acl_osdep.h index 3c1dc402ca..e4

[PATCH] eal/alarm_cancel: Fix thread starvation

2024-09-18 Thread Wojciech Panfil
Issue: Two threads: - A, executing rte_eal_alarm_cancel, - B, executing eal_alarm_callback. Such case can cause starvation of thread B. Please see that there is a small time window between lock and unlock in thread A, so thread B must be switched to within a very small time window, so that it can

Re: [PATCH v6 1/6] dpdk: do not force C linkage on include file dependencies

2024-09-18 Thread David Marchand
On Tue, Sep 17, 2024 at 11:30 AM Mattias Rönnblom wrote: > > On 2024-09-16 14:05, David Marchand wrote: > > Hello, > > > > On Tue, Sep 10, 2024 at 10:41 AM Mattias Rönnblom > > wrote: > >> diff --git a/lib/acl/rte_acl_osdep.h b/lib/acl/rte_acl_osdep.h > >> index 3c1dc402ca..e4c7d07c69 100644 > >>

Re: 21.11.8 patches review and test

2024-09-18 Thread Kevin Traynor
On 18/09/2024 08:50, Ali Alnubani wrote: >> -Original Message- >> From: Kevin Traynor >> Sent: Thursday, September 5, 2024 3:38 PM >> To: sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; Ali >> Alnubani ; David Christensen ; >> Hemant Agrawal ; Ian Stokes >> ; Jerin Jacob ; John McN

RE: [PATCH] eal: add build-time option to omit trace

2024-09-18 Thread Morten Brørup
> From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Wednesday, 18 September 2024 11.50 to omit trace > > On Wed, Sep 18, 2024 at 2:39 PM Morten Brørup > wrote: > > > > Some applications want to omit the trace feature. > > Either to reduce the memory footprint, to reduce the exposed attack

[RFC v2 1/1] dmadev: support priority configuration

2024-09-18 Thread Vamsi Krishna
From: Vamsi Attunuru Some DMA controllers offer the ability to configure priority level for the hardware command queues, allowing for the prioritization of DMA command execution based on queue importance. This patch introduces the necessary fields in the dmadev structures to retrieve information

Re: [PATCH v2 1/6] eal: add static per-lcore memory allocation facility

2024-09-18 Thread Jerin Jacob
On Thu, Sep 12, 2024 at 8:52 PM Jerin Jacob wrote: > > On Thu, Sep 12, 2024 at 7:11 PM Morten Brørup > wrote: > > > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > > Sent: Thursday, 12 September 2024 15.17 > > > > > > On Thu, Sep 12, 2024 at 2:40 PM Morten Brørup > > > wrote: > > > > >

Re: [PATCH v3 3/7] eal: add lcore variable performance test

2024-09-18 Thread Jerin Jacob
On Mon, Sep 16, 2024 at 4:20 PM Mattias Rönnblom wrote: > > On 2024-09-13 13:23, Jerin Jacob wrote: > > On Fri, Sep 13, 2024 at 12:17 PM Mattias Rönnblom > > wrote: > >> > >> On 2024-09-12 17:11, Jerin Jacob wrote: > >>> On Thu, Sep 12, 2024 at 6:50 PM Mattias Rönnblom > >>> wrote: > > >>

Re: [PATCH] eal: add build-time option to omit trace

2024-09-18 Thread Jerin Jacob
On Wed, Sep 18, 2024 at 2:39 PM Morten Brørup wrote: > > Some applications want to omit the trace feature. > Either to reduce the memory footprint, to reduce the exposed attack > surface, or for other reasons. > > This patch adds an option in rte_config.h to include or omit trace in the > build.

[RFC v1 1/1] dmadev: support priority configuration

2024-09-18 Thread Vamsi Krishna
From: Vamsi Attunuru Some DMA controllers offer the ability to configure priority level for the hardware command queues, allowing for the prioritization of DMA command execution based on queue importance. This patch introduces the necessary fields in the dmadev structures to retrieve information

Re: [PATCH v7 0/7] Lcore variables

2024-09-18 Thread fengchengwen
Series-acked-by: Chengwen Feng On 2024/9/18 16:26, Mattias Rönnblom wrote: > This patch set introduces a new API for static > per-lcore id data allocation. > > Please refer to the API documentation for both a > rationale for this new API, and a comparison to the alternatives > available. > >

Re: [PATCH v3 02/19] net/xsc: add log macro

2024-09-18 Thread WanRenyong
On 2024/9/18 16:56, David Marchand wrote: > On Wed, Sep 18, 2024 at 8:10 AM WanRenyong wrote: >> Add log macro to print runtime messages and trace functions. >> >> Signed-off-by: WanRenyong >> >> --- >> >> v3: >> * use RTE_LOG_LINE_PREFIX instead of rte_log >> --- >> drivers/net/xsc/xsc_ethdev.

RE: [EXTERNAL] [PATCH 1/2] net: add thread-safe crc api

2024-09-18 Thread Singh, Jasvinder
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, September 18, 2024 6:58 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org; > Singh, Jasvinder > Cc: Ji, Kai ; Dooley, Brian ; Ferruh > Yigit > Subject: RE: [EXTERNAL] [PATCH 1/2] net: add thread-safe crc api > > > The current net C

RE: [PATCH v7 1/7] eal: add static per-lcore memory allocation facility

2024-09-18 Thread Konstantin Ananyev
> Introduce DPDK per-lcore id variables, or lcore variables for short. > > An lcore variable has one value for every current and future lcore > id-equipped thread. > > The primary use case is for statically allocating > small, frequently-accessed data structures, for which one instance > shoul

[RFC 2/4] ethdev: omit promiscuous config restore if not required

2024-09-18 Thread Dariusz Sosnowski
This patch adds a new device flag - RTE_ETH_DEV_PROMISC_FORCE_RESTORE. If device driver sets this flag, then it requires that ethdev library forcefully reapplies promiscuous mode configuration, after the port is started. As a result, unnecessary work can be removed from rte_eth_dev_start() for driv

[RFC 3/4] ethdev: omit all multicast config restore if not required

2024-09-18 Thread Dariusz Sosnowski
This patch adds a new device flag - RTE_ETH_DEV_ALLMULTI_FORCE_RESTORE. If device driver sets this flag, then it requires that ethdev library forcefully reapplies allmulticast configration, after the port is started. As a result, unnecessary work can be removed from rte_eth_dev_start() for drivers

[RFC 4/4] ethdev: omit MAC address restore if not required

2024-09-18 Thread Dariusz Sosnowski
This patch adds a new device flag - RTE_ETH_DEV_MAC_ADDR_FORCE_RESTORE. If device driver sets this flag, then it requires that ethdev library forcefully reapplies configured MAC addresses, after the port is started. As a result, unnecessary work can be removed from rte_eth_dev_start() for drivers w

[RFC 1/4] ethdev: rework config restore

2024-09-18 Thread Dariusz Sosnowski
Extract promiscuous and all multicast configuration restore to separate functions. This change will allow easier integration of disabling these procedures for supporting PMDs in follow up commits. Signed-off-by: Dariusz Sosnowski --- lib/ethdev/rte_ethdev.c | 34 +

[RFC 0/4] ethdev: rework config restore

2024-09-18 Thread Dariusz Sosnowski
Hi all, We have been working on optimizing the latency of calls to rte_eth_dev_start(), on ports spawned by mlx5 PMD. Most of the work requires changes in the implementation of .dev_start() PMD callback, but I also wanted to start a discussion regarding configuration restore. rte_eth_dev_start()

[PATCH v9 4/6] eal: add atomic bit operations

2024-09-18 Thread Mattias Rönnblom
Add atomic bit test/set/clear/assign/flip and test-and-set/clear/assign/flip functions. All atomic bit functions allow (and indeed, require) the caller to specify a memory order. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston --

[PATCH v9 6/6] eal: extend bitops to handle volatile pointers

2024-09-18 Thread Mattias Rönnblom
Have rte_bit_[test|set|clear|assign|flip]() and rte_bit_atomic_*() handle volatile-marked pointers. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Jack Bond-Preston -- PATCH v3: * Updated to reflect removed 'fun' parameter in __RTE_GEN_BIT_*() (Jack Bond-Preston). PATC

  1   2   >