[PATCH 1/1] examples/l2fwd-jobstats: add delay to show stats

2024-07-25 Thread Rakesh Kudurumalla
In main_loop function only one lock is acquired before fwd jobs has started and finished and then lock is released. Due to this most of the time lock is not available for show_lcore_stats() as a result stats are not updated periodically. This patch fixes the same by adding delay before accquring lo

[PATCH] net/mlx5: fix NVGRE item validation for template API

2024-07-25 Thread Jiawei Wang
The template API NVGRE item can support full mask. This patch updates default NVGRE item mask for the template API. Fixes: 80c676259a04 ("net/mlx5: validate HWS template items") Cc: sta...@dpdk.org Signed-off-by: Jiawei Wang Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow.c | 13 +++

Re: How does CI system get updated?

2024-07-25 Thread Patrick Robb
Hi Stephen, This is a UNH Lab system. We review our systems for updates once every 4 months. The idea is we do it early in each DPDK release's development cycle. So, we update Dockerfiles (for container environments), we apply updates where needed to persistent systems (for VMs, or baremetal serv

[DPDK/DTS Bug 1500] Create process for adding VFs

2024-07-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1500 Bug ID: 1500 Summary: Create process for adding VFs Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priori

[PATCH] doc: fix dma perf typo

2024-07-25 Thread Amit Prakash Shukla
Fixing typo in command line arguments for dma perf application. Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test") Cc: sta...@dpdk.org Signed-off-by: Amit Prakash Shukla --- doc/guides/tools/dmaperf.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/gu

Community CI Meeting Minutes - July 25, 2024

2024-07-25 Thread Patrick Robb
# July 25, 2024 Attendees 1. Patrick Robb 2. Jeremy Spewock 3. Juraj Linkeš 4. Aaron Conole 5. Adam Hassick 6. Dean Marx 7. Luca Vizzarro 8. Manit Mahajan 9. Paul Szczepanek 10. Tomas Durovec ##

Re: [PATCH dpdk v2] rel_notes: announce 24.11 ipv6 api breakage

2024-07-25 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 23/07/2024 09:27, Robin Jarry wrote: In 24.11, all IPv6 public APIs will be modified to use a structure instead of fixed size arrays. Signed-off-by: Robin Jarry Acked-by: Morten Brørup --- Notes: v2: updated with the exhaustive list of symbols doc/gui

Re: fib{,6}: questions and proposals

2024-07-25 Thread Medvedkin, Vladimir
Hi Robin, Apologies for the delayed response On 19/03/2024 20:38, Robin Jarry wrote: Hi Vladimir, Medvedkin, Vladimir, Mar 19, 2024 at 18:16: > 2) Is it OK/safe to modify a fib from a control thread (read/write) >    while it is used by data path threads (read only)? This part is a bit more

[PATCH] baseband/fpga_5gnr_fec: remove useless cast

2024-07-25 Thread Stephen Hemminger
The rte_pktmbuf_mtod_offset macro already includes a type cast so casting the result just adds extra cast. Found by cocci/mtod-offset.cocci Signed-off-by: Stephen Hemminger --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

[PATCH] eventdev: do not use zero length arrays

2024-07-25 Thread Stephen Hemminger
Zero length array's are a GNU C extension and should be replaced by use of flexible arrayrs. This has been fixed almost everywhere in DPDK 24.07 but looks like some event code got missed. Generated by devtools/cocci/zero_length_array.cocci Signed-off-by: Stephen Hemminger --- drivers/event/opdl

[RFC v1 3/3] dts: conf schema VXLAN gpe support

2024-07-25 Thread Dean Marx
Configuration schema to run vxlan gpe support test suite Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index f0

[RFC v1 2/3] dts: VXLAN gpe support test suite

2024-07-25 Thread Dean Marx
Test suite for verifying vxlan gpe support on NIC, as well as expected behavior while sending vxlan packets through tunnel Signed-off-by: Dean Marx --- dts/tests/TestSuite_vxlan_gpe_support.py | 77 1 file changed, 77 insertions(+) create mode 100644 dts/tests/TestSuite

[RFC v1 1/3] dts: add UDP tunnel command to testpmd shell

2024-07-25 Thread Dean Marx
add udp_tunnel_port command to testpmd shell class, also ports over set verbose method from vlan suite Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 51 ++- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/dts/framework/remote_session/t

[RFC v1 0/3] VXLAN-GPE test suite

2024-07-25 Thread Dean Marx
This test suite and the supporting testpmd shell changes originate from an old dts test plan called "vxlan_gpe_support_in_i40e", and the necessary testpmd commands to run the suite are only fully supported on the i40e NICs I have tested on (bnxt and mlx5 NICs don't support.) However, VXLAN-GPE tunn

Question regarding the status of Hotplug on multi-processes

2024-07-25 Thread Brandes, Shai
Hi all, I hope this email finds you well. We would like to understand the status of Hotplug on multi-processes: - 18.11 RN https://doc.dpdk.org/guides-23.11/rel_notes/release_18_11.html states that it added support for device multi-process hotplug. - DTS test plan https://doc.dpdk.org/dts/test_p

RE: [PATCH] doc: announce cryptodev changes to offload RSA in VirtIO

2024-07-25 Thread Gowrishankar Muthukrishnan
Hi ArkadiuszX, > + > +* cryptodev: The struct rte_crypto_rsa_padding will be moved from > + rte_crypto_rsa_op_param struct to rte_crypto_rsa_xform struct, > + breaking ABI. The new location is recommended to comply with > + virtio-crypto specification. Applications and drivers using > +

RE: [PATCH] doc: announce cryptodev changes to offload RSA in VirtIO

2024-07-25 Thread Gowrishankar Muthukrishnan
> +* cryptodev: The struct rte_crypto_rsa_padding will be moved from > + rte_crypto_rsa_op_param struct to rte_crypto_rsa_xform struct, > + breaking ABI. The new location is recommended to comply with > + virtio-crypto specification. Applications and drivers using > + this struct will be up

RE: [PATCH v2] doc: announce rte_ipsec API changes

2024-07-25 Thread Konstantin Ananyev
> > > > > In case of event mode operations where event device can help in > > > > > atomic sequence number increment across cores, sequence number > > > > > need to be provided by the application instead of being updated in > > > > > rte_ipsec or the PMD. To support this, a new flag > > > > > ``

RE: [PATCH] doc: announce cryptodev change to support EDDSA

2024-07-25 Thread Kusztal, ArkadiuszX
> Announce the additions in cryptodev ABI to support EDDSA algorithm. > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Arkadiusz Kusztal

How does CI system get updated?

2024-07-25 Thread Stephen Hemminger
This warning is due to a very old version of Mingw installed in CI system. 20 line log output for Windows Server 2019 (dpdk_mingw64_compile): In file included from ..\lib\net/rte_ip.h:21, from ../lib/net/rte_dissect.c:20: C:/mingw64/mingw64/x86_64-w64-mingw32/include/ws2tcpip.h:447:63

Re: [PATCH v1 2/3] dts: add dual_vlan testing suite

2024-07-25 Thread Jeremy Spewock
On Mon, Jul 22, 2024 at 1:38 PM Dean Marx wrote: >> >> >> +recv = self.send_packet_and_capture(pakt) >> +self.verify(len(recv) > 0, "Did not receive and packets when >> testing VLAN priority.") > > > I'm assuming this should say "any" instead of "and." Other than that, > everyth

[PATCH v2] net/gve: Fix TX/RX queue setup and stop

2024-07-25 Thread Tathagat Priyadarshi
The PR aims to update the TX/RQ queue setup/stop routines that are unique to DQO, so that they may be called for instances that use the DQO RDA format during dev start/stop Signed-off-by: Tathagat Priyadarshi --- drivers/net/gve/gve_ethdev.c | 29 +++-- 1 file changed, 23

Re: [PATCH v1] net/ntnic: add missing SPDX tag

2024-07-25 Thread Ferruh Yigit
On 7/24/2024 2:14 PM, Mykola Kostenok wrote: > Add missing SPDX tag. > Remove exception added to './devtools/check-spdx-tag.sh' for this files. > > Signed-off-by: Mykola Kostenok > Hi Mykola, Thanks for the update. Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

Re: [PATCH] net/gve: Fix TX/RX queue setup and stop

2024-07-25 Thread Ferruh Yigit
On 7/25/2024 1:51 PM, Tathagat Priyadarshi wrote: > Hi Ferruh, > > It’s my mistake, there was a coding error in the first email and i did > send out v2, but it somehow didn't go through and i kept getting failure > emails, So i fixed and repushed it only to find out later that v2 was > also update

Re: [PATCH] app/testpmd: improve sse based macswap

2024-07-25 Thread Bruce Richardson
On Thu, Jul 25, 2024 at 06:17:35PM +0530, Varghese, Vipin wrote: >Hi Bruce, >Thanks for highlighting the variance. We found this was an internal >test bed configuration issue. We are sharing the next version of the >same patch with updated numbers. > Great, thanks for the update.

Re: [PATCH] net/gve: Fix TX/RX queue setup and stop

2024-07-25 Thread Tathagat Priyadarshi
Hi Ferruh, It’s my mistake, there was a coding error in the first email and i did send out v2, but it somehow didn't go through and i kept getting failure emails, So i fixed and repushed it only to find out later that v2 was also updated. So i had to defer the previous PR. I have added Acked by J

Re: [PATCH] app/testpmd: improve sse based macswap

2024-07-25 Thread Varghese, Vipin
Hi Bruce, Thanks for highlighting the variance. We found this was an internal test bed configuration issue. We are sharing the next version of the same patch with updated numbers. On 7/23/2024 10:42 PM, Bruce Richardson wrote: Caution: This message originated from an External Source. Use pr

Re: [PATCH] net/gve: Fix TX/RX queue setup and stop

2024-07-25 Thread Ferruh Yigit
On 7/24/2024 2:35 PM, Tathagat Priyadarshi wrote: > The PR aims to update the TX/RQ queue setup/stop routines that are > unique to DQO, so that they may be called for instances that use the > DQO RDA format during dev start/stop. > > Signed-off-by: Tathagat Priyadarshi > Acked-by: Joshua Washingt

RE: [PATCH v2] doc: announce rte_ipsec API changes

2024-07-25 Thread Aakash Sasidharan
> -Original Message- > From: Konstantin Ananyev > Sent: Wednesday, July 24, 2024 10:39 PM > To: Aakash Sasidharan > Cc: Akhil Goyal ; Jerin Jacob ; > Anoob Joseph ; Vidya Sagar Velumuri > ; dev@dpdk.org; konstantin.v.anan...@yandex.ru; > vladimir.medved...@intel.com > Subject: [EXTERNAL]

RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-07-25 Thread Akhil Goyal
> > On 25-Jul-24 5:47 AM, Akhil Goyal wrote: > >> On 24-Jul-24 2:04 PM, Akhil Goyal wrote: > On 24-Jul-24 12:20 PM, Akhil Goyal wrote: > >> On 23-Jul-24 5:57 PM, Akhil Goyal wrote: > Hi all, > > This patch breaks ipsec tests with ipsec-secgw: > > >>

Re: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-07-25 Thread Radu Nicolau
On 25-Jul-24 5:47 AM, Akhil Goyal wrote: On 24-Jul-24 2:04 PM, Akhil Goyal wrote: On 24-Jul-24 12:20 PM, Akhil Goyal wrote: On 23-Jul-24 5:57 PM, Akhil Goyal wrote: Hi all, This patch breaks ipsec tests with ipsec-secgw: ./examples/ipsec-secgw/test/run_test.sh -4 trs_aesctr_sha1 ... ERROR

RE: [PATCH] doc: announce cryptodev changes to offload RSA in VirtIO

2024-07-25 Thread Kusztal, ArkadiuszX
Hi Gowrishankar, > -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Monday, July 22, 2024 4:56 PM > To: dev@dpdk.org; Anoob Joseph ; Richardson, Bruce > ; ciara.po...@intel.com; jer...@marvell.com; > fanzhang@gmail.com; Kusztal, ArkadiuszX ; > Ji, Kai ; jack.bond-pres...@

RE: [EXTERNAL] Re: [PATCH] doc: announce vhost changes to support asymmetric operation

2024-07-25 Thread Gowrishankar Muthukrishnan
Sure Jerin. I’ll drop this proposal as ABI versioning could help. Thanks. Looks like in this case adding new arguments to function. Could you check ABI versing helps here? It seems like it can be easy manged with ABI versioning.

DPDK Release Status Meeting 2024-07-25

2024-07-25 Thread Mcnamara, John
Release status meeting minutes 2024-07-25 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the current/

[PATCH] eal/linux: clear asan after allocation and before prefaulting

2024-07-25 Thread Alex Michon
Prefaulting may generate asan error. Signed-off-by: Alex Michon --- .mailmap | 1 + lib/eal/linux/eal_memalloc.c | 5 + 2 files changed, 6 insertions(+) diff --git a/.mailmap b/.mailmap index 3f3f0442e5..b1655a4080 100644 --- a/.mailmap +++ b/.mailmap @@ -60,6 +60,7 @@ A