[PATCH v5 3/3] event/dsw: add capability for independent enqueue

2024-07-09 Thread Abdullah Sevincer
To use independent enqueue capability applications need to set flag RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ during port setup only if the capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ exists. Hence, this commit adds the capability of independent enqueue to the DSW driver. Signed-off-by: Abdullah Sevince

[PATCH v5 2/3] eventdev: add support for independent enqueue

2024-07-09 Thread Abdullah Sevincer
This commit adds support for independent enqueue feature and updates Event Device and PMD feature list. A new capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ is introduced to support independent enqueue to support PMD to enqueue in any order even the underlined hardware device needs enqueues in a str

[PATCH v5 1/3] event/dlb2: add support for independent enqueue

2024-07-09 Thread Abdullah Sevincer
DLB devices need events to be enqueued in the same order they are dequeued. Applications are not suppose to change event order between dequeue and to enqueue. Since Eventdev standard does not add such restrictions independent enqueue support is needed for DLB PMD so that it restores dequeue order o

[PATCH v5 0/3] Independent Enqueue Support

2024-07-09 Thread Abdullah Sevincer
v5: Address build issues v4: Address comments v3: Fix CI/build issues v2: Fix CI/build issues v1: Initial patchset Abdullah Sevincer (3): event/dlb2: add support for independent enqueue eventdev: add support for independent enqueue event/dsw: add capability for independent enqueue doc/guid

Re: [PATCH v2 1/2] net/bonding: introduce direct link bonding mode

2024-07-09 Thread Kamil Vojanec
Hi, I don't find the 'direct' mode in latest Linux. Do you have a plan to do this in Linux No, I was not planning on any Linux kernel contributions. IIUC, the 'direct' mode just to let the packets from one port send out at the same port, right? If it is, why do you introduce this new mode? It

Re: [PATCH v2 1/2] net/bonding: introduce direct link bonding mode

2024-07-09 Thread lihuisong (C)
Hi Kamil, 在 2024/4/12 20:27, Kamil Vojanec 写道: This patch adds a new bonding mode: 'direct'. The purpose of this mode is to redirect output packets to the same member port on which they were received. In case the requested port is not among the member ports, round robin TX mode is used as a fall

Re: [PATCH] vhost: fix offset while mmaping log base address

2024-07-09 Thread BillXiang
From: BillXiang > From: "Chenbo Xia" > Date: Tue, Jul 9, 2024, 20:42 > Subject: Re: [PATCH] vhost: fix offset while mmaping log base address > To: "BillXiang" > Cc: "Maxime Coquelin", "Jianfeng > Tan", "Tomasz Kulasek", > "Pawel Wodkowski", "dev@dpdk.org" > > On Jul 8, 2024, at 14:57, BillXiang

[DPDK/core Bug 15] Kernel crash after "Detected Tx Unit Hang" report

2024-07-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=15 Stephen Hemminger (step...@networkplumber.org) changed: What|Removed |Added Resolution|--- |INVALID

[DPDK/doc Bug 1485] Checksum function should require the whole packet to be on one segment

2024-07-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1485 Bug ID: 1485 Summary: Checksum function should require the whole packet to be on one segment Product: DPDK Version: 24.07 Hardware: All OS: All Status:

[PATCH v4 3/3] event/dsw: add capability for independent enqueue

2024-07-09 Thread Abdullah Sevincer
To use independent enqueue capability applications need to set flag RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ during port setup only if the capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ exists. Hence, this commit adds the capability of independent enqueue to the DSW driver. Signed-off-by: Abdullah Sevince

[PATCH v4 2/3] eventdev: add support for independent enqueue

2024-07-09 Thread Abdullah Sevincer
This commit adds support for independent enqueue feature and updates Event Device and PMD feature list. A new capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ is introduced to support independent enqueue to support PMD to enqueue in any order even the underlined hardware device needs enqueues in a str

[PATCH v4 1/3] event/dlb2: add support for independent enqueue

2024-07-09 Thread Abdullah Sevincer
DLB devices need events to be enqueued in the same order they are dequeued. Applications are not suppose to change event order between dequeue and to enqueue. Since Eventdev standard does not add such restrictions independent enqueue support is needed for DLB PMD so that it restores dequeue order o

[PATCH v4 0/3] Independent Enqueue Support

2024-07-09 Thread Abdullah Sevincer
v4: Address comments v3: Fix CI/build issues v2: Fix CI/build issues v1: Initial patchset Abdullah Sevincer (3): event/dlb2: add support for independent enqueue eventdev: add support for independent enqueue event/dsw: add capability for independent enqueue doc/guides/eventdevs/features/def

Re: release candidate 24.07-rc1

2024-07-09 Thread Thinh Tran
IBM - Power Systems Testing DPDK v24.07-rc1-21-gc15902587b * Build CI on Fedora 30,37,38,39,40 container images for ppc64le * Basic PF on Mellanox: No issue found * Performance: not tested. * OS:- RHEL 9.3 kernel: 5.14.0-362.2.1.el9_3.ppc64le with gcc version 11.4.1 20230605 (Red Hat 11.

Re: [PATCH v10 2/3] dts: VLAN test suite implementation

2024-07-09 Thread Jeremy Spewock
I just had one minor comment, otherwise: Reviewed-by: Jeremy Spewock On Wed, Jul 3, 2024 at 12:51 PM Dean Marx wrote: > + > +def vlan_setup(self, port_id: int, filtered_id: int) -> TestPmdShell: > +"""Setup method for all test cases. > + > +Args: > +shell: TestP

Re: [PATCH v9 3/3] dts: add VLAN methods to testpmd shell

2024-07-09 Thread Jeremy Spewock
Hey Dean, one other thing that I just noticed which I should have picked up on sooner is that all of the methods that you added here are missing return type annotations. I believe these are generally things we look for on all methods, and I'm surprised that we don't have something that checks for t

Re: [PATCH v4] ethdev: Add link_speed lanes support

2024-07-09 Thread Damodharam Ammepalli
On Tue, Jul 9, 2024 at 4:10 AM Ferruh Yigit wrote: > > On 7/9/2024 12:22 AM, Damodharam Ammepalli wrote: > > Update the eth_dev_ops structure with new function vectors > > to get, get capabilities and set ethernet link speed lanes. > > Update the testpmd to provide required config and information

[DPDK/ethdev Bug 1484] net/netvsc deadlock during VF hot add when setting MTU

2024-07-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1484 Bug ID: 1484 Summary: net/netvsc deadlock during VF hot add when setting MTU Product: DPDK Version: 23.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: no

[PATCH v7 2/2] dts: add test case that utilizes offload to pmd_buffer_scatter

2024-07-09 Thread jspewock
From: Jeremy Spewock Some NICs tested in DPDK allow for the scattering of packets without an offload and others enforce that you enable the scattered_rx offload in testpmd. The current version of the suite for testing support of scattering packets only tests the case where the NIC supports testin

[PATCH v7 1/2] dts: add methods for modifying MTU to testpmd shell

2024-07-09 Thread jspewock
From: Jeremy Spewock There are methods within DTS currently that support updating the MTU of ports on a node, but the methods for doing this in a linux session rely on the ip command and the port being bound to the kernel driver. Since test suites are run while bound to the driver for DPDK, there

[PATCH v7 0/2] Add second scatter test case

2024-07-09 Thread jspewock
From: Jeremy Spewock The decision was made to break this series in half meaning that this new version no longer contains the context manager or the change that uses a weakref finalize class for cleaning up interactive shells. Instead this new version only contains the changes to the testpmd shell

[PATCH v1 2/2] dts: improve starting and stopping interactive shells

2024-07-09 Thread jspewock
From: Jeremy Spewock The InteractiveShell class currently relies on being cleaned up and shutdown at the time of garbage collection, but this cleanup of the class does no verification that the session is still running prior to cleanup. So, if a user were to call this method themselves prior to ga

[PATCH v1 1/2] dts: add context manager for interactive shells

2024-07-09 Thread jspewock
From: Jeremy Spewock Interactive shells are managed in a way currently where they are closed and cleaned up at the time of garbage collection. Due to there being no guarantee of when this garbage collection happens in Python, there is no way to consistently know when an application will be closed

[PATCH v1 0/2] dts: add context manager for interactive shells

2024-07-09 Thread jspewock
From: Jeremy Spewock This series is extracted from an existing series that expands the scatter test suite. The goal of this patch series is to take this feature that would be useful to other test suites and extract it from the scatter series that does not directly depend on it. This series adds

Re: [PATCH v9] eal/x86: improve rte_memcpy const size 16 performance

2024-07-09 Thread David Marchand
On Tue, Jul 9, 2024 at 3:28 PM Morten Brørup wrote: > > When the rte_memcpy() size is 16, the same 16 bytes are copied twice. > In the case where the size is known to be 16 at build time, omit the > duplicate copy. > > Reduced the amount of effectively copy-pasted code by using #ifdef > inside fun

Re: [PATCH v8] eal/x86: improve rte_memcpy const size 16 performance

2024-07-09 Thread Patrick Robb
On Tue, Jul 9, 2024 at 8:48 AM David Marchand wrote: > > On Tue, Jul 9, 2024 at 2:43 PM Morten Brørup > wrote: > > PS: The CI should catch this stuff. > > Restoring OVS tests in CI has been requested and I think it was being worked > on. > Not sure where we are atm, Patrick? > OvS and SPDK com

RE: [PATCH 8/8] net/mlx5/hws: fix NA64 copy TOS field instead of TTL

2024-07-09 Thread Bing Zhao
Hi Itamar & Erez, Typo: NA64 -> NAT64 BR. Bing > -Original Message- > From: Itamar Gozlan > Sent: Tuesday, July 9, 2024 8:31 PM > To: Itamar Gozlan ; Erez Shitrit ; > Hamdan Agbariya ; Yevgeny Kliteynik > ; Alex Vesker ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Sua

DPDK Release Status Meeting 2024-07-04

2024-07-09 Thread Mcnamara, John
Release status meeting minutes 2024-07-04 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the current/

[PATCH v9] eal/x86: improve rte_memcpy const size 16 performance

2024-07-09 Thread Morten Brørup
When the rte_memcpy() size is 16, the same 16 bytes are copied twice. In the case where the size is known to be 16 at build time, omit the duplicate copy. Reduced the amount of effectively copy-pasted code by using #ifdef inside functions instead of outside functions. Suggested-by: Stephen Hemmin

[PATCH v2] ci: run more checks in private repositories

2024-07-09 Thread Robin Jarry
From: David Marchand Though devtools/checkpatches.sh is run as part of our CI, some other (not well known) checks could help when run in private repositories before submitting to the mailing list and even when run from the ovsrobot. Most of them require a git history or checked sources to run. A

Re: [PATCH v2] devtools: check that maintainers are listed in mailmap

2024-07-09 Thread David Marchand
On Fri, Jun 28, 2024 at 2:56 PM David Marchand wrote: > > When a maintainer changes its mail address, check that the associated > entry in .mailmap knows this address, otherwise there is a chance > .mailmap points at an obsolete address. > > While at it, fix Zhirun mail address in mailmap and add

Re: [PATCH v4 0/5] support AVX2 instruction Rx/Tx function

2024-07-09 Thread Ferruh Yigit
On 7/9/2024 9:24 AM, Chaoyong He wrote: > This patch series add the support of Rx/Tx function using the > AVX2 instruction. > > --- > v4: > * Add commit to solve the compile problem on 32-bit OS. > v3: > * Fix the 'meson.build' file to solve the compile problem. > v2: > * Rebase to the latest main

RE: [PATCH v8] eal/x86: improve rte_memcpy const size 16 performance

2024-07-09 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Tuesday, 9 July 2024 14.48 > > On Tue, Jul 9, 2024 at 2:43 PM Morten Brørup > wrote: > > PS: The CI should catch this stuff. Working on fixing it now, some old variants of rte_mov16() do the extra cast, and some don't. It could b

Re: [PATCH v8] eal/x86: improve rte_memcpy const size 16 performance

2024-07-09 Thread David Marchand
On Tue, Jul 9, 2024 at 2:43 PM Morten Brørup wrote: > PS: The CI should catch this stuff. Restoring OVS tests in CI has been requested and I think it was being worked on. Not sure where we are atm, Patrick? -- David Marchand

RE: [PATCH v8] eal/x86: improve rte_memcpy const size 16 performance

2024-07-09 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Tuesday, 9 July 2024 13.43 > > Hello, > > On Tue, Jul 9, 2024 at 11:24 AM David Marchand > wrote: > > > > On Mon, Jun 10, 2024 at 3:40 PM Konstantin Ananyev > > wrote: > > > > When the rte_memcpy() size is 16, the same 16 bytes a

Re: [PATCH] vhost: fix offset while mmaping log base address

2024-07-09 Thread Chenbo Xia
> On Jul 8, 2024, at 14:57, BillXiang wrote: > > External email: Use caution opening links or attachments > > > From: BillXiang > > For sanity the offset should be the last parameter of mmap. > > Fixes: fbc4d24 ("vhost: fix offset while mmaping log base address") The commit id length shou

Re: [PATCH v4] netdev-offload-dpdk: Support offload of set dscp action

2024-07-09 Thread Ferruh Yigit
On 7/9/2024 1:14 PM, Sunyang Wu wrote: > Add the "set dscp action" parsing function, > so that the "set dscp action" can be offloaded. > > Signed-off-by: Sunyang Wu > Hi Sunyang, This patch is for ovs, did you send it to dpdk mail list by mistake?

[PATCH 8/8] net/mlx5/hws: fix NA64 copy TOS field instead of TTL

2024-07-09 Thread Itamar Gozlan
From: Erez Shitrit We don't have enough registers to copy TTL and TOS, so we will set TTL to be the default value (64) and will copy TOS. Fixes: 06d969a8c5b8 ("net/mlx5/hws: support NAT64 flow action") Cc: ere...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Erez Shitrit Acked-by: Matan Azrad

[PATCH 7/8] net/mlx5/hws: fix NAT64 csum issue

2024-07-09 Thread Itamar Gozlan
From: Erez Shitrit Due to HW limitation we got two csum's that were not correct, udp and ip, both of them were not calculated correctly by the HW. By adding the next W/A we allow the HW to collect it well: Separate the protocol field and zero all the addresses before fixed the UDP csum. We saw th

[PATCH 6/8] net/mlx5/hws: take out not needed variable

2024-07-09 Thread Itamar Gozlan
From: Erez Shitrit Removing a redundant variable. Was there from day 1, not in use. Fixes: f8c8a6d8440d ("net/mlx5/hws: add action object") Cc: ere...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_pat_arg.h | 1 - 1 file chan

[PATCH 5/8] net/mlx5/hws: fix incorrect port ID on root item convert

2024-07-09 Thread Itamar Gozlan
From: Alex Vesker When calling item convert function we need to pass the port_id in the attributes. This value should be passed not only for cases that match on PORT related items, to resolve we will always pass it. Fixes: 572fe9ef2f46 ("net/mlx5/hws: fix port ID for root table") Cc: ere...@nvid

[PATCH 4/8] net/mlx5/hws: fix deletion of action vport

2024-07-09 Thread Itamar Gozlan
From: Erez Shitrit No more ignoring this action while destroying it. Fixes: f8c8a6d8440d ("net/mlx5/hws: add action object") Cc: ere...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_action.c | 4 drivers/net/mlx5/hws/mlx

[PATCH 3/8] net/mlx5/hws: strictly range templates check fix

2024-07-09 Thread Itamar Gozlan
Using range and non range templates is not allowed, and in HWS there is a check that enforce that limitation with constantly check that, in a loop, if the current template defined as range, the last one should also be defined as range. But, in the case where there are two templates in the following

[PATCH 2/8] net/mlx5/hws: fix memory leak in modify header free

2024-07-09 Thread Itamar Gozlan
From: Erez Shitrit When creating action from type MLX5DR_ACTION_TYP_REFORMAT_TNL_L3_TO_L2 we use modify-header object, we support few of that type at the same time over this action depends on the number of headers. Now when destroying the modify-header object we run over the number_of_patterns, t

[PATCH 0/8] HW steering team updates

2024-07-09 Thread Itamar Gozlan
This patch series contains 8 commits from the HW steering team, addressing various improvements and fixes in the DPDK project. This is the second version of this submission. The previous version erroneously included two unnecessary commits, which have been removed in this iteration. Alex Vesker (

[PATCH 1/8] net/mlx5/hws: set eswitch owner vhc ID valid accordingly

2024-07-09 Thread Itamar Gozlan
From: Erez Shitrit eswitch_owner_vhca_id_valid value should be set to 1 only on merged-eswitch device. Signed-off-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_action.c | 12 drivers/net/mlx5/hws/mlx5dr_cmd.c| 3 ++- drivers/net/mlx5/hws/mlx5dr_cmd.h

Re: [PATCH] app/testpmd: fix help string of BPF load command

2024-07-09 Thread David Marchand
On Mon, Jun 24, 2024 at 5:46 PM Konstantin Ananyev wrote: > > > Based on the logic of 'bpf_parse_flags()' and the 'bpf-load' section of > > 'testpmd_funcs.rst' document, the 'B' flag in the help string of > > bpf-load command should be '-'. > > > > Fixes: e977e4199a8d ("app/testpmd: add commands t

Re: [PATCH v5 0/3] replace use of EAL logtype in examples and testpmd

2024-07-09 Thread David Marchand
On Wed, Jul 3, 2024 at 6:30 PM Stephen Hemminger wrote: > > There are some places EAL logtype is being used in testpmd > and examples where it should not be. Lets reserve EAL > logtype to only be used by DPDK internals. > > Stephen Hemminger (3): > examples/l2fwd-keepalive: don't use EAL logtype

[PATCH v4] netdev-offload-dpdk: Support offload of set dscp action

2024-07-09 Thread Sunyang Wu
Add the "set dscp action" parsing function, so that the "set dscp action" can be offloaded. Signed-off-by: Sunyang Wu --- Documentation/howto/dpdk.rst | 5 +++-- lib/netdev-offload-dpdk.c| 27 ++- 2 files changed, 29 insertions(+), 3 deletions(-) diff --git a/Docume

Re: [v4 0/8] DPAA specific fixes

2024-07-09 Thread David Marchand
On Tue, Jul 9, 2024 at 12:05 PM wrote: > > From: Vanshika Shukla > > This series includes fixes for NXP DPAA drivers. > > V4 changes: > Removed \n from debug prints in "cache free optimization" patch. > Added fixline for "restrict MTU config for shared intf" patch. > Added CID for "fix resource l

Re: [PATCH v8] eal/x86: improve rte_memcpy const size 16 performance

2024-07-09 Thread David Marchand
Hello, On Tue, Jul 9, 2024 at 11:24 AM David Marchand wrote: > > On Mon, Jun 10, 2024 at 3:40 PM Konstantin Ananyev > wrote: > > > When the rte_memcpy() size is 16, the same 16 bytes are copied twice. > > > In the case where the size is known to be 16 at build time, omit the > > > duplicate copy

Re: [PATCH] usertools/devbind: add ODM DMA device

2024-07-09 Thread David Marchand
On Wed, Apr 17, 2024 at 9:13 AM Robin Jarry wrote: > > Anoob Joseph, Apr 17, 2024 at 09:11: > > Add support for ODM DMA device in devbind. > > > > Signed-off-by: Anoob Joseph > > Signed-off-by: Gowrishankar Muthukrishnan > > Signed-off-by: Vidya Sagar Velumuri > Acked-by: Robin Jarry Applied,

Re: [PATCH v2] dma/idxd: fix failure to configure a device instance for DSA

2024-07-09 Thread David Marchand
On Fri, Jun 28, 2024 at 12:26 PM Bruce Richardson wrote: > > On Fri, Jun 28, 2024 at 05:54:00PM +0800, Wenwu Ma wrote: > > In ubuntu 24.04, DSA's workqueue has a new driver_name file in sysfs, > > DPDK needs to write a correct value to this file when configuring a device > > instance using the dpd

Re: [PATCH v4] ethdev: Add link_speed lanes support

2024-07-09 Thread Ferruh Yigit
On 7/9/2024 12:22 AM, Damodharam Ammepalli wrote: > Update the eth_dev_ops structure with new function vectors > to get, get capabilities and set ethernet link speed lanes. > Update the testpmd to provide required config and information > display infrastructure. > > The supporting ethernet control

Re: [PATCH v4 0/6] refine argparse library

2024-07-09 Thread huangdengdui
For the patchset, Reviewed-by: Dengdui Huang On 2024/3/18 19:18, Chengwen Feng wrote: > I found a couple of issues when I revisited the argparse_autotest > output, so got this patchset. > > Chengwen Feng (6): > argparse: refine error message > argparse: remove dead code > argparse: replace

Re: [PATCH v2] dma/idxd: fix failure to configure a device instance for DSA

2024-07-09 Thread Bruce Richardson
On Tue, Jul 09, 2024 at 12:18:29PM +0200, David Marchand wrote: > On Fri, Jun 28, 2024 at 12:26 PM Bruce Richardson > wrote: > > > > On Fri, Jun 28, 2024 at 05:54:00PM +0800, Wenwu Ma wrote: > > > In ubuntu 24.04, DSA's workqueue has a new driver_name file in sysfs, > > > DPDK needs to write a cor

Re: [PATCH v2] dma/idxd: fix failure to configure a device instance for DSA

2024-07-09 Thread David Marchand
On Fri, Jun 28, 2024 at 12:26 PM Bruce Richardson wrote: > > On Fri, Jun 28, 2024 at 05:54:00PM +0800, Wenwu Ma wrote: > > In ubuntu 24.04, DSA's workqueue has a new driver_name file in sysfs, > > DPDK needs to write a correct value to this file when configuring a device > > instance using the dpd

[v4 7/8] net/dpaa: restrict MTU config for shared intf

2024-07-09 Thread vanshika . shukla
From: Rohit Raj Since DPDK was able to configure mtu in VSP/Shared interface mode, it was causing misconfiguration of the hw which further caused crashes. This patch allow only kernel to config MTU in such cases Fixes: e4abd4ff183c ("net/dpaa: support virtual storage profile") Cc: jun.y...@nxp

[v4 8/8] mempool/dpaax: cache free optimization

2024-07-09 Thread vanshika . shukla
From: Sachin Saxena - Updates the cache threshold value as per the platform specific optimal value. Signed-off-by: Sachin Saxena Signed-off-by: Vanshika Shukla --- drivers/mempool/dpaa/dpaa_mempool.c | 16 +++- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 15 +++

[v4 6/8] bus/dpaa: remove unused code

2024-07-09 Thread vanshika . shukla
From: Gagandeep Singh The slow poll code is not being used in DPDK DPAA driver sub-system. Signed-off-by: Gagandeep Singh Signed-off-by: Vanshika Shukla --- drivers/bus/dpaa/base/qbman/qman.c | 31 - drivers/bus/dpaa/include/fsl_qman.h | 31 ---

[v4 5/8] bus/dpaa: remove redundant file descriptor check

2024-07-09 Thread vanshika . shukla
From: Rohit Raj This patch removes the redundant file descriptor check Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: sta...@dpdk.org Signed-off-by: Rohit Raj Signed-off-by: Vanshika Shukla --- drivers/bus/dpaa/base/qbman/process.c | 7 --- 1 file chang

[v4 4/8] common/dpaax: fix array overrun issue

2024-07-09 Thread vanshika . shukla
From: Apeksha Gupta Out-of-bounds read, Overrunning dynamic array nodes at offset corresponding to index variable j. Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: sta...@dpdk.org Signed-off-by: Apeksha Gupta Signed-off-by: Vanshika Shukla --- drivers/commo

[v4 3/8] common/dpaax: fix IOVA table cleanup

2024-07-09 Thread vanshika . shukla
From: Gagandeep Singh Fixes incorrect structure free Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh Signed-off-by: Vanshika Shukla --- drivers/common/dpaax/dpaax_iova_table.c | 7 ++- 1 file changed, 2 inse

[v4 2/8] bus/dpaa: fix resource leak in variable dev

2024-07-09 Thread vanshika . shukla
From: Apeksha Gupta Resource leak: variable dev is going out of scope leaks the storage. Coverity issue: CID 373703 Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") Cc: hka...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Apeksha Gupta Signed-off-by: Vanshika Shukla

[v4 0/8] DPAA specific fixes

2024-07-09 Thread vanshika . shukla
From: Vanshika Shukla This series includes fixes for NXP DPAA drivers. V4 changes: Removed \n from debug prints in "cache free optimization" patch. Added fixline for "restrict MTU config for shared intf" patch. Added CID for "fix resource leak in variable dev" patch. V3 changes: Fixed compilati

[v4 1/8] bus/dpaa: fix bus scan for DMA devices

2024-07-09 Thread vanshika . shukla
From: Gagandeep Singh if there is no sec devices available, code is not scanning QDMA dev This patch fix this problem by adding a goto statement instead of return in case no sec device available. Fixes: 583f3732974f ("dma/dpaa: introduce DPAA DMA driver skeleton") Cc: sta...@dpdk.org Signed-off

Re: [PATCH v2] net/mlx5: add metadata split for compatibility API

2024-07-09 Thread Raslan Darawsheh
Hi, From: Bing Zhao Sent: Thursday, July 4, 2024 1:26 PM To: Slava Ovsiienko; dev@dpdk.org; Raslan Darawsheh Cc: Ori Kam; Dariusz Sosnowski; Suanming Mou; Matan Azrad Subject: [PATCH v2] net/mlx5: add metadata split for compatibility API The method will not create any new flow rule implicitly du

Re: [PATCH v8] eal/x86: improve rte_memcpy const size 16 performance

2024-07-09 Thread David Marchand
On Mon, Jun 10, 2024 at 3:40 PM Konstantin Ananyev wrote: > > When the rte_memcpy() size is 16, the same 16 bytes are copied twice. > > In the case where the size is known to be 16 at build time, omit the > > duplicate copy. > > > > Reduced the amount of effectively copy-pasted code by using #ifde

Re: [RFC] test: remove dead cfgfile tests

2024-07-09 Thread Bruce Richardson
On Tue, Jul 09, 2024 at 10:57:55AM +0200, Thomas Monjalon wrote: > 08/07/2024 18:55, Stephen Hemminger: > > The tests for the cfgfile library were never built since the conversion > > to meson (in 2017). Remove the dead code and files, if someone wants > > to fix them then they can be restored late

Re: [RFC] test: remove dead cfgfile tests

2024-07-09 Thread Thomas Monjalon
08/07/2024 18:55, Stephen Hemminger: > The tests for the cfgfile library were never built since the conversion > to meson (in 2017). Remove the dead code and files, if someone wants > to fix them then they can be restored later. > See commit b5dc795a8a55 ("test: build app with meson as dpdk-test")

Re: [PATCH] eal/linux: lower log level on allocation attempt failure

2024-07-09 Thread David Marchand
On Wed, Jun 26, 2024 at 5:00 PM Stephen Hemminger wrote: > > On Wed, 26 Jun 2024 16:51:42 +0200 > David Marchand wrote: > > > On a ARM system with only 2MB hugepages configured, EAL emits an error > > log with allocations larger than 512MB. > > > > Example with testpmd: > > $ dpdk-testpmd --in-me

Re: [PATCH v3] vfio: combine container_create and group_bind

2024-07-09 Thread David Marchand
On Thu, Jul 4, 2024 at 9:48 AM BillXiang wrote: > > From: BillXiang > > For multi-devices in one group we can only create and bind to one > container. With this new function, device driver does not need to > save the binding info additionally between different devices. > > Signed-off-by: BillXian

Re: [PATCH v3 7/8] net/dpaa: restrict MTU config for shared intf

2024-07-09 Thread David Marchand
On Mon, Jul 8, 2024 at 9:30 AM wrote: > > From: Rohit Raj > > Since DPDK was able to configure mtu in VSP/Shared interface mode, > it was causing misconfiguration of the hw which further caused crashes. > > This patch allow only kernel to config MTU in such cases > > Signed-off-by: Rohit Raj >

Re: [PATCH v3 00/19] remove use of VLAs for Windows

2024-07-09 Thread David Marchand
Hello guys, On Mon, May 6, 2024 at 8:19 PM Tyler Retzlaff wrote: > > As per guidance technical board meeting 2024/04/17. This series > removes the use of VLAs from code built for Windows for all 3 > toolchains. If there are additional opportunities to convert VLAs > to regular C arrays please pro

[PATCH v4 5/5] net/nfp: vector Rx function supports parsing ptype

2024-07-09 Thread Chaoyong He
From: Long Wu Vector AVX2 Rx function supports parsing packet type and set it to mbuf. Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_net_common.c| 2 +- drivers/net/nfp/nfp_rxtx.c | 2 +- drivers/net/nfp/nfp_rxtx.h | 3 +++ drivers/net/nfp/nfp_r

[PATCH v4 4/5] net/nfp: support AVX2 Rx function

2024-07-09 Thread Chaoyong He
From: Long Wu Use AVX2 instructions to accelerate Rx performance. The acceleration only works on X86 machine. Signed-off-by: Peng Zhang Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_ethdev.c| 2 +- drivers/net/nfp/nfp_ethdev_vf.c | 2 +- drivers/net/

[PATCH v4 3/5] net/nfp: support AVX2 Tx function

2024-07-09 Thread Chaoyong He
From: Long Wu Use AVX2 instructions to accelerate Tx performance. The acceleration only works on X86 machine. Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- drivers/net/nfp/meson.build | 20 + drivers/net/nfp/nfdk/nfp_nfdk.h | 1 + drivers/net/nfp/nfdk/nfp_

[PATCH v4 2/5] net/nfp: export more interfaces of NFDk

2024-07-09 Thread Chaoyong He
From: Long Wu NFP will support NFDk vector Tx function, so move some functions to header file for use by vector Tx function. Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- drivers/net/nfp/nfdk/nfp_nfdk.h| 45 ++ drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 43 +---

[PATCH v4 1/5] net/nfp: fix compile fail on 32-bit OS

2024-07-09 Thread Chaoyong He
From: Long Wu NFP PMD only support compile on 64-bit linux OS, add exit logic in other conditions. Fixes: 8741a9074536 ("net/nfp: disable for 32-bit meson builds") Cc: sta...@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/meson.build | 1

[PATCH v4 0/5] support AVX2 instruction Rx/Tx function

2024-07-09 Thread Chaoyong He
This patch series add the support of Rx/Tx function using the AVX2 instruction. --- v4: * Add commit to solve the compile problem on 32-bit OS. v3: * Fix the 'meson.build' file to solve the compile problem. v2: * Rebase to the latest main branch. --- Long Wu (5): net/nfp: fix compile fail on 32

Re: [PATCH 2/2] latencystats: replace use of VLA

2024-07-09 Thread David Marchand
On Tue, May 7, 2024 at 4:54 AM Stephen Hemminger wrote: > > The temporary array latencystats is not needed if the algorithm > is converted into one pass. > > Signed-off-by: Stephen Hemminger > Acked-by: Morten Brørup > Acked-by: Tyler Retzlaff Series applied, thanks for the cleanup. -- Davi

Re: raw/zxdh: introduce zxdh raw device driver

2024-07-09 Thread David Marchand
Hello, On Tue, Jul 9, 2024 at 8:31 AM wrote: > > I have made some changes as suggested. Is there anything else that needs to > be changed? This new patch can't be tested by the CI, because it does not make sense individually and there is no reference to the patch introducing the new driver. It

[PATCH v8 0/2] power: introduce PM QoS interface

2024-07-09 Thread Huisong Li
The deeper the idle state, the lower the power consumption, but the longer the resume time. Some service are delay sensitive and very except the low resume time, like interrupt packet receiving mode. And the "/sys/devices/system/cpu/cpuX/power/pm_qos_resume_latency_us" sysfs interface is used to s

[PATCH v8 1/2] power: introduce PM QoS API on CPU wide

2024-07-09 Thread Huisong Li
The deeper the idle state, the lower the power consumption, but the longer the resume time. Some service are delay sensitive and very except the low resume time, like interrupt packet receiving mode. And the "/sys/devices/system/cpu/cpuX/power/pm_qos_resume_latency_us" sysfs interface is used to s

[PATCH v8 2/2] examples/l3fwd-power: add PM QoS configuration

2024-07-09 Thread Huisong Li
Add PM QoS configuration to declease the delay after sleep in case of entering deeper idle state. Signed-off-by: Huisong Li Acked-by: Morten Brørup --- examples/l3fwd-power/main.c | 24 1 file changed, 24 insertions(+) diff --git a/examples/l3fwd-power/main.c b/example

[PATCH v3 4/4] net/nfp: vector Rx function supports parsing ptype

2024-07-09 Thread Chaoyong He
From: Long Wu Vector AVX2 Rx function supports parsing packet type and set it to mbuf. Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_net_common.c| 2 +- drivers/net/nfp/nfp_rxtx.c | 2 +- drivers/net/nfp/nfp_rxtx.h | 3 +++ drivers/net/nfp/nfp_r

[PATCH v3 3/4] net/nfp: support AVX2 Rx function

2024-07-09 Thread Chaoyong He
From: Long Wu Use AVX2 instructions to accelerate Rx performance. The acceleration only works on X86 machine. Signed-off-by: Peng Zhang Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_ethdev.c| 2 +- drivers/net/nfp/nfp_ethdev_vf.c | 2 +- drivers/net/

[PATCH v3 1/4] net/nfp: export more interfaces of NFDk

2024-07-09 Thread Chaoyong He
From: Long Wu NFP will support NFDk vector Tx function, so move some functions to header file for use by vector Tx function. Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- drivers/net/nfp/nfdk/nfp_nfdk.h| 45 ++ drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 43 +---

[PATCH v3 2/4] net/nfp: support AVX2 Tx function

2024-07-09 Thread Chaoyong He
From: Long Wu Use AVX2 instructions to accelerate Tx performance. The acceleration only works on X86 machine. Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- drivers/net/nfp/meson.build | 20 + drivers/net/nfp/nfdk/nfp_nfdk.h | 1 + drivers/net/nfp/nfdk/nfp_

[PATCH v3 0/4] support AVX2 instruction Rx/Tx function

2024-07-09 Thread Chaoyong He
This patch series add the support of Rx/Tx function using the AVX2 instruction. --- v3: * Fix the 'meson.build' file to solve the compile problem. v2: * Rebase to the latest main branch. --- Long Wu (4): net/nfp: export more interfaces of NFDk net/nfp: support AVX2 Tx function net/nfp: supp

Re: [PATCH v4] vhost: fix crash caused by accessing a freed vsocket

2024-07-09 Thread David Marchand
Hello, On Mon, Jul 8, 2024 at 6:41 AM Gongming Chen wrote: > > From: Gongming Chen > > When a vhost user message handling error in the event dispatch thread, > vsocket reconn is added to the reconnection list of the reconnection > thread. > Since the reconnection, event dispatching and app confi