I just had one minor comment, otherwise: Reviewed-by: Jeremy Spewock <jspew...@iol.unh.edu>
On Wed, Jul 3, 2024 at 12:51 PM Dean Marx <dm...@iol.unh.edu> wrote: <snip> > + > + def vlan_setup(self, port_id: int, filtered_id: int) -> TestPmdShell: > + """Setup method for all test cases. > + > + Args: > + shell: TestPmdShell object that is being used inside test case. It seems this argument was removed from the method, it's probably better to remove it from this doc-string as well. > + port_id: Number of port to use for setup. > + filtered_id: ID to be added to the vlan filter list. > + """ > + testpmd = TestPmdShell(node=self.sut_node) > + testpmd.set_forward_mode(SimpleForwardingModes.mac) > + testpmd.set_promisc(port_id, False) > + testpmd.vlan_filter_set(port=port_id, on=True) > + testpmd.rx_vlan(vlan=filtered_id, port=port_id, add=True) > + return testpmd > + <snip> > 2.44.0 >
