[DPDK/meson Bug 1469] [dpdk-24.07] meson_tests/driver-tests: event_dma_adapter_autotest test timeout

https://bugs.dpdk.org/show_bug.cgi?id=1469 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Res

RE: release candidate 24.07-rc1

> -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 20, 2024 12:09 PM > To: annou...@dpdk.org > Subject: release candidate 24.07-rc1 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v24.07-rc1 > > There are 361 new patches i

[PATCH v1] net/cpfl: add checks for received ctlq messages

cpfl_process_rx_ctlq_msg() is used to check error status returned for specific opcodes. Previously error codes were only -ve for cpfl_receive_ctlq_msg() but now there are +ve error codes. Hence code changes are made accordingly. Signed-off-by: Soumyadeep Hore --- drivers/net/cpfl/cpfl_flow_engi

[DPDK/core Bug 1472] mbuf: some dynamic fields are mishandled if IOVA as PA is disabled during build

https://bugs.dpdk.org/show_bug.cgi?id=1472 Shijith Thotton (sthot...@marvell.com) changed: What|Removed |Added Resolution|--- |FIXED Status

Re: [PATCH v4 0/6] refine argparse library

Kindly ping. Best regards, Chengwen Feng On 2024/3/18 19:18, Chengwen Feng wrote: > I found a couple of issues when I revisited the argparse_autotest > output, so got this patchset. > > Chengwen Feng (6): > argparse: refine error message > argparse: remove dead code > argparse: replace fla

[PATCH] dma/hisilicon: remove support for HIP09 platform

The DMA for HIP09 is no longer available, so delete it. Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- doc/guides/dmadevs/hisilicon.rst | 1 - doc/guides/rel_notes/release_24_07.rst | 5 drivers/dma/hisilicon/hisi_dmadev.c| 40 +- drivers/dma/hisil

[PATCH] net/hns3: support more VLAN fields matching

The commit 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN items") introduces ``has_vlan`` and ``has_more_vlan`` fields in items ETH and VLAN. This patch adds support for these fields. The usage is documented in hns3.rst. Signed-off-by: Jie Hai --- doc/guides/nics/hns3.rst |

[PATCH] doc: remove reference to pkt.next

The pkt union in mbuf was removed way back in 2014 but there still was one leftover in the mbuf figure. Fixes: 9aaccf1abdb2 ("mbuf: remove rte_ctrlmbuf") Signed-off-by: Stephen Hemminger --- doc/guides/prog_guide/img/mbuf1.svg | 2 +- doc/guides/prog_guide/img/mbuf2.svg | 6 +++--- 2 files chan

RE: [EXTERNAL] Re: [PATCH] net/netvsc: fix mtu_set in netvsc devices

Fixes: 45c83603087e (“net/netvsc: support MTU set”) Cc: sta...@dpdk.org From: Sam Andrew Sent: Wednesday, July 3, 2024 3:50 PM To: Alexander Skorichenko ; Long Li Cc: step...@networkplumber.org; ferruh.yi...@amd.com; andrew.rybche...@oktetlabs.ru; Wei Hu ; dev@dpdk.org

RE: [EXTERNAL] Re: [PATCH] net/netvsc: fix mtu_set in netvsc devices

Thank you so much, Alexander. I’ve reviewed the patch. It looks good to me as well. Reviewed-by: Sam Andrew mailto:samand...@microsoft.com>> From: Alexander Skorichenko Sent: Wednesday, July 3, 2024 3:14 AM To: Long Li Cc: step...@networkplumber.org; Sam Andrew ; ferruh.yi...@amd.com; andre

[PATCH v2 4/4] dts: add dynamic queue conf to the yaml schema

From: Jeremy Spewock Adds the ability to run the test suite using the yaml configuration file. Signed-off-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/fr

[PATCH v2 3/4] dts: add dynamic queue test suite

From: Jeremy Spewock This patch adds a new test suite that is designed to test the stopping and modification of port queues at runtime. Specifically, there are test cases that display the ports ability to stop some queues but still send and receive traffic on others, as well as the ability to con

[PATCH v2 2/4] dts: add port queue modification and forwarding stats to testpmd

From: Jeremy Spewock This patch adds methods for querying and modifying port queue state and configuration. In addition to this, it also adds the ability to capture the forwarding statistics that get outputted when you send the "stop" command in testpmd. Querying of port queue information is hand

[PATCH v2 1/4] dts: add send_packets to test suites and rework packet addressing

From: Jeremy Spewock Currently the only method provided in the test suite class for sending packets sends a single packet and then captures the results. There is, in some cases, a need to send multiple packets at once while not really needing to capture any traffic received back. The method to do

[PATCH v2 0/4] dts: add dynamic queue configuration test suite

From: Jeremy Spewock v2: * Fix default address in _adjust_addresses so that the position of the IP layer of the payload does not matter * Added default values to fields in the testpmd queue info. Burst mode is not something that is always specified, so it had to be optional and this me

DTS WG Meeting Minutes - July 3, 2024

# Attendees * Patrick Robb * Nicholas Pratte * Dean Marx * Alex * Nicholas Pratte * Paul Szczepanek # Minutes ===

Re: [PATCH v2] net/ice: support FEC feature

Hi Minjin, - please update release notes - see comments inline On 02/07/2024 09:02, Mingjin Ye wrote: This patch enable three Forward Error Correction(FEC) related ops in ice driver. As no speed information can get from HW, this patch only show FEC capability. Signed-off-by: Qiming Yang Signe

[DPDK/DTS Bug 1482] Port over Dynamic Config test suite

https://bugs.dpdk.org/show_bug.cgi?id=1482 Bug ID: 1482 Summary: Port over Dynamic Config test suite Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[PATCH v5 3/3] dts: queue suite conf schema

Configuration schema for the queue_start_stop suite. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index f02a31

[PATCH v5 2/3] dts: initial queue start/stop suite implementation

This suite tests the ability of the Poll Mode Driver to enable and disable Rx/Tx queues on a port. Signed-off-by: Dean Marx --- dts/tests/TestSuite_queue_start_stop.py | 94 + 1 file changed, 94 insertions(+) create mode 100644 dts/tests/TestSuite_queue_start_stop.py di

[PATCH v5 1/3] dts: add functions to testpmd shell

added set promisc, set verbose, and port stop commands to testpmd shell. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 192 ++ 1 file changed, 192 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_sess

RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

> -Original Message- > From: Akhil Goyal > Sent: Friday, March 15, 2024 12:42 AM > To: Akhil Goyal ; Chaoyong He > ; dev@dpdk.org > Cc: oss-driv...@corigine.com; Shihong Wang ; > sta...@dpdk.org > Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt > endianness problem >

Re: [PATCH v6] net/i40e: support FEC feature

Acked-by: Vladimir Medvedkin On 02/07/2024 09:40, Zhichao Zeng wrote: This patch enabled querying Forward Error Correction(FEC) capabilities, set FEC mode and get current FEC mode functions. Signed-off-by: Zhichao Zeng --- v6: fix some judgments v5: fix some judgments v4: fix some logic v3:

RE: [EXTERNAL] [PATCH 1/2] crypto/ionic: fix buffer overrun when writing session

> Coverity pointed out that, if the final segment of the session key being > written is not a full segment, the loop could potentially read past the > end of the source buffer. Use RTE_MIN() to make sure to only copy as much > of the key as is left. > > Coverity issue: 426432 > Fixes: 6bc7f2cf6687

RE: [PATCH v1] crypto/ipsec_mb: use new ipad/opad calculation API

> Acked-by: Wathsala Vithanage > > > Subject: [PATCH v1] crypto/ipsec_mb: use new ipad/opad calculation API > > > > From: Pablo de Lara > > > > IPSec Multi-buffer library v1.4 added a new API to calculate inner/outer > > padding for HMAC-SHAx/MD5. > > > > Signed-off-by: Pablo de Lara > > Signed

RE: [EXTERNAL] [PATCH 02/11] common/dpaax: caamflib: fix PDCP AES-AES wdog DECO err

> From: Varun Sethi > > Adding a Jump instruction with CALM flag to ensure > previous processing has been completed. > > Fixes: 8827d94398f1 ("crypto/dpaa2_sec/hw: support AES-AES 18-bit PDCP") > Cc: vakul.g...@nxp.com > Cc: sta...@dpdk.org > > Signed-off-by: Gagandeep Singh > Signed-off-by: V

[PATCH v10 4/4] hash: add SVE support for bulk key lookup

- Implemented SVE code for comparing signatures in bulk lookup. - New SVE code is ~5% slower than optimized NEON for N2 processor for 128b vectors. Signed-off-by: Yoan Picchi Signed-off-by: Harjot Singh Reviewed-by: Nathan Brown Reviewed-by: Ruifeng Wang --- lib/hash/compare_signatures_arm_pv

[PATCH v10 3/4] test/hash: check bulk lookup of keys after collision

This patch adds unit test for rte_hash_lookup_bulk(). It also update the test_full_bucket test to the current number of entries in a hash bucket. Signed-off-by: Yoan Picchi Signed-off-by: Harjot Singh Reviewed-by: Ruifeng Wang Reviewed-by: Nathan Brown --- .mailmap | 1 + app/tes

[PATCH v10 1/4] hash: pack the hitmask for hash in bulk lookup

Current hitmask includes padding due to Intel's SIMD implementation detail. This patch allows non Intel SIMD implementations to benefit from a dense hitmask. In addition, the new dense hitmask interweave the primary and secondary matches which allow a better cache usage and enable future improvemen

[PATCH v10 2/4] hash: optimize compare signature for NEON

Upon a successful comparison, NEON sets all the bits in the lane to 1 We can skip shifting by simply masking with specific masks. Signed-off-by: Yoan Picchi Reviewed-by: Ruifeng Wang Reviewed-by: Nathan Brown --- lib/hash/compare_signatures_arm_pvt.h | 22 +++--- 1 file changed

[PATCH v10 0/4] hash: add SVE support for bulk key lookup

This patchset adds SVE support for the signature comparison in the cuckoo hash lookup and improves the existing NEON implementation. These optimizations required changes to the data format and signature of the relevant functions to support dense hitmasks (no padding) and having the primary and seco

RE: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics

> 03/07/2024 15:27, Wathsala Wathawana Vithanage: > > > RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED #ifdef block. > > > > This patch fixes this issue by moving __RTE_ARM_WFE out of > > > > RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED block. > > > > > > > > Perhaps we should change RTE_ARM_USE_WFE to something like > >

[PATCH v10 3/3] dts: config schema

Configuration to run vlan test suite Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index f02a310bb5..cd45902cc4

[PATCH v10 2/3] dts: VLAN test suite implementation

Test suite for verifying VLAN filtering, stripping, and insertion functionality on Poll Mode Driver. Signed-off-by: Dean Marx --- dts/tests/TestSuite_vlan.py | 171 1 file changed, 171 insertions(+) create mode 100644 dts/tests/TestSuite_vlan.py diff --git

[PATCH v10 1/3] dts: add VLAN methods to testpmd shell

added the following methods to testpmd shell class: vlan set filter on/off, rx vlan add/rm, vlan set strip on/off, port stop/start all/port, tx vlan set/reset, set promisc/verbose fixed: bug in vlan_offload for show port info, removed $ at end of regex Signed-off-by: Dean Marx --- dts/framework/

[PATCH v9 3/3] dts: add VLAN methods to testpmd shell

added the following methods to testpmd shell class: vlan set filter on/off, rx vlan add/rm, vlan set strip on/off, port stop/start all/port, tx vlan set/reset, set promisc/verbose fixed: bug in vlan_offload for show port info, removed $ at end of regex Signed-off-by: Dean Marx --- dts/framework/

[PATCH v9 2/3] dts: VLAN test suite implementation

Test suite for verifying VLAN filtering, stripping, and insertion functionality on Poll Mode Driver. Signed-off-by: Dean Marx --- dts/tests/TestSuite_vlan.py | 171 1 file changed, 171 insertions(+) create mode 100644 dts/tests/TestSuite_vlan.py diff --git

[PATCH v9 1/3] dts: config schema

Configuration to run vlan test suite Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index f02a310bb5..cd45902cc4

New DTS Meeting Schedule

Hello, There is interest in moving the DTS meeting from Wednesdays at 14:00 UTC to Thursdays at 13:00 UTC. This would mean the DTS meetings would happen at the same time as the CI testing meetings, but on the off weeks. Let me know if this doesn't work for you, and we can try to make a decision w

[PATCH v5 3/3] testpmd: replace EAL logtype TESTPMD_LOG

Testpmd is misusing EAL logtype for some errors. Since the code directly has a macro for logging, use that. Signed-off-by: Stephen Hemminger Acked-by: Huisong Li Acked-by: Aman Singh --- app/test-pmd/testpmd.c | 49 -- 1 file changed, 19 insertions(+), 3

[PATCH v5 2/3] examples/vm_power_manager: do not use EAL logtype

Be consistent for all the error printouts and use fprintf(). The EAL logtype is reserved for internal use by EAL. Signed-off-by: Stephen Hemminger Acked-by: David Hunt Acked-by: Huisong Li --- examples/vm_power_manager/main.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) d

[PATCH v5 1/3] examples/l2fwd-keepalive: don't use EAL logtype

EAL logtype should be reserved for EAL library. This example is already has a log wrapper so use it. Signed-off-by: Stephen Hemminger Acked-by: Huisong Li Acked-by: Morten Brørup --- examples/l2fwd-keepalive/main.c | 2 -- examples/l2fwd-keepalive/shm.c | 29 - ex

[PATCH v5 0/3] replace use of EAL logtype in examples and testpmd

There are some places EAL logtype is being used in testpmd and examples where it should not be. Lets reserve EAL logtype to only be used by DPDK internals. Stephen Hemminger (3): examples/l2fwd-keepalive: don't use EAL logtype examples/vm_power_manager: do not use EAL logtype testpmd: replac

[PATCH] net/virtio-user: fix control queue allocation for non-vDPA

For non-vDPA backends, where the backend does not support control queue, it is still emulated in the Virtio-user layer to handle multiqueue feature. The frontend setups a control queue, which is hidden to the device. It means the number of vrings metadata to allocate should be based on the frontend

RE: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics

> > > > +uint8_t wfet_en; > > > > > > It should be made static probably. > > > This variable will be unused in some cases, needs #ifdef. > > > > > > > This variable is used in all cases. It's 1 when WFET is available, 0 when > > it's not. > > It would be 0 if you make it static yes. No need to m

Re: [PATCH 0/2] provide toolchain abstracted __builtin_constant_p

20/03/2024 22:33, Tyler Retzlaff: > Decouple direct dependency on GCC built-in __builtin_constant_p provide > a new macro __rte_constant(e) that expands to the built-in for GCC and > to false for MSVC. > > Tyler Retzlaff (2): > eal: provide macro for GCC builtin constant intrinsic > mempool: u

Re: [PATCH v2] buildtools: fix invalid symbols

Adding Ali in the loop, as he was working on a similar patch. On Mon, Jul 1, 2024 at 12:56 PM Mingjin Ye wrote: > > Elf files generated by higher version compilers wrap multiple > symbols prefixed with "this_pmd_name". > > The patch uses the regex "^this_pmd_name[0-9]+$" to match the > symbol nam

Re: [PATCH v2] mbuf: fix API to copy mbuf dynamic fields

27/06/2024 09:57, Shijith Thotton: > Fixed rte_mbuf_dynfield_copy() API to copy dynamic fields from one mbuf > to another. When RTE_IOVA_AS_PA is not defined during the build, an > additional dynamic field (dynfield2) becomes available. This field > should be conditionally copied to ensure the comp

Re: [PATCH v5] bitmap: add scan from offset function

03/07/2024 15:42, Volodymyr Fialko: > > From: Thomas Monjalon > > Sent: Wednesday, July 3, 2024 2:50 PM > > To: Volodymyr Fialko > > Cc: dev@dpdk.org; cristian.dumitre...@intel.com; Jerin Jacob; Anoob Joseph > > Subject: Re: [PATCH v5] bitmap: add scan from offset function > > > > 03/07/2023 14:39

[PATCH v3 3/3] dumpcap: add lcores option

The dumpcap application is reading from ring and writing to the kernel. By default the EAL init will cause the main thread to bound to the first lcore (cpu 0). Add a command line option to select the lcore to use; or if no lcores are specified then just be a normal process and let the CPU scheduler

[PATCH v3 2/3] app/pdump: handle SIGTERM and SIGHUP

The pdump application will leak ring and memory pool if killed by SIGTERM. Like dumpcap, the pdump process should cleanup if process terminates due to being killed or hangup. Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Signed-off-by: Stephen Hemminger --- app/pdump/main.c

[PATCH v3 1/3] app/dumpcap: handle SIGTERM and SIGHUP

If the dumpcap is killed it does not cleanup which leaves the ring buffer and the memory pool behind. Until resource are exhausted devices will continue to fill the ring. Fix by having the application handle SIGTERM, SIGHUP, and SIGPIPE. These are the same signals handled in same way by the wiresh

[PATCH v3 0/3] dumpcap and pdump patches for 24.07

Fix bug where dumpcap and pdump programs would leave resources if killed with SIGTERM (or if file gets full). Fix bug where dumpcap would always run on CPU 0 only. v3 - combine and rebase these patches Stephen Hemminger (3): app/dumpcap: handle SIGTERM and SIGHUP app/pdump: handle SIGTERM an

Re: [PATCH 2/2] mempool: use rte constant macro instead of GCC builtin

On Wed, Jul 3, 2024 at 10:22 AM David Marchand wrote: > > > > From the discussions on the retest mechanism, I understand we need to > ask for a rebase. > I sent a new retest. Let's see... > Hi, That makes sense that we need to re-apply on the latest mainline and retest. But, the "rebase" feature

RE: [EXTERNAL] [PATCH v5 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

> Subject: [EXTERNAL] [PATCH v5 1/5] crypto/openssl: fix GCM and CCM thread > unsafe ctxs > > Commit 67ab783b5d70 ("crypto/openssl: use local copy for session > contexts") introduced a fix for concurrency bugs which could occur when > using one OpenSSL PMD session across multiple cores simultaneou

[PATCH] eal: make dev_sigbus static

Only used in one file, and not an exported symbol should be static. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_private.h | 22 -- lib/eal/linux/eal_dev.c | 4 ++-- 2 files changed, 2 insertions(+), 24 deletions(-) diff --git a/lib/eal/common/eal_private.h

[PATCH v2] dts: Testbed And Node Configuration Split

This implementation splits the execution and node configuration components of the conf.yaml into two separate config files. A new command line argument is added, allowing the user to specify both a node configuration file and an execution configuration file. Be default, these config files are now n

Re: [PATCH 0/6] Some drivers logging cleanups

On Tue, Jun 25, 2024 at 2:24 PM David Marchand wrote: > > This series removes the last direct calls to some RTE_LOGTYPE_ coming > from libraries (EAL and CRYPTODEV) and replaces them with dedicated > macros coming from the drivers. > Series applied. -- David Marchand

Re: [PATCH v4 1/3] drivers: replace printf with log macros

On Wed, Jul 3, 2024 at 2:17 PM Hemant Agrawal wrote: > > This patch replaces the printf with related log macros and functions at > various places in NXP dpaaX drivers. > > Signed-off-by: Hemant Agrawal Series applied, thanks Hemant. -- David Marchand

[PATCH] test: fix option block

> > The options allow (-a) and block (-b) cannot be used at the same time. > > Therefore, allow (-a) will not be added when block (-b) is present. > > > > Fixes: b3ce7891ad38 ("test: fix probing in secondary process") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Mingjin Ye Hi Mingjin, in genera

Re: [PATCH v3 0/3] net/virtio: support IOVA as PA mode for vDPA backend

On 7/3/24 12:03, Srujana Challa wrote: This patch series makes Virtio-user works in IOVA as PA mode for vDPA backend. First patch fixes the issue when having buffer IOVA address in control queue descriptors. Second and third patches helps to share descriptor IOVA address, to the vhost backend

[DPDK/DTS Bug 1481] Add l2fwd sample app test but converted to use testpmd

https://bugs.dpdk.org/show_bug.cgi?id=1481 Bug ID: 1481 Summary: Add l2fwd sample app test but converted to use testpmd Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity

Re: [PATCH 2/2] mempool: use rte constant macro instead of GCC builtin

On Wed, Jul 3, 2024 at 3:49 PM Morten Brørup wrote: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Wednesday, 3 July 2024 15.17 > > > > 14/06/2024 16:32, David Marchand: > > > On Wed, May 29, 2024 at 4:51 PM Thomas Monjalon > > > wrote: > > > > > > > > 20/03/2024 22:33, Tyler

Re: [PATCH 0/2] provide toolchain abstracted __builtin_constant_p

On Wed, Mar 20, 2024 at 10:33 PM Tyler Retzlaff wrote: > > Decouple direct dependency on GCC built-in __builtin_constant_p provide > a new macro __rte_constant(e) that expands to the built-in for GCC and > to false for MSVC. > > Tyler Retzlaff (2): > eal: provide macro for GCC builtin constant i

[DPDK/DTS Bug 1480] Port Over ipgre For New DTS.

https://bugs.dpdk.org/show_bug.cgi?id=1480 Bug ID: 1480 Summary: Port Over ipgre For New DTS. Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priorit

RE: [PATCH 2/2] mempool: use rte constant macro instead of GCC builtin

> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, 3 July 2024 15.17 > > 14/06/2024 16:32, David Marchand: > > On Wed, May 29, 2024 at 4:51 PM Thomas Monjalon wrote: > > > > > > 20/03/2024 22:33, Tyler Retzlaff: > > > > Use newly introduced __rte_constant(e) macro instead of

Re: [EXTERNAL] [PATCH v4 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

On 03/07/2024 11:49, Jack Bond-Preston wrote: On 02/07/2024 16:39, Akhil Goyal wrote: I am seeing below errors when it is compiled with openssl 3.0 [1/30] Compiling C object 'drivers/a715181@@tmp_rte_crypto_openssl@sta/crypto_openssl_rte_openssl_pmd_ops.c.o'. FAILED: drivers/a715181@@tmp_rte

[PATCH v5 5/5] crypto/openssl: only set cipher padding once

Setting the cipher padding has a noticeable performance footprint, and it doesn't need to be done for every call to process_openssl_cipher_{en,de}crypt(). Setting it causes OpenSSL to set it on every future context re-init. Thus, for every buffer after the first one, the padding is being set twice.

[PATCH v5 4/5] crypto/openssl: per-qp auth context clones

Currently EVP auth ctxs (e.g. EVP_MD_CTX, EVP_MAC_CTX) are allocated, copied to (from openssl_session), and then freed for every auth operation (ie. per packet). This is very inefficient, and avoidable. Make each openssl_session hold an array of structures, containing pointers to per-queue-pair ci

[PATCH v5 3/5] crypto/openssl: per-qp cipher context clones

Currently EVP_CIPHER_CTXs are allocated, copied to (from openssl_session), and then freed for every cipher operation (ie. per packet). This is very inefficient, and avoidable. Make each openssl_session hold an array of pointers to per-queue-pair cipher context copies. These are populated on first

[PATCH v5 2/5] crypto/openssl: only init 3DES-CTR key + impl once

Currently the 3DES-CTR cipher context is initialised for every buffer, setting the cipher implementation and key - even though for every buffer in the session these values will be the same. Change to initialising the cipher context once, before any buffers are processed, instead. Throughput perfo

[PATCH v5 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

Commit 67ab783b5d70 ("crypto/openssl: use local copy for session contexts") introduced a fix for concurrency bugs which could occur when using one OpenSSL PMD session across multiple cores simultaneously. The solution was to clone the EVP contexts per-buffer to avoid them being used concurrently.

[PATCH v5 0/5] OpenSSL PMD Optimisations

v2: * Fixed missing * in patch 4 causing compilation failures. v3: * Work around a lack of support for duplicating EVP_CIPHER_CTXs for AES-GCM and AES-CCM in OpenSSL versions 3.0.0 <= v < 3.2.0. v4: * Work around a bug with re-initing EVP_MAC_CTXs in OpenSSL versions 3.0.0 <= v < 3.0.3. v5:

Re: [PATCH v5] bitmap: add scan from offset function

> From: Thomas Monjalon > Sent: Wednesday, July 3, 2024 2:50 PM > To: Volodymyr Fialko > Cc: dev@dpdk.org; cristian.dumitre...@intel.com; Jerin Jacob; Anoob Joseph > Subject: Re: [PATCH v5] bitmap: add scan from offset function > > 03/07/2023 14:39, Volodymyr Fialko: > > Currently, in the case whe

Re: [PATCH v3 3/3] net/virtio_user: support sharing vq descriptor IOVA to the backend

On 7/3/24 12:03, Srujana Challa wrote: Adds support to share descriptor IOVA to the vhost backend. This makes virtio_user driver works in IOVA as PA mode when use_va flag is disabled. This patch also disables use_va flag for VDPA backend. Signed-off-by: Srujana Challa --- .../net/virtio/vi

Re: [PATCH v3 2/3] net/virtio: store desc IOVA address in vring data structure

On 7/3/24 12:03, Srujana Challa wrote: Stores desc IOVA in the queue's vring data structure, as preliminary work to provide a way for Virtio-user to share desc IOVA to the vhost backend. Signed-off-by: Srujana Challa --- drivers/net/virtio/virtio_ring.h | 12 drivers/net/virt

Re: [PATCH v3 1/3] net/virtio_user: convert cq descriptor IOVA address to Virtual address

On 7/3/24 12:03, Srujana Challa wrote: This patch modifies the code to convert descriptor buffer IOVA addresses to virtual addresses during the processing of shadow control queue when IOVA mode is PA. This change enables Virtio-user to operate with IOVA as the descriptor buffer address. Signe

Re: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics

03/07/2024 15:27, Wathsala Wathawana Vithanage: > > RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED #ifdef block. > > > This patch fixes this issue by moving __RTE_ARM_WFE out of > > > RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED block. > > > > > > Perhaps we should change RTE_ARM_USE_WFE to something like > > > RTE_ARM_US

[PATCH] net/gve: fix RSS hash endianness in DQO format

The hash field in struct gve_rx_compl_desc_dqo defined in gve_desc_dqo.h has the type __le32. Therefore the hash must be read in little endian rather than big endian. Bugzilla ID: 1441 Signed-off-by: Shreesh Adiga <16567adigashre...@gmail.com> --- drivers/net/gve/gve_rx_dqo.c | 2 +- 1 file chan

Re: [PATCH v3 1/3] net/virtio_user: convert cq descriptor IOVA address to Virtual address

On 7/3/24 12:19, Jerin Jacob wrote: On Wed, Jul 3, 2024 at 3:43 PM Srujana Challa wrote: This patch modifies the code to convert descriptor buffer IOVA addresses to virtual addresses during the processing of shadow control queue when IOVA mode is PA. This change enables Virtio-user to opera

RE: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics

> RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED #ifdef block. > > This patch fixes this issue by moving __RTE_ARM_WFE out of > > RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED block. > > > > Perhaps we should change RTE_ARM_USE_WFE to something like > > RTE_ARM_USE_WFE_IN_WAIT_UNTIL_EQUAL ? > > Yes perhaps. RTE_ARM_USE_WF

Re: [PATCH 2/2] mempool: use rte constant macro instead of GCC builtin

14/06/2024 16:32, David Marchand: > On Wed, May 29, 2024 at 4:51 PM Thomas Monjalon wrote: > > > > 20/03/2024 22:33, Tyler Retzlaff: > > > Use newly introduced __rte_constant(e) macro instead of directly using > > > __builtin_constant_p() allowing mempool to be built by MSVC. > > > > Does it mean

Re: [PATCH v5] bitmap: add scan from offset function

03/07/2023 14:39, Volodymyr Fialko: > Currently, in the case when we search for a bit set after a particular > value, the bitmap has to be scanned from the beginning and > rte_bitmap_scan() has to be called multiple times until we hit the value. > > Add a new rte_bitmap_scan_from_offset() function

[PATCH v4 3/3] drivers: replace printf with fprintf for debug functions

This patch replaces simple printf with fprintf for debug dump related functions for various NXP dpaaX related drivers. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/netcfg_layer.c | 22 +++ drivers/bus/dpaa/dpaa_bus.c | 2 +- drivers/bus/dpaa/include/netcfg.

[PATCH v4 2/3] drivers: dpaa: remove double newline

Remove duplicate newline `\n` from the debugging macros to avoid double `\n\n`. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman.c | 58 ++--- drivers/bus/dpaa/dpaa_bus.c | 12 +++--- drivers/event/dpaa/dpaa_eventdev.c | 20 +- drivers/

[PATCH v4 1/3] drivers: replace printf with log macros

This patch replaces the printf with related log macros and functions at various places in NXP dpaaX drivers. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman.c | 6 ++ drivers/bus/dpaa/base/qbman/process.c | 29 +- drivers/bus/dpaa/base/qbman/q

Re: [PATCH v3 1/3] drivers: replace printf with log macros

On Wed, Jul 3, 2024 at 2:03 PM Hemant Agrawal wrote: > >> diff --git a/drivers/net/dpaa/dpaa_ethdev.c > >> b/drivers/net/dpaa/dpaa_ethdev.c > >> index 935a4f2ada..bcd19f31fb 100644 > >> --- a/drivers/net/dpaa/dpaa_ethdev.c > >> +++ b/drivers/net/dpaa/dpaa_ethdev.c > >> @@ -282,9 +282,9 @@ dpaa_et

Re: [PATCH v3 1/3] drivers: replace printf with log macros

Hi David On 03-07-2024 16:11, David Marchand wrote: Hello Hemant, On Tue, Jul 2, 2024 at 3:09 PM Hemant Agrawal wrote: [snip] diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c index 0fa70c978f..fb9ac9cb30 100644 --- a/drivers/crypto/caam_jr/caam_jr.c +++ b/dri

Re: [PATCH] net/netvsc: fix mtu_set in netvsc devices

Thanks. >> With this patch, do you see other problems with VPP? No further problems were noticed and MTU can be set to custom values. - Alexander Skorichenko On Wed, Jul 3, 2024 at 2:35 AM Long Li wrote: > Thank you, Alexander. > > > > The patch looks good to me. With this patch, do you see ot

RE: [PATCH v5] bitmap: add scan from offset function

Hi Thomas, Is there any remaining work for this patch, or is it ready to be merged? /Volodymyr

[PATCH 8/8] mempool/dpaax: cache free optimization

From: Sachin Saxena - Updates the cache threshold value as per the platform specific optimal value. Signed-off-by: Sachin Saxena Signed-off-by: Vanshika Shukla --- drivers/mempool/dpaa/dpaa_mempool.c | 16 +++- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 15 +++

[PATCH 7/8] net/dpaa: restrict MTU config for shared intf

From: Rohit Raj Since DPDK was able to configure mtu in VSP/Shared interface mode, it was causing misconfiguration of the hw which further caused crashes. This patch allow only kernel to config MTU in such cases Signed-off-by: Rohit Raj Signed-off-by: Vanshika Shukla --- drivers/net/dpaa/dp

[PATCH 6/8] bus/dpaa: remove unused code

From: Gagandeep Singh The slow poll code is not being used in DPDK DPAA driver sub-system. Signed-off-by: Gagandeep Singh Signed-off-by: Vanshika Shukla --- drivers/bus/dpaa/base/qbman/qman.c | 31 - drivers/bus/dpaa/include/fsl_qman.h | 31 ---

[PATCH 5/8] bus/dpaa: remove redundant file descriptor check

From: Rohit Raj This patch removes the redundant file descriptor check Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: sta...@dpdk.org Signed-off-by: Rohit Raj Signed-off-by: Vanshika Shukla --- drivers/bus/dpaa/base/qbman/process.c | 7 --- 1 file chang

[PATCH 4/8] common/dpaax: fix array overrun issue

From: Apeksha Gupta Out-of-bounds read, Overrunning dynamic array nodes at offset corresponding to index variable j. Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: sta...@dpdk.org Signed-off-by: Apeksha Gupta Signed-off-by: Vanshika Shukla --- drivers/commo

[PATCH 3/8] common/dpaax: fix IOVA table cleanup

From: Gagandeep Singh Fixes incorrect structure free Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh Signed-off-by: Vanshika Shukla --- drivers/common/dpaax/dpaax_iova_table.c | 7 ++- 1 file changed, 2 inse

[PATCH 2/8] bus/dpaa: fix resource leak in variable dev

From: Apeksha Gupta Resource leak: variable dev is going out of scope leaks the storage. Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") Cc: hka...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Apeksha Gupta Signed-off-by: Vanshika Shukla --- drivers/bus/dpaa/dpaa_

[PATCH 1/8] bus/dpaa: fix bus scan for DMA devices

From: Gagandeep Singh if there is no sec devices available, code is not scanning QDMA dev This patch fix this problem by adding a goto statement instead of return in case no sec device available. Fixes: 583f3732974f ("dma/dpaa: introduce DPAA DMA driver skeleton") Cc: sta...@dpdk.org Signed-off

[PATCH 0/8] DPAA specific fixes

From: Vanshika Shukla This series includes fixes for NXP DPAA drivers. Apeksha Gupta (2): bus/dpaa: fix resource leak in variable dev common/dpaax: fix array overrun issue Gagandeep Singh (3): bus/dpaa: fix bus scan for DMA devices common/dpaax: fix IOVA table cleanup bus/dpaa: remove

Re: [EXTERNAL] [PATCH v4 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

On 02/07/2024 16:39, Akhil Goyal wrote: I am seeing below errors when it is compiled with openssl 3.0 [1/30] Compiling C object 'drivers/a715181@@tmp_rte_crypto_openssl@sta/crypto_openssl_rte_openssl_pmd_ops.c.o'. FAILED: drivers/a715181@@tmp_rte_crypto_openssl@sta/crypto_openssl_rte_openssl_

  1   2   >