> -----Original Message----- > From: Akhil Goyal <gak...@marvell.com> > Sent: Friday, March 15, 2024 12:42 AM > To: Akhil Goyal <gak...@marvell.com>; Chaoyong He > <chaoyong...@corigine.com>; dev@dpdk.org > Cc: oss-driv...@corigine.com; Shihong Wang <shihong.w...@corigine.com>; > sta...@dpdk.org > Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt > endianness problem > > > Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt > > endianness problem > > > > > From: Shihong Wang <shihong.w...@corigine.com> > > > > > > The SA salt of struct ipsec_sa is a CPU-endian u32 variable, but it’s > > > value is stored in an array of encryption or authentication keys > > > according to big-endian. So it maybe need to convert the endianness > > > order to ensure that the value assigned to the SA salt is CPU-endian. > > > > > > Fixes: 50d75cae2a2c ("examples/ipsec-secgw: initialize SA salt") > > > Fixes: 9413c3901f31 ("examples/ipsec-secgw: support additional > > > algorithms") > > > Fixes: 501e9c226adf ("examples/ipsec-secgw: add AEAD parameters") > > > Cc: sta...@dpdk.org > > > > > > Signed-off-by: Shihong Wang <shihong.w...@corigine.com> > > > Reviewed-by: Chaoyong He <chaoyong...@corigine.com> > > > > > Acked-by: Akhil Goyal <gak...@marvell.com> > > > > Applied to dpdk-next-crypto > > The patch is pulled back from dpdk-next-crypto. > This change may cause all the PMDs to fail these cases. > Would need acks from PMDs.
Applied to dpdk-next-crypto No update from PMD owners. Applying it before RC2 so that we have time for fixes if needed.