03/07/2024 15:27, Wathsala Wathawana Vithanage: > > RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED #ifdef block. > > > This patch fixes this issue by moving __RTE_ARM_WFE out of > > > RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED block. > > > > > > Perhaps we should change RTE_ARM_USE_WFE to something like > > > RTE_ARM_USE_WFE_IN_WAIT_UNTIL_EQUAL ? > > > > Yes perhaps. > RTE_ARM_USE_WFE is already used in drivers/event/cnxk/cn10k_worker.h > therefore RTE_ARM_USE_WFE_IN_WAIT_UNTIL_EQUAL is not suitable. > I wouldn't mind keeping RTE_ARM_USE_WFE because "USE_WFE" sounds like an > instruction to use WFE rather than an indication of availability of the WFE > instruction.
The problem is that the definition of this flag is not clear. What is it doing? If it's really disabling WFE, keep the #ifdef to not use it. For now, it is a nack of this patch for all reasons described before.
