RE: [PATCH v10 02/20] eal: replace use of sanity check in comments and messages

2024-06-05 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 30 May 2024 01.34 > > Sanity check is on the Tier 2 non-inclusive list. > Replace or remove it. > > Signed-off-by: Stephen Hemminger > Acked-by: Anatoly Burakov > --- Acked-by: Morten Brørup

RE: [PATCH v21 01/14] maintainers: add for log library

2024-06-05 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, 4 June 2024 02.45 > > "You touch it you own it" > Add myself as maintainer for log library. > > Signed-off-by: Stephen Hemminger > Acked-by: Tyler Retzlaff > --- For the series, Acked-by: Morten Brørup

RE: [PATCH 0/2] add function to set dedicated queue size

2024-06-05 Thread Chaoyong He
> On Wed, 5 Jun 2024 13:55:18 +0800 > Chaoyong He wrote: > > > This patch series mainly add a function to bonding PMD to set > > dedicated queue size, also add a command to testpmd application to > > invoke this function. > > > > At the same time, standard the log message of bonding PMD. > > > >

[PATCH v3 4/4] dts: add test case that utilizes offload to pmd_buffer_scatter

2024-06-05 Thread jspewock
From: Jeremy Spewock Some NICs tested in DPDK allow for the scattering of packets without an offload and others enforce that you enable the scattered_rx offload in testpmd. The current version of the suite for testing support of scattering packets only tests the case where the NIC supports testin

[PATCH v3 3/4] dts: add methods for modifying MTU to testpmd shell

2024-06-05 Thread jspewock
From: Jeremy Spewock There are methods within DTS currently that support updating the MTU of ports on a node, but the methods for doing this in a linux session rely on the ip command and the port being bound to the kernel driver. Since test suites are run while bound to the driver for DPDK, there

[PATCH v3 2/4] dts: add context manager for interactive shells

2024-06-05 Thread jspewock
From: Jeremy Spewock Interactive shells are managed in a way currently where they are closed and cleaned up at the time of garbage collection. Due to there being no guarantee of when this garbage collection happens in Python, there is no way to consistently know when an application will be closed

[PATCH v3 1/4] dts: improve starting and stopping interactive shells

2024-06-05 Thread jspewock
From: Jeremy Spewock The InteractiveShell class currently relies on being cleaned up and shutdown at the time of garbage collection, but this cleanup of the class does no verification that the session is still running prior to cleanup. So, if a user were to call this method themselves prior to ga

[PATCH v3 0/4] Add second scatter test case

2024-06-05 Thread jspewock
From: Jeremy Spewock v3: * increasse timeout before retrying starting interactive shells * added the ability to send logging messages from sending commands to interactive shells at the debug level rather than always being at the info level * changed the verification step for the scatter

[PATCH 3/9] net/mlx5: extract queue index validation

2024-06-05 Thread Dariusz Sosnowski
Extract validation of queue index out of validation of RTE_FLOW_ACTION_TYPE_QUEUE action to allow reuse in template API flow rule creation implementation. Signed-off-by: Dariusz Sosnowski Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.c | 59 +--- drivers/net/m

[PATCH 6/9] net/mlx5: store expected type on indirect action

2024-06-05 Thread Dariusz Sosnowski
When template table is created, list of unmasked actions is recorded for future flow rule insertions. This patch expands entries for RTE_FLOW_ACTION_TYPE_INDIRECT actions in this list with information about expected indirect action type. This will be used in follow up commits which add flow rule op

[PATCH 8/9] common/mlx5: add debug mode indicator

2024-06-05 Thread Dariusz Sosnowski
Add mlx5_fp_debug_enabled() function which: - returns true if RTE_LIBRTE_MLX5_DEBUG is defined, - returns false otherwise. This allows for conditional execution of code meant to be executed only when mlx5 debug mode is enabled, without adding conditional compilation guards inside source code. Whe

[PATCH 7/9] net/mlx5: store modify field action

2024-06-05 Thread Dariusz Sosnowski
When template table is created, list of unmasked actions is recorded for future flow rule insertions. This patch expands entries for RTE_FLOW_ACTION_TYPE_MODIFY_FIELD actions in this list with a copy of the action from the template. This will be used in follow up commits which add flow rule operati

[PATCH 5/9] net/mlx5: store original actions in template

2024-06-05 Thread Dariusz Sosnowski
When actions template is created in mlx5 PMD, some actions will be replaced with another or some actions will be added to implement required template semantics on NVIDIA NICs. For example: - RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID actions is replaced with modify field action. - Modify field action

[PATCH 1/9] ethdev: support duplicating only item mask

2024-06-05 Thread Dariusz Sosnowski
Extend rte_flow_conv() to support working only on item's mask. This allows drivers to get only the mask's size when working on pattern templates and duplicate items having only the mask in a generic way. Signed-off-by: Dariusz Sosnowski Acked-by: Ori Kam --- lib/ethdev/rte_flow.c | 15 +

[PATCH 2/9] net/mlx5: extract target port validation

2024-06-05 Thread Dariusz Sosnowski
Extract code responsible for validation if port specified in configuration of RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT action is correct. Allow for reuse of this logic for both RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT actions and RTE_FLOW_ITEM_TYPE_REPRESENTED_PORT items. Signed-off-by: Dariusz Sosnowsk

[PATCH 9/9] net/mlx5: add async flow operation validation

2024-06-05 Thread Dariusz Sosnowski
This patch adds validation to implementations of the following API functions: - rte_flow_async_create() - rte_flow_async_create_by_index() - rte_flow_async_update() - rte_flow_async_destroy() These validations are enabled if and only if RTE_LIBRTE_MLX5_DEBUG macro is defined. Signed-off-by: Dari

[PATCH 0/9] net/mlx5: flow fast path validation

2024-06-05 Thread Dariusz Sosnowski
This patchset adds validations for flow items and actions supplied by the user to fast path async flow API functions implemented in mlx5 PMD. - Patch 1: Adds the ability to generically calculate flow item's mask size using rte_flow_conv(). This change is used in follow up patches to check for

[PATCH 4/9] net/mlx5: store pattern template items

2024-06-05 Thread Dariusz Sosnowski
Store items which define the pattern template on creation. This allows validation of items, provided by the user during flow rule creation, against pattern template. Signed-off-by: Dariusz Sosnowski Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.h| 2 ++ drivers/net/mlx5/mlx5_flow_hw.c |

Re: [PATCH v4] net/cpfl: get running host ID for CPFL PMD

2024-06-05 Thread Stephen Hemminger
On Wed, 5 Jun 2024 05:48:39 + "Wani, Shaiq" wrote: > > + if (uname(&unamedata) != 0) > > + PMD_INIT_LOG(ERR, "Cannot fetch node_name for host\n"); No newline needed. > > + else if (strstr(unamedata.nodename, "ipu-imc")) > > + PMD_INIT_LOG(ERR, "CPFL PMD cannot be run

DTS WG Meeting Minutes - June 5, 2024

2024-06-05 Thread Patrick Robb
# June 5, 2024 Attendees * Patrick Robb * Nicholas Pratte * Dean Marx * Luca Vizzarro * Juraj Linkeš * Paul Szczepanek * Tomas Durovec * Jeremy Spewock # Minutes

[RFC PATCH v1 2/2] dts: Remove XML-RPC server for Scapy TG and instead us ScapyShell

2024-06-05 Thread jspewock
From: Jeremy Spewock Previously all scapy commands were handled using an XML-RPC server that ran on the TGNode. This unnecessarily enforces a minimum Python version of 3.10 on the server that is being used as a traffic generator and complicates the implementation of scapy methods. This patch remo

[RFC PATCH v1 1/2] dts: Add interactive shell for managing Scapy

2024-06-05 Thread jspewock
From: Jeremy Spewock This shell can be used to remotely run Scapy commands interactively and provides methods for handling the sending and capturing of packets. depends-on: series-32014 ("Improve interactive shell output gathering and logging") Signed-off-by: Jeremy Spewock --- dts/framework/

[RFC PATCH v1 0/2] dts: replace XML-RPC server

2024-06-05 Thread jspewock
From: Jeremy Spewock This series implements a new way to handle scapy interactions by using an interactive shell for managing the session instead of an XML-RPC server. One thing to note about these changes while reviewing is that I made the choice to use a Python interactive terminal and import

[DPDK/DTS Bug 1455] Add support for checking docstring validity

2024-06-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1455 Bug ID: 1455 Summary: Add support for checking docstring validity Product: DPDK Version: 24.07 Hardware: All OS: All Status: UNCONFIRMED Severity: minor

Re: [PATCH v3 01/25] net/axgbe: fix mdio access for non-zero ports and CL45 PHYs

2024-06-05 Thread Ferruh Yigit
On 6/4/2024 1:11 PM, Venkat Kumar Ande wrote: > From: Venkat Kumar Ande > > The XGBE supports performing MDIO operations using an MDIO command > request. The driver mistakenly uses the mdio port address as the > MDIO command request device address instead of the MDIO command > request port addres

[PATCH v2] devtools: add acronyms in dictionary for commit checks

2024-06-05 Thread Ferruh Yigit
ELF -> Executable and Linkable Format Ethernet -> with an uppercase “E” mark -> 'mark' flow action, no need to capitalise max -> maximum MDIO -> Management Data Input/Output MII -> Media-Independent Interface XSK -> XDP Socket. XDP (eXpress Data Path) Signed-off-by: Fer

RE: [PATCH v2 3/3] net/mlx5: add external Tx queue map and unmap

2024-06-05 Thread Dariusz Sosnowski
> -Original Message- > From: Suanming Mou > Sent: Wednesday, June 5, 2024 11:32 > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Ori Kam ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v2 3/3] net/mlx5: add external Tx queue map and unmap > > For using external creat

RE: [PATCH v2] net/mlx5: support match with E-Switch manager

2024-06-05 Thread Dariusz Sosnowski
> -Original Message- > From: Suanming Mou > Sent: Wednesday, June 5, 2024 11:37 > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Ori Kam ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v2] net/mlx5: support match with E-Switch manager > > Currently, in switch mode, m

[PATCH v3 5/5] dts: add `show port stats` command to TestPmdShell

2024-06-05 Thread Luca Vizzarro
Add a new TestPmdPortStats data structure to represent the output returned by `show port stats`, which is implemented as part of TestPmdShell. Bugzilla ID: 1407 Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/remote_session/testpmd_shell.py | 75 +++

[PATCH v3 4/5] dts: add `show port info` command to TestPmdShell

2024-06-05 Thread Luca Vizzarro
Add a new TestPmdPort data structure to represent the output returned by `show port info`, which is implemented as part of TestPmdShell. The TestPmdPort data structure and its derived classes are modelled based on the relevant testpmd source code. This implementation makes extensive use of regula

[PATCH v3 3/5] dts: add parsing utility module

2024-06-05 Thread Luca Vizzarro
Adds parsing text into a custom dataclass. It provides a new `TextParser` dataclass to be inherited. This implements the `parse` method, which combined with the parser functions, it can automatically parse the value for each field. This new utility will facilitate and simplify the parsing of compl

[PATCH v3 2/5] dts: skip first line of send command output

2024-06-05 Thread Luca Vizzarro
The first line of the InteractiveShell send_command method is generally the command input field. This sometimes is unwanted, therefore this commit enables the possibility of omitting the first line from the returned output. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/frame

[PATCH v3 1/5] dts: fix InteractiveShell command prompt filtering

2024-06-05 Thread Luca Vizzarro
When sending a command using an instance of InteractiveShell the output should filter out the trailing shell prompt when returning it. After every command two shell prompts are summoned. One is consumed as it is used as a delimiter for the command output. The second one is not consumed and left for

[PATCH v3 0/5] dts: testpmd show port info/stats

2024-06-05 Thread Luca Vizzarro
v3: - fixed docstrings - changed TextParser.compose signature - explained TextParser further - introduced new DTSError InternalError v2: - refactored parsing utility - changed functionality of the parser for conciseness - added a usage example to the parsing module --- Depends-on: series-32026 ("d

Re: [RFC PATCH v2] dts: skip test cases based on capabilities

2024-06-05 Thread Patrick Robb
On Fri, May 31, 2024 at 12:44 PM Luca Vizzarro wrote: > > In my testing of Jeremy's patches which depend on this one ("Add second > scatter test case"), I've discovered that the Intel E810-C NIC I am > using to test does not automatically show "RX scattered packets: on". > But I've noticed it doe

[PATCH v2] event/dsw: support explicit release only mode

2024-06-05 Thread Mattias Rönnblom
Add the RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE capability to the DSW event device. This feature may be used by an EAL thread to pull more work from the work scheduler, without giving up the option to forward events originating from a previous dequeue batch. This in turn allows an EAL thread to

[PATCH v7 2/3] ethdev: add VXLAN last reserved field

2024-06-05 Thread Rongwei Liu
Add "uint8_t last_rsvd" as union with origin rsvd1. Add RTE_FLOW_FIELD_VXLAN_LAST_RSVD into rte flow packet field. The new union is used by testpmd matching item VXLAN "last_rsvd" and modify target "vxlan_last_rsvd". Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdli

[PATCH v7 3/3] net/mlx5: implement VXLAN last reserved modification

2024-06-05 Thread Rongwei Liu
Implementing the VxLAN last reserved byte modification. Following the RFC, the field is only 1 byte and needs to use the field_length as 8 instead of the real dst_field->size. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst| 5 + drivers/net/mlx5

[PATCH v7 1/3] app/testpmd: fix the testpmd field string sequence

2024-06-05 Thread Rongwei Liu
The field string should be in the same order as the rte_flow_field_id enumration definitions Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c |

[PATCH v7 0/3] support VXLAN last reserved byte modification

2024-06-05 Thread Rongwei Liu
v7: squash, add more commit logs. v6: add union into vxlan header. v5: change the field enumeration naming. v4: specify the limitation with exact port number. v3: squash testpmd and rte_flow into one commit. v2: patch split. Rongwei Liu (3): app/testpmd: fix the testpmd field string sequence e

Re: [PATCH v2 3/5] dts: add parsing utility module

2024-06-05 Thread Luca Vizzarro
On 05/06/2024 13:19, Juraj Linkeš wrote: +    return cls.compose(partial(int, base=int_base), cls.find(pattern)) + +    """ END PARSER FUNCTIONS """ + +    @classmethod +    def parse(cls, text: str) -> Self: Would converting this into __init__(self, text: str) work

Re: [PATCH v2 3/5] dts: add parsing utility module

2024-06-05 Thread Juraj Linkeš
+ +    """ BEGIN PARSER FUNCTIONS """ + +    @staticmethod +    def compose(f: Callable, parser_fn: ParserFn) -> ParserFn: +    """Makes a composite parser function. + +    The parser function is run and if a non-None value was returned, f is called with it.

Re: [PATCH v6 2/4] net: add new union into VXLAN header

2024-06-05 Thread Thomas Monjalon
05/06/2024 13:28, rongwei liu: > From: Thomas Monjalon > > 05/06/2024 12:21, Rongwei Liu: > > > Add "uint8_t last_rsvd" as union with origin rsvd1. > > > > You should explain why: for matching what we have in testpmd. > > I think it should be squashed with the next patch. > > Sure. Let' squash t

RE: [PATCH v6 2/4] net: add new union into VXLAN header

2024-06-05 Thread rongwei liu
BR Rongwei > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, June 5, 2024 18:42 > To: rongwei liu > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > > Subject: Re: [PATCH v6 2/4] net: add new union into VXLAN header > > External email: Use ca

Re: [PATCH v2 5/5] dts: add `show port stats` command to TestPmdShell

2024-06-05 Thread Luca Vizzarro
Ack.

Re: [PATCH v2 4/5] dts: add `show port info` command to TestPmdShell

2024-06-05 Thread Luca Vizzarro
Ack.

Re: [PATCH] net/i40e: increase descriptor queue length to 8160

2024-06-05 Thread Igor Gutorov
On Mon, Jun 3, 2024 at 1:41 PM Igor Gutorov wrote: > > On Mon, May 27, 2024 at 7:20 PM Igor Gutorov wrote: > > > > According to the Intel X710/XXV710/XL710 Datasheet, the maximum receive > > queue descriptor length is 0x1FE0 (8160 in base 10). This is specified > > as QLEN in table 8-12, page 108

Re: [PATCH v6 2/4] net: add new union into VXLAN header

2024-06-05 Thread Thomas Monjalon
05/06/2024 12:21, Rongwei Liu: > Add "uint8_t last_rsvd" as union with origin rsvd1. You should explain why: for matching what we have in testpmd. I think it should be squashed with the next patch. > - uint8_trsvd1;/**< Reserved. */ > + union { > +

Re: [PATCH v2 3/5] dts: add parsing utility module

2024-06-05 Thread Luca Vizzarro
On 04/06/2024 16:13, Juraj Linkeš wrote: I'd like to see a high level explanation of what the key pieces of the parsing are and how they're tied to the implementation: 1. The text we're about to parse, passed to the instance of a subclass 2. What we're parsing, the fields of the subclass 3. How

[PATCH v6 4/4] net/mlx5: implement VXLAN last reserved modification

2024-06-05 Thread Rongwei Liu
Implementing the VxLAN last reserved byte modification. Following the RFC, the field is only 1 byte and needs to use the field_length as 8 instead of the real dst_field->size. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst| 5 + drivers/net/mlx5

[PATCH v6 3/4] ethdev: add VXLAN last reserved field

2024-06-05 Thread Rongwei Liu
Add VXLAN last reserved byte in rte flow packet field. Add 'vxlan_last_rsvd' as the modification command string. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 1 + lib/ethdev/rte_flow.h | 1 + 2 files changed, 2 insertions(+) diff --git a/app/te

[PATCH v6 2/4] net: add new union into VXLAN header

2024-06-05 Thread Rongwei Liu
Add "uint8_t last_rsvd" as union with origin rsvd1. Signed-off-by: Rongwei Liu --- lib/net/rte_vxlan.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/net/rte_vxlan.h b/lib/net/rte_vxlan.h index 997fc784fc..57300fb442 100644 --- a/lib/net/rte_vxlan.h +++ b/lib/net/rte

[PATCH v6 1/4] app/testpmd: fix the testpmd field string sequence

2024-06-05 Thread Rongwei Liu
The field string should be in the same order as the rte_flow_field_id enumration definitions Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c |

[PATCH v6 0/4] support VXLAN last reserved byte modification

2024-06-05 Thread Rongwei Liu
Support to modify VXLAN last reserved byte. v6: add union into vxlan header. v5: change the field enumeration naming. v4: specify the limitation with exact port number. v3: squash testpmd and rte_flow into one commit. v2: patch split. Rongwei Liu (4): app/testpmd: fix the testpmd field string s

Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field

2024-06-05 Thread Thomas Monjalon
05/06/2024 11:41, rongwei liu: > From: Thomas Monjalon > > 05/06/2024 10:14, rongwei liu: > > > > > > > In this patch, "vxlan_last_rsvd" is used in testpmd, so it > > > > > > > matches > > > > > > > existing "last_rsvd" field in VXLAN item. If we choose to use > > > > > > > "rsvd1", > > > > > > >

Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field

2024-06-05 Thread rongwei liu
BR Rongwei From: Thomas Monjalon Sent: Wednesday, June 5, 2024 17:35 To: rongwei liu Cc: Dariusz Sosnowski ; dev@dpdk.org ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; Suanming Mou ; Aman Singh ; Yuying Zhang ; Ferruh Yigit ; Andrew Rybchenko Subject: Re:

[PATCH v2] net/mlx5: support match with E-Switch manager

2024-06-05 Thread Suanming Mou
Currently, in switch mode, mlx5 PMD only supports match with dedicated vport. There is a use case which user may want to offload the rules only to match with all the packet sent by application not from vport. Since the port_id info of packet sent by application is E-Switch manager, and kernel driv

Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field

2024-06-05 Thread Thomas Monjalon
05/06/2024 10:14, rongwei liu: > > > > > In this patch, "vxlan_last_rsvd" is used in testpmd, so it matches > > > > > existing "last_rsvd" field in VXLAN item. If we choose to use > > > > > "rsvd1", > > > > > we should probably rename all other instances of "last_rsvd" to > > > > > match.> > > > >

[PATCH v2 2/3] net/mlx5: rename external Rx queue to external queue

2024-06-05 Thread Suanming Mou
Due to external Tx queue will be supported, in order to reuse the external queue struct, rename the current external Rx queue to external queue. Signed-off-by: Suanming Mou Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/linux/mlx5_os.c | 2 +- drivers/net/mlx5/mlx5.h | 2 +- driver

[PATCH v2 1/3] net/mlx5: add match with Tx queue item

2024-06-05 Thread Suanming Mou
With the item RTE_FLOW_ITEM_TYPE_TX_QUEUE, user will be able to set the Tx queue index and create flow match with that queue index. This commit adds match with RTE_FLOW_ITEM_TX_QUEUE item. Signed-off-by: Suanming Mou Acked-by: Dariusz Sosnowski --- doc/guides/nics/features/mlx5.ini | 1 +

[PATCH v2 3/3] net/mlx5: add external Tx queue map and unmap

2024-06-05 Thread Suanming Mou
For using external created Tx queues in RTE_FLOW_ITEM_TX_QUEUE, this commit provides the map and unmap functions to convert the external created SQ's devx ID to DPDK flow item Tx queue ID. Signed-off-by: Suanming Mou --- v2: add feature and release notes. --- doc/guides/nics/mlx5.rst

RE: [PATCH 1/2] net/mlx5: support match with switch manager

2024-06-05 Thread Suanming Mou
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Wednesday, June 5, 2024 4:34 PM > To: Suanming Mou ; Slava Ovsiienko > ; Ori Kam ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: RE: [PATCH 1/2] net/mlx5: support match with switch manager > > > -Original Me

[PATCH v1 1/1] crypto/ipsec_mb: unify some IPsec MB PMDs

2024-06-05 Thread Brian Dooley
Currently IPsec MB provides both the JOB API and direct API. AESNI_MB PMD is using the JOB API codepath while KASUMI and CHACHA20_POLY1305 are using the direct API. Instead of using the direct API for these PMDs, they should now make use of the JOB API codepath. This would remove all use of the IPs

[PATCH v1 0/1] Unifying IPsec MB

2024-06-05 Thread Brian Dooley
Unifying some PMDs in the ipsec_mb crypto driver As discussed previously on the mailing list: https://patches.dpdk.org/project/dpdk/patch/20240228113301.934291-1-brian.doo...@intel.com/ Brian Dooley (1): crypto/ipsec_mb: unify some IPsec MB PMDs doc/guides/rel_notes/release_24_07.rst|

[PATCH v1] crypto/ipsec_mb: use new ipad/opad calculation API

2024-06-05 Thread Brian Dooley
From: Pablo de Lara IPSec Multi-buffer library v1.4 added a new API to calculate inner/outer padding for HMAC-SHAx/MD5. Signed-off-by: Pablo de Lara Signed-off-by: Brian Dooley --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 34 +- 1 file changed, 33 insertions(+), 1 dele

[PATCH v5 3/3] net/mlx5: implement VXLAN last reserved modification

2024-06-05 Thread Rongwei Liu
Implementing the VxLAN last reserved byte modification. Following the RFC, the field is only 1 byte and needs to use the field_length as 8 instead of the real dst_field->size. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst| 5 + drivers/net/mlx5

[PATCH v5 2/3] ethdev: add VXLAN last reserved field

2024-06-05 Thread Rongwei Liu
Add VXLAN last reserved byte in rte flow packet field. Add 'vxlan_last_rsvd' as the modification command string. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 1 + lib/ethdev/rte_flow.h | 1 + 2 files changed, 2 insertions(+) diff --git a/app/te

[PATCH v5 1/3] app/testpmd: fix the testpmd field string sequence

2024-06-05 Thread Rongwei Liu
The field string should be in the same order as the rte_flow_field_id enumration definitions Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c |

[PATCH v5 0/3] support VXLAN last reserved byte modification

2024-06-05 Thread Rongwei Liu
Support to modify VXLAN last reserved byte. v5: change the field enumeration naming. v4: specify the limitation with exact port number. v3: squash testpmd and rte_flow into one commit. v2: patch split. Rongwei Liu (3): app/testpmd: fix the testpmd field string sequence ethdev: add VXLAN last

RE: [PATCH 1/2] net/mlx5: support match with switch manager

2024-06-05 Thread Dariusz Sosnowski
> -Original Message- > From: Suanming Mou > Sent: Friday, May 31, 2024 05:52 > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Ori Kam ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 1/2] net/mlx5: support match with switch manager > > Currently, in switch mode, mlx5

RE: [PATCH 3/3] net/mlx5: add external Tx queue map and unmap

2024-06-05 Thread Suanming Mou
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Wednesday, June 5, 2024 4:17 PM > To: Suanming Mou ; Slava Ovsiienko > ; Ori Kam ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: RE: [PATCH 3/3] net/mlx5: add external Tx queue map and unmap > > > -Original

RE: [PATCH 3/3] net/mlx5: add external Tx queue map and unmap

2024-06-05 Thread Dariusz Sosnowski
> -Original Message- > From: Suanming Mou > Sent: Friday, May 31, 2024 05:51 > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Ori Kam ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 3/3] net/mlx5: add external Tx queue map and unmap > > For using external created Tx

Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field

2024-06-05 Thread rongwei liu
BR Rongwei From: Thomas Monjalon Sent: Wednesday, June 5, 2024 15:13 To: Dariusz Sosnowski ; rongwei liu Cc: dev@dpdk.org ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; Suanming Mou ; Aman Singh ; Yuying Zhang ; Ferruh Yigit ; Andrew Rybchenko Subject: Re:

RE: [PATCH 2/3] net/mlx5: rename external Rx queue to external queue

2024-06-05 Thread Dariusz Sosnowski
> -Original Message- > From: Suanming Mou > Sent: Friday, May 31, 2024 05:51 > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Ori Kam ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 2/3] net/mlx5: rename external Rx queue to external queue > > Due to external Tx queu

RE: [PATCH 1/3] net/mlx5: add match with Tx queue item

2024-06-05 Thread Dariusz Sosnowski
> -Original Message- > From: Suanming Mou > Sent: Friday, May 31, 2024 05:51 > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Ori Kam ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 1/3] net/mlx5: add match with Tx queue item > > With the item RTE_FLOW_ITEM_TYPE_TX_Q

[V3 1/2] net: extend VXLAN header to support more extensions

2024-06-05 Thread Gavin Li
VXLAN and VXLAN-GPE were supported with similar header structures. In order to add VXLAN-GBP, which is another extension to VXLAN, both extensions are merged in the original VXLAN header structure for an easier usage. More VXLAN extensions may be added in the future in the same single structure. V

[V3 2/2] app/testpmd: support matching any VXLAN field

2024-06-05 Thread Gavin Li
VXLAN extensions (VXLAN-GPE and VXLAN-GBP) are unified in a single VXLAN flow item. It is user responsibility to explicitly match VXLAN-GPE with its UDP port. Below are examples to match standard VXLAN, VXLAN-GPE and VXLAN-GBP. To match standard vxlan, ... / udp dst is 4789 / vxlan ... / ... To ma

[V3 0/2] net: extend VXLAN header to support more extensions

2024-06-05 Thread Gavin Li
In this patch series, all the VXLAN extension header will be merged with VXLAN as union if the overlapped field has different format among protocols. The existing VXLAN-GPE will be marked as deprecated and new extensions of VXLAN should be added to VXLAN instead of a new RTE item. RFC https://patc

Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field

2024-06-05 Thread Thomas Monjalon
05/06/2024 03:16, rongwei liu: > From: Thomas Monjalon > > 04/06/2024 18:40, Dariusz Sosnowski: > > > > > 04/06/2024 14:38, Rongwei Liu: > > > > > > --- a/app/test-pmd/cmdline_flow.c > > > > > > +++ b/app/test-pmd/cmdline_flow.c > > > > > > @@ -1006,6 +1006,7 @@ static const char *const flow_field

[PATCH 5/5] eal: provide option to use compiler memcpy instead of RTE

2024-06-05 Thread Mattias Rönnblom
Provide build option to have functions in delegate to the standard compiler/libc memcpy(), instead of using the various custom DPDK, handcrafted, per-architecture rte_memcpy() implementations. A new meson build option 'use_cc_memcpy' is added. By default, the compiler/libc memcpy() is used. The

[PATCH 1/5] event/dlb2: include headers for vector and memory copy APIs

2024-06-05 Thread Mattias Rönnblom
The DLB2 PMD depended on being included as a side-effect of being included. In addition, DLB2 used rte_memcpy() but did not include , but rather depended on other include files to do so. This patch addresses both of those issues. Signed-off-by: Mattias Rönnblom --- drivers/event/dlb2/dlb2.c

[PATCH 0/5] Optionally have rte_memcpy delegate to compiler memcpy

2024-06-05 Thread Mattias Rönnblom
This patch set make DPDK library, driver, and application code use the compiler/libc memcpy() by default when functions in are invoked. The various custom DPDK rte_memcpy() implementations may be retained by means of a build-time option. This patch set only make a difference on x86, PPC and ARM.

[PATCH 3/5] distributor: properly include vector API header file

2024-06-05 Thread Mattias Rönnblom
The distributor library relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom --- lib/distributor/rte_distributor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/distributor/rte_distributor.c b/lib/distributor/rte_distributor.c index e58727cd

[PATCH 4/5] fib: properly include vector API header file

2024-06-05 Thread Mattias Rönnblom
The trie implementation of the fib library relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom --- lib/fib/trie.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/fib/trie.c b/lib/fib/trie.c index 09470e7287..74db8863df 100644 --- a/lib/fib/tri

[PATCH 2/5] net/octeon_ep: properly include vector API header file

2024-06-05 Thread Mattias Rönnblom
The octeon_ip driver relied on , but failed to provide a direct include of this file. Signed-off-by: Mattias Rönnblom --- drivers/net/octeon_ep/otx_ep_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/octeon_ep/otx_ep_ethdev.c b/drivers/net/octeon_ep/otx_ep_ethdev.c ind