On Wed, 5 Jun 2024 05:48:39 +0000 "Wani, Shaiq" <shaiq.w...@intel.com> wrote:
> > + if (uname(&unamedata) != 0) > > + PMD_INIT_LOG(ERR, "Cannot fetch node_name for host\n"); No newline needed. > > + else if (strstr(unamedata.nodename, "ipu-imc")) > > + PMD_INIT_LOG(ERR, "CPFL PMD cannot be running on IMC."); > > + else if (strstr(unamedata.nodename, "ipu-acc")) > > + host_id = CPFL_HOST_ID_ACC; > > The nodename in uname is the same as the hostname. > This can be changed by user, is that ok? > > We are making an assumption that user will not have hostname as ipu-acc or > ipu-imc. > If this is okay, I will upload a new patch taking care of the blank line > between the functions. > > Also, please put one blank line between functions, it makes code easier to > read. > The blank line is not important, but there is something that is worth adding. Could you add something to the NIC documentation and/or release notes if necessary.
