Re: [PATCH v8 2/2] dts: Change hugepage 'amount' to a different term

2024-05-30 Thread Juraj Linkeš
On Thu, May 30, 2024 at 9:38 PM Nicholas Pratte wrote: > > The term 'amount' is used for uncountable nouns. Since total hugepages > is a discrete value (i.e. countable), the declaration of the 'amount' > key value pair should be changes to a different term in both the config > and the rest of the

Re: [PATCH v8 1/2] dts: Change hugepage runtime config to 2MB Exclusively

2024-05-30 Thread Juraj Linkeš
On Thu, May 30, 2024 at 9:38 PM Nicholas Pratte wrote: > > The previous implementation configures and allocates hugepage sizes > based on a system default. This can lead to two problems: overallocation of > hugepages (which may crash the remote host), and configuration of hugepage > sizes that are

Re: [RFC v2] eal: provide option to use compiler memcpy instead of RTE

2024-05-30 Thread Mattias Rönnblom
On 2024-05-28 17:09, Bruce Richardson wrote: On Tue, May 28, 2024 at 07:59:36AM -0700, Stephen Hemminger wrote: On Tue, 28 May 2024 10:19:15 +0200 Mattias Rönnblom wrote: I've tested this patch some with DSW micro benchmarks, and the result is a 2.5% reduction of the DSW+testapp overhead

[PATCH 2/2] net/mlx5/hws: add match with switch manager

2024-05-30 Thread Suanming Mou
This commit adds HWS layer match with switch manager code. Signed-off-by: Suanming Mou --- drivers/net/mlx5/hws/mlx5dr_definer.c | 3 ++- drivers/net/mlx5/hws/mlx5dr_definer.h | 5 - drivers/net/mlx5/hws/mlx5dr_rule.c| 2 +- drivers/net/mlx5/mlx5_flow.h | 30 +

[PATCH 1/2] net/mlx5: support match with switch manager

2024-05-30 Thread Suanming Mou
Currently, in switch mode, mlx5 PMD only supports match with dedicate vport. There is a usercase which user may want to offload the rules only to match with all the pkt sent by application not from vport. Since the port_id info of pkt sent by application is switch manager, and kernel driver has ex

[PATCH 3/3] net/mlx5: add external Tx queue map and unmap

2024-05-30 Thread Suanming Mou
For using external created Tx queues in RTE_FLOW_ITEM_TX_QUEUE, this commit provides the map and unmap functions to convert the external created SQ's devx ID to DPDK flow item Tx queue ID. Signed-off-by: Suanming Mou --- drivers/net/mlx5/linux/mlx5_os.c | 12 ++- drivers/net/mlx5/mlx5.c

[PATCH 2/3] net/mlx5: rename external Rx queue to external queue

2024-05-30 Thread Suanming Mou
Due to external Tx queue will be supported, in order to reuse the external queue struct, rename the current external Rx queue to external queue. Signed-off-by: Suanming Mou --- drivers/net/mlx5/linux/mlx5_os.c | 2 +- drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_devx.c |

[PATCH 1/3] net/mlx5: add match with Tx queue item

2024-05-30 Thread Suanming Mou
With the item RTE_FLOW_ITEM_TYPE_TX_QUEUE, user will be able to set the Tx queue index and create flow match with that queue index. This commit adds match with RTE_FLOW_ITEM_TX_QUEUE item. Signed-off-by: Suanming Mou --- doc/guides/nics/features/mlx5.ini | 1 + doc/guides/rel_notes/releas

BPF standardization

2024-05-30 Thread Stephen Hemminger
It would be good to make sure that DPDK BPF conforms to IETF draft. https://datatracker.ietf.org/doc/draft-ietf-bpf-isa/ Based on LWN article on presentation at Linux Storage, Filesystem, Memory Mangerment, and BPF Summit. https://lwn.net/SubscriberLink/975830/3b32df6be23d3abf/

Re: [PATCH v3 2/2] dts: clean up config types

2024-05-30 Thread Jeremy Spewock
Reviewed-by: Jeremy Spewock

Re: [PATCH v3 1/2] dts: update mypy static checker

2024-05-30 Thread Jeremy Spewock
Reviewed-by: Jeremy Spewock

Re: [PATCH v3 8/8] dts: use Unpack for type checking and hinting

2024-05-30 Thread Jeremy Spewock
Reviewed-by: Jeremy Spewock

Re: [PATCH v3 7/8] dts: rework interactive shells

2024-05-30 Thread Jeremy Spewock
Reviewed-by: Jeremy Spewock

Re: [PATCH v3 6/8] dts: use testpmd params for scatter test suite

2024-05-30 Thread Jeremy Spewock
Reviewed-by: Jeremy Spewock

Re: [PATCH v3 5/8] dts: add testpmd shell params

2024-05-30 Thread Jeremy Spewock
Reviewed-by: Jeremy Spewock

Re: [PATCH v3 4/8] dts: remove module-wide imports

2024-05-30 Thread Jeremy Spewock
Reviewed-by: Jeremy Spewock

Re: [PATCH v3 3/8] dts: refactor EalParams

2024-05-30 Thread Jeremy Spewock
Reviewed-by: Jeremy Spewock

Re: [PATCH v3 2/8] dts: use Params for interactive shells

2024-05-30 Thread Jeremy Spewock
Reviewed-by: Jeremy Spewock

Re: [PATCH v3 1/8] dts: add params manipulation module

2024-05-30 Thread Jeremy Spewock
Reviewed-by: Jeremy Spewock

[PATCH v8 2/2] dts: Change hugepage 'amount' to a different term

2024-05-30 Thread Nicholas Pratte
The term 'amount' is used for uncountable nouns. Since total hugepages is a discrete value (i.e. countable), the declaration of the 'amount' key value pair should be changes to a different term in both the config and the rest of the code. Bugzilla ID: 1370 Signed-off-by: Nicholas Pratte Reviewed-

[PATCH v8 1/2] dts: Change hugepage runtime config to 2MB Exclusively

2024-05-30 Thread Nicholas Pratte
The previous implementation configures and allocates hugepage sizes based on a system default. This can lead to two problems: overallocation of hugepages (which may crash the remote host), and configuration of hugepage sizes that are not recommended during runtime. This new implementation allows on

[PATCH v8 0/2] Methodology change for hugepage configuration

2024-05-30 Thread Nicholas Pratte
In order to prevent accidental misconfiguration of hugepages at runtime, the following changes are made to only allow for configuration of 2MB hugepages within the DTS config.yaml. In the previous implementation, a default hugepage size was selected via the size listed in /proc/meminfo. The problem

Re: [PATCH v5 3/3] dts: store stderr in RemoteCommandExecutionError

2024-05-30 Thread Luca Vizzarro
On 30/05/2024 16:47, Juraj Linkeš wrote: @@ -129,21 +130,27 @@ class RemoteCommandExecutionError(DTSError): severity: ClassVar[ErrorSeverity] = ErrorSeverity.REMOTE_CMD_EXEC_ERR #: The executed command. command: str +_command_stderr: str _command_return_code: int -

Re: [PATCH v5 2/3] dts: constrain DPDK source argument

2024-05-30 Thread Luca Vizzarro
On 30/05/2024 16:41, Juraj Linkeš wrote: - [DTS_CFG_FILE] The configuration file that describes the test cases, SUTs and targets. - (default: conf.yaml) + [DTS_CFG_FILE] The configuration file that describes the test

Re: [PATCH v5 1/3] dts: rework arguments framework

2024-05-30 Thread Luca Vizzarro
On 30/05/2024 16:30, Juraj Linkeš wrote: There is a difference in behavior when I pass no arguments and then I either have or don't have an env var set: ./main.py usage: main.py [-h] [--config-file FILE_PATH] ... ... - DTS_SKIP_SETUP=Y ./main.py main.py: error: one of

[PATCH v8 0/2] Methodology change for hugepage configuration

2024-05-30 Thread Nicholas Pratte
In order to prevent accidental misconfiguration of hugepages at runtime, the following changes are made to only allow for configuration of 2MB hugepages within the DTS config.yaml. In the previous implementation, a default hugepage size was selected via the size listed in /proc/meminfo. The problem

[PATCH v7 2/2] dts: Change hugepage 'amount' to a different term

2024-05-30 Thread Nicholas Pratte
The term 'amount' is used for uncountable nouns. Since total hugepages is a discrete value (i.e. countable), the declaration of the 'amount' key value pair should be changes to a different term in both the config and the rest of the code. --- * v8: Decided on a variable name "number_of" to be used

[PATCH v7 1/2] dts: Change hugepage runtime config to 2MB Exclusively

2024-05-30 Thread Nicholas Pratte
The previous implementation configures and allocates hugepage sizes based on a system default. This can lead to two problems: overallocation of hugepages (which may crash the remote host), and configuration of hugepage sizes that are not recommended during runtime. This new implementation allows on

[PATCH v7 0/2] Methodology change for hugepage configuration

2024-05-30 Thread Nicholas Pratte
In order to prevent accidental misconfiguration of hugepages at runtime, the following changes are made to only allow for configuration of 2MB hugepages within the DTS config.yaml. In the previous implementation, a default hugepage size was selected via the size listed in /proc/meminfo. The problem

[PATCH] net/virtio: fix MAC table update

2024-05-30 Thread skoteshwar
From: Satha Rao Don't send NULL MAC addresses in MAC table update. Fixes: 1b306359e58 ("virtio: suport multiple MAC addresses") Cc: step...@networkplumber.org Cc: sta...@dpdk.org Signed-off-by: Satha Rao --- drivers/net/virtio/virtio_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --gi

RE: [EXTERNAL] Re: [PATCH v3 1/2] eventdev/dma: reorganize event DMA ops

2024-05-30 Thread Pavan Nikhilesh Bhagavatula
> On Thu, May 16, 2024 at 1:09 PM Amit Prakash Shukla > wrote: > > > > > -Original Message- > > > From: pbhagavat...@marvell.com > > > Sent: Wednesday, April 17, 2024 1:57 PM > > > To: Jerin Jacob ; Amit Prakash Shukla > > > ; Vamsi Krishna Attunuru > > > > > > Cc: dev@dpdk.org; Pavan Ni

[PATCH 2/2] eal/riscv: add support for zicbop extension

2024-05-30 Thread Daniel Gregory
The zicbop extension adds instructions for prefetching data into cache. Use them to implement RISCV-specific versions of the rte_prefetch* and rte_prefetch*_write functions. - prefetch.r indicates to hardware that the cache block will be accessed by a data read soon - prefetch.w indicates to har

[PATCH 1/2] eal: add flag to hide generic prefetch_write

2024-05-30 Thread Daniel Gregory
This allows for the definition of architecture-specific implementations of the rte_prefetch*_write collection of functions by defining RTE_PREFETCH_WRITE_ARCH_DEFINED. Signed-off-by: Daniel Gregory --- lib/eal/include/generic/rte_prefetch.h | 47 +- 1 file changed, 31 ins

[PATCH 0/2] eal/riscv: implement prefetch using zicbop

2024-05-30 Thread Daniel Gregory
Instructions from RISC-V's Zicbop extension can be used to implement the rte_prefetch* family of functions. On modern versions of GCC (13.1.0+) and Clang (17.0.1+), these are emitted by __builtin_prefetch() when the extension is present. In order to support older compiler versions, this patchset m

[PATCH v5] eal: verify mmu type for DPDK support (ppc64le)

2024-05-30 Thread David Christensen
From: David Christensen IBM POWER systems support more than one type of memory management unit (MMU). The Power ISA 3.0 specification, which applies to P9 and later CPUs, defined a new Radix MMU which, among other things, allows an anonymous memory page mapping to be converted into a hugepage ma

[PATCH v2 2/4] dts: add context manager for interactive shells

2024-05-30 Thread jspewock
From: Jeremy Spewock Interactive shells are managed in a way currently where they are closed and cleaned up at the time of garbage collection. Due to there being no guarantee of when this garbage collection happens in Python, there is no way to consistently know when an application will be closed

[PATCH v2 4/4] dts: add test case that utilizes offload to pmd_buffer_scatter

2024-05-30 Thread jspewock
From: Jeremy Spewock Some NICs tested in DPDK allow for the scattering of packets without an offload and others enforce that you enable the scattered_rx offload in testpmd. The current version of the suite for testing support of scattering packets only tests the case where the NIC supports testin

[PATCH v2 3/4] dts: add methods for modifying MTU to testpmd shell

2024-05-30 Thread jspewock
From: Jeremy Spewock There are methods within DTS currently that support updating the MTU of ports on a node, but the methods for doing this in a linux session rely on the ip command and the port being bound to the kernel driver. Since test suites are run while bound to the driver for DPDK, there

[PATCH v2 1/4] dts: improve starting and stopping interactive shells

2024-05-30 Thread jspewock
From: Jeremy Spewock The InteractiveShell class currently relies on being cleaned up and shutdown at the time of garbage collection, but this cleanup of the class does no verification that the session is still running prior to cleanup. So, if a user were to call this method themselves prior to ga

[PATCH v2 0/4] Add second scatter test case

2024-05-30 Thread jspewock
From: Jeremy Spewock This version addresses comments from the last which featured new improvements such as the usage of the Self typehint in the critical interactive shell, modifying the MTU of all ports within the scope of testpmd rather than making a guess as to which should be changed, and som

Community CI Meeting Minutes - May 30, 2024

2024-05-30 Thread Patrick Robb
May 30, 2024 # Attendees 1. Patrick Robb 2. Adam Hassick 3. Nicholas Pratte 4. Paul Szczepanek 5. Jeremy Spewock 6. Dean Marx 7. Aaron Conole 8. Juraj Linkeš # M

Re: [PATCH v5 3/3] dts: store stderr in RemoteCommandExecutionError

2024-05-30 Thread Juraj Linkeš
> diff --git a/dts/framework/exception.py b/dts/framework/exception.py > index cce1e0231a..50724acdf2 100644 > --- a/dts/framework/exception.py > +++ b/dts/framework/exception.py > @@ -2,6 +2,7 @@ > # Copyright(c) 2010-2014 Intel Corporation > # Copyright(c) 2022-2023 PANTHEON.tech s.r.o. > # Co

Re: [PATCH v5 2/3] dts: constrain DPDK source argument

2024-05-30 Thread Juraj Linkeš
> diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst > index 6993443389..f64ab7f732 100644 > --- a/doc/guides/tools/dts.rst > +++ b/doc/guides/tools/dts.rst > @@ -215,41 +215,38 @@ DTS is run with ``main.py`` located in the ``dts`` > directory after entering Poet > .. code-block:: c

[PATCH v8] eal/x86: improve rte_memcpy const size 16 performance

2024-05-30 Thread Morten Brørup
When the rte_memcpy() size is 16, the same 16 bytes are copied twice. In the case where the size is known to be 16 at build time, omit the duplicate copy. Reduced the amount of effectively copy-pasted code by using #ifdef inside functions instead of outside functions. Suggested-by: Stephen Hemmin

Re: [PATCH v5 1/3] dts: rework arguments framework

2024-05-30 Thread Juraj Linkeš
The overall approach looks solid. Maybe we can do some minor improvements on it, but it's honestly fine the way it's now. There is a difference in behavior when I pass no arguments and then I either have or don't have an env var set: ./main.py usage: main.py [-h] [--config-file FILE_PATH] ... ...

[PATCH v3 8/8] dts: use Unpack for type checking and hinting

2024-05-30 Thread Luca Vizzarro
Interactive shells that inherit DPDKShell initialise their params classes from a kwargs dict. Therefore, static type checking is disabled. This change uses the functionality of Unpack added in PEP 692 to re-enable it. The disadvantage is that this functionality has been implemented only with TypedD

[PATCH v3 7/8] dts: rework interactive shells

2024-05-30 Thread Luca Vizzarro
The way nodes and interactive shells interact makes it difficult to develop for static type checking and hinting. The current system relies on a top-down approach, attempting to give a generic interface to the test developer, hiding the interaction of concrete shell classes as much as possible. Whe

[PATCH v3 6/8] dts: use testpmd params for scatter test suite

2024-05-30 Thread Luca Vizzarro
Update the buffer scatter test suite to use TestPmdParameters instead of the StrParams implementation. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/tests/TestSuite_pmd_buffer_scatter.py | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/d

[PATCH v3 5/8] dts: add testpmd shell params

2024-05-30 Thread Luca Vizzarro
Implement all the testpmd shell parameters into a data structure. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/params/testpmd.py | 609 ++ dts/framework/remote_session/testpmd_shell.py | 42 +- dts/tests/TestSuite_pmd_buffer_scatter.

[PATCH v3 4/8] dts: remove module-wide imports

2024-05-30 Thread Luca Vizzarro
Remove the imports in the testbed_model and remote_session modules init file, to avoid the initialisation of unneeded modules, thus removing or limiting the risk of circular dependencies. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/remote_session/__init__.py

[PATCH v3 3/8] dts: refactor EalParams

2024-05-30 Thread Luca Vizzarro
Move EalParams to its own module to avoid circular dependencies. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/params/eal.py | 50 +++ dts/framework/remote_session/testpmd_shell.py | 2 +- dts/framework/testbed_model/sut_node.py

[PATCH v3 2/8] dts: use Params for interactive shells

2024-05-30 Thread Luca Vizzarro
Make it so that interactive shells accept an implementation of `Params` for app arguments. Convert EalParameters to use `Params` instead. String command line parameters can still be supplied by using the `Params.from_str()` method. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek ---

[PATCH v3 1/8] dts: add params manipulation module

2024-05-30 Thread Luca Vizzarro
This commit introduces a new "params" module, which adds a new way to manage command line parameters. The provided Params dataclass is able to read the fields of its child class and produce a string representation to supply to the command line. Any data structure that is intended to represent comma

[PATCH v3 0/8] dts: add testpmd params

2024-05-30 Thread Luca Vizzarro
v3: - refactored InteractiveShell methods - fixed docstrings v2: - refactored the params module - strengthened typing of the params module - moved the params module into its own package - refactored EalParams and TestPmdParams and moved under the params package - reworked interactions between nod

[PATCH v3 2/2] dts: clean up config types

2024-05-30 Thread Luca Vizzarro
Clean up types used with the configuration classes, and use Self from the newly added typing_extensions module. Methods that instantiate their own class should be @classmethod instead of @staticmethod. Bugzilla ID: 1433 Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framewo

[PATCH v3 1/2] dts: update mypy static checker

2024-05-30 Thread Luca Vizzarro
Update the mypy static checker to the latest version and fix all the reported errors. Bump up supported Poetry shell version. Bugzilla ID: 1433 Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- doc/guides/tools/dts.rst | 2 +- dts/Dockerfile

[PATCH v3 0/2] dts: update mypy and clean up

2024-05-30 Thread Luca Vizzarro
v3: - reverted changes to run() function and made it a typed one - updated Poetry version to 1.8.2 v2: - apply fix to error formatting bug in framework/testbed_model/traffic_generator/__init__.py Luca Vizzarro (2): dts: update mypy static checker dts: clean up config types doc/guides/tool

Re: [PATCH v3 00/30] Update IXGBE base driver

2024-05-30 Thread Bruce Richardson
On Thu, May 30, 2024 at 12:13:33PM +0100, Anatoly Burakov wrote: > This patchset updates IXGBE base driver to latest shared code snapshot, > fixing a few issues as well as adding support for new hardware. > > v3: > - Split out big patch with definitions into a separate patch > - Split out the "mis

[PATCH v1 16/17] net/ntnic: add link 100G module

2024-05-30 Thread Serhii Iliushyk
Add ntnic 100G link support. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/nt4ga_link.h| 8 + .../link_mgmt/link_100g/nt4ga_link_100g.c | 840 .../link_mgmt/link_100g/nt4ga_link_100g.h | 11 + .../net/ntnic/nthw/core/include/nthw_core.h | 2

[PATCH v1 11/17] net/ntnic: add ethdev and makes PMD available

2024-05-30 Thread Serhii Iliushyk
Add ethdev to ntnic. Signed-off-by: Serhii Iliushyk --- .mailmap |1 + MAINTAINERS|6 + doc/guides/nics/features/ntnic.ini |9 + doc/guides/nics/index.rst |1 + doc/guides/nics/ntnic.rst | 115 +++ drivers/net/m

[PATCH v1 14/17] net/ntnic: add adapter initialization API

2024-05-30 Thread Serhii Iliushyk
Add ntnic adapter initialization API. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 496 ++ drivers/net/ntnic/meson.build | 1 + 2 files changed, 497 insertions(+) create mode 100644 drivers/net/ntnic/adapter/nt4ga_adapter.c di

[PATCH v1 15/17] net/ntnic: add link management module

2024-05-30 Thread Serhii Iliushyk
Add ntnic link control. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/link_mgmt/nt4ga_link.c | 264 +++ 1 file changed, 264 insertions(+) create mode 100644 drivers/net/ntnic/link_mgmt/nt4ga_link.c diff --git a/drivers/net/ntnic/link_mgmt/nt4ga_link.c b/drivers/net/

[PATCH v1 17/17] net/ntnic: add NIM module

2024-05-30 Thread Serhii Iliushyk
Includes support for NIM QSFP and QSFP+. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/meson.build | 20 +- drivers/net/ntnic/nim/i2c_nim.c | 1359 + drivers/net/ntnic/nim/i2c_nim.h | 77 + .../net/ntnic/nim/include/qsfp_regi

[PATCH v1 13/17] net/ntnic: add adapter initialization

2024-05-30 Thread Serhii Iliushyk
Add ntnic HW interfaces (PCIe, I2C) API. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/adapter/nt4ga_pci_ta_tg.c | 550 ++ drivers/net/ntnic/adapter/nt4ga_tfg.c | 69 +++ drivers/net/ntnic/include/nt4ga_tfg.h | 2 + drivers/net/ntnic/include/ntnic_nim.

[PATCH v1 04/17] net/ntnic: add FPGA model implementation

2024-05-30 Thread Serhii Iliushyk
Add ntnic query FPGA functionality. Signed-off-by: Serhii Iliushyk --- .../net/ntnic/nthw/model/nthw_fpga_model.c| 1218 + .../net/ntnic/nthw/model/nthw_fpga_model.h| 247 2 files changed, 1465 insertions(+) create mode 100644 drivers/net/ntnic/nthw/model/nthw_fpga

[PATCH v1 05/17] net/ntnic: add NTNIC adapter interfaces

2024-05-30 Thread Serhii Iliushyk
Add ntnic adapter interfaces structures. Signed-off-by: Serhii Iliushyk --- .../ntnic/include/clock_profiles_structs.h| 69 +++ .../net/ntnic/include/common_adapter_defs.h | 15 ++ drivers/net/ntnic/include/fpga_model.h| 153 +++ drivers/net/ntnic/include/nt4ga_ad

[PATCH v1 08/17] net/ntnic: add interfaces for flow API engine

2024-05-30 Thread Serhii Iliushyk
Add ntnic basic flow filter functionality. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/flow_api.h | 89 ++ drivers/net/ntnic/include/flow_api_actions.h | 13 + drivers/net/ntnic/include/flow_api_engine.h | 46 + drivers/net/ntnic/include/flow_filter.h | 15

[PATCH v1 10/17] net/ntnic: add Logs and utilities implementation

2024-05-30 Thread Serhii Iliushyk
Add ntnic logging API and utilities. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/ntlog/include/ntlog.h| 162 + drivers/net/ntnic/ntlog/ntlog.c| 108 ++ drivers/net/ntnic/ntutil/include/nt_util.h | 51 +++ drivers/net/ntnic/ntutil/nt_u

[PATCH v1 03/17] net/ntnic: add interfaces for platform functionality

2024-05-30 Thread Serhii Iliushyk
Add ntnic structures and prototypes for platform interfaces. Signed-off-by: Serhii Iliushyk --- .../nthw/core/include/nthw_clock_profiles.h | 20 ++ .../net/ntnic/nthw/core/include/nthw_core.h | 32 +++ .../net/ntnic/nthw/core/include/nthw_fpga.h | 54 + .../ntnic/nthw/core/include/

[PATCH v1 09/17] net/ntnic: add VFIO module

2024-05-30 Thread Serhii Iliushyk
Add ntnic VFIO functionality. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/ntnic_vfio.c | 232 + drivers/net/ntnic/ntnic_vfio.h | 21 +++ 2 files changed, 253 insertions(+) create mode 100644 drivers/net/ntnic/ntnic_vfio.c create mode 100644 drivers/net

[PATCH v1 07/17] net/ntnic: add API for PMD driver modules

2024-05-30 Thread Serhii Iliushyk
Add API for ntnic PMD driver modules, thus allow modules to be enabled/disabled. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/dpdk_mod_reg.c | 64 drivers/net/ntnic/dpdk_mod_reg.h | 167 ++ drivers/net/ntnic/ntnic_mod_reg.c | 382 ++ drivers/net/ntnic/

[PATCH v1 06/17] net/ntnic: add interfaces for PMD driver modules

2024-05-30 Thread Serhii Iliushyk
Add ntnic base interfaces for: link, NIM, sensors, statistics. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/nt4ga_link.h| 132 + drivers/net/ntnic/include/ntnic_dbs.h | 356 drivers/net/ntnic/include/ntnic_nim.h | 160 ++ .../include/n

[PATCH v1 02/17] net/ntnic: add core platform functionality

2024-05-30 Thread Serhii Iliushyk
Add ntnic platform interfaces for FPGA registers Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/nthw/nthw_drv.h | 94 +++ drivers/net/ntnic/nthw/nthw_epp.c | 226 ++ drivers/net/ntnic/nthw/nthw_epp.h | 92 +++ drivers/net/ntnic/nthw/nthw_helper.h | 3

RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro

2024-05-30 Thread Morten Brørup
> From: Kundapura, Ganapati [mailto:ganapati.kundap...@intel.com] > Sent: Thursday, 30 May 2024 16.22 > > Hi, > > > From: Akhil Goyal > > Sent: Thursday, May 30, 2024 5:17 PM > > > > > > > #if may not be needed in application. > > > > > Test should be skipped if API is not available/supported. >

[DPDK/ethdev Bug 1448] cannot disable RTE_ETHDEV_RXTX_CALLBACKS from rte_config.h

2024-05-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1448 Morten Brørup (m...@smartsharesystems.com) changed: What|Removed |Added Resolution|--- |INVALID

RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro

2024-05-30 Thread Kundapura, Ganapati
Hi, > -Original Message- > From: Akhil Goyal > Sent: Thursday, May 30, 2024 5:17 PM > To: Kundapura, Ganapati ; dev@dpdk.org; > Gujjar, Abhinandan S ; ferruh.yi...@amd.com; > tho...@monjalon.net; Richardson, Bruce ; > fanzhang@gmail.com; ciara.po...@intel.com; Morten Brørup > > Subje

[DPDK/ethdev Bug 1448] cannot disable RTE_ETHDEV_RXTX_CALLBACKS from rte_config.h

2024-05-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1448 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|RESOLVED|CONFIRMED Resolut

i40e add UDP GENEVE tunnel

2024-05-30 Thread Taras Bilous
Hi All, I see that GENEVE tunnel type is currently not supported in i40e_dev_udp_tunnel_port_add(). Is there any reason for this or a roadmap for when this is planned to be done? I looked into the latest DPDK (24.03) and it is still not available there. I'm using XXV710 with an i40e driver and wa

Re: [PATCH v13 0/6] add pointer compression API

2024-05-30 Thread Paul Szczepanek
Recheck-request: github-robot

[PATCH v4 2/2] dma/cnxk: remove completion pool

2024-05-30 Thread pbhagavatula
From: Pavan Nikhilesh Use DMA ops to store metadata, remove use of completion pool. Signed-off-by: Pavan Nikhilesh Acked-by: Vamsi Attunuru --- drivers/dma/cnxk/cnxk_dmadev.c | 53 drivers/dma/cnxk/cnxk_dmadev.h | 24 +- drivers/dma/cnxk/cnxk_dmadev_fp.c

[PATCH v4 1/2] eventdev/dma: reorganize event DMA ops

2024-05-30 Thread pbhagavatula
From: Pavan Nikhilesh Re-organize event DMA ops structure to allow holding source and destination pointers without the need for additional memory, the mempool allocating memory for rte_event_dma_adapter_ops can size the structure to accommodate all the needed source and destination pointers. Add

Re: [PATCH v3 1/2] eventdev/dma: reorganize event DMA ops

2024-05-30 Thread Jerin Jacob
On Thu, May 16, 2024 at 1:09 PM Amit Prakash Shukla wrote: > > > -Original Message- > > From: pbhagavat...@marvell.com > > Sent: Wednesday, April 17, 2024 1:57 PM > > To: Jerin Jacob ; Amit Prakash Shukla > > ; Vamsi Krishna Attunuru > > > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula

RE: [EXTERNAL] [PATCH v2 1/9] crypto/ionic: introduce AMD Pensando ionic crypto driver

2024-05-30 Thread Akhil Goyal
> Subject: [EXTERNAL] [PATCH v2 1/9] crypto/ionic: introduce AMD Pensando ionic > crypto driver > Title should be "crypto/ionic: introduce AMD Pensando driver" Do not repeat words in title. > + > +Device Support > +-- > + > +The ionic crypto PMD currently supports running directly on

RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro

2024-05-30 Thread Morten Brørup
> From: Akhil Goyal [mailto:gak...@marvell.com] > Sent: Thursday, 30 May 2024 13.47 > > > > > #if may not be needed in application. > > > > Test should be skipped if API is not available/supported. > > > > > > It's needed otherwise application developer has to check the implementation > for > > su

RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro

2024-05-30 Thread Akhil Goyal
> > > #if may not be needed in application. > > > Test should be skipped if API is not available/supported. > > > > It's needed otherwise application developer has to check the implementation > for > supported/not supported or else > run the application to get to know whether api is supported or n

RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro

2024-05-30 Thread Morten Brørup
> From: Kundapura, Ganapati [mailto:ganapati.kundap...@intel.com] > Sent: Thursday, 30 May 2024 13.42 > > Hi, > > > From: Morten Brørup > > Sent: Thursday, May 30, 2024 4:44 PM > > > > > From: Akhil Goyal [mailto:gak...@marvell.com] > > > Sent: Thursday, 30 May 2024 13.02 > > > > > > ++ Morten f

RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro

2024-05-30 Thread Kundapura, Ganapati
Hi, > -Original Message- > From: Morten Brørup > Sent: Thursday, May 30, 2024 4:44 PM > To: Akhil Goyal ; Kundapura, Ganapati > ; dev@dpdk.org; Gujjar, Abhinandan S > ; ferruh.yi...@amd.com; > tho...@monjalon.net; Richardson, Bruce ; > fanzhang@gmail.com; ciara.po...@intel.com > Subje

RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro

2024-05-30 Thread Kundapura, Ganapati
Hi > -Original Message- > From: Akhil Goyal > Sent: Thursday, May 30, 2024 4:32 PM > To: Kundapura, Ganapati ; dev@dpdk.org; > Gujjar, Abhinandan S ; ferruh.yi...@amd.com; > tho...@monjalon.net; Richardson, Bruce ; > fanzhang@gmail.com; ciara.po...@intel.com; Morten Brørup > > Subjec

[PATCH v3 30/30] net/ixgbe/base: add various miscellaneous features

2024-05-30 Thread Anatoly Burakov
Add various changes to the base driver that are not specifically about any features but are present in the shared code snapshot, to better align base code with DPDK. Also, update documentation to reflect new base code snapshot version, as well as document new hardware support. Signed-off-by: Anat

[PATCH v3 29/30] net/ixgbe/base: support more NVM-related operations

2024-05-30 Thread Anatoly Burakov
Add support for more NVM-related operations through Admin Command Interface, such as: - NVM read/write - Recalculating NVM checksum - Sanitize NVM - Clear user data from NVM - Validate an NVM read/write request - Read/program topology device - Read Option ROM and Minimum Security Revision Signed-

[PATCH v3 28/30] net/ixgbe/base: alternate structure operations support

2024-05-30 Thread Anatoly Burakov
Add support for read/write/clear operations on alternate structure. Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/base/ixgbe_e610.c | 132 drivers/net/ixgbe/base/ixgbe_e610.h | 9 ++ 2 files changed, 141 insertions(+) diff --git a/drivers/net/ixgbe/base/ixg

[PATCH v3 27/30] net/ixgbe/base: add NVM init and populate

2024-05-30 Thread Anatoly Burakov
The driver can store NVM settings in its internal structures. Add functions to initialize and populate these structures through the Admin Command Interface. Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/base/ixgbe_e610.c | 245 drivers/net/ixgbe/base/ixgbe_e61

[PATCH v3 26/30] net/ixgbe/base: add i2c and GPIO read/write API

2024-05-30 Thread Anatoly Burakov
The E610 hardware supports reading/writing values from/to GPIO and I2C registers through Admin Command Interface. Add API's to do so. Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/base/ixgbe_e610.c | 158 drivers/net/ixgbe/base/ixgbe_e610.h | 10 ++ 2 files c

[PATCH v3 25/30] net/ixgbe/base: enable E610 device support

2024-05-30 Thread Anatoly Burakov
From: Piotr Kwapulinski Add high level link management support for E610 device, as well as enable all code paths related to E610 initialization. This makes it so that E610 can be brought up using ixgbe driver. Signed-off-by: Carolyn Wyborny Signed-off-by: Jedrzej Jagielski Signed-off-by: Piotr

[PATCH v3 24/30] net/ixgbe/base: add support for NVM handling in E610 device

2024-05-30 Thread Anatoly Burakov
From: Piotr Kwapulinski Add low level support for accessing NVM in E610 device. NVM operations are handled via the Admin Command Interface. Signed-off-by: Stefan Wegrzyn Signed-off-by: Jedrzej Jagielski Signed-off-by: Piotr Kwapulinski Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/ba

[PATCH v3 23/30] net/ixgbe/base: add link management support for E610 device

2024-05-30 Thread Anatoly Burakov
From: Piotr Kwapulinski Add low level link management support for E610 device. Link management operations are handled via the Admin Command Interface. Signed-off-by: Stefan Wegrzyn Signed-off-by: Jedrzej Jagielski Signed-off-by: Piotr Kwapulinski Signed-off-by: Anatoly Burakov --- drivers/n

[PATCH v3 22/30] net/ixgbe/base: add support for E610 device capabilities detection

2024-05-30 Thread Anatoly Burakov
From: Piotr Kwapulinski Add low level support for E610 device capabilities detection. The capabilities are discovered via the Admin Command Interface. Signed-off-by: Stefan Wegrzyn Signed-off-by: Jedrzej Jagielski Signed-off-by: Piotr Kwapulinski Signed-off-by: Anatoly Burakov --- drivers/n

[PATCH v3 21/30] net/ixgbe/base: add support for E610 Admin Command Interface

2024-05-30 Thread Anatoly Burakov
Add low level support for Admin Command Interface (ACI). ACI is the Firmware interface used by a driver to communicate with E610 adapter. Add the following ACI features: - data structures, macros, register definitions - commands handling - events handling Signed-off-by: Stefan Wegrzyn Signed-off-

[PATCH v3 20/30] net/ixgbe/base: add definitions for E610

2024-05-30 Thread Anatoly Burakov
We're about to start adding code to support E610 device type, which relies on a lot of definitions. Add these definitions to base driver. Signed-off-by: Stefan Wegrzyn Signed-off-by: Jedrzej Jagielski Signed-off-by: Piotr Kwapulinski Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/base/i

[PATCH v3 19/30] net/ixgbe/base: remove prototypes of unimplemented functions

2024-05-30 Thread Anatoly Burakov
From: Chinh Cao There are some function prototypes that were introduced at some point but were never implemented, so remove them. Signed-off-by: Chinh Cao --- drivers/net/ixgbe/base/ixgbe_api.h | 1 - drivers/net/ixgbe/base/ixgbe_x550.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/dr

  1   2   >