[PATCH v3] common/qat: add virtual qat device (vQAT)

2024-02-20 Thread Arkadiusz Kusztal
This commit adds virtual QAT device to the Intel QuickAssist Technology PMD. There are three kinds of virtual QAT device defined which offer different QAT service to the customers: symmetric crypto, asymmetric crypto and compression. Signed-off-by: Arkadiusz Kusztal --- v2: - added symmetric cryp

[PATCH v1 2/2] net/mlx5: fix modify flex item error

2024-02-20 Thread Rongwei Liu
In the rte_flow_field_data structure, the flex item handle is part of union with other members like level/tag_index. If the user wants to modify the flex item as source or destination, there should not be any checking against zero. Signed-off-by: Rongwei Liu Fixes: 7ea38955b ("ethdev: update MPL

[PATCH v1 1/2] app/testpmd: fix modify tag typo

2024-02-20 Thread Rongwei Liu
Update the name to the right one: "src_tag_index" Signed-off-by: Rongwei Liu Fixes: 7ea38955b ("ethdev: update MPLS header modification API") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[PATCH v1 0/2] fix flex item modify error

2024-02-20 Thread Rongwei Liu
Fix flex item modification typo and wrong checking. Rongwei Liu (2): app/testpmd: fix modify tag typo net/mlx5: fix modify flex item error app/test-pmd/cmdline_flow.c | 2 +- drivers/net/mlx5/mlx5_flow.c| 2 +- drivers/net/mlx5/mlx5_flow_hw.c | 6 -- 3 files changed, 6 insertions

RE: [PATCH] examples/dma: fix max-frame-size cannot be zero

2024-02-20 Thread Jiang, YuX
> -Original Message- > From: Chengwen Feng > Sent: Tuesday, February 20, 2024 10:32 AM > To: tho...@monjalon.net; dev@dpdk.org; Jiang, YuX ; > Richardson, Bruce ; Laatz, Kevin > > Subject: [PATCH] examples/dma: fix max-frame-size cannot be zero > > In the original implementation, the max

[PATCH] net/mlx5: fix condition of LACP miss flow

2024-02-20 Thread Bing Zhao
The LACP traffic is only related to the bond interface. The default miss flow to redirect the LACP traffic with ethertype 0x8809 to the kernel driver should only be created on the bond device. This commit will: 1. remove the incorrect assertion of the port role. 2. skip the resource allocation

[PATCH] net/mlx5/hws: set the correct VLAN inner_type value

2024-02-20 Thread Bing Zhao
From: Hamdan Igbaria Set the correct VLAN inner_type value, till today the once the VLAN inner_type field was set, an incorrect value was taken instead of the inner_type field. Fixes: c55c2bf35333 ("net/mlx5/hws: add definer layer") Cc: sta...@dpdk.org Signed-off-by: Hamdan Igbaria Reviewed-by

Re: [PATCH] app/dma-perf: support bi-directional transfer

2024-02-20 Thread fengchengwen
Hi Amit, I didn't got the bit-directional meaning, does it mean: one core + one dmadev work for mem2dev while another core + another dmadev work for mem2dev? Thanks On 2024/1/8 16:27, Amit Prakash Shukla wrote: > Adds bi-directional DMA transfer support to test performance. > > Signed-off-by:

Re: [EXT] [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID

2024-02-20 Thread Patrick Robb
Okay. In terms of lab operations, I'll disable the ARM ZUC/Snow3G tests for main and next-*, but leave enabled for LTS. Once we can use v1.4 for ARM, will re-enable everything. Thanks. On Wed, Feb 21, 2024 at 12:10 AM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > > > > On Feb 20,

Re: [EXT] [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID

2024-02-20 Thread Honnappa Nagarahalli
> On Feb 20, 2024, at 11:01 PM, Patrick Robb wrote: > > > > On Tue, Jun 20, 2023 at 5:44 AM Fangming Fang wrote: > v1.4 release on the arm repo breaks DPDK > We have reverted the Arm library version to 1.3.0 to work around this issue > according to Pablo's suggestion. The library fixing this i

Re: [EXT] Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID

2024-02-20 Thread Patrick Robb
On Tue, Jun 20, 2023 at 5:44 AM Fangming Fang wrote: > v1.4 release on the arm repo breaks DPDK > We have reverted the Arm library version to 1.3.0 to work around this > issue according to Pablo's suggestion. The library fixing this issue is > tagged as SECLIB-IPSEC-2023.06.20. > > Thanks, > Fang

[PATCH v2] net/mlx5/hws: fix VLAN item handling on non relaxed mode

2024-02-20 Thread Bing Zhao
From: Hamdan Igbaria If a VLAN item was passed with null mask, the item handler would return immediately and thus won't set default values for non relax mode. Also change the non relax default set to single-tagged (CVLAN). Fixes: c55c2bf35333 ("net/mlx5/hws: add definer layer") Cc: sta...@dpdk.o

[PATCH] net/mlx5/hws: fix VLAN item handling on non relaxed mode

2024-02-20 Thread Bing Zhao
From: Hamdan Igbaria If a VLAN item was passed with null mask, the item handler would return immediately and thus won't set default values for non relax mode. Also change the non relax default set to single-tagged (CVLAN). Fixes: c55c2bf35333 ("net/mlx5/hws: add definer layer") Cc: sta...@dpdk.o

Re: [PATCH v8 4/4] app/dma-perf: add SG copy support

2024-02-20 Thread fengchengwen
Hi Gowrishankar, On 2023/11/22 19:06, Gowrishankar Muthukrishnan wrote: > Add SG copy support. > > Signed-off-by: Gowrishankar Muthukrishnan > Acked-by: Anoob Joseph > --- > app/test-dma-perf/benchmark.c | 274 +- > app/test-dma-perf/config.ini | 19 ++- > app

Re: [PATCH v4] dts: add Dockerfile

2024-02-20 Thread Patrick Robb
Tested-by: Patrick Robb The approach for mounting in ssh keys and managing the test engine environment has been agreed upon by the CI group, and this patch has been tested by a few people at the Community Lab. I believe it is ready to be merged. On Tue, Jan 16, 2024 at 2:18 PM wrote: > From: J

Re: [PATCH v8 0/7] dts: Port scatter suite over

2024-02-20 Thread Patrick Robb
Tested-by: Patrick Robb I ran this testsuite with a bnxt_en NIC at the Community Lab. I also spoke with Jeremy about the state of this patch today. He wants to add a second testcase to the suite for testing the scattered packets hardware offload (--enable-scatter flag in testpmd). But, he still

Re: [PATCH v8 2/4] app/dma-perf: add PCI device support

2024-02-20 Thread fengchengwen
Hi Amit, There are many commit for dma-perf, I've done a re-review and have a few comments, pls see below: On 2023/11/22 19:06, Gowrishankar Muthukrishnan wrote: > From: Amit Prakash Shukla > > Add support to test performance for "device to memory" and > "memory to device" data transfer. > >

[PATCH] net/mlx5: prevent querying aged flows on uninit port

2024-02-20 Thread Bing Zhao
In HWS template API, the aging mechanism doesn't support shared host mode now. When the guest's counter is set to 0, the aging won't be initialized. The current implementation didn't prevent the user from querying the aged flows on the uninitialized port. The access of invalid pointers would cause

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-20 Thread Honnappa Nagarahalli
> On Feb 20, 2024, at 12:58 PM, Abdullah Ömer Yamaç > wrote: > > I appreciate that you gave me suggestions and comments. I will make changes > according to all your recommendations, but before that, I want to make > everyone's minds clear. Then, I will apply modifications. > > On Tue, Feb

Re: [PATCH v2] raw/cnxk_bphy: switch to dynamic logging

2024-02-20 Thread Thomas Monjalon
06/12/2023 15:09, Jerin Jacob: > On Mon, Nov 27, 2023 at 11:42 PM Tomasz Duszynski > wrote: > > > > Dynamically allocated log type is a standard approach among all drivers. > > Switch to it. > > > > Signed-off-by: Tomasz Duszynski > > --- > > v2: > > - cleanup remaining plt_ log calls > > Applie

Re: [PATCH] raw/cnxk_gpio: switch to dynamic logging

2024-02-20 Thread Thomas Monjalon
05/12/2023 10:37, Jerin Jacob Kollanukkaran: > From: Tomasz Duszynski > > Dynamically allocated log type is a standard approach among all drivers. > > Switch to it. > > > > Signed-off-by: Tomasz Duszynski > > > Applied to dpdk-next-net-mrvl/for-main. Thanks Sorry, a patch from Stephen has bee

Re: [PATCH 3/3] net/ionic: add vdev support for embedded applications

2024-02-20 Thread Boyer, Andrew
On Feb 19, 2024, at 9:02 PM, Honnappa Nagarahalli wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Feb 16, 2024, at 11:07 AM, Andrew Boyer wrote: Add support for running DPDK applications direct

Reminder - DPDK Tech Board Call Tomorrow -7am Pacific/10am Eastern/1500h UTC

2024-02-20 Thread Nathan Southern
You have been invited to a recurring meeting for Data Plane Development Kit (DPDK) Agenda (read only): https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db

[DPDK/core Bug 1335] [dpdk-24.03-rc0] freebsd/nic_uio meson build error with clang16.0.6 and gcc12.2.0 on FreeBSD14

2024-02-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1335 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |FIXED Status|

[RFC] eal: increase maximum number of file descriptors in MP message

2024-02-20 Thread Stephen Hemminger
The TAP (and XDP) driver need to pass a file descriptor per queue to/from secondary process. The current limit is too low and ends up limiting these drivers to 7 queues. Increase the limit to what the unix domain socket allows. The Linux kernel allows up to SCM_MAX_FD (253). Signed-off-by: Stephe

[PATCH v2 3/3] net/ionic: add vdev support for embedded applications

2024-02-20 Thread Andrew Boyer
Add support for running DPDK applications directly on AMD Pensando embedded HW. The platform exposes the device BARs through UIO. The UIO code in the common/ionic library walks the sysfs filesystem to identify the relevant BARs and map them into process memory. The SoCs are named 'Capri' and 'Elba

[PATCH v2 2/3] net/ionic: remove duplicate barriers

2024-02-20 Thread Andrew Boyer
These barriers are duplicated by the barriers inside rte_write64(). Remove them to improve performance. Signed-off-by: Neel Patel Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_main.c| 1 - drivers/net/ionic/ionic_rxtx_sg.c | 1 - drivers/net/ionic/ionic_rxtx_simple.c | 1 -

[PATCH v2 1/3] common/ionic: create common code library for ionic

2024-02-20 Thread Andrew Boyer
Move definitions that will be shared by net/ionic and crypto/ionic. Add the code used for discovering UIO vdevs. Signed-off-by: Andrew Boyer --- MAINTAINERS | 1 + drivers/common/ionic/ionic_common.h | 41 +++ drivers/common/ionic/ionic_common_uio.c

[PATCH v2 0/3] net/ionic, common/ionic: add vdev support

2024-02-20 Thread Andrew Boyer
This patch series adds support to net/ionic for using UIO platform devices as DPDK vdevs. This is used by client applications which run directly on the AMD Pensando family of devices. The UIO code is implemented in a new common code library so that it can be shared with the upcoming crypto/ionic d

[DPDK/ethdev Bug 1382] tap device does not support multiple flow rules with same priority

2024-02-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1382 Bug ID: 1382 Summary: tap device does not support multiple flow rules with same priority Product: DPDK Version: 23.11 Hardware: All OS: All Status: UNCO

Re: [PATCH v4 01/18] mbuf: deprecate GCC marker in rte mbuf struct

2024-02-20 Thread Tyler Retzlaff
On Tue, Feb 20, 2024 at 08:16:23PM +0100, Thomas Monjalon wrote: > 20/02/2024 18:53, Thomas Monjalon: > > 20/02/2024 18:20, Tyler Retzlaff: > > > On Sun, Feb 18, 2024 at 01:39:52PM +0100, Thomas Monjalon wrote: > > > > 15/02/2024 07:21, Tyler Retzlaff: > > > > > Provide a macro that allows conditio

Re: [DPDK/ethdev Bug 1381] TAP device can not support 17 queues

2024-02-20 Thread Stephen Hemminger
On Tue, 20 Feb 2024 03:29:04 + bugzi...@dpdk.org wrote: > https://bugs.dpdk.org/show_bug.cgi?id=1381 > > Bug ID: 1381 >Summary: TAP device can not support 17 queues >Product: DPDK >Version: 23.11 > Hardware: All > OS: A

Re: [PATCH v4 01/18] mbuf: deprecate GCC marker in rte mbuf struct

2024-02-20 Thread Thomas Monjalon
20/02/2024 18:53, Thomas Monjalon: > 20/02/2024 18:20, Tyler Retzlaff: > > On Sun, Feb 18, 2024 at 01:39:52PM +0100, Thomas Monjalon wrote: > > > 15/02/2024 07:21, Tyler Retzlaff: > > > > Provide a macro that allows conditional expansion of RTE_MARKER fields > > > > to empty to allow rte_mbuf to be

RE: [PATCH 1/1] net/mana: add vlan tagging support

2024-02-20 Thread Long Li
> Not sure if we want to do the same. Two reasons. > > 1. Searching the netvsc source, I don't see a place that it set > hv->vlan_strip to > false. It means !hv->vlan_string is always false, and rte_vlan_insert(&m) > never > run. It's set here: drivers/net/netvsc/hn_ethdev.c: hv->vlan_strip = !

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-20 Thread Abdullah Ömer Yamaç
I appreciate that you gave me suggestions and comments. I will make changes according to all your recommendations, but before that, I want to make everyone's minds clear. Then, I will apply modifications. On Tue, Feb 20, 2024 at 2:35 AM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote:

Re: [PATCH 2/3] net/ionic: remove duplicate barriers

2024-02-20 Thread Boyer, Andrew
On Feb 19, 2024, at 9:02 PM, Wathsala Wathawana Vithanage wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. -Original Message- From: Wathsala Wathawana Vithanage mailto:wathsala.vithan...@arm

Re: [PATCH] eal: provide rte attribute macro for GCC attribute

2024-02-20 Thread Thomas Monjalon
20/02/2024 19:06, Tyler Retzlaff: > On Sun, Feb 18, 2024 at 04:31:50PM +0100, Thomas Monjalon wrote: > > 18/02/2024 15:51, Mattias Rönnblom: > > > On 2024-02-18 13:24, Thomas Monjalon wrote: > > > > 15/02/2024 23:20, Tyler Retzlaff: > > > >> Provide a new macro __rte_attribute(a) that when directly

Re: Email based retest request process: proposal for new pull/re-apply feature

2024-02-20 Thread Patrick Robb
On Tue, Feb 20, 2024 at 1:12 PM Aaron Conole wrote: > > Why not something like: > > Recheck-request: [attribute-list],[test-list]... > > For example, then we can do: > > Recheck-request: rebase=[identifier], > > where identifier is a branch specifier (or the word 'latest')? > I hadn't thought

Re: Email based retest request process: proposal for new pull/re-apply feature

2024-02-20 Thread Aaron Conole
Patrick Robb writes: > Hi all, > > I want to poll the CI group and dev community about a proposed feature > addition to the CI retest request framework. > Currently, you can respond to a patchseries or patch email, requesting a > retest like so: > > Recheck-request: iol-compile-amd64-testing, i

Re: [PATCH] eal: provide rte attribute macro for GCC attribute

2024-02-20 Thread Tyler Retzlaff
On Sun, Feb 18, 2024 at 04:31:50PM +0100, Thomas Monjalon wrote: > 18/02/2024 15:51, Mattias Rönnblom: > > On 2024-02-18 13:24, Thomas Monjalon wrote: > > > 15/02/2024 23:20, Tyler Retzlaff: > > >> Provide a new macro __rte_attribute(a) that when directly used > > >> compiles to empty for MSVC and

Re: [PATCH v3 10/11] eventdev: clarify docs on event object fields and op types

2024-02-20 Thread Bruce Richardson
On Fri, Feb 09, 2024 at 02:44:04PM +0530, Jerin Jacob wrote: > On Fri, Feb 2, 2024 at 6:11 PM Bruce Richardson > wrote: > > > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > For the fields in "rte_event" struct, enhance the comments on each to > > clarify the field's use, an

Re: [PATCH v4 01/18] mbuf: deprecate GCC marker in rte mbuf struct

2024-02-20 Thread Thomas Monjalon
20/02/2024 18:20, Tyler Retzlaff: > On Sun, Feb 18, 2024 at 01:39:52PM +0100, Thomas Monjalon wrote: > > 15/02/2024 07:21, Tyler Retzlaff: > > > Provide a macro that allows conditional expansion of RTE_MARKER fields > > > to empty to allow rte_mbuf to be used with MSVC. It is proposed that > > > we

Re: [PATCH] eal: provide rte attribute macro for GCC attribute

2024-02-20 Thread Tyler Retzlaff
On Sun, Feb 18, 2024 at 05:44:48PM +0100, Thomas Monjalon wrote: > 18/02/2024 17:38, Morten Brørup: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Sunday, 18 February 2024 16.35 > > > > > > 18/02/2024 13:53, Morten Brørup: > > > > > From: Thomas Monjalon [mailto:tho...@monjal

Re: [PATCH v3 10/11] eventdev: clarify docs on event object fields and op types

2024-02-20 Thread Bruce Richardson
On Fri, Feb 09, 2024 at 02:44:04PM +0530, Jerin Jacob wrote: > On Fri, Feb 2, 2024 at 6:11 PM Bruce Richardson > wrote: > > > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > For the fields in "rte_event" struct, enhance the comments on each to > > clarify the field's use, an

Re: [PATCH v3 10/11] eventdev: clarify docs on event object fields and op types

2024-02-20 Thread Bruce Richardson
On Fri, Feb 09, 2024 at 02:44:04PM +0530, Jerin Jacob wrote: > On Fri, Feb 2, 2024 at 6:11 PM Bruce Richardson > wrote: > > > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > For the fields in "rte_event" struct, enhance the comments on each to > > clarify the field's use, an

Re: [PATCH v4 01/18] mbuf: deprecate GCC marker in rte mbuf struct

2024-02-20 Thread Tyler Retzlaff
On Sun, Feb 18, 2024 at 04:22:15PM +0100, Thomas Monjalon wrote: > 18/02/2024 14:07, Morten Brørup: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 15/02/2024 07:21, Tyler Retzlaff: > > > > --- a/lib/eal/include/rte_common.h > > > > +++ b/lib/eal/include/rte_common.h > > > > @@ -582,6

Re: [PATCH v3 09/11] eventdev: improve comments on scheduling types

2024-02-20 Thread Bruce Richardson
On Thu, Feb 08, 2024 at 11:04:03AM +0100, Mattias Rönnblom wrote: > On 2024-02-08 10:18, Jerin Jacob wrote: > > On Fri, Feb 2, 2024 at 6:11 PM Bruce Richardson > > wrote: > > > > > > The description of ordered and atomic scheduling given in the eventdev > > > doxygen documentation was not always

Re: [PATCH v4 01/18] mbuf: deprecate GCC marker in rte mbuf struct

2024-02-20 Thread Tyler Retzlaff
On Sun, Feb 18, 2024 at 01:39:52PM +0100, Thomas Monjalon wrote: > 15/02/2024 07:21, Tyler Retzlaff: > > Provide a macro that allows conditional expansion of RTE_MARKER fields > > to empty to allow rte_mbuf to be used with MSVC. It is proposed that > > we announce the fields to be __rte_deprecated

Re: [PATCH] build: fix linker warnings about undefined symbols

2024-02-20 Thread Tyler Retzlaff
On Sun, Feb 18, 2024 at 06:38:22PM +0100, Thomas Monjalon wrote: > 10/01/2024 17:58, Tyler Retzlaff: > > On Wed, Jan 10, 2024 at 03:01:03PM +, Bruce Richardson wrote: > > > The default behaviour of "ld.lld" has changed, so it now prints out > > > warnings about entries in the version.map file w

Re: [PATCH v3 03/11] eventdev: update documentation on device capability flags

2024-02-20 Thread Bruce Richardson
On Wed, Feb 07, 2024 at 04:00:04PM +0530, Jerin Jacob wrote: > On Sat, Feb 3, 2024 at 12:59 PM Bruce Richardson > wrote: > > > > Update the device capability docs, to: > > > > * include more cross-references > > * split longer text into paragraphs, in most cases with each flag having > > a singl

Re: [PATCH v3 01/11] eventdev: improve doxygen introduction text

2024-02-20 Thread Bruce Richardson
On Wed, Feb 07, 2024 at 03:44:37PM +0530, Jerin Jacob wrote: > On Fri, Feb 2, 2024 at 7:29 PM Bruce Richardson > wrote: > > > > Make some textual improvements to the introduction to eventdev and event > > devices in the eventdev header file. This text appears in the doxygen > > output for the head

Re: [PATCH v3 01/11] eventdev: improve doxygen introduction text

2024-02-20 Thread Bruce Richardson
On Sat, Feb 10, 2024 at 08:24:29AM +0100, Mattias Rönnblom wrote: > On 2024-02-09 09:43, Jerin Jacob wrote: > > On Thu, Feb 8, 2024 at 3:20 PM Mattias Rönnblom > > wrote: > > > > > > On 2024-02-07 11:14, Jerin Jacob wrote: > > > > On Fri, Feb 2, 2024 at 7:29 PM Bruce Richardson > > > > wrote: >

Re: [RFC v3 1/6] eal: add static per-lcore memory allocation facility

2024-02-20 Thread Mattias Rönnblom
On 2024-02-20 12:39, Bruce Richardson wrote: On Tue, Feb 20, 2024 at 11:47:14AM +0100, Mattias Rönnblom wrote: On 2024-02-20 10:11, Bruce Richardson wrote: On Tue, Feb 20, 2024 at 09:49:03AM +0100, Mattias Rönnblom wrote: Introduce DPDK per-lcore id variables, or lcore variables for short. An

[RFC PATCH 2/2] power: refactor uncore power management library

2024-02-20 Thread Sivaprasad Tummala
This patch refactors the power management library, addressing uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/uncore/*'. The adjustment of meson.build files enables the selective activation of individual drivers. This

[RFC PATCH 0/2] power: refactor power management library

2024-02-20 Thread Sivaprasad Tummala
This patchset refactors the power management library, addressing both core and uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/core/*' and 'drivers/power/uncore/*'. This refactor significantly improves code organiza

[RFC PATCH 1/2] power: refactor core power management library

2024-02-20 Thread Sivaprasad Tummala
This patch introduces a comprehensive refactor to the core power management library. The primary focus is on improving modularity and organization by relocating specific driver implementations from the 'lib/power' directory to dedicated directories within 'drivers/power/core/*'. The adjustment of m

[RFC PATCH 0/2] power: refactor power management library

2024-02-20 Thread Sivaprasad Tummala
This patchset refactors the power management library, addressing both core and uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/core/*' and 'drivers/power/uncore/*'. This refactor significantly improves code organiza

RE: [RFC v3 3/6] random: keep PRNG state in lcore variable

2024-02-20 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Tuesday, 20 February 2024 09.49 > [...] > @@ -124,11 +129,10 @@ struct rte_rand_state *__rte_rand_get_state(void) > > idx = rte_lcore_id(); > > - /* last instance reserved for unregistered non-EAL threads */ >

Email based retest request process: proposal for new pull/re-apply feature

2024-02-20 Thread Patrick Robb
Hi all, I want to poll the CI group and dev community about a proposed feature addition to the CI retest request framework. Currently, you can respond to a patchseries or patch email, requesting a retest like so: Recheck-request: iol-compile-amd64-testing, iol-unit-amd64-testing Labs who have ad

Re: [PATCH v3 1/7] ethdev: support report register names and filter

2024-02-20 Thread Stephen Hemminger
On Tue, 20 Feb 2024 18:58:17 +0800 Jie Hai wrote: > int > rte_eth_dev_get_reg_info(uint16_t port_id, struct rte_dev_reg_info *info) > +{ > + struct rte_dev_reg_info reg_info = { 0 }; > + int ret; > + > + if (info == NULL) { > + RTE_ETHDEV_LOG_LINE(ERR, > +

Re: [PATCH v3 1/7] ethdev: support report register names and filter

2024-02-20 Thread Stephen Hemminger
On Tue, 20 Feb 2024 18:58:17 +0800 Jie Hai wrote: > @@ -20,6 +25,12 @@ struct rte_dev_reg_info { > uint32_t length; /**< Number of registers to fetch */ > uint32_t width; /**< Size of device register */ > uint32_t version; /**< Device version */ > + /** > + * Filter for

Re: [PATCH v3 1/7] ethdev: support report register names and filter

2024-02-20 Thread Stephen Hemminger
On Tue, 20 Feb 2024 18:58:17 +0800 Jie Hai wrote: > This patch adds "filter" and "names" fields to "rte_dev_reg_info" > structure. Names of registers in data fields can be reported and > the registers can be filtered by their names. > > The new API rte_eth_dev_get_reg_info_ext() is added to supp

Re: [PATCH v3 1/7] ethdev: support report register names and filter

2024-02-20 Thread Stephen Hemminger
On Tue, 20 Feb 2024 18:58:17 +0800 Jie Hai wrote: > +* **Added support for dumping regiters with names and filter.** Spelling

Re: [PATCH 3/3] net/ionic: add vdev support for embedded applications

2024-02-20 Thread Honnappa Nagarahalli
> On Feb 20, 2024, at 2:28 AM, Ferruh Yigit wrote: > > On 2/16/2024 5:07 PM, Andrew Boyer wrote: >> +#if defined(RTE_LIBRTE_IONIC_PMD_BARRIER_ERRATA) >> + /* On some devices the standard 'dmb' barrier is insufficient */ >> + asm volatile("dsb st" : : : "memory"); >> + rte_write64_relaxed(rte_cp

[PATCH v3 4/5] net/mlx5: add NAT64 action support in rule creation

2024-02-20 Thread Bing Zhao
The action will handle the IPv4 and IPv6 headers translation. It will add / remove IPv6 address prefix by default. To use the user specific address, another rule to modify the addresses of the IP header is needed. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow_hw.c | 20 +++

[PATCH v3 5/5] net/mlx5: validate the actions combination with NAT64

2024-02-20 Thread Bing Zhao
NAT64 is treated as a modify header action. The action order and limitation should be the same as that of modify header in each domain. Since the last 2 TAG registers will be used implicitly in the address backup mode, the values in these registers are no longer valid after the NAT64 action. The a

[PATCH v3 3/5] net/mlx5: create NAT64 actions during configuration

2024-02-20 Thread Bing Zhao
The NAT64 DR actions can be shared among the tables. All these actions can be created during configuring the flow queues and saved for the future usage. Even the actions can be shared now, inside per each flow rule, the actual hardware resources are unique. Signed-off-by: Bing Zhao --- doc/guid

[PATCH v3 2/5] net/mlx5: fetch the available registers for NAT64

2024-02-20 Thread Bing Zhao
REG_C_6 is used as the 1st one and since it is reserved internally by default, there is no impact. The remaining 2 registers will be fetched from the available TAGs array from right to left. They will not be masked in the array due to the fact that not all the rules will use NAT64 action. Signed-

[PATCH v3 1/5] net/mlx5/hws: support NAT64 action

2024-02-20 Thread Bing Zhao
From: Erez Shitrit Add support of new action mlx5dr_action_create_nat64. The new action allows to modify IP packets from version to version, IPV6 to IPV4 and vice versa. Signed-off-by: Erez Shitrit Signed-off-by: Bing Zhao --- drivers/net/mlx5/hws/mlx5dr.h| 29 ++ drivers/net/mlx5/hw

[PATCH v3 0/5] NAT64 support in mlx5 PMD

2024-02-20 Thread Bing Zhao
This patch set contains the mlx5 PMD implementation for NAT64. Update in v3: 1. code style and typo. Update in v2: 1. separate from the RTE and testpmd common part. 2. reorder the commits. 3. bug fix, code polishing and document update. Bing Zhao (4): net/mlx5: fetch the available regi

[PATCH v2 5/5] net/mlx5: validate the actions combination with NAT64

2024-02-20 Thread Bing Zhao
NAT64 is treated as a modify header action. The action order and limitation should be the same as that of modify header in each domain. Since the last 2 TAG registers will be used implicitly in the address backup mode, the values in these registers are no longer valid after the NAT64 action. The a

[PATCH v2 4/5] net/mlx5: add NAT64 action support in rule creation

2024-02-20 Thread Bing Zhao
The action will handle the IPv4 and IPv6 headers translation. It will add / remove IPv6 address prefix by default. To use the user specific address, another rule to modify the addresses of the IP header is needed. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow_hw.c | 20 +++

[PATCH v2 3/5] net/mlx5: create NAT64 actions during configuration

2024-02-20 Thread Bing Zhao
The NAT64 DR actions can be shared among the tables. All these actions can be created during configuring the flow queues and saved for the future usage. Even the actions can be shared now, inside per each flow rule, the actual hardware resources are unique. Signed-off-by: Bing Zhao --- doc/guid

[PATCH v2 2/5] net/mlx5: fetch the available registers for NAT64

2024-02-20 Thread Bing Zhao
REG_C_6 is used as the 1st one and since it is reserved internally by default, there is no impact. The remaining 2 registers will be fetched from the available TAGs array from right to left. They will not be masked in the array due to the fact that not all the rules will use NAT64 action. Signed-

[PATCH v2 1/5] net/mlx5/hws: support NAT64 action

2024-02-20 Thread Bing Zhao
From: Erez Shitrit Add support of new action mlx5dr_action_create_nat64. The new action allows to modify IP packets from version to version, IPV6 to IPV4 and vice versa. Signed-off-by: Erez Shitrit Signed-off-by: Bing Zhao --- drivers/net/mlx5/hws/mlx5dr.h| 29 ++ drivers/net/mlx5/hw

[PATCH v2 0/5] NAT64 support in mlx5 PMD

2024-02-20 Thread Bing Zhao
This patch set contains the mlx5 PMD implementation for NAT64. Update in v2: 1. separate from the RTE and testpmd common part. 2. reorder the commits. 3. bug fix, code polishing and document update. Bing Zhao (4): net/mlx5: fetch the available registers for NAT64 net/mlx5: create NAT64

RE: [PATCH] net/mlx5: fix error packets drop in the regular Rx

2024-02-20 Thread Dariusz Sosnowski
> -Original Message- > From: Slava Ovsiienko > Sent: Tuesday, February 20, 2024 12:45 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Dariusz Sosnowski > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix error packets drop in the regular Rx > > When packet gets rece

[PATCH v6] mempool: test performance with larger bursts

2024-02-20 Thread Morten Brørup
Bursts of up to 64 or 128 packets are not uncommon, so increase the maximum tested get and put burst sizes from 32 to 128. For convenience, also test get and put burst sizes of RTE_MEMPOOL_CACHE_MAX_SIZE. Some applications keep more than 512 objects, so increase the maximum number of kept objects

RE: [PATCH] net/mlx5: fix use after free when releasing tx queues

2024-02-20 Thread Dariusz Sosnowski
Hi, > -Original Message- > From: Yunjian Wang > Sent: Tuesday, February 20, 2024 10:32 > To: dev@dpdk.org > Cc: Dariusz Sosnowski ; Ori Kam > ; Matan Azrad ; Slava Ovsiienko > ; Suanming Mou ; > luyi...@huawei.com; Pengfei Sun ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix use after

RE: [PATCH v5] mempool: test performance with larger bursts

2024-02-20 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, 18 February 2024 19.04 > > 24/01/2024 12:21, Morten Brørup: > > --- a/app/test/test_mempool_perf.c > > +++ b/app/test/test_mempool_perf.c > > @@ -1,6 +1,6 @@ > > /* SPDX-License-Identifier: BSD-3-Clause > > * Copyright(c) 2010

RE: [RFC v3 1/6] eal: add static per-lcore memory allocation facility

2024-02-20 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Tuesday, 20 February 2024 12.39 > > On Tue, Feb 20, 2024 at 11:47:14AM +0100, Mattias Rönnblom wrote: > > On 2024-02-20 10:11, Bruce Richardson wrote: > > > On Tue, Feb 20, 2024 at 09:49:03AM +0100, Mattias Rönnblom wrote: > > >

Re: DTS testpmd and SCAPY integration

2024-02-20 Thread Gregory Etelson
Hello Patrick, Note: incorporating a function(s) to load different mlnx device firmware as a part of the testsuite is an interesting touch. Do you mind explaining why it is made a part of the testing framework, as opposed to a pre-step for the user to complete ahead of running the framework? Do

[PATCH 4/4] test/argparse: refine testcases

2024-02-20 Thread Chengwen Feng
Refine testcases, including: 1. add testcase comment. 2. argv[0] should set obj->prog_name. 3. set val_set as NULL in test_argparse_invalid_arg_flags, let it test to the specified code logic. 4. enable index verification in opt_callback_parse_int_of_no_val. Fixes: 6c5c6571601c ("argparse: verify a

[PATCH 1/4] argparse: refine error message

2024-02-20 Thread Chengwen Feng
This patch refines the error message. Signed-off-by: Chengwen Feng --- lib/argparse/rte_argparse.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/lib/argparse/rte_argparse.c b/lib/argparse/rte_argparse.c index 2d953f1694..48738cd07b 100644 -

[PATCH 3/4] argparse: fix argument flags operate as uint32 type

2024-02-20 Thread Chengwen Feng
The struct rte_argparse_arg's flags was 64bit type, uint64_t should be used instead of uint32_t where the operation happened. Also, the flags' bit16 was also unused, so don't test bit16 in testcase test_argparse_invalid_arg_flags. Fixes: 6c5c6571601c ("argparse: verify argument config") Fixes: 31

[PATCH 0/4] refine argparse library

2024-02-20 Thread Chengwen Feng
I found a couple of issues when I revisited the argparse_autotest output, so got this patchset. Chengwen Feng (4): argparse: refine error message argparse: remove dead code argparse: fix argument flags operate as uint32 type test/argparse: refine testcases app/test/test_argparse.c| 6

[PATCH 2/4] argparse: remove dead code

2024-02-20 Thread Chengwen Feng
The judgement "obj->callback == NULL" is dead code which can't be reached, because verify_arg_saver() already make sure obj->callback must not be NULL when arg->val_saver is NULL. Signed-off-by: Chengwen Feng --- app/test/test_argparse.c| 7 --- lib/argparse/rte_argparse.c | 6 -- 2

[PATCH] net/mlx5: fix error packets drop in the regular Rx

2024-02-20 Thread Viacheslav Ovsiienko
When packet gets received with error it is reported in CQE structure and PMD analyzes the error syndrome and provides two options - either reset the entire queue for the critical errors, or just ignore the packet. The non-vectorized rx_burst did not ignore the non-critical error packets, and in ca

[PATCH] net/virtio-user: add VIRTIO_F_ORDER_PLATFORM to feature list

2024-02-20 Thread Nithin Dabilpuram
VIRTIO_F_ORDER_PLATFORM is needed feature when working with real HW platforms that are exposing virtio-net devices via VDPA framework. This feature helps in having more real ordering requirements between descriptor updates and notification data updates. Hence enable it if the device supports the fe

Re: [RFC v3 1/6] eal: add static per-lcore memory allocation facility

2024-02-20 Thread Bruce Richardson
On Tue, Feb 20, 2024 at 11:47:14AM +0100, Mattias Rönnblom wrote: > On 2024-02-20 10:11, Bruce Richardson wrote: > > On Tue, Feb 20, 2024 at 09:49:03AM +0100, Mattias Rönnblom wrote: > > > Introduce DPDK per-lcore id variables, or lcore variables for short. > > > > > > An lcore variable has one va

[PATCH v2 13/13] common/cnxk: use SQ enable and disable API

2024-02-20 Thread Nithin Dabilpuram
Use SQ enable and disable API in TM setup to affect the state change. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix_tm_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_tm_ops.c b/drivers/common/cnxk/roc_nix_tm_ops.c ind

[PATCH v2 12/13] common/cnxk: add IO attribute to mbox structs

2024-02-20 Thread Nithin Dabilpuram
IO attribute is needed to mbox structs to avoid unaligned or pair access causing by compiler optimization. Add them to structs where it is missing. Fixes: 503b82de2cbf ("common/cnxk: add mbox request and response definitions") Fixes: ddf955d3917e ("common/cnxk: support CPT second pass") Cc: sta...

[PATCH v2 11/13] net/cnxk: fix check cookies for multi-seg offload

2024-02-20 Thread Nithin Dabilpuram
From: Rahul Bhansali Fix missing check cookies with multi-seg offload case Fixes: 3626d5195d49 ("net/cnxk: add multi-segment Tx for CN10K") Cc: sta...@dpdk.org Signed-off-by: Rahul Bhansali --- drivers/net/cnxk/cn10k_tx.h | 21 - 1 file changed, 20 insertions(+), 1 deletio

[PATCH v2 10/13] net/cnxk: fix indirect mbuf handling in Tx path

2024-02-20 Thread Nithin Dabilpuram
Indirect mbuf can be pointing to data from different pool. Use the right aura in NIX send header in SG2 and SG case. Fixes: 862e28128707 ("net/cnxk: add vector Tx for CN9K") Fixes: f71b7dbbf04b ("net/cnxk: add vector Tx for CN10K") Fixes: 7e95c11df4f1 ("net/cnxk: add multi-segment Tx for CN9K") Fi

[PATCH v2 09/13] common/cnxk: update queue entries copy in RETA table

2024-02-20 Thread Nithin Dabilpuram
From: Kommula Shiva Shankar This patch updates queue entries copy in reta table based on data type Signed-off-by: Kommula Shiva Shankar --- drivers/common/cnxk/roc_nix_rss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_rss.c b/drivers/com

[PATCH v2 08/13] net/cnxk: fix max MTU limit

2024-02-20 Thread Nithin Dabilpuram
From: Sunil Kumar Kori Device can support maximum frame size up to 9212 bytes. While configuring mtu, overhead is considered as ethernet header size, crc and 2 * (vlan tags) which translates to 26 bytes. Exposed overhead to the user via rte_eth_dev_info() is 18 bytes which were leading to set wr

[PATCH v2 07/13] common/cnxk: skip setting Tx MTU separately

2024-02-20 Thread Nithin Dabilpuram
Skip setting Tx MTU separately as now the Tx credit configuration is based on max MTU possible for that link. Also init MTU with max value for that port. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.c | 2 +- drivers/common/cnxk/roc_nix.h | 2 -- drivers/net/cnxk/

[PATCH v2 06/13] net/cnxk: fix issue with buff size compute

2024-02-20 Thread Nithin Dabilpuram
In case where cnxk_nix_mtu_set() is called before data->min_rx_buf_size is set, use buf size from first RQ's mempool. Fixes: 34b46320f446 ("net/cnxk: perform early MTU setup for event mode") Cc: sta...@dpdk.org Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cnxk_ethdev_ops.c | 25 +++

[PATCH v2 05/13] net/cnxk: added Tx descriptor dump API

2024-02-20 Thread Nithin Dabilpuram
From: Satha Rao New API to dump selected descriptor entries from SQE list. Signed-off-by: Satha Rao --- drivers/net/cnxk/cnxk_ethdev.c | 1 + drivers/net/cnxk/cnxk_ethdev.h | 2 ++ drivers/net/cnxk/cnxk_ethdev_ops.c | 10 ++ 3 files changed, 13 insertions(+) diff --git a/dri

[PATCH v2 04/13] common/cnxk: dump selected SQ entries

2024-02-20 Thread Nithin Dabilpuram
From: Satha Rao New API to dump detailed SQ entries. Signed-off-by: Satha Rao --- drivers/common/cnxk/roc_nix.h | 2 + drivers/common/cnxk/roc_nix_debug.c | 172 drivers/common/cnxk/version.map | 1 + 3 files changed, 175 insertions(+) diff --git a/d

  1   2   >