> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, 18 February 2024 19.04 > > 24/01/2024 12:21, Morten Brørup: > > --- a/app/test/test_mempool_perf.c > > +++ b/app/test/test_mempool_perf.c > > @@ -1,6 +1,6 @@ > > /* SPDX-License-Identifier: BSD-3-Clause > > * Copyright(c) 2010-2014 Intel Corporation > > - * Copyright(c) 2022 SmartShare Systems > > + * Copyright(c) 2022-2024 SmartShare Systems > > You don't need to update copyright year. > The first year is the only important one. > > reading: https://matija.suklje.name/how-and-why-to-properly-write- > copyright-statements-in-your-code#why-not-bump-the-year-on-change
Thank you, Thomas. Very informative. Will fix in next version. > > [...] > > REGISTER_PERF_TEST(mempool_perf_autotest, test_mempool_perf); > > +REGISTER_PERF_TEST(mempool_perf_autotest_1core, > test_mempool_perf_1core); > > +REGISTER_PERF_TEST(mempool_perf_autotest_2cores, > test_mempool_perf_2cores); > > How do we make sure the test is skipped if we have only 1 core? Good point. Will fix in next version. > > > +REGISTER_PERF_TEST(mempool_perf_autotest_allcores, > test_mempool_perf_allcores); > > How the test duration is changed after this patch? > On my test machine, the expanded test parameter set increased the duration of one test run from 20 minutes to 100 minutes. Before the patch, all three test runs were always executed, i.e. a total duration of 60 minutes. In other words: The expanded test parameter set increased the test run duration by factor five. Introducing the ability to optionally only test with a specific number of lcores reduced the total test duration to a third.
