RE: [PATCH v2] common/sfc: replace out of bounds condition with static_assert

> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, 19 January 2024 23.14 > > The sfc base code had its own definition of static assertions > using the out of bound array access hack. Replace it with a > static_assert like rte_common.h. > > Fixes: f67e4719147d ("net/sfc/

RE: [EXT] Re: [PATCH 2/2] config/arm: add armv9-a march

> On 2024/1/4 5:18 PM, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Now that major versions of GCC recognize armv9-a march option, > > add it to the list of supported march. > > Update neoverse-n2 part number to include march as armv9-a. > > > > Signed-off-by: Pavan Nikhilesh

Re: gve: mixes DPDK and Linux versions in compatibility check

Hi Stephen We wish to capture both rte version and linux kernel version. The current implementation is needed to answer questions like how many customers are on Dpdk 23.11 for Ubuntu 22 vs Debian 11. Therefore, we need the uts library and the adminq is working as intended. On Fri, Jan 12, 2024, 1

?????? [PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail

I have modified my  commitlog and resubmitted the patch, but I seem to have forgotten to add a [v2] flag to the patch. Do I need to resubmit the patch again? --  -- ??: "David Marchand"https://doc.dpdk.org/guides/contributing/patches.html#patch-fix-

[PATCH] net/mana: rename mana_find_pmd_mr() to mana_alloc_pmd_mr()

From: Long Li The function name mana_find_pmd_mr() is misleading as there might be allocations to get a MR. Change function name to mana_alloc_pmd_mr(). Signed-off-by: Long Li --- drivers/net/mana/mana.h | 6 +++--- drivers/net/mana/mr.c | 7 --- drivers/net/mana/rx.c | 2 +- drivers/n

Re: [PATCH v4 1/6] eal: introduce RTE_MIN_T() and RTE_MAX_T() macros

On Fri, 19 Jan 2024 12:58:47 -0800 Tyler Retzlaff wrote: > On Wed, Jan 17, 2024 at 10:19:55AM -0800, Stephen Hemminger wrote: > > These macros work like RTE_MIN and RTE_MAX but take an explicit > > type. Necessary when being used in static assertions since > > RTE_MIN and RTE_MAX use temporary va

Re: [RFC PATCH] eventdev: ensure 16-byte alignment for events

On Fri, 6 Oct 2023 14:15:00 +0200 Mattias Rönnblom wrote: > On 2023-10-05 13:51, Bruce Richardson wrote: > > The event structure in DPDK is 16-bytes in size, and events are > > regularly passed as parameters directly rather than being passed as > > pointers. > > When are events passed by-value

Re: [dpdk-dev] [PATCH v3] eal: refactor rte_eal_init into sub-functions

On Fri, 19 Jan 2024 08:58:17 -0800 Rahul Gupta wrote: > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 9e4e99e53b..345f3c1c04 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -4531,6 +4531,8 @@ main(int argc, char** argv) > portid_t port_id; >

[PATCH v2] common/sfc: replace out of bounds condition with static_assert

The sfc base code had its own definition of static assertions using the out of bound array access hack. Replace it with a static_assert like rte_common.h. Fixes: f67e4719147d ("net/sfc/base: fix coding style") Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- v2 - add assert.h to make

Re: [PATCH v4] eventdev: ensure 16-byte alignment for events

On Mon, Nov 13, 2023 at 08:58:19AM +0100, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, 13 November 2023 00.32 > > > > On Sun, 12 Nov 2023 09:30:24 +0100 > > Morten Brørup wrote: > > > > > > > +static_assert(sizeof(struct rte_event) == 16,

Re: [PATCH v4 1/6] eal: introduce RTE_MIN_T() and RTE_MAX_T() macros

On Wed, Jan 17, 2024 at 10:19:55AM -0800, Stephen Hemminger wrote: > These macros work like RTE_MIN and RTE_MAX but take an explicit > type. Necessary when being used in static assertions since > RTE_MIN and RTE_MAX use temporary variables which confuses > compilers constant expression checks. Thes

Re: DTS testpmd and SCAPY integration

Thanks for summarizing Juraj. As we discussed at the CI meeting yesterday, we should get together next week to workshop some rough testsuites based on the ideas which have been proposed above, and discussed in the DTS meeting and CI testing meeting. Just to get something on the calendar I schedul

RE: [EXT] Re: [PATCH 1/2] config/arm: fix CN10K minimum march requirement

> -Original Message- > From: Ruifeng Wang > Sent: Thursday, January 18, 2024 7:32 AM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > ; Bruce Richardson > Cc: dev@dpdk.org; sta...@dpdk.org; n...@arm.com > Subject: [EXT] Re: [PATCH 1/2] config/arm: fix CN10K minimum march > requirement

RE: [EXT] Re: [PATCH v4 2/2] config/arm: use common cpu arch for cross files

> -Original Message- > From: Stephen Hemminger > Sent: Friday, December 8, 2023 4:12 AM > To: Joyce Kong > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; > bruce.richard...@intel.com; dev@dpdk.org; n...@arm.com; Honnappa > Nagarahalli > Subject: [EXT] Re: [PATCH v4 2/2] config/arm: us

RE: [PATCH v4 1/2] config: correct cpu instruction set for cross build

> -Original Message- > From: Joyce Kong > Sent: Friday, December 8, 2023 8:21 AM > To: Stephen Hemminger > Cc: tho...@monjalon.net; Ruifeng Wang ; > bruce.richard...@intel.com; dev@dpdk.org; nd ; > sta...@dpdk.org > Subject: [EXT] RE: [PATCH v4 1/2] config: correct cpu instruction set

[PATCH v2 11/11] eventdev: RFC clarify docs on event object fields

Clarify the meaning of the NEW, FORWARD and RELEASE event types. For the fields in "rte_event" struct, enhance the comments on each to clarify the field's use, and whether it is preserved between enqueue and dequeue, and it's role, if any, in scheduling. Signed-off-by: Bruce Richardson --- As wi

[PATCH v2 10/11] eventdev: RFC clarify comments on scheduling types

The description of ordered and atomic scheduling given in the eventdev doxygen documentation was not always clear. Try and simplify this so that it is clearer for the end-user of the application Signed-off-by: Bruce Richardson --- NOTE TO REVIEWERS: I've updated this based on my understanding of

[PATCH v2 09/11] eventdev: improve doxygen comments for control APIs

The doxygen comments for the port attributes, start and stop (and related functions) are improved. Signed-off-by: Bruce Richardson --- lib/eventdev/rte_eventdev.h | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/lib/eventdev/rte_eventdev.h

[PATCH v2 08/11] eventdev: improve doxygen comments on config fns

Improve the documentation text for the configuration functions and structures for configuring an eventdev, as well as ports and queues. Clarify text where possible, and ensure references come through as links in the html output. Signed-off-by: Bruce Richardson --- lib/eventdev/rte_eventdev.h | 1

[PATCH v2 07/11] eventdev: fix documentation for counting single-link ports

The documentation of how single-link port-queue pairs were counted in the rte_event_dev_config structure did not match the actual implementation and, if following the documentation, certain valid port/queue configurations would have been impossible to configure. Fix this by changing the documentati

[PATCH v2 06/11] eventdev: improve doxygen comments on configure struct

General rewording and cleanup on the rte_event_dev_config structure. Improved the wording of some sentences and created linked cross-references out of the existing references to the dev_info structure. Signed-off-by: Bruce Richardson --- lib/eventdev/rte_eventdev.h | 47 +++--

[PATCH v2 05/11] eventdev: improve function documentation for query fns

General improvements to the doxygen docs for eventdev functions for querying basic information: * number of devices * id for a particular device * socket id of device * capability information for a device Signed-off-by: Bruce Richardson --- lib/eventdev/rte_eventdev.h | 22 +-

[PATCH v2 04/11] eventdev: cleanup doxygen comments on info structure

Some small rewording changes to the doxygen comments on struct rte_event_dev_info. Signed-off-by: Bruce Richardson --- lib/eventdev/rte_eventdev.h | 46 - 1 file changed, 25 insertions(+), 21 deletions(-) diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventde

[PATCH v2 03/11] eventdev: update documentation on device capability flags

Update the device capability docs, to: * include more cross-references * split longer text into paragraphs, in most cases with each flag having a single-line summary at the start of the doc block * general comment rewording and clarification as appropriate Signed-off-by: Bruce Richardson ---

[PATCH v2 02/11] eventdev: move text on driver internals to proper section

Inside the doxygen introduction text, some internal details of how eventdev works was mixed in with application-relevant details. Move these details on probing etc. to the driver-relevant section. Signed-off-by: Bruce Richardson --- lib/eventdev/rte_eventdev.h | 32 --

[PATCH v2 00/11] improve eventdev API specification/documentation

This patchset makes rewording improvements to the eventdev doxygen documentation to try and ensure that it is as clear as possible, describes the implementation as accurately as possible, and is consistent within itself. Most changes are just minor rewordings, along with plenty of changes to chang

[PATCH v2 01/11] eventdev: improve doxygen introduction text

Make some textual improvements to the introduction to eventdev and event devices in the eventdev header file. This text appears in the doxygen output for the header file, and introduces the key concepts, for example: events, event devices, queues, ports and scheduling. This patch makes the followi

Re: [PATCH v2 1/2] dts: improve documentation

16/01/2024 17:47, Juraj Linkeš: > Reviewed-by: Juraj Linkeš > > On Tue, Jan 16, 2024 at 12:46 PM Luca Vizzarro wrote: > > > > Improve instructions for installing dependencies, configuring and > > launching the project. Add mypy in the list of developer tools. > > > > Finally, fix a bug where Poe

Re: [dpdk-dev] [PATCH v3] eal: refactor rte_eal_init into sub-functions

On Fri, Jan 19, 2024 at 08:58:17AM -0800, Rahul Gupta wrote: > From: Rahul Gupta > > In continuation to the following email, I am sending this patch. > (https://inbox.dpdk.org/dev/20231110172523.ga17...@microsoft.com/) > > Initialization requires rte_eal_init + rte_pktmbuf_pool_create which > ca

RE: [PATCH v5 1/2] drivers/net: fix buffer overflow for ptypes list

Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Friday, January 19, 2024 2:59 PM > To: Sivaramakrishnan, VenkatX ; > Hemant Agrawal ; Sachin Saxena > ; Zyta Szpak ; Liron Himi > ; Chaoyong He ; > Gagandeep Singh ; Jerin Jacob ; > Maciej Czekaj > Cc: dev@dpdk.org; Power, Ciar

[v4] net/gve: enable imissed stats for GQ format

Read from shared region to retrieve imissed statistics for GQ from device. Signed-off-by: Rushil Gupta Reviewed-by: Joshua Washington --- drivers/net/gve/base/gve_adminq.h | 11 drivers/net/gve/gve_ethdev.c | 104 ++ drivers/net/gve/gve_ethdev.h | 6

Re: [PATCH v6 00/20] Remove uses of PMD logtype

On Fri, 19 Jan 2024 14:59:58 +0100 David Marchand wrote: > This series mixes unrelated changes, like adding missing \n or > removing some of them. > I identified a couple of places where it introduces issues by doing so. > > Please focus on changing the logtype / log macros and not silently > "f

[dpdk-dev] [PATCH v3] eal: refactor rte_eal_init into sub-functions

From: Rahul Gupta In continuation to the following email, I am sending this patch. (https://inbox.dpdk.org/dev/20231110172523.ga17...@microsoft.com/) Initialization requires rte_eal_init + rte_pktmbuf_pool_create which can consume a total time of 500-600 ms: a) For many devices FLR may take a si

Re: [PATCH] test/security: add inline IPsec Rx inject test

On Fri, 19 Jan 2024 11:42:20 +0530 Rahul Bhansali wrote: > +static int > +test_ipsec_with_rx_inject(struct ip_pkt_vector *vector, const struct > ipsec_test_flags *flags) > +{ > + struct rte_security_session_conf sess_conf_out = {0}; > + struct rte_security_session_conf sess_conf_in = {0}

[PATCH] cryptodev: add a simple mapping cache to speed up ops pool create

Cache the most recent VA -> PA mapping found so that we can skip most of the system calls. With 4K pages this reduces pool create time by about 90%. Signed-off-by: Andrew Boyer --- lib/cryptodev/rte_crypto.h| 5 + lib/cryptodev/rte_cryptodev.c | 23 ++- 2 files chang

Re: [v3] net/gve: enable imissed stats for GQ format

I misinterpreted your comment earlier and prefixed memzone variable name with "gve" instead of memzone name. Will fix it in v4. Thanks! On Fri, Jan 19, 2024 at 8:55 PM Ferruh Yigit wrote: > On 1/19/2024 2:26 PM, Rushil Gupta wrote: > > Read from shared region to retrieve imissed statistics for G

[PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail

Telemetry can only create 10 conns by default, each of which is processed by a thread. When a thread fails to write using socket, the thread will end directly without reducing the total number of conns. This will result in the machine running for a long time, and if there are 10 failures, the tel

[PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail

Telemetry can only create 10 conns by default, each of which is processed by a thread. When a thread fails to write using socket, the thread will end directly without reducing the total number of conns. This will result in the machine running for a long time, and if there are 10 failures, the tel

roadmap & deadlines reminder

Hello, We are approaching a period of release candidates in the cycle 24.03. As a reminder these are the dates: API freeze (-rc1): 5 February 2024 PMD features freeze (-rc2): 23 February 2024 Builtin applications features freeze (-rc3): 4 March 2024 Release: 14 Mar

Re: [PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail

Hello, On Fri, Jan 19, 2024 at 12:40 PM sunshaowei01 <1819846...@qq.com> wrote: > > Telemetry can only create 10 conns by default, each of which is processed > by a thread. > > When a thread fails to write using socket, the thread will end directly > without reducing the total number of conns. > >

RE: [PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail

> -Original Message- > From: sunshaowei01 <1819846...@qq.com> > Sent: Friday, January 19, 2024 11:40 AM > To: dev@dpdk.org > Cc: Power, Ciara > Subject: [PATCH] lib/telemetry:fix telemetry conns leak in case of socket > write > fail > > Telemetry can only create 10 conns by default, e

Re: [v3] net/gve: enable imissed stats for GQ format

On 1/19/2024 2:26 PM, Rushil Gupta wrote: > Read from shared region to retrieve imissed statistics for GQ from device. > > Signed-off-by: Rushil Gupta > Reviewed-by: Joshua Washington > <...> > +static int > +gve_alloc_stats_report(struct gve_priv *priv, > + uint16_t nb_tx_queues,

Re: [PATCH v5 1/2] drivers/net: fix buffer overflow for ptypes list

On 1/18/2024 12:07 PM, Sivaramakrishnan Venkat wrote: > Address Sanitizer detects a buffer overflow caused by an incorrect > ptypes list. Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow. > Fix the ptypes list for drivers. > > Fixes: 0849ac3b6122 ("net/tap: add packet type management") > F

Re: [PATCH v5 2/2] drivers/net: return number of types in get supported types

On 1/18/2024 12:07 PM, Sivaramakrishnan Venkat wrote: > Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow. > Enhance code such that the dev_supported_ptypes_get() > function pointer now returns the number of elements to > eliminate the need for "RTE_PTYPE_UNKNOWN" as the last item. > > Sig

[v3] net/gve: enable imissed stats for GQ format

Read from shared region to retrieve imissed statistics for GQ from device. Signed-off-by: Rushil Gupta Reviewed-by: Joshua Washington --- drivers/net/gve/base/gve_adminq.h | 11 drivers/net/gve/gve_ethdev.c | 103 ++ drivers/net/gve/gve_ethdev.h | 6

Re: [PATCH v6 00/20] Remove uses of PMD logtype

On Fri, Dec 22, 2023 at 6:18 PM Stephen Hemminger wrote: > > The generic RTE_LOGTYPE_PMD is a leftover and should be removed. > This replaces all uses in current tree. It leaves PMD logtype > as deprecated because there maybe other uses in external projects > leftover. > > This version does not us

Re: [PATCH] net/gve: Enable stats reporting for GQ format

Those are fair points. I'll fix this by simply calling gve_get_imissed_from_nic from gve_xstats_get in the v3 patch. On Wed, Jan 17, 2024 at 3:10 PM Ferruh Yigit wrote: > On 1/16/2024 6:18 AM, Rushil Gupta wrote: > > > > > > On Fri, Jan 12, 2024 at 8:36 PM Ferruh Yigit >

Re: [PATCH v5 6/6] eal: replace out of bounds VLA with static_assert

On 1/18/2024 6:42 PM, Morten Brørup wrote: >> From: Stephen Hemminger [mailto:step...@networkplumber.org] >> Sent: Thursday, 18 January 2024 17.51 >> >> Both Gcc, clang and MSVC have better way to do compile time >> assertions rather than using out of bounds array access. >> The old method would fa

Re: [PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail

On Fri, Jan 19, 2024 at 07:40:00PM +0800, sunshaowei01 wrote: > Telemetry can only create 10 conns by default, each of which is processed > by a thread. > > When a thread fails to write using socket, the thread will end directly > without reducing the total number of conns. > > This will result i

[PATCH v1] crypto/ipsec_mb: upgrade IPsec Multi-buffer to 1.4

SW PMDs do not support IPsec Multi-buffer version 1.3 and less. A minimum IPsec Multi-buffer version of 1.4 or greater is now required. Signed-off-by: Sivaramakrishnan Venkat --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 22 --- drivers/crypto/ipsec_mb/meson.build | 2 +- drivers/

[PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail

Telemetry can only create 10 conns by default, each of which is processed by a thread. When a thread fails to write using socket, the thread will end directly without reducing the total number of conns. This will result in the machine running for a long time, and if there are 10 failures, the tel

Re: [PATCH] devtools: forbid writing to standard output streams

On Thu, Dec 21, 2023 at 2:31 PM David Marchand wrote: > > No output on stdout or stderr! > Drivers and libraries must use the logging framework. > > Signed-off-by: David Marchand Applied, thanks. -- David Marchand

Re: [PATCH] dma/dpaa2: fix logtype register

On Mon, Dec 18, 2023 at 4:46 PM David Marchand wrote: > > This driver logtype was not initialized so its logs would end up under > the 0 logtype, iow, RTE_LOGTYPE_EAL. > This issue comes from a typo on the logtype variable name. > > Fixes: 8caf8427f85a ("dma/dpaa2: introduce driver skeleton") > Cc

Re: [PATCH] bus/ifpga: remove dead code

On Mon, Dec 18, 2023 at 4:45 PM David Marchand wrote: > > This macro was never used. > > Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") > > Signed-off-by: David Marchand Applied, thanks. -- David Marchand

RE: [dpdk-dev] [v1] ethdev: support Tx queue used count

> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Friday, 19 January 2024 10.53 > > > > > > > Introduce a new API to retrieve the number of used > descriptors > > > > > > in a Tx queue. Applications can leverage this API in the fast > > > path to > > > > > > inspect the Tx

RE: [PATCH v5 5/6] mempool: avoid floating point expression in static assertion

> -Original Message- > From: Stephen Hemminger > Sent: Thursday, January 18, 2024 6:51 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Konstantin Ananyev > ; Andrew Rybchenko > ; Dariusz Sosnowski > ; Slava Ovsiienko ; Ori > Kam ; Suanming Mou ; Matan > Azrad ; Morten Brørup > Subject: [P

RE: [PATCH] telemetry: correct json empty dictionaries

> -Original Message- > From: Jonathan Erb > Sent: Thursday, January 18, 2024 5:26 PM > To: Power, Ciara > Cc: dev@dpdk.org; Richardson, Bruce ; > Jonathan Erb > Subject: [PATCH] telemetry: correct json empty dictionaries > > Fix to allow telemetry to handle empty dictionaries correct

RE: [dpdk-dev] [v1] ethdev: support Tx queue used count

> > > > > Introduce a new API to retrieve the number of used descriptors > > > > > in a Tx queue. Applications can leverage this API in the fast > > path to > > > > > inspect the Tx queue occupancy and take appropriate actions based > > on the > > > > > available free descriptors. > > > > > > > >

RE: [RFC] cryptodev: refactor sm2, add plain message flag

Hi Ciara/Arek, > Hi Akhil, > > > -Original Message- > > From: Kusztal, ArkadiuszX > > Sent: Friday, August 11, 2023 6:40 PM > > To: dev@dpdk.org > > Cc: gak...@marvell.com; Ji, Kai ; Power, Ciara > > ; Kusztal, ArkadiuszX > > > Subject: [RFC] cryptodev: refactor sm2, add plain message fl

RE: [PATCH 00/14] Add TLS record test suite

> Subject: RE: [PATCH 00/14] Add TLS record test suite > > > Subject: [PATCH 00/14] Add TLS record test suite > > > > Add TLS record test suite in cryptodev autotest framework. The test > > suite would run based on capabilities exposed by the cryptodev. > > > > The test suite framework is similar

RE: [EXT] Re: Comments/Doc error for CRYPTODEV of DPDK

Hi Akhil, Ok, Seems like I need to update my code version. Thank you for letting me know! BR, Songyi -Original Message- From: Akhil Goyal Sent: Friday, January 19, 2024 4:27 PM To: Marchand, David ; Wang, Songyi ; Fan Zhang Cc: dev@dpdk.org; Dong, Yao Subject: RE: [EXT] Re: Comments

RE: [EXT] Re: Comments/Doc error for CRYPTODEV of DPDK

> > > I’ve noticed an error on comment of DPDK version 23.11 rte_cryptodev.h: > 928- > > 930 Ok, now I see the original mail. Thanks David. The line numbers pointed as 928-930 does not have the API rte_cryptodev_sym_session_pool_create for v23.11 The API is at line 1036-1039. And the comment is

RE: [EXT] Re: Comments/Doc error for CRYPTODEV of DPDK

Hi, > Hello, > > On Fri, Jan 19, 2024 at 8:48 AM Wang, Songyi wrote: > > > > Hi maintainer of DPDK, > > Redirecting to the cryptodev maintainers. > Akhil, Fan, can you have a look? > > Thanks. > > > > > > > > > I’ve noticed an error on comment of DPDK version 23.11 rte_cryptodev.h: 928- > 930