Hi Ferruh,
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yi...@amd.com>
> Sent: Friday, January 19, 2024 2:59 PM
> To: Sivaramakrishnan, VenkatX <venkatx.sivaramakrish...@intel.com>;
> Hemant Agrawal <hemant.agra...@nxp.com>; Sachin Saxena
> <sachin.sax...@nxp.com>; Zyta Szpak <z...@semihalf.com>; Liron Himi
> <lir...@marvell.com>; Chaoyong He <chaoyong...@corigine.com>;
> Gagandeep Singh <g.si...@nxp.com>; Jerin Jacob <jer...@marvell.com>;
> Maciej Czekaj <mcze...@marvell.com>
> Cc: dev@dpdk.org; Power, Ciara <ciara.po...@intel.com>;
> pascal.ma...@6wind.com; shreyansh.j...@nxp.com; t...@semihalf.com;
> qin...@corigine.com; jerin.ja...@caviumnetworks.com; sta...@dpdk.org
> Subject: Re: [PATCH v5 1/2] drivers/net: fix buffer overflow for ptypes list
>
> On 1/18/2024 12:07 PM, Sivaramakrishnan Venkat wrote:
> > Address Sanitizer detects a buffer overflow caused by an incorrect
> > ptypes list. Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow.
> > Fix the ptypes list for drivers.
> >
> > Fixes: 0849ac3b6122 ("net/tap: add packet type management")
> > Fixes: a7bdc3bd4244 ("net/dpaa: support packet type parsing")
> > Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton")
> > Fixes: f3f0d77db6b0 ("net/mrvl: support packet type parsing")
> > Fixes: 71e8bb65046e ("net/nfp: update supported list of packet types")
> > Fixes: 659b494d3d88 ("net/pfe: add packet types and basic statistics")
> > Fixes: 398a1be14168 ("net/thunderx: remove generic passX references")
> > Cc: pascal.ma...@6wind.com
> > Cc: shreyansh.j...@nxp.com
> > Cc: z...@semihalf.com
> > Cc: t...@semihalf.com
> > Cc: qin...@corigine.com
> > Cc: g.si...@nxp.com
> > Cc: jerin.ja...@caviumnetworks.com
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Sivaramakrishnan Venkat
> > <venkatx.sivaramakrish...@intel.com>
> >
>
> Reviewed-by: Ferruh Yigit <ferruh.yi...@amd.com>
>
>
> ("Cc: <email>" shouldn't be in the commit message, but not big deal I can
> remove them while merging.
> If you want to help, in next version please put them after '---', as you are
> already doing with changelog)
Thanks for the review on this one.
The DPDK docs suggest adding the Fixes line + CC in the commit message body -
has the guidelines changed for this?
We can update in the next version if that is preferred here though, no problem.
Thanks,
Ciara
