On Fri, Dec 22, 2023 at 6:18 PM Stephen Hemminger
<step...@networkplumber.org> wrote:
>
> The generic RTE_LOGTYPE_PMD is a leftover and should be removed.
> This replaces all uses in current tree. It leaves PMD logtype
> as deprecated because there maybe other uses in external projects
> leftover.
>
> This version does not use Depends-on: because CI system can't
> handle that and want to make sure no PMD left behind
>
> v6 - add a couple of more places
> remove PMD logtype in last patch
This series mixes unrelated changes, like adding missing \n or
removing some of them.
I identified a couple of places where it introduces issues by doing so.
Please focus on changing the logtype / log macros and not silently
"fix" other log issues.
We can fix the latter, later.
Details of what I spotted:
- there is the "funny" case of event/dlb2 where the DLB2_LOG_DBG macro
does not add a \n, while _INFO and _ERR do,
- there is also the case of some _DP log macros in some drivers.
For the drivers below, the _DP macro won't add a \n, while their non
_DP macro equivalent do add one...
$ git grep 'RTE_LOG_DP(.*fmt' drivers/ | grep -v '\\n' | cut -d : -f 1
| xargs grep -B1 -w RTE_LOG_DP
drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h-#define
rte_bbdev_dp_log(level, fmt, args...) \
drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h: RTE_LOG_DP(level,
PMD, fmt, ## args)
--
drivers/bus/cdx/cdx_logs.h-#define CDX_BUS_DP_LOG(level, fmt, args...) \
drivers/bus/cdx/cdx_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args)
--
drivers/bus/fslmc/fslmc_logs.h-#define DPAA2_BUS_DP_LOG(level, fmt, args...) \
drivers/bus/fslmc/fslmc_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args)
--
drivers/common/dpaax/dpaax_logs.h-#define DPAAX_DP_LOG(level, fmt, args...) \
drivers/common/dpaax/dpaax_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args)
--
drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h-#define
DPAA2_SEC_DP_LOG(level, fmt, args...) \
drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h: RTE_LOG_DP(level, PMD,
fmt, ## args)
--
drivers/crypto/dpaa_sec/dpaa_sec_log.h-#define DPAA_SEC_DP_LOG(level,
fmt, args...) \
drivers/crypto/dpaa_sec/dpaa_sec_log.h: RTE_LOG_DP(level, PMD, fmt, ## args)
--
drivers/event/dlb2/dlb2_log.h-#define DLB2_LOG_DBG(fmt, args...) \
drivers/event/dlb2/dlb2_log.h: RTE_LOG_DP(DEBUG, PMD, fmt, ## args)
--
drivers/event/dpaa2/dpaa2_eventdev_logs.h-#define
DPAA2_EVENTDEV_DP_LOG(level, fmt, args...) \
drivers/event/dpaa2/dpaa2_eventdev_logs.h: RTE_LOG_DP(level, PMD,
fmt, ## args)
--
drivers/event/dsw/dsw_evdev.h-#define DSW_LOG_DP(level, fmt, args...)
\
drivers/event/dsw/dsw_evdev.h: RTE_LOG_DP(level, EVENTDEV, "[%s]
%s() line %u: " fmt, \
--
drivers/mempool/dpaa/dpaa_mempool.h-#define DPAA_MEMPOOL_DPDEBUG(fmt, args...) \
drivers/mempool/dpaa/dpaa_mempool.h: RTE_LOG_DP(DEBUG, PMD, fmt, ## args)
--
drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h-#define
DPAA2_MEMPOOL_DP_LOG(level, fmt, args...) \
drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h: RTE_LOG_DP(level,
PMD, fmt, ## args)
--
drivers/net/dpaa/dpaa_ethdev.h-#define DPAA_DP_LOG(level, fmt, args...) \
drivers/net/dpaa/dpaa_ethdev.h: RTE_LOG_DP(level, PMD, fmt, ## args)
--
drivers/net/dpaa2/dpaa2_pmd_logs.h-#define DPAA2_PMD_DP_LOG(level,
fmt, args...) \
drivers/net/dpaa2/dpaa2_pmd_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args)
--
drivers/net/enetc/enetc_logs.h-#define ENETC_PMD_DP_LOG(level, fmt, args...) \
drivers/net/enetc/enetc_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args)
--
drivers/net/enetfec/enet_pmd_logs.h-#define ENETFEC_DP_LOG(level, fmt,
args...) \
drivers/net/enetfec/enet_pmd_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args)
--
drivers/net/pfe/pfe_logs.h-#define PFE_DP_LOG(level, fmt, args...) \
drivers/net/pfe/pfe_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args)
--
David Marchand
