[PATCH v2] eal/x86: add AMD vendor check to choose TSC calibration

2023-11-22 Thread Sivaprasad Tummala
AMD Epyc processors doesn't support get_tsc_freq_arch(). The patch allows graceful return to allow fallback to alternate TSC calibration. Fixes: 3dbc565e81a0 ("timer: honor arch-specific TSC frequency query") Cc: jerin.ja...@caviumnetworks.com Cc: sta...@dpdk.org Signed-off-by: Sivaprasad Tummala

[PATCH v3 1/1] app/test: fix external mbuf test when assertions enabled

2023-11-22 Thread Rakesh Kudurumalla
when RTE_ENABLE_ASSERT is defined test_mbuf application is failing because we are trying to attach extbuf to a cloned buffer to which external mbuf is already attached.To make test_mbuf pass CI we have updated ol_flags. This patch fixes the same. Fixes: 7b295dceea07 ("test/mbuf: add unit test case

[PATCH V1] doc: add tested Intel platforms with Intel NICs

2023-11-22 Thread Lingli Chen
Add tested Intel platforms with Intel NICs to v23.11 release note. Signed-off-by: Lingli Chen --- doc/guides/rel_notes/release_23_11.rst | 146 + 1 file changed, 146 insertions(+) diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.r

Re: [PATCH 0/2] app/testpmd: support set RSS hash algorithm

2023-11-22 Thread Jie Hai
On 2023/11/22 18:46, Ferruh Yigit wrote: On 11/22/2023 9:48 AM, Jie Hai wrote: This patch set supports setting RSS hash algorithm. Jie Hai (2): ethdev: add new API to get RSS hash algorithm by name app/testpmd: support set RSS hash algorithm Hi Jie, Hi, ferruh, It is too late for th

[PATCH 2/2] app/graph: implement L2FWD usecase

2023-11-22 Thread Rakesh Kudurumalla
Added l2fwd usecase for graph Signed-off-by: Rakesh Kudurumalla --- app/graph/cli.c | 1 + app/graph/examples/l2fwd.cli | 41 ++ app/graph/graph.c| 8 +- app/graph/l2fwd.c| 148 +++ app/graph/l2fwd.h|

[PATCH 1/2] node: forward packet from ethdev_rx node

2023-11-22 Thread Rakesh Kudurumalla
By default all packets received on ethdev_rx node is forwarded to pkt_cls node.This patch provides library support to add a new node as next node to ethdev_rx node and forward packet to new node from rx node. Signed-off-by: Rakesh Kudurumalla --- lib/node/ethdev_ctrl.c | 40

Re: [PATCH v1 1/3] dmadev: add inter-domain operations

2023-11-22 Thread Jerin Jacob
On Fri, Oct 27, 2023 at 7:16 PM Medvedkin, Vladimir wrote: > > Hi Satananda, Anoob, Chengwen, Jerin, all, > > After a number of internal discussions we have decided that we're going > to postpone this feature/patchset till next release. > > >[Satananda] Have you considered extending rte_dma_port

Re: [PATCH 24.03 v2 8/9] event/opdl: add schedule-type capability flags

2023-11-22 Thread Jerin Jacob
On Tue, Nov 21, 2023 at 11:47 PM Bruce Richardson wrote: > > Document explicitly the scheduling types supported by this driver, both > via info_get() function, and via table in the documentation. > > Signed-off-by: Bruce Richardson > --- > > Maintainers, please check this patch carefully, as I'm

Re: [PATCH 24.03 v2 2/9] eventdev: increase flexibility of all-types flag

2023-11-22 Thread Jerin Jacob
On Tue, Nov 21, 2023 at 5:25 PM Bruce Richardson wrote: > > Rather than requiring that any device advertising the > RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES flag support all of atomic, ordered > and parallel scheduling, we can redefine the field so that it basically > means that you don't need to specify

Re: [PATCH 24.03 v2 1/9] eventdev: add capability flags for supported sched types

2023-11-22 Thread Jerin Jacob
On Tue, Nov 21, 2023 at 5:25 PM Bruce Richardson wrote: > > Not all eventdev's support all scheduling types, for example, some may > only support atomic scheduling or others only support ordered > scheduling. There is currently no clear indication for each driver what > sched types it supports, so

release candidate 23.11-rc4

2023-11-22 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v23.11-rc4 There are 58 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_23_11.html There are more doc and tools updates to be merged before closing this

[PATCH v1] doc/mlx5: update IPv6 routing extension matching limitation

2023-11-22 Thread Rongwei Liu
Due to hardware limitations, the relaxed mode is not supported, otherwise, packets may mismatch. Signed-off-by: Rongwei Liu Acked-by: Suanming Mou Acked-by: Thomas Monjalon --- doc/guides/nics/mlx5.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/

Re: [PATCH 3/5] common/nfp: fix integer handling issues

2023-11-22 Thread Thomas Monjalon
23/11/2023 02:23, Chaoyong He: > > 15/11/2023 04:23, Chaoyong He: > > > CI found integer handling issues, overflow before widen. > > > > > > Coverity issue: 405351 > > > Fixes: 87f5b35ba4e8 ("common/nfp: move queue logic") > > > Cc: sta...@dpdk.org > > [...] > > > - enabled_queues |= (1 <<

Re: [PATCH] examples/l3fwd-power: fix to configure the uncore env

2023-11-22 Thread Thomas Monjalon
26/10/2023 17:19, Sivaprasad Tummala: > Updated the l3fwd-power app to configure the uncore env before invoking > any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is > too late because other APIs already called. You are also updating the uncore API. > + if (env == RTE_UNCO

Re: [PATCH v3 0/3] fix test-pipeline issues

2023-11-22 Thread Thomas Monjalon
> > Feifei Wang (3): > > app/test-pipeline: relax RSS hash requirement > > app/test-pipeline: fix SIGINT handling issue > > app/test-pipeline: add dev close operation > > > Series-acked-by: Cristian Dumitrescu Applied with few minor cleanups.

Re: [PATCH v4 10/10] common/dpaxx: remove zero length array

2023-11-22 Thread Stephen Hemminger
On Wed, 22 Nov 2023 07:23:36 + Hemant Agrawal wrote: > > -Original Message- > > From: Tyler Retzlaff > > Sent: Tuesday, November 21, 2023 10:49 PM > > To: Stephen Hemminger > > Cc: Hemant Agrawal ; dev@dpdk.org; Sachin > > Saxena ; Gagandeep Singh > > Subject: Re: [PATCH v4 10/10]

RE: release candidate 23.11-rc3

2023-11-22 Thread Xu, HailinX
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, November 22, 2023 6:26 PM > To: Xu, HailinX ; Thomas Monjalon > ; dev@dpdk.org > Cc: Kovacevic, Marko ; Mcnamara, John > ; Richardson, Bruce > ; Ferruh Yigit > Subject: Re: release candidate 23.11-rc3 > > On 11/22/2023 5:41 AM,

[Bug 1329] Kernel BPF API changes break TAP RSS

2023-11-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1329 Bug ID: 1329 Summary: Kernel BPF API changes break TAP RSS Product: DPDK Version: 23.07 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Prior

[PATCH v4 6/6] Section 6: Glossary

2023-11-22 Thread David Young
-Glossary Introduction Formatting: Refined the introduction's formatting for clarity. -Directive Implementation: Used .. glossary:: directive for structured term definitions. -Term Definitions and Linking: Expanded definitions for terms like BIOS, Bifurcated Driver, Clang-LLVM, etc., with referen

[PATCH v4 5/6] Section 5: Appendix

2023-11-22 Thread David Young
Added new guide on hugepages for different architectures Added hugepages_different_architectures to index -Content Streamlining: Removed initial detailed instructions on setting up DPDK for non-root users. Emphasized that running DPDK as non-root on Linux requires IOMMU support through vfio. -Li

[PATCH v4 4/6] Section 4: Running Applications

2023-11-22 Thread David Young
--- .../getting_started_guide/run_apps/index.rst | 10 ++ .../run_apps/run_apps.rst | 118 ++ 2 files changed, 128 insertions(+) create mode 100644 doc/guides/getting_started_guide/run_apps/index.rst create mode 100644 doc/guides/getting_started_guide/run_ap

[PATCH v4 3/6] Section 3: Setting up a System to Run DPDK Applications

2023-11-22 Thread David Young
Replaced .. |reg| unicode:: U+000AE with .. include:: Added a reference to the section memory_setup_reserving_hugepages -Corrected the sentence “To check if hugepages are are on your system” to “To check if hugepages are reserved on your system” -Updated the instructions for checking if your distr

[PATCH v4 2/6] Section 2: Install and Build DPDK

2023-11-22 Thread David Young
-Common Tools for All Distributions: The common tools installation instructions for all Linux distributions and FreeBSD have been removed. Instead, the tools are now listed under each specific distribution. -Linux Distributions: The Linux distributions have been restructured to include Alpine, Deb

[PATCH v4 1/6] Section 1: Introduction

2023-11-22 Thread David Young
Added link to Getting Started Guide in index.rst Moved run_apps.rst to GSG index Removed run_apps/index.rst - no longer needed Added run_apps.rst to index -Reformatted the introduction paragraph for better readability. -Clarified that the guide provides basic step-by-step instructions with OS-

[PATCH v4 0/6] docs: getting started guide consolidation

2023-11-22 Thread David Young
This patch series introduces significant updates to the DPDK Getting Started Guide, enhancing user accessibility and content clarity: 1-Structural Improvements: Integrated links to the Getting Started Guide in the main index. Relocated run_apps.rst to the GSG index and removed run_apps/index.rst.

RE: [PATCH 3/5] common/nfp: fix integer handling issues

2023-11-22 Thread Chaoyong He
> 15/11/2023 04:23, Chaoyong He: > > CI found integer handling issues, overflow before widen. > > > > Coverity issue: 405351 > > Fixes: 87f5b35ba4e8 ("common/nfp: move queue logic") > > Cc: sta...@dpdk.org > [...] > > - enabled_queues |= (1 << i); > > + enabled_queues |= (1ULL <

Re: [PATCH v8 3/4] app/dma-perf: validate copied memory

2023-11-22 Thread fengchengwen
Acked-by: Chengwen Feng On 2023/11/22 19:06, Gowrishankar Muthukrishnan wrote: > Validate copied memory to ensure DMA copy did not fail. > > Signed-off-by: Gowrishankar Muthukrishnan > Acked-by: Anoob Joseph > --- > app/test-dma-perf/benchmark.c | 21 - > app/test-dma-perf

Re: [PATCH v8 2/4] app/dma-perf: add PCI device support

2023-11-22 Thread fengchengwen
Acked-by: Chengwen Feng On 2023/11/22 19:06, Gowrishankar Muthukrishnan wrote: > From: Amit Prakash Shukla > > Add support to test performance for "device to memory" and > "memory to device" data transfer. > > Signed-off-by: Amit Prakash Shukla > Acked-by: Anoob Joseph > --- > app/test-dma-

Re: [PATCH 1/1] test/hash: fix error log output

2023-11-22 Thread Thomas Monjalon
12/09/2023 13:52, Min Zhou: > Caught while running meson test: > hash creation failedTest Failed > > Add missing \n. > > Fixes: 0eb3726ebcf ("test/hash: add test for read/write concurrency") > > Signed-off-by: Min Zhou Applied, thanks.

Re: [PATCH v2 1/1] ml/cnxk: fix name of TVM model with single layer

2023-11-22 Thread Thomas Monjalon
22/11/2023 18:13, Srikanth Yalavarthi: > Name field of TVM model with single MRVL layer is > currently set to empty string. Update the name with > the field from metadata. > > Fixes: 5cea2c67edfc ("ml/cnxk: update internal TVM model info structure") > > Signed-off-by: Srikanth Yalavarthi Applie

Re: [PATCH v2 1/1] ml/cnxk: fix reading model and layer ID

2023-11-22 Thread Thomas Monjalon
22/11/2023 19:35, Srikanth Yalavarthi: > Using model_id from op structure as layer index for TVM > models with multiple MRVL layers is incorrect. This patch > fixes the issue by reading the layer index from the job > descriptor structure. > > Fixes: 31cc30b5f088 ("ml/cnxk: update model start/stop

Re: [PATCH] common/qat: fix build errors with incompatible IPSec lib

2023-11-22 Thread Thomas Monjalon
> > Since "find_library()" is used to find the libipsec_mb library, there is a > > chance > > that an incompatible library will be found e.g. when doing cross-builds. To > > fix > > this, we copy the logic from the crypto/ipsec_mb driver to actually do a > > link- > > check on the library before

Re: [PATCH v2 1/3] usertools/rss: add driver abstractions

2023-11-22 Thread Thomas Monjalon
20/11/2023 17:22, Robin Jarry: > The default RETA size is not the same for all drivers. In some drivers > (mlx5), the RETA size may also be dependent on the number of RX queues. > > Introduce a new DriverInfo abstraction for known keys. Define a simple > API to expose the RSS key and RETA size (ba

Re: [PATCH 1/2] usertools/rss: add driver abstractions

2023-11-22 Thread Thomas Monjalon
22/11/2023 10:37, fengchengwen: > On 2023/11/22 16:28, Robin Jarry wrote: > > Stephen Hemminger, Nov 21, 2023 at 18:27: > >> On Tue, 21 Nov 2023 22:51:19 +0530 > >> Jerin Jacob wrote: > >> > IMO, That may be too much of non-productive work to save a couple of > >> > lines(seed array) of duplicate

Re: [PATCH] usertools/pmdinfo: fix usage typos

2023-11-22 Thread Thomas Monjalon
27/09/2023 09:56, David Marchand: > On Tue, Sep 19, 2023 at 12:20 PM Robin Jarry wrote: > > > > The docs and script usages are not consistent. > > > > There is no .devices, .vendor_id nor .device_id fields. Fix usage to the > > correct field names. > > > > Some drivers do not expose any pci_ids, s

Re: [PATCH v5 0/2] example/l3fwd: relax l3fwd rx RSS/Offload if needed

2023-11-22 Thread Thomas Monjalon
13/11/2023 17:11, Trevor Tao: > This series try to relax l3fwd rx RSS/Offload mode requirement if they > are not supported by underlying hw or virtual devices, there is an > option named relax_rx_mode added to enable this option. > > Trevor Tao (2): > examples/l3fwd: relax RSS requirement with o

Re: [PATCH v2] examples/ethtool: fix pause configuration

2023-11-22 Thread Thomas Monjalon
10/11/2023 04:30, Huisong Li: > Currently, the pause command in ethtool to enable Rx/Tx pause has the > following problem. Namely, Assume that the device supports flow control > auto-negotiation to set pause parameters, which will the device that does > not support flow control auto-negotiation fai

Re: [PATCH v7 0/5] dumpcap and pcapng fixes

2023-11-22 Thread Thomas Monjalon
> Stephen Hemminger (5): > pdump: fix setting rte_errno on mp error > dumpcap: allow multiple invocations > pcapng: modify timestamp calculation > pcapng: avoid using alloca() > test: cleanups to pcapng test Applied with a note about the API change in release notes.

[PATCH v2 1/1] ml/cnxk: fix reading model and layer ID

2023-11-22 Thread Srikanth Yalavarthi
Using model_id from op structure as layer index for TVM models with multiple MRVL layers is incorrect. This patch fixes the issue by reading the layer index from the job descriptor structure. Fixes: 31cc30b5f088 ("ml/cnxk: update model start/stop functions") Signed-off-by: Srikanth Yalavarthi --

RE: [PATCH] eal/x86: add vendor ID checks for specific implementation

2023-11-22 Thread Tummala, Sivaprasad
[AMD Official Use Only - General] Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, November 22, 2023 4:56 PM > To: Tummala, Sivaprasad ; > bruce.richard...@intel.com; konstantin.v.anan...@yandex.ru > Cc: dev@dpdk.org; David Marchand > Subject: Re: [PATCH] eal/x86

RE: [EXT] Re: [PATCH 1/1] ml/cnxk: fix name of TVM model with single layer

2023-11-22 Thread Srikanth Yalavarthi
> -Original Message- > From: Bruce Richardson > Sent: 22 November 2023 22:21 > To: Srikanth Yalavarthi > Cc: Prince Takkar ; dev@dpdk.org; Shivah Shankar > Shankar Narayan Rao ; Anup Prabhu > ; Jerin Jacob Kollanukkaran > Subject: [EXT] Re: [PATCH 1/1] ml/cnxk: fix name of TVM model with

[PATCH v2 1/1] ml/cnxk: fix name of TVM model with single layer

2023-11-22 Thread Srikanth Yalavarthi
Name field of TVM model with single MRVL layer is currently set to empty string. Update the name with the field from metadata. Fixes: 5cea2c67edfc ("ml/cnxk: update internal TVM model info structure") Signed-off-by: Srikanth Yalavarthi --- v2: - Replaced rte_memcpy with strlcpy drivers/ml/cn

RE: [PATCH] common/qat: fix build errors with incompatible IPSec lib

2023-11-22 Thread Power, Ciara
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, November 22, 2023 4:47 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Dooley, Brian > ; Ji, Kai ; De Lara Guarch, Pablo > ; Power, Ciara > Subject: [PATCH] common/qat: fix build errors with incompatible IPSec lib > > S

Re: [PATCH] eal/windows: fix memory management macros usage

2023-11-22 Thread David Marchand
On Tue, Nov 14, 2023 at 6:06 PM Gregory Etelson wrote: > > Windows compilation with cross-mingw on Fedora 39 failed > because MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER were > already defined in the compiler environment: > > eal_memory.c:77: error: "MEM_REPLACE_PLACEHOLDER" redefined > /u

Re: [PATCH 1/1] ml/cnxk: fix name of TVM model with single layer

2023-11-22 Thread Bruce Richardson
On Wed, Nov 22, 2023 at 04:48:50PM +, Bruce Richardson wrote: > On Wed, Nov 22, 2023 at 08:36:40AM -0800, Srikanth Yalavarthi wrote: > > Name field of TVM model with single MRVL layer is > > currently set to empty string. Update the name with > > the field from metadata. > > > > Fixes: 5cea2c6

Re: [PATCH 1/1] ml/cnxk: fix name of TVM model with single layer

2023-11-22 Thread Bruce Richardson
On Wed, Nov 22, 2023 at 08:36:40AM -0800, Srikanth Yalavarthi wrote: > Name field of TVM model with single MRVL layer is > currently set to empty string. Update the name with > the field from metadata. > > Fixes: 5cea2c67edfc ("ml/cnxk: update internal TVM model info structure") > > Signed-off-by

[PATCH 24.03 4/4] dlb2: add new arg parsing library API support

2023-11-22 Thread Euan Bourke
Switched the dlb2 driver to call the new arg parsing library instead of eal for coremask parsing, and updated the resource probe funcion to support the changed formatting of the API. Signed-off-by: Euan Bourke --- drivers/event/dlb2/dlb2_priv.h | 4 +- drivers/event/dlb2/pf/base/dlb

[PATCH 24.03 3/4] eal: add support for new arg parsing library

2023-11-22 Thread Euan Bourke
Update to eal functions relating to corelist and coremask parsing to support the new arg parsing library. Functions now call the API instead of implementing their own version. Signed-off-by: Euan Bourke --- lib/eal/common/eal_common_options.c | 114 lib/eal/meson.bui

[PATCH 24.03 2/4] arg_parser: add new coremask parsing API

2023-11-22 Thread Euan Bourke
Add new coremask parsing API. This API behaves similarly to the corelist parsing API, parsing the coremask string, filling its values into the cores array. The API also returns a 'count' which corresponds to the total number of cores in the coremask string. Signed-off-by: Euan Bourke --- lib/ar

[PATCH 24.03 1/4] arg_parser: new library for command line parsing

2023-11-22 Thread Euan Bourke
Add a new library to make it easier for eal and other libraries to parse command line arguments. The first function in this library is one to parse a corelist string into an array of individual core ids. The function will then return the total number of cores described in the corelist Signed-off-

[PATCH 24.03 0/4] add new command line argument parsing library

2023-11-22 Thread Euan Bourke
A recent thread on the mailing list[1] discussed corelist and coremask parsing and the idea of a new library dedicated to command line parsing was mentioned[2]. As I had been working on a public corelist parsing API at the time, this patchset adds the library, along with the new APIs, edits to EAL

Re: [PATCH] eal/windows: fix memory management macros usage

2023-11-22 Thread Thomas Monjalon
14/11/2023 20:19, Dmitry Kozlyuk: > 2023-11-14 19:05 (UTC+0200), Gregory Etelson: > > Windows compilation with cross-mingw on Fedora 39 failed > > because MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER were > > already defined in the compiler environment: > > > > eal_memory.c:77: error: "MEM_

[PATCH] common/qat: fix build errors with incompatible IPSec lib

2023-11-22 Thread Bruce Richardson
Since "find_library()" is used to find the libipsec_mb library, there is a chance that an incompatible library will be found e.g. when doing cross-builds. To fix this, we copy the logic from the crypto/ipsec_mb driver to actually do a link-check on the library before deciding it can be used. Fixes

Re: [PATCH] maintainers: volunteer to maintain security library

2023-11-22 Thread Thomas Monjalon
> > Add co-maintainer for security library. > > > > Signed-off-by: Anoob Joseph > Acked-by: Akhil Goyal Applied, thanks.

Re: [PATCH] build: riscv is not a valid -march value

2023-11-22 Thread David Marchand
On Wed, Nov 22, 2023 at 5:17 PM Bruce Richardson wrote: > > On Wed, Nov 22, 2023 at 05:02:56PM +0100, David Marchand wrote: > > On Tue, Nov 21, 2023 at 5:49 PM wrote: > > > > > > From: Christian Ehrhardt > > > > > > If building riscv natively with -Dplatform=generic config/meson.build > > > will

Re: [PATCH] eal/windows: fix mingw build

2023-11-22 Thread Bruce Richardson
On Wed, Nov 22, 2023 at 05:36:44PM +0100, David Marchand wrote: > On Wed, Nov 22, 2023 at 5:32 PM Bruce Richardson > wrote: > > > > When compiling with mingw on Ubuntu 23.10, I get the following compiler > > error: > > > > ../../lib/eal/windows/eal_memory.c:77: error: "MEM_REPLACE_PLACEHOLDER" >

Re: [PATCH] build: riscv is not a valid -march value

2023-11-22 Thread David Marchand
On Tue, Nov 21, 2023 at 5:49 PM wrote: > > From: Christian Ehrhardt > > If building riscv natively with -Dplatform=generic config/meson.build > will select cpu_instruction_set=riscv. > > That was fine because config/riscv/meson.build did override it to valid > values later, but since b7676fcccab4

Re: [PATCH] examples/ipsec-secgw: fix partial overflow

2023-11-22 Thread Thomas Monjalon
> > Case of partial overflow detected with ASan. Added extra padding to cdev_key > > structure. > > > > This structure is used for the key in hash table. > > Padding is added to force the struct to use 8 bytes, to ensure memory is > > notread past this structs boundary (the hash key calculation re

[PATCH 1/1] ml/cnxk: fix reading model and layer ID

2023-11-22 Thread Srikanth Yalavarthi
Using model_id from op structure as layer index for TVM models with multiple MRVL layers is incorrect. This patch fixes the issue by reading the layer index from the job descriptor structure. Fixes: 31cc30b5f088 ("ml/cnxk: update model start/stop functions") Signed-off-by: Srikanth Yalavarthi --

Re: [PATCH] eal/windows: fix mingw build

2023-11-22 Thread David Marchand
On Wed, Nov 22, 2023 at 5:32 PM Bruce Richardson wrote: > > When compiling with mingw on Ubuntu 23.10, I get the following compiler > error: > > ../../lib/eal/windows/eal_memory.c:77: error: "MEM_REPLACE_PLACEHOLDER" > redefined [-Werror] >77 | #define MEM_REPLACE_PLACEHOLDER 0x4000 >

[PATCH 1/1] ml/cnxk: fix name of TVM model with single layer

2023-11-22 Thread Srikanth Yalavarthi
Name field of TVM model with single MRVL layer is currently set to empty string. Update the name with the field from metadata. Fixes: 5cea2c67edfc ("ml/cnxk: update internal TVM model info structure") Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/mvtvm_ml_model.c | 4 1 file chang

[PATCH] eal/windows: fix mingw build

2023-11-22 Thread Bruce Richardson
When compiling with mingw on Ubuntu 23.10, I get the following compiler error: ../../lib/eal/windows/eal_memory.c:77: error: "MEM_REPLACE_PLACEHOLDER" redefined [-Werror] 77 | #define MEM_REPLACE_PLACEHOLDER 0x4000 | In file included from /usr/share/mingw-w64/include/minwindef.h:16

Re: [PATCH v2] crypto/qat: fix block cipher misalignment for AES CBC and 3DES CBC

2023-11-22 Thread Thomas Monjalon
> > check cipher length alignment for 3DES CBC and AES CBC to change it to NULL > > service type for buffer misalignment. > > > > Fixes: def38073ac90 ("crypto/qat: check cipher buffer alignment") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Sivaramakrishnan Venkat > > > > Acked-by: Kai Ji > >

Re: [PATCH] build: riscv is not a valid -march value

2023-11-22 Thread Bruce Richardson
On Wed, Nov 22, 2023 at 05:02:56PM +0100, David Marchand wrote: > On Tue, Nov 21, 2023 at 5:49 PM wrote: > > > > From: Christian Ehrhardt > > > > If building riscv natively with -Dplatform=generic config/meson.build > > will select cpu_instruction_set=riscv. > > > > That was fine because config/r

Re: [PATCH] build: riscv is not a valid -march value

2023-11-22 Thread David Marchand
On Tue, Nov 21, 2023 at 5:49 PM wrote: > > From: Christian Ehrhardt > > If building riscv natively with -Dplatform=generic config/meson.build > will select cpu_instruction_set=riscv. > > That was fine because config/riscv/meson.build did override it to valid > values later, but since b7676fcccab4

Re: [PATCH v1] test/crypto: fix timeout in Rx inject

2023-11-22 Thread Thomas Monjalon
21/11/2023 07:57, Anoob Joseph: > > > > Fix the timeout condition for rx in Rx inject. > > > > Fixes: 69e1a909aa08 (test/crypto: add Rx inject) > > > > Signed-off-by: Vidya Sagar Velumuri > > Acked-by: Anoob Joseph Applied, thanks.

Re: RFC - GRO Flowlookup Optimisation

2023-11-22 Thread kumaraparameshwaran rathinavel
On Wed, Nov 22, 2023 at 8:44 PM 胡嘉瑜 wrote: > Hi Kumara, > > It is a good idea. You can send the code and I will help to review. > >> Thanks Jiyau. Will try to get out a PR in few days. >> > > Thanks, > Jiayu > -- > 发自我的iPhone > > > -- Original -

Re: RFC - GRO Flowlookup Optimisation

2023-11-22 Thread kumaraparameshwaran rathinavel
On Wed, Nov 22, 2023 at 4:05 PM Ferruh Yigit wrote: > On 11/22/2023 6:01 AM, kumaraparameshwaran rathinavel wrote: > > Hi Folks, > > > > The current GRO code uses an unoptimised version of flow lookup where > > each flow in the table is iterated over during the flow matching > > process. For a rt

Re: RFC - GRO Flowlookup Optimisation

2023-11-22 Thread 胡嘉瑜
Hi Kumara, It is a good idea. You can send the code and I will help to review. Thanks, Jiayu 发自我的iPhone -- Original -- From: kumaraparameshwaran rathinavel

Re: [PATCH v7 21/21] dts: test suites docstring update

2023-11-22 Thread Juraj Linkeš
On Mon, Nov 20, 2023 at 1:50 PM Yoan Picchi wrote: > > On 11/20/23 10:17, Juraj Linkeš wrote: > > On Thu, Nov 16, 2023 at 6:36 PM Yoan Picchi > > wrote: > >> > >> On 11/15/23 13:09, Juraj Linkeš wrote: > >>> Format according to the Google format and PEP257, with slight > >>> deviations. > >>> >

Re: [PATCH v7 16/21] dts: posix and linux sessions docstring update

2023-11-22 Thread Juraj Linkeš
On Wed, Nov 22, 2023 at 2:24 PM Yoan Picchi wrote: > > On 11/15/23 13:09, Juraj Linkeš wrote: > > Format according to the Google format and PEP257, with slight > > deviations. > > > > Signed-off-by: Juraj Linkeš > > --- > > dts/framework/testbed_model/linux_session.py | 63 ++- > >

Re: [PATCH v7 18/21] dts: sut and tg nodes docstring update

2023-11-22 Thread Juraj Linkeš
On Wed, Nov 22, 2023 at 2:13 PM Yoan Picchi wrote: > > On 11/15/23 13:09, Juraj Linkeš wrote: > > Format according to the Google format and PEP257, with slight > > deviations. > > > > Signed-off-by: Juraj Linkeš > > --- > > dts/framework/testbed_model/sut_node.py | 224

Re: [PATCH v7 17/21] dts: node docstring update

2023-11-22 Thread Juraj Linkeš
On Wed, Nov 22, 2023 at 1:18 PM Yoan Picchi wrote: > > On 11/15/23 13:09, Juraj Linkeš wrote: > > Format according to the Google format and PEP257, with slight > > deviations. > > > > Signed-off-by: Juraj Linkeš > > --- > > dts/framework/testbed_model/node.py | 191 +++-

Re: [PATCH v7 15/21] dts: os session docstring update

2023-11-22 Thread Juraj Linkeš
On Wed, Nov 22, 2023 at 12:50 PM Yoan Picchi wrote: > > On 11/15/23 13:09, Juraj Linkeš wrote: > > Format according to the Google format and PEP257, with slight > > deviations. > > > > Signed-off-by: Juraj Linkeš > > --- > > dts/framework/testbed_model/os_session.py | 275 --

RE: [PATCH] build: riscv is not a valid -march value

2023-11-22 Thread Tummala, Sivaprasad
[AMD Official Use Only - General] > -Original Message- > From: christian.ehrha...@canonical.com > Sent: Tuesday, November 21, 2023 10:19 PM > To: dev ; Thomas Monjalon > Cc: Luca Boccassi ; Christian Ehrhardt > > Subject: [PATCH] build: riscv is not a valid -march value > > Caution: Thi

Re: [PATCH v7 16/21] dts: posix and linux sessions docstring update

2023-11-22 Thread Yoan Picchi
On 11/15/23 13:09, Juraj Linkeš wrote: Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/linux_session.py | 63 ++- dts/framework/testbed_model/posix_session.py | 81 +--- 2 files

Re: [PATCH v7 20/21] dts: scapy tg docstring update

2023-11-22 Thread Juraj Linkeš
On Tue, Nov 21, 2023 at 5:33 PM Yoan Picchi wrote: > > On 11/15/23 13:09, Juraj Linkeš wrote: > > Format according to the Google format and PEP257, with slight > > deviations. > > > > Signed-off-by: Juraj Linkeš > > --- > > .../testbed_model/traffic_generator/scapy.py | 91 +++

Re: [PATCH v7 18/21] dts: sut and tg nodes docstring update

2023-11-22 Thread Yoan Picchi
On 11/15/23 13:09, Juraj Linkeš wrote: Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/sut_node.py | 224 dts/framework/testbed_model/tg_node.py | 42 +++-- 2 files changed, 173

Re: [PATCH v7 19/21] dts: base traffic generators docstring update

2023-11-22 Thread Juraj Linkeš
On Wed, Nov 22, 2023 at 1:05 PM Yoan Picchi wrote: > > On 11/22/23 11:38, Juraj Linkeš wrote: > > On Tue, Nov 21, 2023 at 5:20 PM Yoan Picchi > > wrote: > >> > >> On 11/15/23 13:09, Juraj Linkeš wrote: > >>> Format according to the Google format and PEP257, with slight > >>> deviations. > >>> >

Re: [PATCH v7 17/21] dts: node docstring update

2023-11-22 Thread Yoan Picchi
On 11/15/23 13:09, Juraj Linkeš wrote: Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/node.py | 191 +++- 1 file changed, 131 insertions(+), 60 deletions(-) diff --git a/dts/framew

RE: [EXT] Re: [PATCH v7 1/4] app/dma-perf: add skip support

2023-11-22 Thread Amit Prakash Shukla
Hi Chengwen, Thanks for the review and feedback. Changes suggested by you are incorporated as part of v8 send by Gowrishankar. In v8, have also removed a redundant check for TEST_TYPE_NONE. Thanks, Amit Shukla > -Original Message- > From: fengchengwen > Sent: Monday, November 20, 2023

Re: [PATCH v7 19/21] dts: base traffic generators docstring update

2023-11-22 Thread Yoan Picchi
On 11/22/23 11:38, Juraj Linkeš wrote: On Tue, Nov 21, 2023 at 5:20 PM Yoan Picchi wrote: On 11/15/23 13:09, Juraj Linkeš wrote: Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- .../traffic_generator/__init__.py | 22 ++

Re: [PATCH 3/5] common/nfp: fix integer handling issues

2023-11-22 Thread Thomas Monjalon
15/11/2023 04:23, Chaoyong He: > CI found integer handling issues, overflow before widen. > > Coverity issue: 405351 > Fixes: 87f5b35ba4e8 ("common/nfp: move queue logic") > Cc: sta...@dpdk.org [...] > - enabled_queues |= (1 << i); > + enabled_queues |= (1ULL << i); That's

Re: [PATCH v7 15/21] dts: os session docstring update

2023-11-22 Thread Yoan Picchi
On 11/15/23 13:09, Juraj Linkeš wrote: Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/os_session.py | 275 -- 1 file changed, 208 insertions(+), 67 deletions(-) diff --git a/dts/framew

Re: [PATCH v7 19/21] dts: base traffic generators docstring update

2023-11-22 Thread Juraj Linkeš
On Tue, Nov 21, 2023 at 5:20 PM Yoan Picchi wrote: > > On 11/15/23 13:09, Juraj Linkeš wrote: > > Format according to the Google format and PEP257, with slight > > deviations. > > > > Signed-off-by: Juraj Linkeš > > --- > > .../traffic_generator/__init__.py | 22 - > > .../

Re: [PATCH v7 11/21] dts: remote session docstring update

2023-11-22 Thread Yoan Picchi
On 11/22/23 11:13, Juraj Linkeš wrote: On Tue, Nov 21, 2023 at 4:36 PM Yoan Picchi wrote: On 11/15/23 13:09, Juraj Linkeš wrote: Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/remote_session/__init__.py | 39 +

Re: [PATCH] eal/x86: add vendor ID checks for specific implementation

2023-11-22 Thread Ferruh Yigit
On 11/9/2023 5:28 AM, Sivaprasad Tummala wrote: > Current get_tsc_freq_arch() implementation is specific for > Intel processors. > > Added vendor checks to gracefully return on AMD EPYC processors. > Hi Siva, Is this fixing an issue in AMD platform, if so can you please describe the impact of t

Re: [PATCH v7 14/21] dts: cpu docstring update

2023-11-22 Thread Juraj Linkeš
On Tue, Nov 21, 2023 at 6:45 PM Yoan Picchi wrote: > > On 11/15/23 13:09, Juraj Linkeš wrote: > > Format according to the Google format and PEP257, with slight > > deviations. > > > > Signed-off-by: Juraj Linkeš > > --- > > dts/framework/testbed_model/cpu.py | 196 +

Re: [PATCH v7 11/21] dts: remote session docstring update

2023-11-22 Thread Juraj Linkeš
On Tue, Nov 21, 2023 at 4:36 PM Yoan Picchi wrote: > > On 11/15/23 13:09, Juraj Linkeš wrote: > > Format according to the Google format and PEP257, with slight > > deviations. > > > > Signed-off-by: Juraj Linkeš > > --- > > dts/framework/remote_session/__init__.py | 39 +- > > .../re

[PATCH v8 4/4] app/dma-perf: add SG copy support

2023-11-22 Thread Gowrishankar Muthukrishnan
Add SG copy support. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph --- app/test-dma-perf/benchmark.c | 274 +- app/test-dma-perf/config.ini | 19 ++- app/test-dma-perf/main.c | 34 - app/test-dma-perf/main.h | 5 +- 4 files c

[PATCH v8 3/4] app/dma-perf: validate copied memory

2023-11-22 Thread Gowrishankar Muthukrishnan
Validate copied memory to ensure DMA copy did not fail. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph --- app/test-dma-perf/benchmark.c | 21 - app/test-dma-perf/main.c | 16 +++- app/test-dma-perf/main.h | 2 +- 3 files changed, 32

[PATCH v8 2/4] app/dma-perf: add PCI device support

2023-11-22 Thread Gowrishankar Muthukrishnan
From: Amit Prakash Shukla Add support to test performance for "device to memory" and "memory to device" data transfer. Signed-off-by: Amit Prakash Shukla Acked-by: Anoob Joseph --- app/test-dma-perf/benchmark.c | 108 +++--- app/test-dma-perf/config.ini | 37

[PATCH v8 1/4] app/dma-perf: add skip support

2023-11-22 Thread Gowrishankar Muthukrishnan
From: Amit Prakash Shukla Add support to skip running a dma-perf test-case. Signed-off-by: Amit Prakash Shukla Acked-by: Anoob Joseph Acked-by: Chengwen Feng --- v8: - abstracted csv file write error log --- app/test-dma-perf/config.ini | 2 ++ app/test-dma-perf/main.c | 48 +++

[PATCH v8 0/4] PCI Dev and SG copy support

2023-11-22 Thread Gowrishankar Muthukrishnan
Improve dma-perf application to support PCI dev and SG copy, along with additional supports below: - validate copied memory - skip tests if not opted. v8: - updated skip test patch. Amit Prakash Shukla (2): app/dma-perf: add skip support app/dma-perf: add PCI device support Gowrishankar M

Re: [PATCH 0/2] app/testpmd: support set RSS hash algorithm

2023-11-22 Thread Ferruh Yigit
On 11/22/2023 9:48 AM, Jie Hai wrote: > This patch set supports setting RSS hash algorithm. > > Jie Hai (2): > ethdev: add new API to get RSS hash algorithm by name > app/testpmd: support set RSS hash algorithm > Hi Jie, It is too late for the current release, can you please rebase it on v2

Re: [PATCH v7 10/21] dts: config docstring update

2023-11-22 Thread Juraj Linkeš
Thanks, Yoan, I'll make these changes in v8. On Tue, Nov 21, 2023 at 4:08 PM Yoan Picchi wrote: > > On 11/15/23 13:09, Juraj Linkeš wrote: > > Format according to the Google format and PEP257, with slight > > deviations. > > > > Signed-off-by: Juraj Linkeš > > --- > > dts/framework/config/__in

[PATCH v7 2/2] bus/pci: fix legacy device missing region info

2023-11-22 Thread Mingjin Ye
If the legacy device in the primary process does not support mapping the io port bar, the secondary process needs to proactively get the device information and fil the region information. Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel value") Signed-off-by: Mingjin Ye --- v7: M

[PATCH v7 1/2] vfio: add get device info API

2023-11-22 Thread Mingjin Ye
This patch adds an API to support getting device information. The driver can use the "rte_vfio_get_device_info" helper to get device information from EAL. Signed-off-by: Mingjin Ye --- lib/eal/include/rte_vfio.h | 29 + lib/eal/linux/eal_vfio.c | 27 +++

[PATCH v7 0/2] fix legacy device missing region info

2023-11-22 Thread Mingjin Ye
Fill in missing region information for legacy devices in secondary processes. And added rte_vfio_get_device_info API for EAL, which makes it easier and more generic to get device information through vfio driver. Mingjin Ye (2): vfio: add get device info API bus/pci: fix legacy device missing r

Re: RFC - GRO Flowlookup Optimisation

2023-11-22 Thread Ferruh Yigit
On 11/22/2023 6:01 AM, kumaraparameshwaran rathinavel wrote: > Hi Folks, > > The current GRO code uses an unoptimised version of flow lookup where > each flow in the table is iterated over during the flow matching > process. For a rte_gro_reassemble_burst in lightweight mode this would > not cause

  1   2   >