On Tue, Nov 21, 2023 at 5:25 PM Bruce Richardson <bruce.richard...@intel.com> wrote: > > Rather than requiring that any device advertising the > RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES flag support all of atomic, ordered > and parallel scheduling, we can redefine the field so that it basically > means that you don't need to specify the queue scheduling type at config > time. Instead all types of supported events can be sent to all queues. > > Suggested-by: Mattias Rönnblom <hof...@lysator.liu.se> > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > --- > lib/eventdev/rte_eventdev.h | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > index d48957362c..1c5043de26 100644 > --- a/lib/eventdev/rte_eventdev.h > +++ b/lib/eventdev/rte_eventdev.h > @@ -250,11 +250,20 @@ struct rte_event; > * @see rte_event_dequeue_burst() > */ > #define RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES (1ULL << 3) > -/**< Event device is capable of enqueuing events of any type to any queue. > +/**< Event device is capable of accepting enqueued events, of any type > + * advertised as supported by the device, to all destination queues. > + * > + * When this capability is set, the "schedule_type" field of the > + * rte_event_queue_conf structure is ignored when a queue is being > configured.
can we also add something like below or so to above line rte_event_queue_conf structure is ignored when a queue is being configured instead rte_event::sched_type shall be used. Also, git commit subject "eventdev: increase flexibility of all-types flag", This patch is just documentation clarification. Right? It was like this from day 1. I would suggest the subject as "eventdev: clarify all-types flag documentation" or so. With above changes, Acked-by: Jerin Jacob <jer...@marvell.com>
