RE: [PATCH v3 3/5] pcapng: modify timestamp calculation

2023-11-08 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 8 November 2023 19.36 ] pcapng: modify timestamp calculation > > The computation of timestamp is best done in the part of > pcapng library that is in secondary process. > The secondary process is already doing a bunch

RE: [PATCH v3 2/5] dumpcap: allow multiple invocations

2023-11-08 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 8 November 2023 19.36 > > If dumpcap is run twice with each instance pointing a different > interface, it would fail because of overlap in ring a pool names. > Fix by putting process id in the name. > > Fixes: cbb441

[Bug 1310] iavf : max_rtx_queues not true when network adaptor not support large vf

2023-11-08 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1310 Bug ID: 1310 Summary: iavf : max_rtx_queues not true when network adaptor not support large vf Product: DPDK Version: 22.11 Hardware: x86 OS: Linux Stat

RE: [PATCH v3 1/5] pdump: fix setting rte_errno on mp error

2023-11-08 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 8 November 2023 19.36 > > The response from MP server sets err_value to negative > on error. The convention for rte_errno is to use a positive > value on error. This makes errors like duplicate registration > show up

[PATCH] drivers: use stdatomic API

2023-11-08 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API. Signed-off-by: Tyler Retzlaff --- drivers/common/mlx5/linux/mlx5_nl.c | 5 +- drivers/common/mlx5/mlx5_common.h | 2 +- drivers/common/mlx5/mlx5_common_mr.c| 16 ++-

[PATCH] crypto/mlx5: fix crypto dev leak

2023-11-08 Thread Suanming Mou
For the case crypto initialize failed, the allocated crypto dev should be destroyed, otherwise the dev leaked. Current PMD returns directly instead of releasing the dev. This commit fixes the crypto dev leak when initialize failed. Fixes: a27f6a2e1f30 ("crypto/mlx5: split AES-XTS") Signed-off-by:

RE: [PATCH v3 ] dumpcap: fix mbuf pool ring type

2023-11-08 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 8 November 2023 18.48 > > The internal buffer pool used for copies of mbufs captured > needs to be thread safe. If capturing on multiple interfaces > or multiple queues, the same pool will be used (consumers). > And

[Bug 1007] ixgbe-bound x553 sibling interface broken after app crash

2023-11-08 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1007 dengkaiwen (kaiwenx.d...@intel.com) changed: What|Removed |Added Resolution|--- |INVALID CC|

[PATCH v4] net/iavf: fix mbuf release API selection

2023-11-08 Thread Kaiwen Deng
When AVX2 is forcibly selected and outer checksum offload is configured, the basic Tx path will be selected. Also, the txq mbuf release API is incorrectly set to iavf_tx_queue_release_mbufs_sse. This causes coredump. This commit selects release_txq_mbufs to releasing txq mbufs when selecting the b

[PATCH] eal/x86: add vendor ID checks for specific implementation

2023-11-08 Thread Sivaprasad Tummala
Current get_tsc_freq_arch() implementation is specific for Intel processors. Added vendor checks to gracefully return on AMD EPYC processors. Signed-off-by: Sivaprasad Tummala --- lib/eal/x86/rte_cycles.c | 16 1 file changed, 16 insertions(+) diff --git a/lib/eal/x86/rte_cycl

RE: [PATCH v3] net/iavf: fix mbuf release API selection

2023-11-08 Thread Deng, KaiwenX
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, November 8, 2023 8:03 PM > To: Zhang, Qi Z ; Deng, KaiwenX > ; dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; Wu, > Jingjing ; Xing, Beilei ; Zeng, > ZhichaoX > Subject: RE: [PATCH v3] net

RE: [PATCH v7] net/ice: fix crash on closing representor ports

2023-11-08 Thread Zhang, Qi Z
> -Original Message- > From: Ye, MingjinX > Sent: Wednesday, November 8, 2023 7:40 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Ye, MingjinX ; > sta...@dpdk.org; Zhang, Qi Z > Subject: [PATCH v7] net/ice: fix crash on closing representor ports > > The data resource in

Re: [21.11 PATCH v1] net/mlx5: fix matcher layout size calculation

2023-11-08 Thread Kevin Traynor
On 03/11/2023 03:07, Rongwei Liu wrote: Initially, the rdma-core library only supported misc0 to misc3 fields in matching resources, misc4 and misc5 fields were added to handle new features. The matcher layout, passing from DPDK to rdma-core, shouldn't exceed the size of the engaged library versi

Re: [PATCH 0/5] use rte atomic thread fence

2023-11-08 Thread Tyler Retzlaff
On Wed, Nov 08, 2023 at 06:04:47PM +0100, Thomas Monjalon wrote: > 02/11/2023 04:04, Tyler Retzlaff: > > Replace use of __atomic_thread_fence with __rte_atomic_thread_fence. > > > > It may be appropriate to use rte_atomic_thread_fence instead but it > > will be up to maintainers to evaluate and ma

Re: [PATCH v3 0/7] use abstracted bit count functions

2023-11-08 Thread Tyler Retzlaff
On Wed, Nov 08, 2023 at 05:57:01PM +0100, Thomas Monjalon wrote: > 08/11/2023 09:34, Morten Brørup: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Wednesday, 8 November 2023 00.38 > > > > > > The first set of conversions missed the long 'l' versions of the > > > built

[PATCH v3 5/5] test: cleanups to pcapng test

2023-11-08 Thread Stephen Hemminger
Overhaul of the pcapng test: - promote it to be a fast test so it gets regularly run. - create null device and use i. - use UDP discard packets that are valid so that for debugging the resulting pcapng file can be looked at with wireshark. - do basic checks on resulting pcap file that l

[PATCH v3 4/5] pcapng: avoid using alloca()

2023-11-08 Thread Stephen Hemminger
The function alloca() like VLA's has problems if the caller passes a large value. Instead use a fixed size buffer (4K) which will be more than sufficient for the info related blocks in the file. Add bounds checks as well. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 34

[PATCH v3 3/5] pcapng: modify timestamp calculation

2023-11-08 Thread Stephen Hemminger
The computation of timestamp is best done in the part of pcapng library that is in secondary process. The secondary process is already doing a bunch of system calls which makes it not performance sensitive. Simplify the computation of nanoseconds from TSC to a two step process which avoids numeric

[PATCH v3 2/5] dumpcap: allow multiple invocations

2023-11-08 Thread Stephen Hemminger
If dumpcap is run twice with each instance pointing a different interface, it would fail because of overlap in ring a pool names. Fix by putting process id in the name. Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Reported-by: Isaac Boukris Signed-off-by: Stephen Hemmin

[PATCH v3 1/5] pdump: fix setting rte_errno on mp error

2023-11-08 Thread Stephen Hemminger
The response from MP server sets err_value to negative on error. The convention for rte_errno is to use a positive value on error. This makes errors like duplicate registration show up with the correct error value. Fixes: 660098d61f57 ("pdump: use generic multi-process channel") Signed-off-by: Ste

[PATCH v3 0/5] dumpcap and pcapng fixes

2023-11-08 Thread Stephen Hemminger
This has bugfixes and tests for dumpcap and pcapng. It should be in 23.11 but seems to have been ignored. It fixes issues related to timestamping. The design choices are to maximize performance in the primary process; and do all the time adjustment in the secondary (dumpcap) since the dumpcap need

RE: RFC acceptable handling of VLAs across toolchains

2023-11-08 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 8 November 2023 17.52 > > On Tue, 7 Nov 2023 11:32:20 -0800 > Tyler Retzlaff wrote: > > > hi folks, > > > > i'm seeking advice. we have use of VLAs which are now optional in > > standard C. some toolchains provide a

[PATCH v3 ] dumpcap: fix mbuf pool ring type

2023-11-08 Thread Stephen Hemminger
The internal buffer pool used for copies of mbufs captured needs to be thread safe. If capturing on multiple interfaces or multiple queues, the same pool will be used (consumers). And if the capture ring gets full, the queues will need to put back the capture buffer which leads to multiple produce

RE: [PATCH] dumpcap: fix mbuf pool ring type

2023-11-08 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 8 November 2023 17.51 > > On Tue, 7 Nov 2023 18:38:32 +0100 > Morten Brørup wrote: > > > > If user decides to use a thread unsafe mempool, wouldn't it break > in > > > every PMD as well. > > > > Yes, except if the a

Re: [PATCH v2] ethdev: account for smaller MTU when setting default

2023-11-08 Thread Ferruh Yigit
On 11/8/2023 5:05 PM, Ajit Khaparde wrote: > On Wed, Nov 8, 2023 at 7:07 AM Andrew Rybchenko > wrote: >> >> On 11/8/23 09:05, Joshua Washington wrote: >>> Currently, if not specified in the user configuration, >>> rte_eth_dev_configure() sets the MTU of the device to RTE_EHTER_MTU. >>> This value

Re: [PATCH v6 06/23] dts: logger and settings docstring update

2023-11-08 Thread Yoan Picchi
On 11/8/23 12:53, Juraj Linkeš wrote: Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/logger.py | 72 +-- dts/framework/utils.py | 96 ++--- 2 files chang

Re: [PATCH v2] ethdev: account for smaller MTU when setting default

2023-11-08 Thread Ajit Khaparde
On Wed, Nov 8, 2023 at 7:07 AM Andrew Rybchenko wrote: > > On 11/8/23 09:05, Joshua Washington wrote: > > Currently, if not specified in the user configuration, > > rte_eth_dev_configure() sets the MTU of the device to RTE_EHTER_MTU. > > This value could potentially be larger than the MTU that the

Re: [PATCH 0/5] use rte atomic thread fence

2023-11-08 Thread Thomas Monjalon
02/11/2023 04:04, Tyler Retzlaff: > Replace use of __atomic_thread_fence with __rte_atomic_thread_fence. > > It may be appropriate to use rte_atomic_thread_fence instead but it > will be up to maintainers to evaluate and make the change if appropriate. I don't understand the use of __rte_atomic_t

Re: [PATCH v3 0/7] use abstracted bit count functions

2023-11-08 Thread Thomas Monjalon
08/11/2023 09:34, Morten Brørup: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Wednesday, 8 November 2023 00.38 > > > > The first set of conversions missed the long 'l' versions of the > > builtins that were being used. This series completes the conversion > > of remaini

Re: RFC acceptable handling of VLAs across toolchains

2023-11-08 Thread Stephen Hemminger
On Tue, 7 Nov 2023 11:32:20 -0800 Tyler Retzlaff wrote: > hi folks, > > i'm seeking advice. we have use of VLAs which are now optional in > standard C. some toolchains provide a conformant implementation and msvc > does not (and never will). > > we seem to have a few options, just curious about

Re: [PATCH] dumpcap: fix mbuf pool ring type

2023-11-08 Thread Stephen Hemminger
On Tue, 7 Nov 2023 18:38:32 +0100 Morten Brørup wrote: > > If user decides to use a thread unsafe mempool, wouldn't it break in > > every PMD as well. > > Yes, except if the application only uses one thread for packet processing. > Then thread safety is not necessary. > If application only

Re: [PATCH v1 1/1] dts: bind to DPDK driver before running test suites

2023-11-08 Thread Patrick Robb
On Wed, Nov 8, 2023 at 6:03 AM Juraj Linkeš wrote: > On Fri, Oct 27, 2023 at 12:03 AM wrote: > > > > From: Jeremy Spewock > > > > Modifies the current process so that we bind to os_driver_for_dpdk from > > the configuration file before running test suites and bind back to the > > os_driver afte

Re: [PATCH v1 1/1] dts: bind to DPDK driver before running test suites

2023-11-08 Thread Jeremy Spewock
On Wed, Nov 8, 2023 at 6:03 AM Juraj Linkeš wrote: > On Fri, Oct 27, 2023 at 12:03 AM wrote: > > > > From: Jeremy Spewock > > > > Modifies the current process so that we bind to os_driver_for_dpdk from > > the configuration file before running test suites and bind back to the > > os_driver afte

[PATCH] app/testpmd: fix indirect action list parameters parsing

2023-11-08 Thread Gregory Etelson
Indirect actions list arguments parser was configured to place target number into 64bit value, while the code provided 32bits memory. The patch updated variable size for translation results. Fixes: 72a3dec7126f ("ethdev: add indirect flow list action") Signed-off-by: Gregory Etelson --- app/tes

Re: [PATCH v6 05/23] dts: settings docstring update

2023-11-08 Thread Yoan Picchi
On 11/8/23 12:53, Juraj Linkeš wrote: Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/settings.py | 101 +- 1 file changed, 100 insertions(+), 1 deletion(-) diff --git a/dts/framework

Re: [PATCH v6 22/23] dts: add doc generation dependencies

2023-11-08 Thread Yoan Picchi
On 11/8/23 12:53, Juraj Linkeš wrote: Sphinx imports every Python module when generating documentation from docstrings, meaning all dts dependencies, including Python version, must be satisfied. By adding Sphinx to dts dependencies we make sure that the proper Python version and dependencies are

Re: [RFC] eal: RFC to refactor rte_eal_init into sub-functions

2023-11-08 Thread Thomas Monjalon
08/11/2023 12:51, Bruce Richardson: > On Thu, Nov 02, 2023 at 11:19:24AM -0700, Rahul Gupta wrote: > > From: Rahul Gupta > > > > Initialization often requires rte_eal_init + rte_pktmbuf_pool_create > > which can consume a total time of 500-600 ms: > > a) For many devices FLR may take a significan

Re: [RFC] eal: RFC to refactor rte_eal_init into sub-functions

2023-11-08 Thread Thomas Monjalon
08/11/2023 14:53, Dmitry Kozlyuk: > 2023-11-07 23:03 (UTC+0530), rahul gupta: > > > > From: Rahul Gupta > > > > To: dev@dpdk.org, tho...@monjalon.net > > > > Cc: sovar...@linux.microsoft.com, ok...@kernel.org, > > > sujithsan...@microsoft.com, sowmini.varad...@microsoft.com, > > > rahulrgupt..

Re: [EXT] Re: [PATCH v2 1/1] devtools: update sources in build tags script

2023-11-08 Thread Thomas Monjalon
08/11/2023 15:42, Srikanth Yalavarthi: > From: Thomas Monjalon > > 08/11/2023 10:28, Srikanth Yalavarthi: > > > As part of deprecating kmods meson option, 'kernel/linux' > > > directory is removed from the repository. > > > > > > This patch removes non-existing 'kernel/linux' directory from > > >

Re: [PATCH] eal/x86: fix segfaults in waitpkg power intrinsics

2023-11-08 Thread Thomas Monjalon
08/11/2023 04:19, Tyler Retzlaff: > On Tue, Nov 07, 2023 at 04:19:01PM +, Bruce Richardson wrote: > > From: David Hunt > > > > The code was recently enhanced to allow the use of the waitpkg > > intrinsics rather than the raw assembly in the rte_power functions. > > However, the parameters to

Re: [PATCH v2] ethdev: account for smaller MTU when setting default

2023-11-08 Thread Andrew Rybchenko
On 11/8/23 09:05, Joshua Washington wrote: Currently, if not specified in the user configuration, rte_eth_dev_configure() sets the MTU of the device to RTE_EHTER_MTU. This value could potentially be larger than the MTU that the device supports. This change updates the configured MTU to be the min

RE: [EXT] Re: [PATCH v2 1/1] devtools: update sources in build tags script

2023-11-08 Thread Srikanth Yalavarthi
> -Original Message- > From: Thomas Monjalon > Sent: 08 November 2023 16:54 > To: Srikanth Yalavarthi > Cc: Bruce Richardson ; David Marchand > ; Morten Brørup > ; Stephen Hemminger > ; dev@dpdk.org; Srikanth Yalavarthi > ; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran

Re: [RFC] eal: RFC to refactor rte_eal_init into sub-functions

2023-11-08 Thread Dmitry Kozlyuk
2023-11-07 23:03 (UTC+0530), rahul gupta: > > > From: Rahul Gupta > > > To: dev@dpdk.org, tho...@monjalon.net > > > Cc: sovar...@linux.microsoft.com, ok...@kernel.org, > > sujithsan...@microsoft.com, sowmini.varad...@microsoft.com, > > rahulrgupt...@gmail.com, Rahul Gupta , Rahul > > Gupta

Re: [PATCH] eal: fix msvc conditional compile of rte atomic thread fence

2023-11-08 Thread Thomas Monjalon
08/11/2023 09:27, Morten Brørup: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Tuesday, 7 November 2023 21.00 > > > > MSVC does not expose legacy atomics. When the legacy atomics were > > excluded rte_atomic_thread_fence was also unintentionally excluded > > > > Adjust

Re: [PATCH v5 01/23] dts: code adjustments for doc generation

2023-11-08 Thread Yoan Picchi
On 11/6/23 17:15, Juraj Linkeš wrote: The standard Python tool for generating API documentation, Sphinx, imports modules one-by-one when generating the documentation. This requires code changes: * properly guarding argument parsing in the if __name__ == '__main__' block, * the logger used by D

[PATCH v2] test/cryptodev: add ECDH tests

2023-11-08 Thread Gowrishankar Muthukrishnan
Add ECDH tests. Signed-off-by: Gowrishankar Muthukrishnan Change-Id: I88099e2ba8e058fbb519a06d09ebb3ece7c7e27f --- v2: - rebased due to patch conflict. --- app/test/test_cryptodev_asym.c | 741 app/test/test_cryptodev_asym_util.h | 12 + app/test/test_

RE: [PATCH] config/x86: config support for AMD EPYC processors

2023-11-08 Thread Morten Brørup
> From: Tummala, Sivaprasad [mailto:sivaprasad.tumm...@amd.com] > Sent: Wednesday, 8 November 2023 13.24 > > [AMD Official Use Only - General] > > Hi Konstantin, Morten, > > > From: Konstantin Ananyev > > Sent: Tuesday, November 7, 2023 8:03 PM > > > > > > > > I suppose for 23.11 we have not mu

[PATCH v6 23/23] dts: add doc generation

2023-11-08 Thread Juraj Linkeš
The tool used to generate developer docs is Sphinx, which is already used in DPDK. The same configuration is used to preserve style, but it's been augmented with doc-generating configuration and a change to how the sidebar displays the content hierarchy. Sphinx generates the documentation from Pyt

[PATCH v6 22/23] dts: add doc generation dependencies

2023-11-08 Thread Juraj Linkeš
Sphinx imports every Python module when generating documentation from docstrings, meaning all dts dependencies, including Python version, must be satisfied. By adding Sphinx to dts dependencies we make sure that the proper Python version and dependencies are used when Sphinx is executed. Signed-of

[PATCH v6 21/23] dts: test suites docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/tests/TestSuite_hello_world.py | 16 + dts/tests/TestSuite_os_udp.py | 16 + dts/tests/TestSuite_smoke_tests.py | 53 +++--- 3 files changed,

[PATCH v6 20/23] dts: scapy tg docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- .../testbed_model/traffic_generator/scapy.py | 91 +++ 1 file changed, 54 insertions(+), 37 deletions(-) diff --git a/dts/framework/testbed_model/traffic_generator/scapy.py

[PATCH v6 19/23] dts: base traffic generators docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- .../traffic_generator/__init__.py | 22 - .../capturing_traffic_generator.py| 46 +++ .../traffic_generator/traffic_generator.py| 33 +

[PATCH v6 18/23] dts: sut and tg nodes docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/sut_node.py | 219 dts/framework/testbed_model/tg_node.py | 42 +++-- 2 files changed, 170 insertions(+), 91 deletions(-) diff --git a

[PATCH v6 17/23] dts: node docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/node.py | 191 +++- 1 file changed, 131 insertions(+), 60 deletions(-) diff --git a/dts/framework/testbed_model/node.py b/dts/framework/

[PATCH v6 16/23] dts: posix and linux sessions docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/linux_session.py | 63 ++- dts/framework/testbed_model/posix_session.py | 81 +--- 2 files changed, 113 insertions(+), 31 deletions(-)

[PATCH v6 15/23] dts: os session docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/os_session.py | 275 -- 1 file changed, 208 insertions(+), 67 deletions(-) diff --git a/dts/framework/testbed_model/os_session.py b/dts/fram

[PATCH v6 14/23] dts: cpu docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/cpu.py | 196 + 1 file changed, 144 insertions(+), 52 deletions(-) diff --git a/dts/framework/testbed_model/cpu.py b/dts/framework/t

[PATCH v6 13/23] dts: port and virtual device docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/__init__.py | 16 -- dts/framework/testbed_model/port.py | 53 +++ dts/framework/testbed_model/virtual_device.py | 17 +-

[PATCH v6 12/23] dts: interactive remote session docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- .../interactive_remote_session.py | 36 +++ .../remote_session/interactive_shell.py | 99 +++ dts/framework/remote_session/python_shell.py | 26 -

[PATCH v6 11/23] dts: remote session docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/remote_session/__init__.py | 39 +- .../remote_session/remote_session.py | 128 +- dts/framework/remote_session/ssh_session.py | 16 +-- 3

[PATCH v6 10/23] dts: config docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/config/__init__.py | 371 ++- dts/framework/config/types.py| 132 +++ 2 files changed, 446 insertions(+), 57 deletions(-) create mode 1

[PATCH v6 09/23] dts: test result docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/test_result.py | 292 --- 1 file changed, 234 insertions(+), 58 deletions(-) diff --git a/dts/framework/test_result.py b/dts/framework/test_res

[PATCH v6 08/23] dts: test suite docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/test_suite.py | 223 +++- 1 file changed, 168 insertions(+), 55 deletions(-) diff --git a/dts/framework/test_suite.py b/dts/framework/test_suit

[PATCH v6 07/23] dts: dts runner and main docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/dts.py | 128 --- dts/main.py | 8 ++- 2 files changed, 112 insertions(+), 24 deletions(-) diff --git a/dts/framework/dts.py

[PATCH v6 06/23] dts: logger and settings docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/logger.py | 72 +-- dts/framework/utils.py | 96 ++--- 2 files changed, 121 insertions(+), 47 deletions(-) dif

[PATCH v6 05/23] dts: settings docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/settings.py | 101 +- 1 file changed, 100 insertions(+), 1 deletion(-) diff --git a/dts/framework/settings.py b/dts/framework/settings.py i

[PATCH v6 04/23] dts: exceptions docstring update

2023-11-08 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/__init__.py | 12 - dts/framework/exception.py | 106 + 2 files changed, 83 insertions(+), 35 deletions(-) diff --git a/dts/framework

[PATCH v6 03/23] dts: add basic developer docs

2023-11-08 Thread Juraj Linkeš
Expand the framework contribution guidelines and add how to document the code with Python docstrings. Signed-off-by: Juraj Linkeš --- doc/guides/tools/dts.rst | 73 1 file changed, 73 insertions(+) diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools

[PATCH v6 01/23] dts: code adjustments for doc generation

2023-11-08 Thread Juraj Linkeš
The standard Python tool for generating API documentation, Sphinx, imports modules one-by-one when generating the documentation. This requires code changes: * properly guarding argument parsing in the if __name__ == '__main__' block, * the logger used by DTS runner underwent the same treatment so

[PATCH v6 02/23] dts: add docstring checker

2023-11-08 Thread Juraj Linkeš
Python docstrings are the in-code way to document the code. The docstring checker of choice is pydocstyle which we're executing from Pylama, but the current latest versions are not complatible due to [0], so pin the pydocstyle version to the latest working version. [0] https://github.com/klen/pyla

RE: [PATCH] config/x86: config support for AMD EPYC processors

2023-11-08 Thread Tummala, Sivaprasad
[AMD Official Use Only - General] Hi Konstantin, Morten, > -Original Message- > From: Konstantin Ananyev > Sent: Tuesday, November 7, 2023 8:03 PM > To: Morten Brørup ; Thomas Monjalon > ; Kevin Traynor ; Tummala, > Sivaprasad ; David Marchand > ; Yigit, Ferruh ; > bruce.richard...@intel

RE: [PATCH v3] net/iavf: fix mbuf release API selection

2023-11-08 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, November 8, 2023 5:33 PM > To: Deng, KaiwenX ; dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; Wu, > Jingjing ; Xing, Beilei ; Zeng, > ZhichaoX > Subject: RE: [PATCH v3] net/iavf: fix mbuf

Re: [RFC] eal: RFC to refactor rte_eal_init into sub-functions

2023-11-08 Thread Bruce Richardson
On Thu, Nov 02, 2023 at 11:19:24AM -0700, Rahul Gupta wrote: > From: Rahul Gupta > > Initialization often requires rte_eal_init + rte_pktmbuf_pool_create > which can consume a total time of 500-600 ms: > a) For many devices FLR may take a significant chunk of time >(200-250 ms in our use-case

[PATCH v7] net/ice: fix crash on closing representor ports

2023-11-08 Thread Mingjin Ye
The data resource in struct rte_eth_dev is cleared and points to NULL when the DCF port is closed. If the DCF representor port is closed after the DCF port is closed, a segmentation fault occurs because the representor port accesses the data resource released by the DCF port. This patch fixes thi

Re: [PATCH v2 1/1] devtools: update sources in build tags script

2023-11-08 Thread Ferruh Yigit
On 11/8/2023 9:28 AM, Srikanth Yalavarthi wrote: > As part of deprecating kmods meson option, 'kernel/linux' > directory is removed from the repository. > > This patch removes non-existing 'kernel/linux' directory > from linux_sources of build tags script. > > Fixes: a52d472c5c94 ("build: depreca

Re: [RFC] eal: RFC to refactor rte_eal_init into sub-functions

2023-11-08 Thread rahul gupta
Hi Stephen, Thanks for your review. If I make it __rte_internal then, testpmd or our application can't use it. So instead I am planning to make it __rte_experimental. Regards, Rahul. On Fri, 3 Nov 2023 at 00:08, Stephen Hemminger wrote: > On Thu, 2 Nov 2023 11:19:24 -0700 > Rahul Gupta wrote

Re: [PATCH v2 1/1] devtools: update sources in build tags script

2023-11-08 Thread Thomas Monjalon
08/11/2023 10:28, Srikanth Yalavarthi: > As part of deprecating kmods meson option, 'kernel/linux' > directory is removed from the repository. > > This patch removes non-existing 'kernel/linux' directory > from linux_sources of build tags script. > > Fixes: a52d472c5c94 ("build: deprecate kmods m

Re: [PATCH v1 1/1] dts: bind to DPDK driver before running test suites

2023-11-08 Thread Juraj Linkeš
On Fri, Oct 27, 2023 at 12:03 AM wrote: > > From: Jeremy Spewock > > Modifies the current process so that we bind to os_driver_for_dpdk from > the configuration file before running test suites and bind back to the > os_driver afterwards. This allows test suites to assume that the ports > are boun

RE: [PATCH v3] net/iavf: fix mbuf release API selection

2023-11-08 Thread Zhang, Qi Z
> -Original Message- > From: Kaiwen Deng > Sent: Thursday, November 2, 2023 12:43 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; Wu, > Jingjing ; Xing, Beilei ; Zeng, > ZhichaoX > Subject: [PATCH v3] net/iavf: fix mbuf release API selectio

RE: [PATCH v2 1/1] devtools: update sources in build tags script

2023-11-08 Thread Morten Brørup
> From: Srikanth Yalavarthi [mailto:syalavar...@marvell.com] > Sent: Wednesday, 8 November 2023 10.28 > > As part of deprecating kmods meson option, 'kernel/linux' > directory is removed from the repository. > > This patch removes non-existing 'kernel/linux' directory > from linux_sources of buil

RE: [EXT] Re: [PATCH v1 1/1] devtools: update sources in build tags script

2023-11-08 Thread Srikanth Yalavarthi
> -Original Message- > From: Ferruh Yigit > Sent: 08 November 2023 14:19 > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; tho...@monjalon.net > Subject: [EXT] Re: [PATCH v1 1/1] devtools: update sources in build tags > scr

[PATCH v2 1/1] devtools: update sources in build tags script

2023-11-08 Thread Srikanth Yalavarthi
As part of deprecating kmods meson option, 'kernel/linux' directory is removed from the repository. This patch removes non-existing 'kernel/linux' directory from linux_sources of build tags script. Fixes: a52d472c5c94 ("build: deprecate kmods meson option") Signed-off-by: Srikanth Yalavarthi --

RE: [PATCH] net/cpfl: refactor flow parser

2023-11-08 Thread Zhang, Qi Z
> -Original Message- > From: wenjing.q...@intel.com > Sent: Tuesday, November 7, 2023 4:35 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Qiao, Wenjing > Subject: [PATCH] net/cpfl: refactor flow parser > > From: Wenjing Qiao > > Use strncpy instead of memcpy for string co

Re: [PATCH v5 03/23] dts: add basic developer docs

2023-11-08 Thread Juraj Linkeš
On Tue, Nov 7, 2023 at 3:40 PM Yoan Picchi wrote: > > On 11/6/23 17:15, Juraj Linkeš wrote: > > Expand the framework contribution guidelines and add how to document the > > code with Python docstrings. > > > > Signed-off-by: Juraj Linkeš > > --- > > doc/guides/tools/dts.rst | 73 +++

Re: [PATCH v1 1/1] devtools: update sources in build tags script

2023-11-08 Thread Ferruh Yigit
On 11/8/2023 4:44 AM, Srikanth Yalavarthi wrote: > As part of deprecating kmods meson option, 'kernel/linux' > directory is removed from the repository. > > This patch removes non-existing 'kernel/linux' directory > from linux_sources of build tags script. > > Signed-off-by: Srikanth Yalavarthi

CI test system not catching truncation bugs for 32-bit architectures?

2023-11-08 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 8 November 2023 00.38 > > Use rte_popcount64 instead of __builtin_popcountl where the argument > type passed to the intrinsic was 64-bits. Can someone please explain why our CI test system accepted passing a 64-bit v

RE: [PATCH v3 0/7] use abstracted bit count functions

2023-11-08 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 8 November 2023 00.38 > > The first set of conversions missed the long 'l' versions of the > builtins that were being used. This series completes the conversion > of remaining libraries from __builtin_ctzl, __builtin_c

RE: [PATCH] eal: fix msvc conditional compile of rte atomic thread fence

2023-11-08 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Tuesday, 7 November 2023 21.00 > > MSVC does not expose legacy atomics. When the legacy atomics were > excluded rte_atomic_thread_fence was also unintentionally excluded > > Adjust the conditional compilation check to expose > r

RE: [PATCH v2 0/5] use abstracted bit count functions

2023-11-08 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Tuesday, 7 November 2023 20.10 > > The first set of conversions missed the long 'l' versions of the > builtins that were being used. This series completes the conversion > of remaining libraries from __builtin_ctzl and __builtin_

RE: RFC acceptable handling of VLAs across toolchains

2023-11-08 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 8 November 2023 04.25 > > On Tue, Nov 07, 2023 at 06:31:14PM -0800, Stephen Hemminger wrote: > > On Tue, 7 Nov 2023 11:32:20 -0800 > > Tyler Retzlaff wrote: > > > > > hi folks, > > > > > > i'm seeking advice. we have

[Bug 1309] Broadcom NetXtreme E Series vNIC cards not initializing in DPDK 22.11 or above

2023-11-08 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1309 Bug ID: 1309 Summary: Broadcom NetXtreme E Series vNIC cards not initializing in DPDK 22.11 or above Product: DPDK Version: 22.11 Hardware: All OS: All