> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zh...@intel.com>
> Sent: Wednesday, November 8, 2023 8:03 PM
> To: Zhang, Qi Z <qi.z.zh...@intel.com>; Deng, KaiwenX
> <kaiwenx.d...@intel.com>; dev@dpdk.org
> Cc: sta...@dpdk.org; Yang, Qiming <qiming.y...@intel.com>; Zhou, YidingX
> <yidingx.z...@intel.com>; Deng, KaiwenX <kaiwenx.d...@intel.com>; Wu,
> Jingjing <jingjing...@intel.com>; Xing, Beilei <beilei.x...@intel.com>; Zeng,
> ZhichaoX <zhichaox.z...@intel.com>
> Subject: RE: [PATCH v3] net/iavf: fix mbuf release API selection
>
>
>
> > -----Original Message-----
> > From: Zhang, Qi Z <qi.z.zh...@intel.com>
> > Sent: Wednesday, November 8, 2023 5:33 PM
> > To: Deng, KaiwenX <kaiwenx.d...@intel.com>; dev@dpdk.org
> > Cc: sta...@dpdk.org; Yang, Qiming <qiming.y...@intel.com>; Zhou,
> > YidingX <yidingx.z...@intel.com>; Deng, KaiwenX
> > <kaiwenx.d...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; Xing,
> > Beilei <beilei.x...@intel.com>; Zeng, ZhichaoX
> > <zhichaox.z...@intel.com>
> > Subject: RE: [PATCH v3] net/iavf: fix mbuf release API selection
> >
> >
> >
> > > -----Original Message-----
> > > From: Kaiwen Deng <kaiwenx.d...@intel.com>
> > > Sent: Thursday, November 2, 2023 12:43 PM
> > > To: dev@dpdk.org
> > > Cc: sta...@dpdk.org; Yang, Qiming <qiming.y...@intel.com>; Zhou,
> > > YidingX <yidingx.z...@intel.com>; Deng, KaiwenX
> > > <kaiwenx.d...@intel.com>; Wu, Jingjing <jingjing...@intel.com>;
> > > Xing, Beilei <beilei.x...@intel.com>; Zeng, ZhichaoX
> > > <zhichaox.z...@intel.com>
> > > Subject: [PATCH v3] net/iavf: fix mbuf release API selection
> > >
> > > When AVX2 is forcibly selected and outer checksum offload is
> > > configured, the basic Tx path will be selected. Also, the txq mbuf
> > > release API is incorrectly set to iavf_tx_queue_release_mbufs_sse.
> > > This
> > causes coredump.
> > >
> > > This commit selects release_txq_mbufs to releasing txq mbufs when
> > > selecting the basic Tx path.
> > >
> > > Fixes: 22f1e7608ebc ("net/iavf: fix AVX2 Tx selection")
> > > Cc: sta...@dpdk.org
> > >
> > > Signed-off-by: Kaiwen Deng <kaiwenx.d...@intel.com>
> > > ---
> > > drivers/net/iavf/iavf_rxtx.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/net/iavf/iavf_rxtx.c
> > > b/drivers/net/iavf/iavf_rxtx.c index 610912f635..a16e03d88c 100644
> > > --- a/drivers/net/iavf/iavf_rxtx.c
> > > +++ b/drivers/net/iavf/iavf_rxtx.c
> > > @@ -4022,6 +4022,7 @@ iavf_set_tx_function(struct rte_eth_dev *dev)
> > > PMD_DRV_LOG(DEBUG,
> > > "AVX2 does not support outer
> > > checksum offload, using Basic Tx (port %d).",
> > > dev->data->port_id);
> > > + return;
> >
> > This make the execution routing not consistent between avx2 and avx512.
> > I think it will be a better solution if we reset the use_avx2 flag
> > here, and use this flag to decide if need to overwrite the release function
> later.
>
> Or you can just "goto normal" and removing function call assignment.
I will prepare a new patch.
Thanks.
>
> >
> > > } else {
> > > dev->tx_pkt_burst =
> > > iavf_xmit_pkts_vec_avx2_offload;
> > > dev->tx_pkt_prepare = iavf_prep_pkts;
> > > --
> > > 2.34.1
