> -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: 08 November 2023 16:54 > To: Srikanth Yalavarthi <syalavar...@marvell.com> > Cc: Bruce Richardson <bruce.richard...@intel.com>; David Marchand > <david.march...@redhat.com>; Morten Brørup > <m...@smartsharesystems.com>; Stephen Hemminger > <step...@networkplumber.org>; dev@dpdk.org; Srikanth Yalavarthi > <syalavar...@marvell.com>; Shivah Shankar Shankar Narayan Rao > <sshankarn...@marvell.com>; Jerin Jacob Kollanukkaran > <jer...@marvell.com> > Subject: [EXT] Re: [PATCH v2 1/1] devtools: update sources in build tags > script > > External Email > > ---------------------------------------------------------------------- > 08/11/2023 10:28, Srikanth Yalavarthi: > > As part of deprecating kmods meson option, 'kernel/linux' > > directory is removed from the repository. > > > > This patch removes non-existing 'kernel/linux' directory from > > linux_sources of build tags script. > > > > Fixes: a52d472c5c94 ("build: deprecate kmods meson option") > > If it is an old commit, you should probably add Cc: sta...@dpdk.org You can > check with devtools/check-git-log.sh
The fixes commit (a52d472c5c94) was merged after 23.11-rc0. check-git-log.sh script wasn't suggested to submit this to sta...@dpdk.log My understanding is that Cc:sta...@dpdk.org is need only if we need to backport the patch to older releases? > > > Signed-off-by: Srikanth Yalavarthi <syalavar...@marvell.com> > > You forgot the ack from Ferruh. > > Srikanth, you are sending a lot of patches, which is good :) but we will ask > you > to make an effort on getting all details. > You may read again the contributor's guide again. Thanks. Apologies, Missed including Ack. Will take care of this. >