[PATCH] maintainers: volunteer to maintain security library

2023-11-06 Thread Anoob Joseph
Add co-maintainer for security library. Signed-off-by: Anoob Joseph --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4083658697..bf86bebf5c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -454,6 +454,7 @@ F: examples/l2fwd-crypto/ Security API

RE: [PATCH] dumpcap: fix mbuf pool ring type

2023-11-06 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, 7 November 2023 03.36 > > On Mon, 6 Nov 2023 22:50:50 +0100 > Morten Brørup wrote: > > > > > And I guess there might be other use cases than this one, where a > > > thread-safe mempool driver is required. So adding a

Re: [PATCH v5 2/5] net/sfc: use new API to parse kvargs

2023-11-06 Thread Andrew Rybchenko
On 11/6/23 15:29, fengchengwen wrote: Hi Andrew, On 2023/11/6 18:28, Andrew Rybchenko wrote: On 11/6/23 10:31, Chengwen Feng wrote: The sfc_kvargs_process() and sfc_efx_dev_class_get() function could handle both key=value and only-key, so they should use rte_kvargs_process_opt() instead of rte

Re: [PATCH v1 1/1] ml/cnxk: fix updating internal I/O info

2023-11-06 Thread Jerin Jacob
On Mon, Nov 6, 2023 at 8:43 PM Shivah Shankar Shankar Narayan Rao wrote: > > > -Original Message- > > From: Srikanth Yalavarthi > > Sent: Sunday, October 29, 2023 6:55 PM > > To: Srikanth Yalavarthi > > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > > ; Anup Prabhu ; > > Prince T

RE: [PATCH] bus/vdev: fix devargs memory leak

2023-11-06 Thread Ye, MingjinX
Hi Anatoly, can you please take a look at this patch. Thanks, Mingjin > -Original Message- > From: Ye, MingjinX > Sent: Friday, September 15, 2023 4:56 PM > To: Burakov, Anatoly ; dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; sta...@dpdk.org; Ling, WeiX > > Subject: RE: [PATCH] b

RE: [PATCH] net/mlx5: fix null derefrence in mlx5 txq start

2023-11-06 Thread Slava Ovsiienko
Hi, Weiguo Do we have some compiler's or linter's warning about the "dereference" ? Actually it is not an issue, once we get txq_data pointer - the NULL is just added with some offset, and there is pre-check before using the pointer. And, please fix the typo in title - "derefErence". With best

Re: [PATCH v1] common/cnxk: fix aged flows bitmap alloc

2023-11-06 Thread Jerin Jacob
On Fri, Nov 3, 2023 at 4:55 AM Ankur Dwivedi wrote: > > The allocation of bitmap for aged flows should be done in > npc_aging_ctrl_thread_create() instead of roc_npc_init(), as the bitmap > free is being done in npc_aging_ctrl_thread_destroy(). > > Fixes: 357f5ebc8a24 ("common/cnxk: support flow a

RE: [PATCH] net/mlx5: fix the unlock mismatch issue

2023-11-06 Thread Slava Ovsiienko
Hi, Weiguo Good catch, thank you. With best regards, Slava > -Original Message- > From: Weiguo Li > Sent: Saturday, November 4, 2023 6:08 AM > To: Alexander Kozyrev > Cc: Slava Ovsiienko ; dev@dpdk.org; > sta...@dpdk.org; Weiguo Li > Subject: [PATCH] net/mlx5: fix the unlock mismatch

[dpdk-dev] [PATCH] common/cnxk: fix setting channel mask for SDP interfaces

2023-11-06 Thread psatheesh
From: Satheesh Paul Channel mask field is incorrectly returned as 16 bits. Fixing it by truncating to 12 bits. Fixes: 2703f1fa3200 ("common/cnxk: fix setting channel mask for SDP interfaces") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul --- drivers/common/cnxk/roc_npc.c | 5 +++-- drive

[PATCH v3 2/2] app/testpmd: fix UDP cksum error for UFO enable

2023-11-06 Thread Huisong Li
The command "tso set " is used to enable UFO, please see commit ce8e6e742807 ("app/testpmd: support UFO in checksum engine") The above patch sets the RTE_MBUF_F_TX_UDP_SEG in mbuf ol_flags, only by checking if 'tso_segsz' is set, but missing check if UFO offload (RTE_ETH_TX_OFFLOAD_UDP_TSO) suppo

[PATCH v3 1/2] app/testpmd: remove useless code for TSO setting command

2023-11-06 Thread Huisong Li
Testpmd has added the check of TSO offload capability of port, please see the commit 3926dd2b6668 ("app/testpmd: enforce offload capabilities check") So the code following the check code memtioned above to display warning when port doesn't support TSO offload doesn't access to forever. Fixes: 392

[PATCH v3 0/2] app/testpmd: fix UDP cksum error for UFO enable

2023-11-06 Thread Huisong Li
1. remove useless code. 2. fix UDP cksum error for UFO enable. For detail message, please see the commit log. --- v3: - separate the useless code from patch v2. - fix some comments and use 'printf' to replace 'fprintf'. v2: add handle for tunnel TSO offload in process_inner_cksums Huisong

[PATCH v2] config/arm: correct cpu arch for cross build

2023-11-06 Thread Joyce Kong
The cn10k cross build file sets cpu to 'armv8.6-a' while it is armv8.5-a arch. The cpu field in the cross file doesn't take effect as config/arm/meson.build controls machine_args for march. Then correct the value in arm cross files to 'auto'. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang -

Re: [PATCH v4 1/5] kvargs: add one new process API

2023-11-06 Thread fengchengwen
Hi Stephen, On 2023/11/7 0:19, Stephen Hemminger wrote: > On Mon, 6 Nov 2023 15:13:35 +0800 > fengchengwen wrote: > + >>> >>> Looks good but may I suggest some alternatives. >>> >>> Since this is an API and ABI change as was not announced, maybe a little >>> late >>> in the process for t

RE: [PATCH v1] config/arm: correct cpu arch for cross build

2023-11-06 Thread Joyce Kong
> -Original Message- > From: Thomas Monjalon > Sent: Monday, November 6, 2023 11:38 PM > To: Ruifeng Wang > Cc: dev@dpdk.org; Bruce Richardson ; nd > ; Paul Szczepanek ; Joyce Kong > > Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build > > 06/11/2023 15:31, Joyce Kong:

Re: [PATCH] dumpcap: fix mbuf pool ring type

2023-11-06 Thread Stephen Hemminger
On Mon, 6 Nov 2023 22:50:50 +0100 Morten Brørup wrote: > > > And I guess there might be other use cases than this one, where a > > thread-safe mempool driver is required. So adding a generalized > > function to get the "upgraded" (i.e. thread safe) variant of a mempool > > driver would be nice.

RE: [PATCH 00/11] Add basic flow support for corenic firmware

2023-11-06 Thread Chaoyong He
> On 11/3/2023 6:25 AM, Chaoyong He wrote: > > Add the very basic rte_flow support for corenic firmware. > > > > Chaoyong He (11): > > net/nfp: move some source files > > drivers: add the structures and functions for flow offload > > net/nfp: add the control message channel > > net/nfp: sup

Re: [PATCH v4] dmadev: add tracepoints

2023-11-06 Thread fengchengwen
Hi Thomas, On 2023/11/7 4:59, Thomas Monjalon wrote: > 11/10/2023 11:55, fengchengwen: >> Hi Thomas, >> >> Sorry for the late reply. >> >> On 2023/8/14 22:16, Thomas Monjalon wrote: >>> jeudi 3 août 2023, fengchengwen: Hi Thomas, On 2023/7/31 20:48, Thomas Monjalon wrote: > 10

RE: [PATCH] net/cpfl: fix coverity issues

2023-11-06 Thread Zhang, Qi Z
> -Original Message- > From: Qiao, Wenjing > Sent: Monday, November 6, 2023 6:00 PM > To: Wu, Jingjing ; Xing, Beilei > ; > Zhang, Qi Z > Cc: dev@dpdk.org; Zhang, Yuying ; Qiao, Wenjing > > Subject: [PATCH] net/cpfl: fix coverity issues > > From: Wenjing Qiao > > Fix integer handl

Re: [PATCH 2/2] test/crypto: add negative test cases for cipher buffer alignment

2023-11-06 Thread Ji, Kai
Acked-by: Kai Ji From: Sivaramakrishnan Venkat Sent: 03 November 2023 13:30 To: Akhil Goyal ; Fan Zhang Cc: dev@dpdk.org ; sta...@dpdk.org ; Sivaramakrishnan, VenkatX Subject: [PATCH 2/2] test/crypto: add negative test cases for cipher buffer alignment add n

Re: [PATCH 1/2] crypto/qat: fix block cipher misalignment for AES CBC and 3DES CBC

2023-11-06 Thread Ji, Kai
Acked-by: Kai Ji From: Sivaramakrishnan, VenkatX Sent: 03 November 2023 13:30 To: Ji, Kai Cc: dev@dpdk.org ; sta...@dpdk.org ; gak...@marvell.com ; Sivaramakrishnan, VenkatX Subject: [PATCH 1/2] crypto/qat: fix block cipher misalignment for AES CBC and 3DES

Re: [PATCH] crypto/openssl: fix asym memory leaks

2023-11-06 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> From: Power, Ciara Sent: 03 November 2023 15:45 To: dev@dpdk.org Cc: Power, Ciara ; Ji, Kai ; gmuthukri...@marvell.com ; sunila.s...@caviumnetworks.com ; sta...@dpdk.org Subject: [PATCH] crypto/openssl: fix asym memo

release candidate 23.11-rc2

2023-11-06 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v23.11-rc2 There are 320 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_23_11.html Highlights of 23.11-rc2: - RSS algorithm management

RE: [PATCH] config/x86: config support for AMD EPYC processors

2023-11-06 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, 6 November 2023 22.05 > > 17/10/2023 12:27, Morten Brørup: > > > >> From: Tummala, Sivaprasad > > > >>> From: David Marchand > > > >>> On Mon, Sep 25, 2023 at 5:11 PM Sivaprasad Tummala > > > From: Sivaprasad Tummala > >

RE: [PATCH] dumpcap: fix mbuf pool ring type

2023-11-06 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, 6 November 2023 20.24 > > On Mon, 2 Oct 2023 10:42:53 +0200 > Morten Brørup wrote: > > > > Switching to rte_pktmbuf_pool_create() still leaves the user with > the > > > possibility to shoot himself in the foot (I was t

Re: [PATCH v2] maintainers: update email address

2023-11-06 Thread Thomas Monjalon
23/10/2023 07:13, Chenbo Xia: > I left Intel and joined Nvidia, so update my email address. > > Signed-off-by: Chenbo Xia > Acked-by: Maxime Coquelin Applied, thanks.

RE: Updating examples which use coremask parameters

2023-11-06 Thread Konstantin Ananyev
> > > > > > looking to start a discussion and get some input here. > > > > > > There are a number of our examples in DPDK which still track core usage > > > via > > > a 64-bit bitmask, and, as such, cannot run on cores between 64 and > > > RTE_MAX_LCORE. Two examples I have recently come across

Re: [PATCH] maintainers: update ena maintainers list

2023-11-06 Thread Thomas Monjalon
> > From: Shai Brandes > > > > Removed obsolete maintainers and added the ena team members. > > > > Signed-off-by: Shai Brandes > > --- > > Amazon ENA > > -M: Michal Krawczyk > > M: Shai Brandes > > M: Evgeny Schemeilin > > -M: Igor Chauskin > > M: Ron Beider > > +M: Amit Bernstein >

Re: [PATCH] maintainers: volunteer to maintain power library

2023-11-06 Thread Thomas Monjalon
23/10/2023 12:17, Ferruh Yigit: > On 10/23/2023 10:48 AM, Hunt, David wrote: > > On 23/10/2023 05:27, Sivaprasad Tummala wrote: > >> Add co-maintainer for power library. > >> > >> Signed-off-by: Sivaprasad Tummala > >> > > Thanks for the help, Sivaprasad. > > > > Acked-by: David Hunt > > Acked-

Re: [PATCH] maintainers: update for mempool library

2023-11-06 Thread Thomas Monjalon
01/11/2023 17:48, Andrew Rybchenko: > > On November 1, 2023 19:20:29 Morten Brørup wrote: > > > Add co-maintainer for Memory pool. > > > > Suggested-by: Thomas Monjalon > > Signed-off-by: Morten Brørup > > Acked-by: Andrew Rybchenko Applied, thanks Morten for helping.

Re: [PATCH] config/x86: config support for AMD EPYC processors

2023-11-06 Thread Thomas Monjalon
17/10/2023 12:27, Morten Brørup: > > >> From: Tummala, Sivaprasad > > >>> From: David Marchand > > >>> On Mon, Sep 25, 2023 at 5:11 PM Sivaprasad Tummala > > From: Sivaprasad Tummala > > > > By default, max lcores are limited to 128 for x86 platforms. > > On AMD EPYC processo

Re: [PATCH v4] dmadev: add tracepoints

2023-11-06 Thread Thomas Monjalon
11/10/2023 11:55, fengchengwen: > Hi Thomas, > > Sorry for the late reply. > > On 2023/8/14 22:16, Thomas Monjalon wrote: > > jeudi 3 août 2023, fengchengwen: > >> Hi Thomas, > >> > >> On 2023/7/31 20:48, Thomas Monjalon wrote: > >>> 10/07/2023 09:50, fengchengwen: > Hi Thomas, > > >>

Re: [PATCH] dmadev: add tracepoints at control path APIs

2023-11-06 Thread Thomas Monjalon
20/10/2023 04:21, Chengwen Feng: > Add tracepoints at control path APIs for tracing support. > > Note: Fast path APIs don't support tracepoints because the APIs contains > struct and enum, if adding tracepints will lead to chkincs failure. > > Signed-off-by: Chengwen Feng > Acked-by: Morten Brør

[PATCH v2] dumpcap: fix mbuf pool ring type

2023-11-06 Thread Stephen Hemminger
The internal buffer pool used for copies of mbufs captured needs to be thread safe. If capturing on multiple interfaces or multiple queues, the same pool will be used (consumers). And if the capture ring gets full, the queues will need to put back the capture buffer which leads to multiple produce

Re: [PATCH] dumpcap: fix mbuf pool ring type

2023-11-06 Thread Stephen Hemminger
On Mon, 2 Oct 2023 09:33:50 +0200 David Marchand wrote: > Switching to rte_pktmbuf_pool_create() still leaves the user with the > possibility to shoot himself in the foot (I was thinking of setting > some --mbuf-pool-ops-name EAL option). > > This application has explicit requirements in terms o

Re: [PATCH] dumpcap: fix mbuf pool ring type

2023-11-06 Thread Stephen Hemminger
On Mon, 2 Oct 2023 10:42:53 +0200 Morten Brørup wrote: > > Switching to rte_pktmbuf_pool_create() still leaves the user with the > > possibility to shoot himself in the foot (I was thinking of setting > > some --mbuf-pool-ops-name EAL option). > > > > This application has explicit requirements i

Re: Updating examples which use coremask parameters

2023-11-06 Thread Stephen Hemminger
On Thu, 2 Nov 2023 16:58:52 + Bruce Richardson wrote: > On Thu, Nov 02, 2023 at 05:28:42PM +0100, Thomas Monjalon wrote: > > 02/11/2023 15:56, Bruce Richardson: > > > Hi all, > > > > > > looking to start a discussion and get some input here. > > > > > > There are a number of our examples

RE: [PATCH v7 1/2] bus/pci: support PASID control

2023-11-06 Thread Sevincer, Abdullah
>+I don't see much point in providing a wrapper that does nothing more than >call rte_pci_write_config() and let the driver pass the right offsets. >+If anything, can't this wrapper find out about the pasid offset itself? >+There is a extended capability for this, so I would expect it can be use

Re: [PATCH v7 1/2] bus/pci: support PASID control

2023-11-06 Thread David Marchand
On Mon, Nov 6, 2023 at 6:05 PM Abdullah Sevincer wrote: > > Add an internal API to control PASID for a given PCIe device. > > For kernels when PASID enabled by default it breaks DLB functionality, > hence disabling PASID is required for DLB to function properly. > > PASID capability is not exposed

Re: [PATCH v5 1/1] build: add libarchive to external deps

2023-11-06 Thread David Marchand
On Mon, Nov 6, 2023 at 5:24 PM Bruce Richardson wrote: > > On Mon, Nov 06, 2023 at 05:03:10PM +0100, David Marchand wrote: > > On Mon, Nov 6, 2023 at 5:12 AM Srikanth Yalavarthi > > wrote: > > > > > > In order to avoid linking with Libs.private, libarchive is not added to > > > ext_deps during th

Re: [PATCH v7 0/2] *** Disable PASID for DLB Device ***

2023-11-06 Thread Thomas Monjalon
06/11/2023 18:05, Abdullah Sevincer: > This series implement an internal API to disable > PASID and calls the api to disable PASID in event/dlb2 device. > > Abdullah Sevincer (2): > bus/pci: support PASID control > event/dlb2: fix disable PASID Moved things in the right place/order and added

Re: [PATCH] eal: provide trace point register macro for MSVC

2023-11-06 Thread Tyler Retzlaff
On Mon, Nov 06, 2023 at 05:40:12PM +0100, Thomas Monjalon wrote: > 01/11/2023 23:47, Tyler Retzlaff: > > Provide an alternate RTE_TRACE_POINT_REGISTER macro when building with > > MSVC that allocates segments for the trace point using MSVC specific > > features > > Please could you elaborate what

[PATCH v5 23/23] dts: add doc generation

2023-11-06 Thread Juraj Linkeš
The tool used to generate developer docs is Sphinx, which is already used in DPDK. The same configuration is used to preserve style, but it's been augmented with doc-generating configuration and a change to how the sidebar displays the content hierarchy. Sphinx generates the documentation from Pyt

[PATCH v5 22/23] dts: add doc generation dependencies

2023-11-06 Thread Juraj Linkeš
Sphinx imports every Python module when generating documentation from docstrings, meaning all dts dependencies, including Python version, must be satisfied. By adding Sphinx to dts dependencies we make sure that the proper Python version and dependencies are used when Sphinx is executed. Signed-of

[PATCH v5 21/23] dts: test suites docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/tests/TestSuite_hello_world.py | 16 + dts/tests/TestSuite_os_udp.py | 16 + dts/tests/TestSuite_smoke_tests.py | 53 +++--- 3 files changed,

[PATCH v5 20/23] dts: scapy tg docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- .../testbed_model/traffic_generator/scapy.py | 91 +++ 1 file changed, 54 insertions(+), 37 deletions(-) diff --git a/dts/framework/testbed_model/traffic_generator/scapy.py

[PATCH v5 19/23] dts: base traffic generators docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- .../traffic_generator/__init__.py | 22 - .../capturing_traffic_generator.py| 46 +++ .../traffic_generator/traffic_generator.py| 33 +

[PATCH v5 18/23] dts: sut and tg nodes docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/sut_node.py | 219 dts/framework/testbed_model/tg_node.py | 42 +++-- 2 files changed, 170 insertions(+), 91 deletions(-) diff --git a

[PATCH v5 17/23] dts: node docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/node.py | 191 +++- 1 file changed, 131 insertions(+), 60 deletions(-) diff --git a/dts/framework/testbed_model/node.py b/dts/framework/

[PATCH v5 16/23] dts: posix and linux sessions docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/linux_session.py | 63 ++- dts/framework/testbed_model/posix_session.py | 81 +--- 2 files changed, 113 insertions(+), 31 deletions(-)

[PATCH v5 15/23] dts: os session docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/os_session.py | 275 -- 1 file changed, 208 insertions(+), 67 deletions(-) diff --git a/dts/framework/testbed_model/os_session.py b/dts/fram

[PATCH v5 14/23] dts: cpu docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/cpu.py | 196 + 1 file changed, 144 insertions(+), 52 deletions(-) diff --git a/dts/framework/testbed_model/cpu.py b/dts/framework/t

[PATCH v5 13/23] dts: port and virtual device docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/__init__.py | 16 -- dts/framework/testbed_model/port.py | 53 +++ dts/framework/testbed_model/virtual_device.py | 17 +-

[PATCH v5 12/23] dts: interactive remote session docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- .../interactive_remote_session.py | 36 +++ .../remote_session/interactive_shell.py | 99 +++ dts/framework/remote_session/python_shell.py | 26 -

[PATCH v5 11/23] dts: remote session docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/remote_session/__init__.py | 39 +- .../remote_session/remote_session.py | 128 +- dts/framework/remote_session/ssh_session.py | 16 +-- 3

[PATCH v5 10/23] dts: config docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/config/__init__.py | 371 ++- dts/framework/config/types.py| 132 +++ 2 files changed, 446 insertions(+), 57 deletions(-) create mode 1

[PATCH v5 09/23] dts: test result docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/test_result.py | 292 --- 1 file changed, 234 insertions(+), 58 deletions(-) diff --git a/dts/framework/test_result.py b/dts/framework/test_res

[PATCH v5 06/23] dts: logger and settings docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/logger.py | 72 +-- dts/framework/utils.py | 96 ++--- 2 files changed, 121 insertions(+), 47 deletions(-) dif

[PATCH v5 08/23] dts: test suite docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/test_suite.py | 223 +++- 1 file changed, 168 insertions(+), 55 deletions(-) diff --git a/dts/framework/test_suite.py b/dts/framework/test_suit

[PATCH v5 07/23] dts: dts runner and main docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/dts.py | 128 --- dts/main.py | 8 ++- 2 files changed, 112 insertions(+), 24 deletions(-) diff --git a/dts/framework/dts.py

[PATCH v5 05/23] dts: settings docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/settings.py | 101 +- 1 file changed, 100 insertions(+), 1 deletion(-) diff --git a/dts/framework/settings.py b/dts/framework/settings.py i

[PATCH v5 04/23] dts: exceptions docstring update

2023-11-06 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/__init__.py | 12 - dts/framework/exception.py | 106 + 2 files changed, 83 insertions(+), 35 deletions(-) diff --git a/dts/framework

[PATCH v5 03/23] dts: add basic developer docs

2023-11-06 Thread Juraj Linkeš
Expand the framework contribution guidelines and add how to document the code with Python docstrings. Signed-off-by: Juraj Linkeš --- doc/guides/tools/dts.rst | 73 1 file changed, 73 insertions(+) diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools

[PATCH v5 02/23] dts: add docstring checker

2023-11-06 Thread Juraj Linkeš
Python docstrings are the in-code way to document the code. The docstring checker of choice is pydocstyle which we're executing from Pylama, but the current latest versions are not complatible due to [0], so pin the pydocstyle version to the latest working version. [0] https://github.com/klen/pyla

[PATCH v5 01/23] dts: code adjustments for doc generation

2023-11-06 Thread Juraj Linkeš
The standard Python tool for generating API documentation, Sphinx, imports modules one-by-one when generating the documentation. This requires code changes: * properly guarding argument parsing in the if __name__ == '__main__' block, * the logger used by DTS runner underwent the same treatment so

[PATCH v5 00/23] dts: add dts api docs

2023-11-06 Thread Juraj Linkeš
The commits can be split into groups. The first commit makes changes to the code. These code changes mainly change the structure of the code so that the actual API docs generation works. There are also some code changes which get reflected in the documentation, such as making functions/methods/att

[PATCH v7 2/2] event/dlb2: fix disable PASID

2023-11-06 Thread Abdullah Sevincer
In vfio-pci driver when PASID is enabled by default DLB hardware puts DLB in SIOV mode. This breaks DLB PF-PMD mode. For DLB PF-PMD mode to function properly PASID needs to be disabled. In this commit this issue is addressed and PASID is disabled by writing a zero to PASID control register. Fixes

[PATCH v7 1/2] bus/pci: support PASID control

2023-11-06 Thread Abdullah Sevincer
Add an internal API to control PASID for a given PCIe device. For kernels when PASID enabled by default it breaks DLB functionality, hence disabling PASID is required for DLB to function properly. PASID capability is not exposed to users hence offset can not be retrieved by rte_pci_find_ext_capab

[PATCH v7 0/2] *** Disable PASID for DLB Device ***

2023-11-06 Thread Abdullah Sevincer
This series implement an internal API to disable PASID and calls the api to disable PASID in event/dlb2 device. Abdullah Sevincer (2): bus/pci: support PASID control event/dlb2: fix disable PASID drivers/bus/pci/pci_common.c | 7 +++ drivers/bus/pci/rte_bus_pci.h | 13

Re: [PATCH v2 1/2] bus/cdx: add support for devices without MSI

2023-11-06 Thread Gupta, Nipun
On 11/3/2023 4:50 PM, Shubham Rohila wrote: From: Nikhil Agarwal Update the cleanup routine for cdx device to support device without MSI. Also, set vfio_dev_fd for such devices This fd can be used for BME reload operations. Signed-off-by: Nikhil Agarwal Signed-off-by: Shubham Rohila ---

Re: [PATCH] eal: stop iteration after lcore info is processed

2023-11-06 Thread Thomas Monjalon
> > Telemetry iterates on lcore ID to collect info of a specific lcore. > > Since only one lcore is processed at a time, the iteration can stop > > when a matching lcore is found. > > > > Fixes: f2b852d909f9 ("eal: add lcore info in telemetry") > > Cc: rja...@redhat.com > > Cc: sta...@dpdk.org > >

Re: [PATCH] eal: add missing extension to statement expression

2023-11-06 Thread Thomas Monjalon
01/11/2023 23:07, Tyler Retzlaff: > add missing __extension__ keyword to RTE_ALIGN_MUL_NEAR statement > expression to be consistent with other macros using statement > expressions > > Signed-off-by: Tyler Retzlaff Applied, thanks.

Re: [PATCH] eal: provide trace point register macro for MSVC

2023-11-06 Thread Thomas Monjalon
01/11/2023 23:47, Tyler Retzlaff: > Provide an alternate RTE_TRACE_POINT_REGISTER macro when building with > MSVC that allocates segments for the trace point using MSVC specific > features Please could you elaborate what is the improvement? > +#define RTE_TRACE_POINT_REGISTER(trace, name) \ > +rt

Re: [PATCH v3] eal: support lcore usage ratio

2023-11-06 Thread Thomas Monjalon
23/10/2023 14:51, Chengwen Feng: > Current, the lcore usage only display two key fields: busy_cycles and > total_cycles, which is inconvenient to obtain the usage ratio > immediately. So adds lcore usage ratio field. > > Signed-off-by: Chengwen Feng > Acked-by: Morten Brørup Acked-by: Huisong Li

Re: rte_timer_reset related issues in DPDK 20.05

2023-11-06 Thread Stephen Hemminger
On Mon, 6 Nov 2023 10:31:20 + Nagma Meraj wrote: > TCS Confidential > > Hi, > > We are working on Front Haul Library which is using DPDK internally for data > accleration. > In that we are facing the following issues: > 1.In Front Haul Library, one of the threads xran_timing_source_thread(

Re: [PATCH v5 1/1] build: add libarchive to external deps

2023-11-06 Thread Bruce Richardson
On Mon, Nov 06, 2023 at 05:03:10PM +0100, David Marchand wrote: > On Mon, Nov 6, 2023 at 5:12 AM Srikanth Yalavarthi > wrote: > > > > In order to avoid linking with Libs.private, libarchive is not added to > > ext_deps during the meson setup stage. > > > > Since libarchive is not added to ext_deps

Re: [PATCH v4 1/5] kvargs: add one new process API

2023-11-06 Thread Stephen Hemminger
On Mon, 6 Nov 2023 15:13:35 +0800 fengchengwen wrote: > >> + > > > > Looks good but may I suggest some alternatives. > > > > Since this is an API and ABI change as was not announced, maybe a little > > late > > in the process for this release. And since unlikely to go in 23.11 need to > > d

Re: [PATCH v5 1/1] build: add libarchive to external deps

2023-11-06 Thread David Marchand
On Mon, Nov 6, 2023 at 5:12 AM Srikanth Yalavarthi wrote: > > In order to avoid linking with Libs.private, libarchive > is not added to ext_deps during the meson setup stage. > > Since libarchive is not added to ext_deps, cross-compilation > or native compilation with libarchive installed in non-s

Re: [PATCH] remove unnecessary null check before free/rte_free

2023-11-06 Thread Thomas Monjalon
25/10/2023 00:58, Stephen Hemminger: > This is the latest round of places that are checking for NULL > pointer before calling free or rte_free. It is result of applying > the nullfree.cocci script. > > Signed-off-by: Stephen Hemminger Applied and re-run with more fixes in new ml/cnxk code, thank

RE: [PATCH v6 1/2] bus/pci: add function to enable/disable PASID

2023-11-06 Thread Sevincer, Abdullah
>+Is PASID now part of PCIe spec? This APIs should both work for x86/arm? >+Not sure ARM is OK with the naming, previously they are calling it more as >Sub Stream ID (SSID) For reference, Look for PASID definitions in the PCIe spec. The API takes in offset which might be different for other devic

Re: [PATCH v1] config/arm: correct cpu arch for cross build

2023-11-06 Thread Thomas Monjalon
06/11/2023 15:31, Joyce Kong: > > -Original Message- > > From: Thomas Monjalon > > Sent: Monday, November 6, 2023 10:10 PM > > To: Ruifeng Wang ; Joyce Kong > > > > Cc: dev@dpdk.org; Bruce Richardson ; > > dev@dpdk.org; nd ; Paul Szczepanek > > > > Subject: Re: [PATCH v1] config/arm: cor

Re: [PATCH v5 1/1] build: add libarchive to external deps

2023-11-06 Thread Thomas Monjalon
06/11/2023 16:24, Thomas Monjalon: > 06/11/2023 09:53, Bruce Richardson: > > On Sun, Nov 05, 2023 at 08:12:43PM -0800, Srikanth Yalavarthi wrote: > > > In order to avoid linking with Libs.private, libarchive > > > is not added to ext_deps during the meson setup stage. > > > > > > Since libarchive

Re: [PATCH v5 1/1] build: add libarchive to external deps

2023-11-06 Thread Thomas Monjalon
06/11/2023 09:53, Bruce Richardson: > On Sun, Nov 05, 2023 at 08:12:43PM -0800, Srikanth Yalavarthi wrote: > > In order to avoid linking with Libs.private, libarchive > > is not added to ext_deps during the meson setup stage. > > > > Since libarchive is not added to ext_deps, cross-compilation > >

RE: [PATCH v1 1/1] ml/cnxk: fix updating internal I/O info

2023-11-06 Thread Shivah Shankar Shankar Narayan Rao
> -Original Message- > From: Srikanth Yalavarthi > Sent: Sunday, October 29, 2023 6:55 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Anup Prabhu ; > Prince Takkar ; Jerin Jacob Kollanukkaran > > Subject: [PATCH v1 1/1] ml/cnxk: fix updating inter

RE: [PATCH v1] config/arm: correct cpu arch for cross build

2023-11-06 Thread Joyce Kong
> -Original Message- > From: Thomas Monjalon > Sent: Monday, November 6, 2023 10:10 PM > To: Ruifeng Wang ; Joyce Kong > > Cc: dev@dpdk.org; Bruce Richardson ; > dev@dpdk.org; nd ; Paul Szczepanek > > Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build > > 18/10/2023 07

RE: [PATCH 1/2] pipeline: fix calloc parameters

2023-11-06 Thread Dumitrescu, Cristian
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, November 2, 2023 1:09 PM > To: Dumitrescu, Cristian ; R, Kamalakannan > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 1/2] pipeline: fix calloc parameters > > gcc [1] generates warning [2] about calloc usage, because c

Re: [PATCH v2] config: verify machine arch flag

2023-11-06 Thread Thomas Monjalon
26/10/2023 20:13, Sivaprasad Tummala: > Added additional checks for compiler support of specific cpu arch > flags to fix incorrect error reporting. > > Without this patch, meson build reports '__SSE4_2__' not defined > error for x86 builds when the compiler does not support the specified > cpu_ins

Re: [PATCH v3] config/arm: update aarch32 build with gcc13

2023-11-06 Thread Thomas Monjalon
01/11/2023 13:57, Paul Szczepanek: > > On 25/10/2023 13:57, Juraj Linkeš wrote: > > The aarch32 with gcc13 fails with: > > > > Compiler for C supports arguments -march=armv8-a: NO > > > > ../config/arm/meson.build:714:12: ERROR: Problem encountered: No > > suitable armv8 march version found. > > >

Re: configuration of memseg lists number

2023-11-06 Thread Avi Kivity
Thanks, it makes sense. I'll get around to it "eventually". On Thu, 2023-11-02 at 11:04 +0100, Thomas Monjalon wrote: > Hello, > > While looking at Seastar, I see it uses this patch on top of DPDK: > > build: add meson options of max_memseg_lists > > RTE_MAX_MEMSEG_LISTS = 128 i

[PATCH 2/2] test/crypto: add negative test cases for cipher buffer alignment

2023-11-06 Thread Sivaramakrishnan Venkat
add negative test cases for 3DES CBC and AES CBC cipher algorithms for buffer misalignment Signed-off-by: Sivaramakrishnan Venkat --- app/test/test_cryptodev.c | 321 - app/test/test_cryptodev_aes_test_vectors.h | 119 app/test/test_cryptodev_blockci

[PATCH] net/mvpp2: fix null dereference in vmwa release

2023-11-06 Thread Weiguo Li
Pointer 'mrvl_cfg' is dereferenced and then compared to NULL. Move dereference after NULL test to fix this issue. Fixes: 7af10d29a4a0 ("net/mlx5/linux: refactor VLAN") Cc: sta...@dpdk.org Signed-off-by: Weiguo Li --- drivers/net/mlx5/linux/mlx5_vlan_os.c | 3 ++- 1 file changed, 2 insertions(+)

[PATCH 1/2] crypto/qat: fix block cipher misalignment for AES CBC and 3DES CBC

2023-11-06 Thread Sivaramakrishnan Venkat
check cipher length alignment for 3DES CBC and AES CBC to change it to NULL op for buffer misalignment Fixes: a815a04cea05 ("crypto/qat: support symmetric build op request") Fixes: 85fec6fd9674 ("crypto/qat: unify raw data path functions") Fixes: def38073ac90 ("crypto/qat: check cipher buffer alig

Re: [PATCH] config/arm: add cortex-A55 part number

2023-11-06 Thread Thomas Monjalon
30/10/2023 16:51, Hemant Agrawal: > This patch adds the part number for Cortex-A55 ARM Cores > A55 is used in NXP-i.mx93 SoCs. > > Signed-off-by: Hemant Agrawal Applied, thanks.

Re: [PATCH v1] config/arm: correct cpu arch for cross build

2023-11-06 Thread Thomas Monjalon
18/10/2023 07:40, Joyce Kong: > > From: Thomas Monjalon > > 22/08/2023 09:47, Joyce Kong: > > > The cn10k cross build file sets cpu to 'armv8.6-a' while > > > N2 is armv8.5-a arch. > > > The cpu field in the cross file doesn't take effect as > > > config/arm/meson.build controls machine_args for m

Re: [PATCH v3] eal/linux: verify mmu type for DPDK support (ppc64le)

2023-11-06 Thread Thomas Monjalon
24/10/2023 19:43, David Christensen: > IBM POWER systems support more than one type of memory management unit > (MMU). The Power ISA 3.0 specification, which applies to P9 and later > CPUs, defined a new Radix MMU which, among other things, allows an > anonymous memory page mapping to be converted

Re: [PATCH] eal/linux: verify mmu type for DPDK support (ppc64le)

2023-11-06 Thread Thomas Monjalon
23/10/2023 23:59, David Christensen: > > On 10/17/23 5:39 AM, Thomas Monjalon wrote: > > I feel this function should not be implemented in the common EAL. > > What about adding a new function in lib/eal/ppc/ ? > > And add the "return true" for other architectures? > > Would it be more appropriate

[PATCH v3 7/7] doc: testpmd support event handling section

2023-11-06 Thread Chengwen Feng
Add new section of event handling, which documented the ethdev and device events. Signed-off-by: Chengwen Feng --- doc/guides/testpmd_app_ug/event_handling.rst | 81 doc/guides/testpmd_app_ug/index.rst | 1 + 2 files changed, 82 insertions(+) create mode 100644 do

[PATCH v3 5/7] app/testpmd: add error recovery usage demo

2023-11-06 Thread Chengwen Feng
This patch adds error recovery usage demo which will: 1. stop packet forwarding when the RTE_ETH_EVENT_ERR_RECOVERING event is received. 2. restart packet forwarding when the RTE_ETH_EVENT_RECOVERY_SUCCESS event is received. 3. prompt the ports that fail to recovery and need to be removed whe

[PATCH v3 1/7] ethdev: fix race-condition of proactive error handling mode

2023-11-06 Thread Chengwen Feng
In the proactive error handling mode, the PMD will set the data path pointers to dummy functions and then try recovery, in this period the application may still invoking data path API. This will introduce a race-condition with data path which may lead to crash [1]. Although the PMD added delay aft

[PATCH v3 6/7] app/testpmd: extract event handling to event.c

2023-11-06 Thread Chengwen Feng
This patch extract event handling (including eth-event and dev-event) to a new file 'event.c'. Signed-off-by: Chengwen Feng Acked-by: Huisong Li --- app/test-pmd/event.c | 390 ++ app/test-pmd/meson.build | 1 + app/test-pmd/parameters.c | 36 +--- a

  1   2   >