RE: [EXT] Re: [PATCH v4 00/34] Implementation of revised ml/cnxk driver

2023-10-17 Thread Srikanth Yalavarthi
> -Original Message- > From: Jerin Jacob > Sent: 18 October 2023 07:26 > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Anup Prabhu ; > Prince Takkar > Subject: [EXT] Re: [PATCH v4 00/34] Implementation of revised ml/cnxk > driver > > External Email >

Re: [PATCH v3 2/2] raw/cnxk_gpio: add bunch of newlines

2023-10-17 Thread Jerin Jacob
On Tue, Oct 17, 2023 at 3:02 PM Tomasz Duszynski wrote: > > Improve log output by adding some newlines. > > Signed-off-by: Tomasz Duszynski > Reviewed-by: Jerin Jacob Kollanukkaran > Tested-by: Jerin Jacob Kollanukkaran > --- > drivers/raw/cnxk_gpio/cnxk_gpio.c | 8 Updated the git c

[PATCH v5 34/34] ml/cnxk: enable creation of mvtvm virtual device

2023-10-17 Thread Srikanth Yalavarthi
Enable support to create a mvtvm virtual device on system's without a PCI based ML HW accelerator. Signed-off-by: Srikanth Yalavarthi --- doc/guides/mldevs/cnxk.rst | 49 +++- drivers/ml/cnxk/cn10k_ml_dev.c | 8 ++ drivers/ml/cnxk/cn10k_ml_dev.h | 3 + drivers/ml/cnxk/cnxk_ml_

[PATCH v5 33/34] ml/cnxk: enable fast-path ops for TVM models

2023-10-17 Thread Srikanth Yalavarthi
From: Anup Prabhu Enable fast-path ops support for TVM models. Models would use TVMDP library function calls to execute inference operations for Hybrid and LLVM model sub-types. For TVM MRVL model subtypes that have a single MRVL layer, the inference requests are directly enqueued to hardware by

[PATCH v5 32/34] ml/cnxk: support quantize and dequantize callback

2023-10-17 Thread Srikanth Yalavarthi
From: Prince Takkar Added support for quantize and dequantize callback functions for TVM models. Signed-off-by: Prince Takkar --- drivers/ml/cnxk/mvtvm_ml_ops.c | 129 + drivers/ml/cnxk/mvtvm_ml_ops.h | 4 + 2 files changed, 133 insertions(+) diff --git a/dri

[PATCH v5 29/34] ml/cnxk: enable reporting model runtime as xstats

2023-10-17 Thread Srikanth Yalavarthi
Added model xstats entries to compute runtime latency. Allocated internal resources for TVM model xstats. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 9 +++ drivers/ml/cnxk/cn10k_ml_ops.h | 2 + drivers/ml/cnxk/cnxk_ml_ops.c| 131 ++

[PATCH v5 30/34] ml/cnxk: implement I/O alloc and free callbacks

2023-10-17 Thread Srikanth Yalavarthi
Implemented callback functions for IO allocation and free for Glow layers. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 87 ++ drivers/ml/cnxk/cn10k_ml_ops.h | 3 ++ drivers/ml/cnxk/mvtvm_ml_ops.c | 2 + 3 files changed, 92 insertions(

[PATCH v5 31/34] ml/cnxk: add generic ML malloc and free callback

2023-10-17 Thread Srikanth Yalavarthi
Implemented generic ML malloc and free callbacks Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 30 ++ drivers/ml/cnxk/cn10k_ml_ops.h | 3 +++ drivers/ml/cnxk/mvtvm_ml_ops.c | 2 ++ 3 files changed, 35 insertions(+) diff --git a/drivers/ml/

[PATCH v5 25/34] ml/cnxk: enable OCM check for multilayer TVM model

2023-10-17 Thread Srikanth Yalavarthi
From: Anup Prabhu Enabled check for OCM size requirement for multi-layer TVM model. Compute OCM scratch and WB requirement for all layers during the load stage. Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cnxk_ml_ops.c | 60 +++ 1 file changed, 60 insertions(

[PATCH v5 27/34] ml/cnxk: update internal TVM model info structure

2023-10-17 Thread Srikanth Yalavarthi
From: Prince Takkar Added support to update internal model info structure for TVM models. Signed-off-by: Prince Takkar Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/mvtvm_ml_model.c | 65 drivers/ml/cnxk/mvtvm_ml_model.h | 2 + drivers/ml/cnxk/mvtvm_

[PATCH v5 23/34] ml/cnxk: update internal info for TVM model

2023-10-17 Thread Srikanth Yalavarthi
Enabled updating internal IO info structures for TVM model. Compute static fields related to the model I/O. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cnxk_ml_ops.c| 4 ++ drivers/ml/cnxk/mvtvm_ml_model.c | 111 +++ drivers/ml/cnxk/mvtvm_ml_model.h |

[PATCH v5 18/34] ml/cnxk: support config and close of tvmdp library

2023-10-17 Thread Srikanth Yalavarthi
Added support to configure and close TVMDP library based on ML device configuration options. Updated meson build to enable Jansson, TVM runtime, TVMDP library as build dependencies. Signed-off-by: Srikanth Yalavarthi --- doc/guides/mldevs/cnxk.rst | 58 +++ dri

[PATCH v5 17/34] ml/cnxk: move error handling to cnxk layer

2023-10-17 Thread Srikanth Yalavarthi
Move error type structures to cnxk layer. cn10k layer to handle fw and hw error sub-types only. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 41 ++- drivers/ml/cnxk/cn10k_ml_ops.c | 93 +- drivers/ml/cnxk/cnxk_ml_dev.c | 8

[PATCH v5 16/34] ml/cnxk: update fast path functions

2023-10-17 Thread Srikanth Yalavarthi
Implemented cnxk layer fast-path functions and added support for model specific fast-path functions. CNXK layer functions would invoke model specific fast-path functions. Added support for model specific poll handling functions and updated internal inference sync function. Drop use of rte_ml_op as

[PATCH v5 28/34] ml/cnxk: support device dump for TVM models

2023-10-17 Thread Srikanth Yalavarthi
Enabled support to print TVM model layer info. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cnxk_ml_model.c | 7 +++- drivers/ml/cnxk/mvtvm_ml_model.c | 59 drivers/ml/cnxk/mvtvm_ml_model.h | 2 ++ drivers/ml/cnxk/mvtvm_ml_stubs.c | 8 + drivers

[PATCH v5 15/34] ml/cnxk: update device and model xstats functions

2023-10-17 Thread Srikanth Yalavarthi
Added cnxk wrapper function to handle ML device and model extended stats. Handling resources for the xstats is done in the cnxk layer. Introduced internal xstats group. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 4 - drivers/ml/cnxk/cn10k_ml_ops.c | 531 +++

[PATCH v5 14/34] ml/cnxk: update device stats functions

2023-10-17 Thread Srikanth Yalavarthi
Added cnxk wrapper function to handle ML device stats Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 32 -- drivers/ml/cnxk/cn10k_ml_ops.h | 2 -- drivers/ml/cnxk/cnxk_ml_ops.c | 36 -- 3 files changed, 34 ins

[PATCH v5 26/34] ml/cnxk: support start and stop for TVM models

2023-10-17 Thread Srikanth Yalavarthi
Added support to start and stop TVM models. TVM model start would invoke layer start for all Glow layers part of the model. TVM model stop would invoke layer stop for all Glow layers part of the model. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cn10k_ml_op

[PATCH v5 24/34] ml/cnxk: enable model unload in tvmdp library

2023-10-17 Thread Srikanth Yalavarthi
Enable unloading model using external tvmdp library. Updated layer unload callback to support multiple layers. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cn10k_ml_ops.c | 8 +--- drivers/ml/cnxk/cnxk_ml_ops.c| 7 +-- drivers/ml/cnxk/mvtvm_m

[PATCH v5 13/34] ml/cnxk: update device debug functions

2023-10-17 Thread Srikanth Yalavarthi
Added cnxk wrapper for device dump and selftest debug functions. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_model.c | 118 + drivers/ml/cnxk/cn10k_ml_model.h | 1 + drivers/ml/cnxk/cn10k_ml_ocm.c | 8 +- drivers/ml/cnxk/cn10k_ml_ocm.h | 2 +- dr

[PATCH v5 22/34] ml/cnxk: fetch layer info and load TVM model

2023-10-17 Thread Srikanth Yalavarthi
Added support to fetch TVM model layer information and update internal structures based on the layer information Set callback functions for layer load and unload and enable model loading using TVMDP library. Added support to fetch full metadata after model load. Signed-off-by: Srikanth Yalavarthi

[PATCH v5 12/34] ml/cnxk: update data quantization functions

2023-10-17 Thread Srikanth Yalavarthi
Added cnxk wrapper functions to quantize input data and dequantize output data. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 164 - drivers/ml/cnxk/cn10k_ml_ops.h | 7 -- drivers/ml/cnxk/cnxk_ml_io.c | 95 +++ driver

[PATCH v5 21/34] ml/cnxk: add support to parse TVM model objects

2023-10-17 Thread Srikanth Yalavarthi
Added support to parse TVM model objects from the model archive buffer. Added support to check for all expected objects and copy TVM model objects to internal buffers. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cnxk_ml_ops.c| 5 ++- drivers/ml/cnxk/mv

[PATCH v5 11/34] ml/cnxk: update model utility functions

2023-10-17 Thread Srikanth Yalavarthi
Added cnxk wrapper function to update model params and fetch model info. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 38 ++- drivers/ml/cnxk/cn10k_ml_ops.h | 5 ++-- drivers/ml/cnxk/cnxk_ml_ops.c | 48 -- 3 fil

[PATCH v5 20/34] ml/cnxk: add support for identify model type

2023-10-17 Thread Srikanth Yalavarthi
Enable support to parse model buffer to identify the model type and model sub-type. Enabled basic checks for Glow model type buffer. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cnxk_ml_model.c | 49 drivers/ml/cnxk/cnxk_ml_mode

[PATCH v5 09/34] ml/cnxk: update model load and unload functions

2023-10-17 Thread Srikanth Yalavarthi
Implemented cnxk wrapper functions to load and unload ML models. Wrapper functions would invoke the cn10k model load and unload functions. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_model.c | 244 - drivers/ml/cnxk/cn10k_ml_model.h | 26 ++- drivers/

[PATCH v5 19/34] ml/cnxk: add structures to support TVM model type

2023-10-17 Thread Srikanth Yalavarthi
Introduced model type, sub-type and layer type. Added internal structures for TVM model objects. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ocm.c | 3 ++ drivers/ml/cnxk/cn10k_ml_ops.c | 6 ++- drivers/ml/cnxk/cnxk_ml_model.h | 66 +++- dri

[PATCH v5 07/34] ml/cnxk: update device handling functions

2023-10-17 Thread Srikanth Yalavarthi
Implement CNXK wrapper functions for dev_info_get, dev_configure, dev_close, dev_start and dev_stop. The wrapper functions allocate / release common resources for the ML driver and invoke device specific functions. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 230 ++---

[PATCH v5 06/34] ml/cnxk: rename cnxk ops function pointers struct

2023-10-17 Thread Srikanth Yalavarthi
Renamed cn10k ML ops structure with cnxk prefix. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 2 +- drivers/ml/cnxk/cn10k_ml_ops.c | 73 +- drivers/ml/cnxk/cn10k_ml_ops.h | 34 +++- drivers/ml/cnxk/cnxk_ml_ops.c | 36 ++

[PATCH v5 05/34] ml/cnxk: add generic cnxk xstats structures

2023-10-17 Thread Srikanth Yalavarthi
Introduced generic xstats structures and renamed cn10k xstats enumerations with cnxk prefix. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 86 +--- drivers/ml/cnxk/cn10k_ml_model.h | 6 +- drivers/ml/cnxk/cn10k_ml_ops.c | 169 ++---

[PATCH v5 10/34] ml/cnxk: update model start and stop functions

2023-10-17 Thread Srikanth Yalavarthi
Implemented cnxk wrapper functions to start and stop ML models. Wrapper functions would invoke the cn10k model start and stop functions. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ocm.c | 28 ++-- drivers/ml/cnxk/cn10k_ml_ocm.h | 12 +- drivers/ml/cnxk/cn10k_ml_ops.c | 282

[PATCH v5 04/34] ml/cnxk: add generic cnxk request structure

2023-10-17 Thread Srikanth Yalavarthi
Added generic cnxk request structure. Moved common fields from cn10k structures to cnxk structure. Moved job related structures and enumerations to ops headers. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 72 +++ drivers/ml/cnxk/cn10k_ml_dev.h | 269 +

[PATCH v5 03/34] ml/cnxk: add generic model and layer structures

2023-10-17 Thread Srikanth Yalavarthi
Introduce generic cnxk model and layer structure. These structures would enable supporting models with multiple layers. A model is a collection of multiple independent layers with flow dependencies between the layers. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 9

[PATCH v5 08/34] ml/cnxk: update queue-pair handling functions

2023-10-17 Thread Srikanth Yalavarthi
Added cnxk wrapper function to handle ML device queue-pairs. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 135 + drivers/ml/cnxk/cn10k_ml_ops.h | 7 +- drivers/ml/cnxk/cnxk_ml_ops.c | 153 - drivers/ml/cnxk

[PATCH v5 02/34] ml/cnxk: add generic cnxk device structure

2023-10-17 Thread Srikanth Yalavarthi
Introduce generic cnxk device structure. This structure is a top level device structure for the driver, which would encapsulate the target / platform specific device structure. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 316 ++-- drivers/ml/cnxk/cn1

[PATCH v5 00/34] Implementation of revised ml/cnxk driver

2023-10-17 Thread Srikanth Yalavarthi
This patch series is an implementation of revised ml/cnxk driver to support models compiled with TVM compiler framework. TVM models use a hybrid mode for execution, with regions of the model executing on the ML accelerator and the rest executing on CPU cores. This series of commits reorganizes the

[PATCH v5 01/34] ml/cnxk: drop support for register polling

2023-10-17 Thread Srikanth Yalavarthi
Dropped support for device argument "poll_mem" for cnxk ML driver. Support to use registers for polling is removed and DDR addresses would be used for polling. Signed-off-by: Srikanth Yalavarthi --- doc/guides/mldevs/cnxk.rst | 16 - drivers/ml/cnxk/cn10k_ml_dev.c | 36 +-- dri

[PATCH v9 12/12] app/graph: support l3fwd use case

2023-10-17 Thread skori
From: Rakesh Kudurumalla Adds an use case l3fwd. It contains a dedicated l3fwd.cli file mentioning commands to configure the required resources. Once application successfully parses the l3fwd.cli then a graph is created having below nodes: - ethdev_rx -> pkt_cls - pkt_cls -> ip4_lookup - pkt

[PATCH v9 11/12] app/graph: support CLI option to enable graph stats

2023-10-17 Thread skori
From: Sunil Kumar Kori Adds application's command line parameter "--enable-graph-stats" to enable dumping graph stats on console. By default, no graph stats will be printed on console but same can be dumped via telnet session using "graph stats show" command. Signed-off-by: Sunil Kumar Kori Si

[PATCH v9 10/12] app/graph: support graph command line interfaces

2023-10-17 Thread skori
From: Rakesh Kudurumalla Adds graph module to create a graph for a given use case like l3fwd. Following commands are exposed: - graph [bsz ] [tmo ] [coremask ] \ model pcap_enable <0 | 1> num_pcap_pkts \ pcap_file - graph start - graph stats show - help graph Signed-off-

[PATCH v9 09/12] app/graph: support ethdev Rx command line interfaces

2023-10-17 Thread skori
From: Rakesh Kudurumalla Adds ethdev_rx module to create port-queue-core mapping. Mapping will be used to launch graph worker thread and dequeue packets on mentioned core from desired port/queue. Following commands are exposed: - ethdev_rx map port queue core - help ethdev_rx Signed-off-b

[PATCH v9 08/12] app/graph: support neigh command line interfaces

2023-10-17 Thread skori
From: Sunil Kumar Kori Adds neigh module to configure arp/neigh. This module uses ipv4_rewrite and ipv6_rewrite node to write neigh information. Following commands are exposed: - neigh add ipv4 - neigh add ipv6 - help neigh Signed-off-by: Sunil Kumar Kori Signed-off-by: Rakesh Kudurumal

[PATCH v9 07/12] app/graph: support IPv6 lookup command line interfaces

2023-10-17 Thread skori
From: Rakesh Kudurumalla Adds ipv6_lookup module to configure LPM6 table. This LPM6 table will be used for IPv6 lookup and forwarding. Following commands are exposed: - ipv6_lookup route add ipv6 netmask via - help ipv6_lookup Signed-off-by: Sunil Kumar Kori Signed-off-by: Rakesh Kuduruma

[PATCH v9 06/12] app/graph: support IPv4 lookup command line interfaces

2023-10-17 Thread skori
From: Sunil Kumar Kori Adds ipv4_lookup module to configure LPM table. This LPM table will be used for IPv4 lookup and forwarding. Following commands are exposed: - ipv4_lookup route add ipv4 netmask via - help ipv4_lookup Signed-off-by: Sunil Kumar Kori Signed-off-by: Rakesh Kudurumalla

[PATCH v9 05/12] app/graph: support ethdev command line interfaces

2023-10-17 Thread skori
From: Sunil Kumar Kori Adds ethdev module to configure ethernet devices. Following commands are exposed: - ethdev rxq txq - ethdev mtu - ethdev promiscuous - ethdev show - ethdev stats - ethdev ip4 addr add netmask - ethdev ip6 addr add netmask - help ethdev Signed-off-b

[PATCH v9 04/12] app/graph: support mempool command line interfaces

2023-10-17 Thread skori
From: Rakesh Kudurumalla Adds mempool module which will be creating mempools. Following commands are exposed: - mempool size buffers \ cache numa - help mempool User will add this command in .cli file according to its need. Signed-off-by: Sunil Kumar Kori Signed-off-by: Rakesh

[PATCH v9 03/12] app/graph: support parser utility APIs

2023-10-17 Thread skori
From: Sunil Kumar Kori Adds some helper functions to parse IPv4, IPv6 and MAC addresses string into respective datatype. Signed-off-by: Sunil Kumar Kori Signed-off-by: Rakesh Kudurumalla Acked-by: Jerin Jacob --- app/graph/meson.build | 1 + app/graph/module_api.h | 1 + app/graph/utils

[PATCH v9 02/12] app/graph: support telnet connectivity framework

2023-10-17 Thread skori
From: Sunil Kumar Kori Adds framework to initiate a telnet session with application. Some configurations and debug commands are exposed as runtime APIs. Those commands can be invoked using telnet session. Application initiates a telnet server with host address 0.0.0.0 and port number 8086 by de

[PATCH v9 01/12] app/graph: support application CLI framework

2023-10-17 Thread skori
From: Sunil Kumar Kori Adds base framework to read a given .cli file as a command line parameter "-s". Example: # ./dpdk-graph -c 0xff -- -s ./app/graph/examples/dummy.cli Each .cli file will contain commands to configure different module like mempool, ethdev, lookup tables, graph etc. Command

[PATCH v9 00/12] add CLI based graph application

2023-10-17 Thread skori
From: Sunil Kumar Kori In the continuation of following feedback https://patches.dpdk.org/project/dpdk/patch/20230425131516.3308612-5-vattun...@marvell.com/ this patch series adds dpdk-graph application to exercise various usecases using graph. 1. Each use case is defined in terms of .cli file w

Re: [PATCH] event/dsw: fix missing device pointer

2023-10-17 Thread Mattias Rönnblom
On 2023-10-18 07:18, Jerin Jacob wrote: On Tue, Oct 17, 2023 at 10:21 PM Jerin Jacob wrote: On Tue, Oct 17, 2023 at 9:45 PM Bruce Richardson wrote: On Tue, Oct 17, 2023 at 09:34:04PM +0530, Jerin Jacob wrote: On Tue, Oct 17, 2023 at 9:32 PM Bruce Richardson wrote: After calling rte_even

Re: [PATCH v3 2/4] event/dsw: fix missing device pointer

2023-10-17 Thread Mattias Rönnblom
On 2023-10-17 18:46, Bruce Richardson wrote: Initialize the "dev" pointer in the eventdev structure so it can be returned in calls to "rte_event_dev_info_get()" and avoid potential crashes due to a NULL value being passed to "rte_dev_name()" Fixes: 46a186b1f0c5 ("event/dsw: add device registrati

[PATCH v2] net/cpfl: fix memory leak

2023-10-17 Thread beilei . xing
From: Beilei Xing Fix resource leak reported in coverity scan. Coverity issue: 403265 Fixes: 2d823ecd671c ("net/cpfl: support device initialization") Fixes: 989465ac51ea ("net/cpfl: support probe again") Cc: sta...@dpdk.org Signed-off-by: Beilei Xing --- v2 change: - add label finish for succ

RE: [PATCH v1] config/arm: correct cpu arch for cross build

2023-10-17 Thread Joyce Kong
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, October 18, 2023 3:42 AM > To: Joyce Kong > Cc: Ruifeng Wang ; Bruce Richardson > ; dev@dpdk.org; nd > Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build > > 22/08/2023 09:47, Joyce Kong: > > The cn10k cro

Re: [PATCH 3/3] common/cnxk: check for error code in MAC address set

2023-10-17 Thread Jerin Jacob
On Mon, Oct 16, 2023 at 12:35 PM Nithin Dabilpuram wrote: > > Check for mbox error code in MAC address set. > Fixes: 313cc41830ec ("common/cnxk: support NIX MAC operations") > > Signed-off-by: Nithin Dabilpuram Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-next-net. Th

Re: [PATCH] event/dsw: fix missing device pointer

2023-10-17 Thread Jerin Jacob
On Tue, Oct 17, 2023 at 10:21 PM Jerin Jacob wrote: > > On Tue, Oct 17, 2023 at 9:45 PM Bruce Richardson > wrote: > > > > On Tue, Oct 17, 2023 at 09:34:04PM +0530, Jerin Jacob wrote: > > > On Tue, Oct 17, 2023 at 9:32 PM Bruce Richardson > > > wrote: > > > > > > > > After calling rte_event_dev_i

Re: [PATCH] net/cnxk: fix separate callback for Rx flush on CN10k

2023-10-17 Thread Jerin Jacob
On Mon, Oct 16, 2023 at 1:26 PM Rahul Bhansali wrote: > > In case of dev stop, Rx packet flush will be called which > uses LMT lines to bulk free of the pending meta buffers. > And LMT line is not valid for non EAL cores. As a fix, > a separate callback for Rx packets flush is added, which > will

Re: [PATCH] common/cnxk: fix pool buffer size in opaque mode

2023-10-17 Thread Jerin Jacob
On Fri, Oct 13, 2023 at 10:06 PM Ashwin Sekhar T K wrote: > > From: Kommula Shiva Shankar > > Pool buffer size in opaque mode must always be set to 0. > > Fixes: f765f5611240 ("common/cnxk: add NPA pool HW operations") > > Signed-off-by: Kommula Shiva Shankar > Signed-off-by: Ashwin Sekhar T K

Re: [PATCH] common/cnxk: fix pool buffer size in opaque mode

2023-10-17 Thread Jerin Jacob
On Fri, Oct 13, 2023 at 10:06 PM Ashwin Sekhar T K wrote: > > From: Kommula Shiva Shankar > > Pool buffer size in opaque mode must always be set to 0. > > Fixes: f765f5611240 ("common/cnxk: add NPA pool HW operations") > > Signed-off-by: Kommula Shiva Shankar > Signed-off-by: Ashwin Sekhar T K

Re: [PATCH v4 3/3] net/octeon_ep: add new fastpath routines

2023-10-17 Thread Jerin Jacob
On Thu, Oct 12, 2023 at 4:41 PM Vamsi Attunuru wrote: > > Adds new fastpath routines for cn10k & cn9k endpoint > devices and assigns the fastpath routines based on > the offload flags. > > Patch also adds misc changes to improve performance > and code-readability. > > Signed-off-by: Vamsi Attunuru

[PATCH v2] net/cpfl: remove devargs from adapter

2023-10-17 Thread beilei . xing
From: Beilei Xing Member devargs can be removed from struct cpfl_adapter_ext since it's not a global parameter, it should be local. Signed-off-by: Beilei Xing --- v2 change: - Fix compile issue on some platform. drivers/net/cpfl/cpfl_ethdev.c | 47 + drivers/

[PATCH v1] net/mlx5: add indirect encap decap support

2023-10-17 Thread Rongwei Liu
Support the raw_encap/decap combinations in the indirect action list, and translates to 4 types of underlayer tunnel operations: 1. Layer 2 encapsulation like VxLAN. 2. Layer 2 decapsulation like VxLAN. 3. Layer 3 encapsulation like GRE. 4. Layer 3 decapsulation like GRE. Each indirect action list

RE: [PATCH v3 1/8] ethdev: add member notification for bonding port

2023-10-17 Thread Chaoyong He
> 在 2023/10/9 11:11, Long Wu 写道: > >> Hi Chaoyong, > >> > >> some comments as below. > >> > >> > >> 在 2023/10/8 9:50, Chaoyong He 写道: > >>> From: Long Wu > >>> > >>> Bonding PMD does not let member ports know the bonding port's > >>> information, like how many member ports the bonding port has, wh

RE: [PATCH] net/cpfl: fix memory leak

2023-10-17 Thread Zhang, Qi Z
> -Original Message- > From: beilei.x...@intel.com > Sent: Tuesday, October 17, 2023 7:07 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Xing, Beilei ; sta...@dpdk.org > Subject: [PATCH] net/cpfl: fix memory leak > > From: Beilei Xing > > Fix resource leak reported in coverity scan. > >

Re: [PATCH v4 00/34] Implementation of revised ml/cnxk driver

2023-10-17 Thread Jerin Jacob
On Tue, Oct 17, 2023 at 10:30 PM Srikanth Yalavarthi wrote: > > This patch series is an implementation of revised ml/cnxk driver > to support models compiled with TVM compiler framework. TVM models > use a hybrid mode for execution, with regions of the model executing > on the ML accelerator and t

RE: [PATCH v3 7/8] net/bonding: support checking valid bonding port ID

2023-10-17 Thread Chaoyong He
> 在 2023/10/17 17:25, Chaoyong He 写道: > >> Hi Chaoyong, > >> > >> It is better to separate patch 3/8 and patch 6/8 from this series. > > The patch 3/8 is okay to separate, there is no problem. > > But if patch 6/8 be a separate patch, this patch series will need depend on > > it. > > I'm not sure

[PATCH 4/4] ethdev: add telemetry command for TM node capabilities

2023-10-17 Thread Jie Hai
This patch adds a telemetry command for traffic management node capabilities, using (port_id, node_id) as parameters. An example usage is shown below: --> /ethdev/tm_node_capability,0,264 { "/ethdev/tm_node_capability": { "shaper_private_supported": 1, "shaper_private_dual_rate_supported

[PATCH 3/4] ethdev: add telemetry command for TM level capabilities

2023-10-17 Thread Jie Hai
This patch adds a telemetry command for traffic management level capabilities, using (port_id,level_id) as parameters. An example usage is shown below: --> /ethdev/tm_level_capability,0,0 { "/ethdev/tm_level_capability": { "n_nodes_max": 1, "n_nodes_nonleaf_max": 1, "n_nodes_leaf_max

[PATCH 2/4] ethdev: add telemetry command for TM capabilities

2023-10-17 Thread Jie Hai
This patch adds a telemetry command for traffic management capabilities. An example usage is shown below: --> /ethdev/tm_capability,0 { "/ethdev/tm_capability": { "n_nodes_max": 265, "n_levels_max": 3, "non_leaf_nodes_identical": 1, "leaf_nodes_identical": 1, "shaper_n_max":

[PATCH 0/4] add telemetry commands for TM capabilities

2023-10-17 Thread Jie Hai
This patch adds telemetry commands for TM capabilities and make some bufix for hns3 driver. Jie Hai (4): net/hns3: fix a typo ethdev: add telemetry command for TM capabilities ethdev: add telemetry command for TM level capabilities ethdev: add telemetry command for TM node capabilities d

[PATCH 1/4] net/hns3: fix a typo

2023-10-17 Thread Jie Hai
This patch fixes a typo. Fixes: c09c7847d892 ("net/hns3: support traffic management") Cc: sta...@dpdk.org Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_tm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_tm.c b/drivers/net/hns3/hns3_tm.c index 6

Re: [PATCH v2 00/19] use rte optional stdatomic API

2023-10-17 Thread Stephen Hemminger
On Tue, 17 Oct 2023 13:30:58 -0700 Tyler Retzlaff wrote: > Replace the use of gcc builtin __atomic_xxx intrinsics with > corresponding rte_atomic_xxx optional stdatomic API. > > v2: > * add #include to rte_mbuf_core.h > * remove first two patches which were fixes that have > been merged

release candidate 23.11-rc1

2023-10-17 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v23.11-rc1 There are 617 new patches in this snapshot, including many API/ABI compatibility breakages. This release won't be ABI-compatible with previous ones. Release notes: https://doc.dpdk.org/

[PATCH v2 15/19] distributor: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/distributor/distributor_private.h | 4 +-- lib/distributor/rte_distributor.c | 54 +-- 2 files changed, 29 in

[PATCH v2 19/19] ring: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5_hws_cnt.h | 2 +- lib/ring/rte_ring_c11_pvt.h | 33 + lib/ring/rte_ring_core.h

[PATCH v2 18/19] timer: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/timer/rte_timer.c | 50 +- lib/timer/rte_timer.h | 6 +++--- 2 files changed, 28 insertions(+), 2

[PATCH v2 17/19] hash: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/hash/rte_cuckoo_hash.c | 116 ++--- lib/hash/rte_cuckoo_hash.h | 6 +-- 2 files changed, 61 insertions(+

[PATCH v2 14/19] cryptodev: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/cryptodev/rte_cryptodev.c | 22 -- lib/cryptodev/rte_cryptodev.h | 16 2 files changed, 20 insertions(+), 18

[PATCH v2 16/19] ethdev: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/ethdev/ethdev_driver.h | 16 lib/ethdev/ethdev_private.c | 6 +++--- lib/ethdev/rte_ethdev.c | 24 --

[PATCH v2 13/19] vhost: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/vhost/vdpa.c| 3 ++- lib/vhost/vhost.c | 42 lib/vhost/vhost.h | 39

[PATCH v2 12/19] telemetry: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/telemetry/telemetry.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/telemetry/telemetry.c b/lib/telem

[PATCH v2 11/19] stack: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/stack/rte_stack.h| 2 +- lib/stack/rte_stack_lf_c11.h | 24 lib/stack/rte_stack_lf_generic.h | 18 ++

[PATCH v2 10/19] pdump: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/pdump/rte_pdump.c | 14 +++--- lib/pdump/rte_pdump.h | 8 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/lib/p

[PATCH v2 09/19] rcu: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/rcu/rte_rcu_qsbr.c | 48 +-- lib/rcu/rte_rcu_qsbr.h | 68 +- 2 fil

[PATCH v2 07/19] mbuf: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/mbuf/rte_mbuf.h | 20 ++-- lib/mbuf/rte_mbuf_core.h | 5 +++-- 2 files changed, 13 insertions(+), 12 deletions(-) diff --gi

[PATCH v2 05/19] gpudev: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/gpudev/gpudev.c| 6 +++--- lib/gpudev/gpudev_driver.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/gpudev/gp

[PATCH v2 08/19] mempool: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/mempool/rte_mempool.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.

[PATCH v2 06/19] ipsec: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/ipsec/ipsec_sqn.h | 2 +- lib/ipsec/sa.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ipsec/ipsec_sqn.h b/lib

[PATCH v2 03/19] eal: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_common_launch.c| 10 +-- lib/eal/common/eal_common_mcfg.c | 2 +- lib/eal/common/eal_common_proc.c | 14 ++-- lib

[PATCH v2 04/19] eventdev: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- drivers/event/cnxk/cnxk_tim_worker.h | 4 +-- lib/eventdev/rte_event_timer_adapter.c | 66 +- lib/eventdev/rte_even

[PATCH v2 02/19] bbdev: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/bbdev/rte_bbdev.c | 6 +++--- lib/bbdev/rte_bbdev.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/bbdev/rte_bbdev.c b

[PATCH v2 01/19] power: use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/power/power_acpi_cpufreq.c | 33 + lib/power/power_cppc_cpufreq.c | 25 + lib/power/po

[PATCH v2 00/19] use rte optional stdatomic API

2023-10-17 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API. v2: * add #include to rte_mbuf_core.h * remove first two patches which were fixes that have been merged in another series Tyler Retzlaff (19): power: use rte optional stdato

Re: [PATCH v1 11/11] test/bbdev: support 4 bit LLR compression

2023-10-17 Thread Maxime Coquelin
On 9/29/23 20:13, Hernan Vargas wrote: Add support to test LDPC UL operation for new capability. Option to compress HARQ memory to 4 bits per LLR. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 3 ++- app/test-bbdev/test_bbdev_vector.c | 2 ++ 2 files changed, 4 in

Re: [PATCH v1 10/11] test/bbdev: support new FFT capabilities

2023-10-17 Thread Maxime Coquelin
On 9/29/23 20:13, Hernan Vargas wrote: Adding support to test new FFT capabilities. Optional frequency domain dewindowing, frequency resampling, timing error correction and time offset per CS. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 26 ++--- app/test

Re: [PATCH v1 09/11] test/bbdev: add MLD support

2023-10-17 Thread Maxime Coquelin
On 9/29/23 20:13, Hernan Vargas wrote: Adding test-bbdev support for the MLD-TS processing specific to the VRB2 variant. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 519 + app/test-bbdev/test_bbdev_vector.c | 132 app/test-bb

Re: [PATCH v3 0/3] fix test-pipeline issues

2023-10-17 Thread Thomas Monjalon
Cristian, please could you review this series please? 12/09/2023 08:39, Feifei Wang: > For test-pipeline application, there are some problems with the normal > operation of the program and security issues. These patches can fix > these issues. > > v3: fix SIGINT handling issue and add dev close o

Re: [PATCH] app/proc-info: remove unnecessary rte_malloc

2023-10-17 Thread Thomas Monjalon
08/08/2023 03:11, fengchengwen: > On 2023/8/8 4:43, Stephen Hemminger wrote: > > Better to use malloc() which is faster and has more error > > checking, as is done already for statistics. > > > > Fixes: 077c546704da ("app/proc_info: add metrics displaying") > > Signed-off-by: Stephen Hemminger >

Re: [PATCH v1 08/11] test/bbdev: increase max burst size

2023-10-17 Thread Maxime Coquelin
On 9/29/23 20:13, Hernan Vargas wrote: Increase max burst size to 1023. Signed-off-by: Hernan Vargas --- app/test-bbdev/main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-bbdev/main.h b/app/test-bbdev/main.h index dc10a505d141..ac0083ec6673 100644 --- a/ap

Re: [PATCH v1 07/11] test/bbdev: ldpc encoder concatenation vector

2023-10-17 Thread Maxime Coquelin
On 9/29/23 20:13, Hernan Vargas wrote: Add support for LDPC encoder concatenation configuration from the test vector. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_vector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_vector

  1   2   3   >