> -----Original Message-----
> From: Jerin Jacob <jerinjac...@gmail.com>
> Sent: 18 October 2023 07:26
> To: Srikanth Yalavarthi <syalavar...@marvell.com>
> Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao
> <sshankarn...@marvell.com>; Anup Prabhu <apra...@marvell.com>;
> Prince Takkar <ptak...@marvell.com>
> Subject: [EXT] Re: [PATCH v4 00/34] Implementation of revised ml/cnxk
> driver
>
> External Email
>
> ----------------------------------------------------------------------
> On Tue, Oct 17, 2023 at 10:30 PM Srikanth Yalavarthi
> <syalavar...@marvell.com> wrote:
> >
> > This patch series is an implementation of revised ml/cnxk driver to
> > support models compiled with TVM compiler framework. TVM models use
> a
> > hybrid mode for execution, with regions of the model executing on the
> > ML accelerator and the rest executing on CPU cores.
> >
> > This series of commits reorganizes the ml/cnxk driver and adds support
> > to execute multiple regions with-in a TVM model.
> >
>
> Found following build error (may be due to gcc13)
Issue is due to order of the patches in the series. This patch is incorrectly
ordered in the series and should be applied after
"ml/cnxk: add structures to support TVM model type"
I have fixed this and tested building all patches. No issues observed now.
Submitted v5 with required changes
>
> ml/cnxk: enable OCM check for multilayer TVM model
>
> [2389/2660] Compiling C object
> drivers/libtmp_rte_ml_cnxk.a.p/ml_cnxk_cnxk_ml_ops.c.o
> FAILED: drivers/libtmp_rte_ml_cnxk.a.p/ml_cnxk_cnxk_ml_ops.c.o
> ccache gcc -Idrivers/libtmp_rte_ml_cnxk.a.p -Idrivers -I../drivers -
> Idrivers/ml/cnxk -I../drivers/ml/cnxk -Ilib/mldev -I../lib/mldev -I.
> -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -
> Ilib/eal/linux/include -I../lib/eal/l inux/include -Ilib/eal/x86/include -
> I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -
> I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/metrics
> -
> I../lib/metrics -Ilib/telemetry -I../lib/telemetry -I lib/mempool -
> I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/mbuf -I../lib/mbuf -
> Idrivers/common/cnxk -I../drivers/common/cnxk -Idrivers/bus/pci -
> I../drivers/bus/pci -Ilib/net -I../lib/net -Ilib/ethdev -I../lib/ethdev
> -Ilib/meter
> -I../lib/me ter -Ilib/pci -I../lib/pci -I../drivers/bus/pci/linux
> -Ilib/security -
> I../lib/security -Ilib/cryptodev -I../lib/cryptodev -Ilib/rcu -I../lib/rcu
> -Ilib/hash
> -I../lib/hash -fdiagnostics-color=always
> -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O2 -
> g -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-
> nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -
> Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -
> Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-
> member -Wno-packed-not-aligned -Wno-missing-field-initializers -Wno-
> zero-length-bounds -D_GNU_SOURCE -fPIC -march=native -mrtm -
> DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-
> truncation -DCNXK_ML_DEV_DEBUG -
> DRTE_LOG_DEFAULT_LOGTYPE=pmd.ml.cnxk -MD -MQ
> drivers/libtmp_rte_ml_cnxk.a.p/ml_cnxk_cnxk_ml_ops.c.o -MF
> drivers/libtmp_rte_ml_cnxk.a.p/ml_cnxk_cnxk_ml_ops.c.o.d -o
> drivers/libtmp_rte_ml_cnxk.a.p/ ml_cnxk_cnxk_ml_ops.c.o -c
> ../drivers/ml/cnxk/cnxk_ml_ops.c
> ../drivers/ml/cnxk/cnxk_ml_ops.c: In function ‘cnxk_ml_model_load’:
> ../drivers/ml/cnxk/cnxk_ml_ops.c:527:18: error: ‘struct cnxk_ml_model’
> has no member named ‘type’
> 527 | if (model->type == ML_CNXK_MODEL_TYPE_GLOW) {
> | ^~
> ../drivers/ml/cnxk/cnxk_ml_ops.c:527:28: error:
> ‘ML_CNXK_MODEL_TYPE_GLOW’ undeclared (first use in this function); did
> you mean ‘ML_CNXK_MODEL_STATE_LOADED’?
> 527 | if (model->type == ML_CNXK_MODEL_TYPE_GLOW) {
> | ^~~~~~~~~~~~~~~~~~~~~~~
> | ML_CNXK_MODEL_STATE_LOADED
> ../drivers/ml/cnxk/cnxk_ml_ops.c:527:28: note: each undeclared identifier is
> reported only once for each function it appears in
> ../drivers/ml/cnxk/cnxk_ml_ops.c:549:26: error: ‘struct cnxk_ml_model’
> has no member named ‘type’
> 549 | if (model->type == ML_CNXK_MODEL_TYPE_GLOW) {
> | ^~
> ../drivers/ml/cnxk/cnxk_ml_ops.c:568:26: error: ‘struct cnxk_ml_model’
> has no member named ‘type’
> 568 | if (model->type == ML_CNXK_MODEL_TYPE_GLOW)
> | ^~
> [2390/2660] Generating drivers/rte_bus_dpaa.sym_chk with a custom
> command (wrapped by meson to capture output) [2391/2660] Generating
> drivers/rte_bus_fslmc.sym_chk with a custom command (wrapped by
> meson to capture output) [2392/2660] Generating lib/pipeline.sym_chk with
> a custom command (wrapped by meson to capture output) [2393/2660]
> Generating lib/ethdev.sym_chk with a custom command (wrapped by
> meson to capture output) [2394/2660] Generating lib/eal.sym_chk with a
> custom command (wrapped by meson to capture output) [2395/2660]
> Generating drivers/rte_common_sfc_efx.sym_chk with a custom command
> (wrapped by meson to capture output) [2396/2660] Generating
> drivers/rte_common_cnxk.sym_chk with a custom command (wrapped by
> meson to capture output)
> ninja: build stopped: subcommand failed.
