RE: 22.11.3 patches review and test

2023-08-30 Thread Xueming(Steven) Li
> -Original Message- > From: Xu, HailinX > Sent: 8/31/2023 9:50 > To: Xueming(Steven) Li ; sta...@dpdk.org > Cc: xuemi...@nvdia.com; dev@dpdk.org; Abhishek Marathe > ; Ali Alnubani ; > Walker, Benjamin ; David Christensen > ; Hemant Agrawal ; > Stokes, Ian ; Jerin Jacob ; > Mcnamara, Joh

RE: [PATCH v2 1/2] ethdev: add new symmetric hash function

2023-08-30 Thread Xueming(Steven) Li
> -Original Message- > From: lihuisong (C) > Sent: 8/31/2023 9:24 > To: Xueming(Steven) Li ; Ori Kam > Cc: dev@dpdk.org; fengcheng...@huawei.com; Ivan Malov > > Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function > > > 在 2023/8/30 21:09, Xueming(Steven) Li 写道: > > > >

[PATCH v4 2/2] dma/cnxk: rewrite DMA fastpath

2023-08-30 Thread pbhagavatula
From: Pavan Nikhilesh Rewrite DMA fastpath to use NEON instructions and reduce number of words read from config. Signed-off-by: Pavan Nikhilesh --- drivers/dma/cnxk/cnxk_dmadev.c| 454 +++-- drivers/dma/cnxk/cnxk_dmadev.h| 89 +- drivers/dma/cnxk/cnxk_dmade

[PATCH v4 1/2] dma/cnxk: use mempool for DMA chunk pool

2023-08-30 Thread pbhagavatula
From: Pavan Nikhilesh Use rte_mempool for DMA chunk pool to allow using mempool cache. Signed-off-by: Pavan Nikhilesh --- Depends-on: 29324 v4 Changes: - Fix clang build. v3 Changes: - Fix build. drivers/common/cnxk/roc_dpi.c | 95 + drivers/common/cnxk/roc

RE: 22.11.3 patches review and test

2023-08-30 Thread Xu, HailinX
> -Original Message- > From: Xueming(Steven) Li > Sent: Tuesday, August 29, 2023 4:56 PM > To: Xu, HailinX ; sta...@dpdk.org; Kevin Traynor > > Cc: xuemi...@nvdia.com; dev@dpdk.org; Abhishek Marathe > ; Ali Alnubani ; > Walker, Benjamin ; David Christensen > ; Hemant Agrawal ; > Stokes, I

Re: [PATCH v2 1/2] ethdev: add new symmetric hash function

2023-08-30 Thread lihuisong (C)
在 2023/8/30 21:09, Xueming(Steven) Li 写道: -Original Message- From: lihuisong (C) Sent: 8/30/2023 20:42 To: Xueming(Steven) Li ; Ori Kam Cc: dev@dpdk.org; fengcheng...@huawei.com; Ivan Malov Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function 在 2023/8/30 16:38, Xue

Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

2023-08-30 Thread Ajit Khaparde
On Wed, Aug 30, 2023 at 4:46 AM Thomas Monjalon wrote: > > Hello, > > Thanks for bringing a new capability. > > 26/08/2023 09:46, Jie Hai: > > Currently, rte_eth_rss_conf supports configuring and querying > > rss hash functions, rss key and it's length, but not rss hash > > algorithm. > > > > The

Re: [PATCH v5 3/3] power: amd power monitor support

2023-08-30 Thread Konstantin Ananyev
25/08/2023 17:00, Tyler Retzlaff пишет: On Thu, Aug 24, 2023 at 10:04:42AM +0100, Ferruh Yigit wrote: On 8/23/2023 5:03 PM, Tyler Retzlaff wrote: On Wed, Aug 23, 2023 at 10:19:39AM +0100, Ferruh Yigit wrote: On 8/22/2023 11:30 PM, Konstantin Ananyev wrote: 18/08/2023 14:48, Bruce Richardson п

RE: [PATCH v1] maintainers: update maintainer for DLB Driver

2023-08-30 Thread Sevincer, Abdullah
Sorry folks this has been waiting for long. I heard Tim is retiring. Will it be okay to get ack from Bruce? -Original Message- From: Sevincer, Abdullah Sent: Monday, July 10, 2023 12:52 PM To: Thomas Monjalon Cc: dev@dpdk.org; jer...@marvell.com; Richardson, Bruce Subject: RE: [PATCH

Re: [PATCH] eal: fix memory initialization deadlock

2023-08-30 Thread Dmitry Kozlyuk
2023-08-30 13:33 (UTC+0300), Artemy Kovalyov: > Following these changes, the RW-lock no longer supports > recursion, implying that a single thread shouldn't obtain a read lock if > it already possesses one. The problem arises during initialization: the > rte_eal_init() function acquires the memory_

RE: [EXT] Re: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch

2023-08-30 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, 30 August 2023 18.24 > > 21/08/2023 16:46, Morten Brørup: > > > From: Ankur Dwivedi [mailto:adwiv...@marvell.com] > > > Sent: Monday, 21 August 2023 15.54 > > > > > > >From: Stephen Hemminger > > > >Sent: Thursday, May 18, 20

Re: [PATCH 00/32] Remove use and definition of RTE_STD_C11 macro

2023-08-30 Thread Thomas Monjalon
12/08/2023 00:22, Tyler Retzlaff: > We now document C11 conformant compiler as a minimum, it's not necessary > to mark C11 feature use with __extension__ to avoid warnings. Did you check the occurences of __extension__? I remember at least the case of bit-fields. Is there any C standard allowing t

[PATCH v3 2/2] dma/cnxk: rewrite DMA fastpath

2023-08-30 Thread pbhagavatula
From: Pavan Nikhilesh Rewrite DMA fastpath to use NEON instructions and reduce number of words read from config. Signed-off-by: Pavan Nikhilesh --- drivers/dma/cnxk/cnxk_dmadev.c| 454 +++-- drivers/dma/cnxk/cnxk_dmadev.h| 89 +- drivers/dma/cnxk/cnxk_dmade

[PATCH v3 1/2] dma/cnxk: use mempool for DMA chunk pool

2023-08-30 Thread pbhagavatula
From: Pavan Nikhilesh Use rte_mempool for DMA chunk pool to allow using mempool cache. Signed-off-by: Pavan Nikhilesh --- Depends-on: 29324 v3 Changes: - Fix build drivers/common/cnxk/roc_dpi.c | 95 + drivers/common/cnxk/roc_dpi.h | 28 +--- drivers

Re: [PATCH v2 00/13] Replace us of term abort

2023-08-30 Thread Thomas Monjalon
18/08/2023 19:45, Stephen Hemminger: > The term 'abort' is on the inclusive namin Tier 1 word list > as replace when possible. It is possible to do this across > DPDK except the few places that directly call the lib C abort() > function. > > v2 - drop changes to sfc since requires changes to base

[Bug 1281] Build failure with Meson 1.2.1 on Windows

2023-08-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1281 Bug ID: 1281 Summary: Build failure with Meson 1.2.1 on Windows Product: DPDK Version: unspecified Hardware: All OS: Windows Status: UNCONFIRMED Severity: normal

RE: [PATCH v11 01/16] eal: use rdtsc intrinsic

2023-08-30 Thread Ali Alnubani
> -Original Message- > From: Ali Alnubani > Sent: Wednesday, August 30, 2023 6:49 PM > To: 'Tyler Retzlaff' > Cc: 'David Marchand' ; 'dev@dpdk.org' > ; 'Bruce Richardson' ; > 'Konstantin Ananyev' ; 'Ciara Power' > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; 'm...@smartsharesystems.com' >

Re: [PATCH v5 1/8] net/rnp: add skeleton

2023-08-30 Thread Thomas Monjalon
21/08/2023 11:32, 11: > Hi Thomas, > > Thanks for your useful advice, previously only focused on code format > and Ignored document format. no worries > > > +#. Running testpmd: > > > + > > > + Follow instructions available in the document > > > + :ref:`compiling and testing a PMD for a NIC

Re: 22.11.3 patches review and test

2023-08-30 Thread Kevin Traynor
On 29/08/2023 09:22, Xu, HailinX wrote: -Original Message- From: Xueming Li Sent: Thursday, August 17, 2023 2:14 PM To: sta...@dpdk.org Cc: xuemi...@nvdia.com; dev@dpdk.org; Abhishek Marathe ; Ali Alnubani ; Walker, Benjamin ; David Christensen ; Hemant Agrawal ; Stokes, Ian ; Jerin Jaco

Re: [EXT] Re: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch

2023-08-30 Thread Thomas Monjalon
21/08/2023 16:46, Morten Brørup: > > From: Ankur Dwivedi [mailto:adwiv...@marvell.com] > > Sent: Monday, 21 August 2023 15.54 > > > > >From: Stephen Hemminger > > >Sent: Thursday, May 18, 2023 9:04 PM > > > > > >-- > > >On Thu, 1

Re: [PATCH] app: fix silent enqueue fail in test_mbuf test_refcnt_iter

2023-08-30 Thread Thomas Monjalon
Hello, 22/08/2023 08:34, jhascoet: > From: Julien Hascoet > > In case of ring full state, we retry the enqueue > operation in order to avoid mbuf loss. > > Fixes: af75078fece ("first public release") > > Signed-off-by: Julien Hascoet Please could you give more information about when this is

[PATCH 4/4] net/iavf: add support for runtime queue reconfiguration

2023-08-30 Thread Bruce Richardson
Unlike the i40e driver, the iavf driver does not advertise support for runtime reconfiguration, meaning that application using the same hardware may get different behaviour when using a PF vs a VF. On testing with a 40G NIC, the only blocker to reconfiguring an RX queue on the fly is the fact that

[PATCH 3/4] net/iavf: fix restart of Rx queue on reconfigure

2023-08-30 Thread Bruce Richardson
After reconfiguring an RX queue the mbuf_initializer value was not being correctly set. Fix this by calling the appropriate function if vector processing is enabled. This mirrors the behaviour by the i40e driver. Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx") Cc: jingjing...@intel.com Cc: sta..

[PATCH 2/4] net/iavf: fix buffer leak on Tx queue stop

2023-08-30 Thread Bruce Richardson
When a queue is stopped all buffers are meant to released from it, and then a new set of buffers reallocated on start. For the iavf code when using vector Tx, some buffers were left in the ring, and so those buffers were leaked. The buffers were missed as the release code only handled one side of a

[PATCH v1 34/34] ml/cnxk: enable creation of mvtvm virtual device

2023-08-30 Thread Srikanth Yalavarthi
Enable support to create a mvtvm virtual device on system's without a PCI based ML HW accelerator. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 8 ++ drivers/ml/cnxk/cn10k_ml_dev.h | 3 + drivers/ml/cnxk/cnxk_ml_dev.c | 3 + drivers/ml/cnxk/cnxk_ml_dev.h | 21

[PATCH v1 30/34] ml/cnxk: implement I/O alloc and free callbacks

2023-08-30 Thread Srikanth Yalavarthi
Implemented callback functions for IO allocation and free for Glow layers. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 123 + drivers/ml/cnxk/cn10k_ml_ops.h | 3 + drivers/ml/cnxk/mvtvm_ml_ops.c | 2 + 3 files changed, 128 insertion

[PATCH v1 33/34] ml/cnxk: enable fast-path ops for TVM models

2023-08-30 Thread Srikanth Yalavarthi
From: Anup Prabhu Enable fast-path ops support for TVM models. Models would use TVMDP library function calls to execute inference operations for Hybrid and LLVM model sub-types. For TVM MRVL model subtypes that have a single MRVL layer, the inference requests are directly enqueued to hardware by

[PATCH 1/4] net/i40e: fix buffer leak on Rx reconfiguration

2023-08-30 Thread Bruce Richardson
When reconfiguring a single queue on a device, the mbuf initializer value was not getting set, and remained at zero. This lead to mbuf leaks as the refcount was incorrect (0), so on free it wrapped around to UINT16_MAX. When setting up the mbuf initializer, also ensure that the queue is explicitly

[PATCH v1 32/34] ml/cnxk: support quantize and dequantize callback

2023-08-30 Thread Srikanth Yalavarthi
From: Prince Takkar Added support for quantize and dequantize callback functions for TVM models. Signed-off-by: Prince Takkar --- drivers/ml/cnxk/meson.build | 5 ++ drivers/ml/cnxk/mvtvm_ml_model.h | 2 + drivers/ml/cnxk/mvtvm_ml_ops.c | 127 +++ drivers

[PATCH v1 29/34] ml/cnxk: enable reporting model runtime as xstats

2023-08-30 Thread Srikanth Yalavarthi
Added model xstats entries to compute runtime latency. Allocated internal resources for TVM model xstats. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cnxk_ml_ops.c| 182 --- drivers/ml/cnxk/cnxk_ml_ops.h| 1 + drivers/ml/cnxk/cnxk_ml_xstats.h |

[PATCH v1 31/34] ml/cnxk: add generic ML malloc and free callback

2023-08-30 Thread Srikanth Yalavarthi
Implemented generic ML malloc and free callbacks Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 30 ++ drivers/ml/cnxk/cn10k_ml_ops.h | 3 +++ drivers/ml/cnxk/mvtvm_ml_ops.c | 2 ++ 3 files changed, 35 insertions(+) diff --git a/drivers/ml/

[PATCH v1 28/34] ml/cnxk: support device dump for TVM models

2023-08-30 Thread Srikanth Yalavarthi
Enabled support to print TVM model layer info. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cnxk_ml_model.c | 9 - drivers/ml/cnxk/cnxk_ml_ops.c| 1 + drivers/ml/cnxk/mvtvm_ml_model.c | 59 drivers/ml/cnxk/mvtvm_ml_model.h | 2 ++ 4 files ch

[PATCH v1 27/34] ml/cnxk: update internal TVM model info structure

2023-08-30 Thread Srikanth Yalavarthi
From: Prince Takkar Added support to update internal model info structure for TVM models. Signed-off-by: Prince Takkar Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/mvtvm_ml_model.c | 65 drivers/ml/cnxk/mvtvm_ml_model.h | 2 + drivers/ml/cnxk/mvtvm_

[PATCH v1 26/34] ml/cnxk: support start and stop for TVM models

2023-08-30 Thread Srikanth Yalavarthi
Added support to start and stop TVM models. TVM model start would invoke layer start for all Glow layers part of the model. TVM model stop would invoke layer stop for all Glow layers part of the model. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cn10k_ml_op

[PATCH v1 22/34] ml/cnxk: add support to parse TVM model objects

2023-08-30 Thread Srikanth Yalavarthi
Added support to parse TVM model objects from the model archive buffer. Added support to check for all expected objects and copy TVM model objects to internal buffers. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cnxk_ml_ops.c| 14 +-- drivers/ml/cnx

[PATCH v1 25/34] ml/cnxk: enable model unload in tvmdp library

2023-08-30 Thread Srikanth Yalavarthi
Enable unloading model using external tvmdp library. Updated layer unload callback to support multiple layers. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cn10k_ml_ops.c | 20 drivers/ml/cnxk/cnxk_ml_ops.c | 9 +++-- drivers/ml/cn

[PATCH v1 20/34] ml/cnxk: add structures to support TVM model type

2023-08-30 Thread Srikanth Yalavarthi
Introduced model type, sub-type and layer type. Added internal structures for TVM model objects. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ocm.c | 3 ++ drivers/ml/cnxk/cn10k_ml_ops.c | 6 ++- drivers/ml/cnxk/cnxk_ml_model.h | 63 +++- dri

[PATCH v1 24/34] ml/cnxk: update internal info for TVM model

2023-08-30 Thread Srikanth Yalavarthi
Enabled updating internal IO info structures for TVM model. Compute static fields related to the model I/O. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/mvtvm_ml_model.c | 105 +++ drivers/ml/cnxk/mvtvm_ml_model.h | 1 + drivers/ml/cnxk/mvtvm_ml_ops.c |

[PATCH v1 19/34] ml/cnxk: support config and close of tvmdp library

2023-08-30 Thread Srikanth Yalavarthi
Added support to configure and close TVMDP library based on ML device configuration options. Updated meson build to enable Jansson, TVM runtime, TVMDP library as build dependencies. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cnxk_ml_ops.c | 15 drivers/ml/cnxk/meson.bu

[PATCH v1 23/34] ml/cnxk: fetch layer info and load TVM model

2023-08-30 Thread Srikanth Yalavarthi
Added support to fetch TVM model layer information and update internal structures based on the layer information Set callback functions for layer load and unload and enable model loading using TVMDP library. Added support to fetch full metadata after model load. Signed-off-by: Srikanth Yalavarthi

[PATCH 0/4] Fix i40e/iavf queue reconfig and restarting

2023-08-30 Thread Bruce Richardson
Fixes for a number of issues found when looking at stopping and restarting individual queues, sometimes with a reconfig in the middle. For i40e, it already claims to support runtime reconfig, while for iavf this support is not claimed, but appears to work ok once the bugs in the cleanup code are fi

[PATCH v1 18/34] ml/cnxk: move error handling to cnxk layer

2023-08-30 Thread Srikanth Yalavarthi
Move error type structures to cnxk layer. cn10k layer to handle fw and hw error sub-types only. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 41 ++- drivers/ml/cnxk/cn10k_ml_ops.c | 93 +- drivers/ml/cnxk/cnxk_ml_dev.c | 8

[PATCH v1 21/34] ml/cnxk: add support for identify model type

2023-08-30 Thread Srikanth Yalavarthi
Enable support to parse model buffer to identify the model type and model sub-type. Enabled basic checks for Glow model type buffer. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cnxk_ml_model.c | 96 drivers/ml/cnxk/cnxk_ml_

[PATCH v1 17/34] ml/cnxk: update fast path functions

2023-08-30 Thread Srikanth Yalavarthi
Implemented cnxk layer fast-path functions and added support for model specific fast-path functions. CNXK layer functions would invoke model specific fast-path functions. Added support for model specific poll handling functions and updated internal inference sync function. Drop use of rte_ml_op as

[PATCH v1 16/34] ml/cnxk: update device and model xstats functions

2023-08-30 Thread Srikanth Yalavarthi
Added cnxk wrapper function to handle ML device and model extended stats. Handling resources for the xstats is done in the cnxk layer. Introduced internal xstats group. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 4 - drivers/ml/cnxk/cn10k_ml_ops.c | 542 +--

[PATCH v1 15/34] ml/cnxk: update device stats functions

2023-08-30 Thread Srikanth Yalavarthi
Added cnxk wrapper function to handle ML device stats Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 32 -- drivers/ml/cnxk/cn10k_ml_ops.h | 2 -- drivers/ml/cnxk/cnxk_ml_ops.c | 36 -- 3 files changed, 34 ins

[PATCH v1 14/34] ml/cnxk: update device debug functions

2023-08-30 Thread Srikanth Yalavarthi
Added cnxk wrapper for device dump and selftest debug functions. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_model.c | 118 + drivers/ml/cnxk/cn10k_ml_model.h | 1 + drivers/ml/cnxk/cn10k_ml_ocm.c | 8 +- drivers/ml/cnxk/cn10k_ml_ocm.h | 2 +- dr

[PATCH v1 11/34] ml/cnxk: update model start and stop functions

2023-08-30 Thread Srikanth Yalavarthi
Implemented cnxk wrapper functions to start and stop ML models. Wrapper functions would invoke the cn10k model start and stop functions. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ocm.c | 28 ++-- drivers/ml/cnxk/cn10k_ml_ocm.h | 12 +- drivers/ml/cnxk/cn10k_ml_ops.c | 282

[PATCH v1 09/34] ml/cnxk: update queue-pair handling functions

2023-08-30 Thread Srikanth Yalavarthi
Added cnxk wrapper function to handle ML device queue-pairs. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 135 + drivers/ml/cnxk/cn10k_ml_ops.h | 7 +- drivers/ml/cnxk/cnxk_ml_ops.c | 153 - drivers/ml/cnxk

[PATCH v1 13/34] ml/cnxk: update data quantization functions

2023-08-30 Thread Srikanth Yalavarthi
Added cnxk wrapper functions to quantize input data and dequantize output data. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 164 - drivers/ml/cnxk/cn10k_ml_ops.h | 7 -- drivers/ml/cnxk/cnxk_ml_io.c | 95 +++ driver

[PATCH v1 12/34] ml/cnxk: update model utility functions

2023-08-30 Thread Srikanth Yalavarthi
Added cnxk wrapper function to update model params and fetch model info. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 38 ++- drivers/ml/cnxk/cn10k_ml_ops.h | 5 ++-- drivers/ml/cnxk/cnxk_ml_ops.c | 48 -- 3 fil

[PATCH v1 07/34] ml/cnxk: rename cnxk ops function pointers struct

2023-08-30 Thread Srikanth Yalavarthi
Renamed cn10k ML ops structure with cnxk prefix. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 2 +- drivers/ml/cnxk/cn10k_ml_ops.c | 73 +- drivers/ml/cnxk/cn10k_ml_ops.h | 34 +++- drivers/ml/cnxk/cnxk_ml_ops.c | 38 ++

[PATCH v1 10/34] ml/cnxk: update model load and unload functions

2023-08-30 Thread Srikanth Yalavarthi
Implemented cnxk wrapper functions to load and unload ML models. Wrapper functions would invoke the cn10k model load and unload functions. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_model.c | 239 - drivers/ml/cnxk/cn10k_ml_model.h | 25 +-- drivers/

[PATCH v1 06/34] ml/cnxk: add generic cnxk xstats structures

2023-08-30 Thread Srikanth Yalavarthi
Introduced generic xstats structures and renamed cn10k xstats enumerations with cnxk prefix. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 86 +--- drivers/ml/cnxk/cn10k_ml_model.h | 6 +- drivers/ml/cnxk/cn10k_ml_ops.c | 169 ++---

[PATCH v1 05/34] ml/cnxk: add generic cnxk request structure

2023-08-30 Thread Srikanth Yalavarthi
Added generic cnxk request structure. Moved common fields from cn10k structures to cnxk structure. Moved job related structures and enumerations to ops headers. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 70 --- drivers/ml/cnxk/cn10k_ml_dev.h | 269 +

[PATCH v1 08/34] ml/cnxk: update device handling functions

2023-08-30 Thread Srikanth Yalavarthi
Implement CNXK wrapper functions for dev_info_get, dev_configure, dev_close, dev_start and dev_stop. The wrapper functions allocate / release common resources for the ML driver and invoke device specific functions. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 230 ++---

[PATCH v1 04/34] ml/cnxk: add generic model and layer structures

2023-08-30 Thread Srikanth Yalavarthi
Introduce generic cnxk model and layer structure. These structures would enable supporting models with multiple layers. A model is a collection of multiple independent layers with flow dependencies between the layers. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 9

[PATCH v1 03/34] ml/cnxk: add generic cnxk device structure

2023-08-30 Thread Srikanth Yalavarthi
Introduce generic cnxk device structure. This structure is a top level device structure for the driver, which would encapsulate the target / platform specific device structure. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 315 ++-- drivers/ml/cnxk/cn1

[PATCH v1 02/34] ml/cnxk: drop use of RTE API for firmware read

2023-08-30 Thread Srikanth Yalavarthi
Dropped use of rte_firmware_read API to read ML firmware binary. When DPDK is built with libarchive aaupport, the the RTE API assumes the binary file as a compressed archive. This causes the ML firmware binary to be parsed incorrectly. Fixes: c29da752ffa8 ("ml/cnxk: support firmware load and devic

[PATCH v1 01/34] ml/cnxk: drop support for register polling

2023-08-30 Thread Srikanth Yalavarthi
Dropped support for device argument "poll_mem" for cnxk ML driver. Support to use registers for polling is removed and DDR addresses would be used for polling. Signed-off-by: Srikanth Yalavarthi --- Depends-on: series-29375 ("Spec changes to support multi I/O models") doc/guides/mldevs/cnxk.rst

[PATCH v1 00/34] Implemenation of revised ml/cnxk driver

2023-08-30 Thread Srikanth Yalavarthi
This patch series is an implementation of revised ml/cnxk driver to support models compiled with TVM compiler framework. TVM models use a hybrid mode for execution, with regions of the model executing on the ML accelerator and the rest executing on CPU cores. This series of commits reorganizes the

[PATCH v1 3/3] mldev: drop input and output size get APIs

2023-08-30 Thread Srikanth Yalavarthi
Drop support and use of ML input and output size get functions, rte_ml_io_input_size_get and rte_ml_io_output_size_get. These functions are not required, as the model buffer size can be computed from the fields of updated rte_ml_io_info structure. Signed-off-by: Srikanth Yalavarthi --- drivers/

[PATCH v1 2/3] mldev: introduce support for IO layout

2023-08-30 Thread Srikanth Yalavarthi
Introduce IO layout in ML device specification. IO layout defines the expected arrangement of model input and output buffers in the memory. Packed and Split layout support is added in the specification. Updated rte_ml_op to support array of rte_ml_buff_seg pointers to support packed and split I/O

[PATCH v1 1/3] mldev: add support for arbitrary shape dimensions

2023-08-30 Thread Srikanth Yalavarthi
Updated rte_ml_io_info to support shape of arbitrary number of dimensions. Dropped use of rte_ml_io_shape and rte_ml_io_format. Introduced new fields nb_elements and size in rte_ml_io_info. Updated drivers and app/mldev to support the changes. Signed-off-by: Srikanth Yalavarthi --- app/test-mld

[PATCH v1 0/3] Spec changes to support multi I/O models

2023-08-30 Thread Srikanth Yalavarthi
This series implements changes to mldev spec to extend support for ML models with multiple inputs and outputs. Changes include introduction of I/O layout to support packed and split buffers for model input and output. Extended the rte_ml_model_info structure to support multiple inputs and outputs.

[PATCH v1 1/1] app/mldev: updates to device ops test

2023-08-30 Thread Srikanth Yalavarthi
Updated device_ops test to configure the device with user specific arguments. Fix handling unsupported values for queue_pairs and queue_size Fixes: c0e871657d6a ("app/mldev: support queue pairs and size") Cc: sta...@dpdk.org Signed-off-by: Srikanth Yalavarthi --- app/test-mldev/test_common.c

[PATCH v1 1/1] app/mldev: fix check for filelist and models count

2023-08-30 Thread Srikanth Yalavarthi
Fix incorrect check for filelist and models count. Fixes: bbd272edcb14 ("app/mldev: add ordered inferences") Fixes: f6661e6d9a3a ("app/mldev: validate model operations") Cc: sta...@dpdk.org Signed-off-by: Srikanth Yalavarthi --- app/test-mldev/ml_options.c | 4 ++-- 1 file changed, 2 insertions

[PATCH v1 1/1] app/mldev: report device not found as error

2023-08-30 Thread Srikanth Yalavarthi
Report ML device not found as error, instead of panic. Signed-off-by: Srikanth Yalavarthi --- app/test-mldev/ml_main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-mldev/ml_main.c b/app/test-mldev/ml_main.c index 940e609c9a8..56941b1afb0 100644 --- a/app/tes

RE: [PATCH v11 01/16] eal: use rdtsc intrinsic

2023-08-30 Thread Ali Alnubani
> -Original Message- > From: Ali Alnubani > Sent: Wednesday, August 30, 2023 4:38 PM > To: Tyler Retzlaff > Cc: David Marchand ; dev@dpdk.org; Bruce > Richardson ; Konstantin Ananyev > ; Ciara Power ; > NBU-Contact-Thomas Monjalon (EXTERNAL) ; > m...@smartsharesystems.com > Subject: RE: [

[PATCH v2 2/2] dma/cnxk: rewrite DMA fastpath

2023-08-30 Thread pbhagavatula
From: Pavan Nikhilesh Rewrite DMA fastpath to use NEON instructions and reduce number of words read from config. Signed-off-by: Pavan Nikhilesh --- drivers/dma/cnxk/cnxk_dmadev.c| 454 +++-- drivers/dma/cnxk/cnxk_dmadev.h| 89 +- drivers/dma/cnxk/cnxk_dmade

[PATCH v2 1/2] dma/cnxk: use mempool for DMA chunk pool

2023-08-30 Thread pbhagavatula
From: Pavan Nikhilesh Use rte_mempool for DMA chunk pool to allow using mempool cache. Signed-off-by: Pavan Nikhilesh --- Depends-on: 29324 drivers/common/cnxk/roc_dpi.c | 95 + drivers/common/cnxk/roc_dpi.h | 28 +--- drivers/common/cnxk/roc_dpi_priv.h

Re: CI Testing Automated Recheck Request Framework

2023-08-30 Thread Thomas Monjalon
30/08/2023 15:21, Patrick Robb: > On Wed, Aug 30, 2023 at 8:18 AM Thomas Monjalon wrote: > > > Thank you, it will help a lot. > > > > How/Where are we going to document this? > > Maybe in the "Testing" web page? > > https://core.dpdk.org/testing/ > > > > > I agree that that is the best place for

RE: [PATCH v11 01/16] eal: use rdtsc intrinsic

2023-08-30 Thread Ali Alnubani
> -Original Message- > From: Tyler Retzlaff > Sent: Tuesday, August 29, 2023 7:16 PM > To: Ali Alnubani > Cc: David Marchand ; dev@dpdk.org; Bruce > Richardson ; Konstantin Ananyev > ; Ciara Power ; > NBU-Contact-Thomas Monjalon (EXTERNAL) ; > m...@smartsharesystems.com > Subject: Re: [PA

Re: CI Testing Automated Recheck Request Framework

2023-08-30 Thread Patrick Robb
On Wed, Aug 30, 2023 at 8:18 AM Thomas Monjalon wrote: > Thank you, it will help a lot. > > How/Where are we going to document this? > Maybe in the "Testing" web page? > https://core.dpdk.org/testing/ > > I agree that that is the best place for it. We can submit a patch adding the instructions to

RE: [PATCH v2 1/2] ethdev: add new symmetric hash function

2023-08-30 Thread Xueming(Steven) Li
> -Original Message- > From: lihuisong (C) > Sent: 8/30/2023 20:42 > To: Xueming(Steven) Li ; Ori Kam > Cc: dev@dpdk.org; fengcheng...@huawei.com; Ivan Malov > > Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function > > > 在 2023/8/30 16:38, Xueming(Steven) Li 写道: > > >

Re: [PATCH v2 1/2] ethdev: add new symmetric hash function

2023-08-30 Thread lihuisong (C)
在 2023/8/30 16:38, Xueming(Steven) Li 写道: -Original Message- From: lihuisong (C) Sent: 8/30/2023 15:51 To: Xueming(Steven) Li ; Ori Kam Cc: dev@dpdk.org; fengcheng...@huawei.com; Ivan Malov Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function Hi Xueming, 在 2023/8/2

RE: [PATCH] net/mlx5: fix leak in sysfs port name translation

2023-08-30 Thread Raslan Darawsheh
Hi, > -Original Message- > From: David Marchand > Sent: Tuesday, August 1, 2023 6:19 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Bing Zhao > Subject: [PATCH] net/mlx5: fix leak in sysfs port name translation > > getline() may

RE: [PATCH] net/mlx5/hws: add support for multi pattern

2023-08-30 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alex Vesker > Sent: Sunday, July 9, 2023 5:20 PM > To: Alex Vesker ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Suanming Mou ; Matan > Azrad ; Ori Kam > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5/hws: add support for multi pattern >

Re: CI Testing Automated Recheck Request Framework

2023-08-30 Thread Thomas Monjalon
Thank you, it will help a lot. How/Where are we going to document this? Maybe in the "Testing" web page? https://core.dpdk.org/testing/ 25/08/2023 16:51, Adam Hassick: > Hello DPDK developers, > > Currently, various testing labs perform CI testing on new patch series sent > to dev@dpdk.org and

Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

2023-08-30 Thread Thomas Monjalon
Hello, Thanks for bringing a new capability. 26/08/2023 09:46, Jie Hai: > Currently, rte_eth_rss_conf supports configuring and querying > rss hash functions, rss key and it's length, but not rss hash > algorithm. > > The structure ``rte_eth_rss_conf`` is extended by adding a new > field "func".

Re: [PATCH v3] doc: build manpages as well as html output

2023-08-30 Thread Thomas Monjalon
30/08/2023 12:20, Bruce Richardson: > On Wed, Aug 30, 2023 at 11:47:00AM +0200, Thomas Monjalon wrote: > > 29/08/2023 12:10, Bruce Richardson: > > > On Tue, Aug 29, 2023 at 11:28:01AM +0200, Thomas Monjalon wrote: > > > > 3/08/2023, Bruce Richardson: > > > > > +meson.add_install_script(mandb) >

[PATCH] eal: fix memory initialization deadlock

2023-08-30 Thread Artemy Kovalyov
The issue arose due to the change in the DPDK read-write lock implementation. That change added a new flag, RTE_RWLOCK_WAIT, designed to prevent new read locks while a write lock is in the queue. However, this change has led to a scenario where a recursive read lock, where a lock is acquired twice

Re: [PATCH v3] doc: build manpages as well as html output

2023-08-30 Thread Bruce Richardson
On Wed, Aug 30, 2023 at 11:47:00AM +0200, Thomas Monjalon wrote: > 29/08/2023 12:10, Bruce Richardson: > > On Tue, Aug 29, 2023 at 11:28:01AM +0200, Thomas Monjalon wrote: > > > 3/08/2023, Bruce Richardson: > > > > +meson.add_install_script(mandb) > > > > > > When is it executed exactly? Will

RE: [PATCH v1] maintainers: take maintainership of AMD axgbe driver

2023-08-30 Thread Namburu, Chandu-babu
[Public] -Original Message- From: Selwin Sebastian Sent: Wednesday, August 30, 2023 2:32 PM To: dev@dpdk.org Cc: Sebastian, Selwin Subject: [PATCH v1] maintainers: take maintainership of AMD axgbe driver Chandu is not working on dpdk axgbe driver anymore. Signed-off-by: Selwin Sebastia

Re: [PATCH v3] doc: build manpages as well as html output

2023-08-30 Thread Thomas Monjalon
29/08/2023 12:10, Bruce Richardson: > On Tue, Aug 29, 2023 at 11:28:01AM +0200, Thomas Monjalon wrote: > > 3/08/2023, Bruce Richardson: > > > +meson.add_install_script(mandb) > > > > When is it executed exactly? > > Will it update the database in case we install in a staging directory, > > whe

[PATCH v2] vhost: avoid potential null pointer access

2023-08-30 Thread Li Feng
If the user calls rte_vhost_vring_call() on a ring that has been invalidated, we will encounter SEGV. We should check the pointer firstly before accessing it. Signed-off-by: Li Feng --- lib/vhost/vhost.c | 7 --- lib/vhost/vhost.h | 12 ++-- 2 files changed, 14 insertions(+), 5 del

[PATCH v1] maintainers: take maintainership of AMD axgbe driver

2023-08-30 Thread Selwin Sebastian
Chandu is not working on dpdk axgbe driver anymore. Signed-off-by: Selwin Sebastian --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 6b95da9ae3..1c40ad5665 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -644,7 +644,7 @@ F: doc/gui

Re: [PATCH] vhost: avoid potential null pointer access

2023-08-30 Thread Li Feng
Sorry, ignore this patch, there is a rebase error. I will fix it in V2. > On 30 Aug 2023, at 4:47 PM, Li Feng wrote: > > If the user calls rte_vhost_vring_call() on a ring that has been > invalidated, we will encounter SEGV. > > We should check the pointer firstly before accessing it. > > Sig

[PATCH] vhost: avoid potential null pointer access

2023-08-30 Thread Li Feng
If the user calls rte_vhost_vring_call() on a ring that has been invalidated, we will encounter SEGV. We should check the pointer firstly before accessing it. Signed-off-by: Li Feng --- lib/vhost/vhost.c | 7 --- lib/vhost/vhost.h | 12 ++-- 2 files changed, 14 insertions(+), 5 del

RE: [PATCH v2 1/2] ethdev: add new symmetric hash function

2023-08-30 Thread Xueming(Steven) Li
> -Original Message- > From: lihuisong (C) > Sent: 8/30/2023 15:51 > To: Xueming(Steven) Li ; Ori Kam > Cc: dev@dpdk.org; fengcheng...@huawei.com; Ivan Malov > > Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function > > Hi Xueming, > > 在 2023/8/27 16:17, Xueming Li 写道:

[PATCH 2/2] dma/cnxk: rewrite DMA fastpath

2023-08-30 Thread pbhagavatula
From: Pavan Nikhilesh Rewrite DMA fastpath to use NEON instructions and reduce number of words read from config. Signed-off-by: Pavan Nikhilesh --- drivers/dma/cnxk/cnxk_dmadev.c| 454 +++-- drivers/dma/cnxk/cnxk_dmadev.h| 89 +- drivers/dma/cnxk/cnxk_dmade

[PATCH 1/2] dma/cnxk: use mempool for DMA chunk pool

2023-08-30 Thread pbhagavatula
From: Pavan Nikhilesh Use rte_mempool for DMA chunk pool to allow using mempool cache. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/roc_dpi.c | 95 + drivers/common/cnxk/roc_dpi.h | 28 +--- drivers/common/cnxk/roc_dpi_priv.h | 3 - drivers/c

Re: [PATCH v2 1/2] ethdev: add new symmetric hash function

2023-08-30 Thread lihuisong (C)
Hi Xueming, 在 2023/8/27 16:17, Xueming Li 写道: The new symmetric hash function swap src/dst L3 address and L4 ports automatically by sorting. Signed-off-by: Xueming Li --- lib/ethdev/rte_flow.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_