Re: [PATCH v4] eal: non-temporal memcpy

On 2023-07-31 14:25, Morten Brørup wrote: From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Monday, 31 July 2023 14.14 Hello, What's the status of this feature? I haven't given up on upstreaming this feature, but there doesn't seem to be much demand for it, so working on it has low pr

RE: [PATCH v1] examples/l3fwd: relax the RSS/Offload requirement

HI Konstantin: I do understand your requirement on the SW support for the IPV4 cksum verification, and I think it really can be added here later some time when missing HW support. Anyway, there is a "warning:" message had been sent out to notify the user there is a lack of HW capability support

RE: [PATCH v1] event/dlb2: add support for disabling PASID

>+Is anybody looking into reworking this proposal and moving this code to the >pci bus driver? >+Cc: pci bus maintainers. >+-- >+David Marchand We will work on this proposal, it is not finalized yet. Its not DLB2 specific as commenters say, we are looking into if there is another way doing it

[PATCH v3] doc: build manpages as well as html output

Doxygen can produce manpage output as well as html output for the DPDK APIs. However, we need to do this as a separate task as the manpage output needs to be placed in a different location post-install to the html output (/usr/local/share/man vs /usr/local/share/doc/). Changes required are: * Add

Re: [PATCH v2] doc: build manpages as well as html output

On Thu, Aug 03, 2023 at 11:18:09AM +0200, David Marchand wrote: > On Mon, Jul 17, 2023 at 1:09 PM Bruce Richardson > wrote: > > > There may be some polishing to do later. > > > Looking at the result for rte_eal_init, I see that the generated > > > manual starts with a reference to the rte_eal.h he

Re: Drivers, architectures, processor families, etc.

> On Aug 2, 2023, at 4:47 PM, Stephen Hemminger > wrote: > > On Wed, 2 Aug 2023 15:49:54 -0600 > Philip Prindeville wrote: > >> Hi, >> >> I'm trying to come up with some Kconfig logic for OpenWRT packaging to help >> users select the right build options for their hardware. >> >> Most Ope

[PATCH] gpu/cuda: fix getenv related build error

If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1. This causes gdrcopy.c build to give an error; because compiler can not find signature of getenv. stdlib.h is included for the definition of getenv function. Fixes: ca12f5e8a7db ("gpu/cuda: mark unused GDRCopy functions parameter

Re: [PATCH] eal: remove RTE_FUNC_PTR_* deprecated macros

On Thu, Aug 03, 2023 at 11:41:18AM +0200, David Marchand wrote: > The RTE_FUNC_PTR_OR_* macros were marked as deprecated in v22.11, we can > remove them. > > Signed-off-by: David Marchand > --- Acked-by: Tyler Retzlaff

RE: [PATCH] eal: remove RTE_FUNC_PTR_* deprecated macros

> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, 3 August 2023 11.41 > > The RTE_FUNC_PTR_OR_* macros were marked as deprecated in v22.11, we can > remove them. > > Signed-off-by: David Marchand > --- Acked-by: Morten Brørup

RE: [PATCH] ethdev: introduce generic flow item and action

> From: Zhang, Qi Z [mailto:qi.z.zh...@intel.com] > Sent: Thursday, 3 August 2023 03.05 > > > From: Morten Brørup > > Sent: Thursday, August 3, 2023 1:56 AM > > > > > From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > > > Sent: Wednesday, 2 August 2023 19.23 > > > > > > > From: O

Re: [PATCH v5] build: update DPDK to use C11 standard

On Wed, Aug 2, 2023 at 2:32 PM Bruce Richardson wrote: > > As previously announced, DPDK 23.11 will require a C11 supporting > compiler and will use the C11 standard in all builds. > > Forcing use of the C standard, rather than the standard with > GNU extensions, means that some posix definitions

[RFC] ethdev: add calcualte hash function

rte_flow supports insert by index table[1]. Using the above table, the application can create rules that are based on hash. For example application can create the following logic in order to create load balancing: 1. Create insert by index table with 2 rules, that hashes based on dmac 2. Insert to

Re: [Question/Issue] pkgconfig does not include dpdk/drivers libs

On Thu, Aug 03, 2023 at 12:51:36PM +, Abhineet Pandey wrote: >Hi Bruce, >Thanks for taking a look at this. >Talking about the issues you pointed, >1. Absense of -lrte_bus_pci and similar flags >Even if I don’t give –static flag, I don’t see -lrte_bus_pci (and >-lrte_bus_

Re: [Question/Issue] pkgconfig does not include dpdk/drivers libs

Hi Bruce, Thanks for taking a look at this. Talking about the issues you pointed, 1. Absense of -lrte_bus_pci and similar flags Even if I don’t give –static flag, I don’t see -lrte_bus_pci (and -lrte_bus_vdev, -lrte_mempool_ring). Attaching output, PKG_CONFIG_PATH=dpdk/build/lib/pkgconfig pkg-co

RE: [PATCH v5] build: update DPDK to use C11 standard

> -Original Message- > From: Bruce Richardson > Sent: Wednesday, August 2, 2023 3:32 PM > To: dev@dpdk.org > Cc: Bruce Richardson ; Morten Brørup > ; Tyler Retzlaff > > Subject: [PATCH v5] build: update DPDK to use C11 standard > > As previously announced, DPDK 23.11 will require a C11 s

Re: [PATCH 06/14] pci: define some command constants

On Thu, Aug 3, 2023 at 11:58 AM Bruce Richardson wrote: > > On Thu, Aug 03, 2023 at 09:50:29AM +0200, David Marchand wrote: > > Define some PCI command constants and use them in existing drivers. > > > > Signed-off-by: David Marchand > > --- > > For the idea, all good, but for the implementation,

Re: [PATCH 02/14] bus/pci: add const to some experimental API

On Thu, Aug 3, 2023 at 11:47 AM Bruce Richardson wrote: > > On Thu, Aug 03, 2023 at 09:50:25AM +0200, David Marchand wrote: > > Those functions are fine with a const on the device pointer. > > > > Signed-off-by: David Marchand > > --- > > drivers/bus/pci/pci_common.c | 4 ++-- > > drivers/bus/p

Re: [PATCH 03/14] bus/pci: find PCI capability

On Thu, Aug 3, 2023 at 11:53 AM Bruce Richardson wrote: > > On Thu, Aug 03, 2023 at 10:49:54AM +0100, Bruce Richardson wrote: > > On Thu, Aug 03, 2023 at 09:50:26AM +0200, David Marchand wrote: > > > Introduce two helpers so that drivers stop reinventing the wheel. > > > Use it in existing drivers

Re: [Question/Issue] pkgconfig does not include dpdk/drivers libs

On Thu, Aug 03, 2023 at 09:15:11AM +, Abhineet Pandey wrote: >I’m consuming dpdk via spdk. >I was trying to use pkg-config for a Makefile that I’m writing, >Executing: > >PKG_CONFIG_PATH=dpdk/build/lib/pkgconfig pkg-config --libs --static >libdpdk >Output: >-Wl,--wh

Re: [PATCH 00/14] Cleanup PCI(e) drivers

On Thu, Aug 03, 2023 at 09:50:23AM +0200, David Marchand wrote: > Rather than rely on Linux headers to find some PCI(e) standard constants > or reinvent the same PCI capability helper, this series complements the > pci library and the pci bus driver. > PCI drivers can then use OS agnostic macros an

Re: [PATCH 09/14] pci: define some PCIe constants

On Thu, Aug 03, 2023 at 09:50:32AM +0200, David Marchand wrote: > Define some PCI Express constants and use them in existing drivers. > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson

Re: [PATCH 08/14] pci: define some PM constants

On Thu, Aug 03, 2023 at 09:50:31AM +0200, David Marchand wrote: > Define some PCI Power Management constants and use them in existing > drivers. > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson

Re: [PATCH 07/14] pci: define some BAR constants

On Thu, Aug 03, 2023 at 09:50:30AM +0200, David Marchand wrote: > Define some PCI BAR constants and use them in existing drivers. > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson

Re: [PATCH 06/14] pci: define some command constants

On Thu, Aug 03, 2023 at 09:50:29AM +0200, David Marchand wrote: > Define some PCI command constants and use them in existing drivers. > > Signed-off-by: David Marchand > --- For the idea, all good, but for the implementation, one comment inline below. With the below reworked: Acked-by: Bruce R

Re: [PATCH 05/14] pci: define some MSIX constants

On Thu, Aug 03, 2023 at 09:50:28AM +0200, David Marchand wrote: > Define some PCI MSIX constants and use them in existing drivers. > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson

Re: [PATCH 03/14] bus/pci: find PCI capability

On Thu, Aug 03, 2023 at 10:49:54AM +0100, Bruce Richardson wrote: > On Thu, Aug 03, 2023 at 09:50:26AM +0200, David Marchand wrote: > > Introduce two helpers so that drivers stop reinventing the wheel. > > Use it in existing drivers. > > > > Can you give a little more context on the new helpers a

Re: [PATCH 04/14] pci: define some capability constants

On Thu, Aug 03, 2023 at 09:50:27AM +0200, David Marchand wrote: > Define some PCI capability constants and use them in existing drivers. > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson

Re: [PATCH 03/14] bus/pci: find PCI capability

On Thu, Aug 03, 2023 at 09:50:26AM +0200, David Marchand wrote: > Introduce two helpers so that drivers stop reinventing the wheel. > Use it in existing drivers. > Can you give a little more context on the new helpers and the changes in the patch? A lot of the changes are not that self-explanator

Re: [PATCH 02/14] bus/pci: add const to some experimental API

On Thu, Aug 03, 2023 at 09:50:25AM +0200, David Marchand wrote: > Those functions are fine with a const on the device pointer. > > Signed-off-by: David Marchand > --- > drivers/bus/pci/pci_common.c | 4 ++-- > drivers/bus/pci/rte_bus_pci.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletio

Re: [PATCH 01/14] drivers: remove duplicated PCI master control

On Thu, Aug 03, 2023 at 09:50:24AM +0200, David Marchand wrote: > Use existing API to cleanup duplicated code. > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson

Re: [PATCH] eal: remove RTE_FUNC_PTR_* deprecated macros

On Thu, Aug 03, 2023 at 11:41:18AM +0200, David Marchand wrote: > The RTE_FUNC_PTR_OR_* macros were marked as deprecated in v22.11, we can > remove them. > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson

[PATCH] eal: remove RTE_FUNC_PTR_* deprecated macros

The RTE_FUNC_PTR_OR_* macros were marked as deprecated in v22.11, we can remove them. Signed-off-by: David Marchand --- devtools/cocci/func_or_ret.cocci | 12 doc/guides/rel_notes/deprecation.rst | 4 doc/guides/rel_notes/release_23_11.rst | 2 ++ lib/eal/include/rte_

Re: [PATCH v4] build: update DPDK to use C11 standard

On Wed, Aug 2, 2023 at 3:41 PM Patrick Robb wrote: > On Wed, Aug 2, 2023 at 2:32 AM David Marchand > wrote: >> >> What about the LTS releases testing? > > Okay, we will disable rhel7 testing for dpdk main and next branches, but > leave testing on for the LTS releases. Thank you Patrick. --

Re: [PATCH v2] doc: build manpages as well as html output

On Mon, Jul 17, 2023 at 1:09 PM Bruce Richardson wrote: > > There may be some polishing to do later. > > Looking at the result for rte_eal_init, I see that the generated > > manual starts with a reference to the rte_eal.h header with a path > > relative to its location in the DPDK tree. > > $ MANP

[Question/Issue] pkgconfig does not include dpdk/drivers libs

I’m consuming dpdk via spdk. I was trying to use pkg-config for a Makefile that I’m writing, Executing: PKG_CONFIG_PATH=dpdk/build/lib/pkgconfig pkg-config --libs --static libdpdk Output: -Wl,--whole-archive -Wl,--no-whole-archive -Wl,--as-needed -pthread -L/home/nutanix/exact_spdk/spdk/dpdk/bui

RE: [PATCH] ethdev: introduce generic flow item and action

Hi Cristian, > -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, August 2, 2023 7:57 PM > > > > > -Original Message- > > From: Ori Kam > > Sent: Wednesday, August 2, 2023 4:47 PM > > To: Morten Brørup ; Dumitrescu, Cristian > > ; Jerin Jacob > > Cc: Zhang, Qi

RE: [PATCH v1] eventdev/crypto: flush ops when circ buffer is full

Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Wednesday, August 2, 2023 9:47 PM > To: Kundapura, Ganapati > Cc: jer...@marvell.com; Jayatheerthan, Jay ; > Naga Harish K, S V ; Gujjar, Abhinandan S > ; dev@dpdk.org > Subject: Re: [PATCH v1] eventdev/crypto: flush ops when cir

[PATCH v2] eventdev/crypto: fix circular buffer full case

crypto ops from the circular buffer are not getting flushed to crypto dev when crypto dev becomes busy and circular buffer gets full. Fix it by flushing ops from circular buffer when circ buffer is full instead of returning without flushing. Fixes: 2ae84b39ae7b ("eventdev/crypto: store operations

Re: Drivers, architectures, processor families, etc.

On Wed, Aug 02, 2023 at 03:47:59PM -0700, Stephen Hemminger wrote: > On Wed, 2 Aug 2023 15:49:54 -0600 > Philip Prindeville wrote: > > > Hi, > > > > I'm trying to come up with some Kconfig logic for OpenWRT packaging to help > > users select the right build options for their hardware. > > > >

Re: [PATCH] telemetry: avoid truncation of strlcpy return before check

On Wed, Aug 02, 2023 at 02:21:01PM -0700, Tyler Retzlaff wrote: > strlcpy returns type size_t when directly assigning to > struct rte_tel_data data_len field it may be truncated leading to > compromised length check that follows > > Since the limit in the check is < UINT_MAX the value returned is

[PATCH v4 8/8] net/rnp handle device interrupts

Handle device lsc interrupt event Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_hw.h | 5 + drivers/net/rnp/base/rnp_mac_regs.h | 279 drivers/net/rnp/rnp.h | 8 + drivers/net/rnp/rnp_ethdev.c| 17 ++ drivers/net/rnp/rnp_mbx.h

[PATCH v4 7/8] net/rnp add devargs runtime parsing functions

add various runtime devargs command line options supported by this driver. Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp.h| 22 + drivers/net/rnp/rnp_ethdev.c | 166 +++ drivers/net/rnp/rnp_mbx_fw.c | 164 ++ drivers

[PATCH v4 6/8] net/rnp add port info resource init

Add Api For FW Mac Info, Port Resoucre info init Code For Different Shape Of Nic Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_api.c | 48 +++ drivers/net/rnp/base/rnp_api.h | 10 ++ drivers/net/rnp/base/rnp_hw.h | 18 +++ drivers/net/rnp/meson.build| 1 + drivers/net/rnp/r

[PATCH v4 4/8] net/rnp: add mbx basic api feature

mbx base code is for communicate with the firmware Signed-off-by: Wenbo Cao Suggested-by: Stephen Hemminger --- drivers/net/rnp/base/rnp_api.c | 23 ++ drivers/net/rnp/base/rnp_api.h | 7 + drivers/net/rnp/base/rnp_cfg.h | 7 + drivers/net/rnp/base/rnp_dma_regs.h | 73

[PATCH v4 5/8] net/rnp add reset code for Chip Init process

we must get the shape info of nic from Firmware for reset. so the related codes is first get firmware info and then reset the chip Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_hw.h | 56 +++- drivers/net/rnp/meson.build | 3 + drivers/net/rnp/rnp.h | 27 ++ dri

[PATCH v4 3/8] net/rnp: add device init and uninit

Add basic init and uninit function Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_hw.h | 19 drivers/net/rnp/meson.build | 1 + drivers/net/rnp/rnp.h | 25 + drivers/net/rnp/rnp_ethdev.c | 196 +- drivers/net/rnp/rnp_logs.h| 34

[PATCH v4 2/8] net/rnp: add ethdev probe and remove

Add basic PCIe ethdev probe and remove. Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp.h| 13 ++ drivers/net/rnp/rnp_ethdev.c | 83 2 files changed, 96 insertions(+) create mode 100644 drivers/net/rnp/rnp.h diff --git a/drivers/net/rnp/rnp.h b

[PATCH v4 1/8] net/rnp: add skeleton

Add Basic PMD library and doc build infrastructure Update maintainers file to claim responsibility. Signed-off-by: Wenbo Cao --- MAINTAINERS | 6 + doc/guides/nics/features/rnp.ini | 8 ++ doc/guides/nics/index.rst| 1 + doc/guides/nics/rnp.rst |

[PATCH v4 0/8] [v4] drivers/net Add Support mucse N10 Pmd Driver

For This patchset just to support the basic chip init work and user can just found the eth_dev, but can't control more. For Now just support 2*10g nic,the chip can support 2*10g,4*10g,4*1g,8*1g,8*10g. The Feature rx side can support rx-cksum-offload,rss,vlan-filter flow_clow,uncast_filter,mcast_fil

Re: [RFC PATCH 0/1] make cmdline library easier to use

On Wed, Aug 02, 2023 at 11:05:07AM -0700, Stephen Hemminger wrote: > On Wed, 2 Aug 2023 18:00:51 +0100 > Bruce Richardson wrote: > > > And now for something completely different... :-) > > > > While it's nice that DPDK includes a commandline library for easily > > adding interactivity to applic

Re: error: No probed ethernet devices

On Wed, Aug 02, 2023 at 01:29:03PM +, FRANCISCO ARNALDO BOIX MARTINEZ wrote: >Hi team, > >I am trying to run dpdk-testpmd utility, but I am not able to make it >work even though I have already used dpdk-devbind.py utility. I haven't >been able to find the solution yet, could yo

Re: [PATCH v1] event/dlb2: add support for disabling PASID

On Thu, Jun 8, 2023 at 9:28 AM David Marchand wrote: > > On Thu, Jun 8, 2023 at 7:38 AM Jerin Jacob wrote: > > > > On Thu, Jun 8, 2023 at 2:31 AM Abdullah Sevincer > > wrote: > > > > > > vfio-pci driver in Linux kernel 6.2 enables PASID by default. > > > In DLB hardware, enabling PASID puts DLB

[PATCH v3 8/8] net/rnp handle device interrupts

Handle device lsc interrupt event Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_hw.h | 5 + drivers/net/rnp/base/rnp_mac_regs.h | 279 drivers/net/rnp/rnp.h | 8 + drivers/net/rnp/rnp_ethdev.c| 17 ++ drivers/net/rnp/rnp_mbx.h

[PATCH v3 3/8] net/rnp: add device init and uninit

Add basic init and uninit function Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_hw.h | 19 drivers/net/rnp/meson.build | 1 + drivers/net/rnp/rnp.h | 25 + drivers/net/rnp/rnp_ethdev.c | 196 +- drivers/net/rnp/rnp_logs.h| 34

[PATCH v3 4/8] net/rnp: add mbx basic api feature

mbx base code is for communicate with the firmware Signed-off-by: Wenbo Cao Suggested-by: Stephen Hemminger --- drivers/net/rnp/base/rnp_api.c | 23 ++ drivers/net/rnp/base/rnp_api.h | 7 + drivers/net/rnp/base/rnp_cfg.h | 7 + drivers/net/rnp/base/rnp_dma_regs.h | 73

[PATCH v3 7/8] net/rnp add devargs runtime parsing functions

add various runtime devargs command line options supported by this driver. Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp.h| 22 + drivers/net/rnp/rnp_ethdev.c | 166 +++ drivers/net/rnp/rnp_mbx_fw.c | 164 ++ drivers

[PATCH v3 6/8] net/rnp add port info resource init

Add Api For FW Mac Info, Port Resoucre info init Code For Different Shape Of Nic Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_api.c | 48 +++ drivers/net/rnp/base/rnp_api.h | 10 ++ drivers/net/rnp/base/rnp_hw.h | 18 +++ drivers/net/rnp/meson.build| 1 + drivers/net/rnp/r

[PATCH v3 5/8] net/rnp add reset code for Chip Init process

we must get the shape info of nic from Firmware for reset. so the related codes is first get firmware info and then reset the chip Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_hw.h | 56 +++- drivers/net/rnp/meson.build | 3 + drivers/net/rnp/rnp.h | 27 ++ dri

[PATCH v3 2/8] net/rnp: add ethdev probe and remove

Add basic PCIe ethdev probe and remove. Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c index 5951c2b311..390f2e7743 100644 --- a/drivers/net/rnp/rnp_ethdev.c

[PATCH v3 1/8] net/rnp: add ethdev probe and remove

Add basic PCIe ethdev probe and remove. Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp.h| 13 ++ drivers/net/rnp/rnp_ethdev.c | 83 2 files changed, 96 insertions(+) create mode 100644 drivers/net/rnp/rnp.h diff --git a/drivers/net/rnp/rnp.h b

[PATCH v3 0/8] [v3] drivers/net Add Support mucse N10 Pmd Driver

For This patchset just to support the basic chip init work and user can just found the eth_dev, but can't control more. For Now just support 2*10g nic,the chip can support 2*10g,4*10g,4*1g,8*1g,8*10g. The Feature rx side can support rx-cksum-offload,rss,vlan-filter flow_clow,uncast_filter,mcast_fil

Re: [PATCH v4] dmadev: add tracepoints

Hi Thomas, On 2023/7/31 20:48, Thomas Monjalon wrote: > 10/07/2023 09:50, fengchengwen: >> Hi Thomas, >> >> On 2023/7/10 14:49, Thomas Monjalon wrote: >>> 09/07/2023 05:23, fengchengwen: Hi Thomas, On 2023/7/7 18:40, Thomas Monjalon wrote: > 26/05/2023 10:42, Chengwen Feng:

[PATCH 14/14] devtools: forbid inclusion of Linux header for PCI

Refrain from including Linux-only pci_regs.h header. Instead, prefer our own definitions from the pci library. Signed-off-by: David Marchand --- devtools/checkpatches.sh | 8 1 file changed, 8 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 43f5e36a

[PATCH 12/14] pci: define some PRI constants

Define some PCI PRI extended feature constants and use them in existing drivers. Signed-off-by: David Marchand --- drivers/event/dlb2/pf/dlb2_main.c | 11 --- lib/pci/rte_pci.h | 5 + 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/event/dlb2/p

[PATCH 13/14] pci: define some AER constants

Define some Advanced Error Reporting constants and use them in existing drivers. Signed-off-by: David Marchand --- drivers/event/dlb2/pf/dlb2_main.c | 10 +++--- lib/pci/rte_pci.h | 5 + 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/event/dlb2/pf

[PATCH 11/14] pci: define some ACS constants

Define some PCI ACS extended feature constants and use them in existing drivers. Signed-off-by: David Marchand --- drivers/event/dlb2/pf/dlb2_main.c | 23 --- lib/pci/rte_pci.h | 9 + 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/dr

[PATCH 10/14] pci: define some extended capability constants

Define some PCI extended capability constants and use them in existing drivers. Signed-off-by: David Marchand --- drivers/event/dlb2/pf/dlb2_main.c | 7 ++- lib/pci/rte_pci.h | 2 ++ 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/event/dlb2/pf/dlb2_mai

[PATCH 08/14] pci: define some PM constants

Define some PCI Power Management constants and use them in existing drivers. Signed-off-by: David Marchand --- drivers/net/bnx2x/bnx2x.c | 17 + drivers/net/bnx2x/bnx2x.h | 5 - lib/pci/rte_pci.h | 6 ++ 3 files changed, 15 insertions(+), 13 deletions(-) diff -

[PATCH 09/14] pci: define some PCIe constants

Define some PCI Express constants and use them in existing drivers. Signed-off-by: David Marchand --- drivers/event/dlb2/pf/dlb2_main.c | 40 --- drivers/net/bnx2x/bnx2x.c | 16 ++--- drivers/net/bnx2x/bnx2x.h | 35 ---

[PATCH 07/14] pci: define some BAR constants

Define some PCI BAR constants and use them in existing drivers. Signed-off-by: David Marchand --- drivers/bus/pci/linux/pci_vfio.c | 7 +++ lib/pci/rte_pci.h| 4 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus

[PATCH 06/14] pci: define some command constants

Define some PCI command constants and use them in existing drivers. Signed-off-by: David Marchand --- drivers/bus/pci/linux/pci_vfio.c | 8 drivers/event/dlb2/pf/dlb2_main.c | 8 +++- lib/pci/rte_pci.h | 4 +++- 3 files changed, 10 insertions(+), 10 deletions(-) di

[PATCH 05/14] pci: define some MSIX constants

Define some PCI MSIX constants and use them in existing drivers. Signed-off-by: David Marchand --- drivers/bus/pci/linux/pci_init.h | 18 -- drivers/bus/pci/linux/pci_vfio.c | 14 +++--- drivers/crypto/virtio/virtio_pci.c | 6 ++ drivers/event/dlb2/pf/dlb2_main.c

[PATCH 04/14] pci: define some capability constants

Define some PCI capability constants and use them in existing drivers. Signed-off-by: David Marchand --- drivers/bus/pci/linux/pci_vfio.c| 2 +- drivers/crypto/virtio/virtio_pci.c | 12 ++-- drivers/event/dlb2/pf/dlb2_main.c | 6 ++ drivers/net/bnx2x/bnx2x.c | 16 +

[PATCH 03/14] bus/pci: find PCI capability

Introduce two helpers so that drivers stop reinventing the wheel. Use it in existing drivers. Note: - base/ drivers code is left untouched, only some wrappers in cxgbe are touched, - bnx2x maintained a per device cache of capabilities, this code has been reworked to only cache the capabilities

[PATCH 02/14] bus/pci: add const to some experimental API

Those functions are fine with a const on the device pointer. Signed-off-by: David Marchand --- drivers/bus/pci/pci_common.c | 4 ++-- drivers/bus/pci/rte_bus_pci.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.

[PATCH 01/14] drivers: remove duplicated PCI master control

Use existing API to cleanup duplicated code. Signed-off-by: David Marchand --- drivers/bus/pci/linux/pci_uio.c| 32 +-- drivers/bus/pci/linux/pci_vfio.c | 41 ++ drivers/net/hns3/hns3_ethdev_vf.c | 25 +- drivers/net/ngbe/bas

[PATCH 00/14] Cleanup PCI(e) drivers

Rather than rely on Linux headers to find some PCI(e) standard constants or reinvent the same PCI capability helper, this series complements the pci library and the pci bus driver. PCI drivers can then use OS agnostic macros and helpers. WARNING: this is only compile tested. -- David Marchand D