RE: [PATCH] vfio: do not coalesce DMA mappings

2023-07-03 Thread Gupta, Nipun
Hi Xuan, Please see inline. > -Original Message- > From: Ding, Xuan > Sent: Tuesday, July 4, 2023 10:43 AM > To: Gupta, Nipun ; dev@dpdk.org; > tho...@monjalon.net; Burakov, Anatoly ; Yigit, > Ferruh > Cc: Agarwal, Nikhil ; He, Xingguang > ; Ling, WeiX > Subject: RE: [PATCH] vfio: do n

Re: [PATCH v5 2/2] ethdev: support xstats reset telemetry command

2023-07-03 Thread fengchengwen
Hi Thomas and Morten, On 2023/7/3 21:44, Morten Brørup wrote: >> From: Thomas Monjalon [mailto:tho...@monjalon.net] >> Sent: Monday, 3 July 2023 09.20 >> >> 03/07/2023 05:58, fengchengwen: >>> >>> On 2023/2/20 21:05, Thomas Monjalon wrote: 17/02/2023 10:44, fengchengwen: > On 2023/2/16 20

Re: [PATCH v2 1/2] doc/contributing: provide coding details for dynamic logging

2023-07-03 Thread fengchengwen
Acked-by: Chengwen Feng On 2023/6/21 1:07, Bruce Richardson wrote: > While the section on dynamic logging in the contributors guide covered > the details of the logging naming scheme, it failed to cover exactly how > the component developer, i.e. the contributor, could actually use > dynamic logg

RE: [PATCH] net/mlx5: forbid MPRQ restart

2023-07-03 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: Tuesday, July 4, 2023 12:22 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: forbid MPRQ restart > > The queue restart is only supported by the non-vectori

RE: [PATCH v1] examples/fips_validation: fix digest length in AES GCM

2023-07-03 Thread Akhil Goyal
> Subject: RE: [PATCH v1] examples/fips_validation: fix digest length in AES GCM > > Acked-by: Gowrishankar Muthukrishnan Applied to dpdk-next-crypto Thanks.

RE: [PATCH v1] examples/fips_validation: fix digest length in AES GCM

2023-07-03 Thread Gowrishankar Muthukrishnan
Acked-by: Gowrishankar Muthukrishnan

[PATCH v2] doc: announce addition of new security IPsec SA option

2023-07-03 Thread Nithin Dabilpuram
Announce addition of new security IPsec SA option to enable out of place processing in Ingress Inline inbound SA's. Signed-off-by: Nithin Dabilpuram Acked-by: Akhil Goyal --- v2: - Modified deprication notice to include reserved opts removal. doc/guides/rel_notes/deprecation.rst | 5 + 1

RE: [PATCH] vfio: do not coalesce DMA mappings

2023-07-03 Thread Ding, Xuan
Hi Nipun, > -Original Message- > From: Ding, Xuan > Sent: Friday, June 30, 2023 1:58 PM > To: Nipun Gupta ; dev@dpdk.org; > tho...@monjalon.net; Burakov, Anatoly ; > ferruh.yi...@amd.com > Cc: nikhil.agar...@amd.com; He, Xingguang ; Ling, > WeiX > Subject: RE: [PATCH] vfio: do not coalesc

Re: [PATCH V2] doc: add iavf live migration guide

2023-07-03 Thread Cao, Yahui
Hi Lingyu, On 7/4/2023 10:27 AM, Lingyu Liu wrote: Describe iavf live migration steps. Signed-off-by: Lingyu Liu --- v2: Fixed CI. Added brief introduction about live migration. Clarified this is iavf feature. --- doc/guides/nics/intel_vf.rst | 101

RE: [EXT] [PATCH 1/1] app/test: resolve mbuf_test application failure

2023-07-03 Thread Ashwin Sekhar T K
Acked-by: Ashwin Sekhar T K Ashwin Sekhar T K > -Original Message- > From: Rakesh Kudurumalla > Sent: Wednesday, April 26, 2023 2:58 PM > To: Olivier Matz > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Nithin > Kumar Dabilpuram ; Rakesh Kudurumalla > > Subject: [EXT] [PATCH 1/1] app

Re: [PATCH v2 04/44] net/pcap: fix segment fault when parse devargs

2023-07-03 Thread Stephen Hemminger
On Mon, 20 Mar 2023 09:20:30 + Chengwen Feng wrote: > The rte_kvargs_process() was used to parse KV pairs, it also supports > to parse 'only keys' (e.g. socket_id) type. And the callback function > parameter 'value' is NULL when parsed 'only keys'. > > This patch fixes segment fault when par

Re: [PATCH v2 24/44] net/netvsc: fix segment fault when parse devargs

2023-07-03 Thread Stephen Hemminger
On Mon, 20 Mar 2023 09:20:50 + Chengwen Feng wrote: > The rte_kvargs_process() was used to parse KV pairs, it also supports > to parse 'only keys' (e.g. socket_id) type. And the callback function > parameter 'value' is NULL when parsed 'only keys'. > > This patch fixes segment fault when par

[PATCH v3] vhost: add notify reply ops to fix message deadlock

2023-07-03 Thread Rma Ma
Since backend and frontend message are synchronous in the same thread, there will be a probability of message deadlock. Consider each driver to determine whether to wait for response. Fixes: d90cf7d111ac ("vhost: support host notifier") Cc: maxime.coque...@redhat.com Signed-off-by: Rma Ma --- v2

Re: [PATCH v2] vhost: add notify reply ops to fix message deadlock

2023-07-03 Thread Stephen Hemminger
On Tue, 4 Jul 2023 10:32:28 +0800 Rma Ma wrote: > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c > index 901a80bbaa..aa61992939 100644 > --- a/lib/vhost/vhost_user.c > +++ b/lib/vhost/vhost_user.c > @@ -3365,13 +3365,14 @@ rte_vhost_backend_config_change(int vid, bool > need_reply

[PATCH v2] vhost: add notify reply ops to fix message deadlock

2023-07-03 Thread Rma Ma
Since backend and frontend message are synchronous in the same thread, there will be a probability of message deadlock. Consider each driver to determine whether to wait for response. Fixes: d90cf7d111ac ("vhost: support host notifier") Cc: maxime.coque...@redhat.com Signed-off-by: Rma Ma --- v2

[PATCH V2] doc: add iavf live migration guide

2023-07-03 Thread Lingyu Liu
Describe iavf live migration steps. Signed-off-by: Lingyu Liu --- v2: Fixed CI. Added brief introduction about live migration. Clarified this is iavf feature. --- doc/guides/nics/intel_vf.rst | 101 + doc/guides/rel_notes/release_23_07.rst | 3 +

Re: [PATCH] app/testpmd: fix invalid queue ID when start port

2023-07-03 Thread lihuisong (C)
在 2023/7/3 19:02, Jie Hai 写道: Function update_queue_state updates queue state of all queues of all ports, using the queue num nb_rxq|nb_txq stored locally by testpmd. Error on invalid queue ID occurs if we start testpmd with two ports and detach-attach one of them and start the other How do st

Re: [PATCH] doc: announce inclusive naming function name changes

2023-07-03 Thread Stephen Hemminger
On Fri, 19 May 2023 14:33:34 +0800 Chaoyong He wrote: > In order to support inclusive naming, some of the functions in > DPDK will need to be renamed. Do this through deprecation process > now for 23.07. > > Signed-off-by: Chaoyong He Can this please get merged for 23.07, sufficient ACK's

Re: [PATCH] app/testpmd: fix invalid queue ID when start port

2023-07-03 Thread Jie Hai
On 2023/7/3 20:33, Ali Alnubani wrote: -Original Message- From: Jie Hai Sent: Monday, July 3, 2023 2:03 PM To: Aman Singh ; Yuying Zhang ; Ferruh Yigit ; Shiyang He Cc: dev@dpdk.org; liudongdo...@huawei.com; Ali Alnubani Subject: [PATCH] app/testpmd: fix invalid queue ID when start por

Re: [PATCH v4 0/9] expand list of optional libraries

2023-07-03 Thread fengchengwen
Series-acked-by: Chengwen Feng On 2023/6/23 23:06, Bruce Richardson wrote: > DPDK still has many libraries which cannot be disabled as part of a > build. With the ongoing work to make it easier to only build a subset > of the libraries in DPDK, we can also work to expand the list of > libraries w

RE: [PATCH] net/cpfl: fix RSS lookup table configuration

2023-07-03 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Jingjing > Sent: Monday, July 3, 2023 3:33 PM > To: Xing, Beilei > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/cpfl: fix RSS lookup table configuration > > > > > -Original Message- > > From: Xing, Beilei > > Sent: Monday, July 3, 2023 7:28 P

Re: [PATCH] bus/vmbus: add support allow/block scan mode

2023-07-03 Thread Stephen Hemminger
On Thu, 9 Jun 2022 07:55:13 + Xiaoming Jiang wrote: > Signed-off-by: Xiaoming Jiang > --- > drivers/bus/vmbus/vmbus_common.c | 30 -- > 1 file changed, 28 insertions(+), 2 deletions(-) > > diff --git a/drivers/bus/vmbus/vmbus_common.c > b/drivers/bus/vmbus/vmb

Re: [PATCH v5 00/14] add FreeBSD support to VMBUS & NetVSC PMDs

2023-07-03 Thread Stephen Hemminger
On Thu, 06 Oct 2022 16:58:01 +0200 Thomas Monjalon wrote: > 18/05/2022 10:18, Thomas Monjalon: > > 23/04/2022 06:28, Srikanth Kaka: > > > This patchset requires FreeBSD VMBus kernel changes and > > > HV_UIO driver. Both are currently under review at > > > https://reviews.freebsd.org/D32184 >

Re: [PATCH 2/2] known_issues: drop note about UIO with really old kernels

2023-07-03 Thread Stephen Hemminger
On Thu, 17 Feb 2022 08:45:17 -0800 Stephen Hemminger wrote: > The DPDK has not supported 3.9 kernel for a long time so the > release note about UIO kernel bug in older versions is no > longer relevant. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/rel_notes/known_issues.rst | 21

Re: [dpdk-dev] [RFC 0/3] Add mdev (Mediated device) support in DPDK

2023-07-03 Thread Stephen Hemminger
On Wed, 10 Apr 2019 12:02:28 +0200 Francois Ozog wrote: > Hi all, > > I presented an approach in Fosdem > (https://archive.fosdem.org/2018/schedule/event/netmdev/) and feel > happy someone is picking up. After reading through this old patch set, it looks like there are a number of loose ends. I

Re: [dpdk-dev] [PATCH v2 1/1] vfio: add page-by-page mapping API

2023-07-03 Thread Stephen Hemminger
On Thu, 2 Jun 2022 10:23:07 +0200 David Marchand wrote: > Hello Anatoly, > > On Tue, Nov 2, 2021 at 4:54 PM Burakov, Anatoly > wrote: > > > > On 28-Oct-21 3:09 PM, Anatoly Burakov wrote: > > > Currently, there is no way to map memory for DMA in a way that allows > > > unmapping it partially l

Re: [PATCH] test/ipsec: fix TAP default MAC address

2023-07-03 Thread Stephen Hemminger
On Wed, 28 Jun 2023 19:12:35 + Vladimir Medvedkin wrote: > default TAP mac address was changed in commit id: > c3006be2acab49c6b77ae9c9ef04b061e5dacbd6 > reflect changes in ipsec test scripts. > > Fixes: c3006be2acab ("net/tap: set locally administered bit for fixed MAC > address") > Cc: d.

Re: [dpdk-dev] [PATCH v2 2/2] examples/flow_classify: add an ACL table for tcp

2023-07-03 Thread Stephen Hemminger
On Thu, 19 Aug 2021 12:34:46 -0700 Sowmini Varadhan wrote: > On (08/19/21 16:21), Iremonger, Bernard wrote: > > > > Looking closer at this patchset, I am not sure that a second ACL table is > > needed. > > The existing ACL table handles UDP, TCP and SCP, however it is not > > processing the TC

Re: [dpdk-dev] [PATCH 1/2] doc: add policy for adding vendor PMD specific examples

2023-07-03 Thread Stephen Hemminger
On Wed, 17 Nov 2021 11:57:34 +0100 Thomas Monjalon wrote: > 26/05/2021 09:47, Hemant Agrawal: > > This patch update the dpdk sample app policy to support > > vendor PMD specific test examples in the respective drivers > > sub-directory in examples. > > Please could you add a link to the decisi

[PATCH v2] eal: avoid issues in macro expansion of alignment

2023-07-03 Thread Stephen Hemminger
RTE_ALIGN_MUL_NEAR is a macro so the cycle argument could get evaluated twice causing some potential skew. Fix by computing value once. Suggested by patch to fix side effects. Fixes: 5cbd14b3e5f9 ("eal: roundup TSC frequency when estimating") Cc: pbhagavat...@marvell.com Signed-off-by: Stephen H

[PATCH v2] test: remove unnecessary rte_srand

2023-07-03 Thread Stephen Hemminger
The random number is already initialized to a better random seed during startup process. The calls to rte_srand() are redundant and actually make entropy worse. Signed-off-by: Stephen Hemminger --- v2 - fix spelling error in commit message app/test/test_fib6_perf.c| 2 -- app/te

Re: [dpdk-dev] [PATCH] examples/ethtool: fix pause configuration

2023-07-03 Thread Stephen Hemminger
On Wed, 28 Apr 2021 16:42:59 +0800 "Min Hu (Connor)" wrote: > From: Huisong Li > > Currently, the pause command in ethtool to enable Rx/Tx pause has the > following problem. Namely, Assume that the device supports flow control > auto-negotiation to set pause parameters, which will the device th

Re: [PATCH] ethtool: correct format strings according to the arguments

2023-07-03 Thread Stephen Hemminger
On Thu, 24 Mar 2022 10:31:24 +0500 "huzaifa.rahman" wrote: > The corrected format strings are not consistent with the > given arguments. So they are changed accordingly. > > Signed-off-by: huzaifa.rahman > --- > examples/ethtool/ethtool-app/main.c | 6 +++--- > 1 file changed, 3 insertions(+),

Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()

2023-07-03 Thread Stephen Hemminger
On Thu, 18 Aug 2022 15:18:36 +0500 Usman Tanveer wrote: > Hi, > > Can you please have a look and update the status? Looks OK to me. Acked-by: Stephen Hemminger

Re: [PATCH] ethtool: added list command to list all available commands

2023-07-03 Thread Stephen Hemminger
On Mon, 21 Mar 2022 19:25:47 +0500 "huzaifa.rahman" wrote: > From: Huzaifa696 > > help command is needed so user can see all the available commands directly > from the command line along with the formats. > > Signed-off-by: Huzaifa696 Developer Certificate of Origin is intended to a legal as

Re: [PATCH v2] examples/ethtool: update rxmode to increase functionality

2023-07-03 Thread Stephen Hemminger
On Thu, 11 Aug 2022 17:58:40 +0500 Muhammad Jawad Hussain wrote: > @@ -142,7 +183,6 @@ pcmd_quit_callback(__rte_unused void *ptr_params, > cmdline_quit(ctx); > } > > - > static void > pcmd_drvinfo_callback(__rte_unused void *ptr_params, > __rte_unused struct cmdline *ctx, Please

Re: [dpdk-dev] [PATCH V1 0/2] examples/ethtool: fix MTU set and add MTU query

2023-07-03 Thread Stephen Hemminger
On Mon, 28 Jun 2021 11:23:12 +0800 "Min Hu (Connor)" wrote: > Hi, all, > any comments? > > 在 2021/4/29 18:53, Min Hu (Connor) 写道: > > From: Huisong Li > > > > This patchset fixes MTU data type when set MTU, and supports the query > > of MTU. > > > > Huisong Li (2): > >examples/ethto

[PATCH] net/mlx5: forbid MPRQ restart

2023-07-03 Thread Alexander Kozyrev
The queue restart is only supported by the non-vectorized single-packet receive queue today. Restarting MPRQ will result in corrupted packets because of CQE and WQE mismatch. Prevent this by not allowing the MPRQ Rx queue stop. Fixes: 161d103b23 ("net/mlx5: add queue start and stop") Cc: sta...@dp

[PATCH] eal: avoid issues in macro expansion of alignment

2023-07-03 Thread Stephen Hemminger
RTE_ALIGN_MUL_NEAR is a macro so the cycle arguement could get evaluated twice causing some potential skew. Fix by computing value once. Suggested by patch to fix side effects. Fixes: 5cbd14b3e5f9 ("eal: roundup TSC frequency when estimating") Cc: pbhagavat...@marvell.com Signed-off-by: Stephen

[PATCH] test: remove unnecessary rte_srand

2023-07-03 Thread Stephen Hemminger
The random number is already initialized to a better random seed during starup process. The calls to rte_srand() are redundant and actually make entropy worse. Signed-off-by: Stephen Hemminger --- app/test/test_fib6_perf.c| 2 -- app/test/test_fib_perf.c | 2 -- a

[PATCH] net/mlx5: fix non-ip packets are not delivered when RSS hash type ESP is used.

2023-07-03 Thread Maayan Kashani
Non-ip packets such as ARP or LACP are not delivered if you use RTE flow rule with empty pattern and rss action with specific combination of RSS hash types: "ipv4-tcp ipv4-udp ipv4-other ipv6-tcp ipv6-udp ipv6-other esp". The stack which used for RSS expansion was overflowed and trashed rss exp

Re: [PATCH] doc: fix missing release note for GVE PMD DQO

2023-07-03 Thread Rushil Gupta
On Sun, Jul 2, 2023 at 8:00 PM Junfeng Guo wrote: > > Add missing release note for GVE PMD enabling for DQO queue format. > > Fixes: a14d391c7d99 ("net/gve: add Tx queue setup for DQO") > > Signed-off-by: Junfeng Guo > --- > doc/guides/rel_notes/release_23_07.rst | 3 +++ > 1 file changed, 3 ins

Re: [PATCH] member: fix PRNG seed reset in NitroSketch mode

2023-07-03 Thread Stephen Hemminger
On Wed, 21 Jun 2023 00:17:20 +0300 Dmitry Kozlyuk wrote: > Seeding the global PRNG at sketch creation > does not make the sketch operation deterministic: > it uses rte_rand() later, the PRNG may be seeded again by that point. > On the other hand, seeding the global PRNG with a hash seed, > is lik

Re: [PATCH v2] raw/ntb: add check for disabling interrupt in dev close ops

2023-07-03 Thread Thomas Monjalon
03/07/2023 08:53, Wu, Jingjing: > > > -Original Message- > > From: Guo, Junfeng > > Sent: Wednesday, June 28, 2023 5:12 PM > > To: Wu, Jingjing > > Cc: dev@dpdk.org; sta...@dpdk.org; He, Xingguang ; > > Laatz, Kevin > > ; Guo, Junfeng > > Subject: [PATCH v2] raw/ntb: add check for disa

[PATCH] fib: fix adding a default route

2023-07-03 Thread Vladimir Medvedkin
Fixed an issue that occurs when adding a default route as the first route. Bugzilla ID: 1160 Fixes: 7dc7868b200d ("fib: add DIR24-8 dataplane algorithm") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- v2: - remove unnecessary parenthesis --- lib/fib/dir24_8.c | 2 +- 1 file change

Re: [PATCH] eal/interrupts: Allow UIO interrupts when using igb_uio

2023-07-03 Thread Thomas Monjalon
14/06/2023 18:46, Stephen Hemminger: > On Wed, 14 Jun 2023 13:40:18 + > Vladimir Ratnikov wrote: > > > Some drivers and devices(ex: igc + i225/i226) use > > RTE_INTR_HANDLE_UIO handler when captured under igb_uio > > so just let them use it. > > > > Signed-off-by: Vladimir Ratnikov > > Th

Re: [PATCH] doc: ensure sphinx output is reproducible

2023-07-03 Thread Thomas Monjalon
29/06/2023 14:58, christian.ehrha...@canonical.com: > From: Christian Ehrhardt > > By adding -j we build in parallel, to make building on multiprocessor > machines more effective. While that works it does also break > reproducible builds as the order of the sphinx generated searchindex.js > is de

Re: [PATCH v2] docs: freebsd: Update to 20.11

2023-07-03 Thread Thomas Monjalon
30/06/2023 18:41, David Young: > This patch updates the installation instructions for DPDK on FreeBSD. > It specifies the explicit version of DPDK (20.11) to be installed. > This change is important as the 'dpdk' package is an alias and doesn't > always point to the latest version. By specifying th

Re: [PATCH v5] build: prevent accidentally building without NUMA support

2023-07-03 Thread Thomas Monjalon
28/06/2023 05:03, Tu, Lijuan: > From: Thomas Monjalon > > 15/06/2023 16:38, Bruce Richardson: > > Is the test ci/Intel-compilation fixed? > > Could you send a new version for testing the CI? > > > > Sorry, this is caused by intel testbeds lack of dep libnuma, Installed it and > re-run the CI, r

Re: [EXT] Re: [PATCH v3] net/bnx2x: offer maintainership for bnx2x

2023-07-03 Thread Thomas Monjalon
30/06/2023 04:27, Alok Prasad: > > 02/06/2023 09:52, Julien Aube: > > > This is an offer to maintain the code for bnx2x-based > > > cards. It may not be possible on the long run due to > > > the old design of this chipset. > > > > > > Note that I'm not affiliated with LSI nor Broadcom and > > > do

Re: [PATCH] member: fix PRNG seed reset in NitroSketch mode

2023-07-03 Thread Thomas Monjalon
Any comment? 20/06/2023 23:17, Dmitry Kozlyuk: > Sketch creation seeded the global PRNG > using the supplied seed for hashing. > The use of this seed by SKETCH set summary was not documented. > SKETCH set summary does not require two independent hash seeds, > unlike other set summary types. > Seed

Re: [PATCH] regex/cn9k: remove rule compiler

2023-07-03 Thread Thomas Monjalon
21/06/2023 17:33, Jerin Jacob: > On Wed, Jun 21, 2023 at 7:36 PM Thomas Monjalon wrote: > > > > Nobody knows how to build the feature. > > When the dependency "rxp_compiler" is found, > > the header file is not available: > > > > drivers/regex/cn9k/cn9k_regexdev_compiler.c:12:10: fatal error: > >

RE: [PATCH] doc: announce addition of new security IPsec SA option

2023-07-03 Thread Akhil Goyal
> Subject: [PATCH] doc: announce addition of new security IPsec SA option > > Announce addition of new security IPsec SA option to enable > out of place processing in Ingress Inline inbound SA's. > > Signed-off-by: Nithin Dabilpuram > --- > doc/guides/rel_notes/deprecation.rst | 5 + > 1 fi

RE: [PATCH] test/crypto: fix PDCP-SDAP test vectors

2023-07-03 Thread Akhil Goyal
> Subject: [PATCH] test/crypto: fix PDCP-SDAP test vectors > > Fix incorrect fields in PDCP Header. > 1. Only Data PDUs should be ciphered and authenticated. >Here the vectors are control PDUs which should not be crypto >processed. Change the D/C bit to make the vector as Data PDU > 2. Res

RE: [PATCH v3] common/qat: fix detach QAT crypto compress build

2023-07-03 Thread Akhil Goyal
> > Subject: [PATCH v3] common/qat: fix detach QAT crypto compress build > > > > qat_qp.c is a common file for QAT crypto and compress. Moved compress > > function from common file to compress QAT file qat_comp.c > > > > Bugzilla ID: 1237 > > Fixes: 2ca75c65af4c ("common/qat: build drivers from com

RE: [PATCH v2] crypto/qat: fix NULL algorithm digest placement

2023-07-03 Thread Akhil Goyal
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Monday, June 26, 2023 11:51 PM > To: Power, Ciara ; dev@dpdk.org > Cc: Power, Ciara ; Ji, Kai > Subject: [EXT] RE: [PATCH v2] crypto/qat: fix NULL algorithm digest placement > > External Email > > --

RE: [PATCH v1] crypto/qat: fix struct alignment

2023-07-03 Thread Akhil Goyal
> > Subject: [PATCH v1] crypto/qat: fix struct alignment > > > > The qat_sym_session struct variable alignment was causing a segfault. > > AES expansion keys require 16-byte alignment. Added __rte_aligned to the > > expansion keys. > > > > Fixes: ca0ba0e48129 ("crypto/qat: default to IPsec MB for c

RE: [EXT] [PATCH v4 0/3] Replace obsolote test cases.

2023-07-03 Thread Akhil Goyal
> Subject: RE: [EXT] [PATCH v4 0/3] Replace obsolote test cases. > > Series verified with openssl pmd. > > Acked-by: Gowrishankar Muthukrishnan > Series applied to dpdk-next-crypto There seems to be a false error reported by CI. Hence ignoring it. Thanks.

RE: [PATCH] doc: update mlxreg command arguments for recent versions

2023-07-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Ali Alnubani > Sent: Monday, July 3, 2023 10:48 AM > To: dev@dpdk.org > Subject: [PATCH] doc: update mlxreg command arguments for recent versions > > Recent versions of the command require vhca_id and all_vhca to be set with > the --indexes arg. > > Signe

RE: [PATCH v3] net/mlx5: fix flow workspace destruction

2023-07-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Monday, July 3, 2023 12:51 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Raslan Darawsheh > Cc: dev@dpdk.org; Gregory Etelson ; > sta...@dpdk.org; David Marchand > Subject: [PATCH v3] net/mlx5: fix flow workspace

RE: [PATCH] net/mlx5: reduce the counter pool name length

2023-07-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Friday, June 30, 2023 3:58 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Raslan Darawsheh > Cc: dev@dpdk.org; Jack Min ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: reduce the counter pool name length > > The na

RE: [PATCH] net/mlx5: fix the profile check of meter mark

2023-07-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Friday, June 30, 2023 3:45 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Raslan Darawsheh > Cc: dev@dpdk.org; Alexander Kozyrev ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix the profile check of meter mark

RE: [PATCH] common/mlx5: fix obtaining IB device in LAG mode

2023-07-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Friday, June 30, 2023 3:42 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Raslan Darawsheh > Cc: dev@dpdk.org; Rongwei Liu ; sta...@dpdk.org > Subject: [PATCH] common/mlx5: fix obtaining IB device in LAG mode > >

RE: [PATCH v3] net/mlx5: fix the error in VLAN actions creation

2023-07-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Friday, June 30, 2023 2:02 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Raslan Darawsheh > Cc: dev@dpdk.org; Gregory Etelson ; > sta...@dpdk.org > Subject: [PATCH v3] net/mlx5: fix the error in VLAN actions creat

RE: [PATCH v2] net/mlx5: fix the error set for age pool initialization

2023-07-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Friday, June 30, 2023 1:27 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Raslan Darawsheh > Cc: dev@dpdk.org; Michael Baum ; > sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix the error set for age pool initial

RE: [PATCH v5 2/2] ethdev: support xstats reset telemetry command

2023-07-03 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, 3 July 2023 09.20 > > 03/07/2023 05:58, fengchengwen: > > > > On 2023/2/20 21:05, Thomas Monjalon wrote: > > > 17/02/2023 10:44, fengchengwen: > > >> On 2023/2/16 20:54, Bruce Richardson wrote: > > >>> On Thu, Feb 16, 2023 at 08:

RE: [PATCH v4] app/testpmd: fix primary process not polling all queues

2023-07-03 Thread Ali Alnubani
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, June 27, 2023 2:05 PM > To: Jie Hai ; Ali Alnubani ; Aman > Singh ; Yuying Zhang > ; Anatoly Burakov ; > Matan Azrad ; Dmitry Kozlyuk > > Cc: dev@dpdk.org; liudongdo...@huawei.com; shiyangx...@intel.com; > Raslan Darawsheh ; NBU-C

RE: [PATCH 1/7] net/mlx5: fix the modify field check of tag

2023-07-03 Thread Bing Zhao
Hi Stephen, If I understand correctly, do you mean that the internal value and rte_flow API value may have some conflict? All the MLX5 internal enum values start from INT_MIN. When treating it as a int value, it would not have the same value with rte_flow enums, unless all the 2^^32 are defined.

RE: [PATCH v5] bitmap: add scan from offset function

2023-07-03 Thread Dumitrescu, Cristian
> -Original Message- > From: Volodymyr Fialko > Sent: Monday, July 3, 2023 1:39 PM > To: dev@dpdk.org; Dumitrescu, Cristian > Cc: jer...@marvell.com; ano...@marvell.com; tho...@monjalon.net; > Volodymyr Fialko > Subject: [PATCH v5] bitmap: add scan from offset function > > Currently,

[PATCH v5] bitmap: add scan from offset function

2023-07-03 Thread Volodymyr Fialko
Currently, in the case when we search for a bit set after a particular value, the bitmap has to be scanned from the beginning and rte_bitmap_scan() has to be called multiple times until we hit the value. Add a new rte_bitmap_scan_from_offset() function to initialize scan state at the given offset

RE: [PATCH] app/testpmd: fix invalid queue ID when start port

2023-07-03 Thread Ali Alnubani
> -Original Message- > From: Jie Hai > Sent: Monday, July 3, 2023 2:03 PM > To: Aman Singh ; Yuying Zhang > ; Ferruh Yigit ; Shiyang He > > Cc: dev@dpdk.org; liudongdo...@huawei.com; Ali Alnubani > > Subject: [PATCH] app/testpmd: fix invalid queue ID when start port > > Function update_

Re: [EXT] Re: [PATCH v3] bitmap: add scan from offset function

2023-07-03 Thread Thomas Monjalon
03/07/2023 14:02, Volodymyr Fialko: > > > -Original Message- > > From: Thomas Monjalon > > Sent: Monday, July 3, 2023 1:51 PM > > To: Dumitrescu, Cristian ; Volodymyr Fialko > > > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Anoob > > Joseph > > > > Subject: [EXT] Re: [PATCH v3] bi

[PATCH v2] set namespace prefix to threads

2023-07-03 Thread Thomas Monjalon
When looking at threads in a system, it can be confusing to find some unknown threads without a clue it is started by DPDK. Let's start all thread names with "dpdk-" plus the driver name if it comes from a driver. One more constraint: the thread names are generally limited to 16 characters, inclu

RE: [EXT] Re: [PATCH v3] bitmap: add scan from offset function

2023-07-03 Thread Volodymyr Fialko
> -Original Message- > From: Thomas Monjalon > Sent: Monday, July 3, 2023 1:51 PM > To: Dumitrescu, Cristian ; Volodymyr Fialko > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Anoob Joseph > > Subject: [EXT] Re: [PATCH v3] bitmap: add scan from offset function > > External Email >

Re: [PATCH v3] bitmap: add scan from offset function

2023-07-03 Thread Thomas Monjalon
03/07/2023 12:56, Volodymyr Fialko: > Since it's header-only library, there is issue with using __rte_intenal > (appeared in v4). What is the issue? > Even if the function itself is not used directly, it get's included to the > other public files. > It explains why other functions in this libra

Re: [PATCH] set namespace prefix to threads

2023-07-03 Thread Thomas Monjalon
03/07/2023 13:38, David Marchand: > On Mon, Jul 3, 2023 at 1:24 PM Thomas Monjalon wrote: > > > > When looking at threads in a system, it can be confusing > > to find some unknown threads without a clue it is started by DPDK. > > > > Let's start all thread names with "dpdk-" > > and the driver nam

Re: [PATCH] set namespace prefix to threads

2023-07-03 Thread David Marchand
On Mon, Jul 3, 2023 at 1:24 PM Thomas Monjalon wrote: > > When looking at threads in a system, it can be confusing > to find some unknown threads without a clue it is started by DPDK. > > Let's start all thread names with "dpdk-" > and the driver name if it comes from a driver. > > One more constr

RE: [EXT] [PATCH v4 0/3] Replace obsolote test cases.

2023-07-03 Thread Gowrishankar Muthukrishnan
Series verified with openssl pmd. Acked-by: Gowrishankar Muthukrishnan Thanks.

[PATCH] set namespace prefix to threads

2023-07-03 Thread Thomas Monjalon
When looking at threads in a system, it can be confusing to find some unknown threads without a clue it is started by DPDK. Let's start all thread names with "dpdk-" and the driver name if it comes from a driver. One more constraint: the thread names are generally limited to 16 characters, includ

[PATCH] app/testpmd: fix invalid queue ID when start port

2023-07-03 Thread Jie Hai
Function update_queue_state updates queue state of all queues of all ports, using the queue num nb_rxq|nb_txq stored locally by testpmd. Error on invalid queue ID occurs if we start testpmd with two ports and detach-attach one of them and start the other port first. That's because the attached port

RE: [dpdk-dev] [PATCH 06/10] lib/librte_pipeline: fix the use of unsafe strcpy

2023-07-03 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Friday, June 30, 2023 7:09 PM > To: Min Hu (Connor) > Cc: dev@dpdk.org; ferruh.yi...@intel.com; Dumitrescu, Cristian > ; jer...@marvell.com; > jianjay.z...@huawei.com; jia@intel.com; g.si...@nxp.com; > andrew.rybche...@oktetlab

RE: [PATCH v3] bitmap: add scan from offset function

2023-07-03 Thread Volodymyr Fialko
Since it's header-only library, there is issue with using __rte_intenal (appeared in v4). Even if the function itself is not used directly, it get's included to the other public files. It explains why other functions in this library does not have the rte_internal prefix, but the double underscor

RE: [PATCH v4] bitmap: add scan from offset function

2023-07-03 Thread Dumitrescu, Cristian
> -Original Message- > From: Volodymyr Fialko > Sent: Monday, July 3, 2023 10:31 AM > To: dev@dpdk.org; Dumitrescu, Cristian > Cc: jer...@marvell.com; ano...@marvell.com; tho...@monjalon.net; > Volodymyr Fialko > Subject: [PATCH v4] bitmap: add scan from offset function > > Currently

RE: [PATCH v3] net/mlx5: fix the error set in control tables create

2023-07-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Friday, June 30, 2023 12:47 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Raslan Darawsheh > Cc: dev@dpdk.org; Dariusz Sosnowski ; > sta...@dpdk.org > Subject: [PATCH v3] net/mlx5: fix the error set in control tab

RE: [PATCH v2] net/mlx5: fix the return value of vport action

2023-07-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Friday, June 30, 2023 12:22 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Raslan Darawsheh > Cc: dev@dpdk.org; Dariusz Sosnowski ; > sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix the return value of vport ac

RE: [PATCH v2] net/mlx5: fix the error set in Tx representor tagging

2023-07-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Friday, June 30, 2023 12:13 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Raslan Darawsheh > Cc: dev@dpdk.org; Dariusz Sosnowski ; > sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix the error set in Tx represen

Re: [PATCH] eal: fix file descriptor leakage with unhandled messages

2023-07-03 Thread Burakov, Anatoly
On 6/28/2023 1:19 PM, Viacheslav Ovsiienko wrote: The sendmsg()/recvmsg() API is used to establish communication between the DPDK processes. The API supposes inter-process file descriptors sending and conversion, the recipient sees the resulting descriptors in the received message - the operating

Re: [PATCH v14 5/6] memarea: support dump API

2023-07-03 Thread Burakov, Anatoly
On 6/28/2023 2:39 AM, Thomas Monjalon wrote: 28/06/2023 03:25, fengchengwen: Hi Anatoly, Thanks for your review, a lot of valuable advice. PS: This library stays for a long time, want to hear TB's opinion: whether to continue or stop. If continue I will push a new version. Woul

[PATCH v2 2/2] node: add UDP v4 support

2023-07-03 Thread Rakesh Kudurumalla
IPv4 UDP packets are given to application with specified UDP destination port given by user. Signed-off-by: Rakesh Kudurumalla --- doc/api/doxy-api-index.md | 3 +- doc/guides/prog_guide/graph_lib.rst | 25 ++ .../img/graph_inbuilt_node_flow.svg | 165 +

[PATCH v2 1/2] node: add IPv4 local node to handle local pkts

2023-07-03 Thread Rakesh Kudurumalla
Local or Host destined pkts can be redirected IPv4 local node using IP4 Lookup node entries with prefix of 32 and be redirected to this IP4 local node for further processing. Signed-off-by: Rakesh Kudurumalla --- Depends-on: series-28622 ("add inbuilt graph nodes data flow") v2 : - Resolve co

[PATCH v2] graph: fix graph model check in core binding

2023-07-03 Thread Zhirun Yan
Fix graph model check in core binding with graph. And rte_graph_clone() need to use valid params rather than NULL pointer. Update release notes for new mcore dispatch model. Signed-off-by: Zhirun Yan --- app/test/test_graph.c | 15 --- doc/guides/rel_notes/release_23

[PATCH v3] eal: add notes to SMP memory barrier APIs

2023-07-03 Thread Ruifeng Wang
The rte_smp_xx() APIs are deprecated. But it is not mentioned in the function header. Added notes in function header for clarification. Signed-off-by: Ruifeng Wang --- v3: Added suggested memory ordering semantic for replacement. Refined deprecation explanation. v2: Made the notes more specif

[PATCH v3] net/mlx5: fix flow workspace destruction

2023-07-03 Thread Bing Zhao
From: Gregory Etelson PMD uses pthread key to allocate and access per thread flow workspace memory buffers. PMD registered a key destructor function to clean up flow workspace buffers. However, the key destructor was not called by the pthread library. The patch keeps track of per-thread flow wo

RE: [PATCH] doc: update BIOS setting and supported HW list for NTB

2023-07-03 Thread Wu, Jingjing
> -Original Message- > From: Guo, Junfeng > Sent: Monday, July 3, 2023 5:25 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; sta...@dpdk.org; Guo, Junfeng > Subject: [PATCH] doc: update BIOS setting and supported HW list for NTB > > Update BIOS settings and supported platform list for Intel

RE: [PATCH v2 1/2] net/virtio: fix legacy device IO port map in secondary process

2023-07-03 Thread Xia, Chenbo
+Nipun > -Original Message- > From: David Marchand > Sent: Monday, July 3, 2023 4:58 PM > To: Li, Miao > Cc: dev@dpdk.org; sta...@dpdk.org; Maxime Coquelin > ; Xia, Chenbo > Subject: Re: [PATCH v2 1/2] net/virtio: fix legacy device IO port map in > secondary process > > On Mon, Jul 3,

[PATCH v4] bitmap: add scan from offset function

2023-07-03 Thread Volodymyr Fialko
Currently, in the case when we search for a bit set after a particular value, the bitmap has to be scanned from the beginning and rte_bitmap_scan() has to be called multiple times until we hit the value. Add a new rte_bitmap_scan_from_offset() function to initialize scan state at the given offset

Re: [PATCH] eal: fix file descriptor leakage with unhandled messages

2023-07-03 Thread fengchengwen
Acked-by: Chengwen Feng On 2023/6/28 20:19, Viacheslav Ovsiienko wrote: > The sendmsg()/recvmsg() API is used to establish communication between > the DPDK processes. The API supposes inter-process file descriptors > sending and conversion, the recipient sees the resulting descriptors > in the re

[PATCH] doc: update BIOS setting and supported HW list for NTB

2023-07-03 Thread Junfeng Guo
Update BIOS settings and supported platform list for Intel NTB. Fixes: f5057be340e4 ("raw/ntb: support Intel Ice Lake") Cc: sta...@dpdk.org Signed-off-by: Junfeng Guo --- doc/guides/rawdevs/ntb.rst | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --

[v2 5/5] net/mlx5/hws: support default miss action on FDB

2023-07-03 Thread Itamar Gozlan
From: Alex Vesker Add the support for default miss on HWS FDB, this implementation was missing until now. Default miss can be used for more efficient miss flow instead of going to an empty matcher or some defecated empty table. Signed-off-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_action.

[v2 4/5] net/mlx5: support symmetric RSS hash function

2023-07-03 Thread Itamar Gozlan
From: Xueming Li This patch supports symmetric hash function that creating same hash result for bi-direction traffic which having reverse source and destination IP and L4 port. Since the hash algorithom is different than spec(XOR), leave a warning in validation. Signed-off-by: Xueming Li ---

  1   2   >