RE: [PATCH] net/iavf: fix VLAN insertion in vector path

2023-06-27 Thread Zhang, Qi Z
> -Original Message- > From: Wenzhuo Lu > Sent: Wednesday, June 21, 2023 9:19 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org > Subject: [PATCH] net/iavf: fix VLAN insertion in vector path > > As the VLAN insertion is partially supported in vector path, the behavior is > diff

RE: [PATCH] net/ice: fix VLAN mode parser

2023-06-27 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Sunday, June 25, 2023 4:23 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Yang, Qiming ; sta...@dpdk.org > Subject: [PATCH] net/ice: fix VLAN mode parser > > Parser will not be ctreated if raw packet filter is not support. > This patch add N

[PATCH 2/2] bus/pci: add IO port region check before region map

2023-06-27 Thread Miao Li
This patch adds IO port region check to skip region map when doing IO port map for legacy device in sencondary process. Fixes: 33604c31354a ("vfio: refactor PCI BAR mapping") Cc: sta...@dpdk.org Signed-off-by: Miao Li --- drivers/bus/pci/linux/pci_vfio.c | 9 + 1 file changed, 9 inserti

[PATCH 1/2] net/virtio: fix legacy device IO port map in secondary process

2023-06-27 Thread Miao Li
When doing IO port map for legacy device in sencondary process, vfio_cfg setup for leagacy device like vfio_group_fd and vfio_dev_fd is missing. So, in sencondary process, rte_pci_map_device is added for legacy device to setup vfio_cfg and fill region info like in primary process. Fixes: 512e27eeb

[PATCH] doc: fix missing release note for link support

2023-06-27 Thread Kaiwen Deng
fix missing release note for link speed change support. Fixes: 36afbc269081 ("net/ice: support link speed change") Signed-off-by: Kaiwen Deng --- doc/guides/rel_notes/release_23_07.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/r

[PATCH] doc: fix missing release note for double vlan on ice

2023-06-27 Thread Mingjin Ye
Add missing release note for double vlan on ice driver. Fixes: de5da9d16430 ("net/ice: support double VLAN") Signed-off-by: Mingjin Ye --- doc/guides/rel_notes/release_23_07.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_not

RE: [PATCH v10] app/dma-perf: introduce dma-perf application

2023-06-27 Thread Ling, WeiX
> -Original Message- > From: Jiang, Cheng1 > Sent: Wednesday, June 28, 2023 9:21 AM > To: tho...@monjalon.net; Richardson, Bruce > ; m...@smartsharesystems.com; Xia, Chenbo > ; amitpraka...@marvell.com; ano...@marvell.com; > huangdeng...@huawei.com; Laatz, Kevin ; > fengcheng...@huawei.com

[PATCH] doc: fix missing release note for link support

2023-06-27 Thread kevin-intel
fix missing release note for link speed change support. Fixes: 36afbc269081 ("net/ice: support link speed change") Signed-off-by: kevin-intel --- doc/guides/rel_notes/release_23_07.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/r

[PATCH] doc: fix missing release note for double vlan on ice

2023-06-27 Thread Mingjin Ye
Add missing release note for double vlan on ice driver. Fixes: de5da9d16430 ("net/ice: support double VLAN") Signed-off-by: Mingjin Ye --- doc/guides/rel_notes/release_23_07.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_not

[PATCH] doc: fix missing release note for UFO on iavf and ice

2023-06-27 Thread Zhichao Zeng
Add missing release note for UDP fragmentation offload on iavf and ice. Fixes: 0f24dc14654e ("net/iavf: enable UDP fragmentation offload") Fixes: 623ca7a15db4 ("net/ice: enable UDP fragmentation offload") Signed-off-by: Zhichao Zeng --- doc/guides/rel_notes/release_23_07.rst | 8 1 fil

[PATCH] doc: fix missing release note for timestamp offload on iavf

2023-06-27 Thread Zhichao Zeng
Add missing release note for Rx timestamp offload on vector path. Fixes: 61b6874b9224 ("net/iavf: support Rx timestamp offload on AVX512") Signed-off-by: Zhichao Zeng --- doc/guides/rel_notes/release_23_07.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_2

RE: [EXT] [PATCH v10] app/dma-perf: introduce dma-perf application

2023-06-27 Thread Anoob Joseph
> There are many high-performance DMA devices supported in DPDK now, > and these DMA devices can also be integrated into other modules of DPDK as > accelerators, such as Vhost. Before integrating DMA into applications, > developers need to know the performance of these DMA devices in various > scen

[PATCH] doc: fix missing release note for I225 support

2023-06-27 Thread Qiming Yang
Add missing release note for I225-LMVP support. Fixes: 431d5e6dc3de ("net/igc: support I225-LMVP device") Signed-off-by: Qiming Yang --- doc/guides/rel_notes/release_23_07.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/r

[PATCH v2] doc: fix missing release note for I219 support

2023-06-27 Thread Qiming Yang
Add missing release note for I219 support Fixes: a33e1a5bcd3f ("net/e1000: support more I219 devices") Signed-off-by: Qiming Yang --- v2 changes: add fix line --- doc/guides/rel_notes/release_23_07.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/release_23_07.rs

RE: [PATCH v5] build: prevent accidentally building without NUMA support

2023-06-27 Thread Tu, Lijuan
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, June 27, 2023 9:27 PM > To: Richardson, Bruce > Cc: dev@dpdk.org; David Marchand > Subject: Re: [PATCH v5] build: prevent accidentally building without NUMA > support > > 15/06/2023 16:38, Bruce Richardson: > > When libnum

Re: [PATCH v2 2/2] net/hns3: add FDIR VLAN match mode runtime config

2023-06-27 Thread Dongdong Liu
Hi Thomas Many thanks for your review. On 2023/6/28 7:12, Thomas Monjalon wrote: 27/06/2023 09:11, Dongdong Liu: +- ``fdir_vlan_match_mode`` (default `strict`) + + Used to select VLAN match mode. This runtime config can be `strict` + or `nostrict` and is only valid for PF drives. drives? D

[PATCH] doc: add release note for new Intel devices

2023-06-27 Thread Qiming Yang
This patch add release note for new Intel devices in this release. Signed-off-by: Qiming Yang --- doc/guides/rel_notes/release_23_07.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst index 4459144

RE: [PATCH] examples/ntb: remove redundant logic for dev close

2023-06-27 Thread Guo, Junfeng
> -Original Message- > From: Guo, Junfeng > Sent: Wednesday, June 28, 2023 10:19 > To: Thomas Monjalon ; Wu, Jingjing > > Cc: dev@dpdk.org; sta...@dpdk.org; He, Xingguang > ; Laatz, Kevin ; > Richardson, Bruce > Subject: RE: [PATCH] examples/ntb: remove redundant logic for dev close >

RE: [PATCH] examples/ntb: remove redundant logic for dev close

2023-06-27 Thread Guo, Junfeng
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, June 28, 2023 08:12 > To: Wu, Jingjing ; Guo, Junfeng > > Cc: dev@dpdk.org; sta...@dpdk.org; He, Xingguang > ; Laatz, Kevin ; > Richardson, Bruce > Subject: Re: [PATCH] examples/ntb: remove redundant logic for dev close >

DPDK Tech Board call tomorrow morning 8am Pacific/11am Eastern/1500h UTC

2023-06-27 Thread Nathan Southern
Good evening DPDK Community, Tomorrow the tech board meets at 8am Pacific/11am Eastern/1500h UTC. Here is a read-only copy of our agenda: https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db And as always the link to join is: https://meet.jit.si/dpdk See you there. Thanks, Natha

[PATCH v10] app/dma-perf: introduce dma-perf application

2023-06-27 Thread Cheng Jiang
There are many high-performance DMA devices supported in DPDK now, and these DMA devices can also be integrated into other modules of DPDK as accelerators, such as Vhost. Before integrating DMA into applications, developers need to know the performance of these DMA devices in various scenarios and

Re: [PATCH v14 5/6] memarea: support dump API

2023-06-27 Thread fengchengwen
On 2023/6/28 9:39, Thomas Monjalon wrote: > 28/06/2023 03:25, fengchengwen: >> Hi Anatoly, >> >> Thanks for your review, a lot of valuable advice. >> >> PS: This library stays for a long time, want to hear TB's opinion: whether >> to continue or stop. >> If continue I will push a new ver

Re: [PATCH v14 5/6] memarea: support dump API

2023-06-27 Thread Thomas Monjalon
28/06/2023 03:25, fengchengwen: > Hi Anatoly, > > Thanks for your review, a lot of valuable advice. > > PS: This library stays for a long time, want to hear TB's opinion: whether > to continue or stop. > If continue I will push a new version. Would you be able to attend the techboard

Re: [PATCH v14 5/6] memarea: support dump API

2023-06-27 Thread fengchengwen
Hi Anatoly, Thanks for your review, a lot of valuable advice. PS: This library stays for a long time, want to hear TB's opinion: whether to continue or stop. If continue I will push a new version. Thanks. On 2023/6/22 23:55, Burakov, Anatoly wrote: > On 2/9/2023 6:36 AM, Chengwen Fen

release candidate 23.07-rc2

2023-06-27 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v23.07-rc2 There are 237 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_23_07.html There were a lot of updates in drivers. The driver features should b

Re: [PATCH] app: do not call printf in signal handlers

2023-06-27 Thread Thomas Monjalon
15/06/2023 22:14, Tyler Retzlaff: > On Mon, Jun 12, 2023 at 05:11:50PM -0700, Stephen Hemminger wrote: > > Using printf is not async-signal safe and worst case may lead to deadlock. > > Remove printf from signal handlers present in several applications. > > > > Testpmd was already fixed by > > com

Re: [dpdk-dev] [PATCH v1] doc: fix ip6 node API doxygen generation

2023-06-27 Thread Thomas Monjalon
> > Add ip6 node public API to doxygen list. > > > > Fixes: 20365d793e45 ("node: add IPv6 lookup node") > > Cc: Sunil Kumar Kori > > Cc: Amit Prakash Shukla > > Cc: Nithin Dabilpuram > > > > Signed-off-by: Jerin Jacob > > --- > > doc/api/doxy-api-index.md | 3 ++- > > 1 file changed, 2 inser

Re: [PATCH] examples/ntb: remove redundant logic for dev close

2023-06-27 Thread Thomas Monjalon
14/06/2023 07:14, Junfeng Guo: > During EAL cleanup stage, all bus devices are cleaned up properly. > Based on this, there is no need to do extra device close process, > which may call the dev ops '*dev->dev_ops->dev_close' twice. > > If this dev ops for ntb was called twice, the interrupt handle

Re: [PATCH v4] doc: prefer installing using meson rather than ninja

2023-06-27 Thread Thomas Monjalon
23/06/2023 13:43, Bruce Richardson: > After doing a build, to install DPDK system-wide our documentation > recommended using the "ninja install" command. However, for anyone > building as a non-root user and only installing as root, the "meson > install" command is a better alternative, as it provi

Re: [PATCH v2] config/ppc: fix gcc "internal compiler error" message for p10

2023-06-27 Thread Thomas Monjalon
27/06/2023 23:03, David Christensen: > Building DPDK with gcc 11.3.x for the power10 instruction set may > generate the following error: > > ../drivers/mempool/cnxk/cnxk_mempool_ops.c > during RTL pass: final > ../drivers/mempool/cnxk/cnxk_mempool_ops.c: > In function ‘cnxk_mempool_alloc’: > ../

Re: [PATCH] maintainers: update for PCI bus driver

2023-06-27 Thread Thomas Monjalon
22/06/2023 10:55, Ferruh Yigit: > On 6/15/2023 5:14 PM, Nipun Gupta wrote: > > Add myself as co-maintainer of PCI bus driver > > > > Signed-off-by: Nipun Gupta > > --- > > This patch is based on top of: > > http://patches.dpdk.org/project/dpdk/patch/20230613065738.42370-1-chenbo@intel.com/ >

Re: [PATCH v3] net/bnx2x: offer maintainership for bnx2x

2023-06-27 Thread Thomas Monjalon
We are waiting for an ack here. 02/06/2023 09:52, Julien Aube: > This is an offer to maintain the code for bnx2x-based > cards. It may not be possible on the long run due to > the old design of this chipset. > > Note that I'm not affiliated with LSI nor Broadcom and > do not have access to docume

Re: [PATCH v1] maintainers: update maintainer for DLB Driver

2023-06-27 Thread Thomas Monjalon
26/06/2023 10:04, Abdullah Sevincer: > Abdullah Sevincer is now maintainer for DLB Driver. > > Signed-off-by: Abdullah Sevincer > --- > Intel DLB2 > -M: Timothy McDaniel > +M: Abdullah Sevincer Would you be able to get an ack from Timothy?

Re: [PATCH] maintainers: update for PCI bus driver and library

2023-06-27 Thread Thomas Monjalon
13/06/2023 08:57, Chenbo Xia: > Add myself as maintainer of PCI bus driver and co-maintainer of PCI > library. > > Signed-off-by: Chenbo Xia Applied, thanks Chenbo.

Re: [PATCH v1 1/1] maintainers: update maintainership of power lib

2023-06-27 Thread Thomas Monjalon
15/06/2023 11:16, Anatoly Burakov: > Add co-maintainer for power library. > > Signed-off-by: Anatoly Burakov [...] > Power management > +M: Anatoly Burakov > M: David Hunt > F: lib/power/ > F: doc/guides/prog_guide/power_man.rst I have to ask for a word from David Hunt.

Re: [PATCH] maintainers: update for OCTEON EP and CNXK DMA

2023-06-27 Thread Thomas Monjalon
> > Marvell OCTEON TX EP - endpoint > > -M: Radha Mohan Chintakuntla > > -M: Veerasenareddy Burru > > -M: Sathesh Edara > > +M: Vamsi Attunuru > > T: git://dpdk.org/next/dpdk-next-net-mrvl > > F: drivers/net/octeon_ep/ > > F: doc/guides/nics/features/octeon_ep.ini > > @@ -1250,8 +1248,7 @@

Re: [PATCH v2 2/2] net/hns3: add FDIR VLAN match mode runtime config

2023-06-27 Thread Thomas Monjalon
27/06/2023 09:11, Dongdong Liu: > +- ``fdir_vlan_match_mode`` (default `strict`) > + > + Used to select VLAN match mode. This runtime config can be `strict` > + or `nostrict` and is only valid for PF drives. drives? Do you mean devices? > + If driver works on `strict` mode (default mode), hard

Re: [EXT] Re: [PATCH] lib: fix coverity for unused variable

2023-06-27 Thread Thomas Monjalon
27/06/2023 23:52, Thomas Monjalon: > 27/06/2023 18:05, Amit Prakash Shukla: > > From: Thomas Monjalon > > > 16/06/2023 13:06, Amit Prakash Shukla: > > > > Removed variable "rc" that stored a return value from a function > > > > rte_lpm6_lookup_bulk_func. > > > > > > You are not really removing th

Re: [PATCH v2] config/arm: add Ampere Altra/AltraMax/AmpereOne platform

2023-06-27 Thread Thomas Monjalon
16/06/2023 05:17, Ruifeng Wang: > > -Original Message- > > From: Yutang Jiang > > Sent: Thursday, June 15, 2023 7:24 PM > > To: dev@dpdk.org > > Cc: patc...@amperecomputing.com; yutang.ji...@amperecomputing.com; > > jiangyut...@os.amperecomputing.com; Ruifeng Wang ; nd > > ; > > juraj.lin

Re: [EXT] Re: [PATCH] lib: fix coverity for unused variable

2023-06-27 Thread Thomas Monjalon
27/06/2023 18:05, Amit Prakash Shukla: > Hi Thomas, > > Please find my reply inline. > > Thanks, > Amit Shukla > > > -Original Message- > > From: Thomas Monjalon > > Sent: Tuesday, June 27, 2023 7:15 PM > > To: Amit Prakash Shukla > > Cc: Nithin Kumar Dabilpuram ; Pavan Nikhilesh > > B

Re: [PATCH] config/arm: add HiSilicon hip10

2023-06-27 Thread Thomas Monjalon
27/06/2023 05:13, Ruifeng Wang: > > -Original Message- > > From: Dongdong Liu > > Sent: Monday, June 26, 2023 8:43 PM > > To: dev@dpdk.org; ferruh.yi...@amd.com; tho...@monjalon.net; Ruifeng Wang > > > > Subject: [PATCH] config/arm: add HiSilicon hip10 > > > > Adding support for HiSilico

Re: [PATCH] config/arm: add AMD CDX

2023-06-27 Thread Thomas Monjalon
16/06/2023 10:36, Ruifeng Wang: > > -Original Message- > > From: Nipun Gupta > > Sent: Friday, June 16, 2023 12:19 AM > > To: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com > > Cc: ferruh.yi...@amd.com; nikhil.agar...@amd.com; Ruifeng Wang > > ; > > Honnappa Nagarahalli ; Ni

Re: [PATCH v2 0/3] bus/cdx: fix coverity issue

2023-06-27 Thread Thomas Monjalon
19/06/2023 05:58, Nipun Gupta: > > Please use in-reply-to while sending subsequent version of patches. > > On 6/16/2023 6:09 PM, Abhijit Gangurde wrote: > > This series fixes coverity issues 385379, 385381, 385377 > > > > v2: > > - Merged coverity fix patches into series > > - Updated commit mes

[PATCH v2] config/ppc: fix gcc "internal compiler error" message for p10

2023-06-27 Thread David Christensen
Building DPDK with gcc 11.3.x for the power10 instruction set may generate the following error: ../drivers/mempool/cnxk/cnxk_mempool_ops.c during RTL pass: final ../drivers/mempool/cnxk/cnxk_mempool_ops.c: In function ‘cnxk_mempool_alloc’: ../drivers/mempool/cnxk/cnxk_mempool_ops.c:124:1: inte

[PATCH] config/ppc: fix gcc "internal compiler error" message for p10

2023-06-27 Thread David Christensen
Building DPDK with gcc 11.3.x for the power10 instruction set may generate the following error: ../drivers/mempool/cnxk/cnxk_mempool_ops.c during RTL pass: final ../drivers/mempool/cnxk/cnxk_mempool_ops.c: In function ‘cnxk_mempool_alloc’: ../drivers/mempool/cnxk/cnxk_mempool_ops.c:124:1: inte

Re: [PATCH] app/testpmd: add dump command help message

2023-06-27 Thread Ferruh Yigit
On 6/27/2023 3:44 PM, Viacheslav Ovsiienko wrote: > There was missing "dump_x" commands help message. > Patch adds support for "help dump" command to see one. > Hi Slava, Thanks for the patch, this seems missed for a while. > Signed-off-by: Viacheslav Ovsiienko > --- > app/test-pmd/cmdlin

RE: [EXT] Re: [PATCH] lib: fix coverity for unused variable

2023-06-27 Thread Amit Prakash Shukla
Hi Thomas, Please find my reply inline. Thanks, Amit Shukla > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, June 27, 2023 7:15 PM > To: Amit Prakash Shukla > Cc: Nithin Kumar Dabilpuram ; Pavan Nikhilesh > Bhagavatula ; dev@dpdk.org; Jerin Jacob > Kollanukkaran > Subject

Re: [PATCH v11 2/2] gro : add support for IPv6 GRO

2023-06-27 Thread Thomas Monjalon
21/06/2023 10:38, Kumara Parameshwaran: > Add support for IPv6 GRO for TCP packets > > Signed-off-by: Kumara Parameshwaran Did minor fixes in documentation, added review tag from Jiayu (please keep it in your patch when received) and applied, thanks.

Re: [PATCH v5] app/testpmd: add trace dump command

2023-06-27 Thread Ferruh Yigit
On 6/27/2023 2:09 PM, Viacheslav Ovsiienko wrote: > The "dump_trace" CLI command is added to trigger > saving the trace dumps to the trace directory. > > The tracing data are saved according to the EAL configuration > (explicit --trace-dir EAL command line parameter alters > the target folder to s

RE: [PATCH v4 0/5] Logging related patchs

2023-06-27 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, 27 June 2023 16.49 > > On Tue, 27 Jun 2023 09:40:01 +0200 > Morten Brørup wrote: > > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > Sent: Monday, 26 June 2023 20.42 > > > To: dev@dpdk.org > > >

Re: [PATCH v4 0/5] Logging related patchs

2023-06-27 Thread Bruce Richardson
On Tue, Jun 27, 2023 at 09:40:01AM +0200, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, 26 June 2023 20.42 > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [PATCH v4 0/5] Logging related patchs > > > > This patch set rebases and e

Re: [PATCH 0/5] cleanup in library header files

2023-06-27 Thread Thomas Monjalon
14/06/2023 16:46, Bruce Richardson: > On Wed, Jun 14, 2023 at 04:26:46PM +0200, Thomas Monjalon wrote: > > While pulling some trees for DPDK 23.07-rc1, > > I've seen that some wrong coding style for comments > > were copied over and over. > > > > In order to avoid copying wrong comment style, > >

Re: [PATCH v4 0/5] Logging related patchs

2023-06-27 Thread Stephen Hemminger
On Tue, 27 Jun 2023 09:40:01 +0200 Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, 26 June 2023 20.42 > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [PATCH v4 0/5] Logging related patchs > > > > This patch set rebases and extend

[PATCH] app/testpmd: add dump command help message

2023-06-27 Thread Viacheslav Ovsiienko
There was missing "dump_x" commands help message. Patch adds support for "help dump" command to see one. Signed-off-by: Viacheslav Ovsiienko --- app/test-pmd/cmdline.c | 43 -- 1 file changed, 41 insertions(+), 2 deletions(-) diff --git a/app/test-pmd

Re: [PATCH 0/2] support IPv4 fragment matching in transfer rules

2023-06-27 Thread Ferruh Yigit
On 6/23/2023 5:58 PM, Artemii Morozov wrote: > This patch seria adds support for matching fragment offsets for IPv4 packets, > but with some limitations. Exact matching is supported only for zero offset, > ranges are allowed for non-zero offsets. > > Artemii Morozov (2): > common/sfc_efx/base: a

Re: [PATCH] lib: fix coverity for unused variable

2023-06-27 Thread Thomas Monjalon
16/06/2023 13:06, Amit Prakash Shukla: > Removed variable "rc" that stored a return value from a function > rte_lpm6_lookup_bulk_func. You are not really removing the variable, right? It looks you just stop storing the return of this function. Whouldn't it better to check the return code? > Cove

Re: [PATCH v5] build: prevent accidentally building without NUMA support

2023-06-27 Thread Thomas Monjalon
15/06/2023 16:38, Bruce Richardson: > When libnuma development package is missing on a system, DPDK can still > be built but will be missing much-needed support for NUMA memory > management. This may later cause issues at runtime if the resulting > binary is run on a NUMA system. > > We can reduce

[PATCH v1] event/dlb2: revise QE Weight Feature

2023-06-27 Thread Abdullah Sevincer
Revise QE weight feature to enable from command line just passing a flag. If QE weight feature is enabled simply port cq weight will be same as dequeue depth. Also, update DLB documentation for revised QE weight feature and usage of eventdev application with DLB hardware. Signed-off-by: Abdullah

[PATCH v5] app/testpmd: add trace dump command

2023-06-27 Thread Viacheslav Ovsiienko
The "dump_trace" CLI command is added to trigger saving the trace dumps to the trace directory. The tracing data are saved according to the EAL configuration (explicit --trace-dir EAL command line parameter alters the target folder to save). The result dump folder gets the name like rte--MM-DD

Re: [PATCH] buildtools: remove assumption about current work dir

2023-06-27 Thread Thomas Monjalon
15/06/2023 22:24, Tyler Retzlaff: > On Wed, Jun 14, 2023 at 03:47:28PM +0100, Bruce Richardson wrote: > > According to meson documentation, we should not make any assumptions as > > to what directory a script is called from[1]. The use of "relpath" when > > processing the output of directory globbi

Re: [PATCH v2 0/2] net/hns3: add FDIR VLAN match mode runtime config

2023-06-27 Thread Ferruh Yigit
On 6/27/2023 8:11 AM, Dongdong Liu wrote: > This patchset contains two patches: > The first one is to delete duplicate macro definition for hns3. > The second one is to add FDIR VLAN match mode runtime config for hns3 > > v1->v2: > - Fix the hns3.rst doc build warining. > > Huisong Li (2): > ne

Re: [PATCH v4] app/testpmd: add trace dump command

2023-06-27 Thread Ferruh Yigit
On 6/27/2023 12:39 PM, Slava Ovsiienko wrote: >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, June 27, 2023 2:35 PM >> To: Slava Ovsiienko ; dev@dpdk.org >> Cc: jer...@marvell.com >> Subject: Re: [PATCH v4] app/testpmd: add trace dump command >> >> On 6/26/2023 12:57 PM, Viac

RE: [PATCH v4] app/testpmd: add trace dump command

2023-06-27 Thread Slava Ovsiienko
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, June 27, 2023 2:35 PM > To: Slava Ovsiienko ; dev@dpdk.org > Cc: jer...@marvell.com > Subject: Re: [PATCH v4] app/testpmd: add trace dump command > > On 6/26/2023 12:57 PM, Viacheslav Ovsiienko wrote: > > The "dump_trace" CLI comm

Re: [PATCH v4] app/testpmd: add trace dump command

2023-06-27 Thread Ferruh Yigit
On 6/26/2023 12:57 PM, Viacheslav Ovsiienko wrote: > The "dump_trace" CLI command is added to trigger > saving the trace dumps to the trace directory. > > The tracing data are saved according to the EAL configuration > (explicit --trace-dir EAL command line parameter alters > the target folder to

Re: [PATCH v2 0/5] net/mlx5: introduce Tx datapath tracing

2023-06-27 Thread Thomas Monjalon
27/06/2023 13:24, Slava Ovsiienko: > > > -Original Message- > > From: Thomas Monjalon > > Sent: Tuesday, June 27, 2023 3:46 AM > > To: Slava Ovsiienko > > Cc: dev@dpdk.org; Raslan Darawsheh ; > > rja...@redhat.com; jer...@marvell.com > > Subject: Re: [PATCH v2 0/5] net/mlx5: introduce Tx

RE: [PATCH v2 0/5] net/mlx5: introduce Tx datapath tracing

2023-06-27 Thread Slava Ovsiienko
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, June 27, 2023 3:46 AM > To: Slava Ovsiienko > Cc: dev@dpdk.org; Raslan Darawsheh ; > rja...@redhat.com; jer...@marvell.com > Subject: Re: [PATCH v2 0/5] net/mlx5: introduce Tx datapath tracing > > 20/06/2023 14:00, Raslan D

Re: [PATCH v4] app/testpmd: fix primary process not polling all queues

2023-06-27 Thread Ferruh Yigit
On 6/26/2023 10:30 AM, Jie Hai wrote: > On 2023/6/23 0:40, Ali Alnubani wrote: >>> -Original Message- >>> From: Jie Hai >>> Sent: Friday, June 9, 2023 12:04 PM >>> To: Aman Singh ; Yuying Zhang >>> ; Anatoly Burakov ; >>> Matan Azrad ; Dmitry Kozlyuk >>> >>> Cc: dev@dpdk.org; liudongdo...

RE: Ring algorithm with fewer cache misses

2023-06-27 Thread Konstantin Ananyev
Hi Morten, > Hi Honnappa, Konstantin, Bruce and Gavin, > > You might find this ring algorithm optimization article interesting: > https://rigtorp.se/ringbuffer/ > > > It adds the following optimization: > > The single-producer put() operation keeps a cache of the consumer's index. If > the

Re: [PATCH v5 2/2] test: add reassembly perf test

2023-06-27 Thread Konstantin Ananyev
rom: Pavan Nikhilesh Add reassembly perf autotest for both ipv4 and ipv6 reassembly. Each test is performed with variable number of fragments per flow, either ordered or unordered fragments and interleaved flows. Signed-off-by: Pavan Nikhilesh Reviewed-by: Amit Prakash Shukla Tested-by: Amit

Ring algorithm with fewer cache misses

2023-06-27 Thread Morten Brørup
Hi Honnappa, Konstantin, Bruce and Gavin, You might find this ring algorithm optimization article interesting: https://rigtorp.se/ringbuffer/ It adds the following optimization: The single-producer put() operation keeps a cache of the consumer's index. If the cached consumer index indicates th

Re: [PATCH v4 8/9] build: make fragmentation library optional

2023-06-27 Thread Konstantin Ananyev
23/06/2023 16:07, Bruce Richardson пишет: This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 6 -- lib/meson.build | 1 + 2 files changed, 5 insertions(+),

Re: [PATCH v4 5/9] build: make bpf library optional

2023-06-27 Thread Konstantin Ananyev
23/06/2023 16:07, Bruce Richardson пишет: This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 10 +++--- lib/meson.build | 1 + 2 files changed, 8 insertio

Re: [PATCH v5 1/2] ip_frag: optimize key compare and hash generation

2023-06-27 Thread Konstantin Ananyev
From: Pavan Nikhilesh Use optimized rte_hash_k32_cmp_eq routine for key comparison for x86 and ARM64. Use CRC instructions for hash generation on ARM64. Signed-off-by: Pavan Nikhilesh Reviewed-by: Ruifeng Wang --- On Neoverse-N2, performance improved by 10% when measured with examples/ip_r

[PATCH 2/2] net/mlx5: fix counter allocation from shared pool

2023-06-27 Thread Dariusz Sosnowski
mlx5_hws_cnt struct represents counter objects which are used in flow rules. This struct contains a union which stores the following information: - If counter object is used: - `share` is set to 1 if and only if counter object is used in an indirect action. - `age_idx` is set to the releva

[PATCH 1/2] net/mlx5: fix queue used to deallocate counter

2023-06-27 Thread Dariusz Sosnowski
When ports are configured to share flow engine resources (configured through rte_flow_configure()), counter objects used during flow rule creation are pulled directly from the shared counter pool. This is done by calling mlx5_hws_cnt_pool_get() with NULL pointer passed as queue pointer. When a flo

[PATCH 0/2] net/mlx5: fix counter object leaks

2023-06-27 Thread Dariusz Sosnowski
This patch series fixes the issue where after a long cycle of inserting/deleting flow rules using COUNT actions, mlx5_hws_cnt_pool_get() started returning either -EAGAIN or -ENOENT. Root cause of the issue was the fact that some counter objects were not properly returned to the shared counter pool.

RE: [PATCH v4 0/5] Logging related patchs

2023-06-27 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, 26 June 2023 20.42 > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [PATCH v4 0/5] Logging related patchs > > This patch set rebases and extends some earlier work on logging. > > Stephen Hemminger (5): > eal: uni

[PATCH v2 2/2] net/hns3: add FDIR VLAN match mode runtime config

2023-06-27 Thread Dongdong Liu
From: Huisong Li The VLAN number in FDIR meta data is used to enable that hardware bases on VLAN number to strictly match the input flow. And it is enabled by default. For the following two rules: rule0: pattern: eth type is 0x0806 actions: queue index 3 rule1: pattern: eth typ

[PATCH v2 1/2] net/hns3: delete duplicate macro definition

2023-06-27 Thread Dongdong Liu
From: Huisong Li This patch delete some duplicate macro definitions. Fixes: a4c7152d0581 ("net/hns3: extract common code to its own file") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.h | 7 --- 1 file changed, 7 deletions(-)

[PATCH v2 0/2] net/hns3: add FDIR VLAN match mode runtime config

2023-06-27 Thread Dongdong Liu
This patchset contains two patches: The first one is to delete duplicate macro definition for hns3. The second one is to add FDIR VLAN match mode runtime config for hns3 v1->v2: - Fix the hns3.rst doc build warining. Huisong Li (2): net/hns3: delete duplicate macro definition net/hns3: add FD