27/06/2023 18:05, Amit Prakash Shukla: > Hi Thomas, > > Please find my reply inline. > > Thanks, > Amit Shukla > > > -----Original Message----- > > From: Thomas Monjalon <tho...@monjalon.net> > > Sent: Tuesday, June 27, 2023 7:15 PM > > To: Amit Prakash Shukla <amitpraka...@marvell.com> > > Cc: Nithin Kumar Dabilpuram <ndabilpu...@marvell.com>; Pavan Nikhilesh > > Bhagavatula <pbhagavat...@marvell.com>; dev@dpdk.org; Jerin Jacob > > Kollanukkaran <jer...@marvell.com> > > Subject: [EXT] Re: [PATCH] lib: fix coverity for unused variable > > > > External Email > > > > ---------------------------------------------------------------------- > > 16/06/2023 13:06, Amit Prakash Shukla: > > > Removed variable "rc" that stored a return value from a function > > > rte_lpm6_lookup_bulk_func. > > > > You are not really removing the variable, right? > > It looks you just stop storing the return of this function. > > Whouldn't it better to check the return code? > > Yes, I am just not storing the return value. The reason to not > store return code is to avoid return code check in datapath. > rte_lpm6_lookup_bulk_func will return error only if > lpm6, ip_batch, next_hop are NULL. In function ip6_lookup_node_process_scalar > these variables will never be NULL.
I will update the commit message accordingly.
