On 6/27/2023 3:44 PM, Viacheslav Ovsiienko wrote: > There was missing "dump_xxxxx" commands help message. > Patch adds support for "help dump" command to see one. >
Hi Slava, Thanks for the patch, this seems missed for a while. > Signed-off-by: Viacheslav Ovsiienko <viachesl...@nvidia.com> > --- > app/test-pmd/cmdline.c | 43 ++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 41 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 18e6e19497..9edbb7d04f 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -92,6 +92,7 @@ static void cmd_help_brief_parsed(__rte_unused void > *parsed_result, > " help ports : Configuring ports.\n" > " help filters : Filters configuration > help.\n" > " help traffic_management : Traffic Management > commands.\n" > + " help dump : Dumps related > commands.\n" I am not sure 'dump_*' commands are unique group to make a new help section, even description is vague "dump related ..", or if they are important enough for a new section, what would you think to append them to 'display' section?
